[Lldb-commits] [PATCH] D39283: [lldb-dev] Update LLDB test cases for 'inlineStepping'

2018-01-04 Thread Carlos Alberto Enciso via Phabricator via lldb-commits
CarlosAlbertoEnciso added a comment. I have some issues running the LLDB Test Suite in 32-bit and 64-bit mode. From the LLDB documentation: https://lldb.llvm.org/test.html It is possible to customize the architecture of the test binaries and compiler used by appending -A and -C options respe

[Lldb-commits] [PATCH] D39283: [lldb-dev] Update LLDB test cases for 'inlineStepping'

2018-01-05 Thread Carlos Alberto Enciso via Phabricator via lldb-commits
CarlosAlbertoEnciso abandoned this revision. CarlosAlbertoEnciso added a comment. A new patch have been submitted for review, that fix the general issue and preserve the original test cases. https://reviews.llvm.org/D41762 https://reviews.llvm.org/D39283

[Lldb-commits] [PATCH] D39283: [lldb-dev] Update LLDB test cases for 'inlineStepping'

2017-10-25 Thread Carlos Alberto Enciso via Phabricator via lldb-commits
CarlosAlbertoEnciso created this revision. Herald added a subscriber: eraman. A patch to correct the compiler issue, where instructions associated to the function prolog are assigned line information, causing the debugger to show incorrectly the beginning of the function body, caused some tests in

[Lldb-commits] [PATCH] D39283: [lldb-dev] Update LLDB test cases for 'inlineStepping'

2017-10-26 Thread Carlos Alberto Enciso via Phabricator via lldb-commits
CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D39283#907100, @tberghammer wrote: > Hi Carlos, > > Sorry for not responding to your related e-mails lately. Hi Tamas, There is no need for apologies. You have help me a lot in setting LLDB and be able to run the test suite. (Wi

[Lldb-commits] [PATCH] D39283: [lldb-dev] Update LLDB test cases for 'inlineStepping'

2017-10-27 Thread Carlos Alberto Enciso via Phabricator via lldb-commits
CarlosAlbertoEnciso added a comment. Hi Tamas, What I have done is to use the original code (original.cpp), modified code (calling.cpp), created ELFs for both test cases before and after the compiler change and debug them using LLDB, in order to show the issue while debugging at instruction level

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

2022-12-07 Thread Carlos Alberto Enciso via Phabricator via lldb-commits
CarlosAlbertoEnciso added a comment. @Ericson2314 It seems that these changes break building on Windows using Visual Studio 2019. There are 2 issues: - CMake now creates a directory `$(Configuration)` in the root build directory. $(Configuration)\lib\cmake\llvm Location before the changes:

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

2022-12-07 Thread Carlos Alberto Enciso via Phabricator via lldb-commits
CarlosAlbertoEnciso added a comment. In D132316#3748845 , @Ericson2314 wrote: > Let's just revert this. I'll do it later today if no one beats me to it. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org