brooks added a comment.
Also broke the FreeBSD build:
/usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6
a2d010d804e895ef49932/tools/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.c
pp:338:50: error: cannot initialize a parameter of type
'lldb_private::L
brooks created this revision.
brooks added reviewers: DavidSpickett, emaste, arichardson, dim.
Herald added a subscriber: krytarowski.
Herald added a project: All.
brooks requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Commit 392d9eb03af5a1
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc0df412ad2a5: [lldb] Fix build on older FreeBSD (authored by
brooks).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147300/new/
https://reviews.llvm.org/D14
brooks added a comment.
This needs to be guarded by the presence of PT_COREDUMP since it's a new
feature. As it stands this breaks the lldb build on all supported FreeBSD
releases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109326/new/
https:/
brooks added a comment.
This patch is sufficient to let things build, but doesn't address the tests. If
there's a plan to MFC PT_COREDUMP that's probably an ok state of affairs.
https://cgit.freebsd.org/ports/tree/devel/llvm-devel/files/patch-lldb-PT_COREDUMP.diff?id=7e2f156ce907e7785863d49cbd33
brooks added a comment.
This is broken in a FreeBSD install.
CMake Error at tools/lldb/cmake_install.cmake:44 (file):
file INSTALL cannot find
"/usr/local/poudriere/ports/brooks/devel/llvm-devel/work/Releasebuild/Release/lib/python3Re
brooks added a subscriber: emaste.
brooks added a comment.
The generator is Ninja. @emaste may know of a buildbot. Note that this is an
install failure so I'm not sure if buildbots will catch it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76827
brooks added a comment.
Doing a bit of naive digging suggests to me that putting this section inside an
if (NOT CMAKE_CFG_INTDIR STREQUAL ".")
might do the trick.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76827/new/
https://reviews.llvm.or
brooks created this revision.
brooks added reviewers: emaste, omjavaid.
Herald added subscribers: lldb-commits, kristof.beyls.
Herald added a project: LLDB.
brooks requested review of this revision.
Herald added a subscriber: JDevlieghere.
Add a missing include and some definitions in rG7695332166
