[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. [LLDB] Hi, this is a patch for the proposed GSoC project "Add support for batch-testing to the LLDB testsuite". The project aimed to add continuation functionality when multiple assertions are call

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. - Ohh ok, guess I should have gotten the point about catching all exceptions recursively clarified before I began. - From looking at the code for `subTest`, the error catching functionality comes from `Outcome_object.testPartExecutor` context manager, and the rest seems t

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. Hi, bumping my post from two weeks ago. The main question I had was: would it be ok if I just brought over the Outcome object for the time being? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81697/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. > For example, the thing that's annoying me now is that whenever a test fails > in the "make" phase (e.g. a compile error), we only get an error message with > the return status, and the original make invocation. Sure thing, how should I get started(in particular where in

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. > Ideally this error should include the actual command line So to clarify, you want to also print out the exact clang command/what flags were passed to clang whenever compile errors happen? > We have lots of areas that need improvement, so we can come up with > additional

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. F12311388: image.png Hi, so I think I got the fix working. Attached is a screenshot of the new output, with title "Build Command Stdout Ouput". Should I submit a new pull request for this? Also just wondering, it seems you guys have a

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli created this revision. bbli added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch will add printing of the output of stdout during compile errors, right below output of stderr. Repository: rG LLVM Github Monorepo https://reviews.llvm

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli updated this revision to Diff 276590. bbli added a comment. Changed back to original function signature, as this method gets called once outside the class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83425/new/ https://reviews.llvm.org/D834

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. Hi Pavel, so I submitted the new patch(which I added you as a reviewer of) but it looks like the remote build failed. I ran `ninja check-lldb` locally and it works fine. How would I go about debugging this? I tried clicking on the links to the failed build, but couldn't re

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli added a comment. Hi Pavel, When I change the `stderr` argument to point to `STDOUT` inside the `Popen` function, which is inside the `lldbtest.system` function, the output actually gets mixed up. Whereas currently,, after running a couple times, the contents of stderr always gets printed

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli added a comment. Yeah so in this pic, F12338615: original.png , you can see in the code that both stdout and stderr point to PIPE, and what gets printed out is the concatenation of the two. However, in F12338626: stderr_as_stdout.png

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli updated this revision to Diff 278292. bbli added a comment. Modified stderr output instead of concatenating the stderr and stdout output strings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83425/new/ https://reviews.llvm.org/D83425 Files:

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli added a comment. Ok, I have revised the patch with the code from the first pic. I also moved the `decode` back to the `format_build_error` since it was there to begin with(not sure how much of a difference it makes). Also while we finalize this patch, is there another fix I can get started

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli added a comment. > Setting this no longer makes sense, as it will always be empty. Please remove > that. Maybe also rename stdout_content to indicate it also contains stderr. > Just plain "output" might suffice? Ok, deleted it and changed "stdout_content" to "combined_content". > this err

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli updated this revision to Diff 279122. bbli added a comment. Changed `getCompilerVersion` and a function in `TestDataFormatterSkipSummary` to account for stderr being merged with stdout now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83425/ne

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli added a comment. > I presume you don't have commit access and need someone to commit this for > you? Yup, that would be great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83425/new/ https://reviews.llvm.org/D83425 __