https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/92565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/93262
UpdateFormatsIfNeeded has hardcoded the call to GetFormat with no dynamic
values. GetFormat will try to find the synthetic children of the ValueObject,
and passing the wrong one can fail, which can be bad fo
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/93262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 requested changes to this pull request.
I think overall this looks good! Just some small things to fix.
Could you run `ninja check-lldb` from your build folder to make sure this
change doesn't break anything?
https://github.com/llvm/llvm-project/pull/102835
_
@@ -799,20 +803,21 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
sc_list);
if (auto load_addr = resolver.Resolve(sc_list))
return *load_addr;
-}
-if (sc.target_sp) {
- SymbolContextList sc_list;
-
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/102835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -785,6 +785,10 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
return LLDB_INVALID_ADDRESS;
}
+ ModuleList images = target->GetImages();
augusto2112 wrote:
Check if `target` is null before accessing it.
https://github.com/llvm/llvm-pro
@@ -785,6 +785,10 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
return LLDB_INVALID_ADDRESS;
}
+ ModuleList images = target->GetImages();
augusto2112 wrote:
Oh, looks like target is already checked right before this, disregard this
comm
augusto2112 wrote:
@DmT021 I think you can update this patch and set it ready for review then :)
https://github.com/llvm/llvm-project/pull/102835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/102835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
I agree that passing some sort of "hint" object to prioritize the search would
be a more complete solution, but since this is @DmT021's first contribution to
LLVM I think we should merge this change if there are no concerns with the
current implementation, and if @DmT021 wan
augusto2112 wrote:
> > @clayborg I can see how a module could be used as a hint, but I'm not sure
> > how we'd prioritize lookups using functions or compile unit. The code in
> > `SymTab.cpp` does a binary search to find the symbol, how could we restrict
> > this further by passing a function
augusto2112 wrote:
> Oh, wait a sec. I actually changed the behavior of the
> `IRExecutionUnit::FindInSymbols`. It used to exit early if the function was
> found in `module_sp`, but now we will always scan through the whole
> ModuleList. And we can't change the behavior of the
> `ModuleList::
@@ -441,14 +441,20 @@ ModuleSP ModuleList::GetModuleAtIndexUnlocked(size_t idx)
const {
void ModuleList::FindFunctions(ConstString name,
FunctionNameType name_type_mask,
const ModuleFunctionSearchOptions &options,
+
augusto2112 wrote:
> > > > Oh, wait a sec. I actually changed the behavior of the
> > > > `IRExecutionUnit::FindInSymbols`. It used to exit early if the function
> > > > was found in `module_sp`, but now we will always scan through the whole
> > > > ModuleList. And we can't change the behavior
augusto2112 wrote:
I agree with Michael, I think just adding the search hint and clearly
documenting it would already be a great improvement and would make implementing
this patch a lot simpler.
https://github.com/llvm/llvm-project/pull/102835
___
ll
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/106030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/74011
In some situations it may be useful to have a separate DiagnosticManager
instance, and then later of move the contents of that instance back to the
"main" DiagnosticManager. For example, when silently retryi
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/74011
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/74011
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/75102
The newly introduced LocationListLookupTestCase.test_loclist_expr test fails
with older clangs.
>From 0ec0f8ddf505ad30f8684e9452ebc4524f50a4b4 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Mon, 11 De
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/75102
>From be91ba6b5b411e2fc6b9a7b49324ef5b20c9e2ed Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Mon, 11 Dec 2023 13:38:04 -0800
Subject: [PATCH] [lldb] Disable new TestLocationListLookup when clang versio
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/75102
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/75406
None
>From 2cb9a284a924442c2f9ab8d639268b8154af22a6 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 13 Dec 2023 15:53:37 -0800
Subject: [PATCH] [lldb] Skip 2 newly introduced tests from running on
Author: Augusto Noronha
Date: 2023-08-02T15:33:32-07:00
New Revision: 5f45a87bf029cc4b9815f5f819906198b07e00d1
URL:
https://github.com/llvm/llvm-project/commit/5f45a87bf029cc4b9815f5f819906198b07e00d1
DIFF:
https://github.com/llvm/llvm-project/commit/5f45a87bf029cc4b9815f5f819906198b07e00d1.dif
Author: Augusto Noronha
Date: 2023-08-04T15:33:46-07:00
New Revision: 318f600722e3cc6745317bb68309f82656c97b27
URL:
https://github.com/llvm/llvm-project/commit/318f600722e3cc6745317bb68309f82656c97b27
DIFF:
https://github.com/llvm/llvm-project/commit/318f600722e3cc6745317bb68309f82656c97b27.dif
Author: Augusto Noronha
Date: 2023-08-04T16:01:20-07:00
New Revision: d75dc9a8a86c4f69408dcab3a21416729d14652e
URL:
https://github.com/llvm/llvm-project/commit/d75dc9a8a86c4f69408dcab3a21416729d14652e
DIFF:
https://github.com/llvm/llvm-project/commit/d75dc9a8a86c4f69408dcab3a21416729d14652e.dif
Author: Augusto Noronha
Date: 2023-08-15T11:33:34-07:00
New Revision: 4a390a56aeeb521d0eca1fa4cef6837157ea64ab
URL:
https://github.com/llvm/llvm-project/commit/4a390a56aeeb521d0eca1fa4cef6837157ea64ab
DIFF:
https://github.com/llvm/llvm-project/commit/4a390a56aeeb521d0eca1fa4cef6837157ea64ab.dif
Author: Augusto Noronha
Date: 2023-08-15T11:30:35-07:00
New Revision: 22413641e236ebee7485ce8bc5880e8d1e41573f
URL:
https://github.com/llvm/llvm-project/commit/22413641e236ebee7485ce8bc5880e8d1e41573f
DIFF:
https://github.com/llvm/llvm-project/commit/22413641e236ebee7485ce8bc5880e8d1e41573f.dif
Author: Augusto Noronha
Date: 2023-08-15T15:43:36-07:00
New Revision: 5d16957207ce1bd1a2091f3677e176012009c59a
URL:
https://github.com/llvm/llvm-project/commit/5d16957207ce1bd1a2091f3677e176012009c59a
DIFF:
https://github.com/llvm/llvm-project/commit/5d16957207ce1bd1a2091f3677e176012009c59a.dif
Author: Augusto Noronha
Date: 2023-08-15T16:03:28-07:00
New Revision: 3b919570f2f08581987de7851f3673352afb1578
URL:
https://github.com/llvm/llvm-project/commit/3b919570f2f08581987de7851f3673352afb1578
DIFF:
https://github.com/llvm/llvm-project/commit/3b919570f2f08581987de7851f3673352afb1578.dif
Author: Augusto Noronha
Date: 2023-08-18T16:53:26-07:00
New Revision: bb90063249707e3ae081bfbd8e3512566abb7df6
URL:
https://github.com/llvm/llvm-project/commit/bb90063249707e3ae081bfbd8e3512566abb7df6
DIFF:
https://github.com/llvm/llvm-project/commit/bb90063249707e3ae081bfbd8e3512566abb7df6.dif
Author: Augusto Noronha
Date: 2023-08-18T16:55:37-07:00
New Revision: 79a8e006dbc4ea281e9ec5933f484e476db3d9ab
URL:
https://github.com/llvm/llvm-project/commit/79a8e006dbc4ea281e9ec5933f484e476db3d9ab
DIFF:
https://github.com/llvm/llvm-project/commit/79a8e006dbc4ea281e9ec5933f484e476db3d9ab.dif
Author: Augusto Noronha
Date: 2023-08-22T11:14:04-07:00
New Revision: fef609d2d1da573150121a6ee897e1d90f235eb1
URL:
https://github.com/llvm/llvm-project/commit/fef609d2d1da573150121a6ee897e1d90f235eb1
DIFF:
https://github.com/llvm/llvm-project/commit/fef609d2d1da573150121a6ee897e1d90f235eb1.dif
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/66286:
Value::ResolveValue calls Value::GetValueAsData as part of its implementation.
The latter can receive an optional Module pointer, which is always null when
called from the former. Allow threading in the Mod
https://github.com/augusto2112 review_requested
https://github.com/llvm/llvm-project/pull/66286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 review_requested
https://github.com/llvm/llvm-project/pull/66286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/66286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
@clayborg as Adrian said, this fixes a test failure downstream. I don't there's
any visible change in behavior to test in main, unfortunately.
https://github.com/llvm/llvm-project/pull/66286
___
lldb-commits mailing list
lldb-commit
augusto2112 wrote:
> > @clayborg as Adrian said, this fixes a test failure downstream. I don't
> > there's any visible change in behavior to test in main, unfortunately.
>
> Gotcha. Let me guess: Swift? :-)
Exactly :)
https://github.com/llvm/llvm-project/pull/66286
___
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/66826
When setting conditional breakpoints, we currently assume that a call to
UserExpression::Parse() can be cached and resued multiple times. This may not
be true for every user expression. Add a new method so s
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
Author: Augusto Noronha
Date: 2023-09-25T11:17:42-07:00
New Revision: 962ef991da2836775191435fb732fc61ec07d5e6
URL:
https://github.com/llvm/llvm-project/commit/962ef991da2836775191435fb732fc61ec07d5e6
DIFF:
https://github.com/llvm/llvm-project/commit/962ef991da2836775191435fb732fc61ec07d5e6.dif
Author: Augusto Noronha
Date: 2022-01-28T13:08:30-03:00
New Revision: b414954a5f1c2f8f6adecf20e5a433dfbc320cc2
URL:
https://github.com/llvm/llvm-project/commit/b414954a5f1c2f8f6adecf20e5a433dfbc320cc2
DIFF:
https://github.com/llvm/llvm-project/commit/b414954a5f1c2f8f6adecf20e5a433dfbc320cc2.dif
Author: Augusto Noronha
Date: 2022-07-07T13:11:50-07:00
New Revision: 5ade38c28573b92b8b0bfd1fe7feef2fbea76ddf
URL:
https://github.com/llvm/llvm-project/commit/5ade38c28573b92b8b0bfd1fe7feef2fbea76ddf
DIFF:
https://github.com/llvm/llvm-project/commit/5ade38c28573b92b8b0bfd1fe7feef2fbea76ddf.dif
Author: Augusto Noronha
Date: 2022-07-22T16:00:51-07:00
New Revision: 3b8a1cc38ab72afe6889f3c1fff7c3deb8ac26ec
URL:
https://github.com/llvm/llvm-project/commit/3b8a1cc38ab72afe6889f3c1fff7c3deb8ac26ec
DIFF:
https://github.com/llvm/llvm-project/commit/3b8a1cc38ab72afe6889f3c1fff7c3deb8ac26ec.dif
Author: Augusto Noronha
Date: 2022-07-22T16:06:49-07:00
New Revision: c18304e60067b904941fbcfb3ca1649798b242f6
URL:
https://github.com/llvm/llvm-project/commit/c18304e60067b904941fbcfb3ca1649798b242f6
DIFF:
https://github.com/llvm/llvm-project/commit/c18304e60067b904941fbcfb3ca1649798b242f6.dif
Author: Augusto Noronha
Date: 2022-07-23T15:37:26-07:00
New Revision: 2622c5e212646d1c8d6a43444d7c5b551f0221ad
URL:
https://github.com/llvm/llvm-project/commit/2622c5e212646d1c8d6a43444d7c5b551f0221ad
DIFF:
https://github.com/llvm/llvm-project/commit/2622c5e212646d1c8d6a43444d7c5b551f0221ad.dif
Author: Augusto Noronha
Date: 2022-07-26T13:02:51-07:00
New Revision: 5ee910fef52448c141d0cd2507cee29432541cda
URL:
https://github.com/llvm/llvm-project/commit/5ee910fef52448c141d0cd2507cee29432541cda
DIFF:
https://github.com/llvm/llvm-project/commit/5ee910fef52448c141d0cd2507cee29432541cda.dif
Author: Augusto Noronha
Date: 2022-08-03T10:55:32-07:00
New Revision: 3aef968ec3faada22319aaa3530776974082d2d5
URL:
https://github.com/llvm/llvm-project/commit/3aef968ec3faada22319aaa3530776974082d2d5
DIFF:
https://github.com/llvm/llvm-project/commit/3aef968ec3faada22319aaa3530776974082d2d5.dif
Author: Augusto Noronha
Date: 2022-08-03T11:57:33-07:00
New Revision: 1f64f8bcabb65c9622386d7458e42ee33b2eb7dc
URL:
https://github.com/llvm/llvm-project/commit/1f64f8bcabb65c9622386d7458e42ee33b2eb7dc
DIFF:
https://github.com/llvm/llvm-project/commit/1f64f8bcabb65c9622386d7458e42ee33b2eb7dc.dif
Author: Augusto Noronha
Date: 2022-08-11T09:28:30-07:00
New Revision: c6c5944d05e81b5c7f48abea22a98389b1204a33
URL:
https://github.com/llvm/llvm-project/commit/c6c5944d05e81b5c7f48abea22a98389b1204a33
DIFF:
https://github.com/llvm/llvm-project/commit/c6c5944d05e81b5c7f48abea22a98389b1204a33.dif
Author: Augusto Noronha
Date: 2022-12-22T10:15:20-08:00
New Revision: f85cc6009aa790dd9970981408401072702ea886
URL:
https://github.com/llvm/llvm-project/commit/f85cc6009aa790dd9970981408401072702ea886
DIFF:
https://github.com/llvm/llvm-project/commit/f85cc6009aa790dd9970981408401072702ea886.dif
Author: Augusto Noronha
Date: 2023-01-09T10:27:18-08:00
New Revision: 1d6243db90b09c61d78a14268bb88a73792b63ab
URL:
https://github.com/llvm/llvm-project/commit/1d6243db90b09c61d78a14268bb88a73792b63ab
DIFF:
https://github.com/llvm/llvm-project/commit/1d6243db90b09c61d78a14268bb88a73792b63ab.dif
Author: Augusto Noronha
Date: 2023-01-17T10:30:29-08:00
New Revision: 7ef075a6d7a2bccbeedb9b5a1689e8545d5753e9
URL:
https://github.com/llvm/llvm-project/commit/7ef075a6d7a2bccbeedb9b5a1689e8545d5753e9
DIFF:
https://github.com/llvm/llvm-project/commit/7ef075a6d7a2bccbeedb9b5a1689e8545d5753e9.dif
Author: Augusto Noronha
Date: 2023-01-20T13:02:04-08:00
New Revision: 901ba0fcae3651c81051fd8da2695bbc2bcb3c91
URL:
https://github.com/llvm/llvm-project/commit/901ba0fcae3651c81051fd8da2695bbc2bcb3c91
DIFF:
https://github.com/llvm/llvm-project/commit/901ba0fcae3651c81051fd8da2695bbc2bcb3c91.dif
Author: Augusto Noronha
Date: 2023-02-10T17:19:21-08:00
New Revision: 294ca122956f78aef3ab4e81108b69518e353b07
URL:
https://github.com/llvm/llvm-project/commit/294ca122956f78aef3ab4e81108b69518e353b07
DIFF:
https://github.com/llvm/llvm-project/commit/294ca122956f78aef3ab4e81108b69518e353b07.dif
Author: Augusto Noronha
Date: 2023-02-10T17:32:48-08:00
New Revision: 29fa21eb61293e677a8de4bacd843ef57192b60b
URL:
https://github.com/llvm/llvm-project/commit/29fa21eb61293e677a8de4bacd843ef57192b60b
DIFF:
https://github.com/llvm/llvm-project/commit/29fa21eb61293e677a8de4bacd843ef57192b60b.dif
Author: Augusto Noronha
Date: 2023-03-08T14:18:40-08:00
New Revision: 581ac50d58b99a37244e9d4e0d8d12c9c810f472
URL:
https://github.com/llvm/llvm-project/commit/581ac50d58b99a37244e9d4e0d8d12c9c810f472
DIFF:
https://github.com/llvm/llvm-project/commit/581ac50d58b99a37244e9d4e0d8d12c9c810f472.dif
Author: Augusto Noronha
Date: 2023-03-18T10:33:14-07:00
New Revision: f03cd763384bbb67ddfa12957859ed58841d4b34
URL:
https://github.com/llvm/llvm-project/commit/f03cd763384bbb67ddfa12957859ed58841d4b34
DIFF:
https://github.com/llvm/llvm-project/commit/f03cd763384bbb67ddfa12957859ed58841d4b34.dif
Author: Augusto Noronha
Date: 2023-04-10T10:13:06-07:00
New Revision: 19d969e340c9e1b5a83ad5220ba0875393df71e2
URL:
https://github.com/llvm/llvm-project/commit/19d969e340c9e1b5a83ad5220ba0875393df71e2
DIFF:
https://github.com/llvm/llvm-project/commit/19d969e340c9e1b5a83ad5220ba0875393df71e2.dif
Author: Augusto Noronha
Date: 2023-05-18T10:29:15-07:00
New Revision: 8fe9718dd5f27168fc282c6420bfae0eb7ee6819
URL:
https://github.com/llvm/llvm-project/commit/8fe9718dd5f27168fc282c6420bfae0eb7ee6819
DIFF:
https://github.com/llvm/llvm-project/commit/8fe9718dd5f27168fc282c6420bfae0eb7ee6819.dif
Author: Augusto Noronha
Date: 2023-06-08T13:30:30-07:00
New Revision: b1ebfc5de34ef4c91aa6f163989de600fb5227f8
URL:
https://github.com/llvm/llvm-project/commit/b1ebfc5de34ef4c91aa6f163989de600fb5227f8
DIFF:
https://github.com/llvm/llvm-project/commit/b1ebfc5de34ef4c91aa6f163989de600fb5227f8.dif
Author: Augusto Noronha
Date: 2023-06-13T11:03:04-07:00
New Revision: f94c7ffe46400559740e7f81d7c60d8c0fe7df82
URL:
https://github.com/llvm/llvm-project/commit/f94c7ffe46400559740e7f81d7c60d8c0fe7df82
DIFF:
https://github.com/llvm/llvm-project/commit/f94c7ffe46400559740e7f81d7c60d8c0fe7df82.dif
Author: Augusto Noronha
Date: 2021-09-16T16:38:20-03:00
New Revision: 47dd1f642846d476e3d789f4aa941699dc0ed3fe
URL:
https://github.com/llvm/llvm-project/commit/47dd1f642846d476e3d789f4aa941699dc0ed3fe
DIFF:
https://github.com/llvm/llvm-project/commit/47dd1f642846d476e3d789f4aa941699dc0ed3fe.dif
Author: Augusto Noronha
Date: 2021-09-16T17:49:59-03:00
New Revision: 8fb86011026c56204e54a2806d598249c6297d08
URL:
https://github.com/llvm/llvm-project/commit/8fb86011026c56204e54a2806d598249c6297d08
DIFF:
https://github.com/llvm/llvm-project/commit/8fb86011026c56204e54a2806d598249c6297d08.dif
Author: Augusto Noronha
Date: 2021-09-23T16:45:04-03:00
New Revision: fbaf36721783c3bcbd45f81294e6980eaef165e4
URL:
https://github.com/llvm/llvm-project/commit/fbaf36721783c3bcbd45f81294e6980eaef165e4
DIFF:
https://github.com/llvm/llvm-project/commit/fbaf36721783c3bcbd45f81294e6980eaef165e4.dif
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/69762
None
>From 2cc3dc43d5ef705a016b8b7b3c23d99d5f01a5d8 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Fri, 20 Oct 2023 12:42:52 -0700
Subject: [PATCH] [lldb][NFC] Implement llvm-style RTTI for DWARFASTPar
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/69764
None
>From c97e0b62a2df5309db707861b5f1fd2c223ac50b Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Fri, 20 Oct 2023 12:59:00 -0700
Subject: [PATCH] [lldb][NFC] Move GetTypeForDIE from to DWARFASTParser
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/69793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/69762
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/69764
>From d84b4b293a97b75a34e4208c914988a2e5231d66 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Fri, 20 Oct 2023 12:59:00 -0700
Subject: [PATCH] [lldb][NFC] Move GetTypeForDIE from to DWARFASTParser
---
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/69984
None
>From 2500e7fadc72c56a887b27d5f271bea5af70ccab Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Mon, 23 Oct 2023 16:35:24 -0700
Subject: [PATCH] [lldb][NFC] Remote reference to Swift in DWARFASTPars
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/69984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/69764
>From 040c4f4d98f3306e068521e3c218bdbc170f81f3 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Fri, 20 Oct 2023 12:59:00 -0700
Subject: [PATCH] [lldb][NFC] Move DWARFASTParserClang::GetTypeForDIE to
DWA
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/69764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/69764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/69990
The "protected" was accidentally removed during refactoring of SymbolFileDWARF.
Reintroduce it and also make DWARFASTParser a friend class since
040c4f4d98f3306e068521e3c218bdbc170f81f3 was merged and won't
@@ -321,6 +322,7 @@ class SymbolFileDWARF : public SymbolFileCommon {
m_file_index = file_index;
}
+protected:
augusto2112 wrote:
Can't we merge it and then you can open your isolated patch with the methods
you want to expose? Right now everything is p
@@ -321,6 +322,7 @@ class SymbolFileDWARF : public SymbolFileCommon {
m_file_index = file_index;
}
+protected:
augusto2112 wrote:
I think the big issue on keeping everything public is that will will use those
methods without realizing they were suppose
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/69990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/70062
When moving the GetTypeForDIE function from DWARFASTParserClang to
DWARFASTParser, I kept the signature as-is. To match the rest of the function
signatures in DWARFASTParser, remove the full name
(lldb_priv
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/70062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/70157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/69741
>From b34b8f1786a6fb274710c5e4318bad83b04b0480 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Fri, 20 Oct 2023 10:18:03 -0700
Subject: [PATCH] Fix size in bytes of type DIEs when size in bits is not a
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/69741
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
@dwblaikie I talked with Adrian, his idea is to emit the size in bits whenever
it does not cleanly fit in a byte. His point (and I agree) is that there may be
tools that can use this bit size, and if we always round up when emitting the
DWARF we will lose this information, w
@@ -2210,9 +2216,16 @@ bool DWARFASTParserClang::CompleteRecordType(const
DWARFDIE &die,
!layout_info.vbase_offsets.empty()) {
if (type)
layout_info.bit_size = type->GetByteSize(nullptr).value_or(0) * 8;
-if (layout_info.bit_size == 0)
- layout_info.bi
@@ -2866,8 +2879,12 @@ void DWARFASTParserClang::ParseSingleMember(
// Get the parent byte size so we can verify any members will fit
const uint64_t parent_byte_size =
parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size, UINT64_MAX);
- const uint64_t parent_bit_si
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/69741
>From 997da625fda1efebde43ec965c23c1a8ef9c0132 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Fri, 10 Nov 2023 10:40:05 -0800
Subject: [PATCH] Emit DIE's size in bits when size is not a multiple of 8
T
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/69741
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
> I guess one question that might be relevant - does Swift have something like
> sizeof and what result does it give for these sort of types with bits to
> spare?
You can't actually use that with these types as these are special compiler
builtin types which aren't actually
augusto2112 wrote:
@DavidSpickett thanks for reminding me. I'll add a comment describing the
situation.
Right now, for conditional breakpoints, we assume that the condition expression
is cacheable, since it's being run over and over again in the exact same
context. This works for C/C++, but
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/66826
>From fcc27c3b81a8f2c0566af801e623d23f748fb04a Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Tue, 19 Sep 2023 13:27:41 -0700
Subject: [PATCH] [lldb] Add interface to check if UserExpression::Parse() is
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/66826
>From 5323ac957268e469207aae340e15f6809b53bf53 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 16 Nov 2023 11:31:55 -0800
Subject: [PATCH] [lldb] Add interface to check if UserExpression::Parse() is
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/66826
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Augusto Noronha
Date: 2022-10-19T13:49:40-07:00
New Revision: 6f2423c6fe97bec77da66d87a7a997917f6b489e
URL:
https://github.com/llvm/llvm-project/commit/6f2423c6fe97bec77da66d87a7a997917f6b489e
DIFF:
https://github.com/llvm/llvm-project/commit/6f2423c6fe97bec77da66d87a7a997917f6b489e.dif
Author: Augusto Noronha
Date: 2022-10-24T12:12:36-07:00
New Revision: 7590776b852f28ba8d569e17d989060f33d0e7a3
URL:
https://github.com/llvm/llvm-project/commit/7590776b852f28ba8d569e17d989060f33d0e7a3
DIFF:
https://github.com/llvm/llvm-project/commit/7590776b852f28ba8d569e17d989060f33d0e7a3.dif
Author: Augusto Noronha
Date: 2022-10-28T15:04:24-07:00
New Revision: b3b517d572391d9799d1f29bddd66e2bad1acb54
URL:
https://github.com/llvm/llvm-project/commit/b3b517d572391d9799d1f29bddd66e2bad1acb54
DIFF:
https://github.com/llvm/llvm-project/commit/b3b517d572391d9799d1f29bddd66e2bad1acb54.dif
1 - 100 of 182 matches
Mail list logo
