[Lldb-commits] [PATCH] D152409: [lldb] Never print children if the max depth has been reached

augusto2112 created this revision. augusto2112 added reviewers: aprantl, kastiglione. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When formatting a variable, the max depth would potentially be ig

[Lldb-commits] [PATCH] D152409: [lldb] Never print children if the max depth has been reached

augusto2112 updated this revision to Diff 529673. augusto2112 added a comment. Remove failure check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152409/new/ https://reviews.llvm.org/D152409 Files: lldb/include/lldb/DataFormatters/ValueObjectPri

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 updated this revision to Diff 529709. augusto2112 marked an inline comment as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 Files: lld

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1ebfc5de34e: [lldb] Unconditionally increment depth when printing children (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/n

[Lldb-commits] [PATCH] D152409: [lldb] Never print children if the max depth has been reached

This revision was automatically updated to reflect the committed changes. Closed by commit rGf94c7ffe4640: [lldb] Never print children if the max depth has been reached (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D152409?vs=529673&id=530994#toc Repository: rG

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 created this revision. augusto2112 added reviewers: kastiglione, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Lots of users use "po" as their default print command. If the typ

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added a comment. Herald added subscribers: Michael137, JDevlieghere. @kastiglione I wonder if we should hint in all 3 command objects (expr, frame var and DWIM) or if we should limit this to DWIM instead (since DWIM is the one aliased to p and po and I don't think `vo` or `expr -O`

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 updated this revision to Diff 535561. augusto2112 marked 5 inline comments as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 Files: lld

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. I've bumped into this problem before, so really like this change. It's a bit sad that you'll only print the kind of data formatter once though, so someone reading the logs might have

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

augusto2112 added a comment. Personally I vote for the formatter kind on every line, so we don't need to jump around the logs when reading them, up to you though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D109336: [lldb] Skip TestAppleSimulatorOSType if json parsing fails

augusto2112 created this revision. augusto2112 added reviewers: teemperor, aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. xcodebuild, which is invoked by the apple_simulator_test decorator, may may return a successful

[Lldb-commits] [PATCH] D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully

augusto2112 created this revision. augusto2112 added reviewers: aprantl, labath. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If we applied a fix-it before evaluating an expression and that expression didn't evaluate correctl

[Lldb-commits] [PATCH] D109336: [lldb] Skip TestAppleSimulatorOSType if json parsing fails

This revision was automatically updated to reflect the committed changes. Closed by commit rG47dd1f642846: [lldb] Skip TestAppleSimulatorOSType if json parsing fails (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109336/new/

[Lldb-commits] [PATCH] D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully

augusto2112 updated this revision to Diff 374338. augusto2112 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109908/new/ https://reviews.llvm.org/D109908 Files: lldb/source/Commands/CommandObjectExpression.cpp lldb/tes

[Lldb-commits] [PATCH] D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully

augusto2112 added a comment. In D109908#3004789 , @teemperor wrote: > Could you add a test for that? The usual test fixit in Clang is `.`/`->` > mixup, e.g. > > (lldb) expr struct Foo { int i; }; Foo *f; f.i ; > unknown_identifier_for_fatal_error >

[Lldb-commits] [PATCH] D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbaf36721783: [lldb] Show fix-it applied even if expression didn't evaluate succesfully (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jasonmolenda, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Currently,

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 468337. augusto2112 added a comment. Remote extra semi-colon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136114/new/ https://reviews.llvm.org/D136114 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFCo

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 468729. augusto2112 added a comment. Herald added subscribers: ormris, steven_wu, hiraditya. Added test, changed DWARFCompileUnit::BuildAddressRangeTable to not stop looking at oso ranges at offset 0. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 marked 6 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:644 + if (&comp_unit == extra.get()) + return &m_compile_unit_infos[i]; } aprantl wrote:

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 468750. augusto2112 marked an inline comment as done. augusto2112 added a comment. Add a map from compile unit id to index in vector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136114/new/ https://review

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 469032. augusto2112 added a comment. Updated default stack size of the cu containers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136114/new/ https://reviews.llvm.org/D136114 Files: lldb/source/Plugins/

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f2423c6fe97: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

augusto2112 created this revision. augusto2112 added reviewers: mib, JDevlieghere, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The python "open" function will use the default encoding fo

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

augusto2112 updated this revision to Diff 471662. augusto2112 added a comment. Added encoding parameter to all "open" calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136798/new/ https://reviews.llvm.org/D136798 Files: lldb/examples/python/cr

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b517d57239: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py (authored by augusto2112). Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit

augusto2112 accepted this revision. augusto2112 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103439/new/ https://reviews.llvm.org/D103439 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 created this revision. augusto2112 added reviewers: jasonmolenda, aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On mach-O, if an object file is eligible to be in the shared cache, it cannot have data read

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 added a comment. Hi Jason, I could place this check on the caller, but I think here is the right place for it, maybe I can convince you. > the perf impact of forcing all reads to be out of memory would be > dramatically bad for a remote system debug session, this can't be done. On

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 added a comment. In D106584#2901529 , @vsk wrote: > Hey Augusto, thanks for tackling this, I'm just now slowly paging things in. > > Is this a correct statement of the problem: LLDB is failing to disable its > file cache optimization when rea

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 updated this revision to Diff 361991. augusto2112 added a comment. Keep only filecache and live memory equality assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 Files: lldb/include/

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

augusto2112 updated this revision to Diff 362435. augusto2112 added a comment. Add setting to enable assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 Files: lldb/include/lldb/Core/Section.h lldb

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

augusto2112 updated this revision to Diff 362523. augusto2112 added a comment. Run file-cache verification on tests, change raw buffer to unique pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 Fil

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

augusto2112 updated this revision to Diff 362735. augusto2112 added a comment. Add test to test/Shell/lit-lldb-init.in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 Files: lldb/include/lldb/Core/Secti

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

augusto2112 closed this revision. augusto2112 added a comment. Commit 77e9d10f0fbfe04a14e6ce61753376dd78e0c2f0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://

[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some lldb tests are failing intermittently due to the check for simulators failing for some reason unrela

[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

augusto2112 added a comment. The error that happens in xcodebuild is: 2021-08-30 16:54:51.925 xcodebuild[95554:469108] DVTDownloadable: Failed to get authorization with error Error Domain=DVTDownloadableErrors Code=3 "The authorization was denied since no user interaction was possible." Use

[Lldb-commits] [PATCH] D100263: [lldb] [gdb-remote client] Remove breakpoints in forked processes

augusto2112 added a comment. Hi. It looks like the fork-follow-parent-softbp test is failing on CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100263/new/ https://reviews.llvm.org/D10

[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

augusto2112 added a comment. My initial thought was that xcodebuild is throwing some other error (maybe, for some reason, it times out, which is a `subprocess.TimeoutExpired` exception), which is why my solution was to catch //any// exception thrown by `subprocess.check_output`. Many the secur

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 updated this revision to Diff 329385. augusto2112 marked 7 inline comments as done and an inline comment as not done. augusto2112 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96176/new/ https://reviews

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 added a comment. In D96176#2546777 , @labath wrote: > I'm not sure this new functionality is really worth the new packet (or two), > but if it solves a use case you care about, then I suppose that's fine. To be honest, I started this as I tho

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jasonmolenda. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100338 Files: lldb/includ

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 added a comment. Thanks for the input @jasonmolenda. FWIW I also think it's worth implementing this correctly. Could you help me figure out which callers I should change to `force_live_memory` though? Here's a list of everywhere ReadMemory is called: SBTarget.cpp ReadInstr

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 added a comment. @jasonmolenda actually, most of them are passing `prefer_file_cache = false`, unfortunately. But they might be doing this because there's they weren't sure if the memory was writable, so this was the safer option. I want to change all the ones we deem safe to `force

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

augusto2112 created this revision. augusto2112 added reviewers: jingham, jasonmolenda, clayborg. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100500 Files: l

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

augusto2112 added a comment. Herald added a subscriber: JDevlieghere. This patch introduces a new setting on ProcessGDBRemote to allow artificially slowing down the communication betwenn lldb and the server. The new setting sleeps `PacketDelayMultiplier` nanoseconds per byte read or written in

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 updated this revision to Diff 337558. augusto2112 added a comment. Herald added subscribers: atanasyan, MaskRay, jrtc27, sdardis, emaste. Changed the approach from a target setting to updating Target::ReadMemory to prefer the file cache (if section is read-only) Repository: rG LLV

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 added a comment. @jasonmolenda I've updated all the function calls to prefer the file cache (except the one you pointed out), but I'm a little worried about this, since I changed a lot of function calls. Maybe I could update the function signature to `force_live_memory` (and default

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 updated this revision to Diff 337735. augusto2112 added a comment. Updates all calls to ReadMemory to keep the current behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100338/new/ https://reviews.llvm.org/D100338 Files: lldb/i

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

augusto2112 added a comment. Hey @jasonmolenda thanks for the input, and nice empirical experiment! Do you think simply adding a setting that sleeps by a constant amount would be enough to model this problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D100850: Fix reading from file cache using address instead of resolved address for getting a section

augusto2112 created this revision. augusto2112 added a reviewer: jasonmolenda. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fiex a small problem with https://reviews.llvm.org/D100338 where we'd grab the section from the

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 created this revision. augusto2112 added reviewers: jasonmolenda, jingham. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change ensures that if for whatever reason we read less bytes than expected (for exampl

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 added inline comments. Comment at: lldb/source/Target/Target.cpp:1778 +else if (file_cache_bytes_read > 0) { + file_cache_read_buffer.reset(malloc(file_cache_bytes_read)); + std::memcpy(file_cache_read_buffer.get(), dst, file_cache_bytes_rea

[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jasonmolenda, jingham. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A type system is not guaranteed to have a symbol file. This patch adds null-pointer

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 updated this revision to Diff 341532. augusto2112 added a comment. Change buffer unique pointer from void to uint8_t, eliminating the need to call malloc/free. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101390/new/ https://reviews.l

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 marked 2 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Target/Target.cpp:1778 +else if (file_cache_bytes_read > 0) { + file_cache_read_buffer.reset(malloc(file_cache_bytes_read)); + std::memcpy(file_cache

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 updated this revision to Diff 341550. augusto2112 marked an inline comment as done. augusto2112 added a comment. Rely on `unique_ptr`'s bool operator, instead of checking the underlying pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 marked 2 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Target/Target.cpp:1818 - if (!is_readonly && resolved_addr.IsSectionOffset()) { + if (file_cache_read_buffer.get() && file_cache_bytes_read > 0) { +// Reading from the

[Lldb-commits] [PATCH] D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101585/new/ https://reviews.llvm.org/D101585

[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

augusto2112 updated this revision to Diff 344151. augusto2112 added a comment. Add GetExeModuleWhenMissingSymbolFile tesst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101539/new/ https://reviews.llvm.org/D101539 Files: lldb/source/Plugins/Sym

[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

augusto2112 added a comment. @teemperor let me know if this test is OK, or if there's a better way to test this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101539/new/ https://reviews.llvm.org/D101539

[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

augusto2112 updated this revision to Diff 344368. augusto2112 added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101539/new/ https://reviews.llvm.org/D101539 Files: lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp ll

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. augusto2112 marked an inline comment as done. Closed by commit rG6c82b8a378a6: Change Target::ReadMemory to ensure the amount of memory read from the file… (authored by

[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec28e43e0154: Add null-pointer checks when accessing a TypeSystem's SymbolFile (authored by augusto2112). Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 created this revision. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93895 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationSer

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. Hi guys. I recently ran into an issue where I couldn't use --waitfor on Linux. I found out that there's a patch that adds the functionality which was only missing a test (https://reviews.llvm.org/D47879), so I decided to pick up from where it left. @labath I added

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 updated this revision to Diff 313954. augusto2112 added a comment. Fix formatting issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93895/new/ https://reviews.llvm.org/D93895 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemote

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. Hi @labath. I see! I changed it to `lldbgdbserverutils.gdbremote_hex_encode_string`. Looking at the logs, I found that the checksum I inserted was wrong, so I've corrected that as well (is there a way I can calculate the checksum on the test, instead of hard-coding

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 updated this revision to Diff 314230. augusto2112 added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93895/new/ https://reviews.llvm.org/D93895 Files: lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.p

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 updated this revision to Diff 314231. augusto2112 added a comment. Re-include deleted files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93895/new/ https://reviews.llvm.org/D93895 Files: lldb/source/Plugins/Process/gdb-remote/GDBRe

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. Hi @labath. Ok, I believe the test is passing now. Thank you for all the help today! Question: the original author left a TODO: // TODO: Make the polling interval configurable std::chrono::milliseconds waitfor_interval = std::chrono::seconds(1); Is this a lot

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 updated this revision to Diff 314258. augusto2112 added a comment. Fix issues pointed out in comments left in previous patch, and clean the code a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93895/new/ https://reviews.llvm.org/D9

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:344 + // TODO: Make the polling interval configurable. + std::chrono::milliseconds polling_interval = std::chrono::seconds(1); + clayborg

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 updated this revision to Diff 314641. augusto2112 added a comment. Herald added a subscriber: dang. Adds support to 'vAttachOrWait', as well as the 'waitfor-interval' and 'waitfor-duration' flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 marked an inline comment as done. augusto2112 added a comment. @clayborg I've added support for the 'waitfor-interval' and 'waitfor-duration' flags. Yesterday I thought they existed in macOS, but now I'm not so sure, as I couldn't find them on "Options.td". They were added in 2009, s

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. Question: why does lldb queries if vAttachOrWait is supported, but not vAttachWait? Does it make sense to keep this query? Or should I remove it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93895/new/ https://reviews

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. > So it might be nice to add support for vAttachOrWait, along with the query > packet, in this patch if you have the time? Hi @clayborg, I saw that that implementing vAttachOrWait was already 90% done, so I did just that :) The current patch as-is supports vAttachOr

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. > Here lies the problem that I mentioned above. I would like to avoid having to > launch lldb-server with any arguments so that we continue to work with older > lldb-servers. > So maybe we just rely on defaults for now and avoid having to add any new > arguments

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. I think I get your point. If we pass the extra options in the packet, the validation on older lldb-server versions will reject the message. > Another option would be to have lldb-server check for environment variables > for default values for --waitfor-interval and

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. Ok, that makes sense! Let me summarize the work that needs to be done, correct me if I get something wrong: - Change back `vAttachWait` and `vAttachOrWait` to the original format of sending only the process name. - Add default values for "waitfor-interval-usec" a

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. > I don't think it's a good idea to stuff all of this into a single patch. Can > we go back to the version which just implements the basic vAttachWait packet > (we can bikeshed on what the default interval should be)? I believe new > commands/options/packets should

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 updated this revision to Diff 314874. augusto2112 added a comment. Back to implementation of vAttachWait Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93895/new/ https://reviews.llvm.org/D93895 Files: lldb/source/Plugins/Process/gdb-

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 updated this revision to Diff 314896. augusto2112 marked 5 inline comments as done. augusto2112 added a comment. Changes test to launch a process before and after we ask for the attach. Minor code fixes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. > Looks good, modulo the inline comment. Ok! Can I correct the issue pointed out on the comment on the next (vAttachOrWait) patch? > Do you have commit access or you need someone to commit this for you? I don't, if one of you could do it that'd be great :) Reposi

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. @clayborg @labath if possible, could one of you merge this please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93895/new/ https://reviews.llvm.org/D93895 ___ lldb-commits m

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 created this revision. augusto2112 added reviewers: labath, clayborg, jingham, aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Implements the required functions on gdb-remote so the '--include-existing' fla

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:372 + name_with_slash_stream.Format("/{0}", process_name); + auto name_with_slash = name_with_slash_stream.GetStr

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:377 + // by the desired name. + auto should_exclude_process = [&exclusion_list, &process_name, + &name_with_slash]( --

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 updated this revision to Diff 316782. augusto2112 added a comment. Addresses comments, includes tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/ https://reviews.llvm.org/D94672 Files: lldb/source/Plugins/Process/gdb-re

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 marked 4 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:371 + StreamString name_with_slash_stream; + name_with_slash_stream.Format("/{0}", process_name); + auto na

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added a comment. @labath, @clayborg since both of you approved of it, I think this patch is ready to be merged, right? Could one of you do it? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/ https:/

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

augusto2112 created this revision. augusto2112 added reviewers: teemperor, aprantl, jingham, mib. Herald added a subscriber: krytarowski. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On some Linux distributions, after setting

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

augusto2112 added a comment. Herald added a subscriber: JDevlieghere. This issue was found on the Swift REPL. However, I tested @teemperor's C REPL patch (https://reviews.llvm.org/D87281) and the same problem shows up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

augusto2112 added a comment. @labath, you were absolutely correct! It was simply a matter of saving and restoring the terminal struct on the `terminalHasColors` function in the `Process.inc` file (I really should've tried that before). I'm currently recompiling and will re-run the tests locally

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added a comment. @labath sorry for the repeated messages. I believe this is ready to be merged, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/ https://reviews.llvm.org/D94672 __

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 created this revision. augusto2112 added reviewers: labath, clayborg, jasonmolenda. Herald added a subscriber: dang. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jAttachWait provides the same functionality as vAtt

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 added a comment. Herald added a subscriber: JDevlieghere. As discussed in the vAttachWait patch (https://reviews.llvm.org/D93895), I've implemented a jAttachWait packet with supports two additional parameters (polling interval and polling duration) when attaching to a process by name

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 added a comment. In D96176#2546777 , @labath wrote: > One alternative could be to just tack on some extra data to the existing > vAttach family packets (`vAttachWait;foo;interval:47;duration=74`). This was how I did it originally on https://

<    1   2   3   >