[Lldb-commits] [PATCH] D146041: initial commit

AryanGodara created this revision. Herald added a reviewer: bollu. Herald added subscribers: steakhal, martong, arphaman. Herald added a reviewer: aaron.ballman. Herald added a reviewer: NoQ. Herald added a project: All. AryanGodara requested review of this revision. Herald added projects: clang, L

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4192816 , @mehdi_amini wrote: > You should look into the title and description of the commit: > https://cbea.ms/git-commit/ Is the title and description appropriate now? I can add more details to the description,

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4193045 , @DavidSpickett wrote: > Is there some standard for writing warning messages? For llvm that is, it > would be worth looking through the getting started guides to see. I think the > majority of warnings a

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4193172 , @junaire wrote: > I'm not certain if it's bad to say 'sorry', IMHO it's fine? > > Anyway, you can't just simply delete those words (in diagnostic messages and > regression tests), that doesn't work. To ve

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4195992 , @DavidSpickett wrote: >> Since this is my first commit to such a large repository(and project), can >> you please guide me with this @DavidSpickett ! > > Sure, you'll want to make a commit that only has