[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

aeubanks added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.h:1 +#include "lldb/Interpreter/CommandObject.h" + license? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138315/new/ https:/

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. would somebody be willing to lgtm the workaround while we investigate further since this is currently breaking a fairly typical debugging session? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/ https://reviews.

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b80e8ee1fca: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This simplifies an upcoming patch. Repository: rG LLVM Github Monorepo https://revie

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks updated this revision to Diff 477608. aeubanks added a comment. Herald added a subscriber: JDevlieghere. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138612/new/ https://reviews.llvm.org/D138612 Files: lldb/source/Plugins/Symbol

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks updated this revision to Diff 477611. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138612/new/ https://reviews.llvm.org/D138612 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3c423b6cb2e: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE (authored by aeubanks). Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks added a comment. In D138612#3949869 , @jasonmolenda wrote: > Hi Arthur, this change is causing a testsuite failure on Darwin systems - see > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48671/ on the "LLDB > Incremental" bot - and

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks added a comment. > The bot has pretty good logs fwiw, I don't have easy access to a mac, knowing what the logs are when the test is passing would be helpful with figuring out what's going wrong and relanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks updated this revision to Diff 478272. aeubanks added a comment. potential test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138612/new/ https://reviews.llvm.org/D138612 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClan

[Lldb-commits] [PATCH] D138612: [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks added a comment. @jasonmolenda could you run check-lldb with this patch? I think this patch may fix the test by changing its expectations for logging. (removed "NFC" from title because the logging changes actually mattered) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Without checking template parameters, we would sometimes lookup the wrong type definition

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks added a comment. depends on D132624 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138834/new/ https://reviews.llvm.org/D138834 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks updated this revision to Diff 478323. aeubanks marked an inline comment as done. aeubanks added a comment. don't use stl in test simplify some code a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138834/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:747-749 + if (ParseTemplateParameterInfos(die, template_param_infos) && + (!template_param_infos.args.empty() || + template_param_infos.packed_args)) { ---

[Lldb-commits] [PATCH] D138612: [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks updated this revision to Diff 479056. aeubanks added a comment. go back to calling m_index->GetTypes(DWARFDeclContext) instead of m_index->GetTypes(StringRef) these have different codepaths, I mistakenly thought they were equivalent Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D138612: [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks added a comment. I borrowed a mac and verified that this patch fixes the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138612/new/ https://reviews.llvm.org/D138612 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D138612: [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61aed52c9ec0: [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE (authored by aeubanks). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks updated this revision to Diff 479061. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138834/new/ https://reviews.llvm.org/D138834 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h lldb/source

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks updated this revision to Diff 479759. aeubanks marked 2 inline comments as done. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138834/new/ https://reviews.llvm.org/D138834 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:765 +m_ast.CreateClassTemplateSpecializationType(class_specialization_decl); +return clang_type.GetTypeName(/*BaseOnly*/ true); + } Michael137 wr

<    1   2