[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

aeubanks added a comment. Herald added a project: All. Hi, sorry to ping a very old patch but `TestVSCode_runInTerminal.py` is still failing on my linux machine (and a coworker said the same thing). Searching my email for the test name, some 12.0.0 and 13.0.0 release email threads also mention

[Lldb-commits] [PATCH] D130504: [lldb][NFC] Pass ParsedDWARFTypeAttributes as const reference into ParseArrayType()

aeubanks created this revision. aeubanks added a reviewer: dblaikie. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes a FIXME Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D130504: [lldb][NFC] Pass ParsedDWARFTypeAttributes as const reference into ParseArrayType()

This revision was automatically updated to reflect the committed changes. Closed by commit rG492245d9596d: [lldb][NFC] Pass ParsedDWARFTypeAttributes as const reference into… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13050

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:765 +m_ast.CreateClassTemplateSpecializationType(class_specialization_decl); +return clang_type.GetTypeName(/*BaseOnly*/ true); + } Michael137 wr

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0ac25f1acc4: [lldb] Fix simple template names interaction with debug info declarations (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This factors out the check from various callers. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1251 + if (has_template_params && + ParseTemplateParameterInfos(die, template_param_infos)) { +template_function_decl = m_ast.CreateFunctionD

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

aeubanks updated this revision to Diff 481711. aeubanks added a comment. revert one change to make this nfc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139649/new/ https://reviews.llvm.org/D139649 Files: lldb/source/Plugins/SymbolFile/DWARF/DW

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

This revision was automatically updated to reflect the committed changes. Closed by commit rG81f1f6db40ab: [lldb] Make ParseTemplateParameterInfos return false if there are no template… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The provided test case was crashing because of confusion attempting to find types for `ns::Foo` under -gsimple-template-n

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2519 +GetTypeForDIE(die)->GetBaseName().AsCString(); +if (name_bracket_index == llvm::StringRef::npos && base_name.contains('<')) + return true;

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

aeubanks updated this revision to Diff 484077. aeubanks added a comment. check if type is template by looking at underlying clang Type, rather than looking for a '<' properly handle typedefs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140240/new/

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

aeubanks added inline comments. Comment at: lldb/test/API/lang/cpp/unique-types4/TestUniqueTypes4.py:15 +lldbutil.run_to_source_breakpoint(self, "// Set breakpoint here", lldb.SBFileSpec("main.cpp")) +# FIXME: these should successfully print the values +s

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2521 +if (name_bracket_index == llvm::StringRef::npos && +matching_type->IsTemplateType()) + return true; Michael137 wrote: > You could consider

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

This revision was automatically updated to reflect the committed changes. Closed by commit rGd483d488ca5d: [lldb] Prevent false positives with simple template names in SymbolFileDWARF… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Otherwise we may be inserting a decl into a DeclContext that's not fully defined yet. G

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

aeubanks added a comment. there may be an alternate solution involving making some declarations into definitions (at all? earlier?), but I don't have that level of understanding of lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142413/new/ ht

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

aeubanks updated this revision to Diff 491924. aeubanks marked an inline comment as done. aeubanks added a comment. use suggested alternative Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142413/new/ https://reviews.llvm.org/D142413 Files: lldb/

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetDIEClassTemplateParams

aeubanks added a comment. In D142413#4076749 , @Michael137 wrote: > In D142413#4075198 , @aeubanks > wrote: > >> there may be an alternate solution involving making some declarations into >> definitions (at all

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetDIEClassTemplateParams

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dd7c16c3dcf: [lldb] Don't create Clang AST nodes in GetDIEClassTemplateParams (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142413/n

[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

aeubanks added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: llvm/include/llvm/IR/Module.h:573 + /// Inserts \p Alias into the alias list before \p Where and takes ownership. + void insertAlias(AliasListType::iterator Where, GlobalAlias *Alias

[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

aeubanks added inline comments. Comment at: llvm/include/llvm/IR/Module.h:566 + /// Detaches \p Alias from the list but does not delete it. + void removeAlias(GlobalAlias *Alias) { AliasList.remove(Alias); } use the imperative `Detach` instead of `Detaches` (

[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143958/new/ https://reviews.llvm.org/D143958 ___

[Lldb-commits] [PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/unittests/IR/ModuleTest.cpp:49 EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare)); -M.getGlobalList().sort(compare); -

[Lldb-commits] [PATCH] D110885: [AttributeList] Replace index_begin/end with an iterator

aeubanks created this revision. Herald added subscribers: dexonsmith, jdoerfert, arphaman, hiraditya. aeubanks requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Herald added a subscriber: JDevlieghere. We expose the fact tha

[Lldb-commits] [PATCH] D110885: [NFC][AttributeList] Replace index_begin/end with an iterator

aeubanks updated this revision to Diff 376381. aeubanks added a comment. auto -> unsigned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110885/new/ https://reviews.llvm.org/D110885 Files: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderS

[Lldb-commits] [PATCH] D110885: [NFC][AttributeList] Replace index_begin/end with an iterator

aeubanks updated this revision to Diff 376420. aeubanks added a comment. add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110885/new/ https://reviews.llvm.org/D110885 Files: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScrip

[Lldb-commits] [PATCH] D110885: [NFC][AttributeList] Replace index_begin/end with an iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b4ce9cfd11: [NFC][AttributeList] Replace index_begin/end with an iterator (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110885/new/

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks updated this revision to Diff 461963. aeubanks added a comment. aeubanks added a reviewer: dblaikie. aeubanks published this revision for review. Herald added a project: LLDB. Herald added a subsc

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks updated this revision to Diff 462245. aeubanks added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. "fix" lldb test (hopefully) skip when msan add flag to disable (to be removed in the future) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks updated this revision to Diff 462247. aeubanks added a comment. add flag to disable (to be removed in the future) "fix" lldb test skip on msan instrumented functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks updated this revision to Diff 462249. aeubanks added a comment. extra parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036 Files: clang/test/CodeGenOpenCL/overload.cl lldb/test/API/function

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks added a comment. @vitalybuka can we turn on -fsanitize-memory-param-retval by default upstream? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036 ___ lld

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks added a comment. In D133036#3816002 , @aeubanks wrote: > @vitalybuka can we turn on -fsanitize-memory-param-retval by default upstream? attempt in https://reviews.llvm.org/D134669 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 465586. aeubanks marked 5 inline comments as done. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files: lldb/packages/

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1558-1560 +if (template_param_infos.hasParameterPack()) { + args = template_param_infos.packed_args->args; +} dblaikie w

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 465926. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/test/API/lang/cpp/unique-types2/TestUniqueTypes.py:1 +""" +Test that we return only the requested template instantiation. Michael137 wrote: > I think it would be good to test this with > `-gsimple-template-names`/

[Lldb-commits] [PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

aeubanks created this revision. aeubanks added a reviewer: DavidSpickett. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Similar to D135170 . Repos

[Lldb-commits] [PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

aeubanks updated this revision to Diff 466622. aeubanks added a comment. update python test, although those changes don't actually test the code path changed here, the code path here is tested via the existing `self.expect("image lookup -t A")` Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

aeubanks added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1298 + case BuiltinType::WChar_U: +break; // no suffix. } DavidSpickett wrote: > Is there any reason to have a suffix here? > > I admit this function is puzzling to me anyway given

[Lldb-commits] [PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

This revision was automatically updated to reflect the committed changes. Closed by commit rGeab5c2f94f5a: [LLDB] Fix crash when printing a struct with a static wchar_t member (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1354

[Lldb-commits] [PATCH] D135826: [lldb] Start from end of previous substr when checking ordered substrs

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm trying to add a test which tests that the same substr occurs twice in a row, but it matches even if only one of the s

[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Or else multiple entries end up overlapping on the same line. Repository: rG LLVM Github Monorepo https://reviews.llv

[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

aeubanks added a comment. Herald added a subscriber: JDevlieghere. (depends on https://reviews.llvm.org/D135826 for the test to be meaningful) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135827/new/ https://reviews.llvm.org/D135827 _

[Lldb-commits] [PATCH] D135826: [lldb] Start from end of previous substr when checking ordered substrs

This revision was automatically updated to reflect the committed changes. Closed by commit rG021a3d5a3f73: [lldb] Start from end of previous substr when checking ordered substrs (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

aeubanks added inline comments. Comment at: lldb/test/API/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.py:16 + +self.expect("image lookup -A -t Foo", DATA_TYPES_DISPLAYED_CORRECTLY, substrs=["2 matches found", "\nid =", "\nid ="]) DavidSpic

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In D134378 , we'll need the clang AST to be able to co

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

aeubanks updated this revision to Diff 467868. aeubanks added a comment. Herald added a subscriber: JDevlieghere. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135979/new/ https://reviews.llvm.org/D135979 Files: lldb/source/Plugins/Symbol

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1561 +std::string +DWARFASTParserClang::GetCPlusPlusQualifiedName(const DWARFDIE &die) { + if (!die.IsValid()) dblaikie wrote: > Sorry, when I gave feedback

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

aeubanks updated this revision to Diff 467916. aeubanks added a comment. check if string is empty before assigning to unique_typename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135979/new/ https://reviews.llvm.org/D135979 Files: lldb/source/P

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a98287f255b: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135979/

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 467946. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1534 + std::string qualified_name; + DWARFDIE parent_decl_ctx_die = die.GetParentDeclContextDIE(); + // TODO: change this to get the correct decl context parent ---

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. With -f(un)signed-char, the die corresponding to "char" may be the wrong DW_ATE_(un)signed_char. Ultimately we can determ

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

aeubanks added a comment. not 100% sure this is the right fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136011/new/ https://reviews.llvm.org/D136011 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

aeubanks updated this revision to Diff 468118. aeubanks added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136011/new/ https://reviews.llvm.org/D136011 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp lld

[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

This revision was automatically updated to reflect the committed changes. Closed by commit rG569be95a4089: [lldb] Print newline between found types (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135827/new/ https://reviews.llv

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

aeubanks added a comment. In D136011#3862150 , @labath wrote: > In D136011#3860637 , @dblaikie > wrote: > >> I think the place where this will go wrong is in terms of how lldb renders >> `char` values on non-def

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

This revision was automatically updated to reflect the committed changes. Closed by commit rGba8ded6820fa: [lldb] Don't check environment default char signedness when creating clang type… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 470321. aeubanks marked 3 inline comments as done. aeubanks added a comment. address comments rebasing to ToT, TestCPPBreakpointsLocations.py is failing when using -gsimple-template-names. still working on that Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1551 +} +if (!all_template_names.empty()) { + all_template_names.append(">"); labath wrote: > When can this be empty? Should we still include the

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 470617. aeubanks added a comment. revert breakpoint test change we can leave that to a later change, so I think this change is ready to go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://revi

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 471330. aeubanks added a comment. fix nested types by introducing Type::GetBaseName() add expr eval tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files: ll

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added a comment. regarding the failure in TestCPPBreakpointLocations.py (added recently in https://reviews.llvm.org/D135921, seems like it's catching real issues with this patch), it looks like the manual dwarf index needs a similar fix to this In D134378#3888462

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 471375. aeubanks marked an inline comment as done. aeubanks added a comment. combine GetBaseName into GetTypeName Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Fil

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3809 +ConstString TypeSystemClang::GetBaseName(lldb::opaque_compiler_type_t type) { + if (!type) this was mostly copied from `GetTypeName` above, not sure if t

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 471585. aeubanks added a comment. rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/ll

[Lldb-commits] [PATCH] D136959: clang: Improve errors for DiagnosticInfoResourceLimit

aeubanks added a comment. see https://reviews.llvm.org/D110665 for how we get line/col from a function. basically, we have a map from function name hashes to source location available in clang if we don't have clang source information for functions available, there's not much more we can do ot

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

This revision was automatically updated to reflect the committed changes. Closed by commit rGa842f7405679: [lldb] Support simplified template names (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llv

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Extends D135169 to work with enums with bool as the underlying type. Fixes #58383.

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

aeubanks updated this revision to Diff 472053. aeubanks added a comment. Herald added a reviewer: shafik. undo a lot of code added in D135169 . it seems a little overengineered when we can just check if the type is bool when setting the initializer. Repository

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

aeubanks added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7612 + ->getIntegerType() + ->isSpecificBuiltinType(BuiltinType::Bool)) && "only boolean supported"); DavidSpickett wrote: > C

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

aeubanks updated this revision to Diff 472061. aeubanks added a comment. capitalize comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137045/new/ https://reviews.llvm.org/D137045 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

aeubanks created this revision. Herald added a subscriber: arphaman. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This makes setting breakpoints work with -gsimple-template-names. Repository: rG

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

aeubanks added a comment. Herald added a subscriber: JDevlieghere. (I don't understand why this works yet, it should be giving us false positives?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137098/new/ https://reviews.llvm.org/D137098

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

aeubanks added a comment. updated description with why this doesn't produce false positives with breakpoints this doesn't support regex function name lookup, not sure if we care enough about the interaction between regexes/function names under simple template names. if we do, we could instead

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

This revision was automatically updated to reflect the committed changes. Closed by commit rGa715b1bde910: [lldb] Don't crash when printing static enum members with bool as underlying… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

aeubanks updated this revision to Diff 472770. aeubanks added a comment. move retry into SymbolFileDWARF add tests for non-member functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137098/new/ https://reviews.llvm.org/D137098 Files: lldb/so

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names in the manual index

aeubanks added a comment. In D137098#3902140 , @labath wrote: > Why is it that the other indexes don't need an equivalent fix? Could it be > that you just haven't tried those code paths? > > If they do need it, then it'd be good if we could make the fix

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aeubanks added a comment. Herald added a project: All. the added test `TestVSCode_runInTerminal` consistently fails for me locally with Failed to attach to the target process. Timed out trying to get messages from the runInTerminal launcher I've asked other people and they've also reported co

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names when looking up functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d83a57721de: [lldb] Support simplified template names when looking up functions (authored by aeubanks). Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D137464: [NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription()

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137464 Files: lldb/source/Plugins/TypeSystem/Clang/Typ

[Lldb-commits] [PATCH] D137464: [NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription()

This revision was automatically updated to reflect the committed changes. Closed by commit rGec1bd2546d34: [NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription() (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Followup to D134378 . With PrintingPolicy::SuppressScope, we'd also n

[Lldb-commits] [PATCH] D137793: [lldb][test] TestConstStaticIntegralMember.py: fix for clang-{9, 11, 13}

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. add a FIXME? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137793/new/ https://reviews.llvm.org/D137793 ___

[Lldb-commits] [PATCH] D137793: [lldb][test] TestConstStaticIntegralMember.py: fix for clang-{9, 11, 13}

aeubanks added a comment. In D137793#3920253 , @Michael137 wrote: > In D137793#3920209 , @aeubanks > wrote: > >> add a FIXME? > > May be misunderstanding your suggestion, but the malformed DWARF got fixed > som

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks updated this revision to Diff 474848. aeubanks added a comment. use getNameForDiagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemC

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks updated this revision to Diff 474850. aeubanks added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp lld

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks added a comment. In D137583#3917735 , @dblaikie wrote: > In D137583#3917706 , @aaron.ballman > wrote: > >>> ...we expect template params to be fully qualified when comparing them for >>> simple template

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks updated this revision to Diff 475017. aeubanks added a comment. I somehow missed the previous comments rebased on top of fixing UB in tests changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks added a comment. I'll hold off on submitting this until that bug is figured out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. After D134378 , we started seeing crashes with incomplete types (in the context of shar

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. Herald added a subscriber: JDevlieghere. lldb crash repro $ cat /tmp/a.cc #include void f(std::vector& v) { *(volatile int*) nullptr = 0; } $ cat /tmp/main.cc #include void f(std::vector& v); int main() { std::vector v ;

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. also I'm don't understand how this code doesn't infinite recurse on ObjC and can't trace it because I don't have a mac if anybody has an actual way of fixing this I'd be happy with that too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks updated this revision to Diff 475627. aeubanks added a comment. add bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/ https://reviews.llvm.org/D137983 Files: lldb/source/Core/ValueObject.cpp Index: lldb/source/Core/ValueOb

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2676-2677 if (!m_deref_valobj) { - if (HasSyntheticValue()) { + // FIXME: C++ stdlib formatters break with incomplete types (e.g. + // `std::vector &`). Remove ObjC restriction once t

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb0ffa529a0f: [lldb] Fix simple template names and template params with scope qualifiers (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks updated this revision to Diff 476199. aeubanks added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/ https://reviews.llvm.org/D137983 Files: lldb/source/Core/ValueObject.cpp lldb/test/API/lang/cpp/incompl

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. In D137983#3930973 , @labath wrote: > We have tests for shared libraries (grep for DYLIB_C(XX)_SOURCES)), but it's > easier to reproduce this problem by compiling one CU with -g0 -- see inline > comment. (If you are creating an

  1   2   >