[Lldb-commits] [PATCH] D110569: [lldb] [Process/FreeBSD] Rework arm64 register access

andrew updated this revision to Diff 48. andrew added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110569/new/ https://reviews.llvm.org/D110569 Files: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD.h ll

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew created this revision. andrew added a reviewer: mgorny. Herald added subscribers: kristof.beyls, krytarowski, arichardson. andrew requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Read the mask using ptrace with PT_GETREGSET with NT_AR

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp:128 + +#ifdef NT_ARM_ADDR_MASK + if (m_addr_mask_is_valid) emaste wrote: > This `#define` is coming from our headers? We need to provide this co

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew added a comment. In D120485#3343538 , @emaste wrote: > We need to make sure a test covers this as well, perhaps just enabling > lldb/test/API/functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py? I have a local change to use the test

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew added a comment. It's easy to detect in the debugee as it can check which hardware capabilities are passed to it from the kernel. Another option could be to have a build tool that prints these capabilities and have the test decide based on it as they are identical on FreeBSD and Linux.

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew updated this revision to Diff 420205. andrew added a comment. Add support for the PAC test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120485/new/ https://reviews.llvm.org/D120485 Files: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew updated this revision to Diff 426993. andrew marked 5 inline comments as done and an inline comment as not done. andrew added a comment. Cleanup based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120485/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew updated this revision to Diff 427010. andrew added a comment. Remove a stray change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120485/new/ https://reviews.llvm.org/D120485 Files: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp lldb

[Lldb-commits] [PATCH] D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

andrew created this revision. Herald added subscribers: omjavaid, kristof.beyls, emaste. andrew requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110545 Files: lldb/unittests

[Lldb-commits] [PATCH] D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

andrew updated this revision to Diff 375293. andrew added a comment. Set opt_regsets to eRegsetMaskDefault Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110545/new/ https://reviews.llvm.org/D110545 Files: lldb/unittests/Process/Utility/RegisterC

[Lldb-commits] [PATCH] D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

andrew added a comment. Yes, I found it by trying to build the tests on FreeBSD/arm64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110545/new/ https://reviews.llvm.org/D110545 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D110569: [lldb] [Process/FreeBSD] Rework arm64 register access

andrew created this revision. andrew added a reviewer: mgorny. Herald added subscribers: omjavaid, kristof.beyls, krytarowski, arichardson, emaste. andrew requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To simplify future register access r

[Lldb-commits] [PATCH] D110569: [lldb] [Process/FreeBSD] Rework arm64 register access

andrew added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp:73 -Status NativeRegisterContextFreeBSD_arm64::ReadRegisterSet(uint32_t set) { - switch (set) { - case RegisterInfoPOSIX_arm64::GPRegSet: -return NativePr

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

andrew added a comment. FreeBSD doesn't currently support TBI. I'm trying to decide if it will be enabled everywhere, or just when needed (e.g. for HWASAN) due to how it interacts with PAC. I have a patch in review in the FreeBSD phabricator to add PAC support. Repository: rG LLVM Github Mo