[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

andrewrk added a comment. In D139102#3963388 , @DavidSpickett wrote: > > @andrewrk I seem to remember that Zig uses these files for generating > compiler options of its own? A basic search didn't show anything but we'd > better check if you're usin

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

andrewrk added a comment. if(LLVM_ENABLE_ZSTD) list(APPEND imported_libs zstd::libzstd_shared) endif() This hard codes shared linking which breaks the use case of static linking LLVM. Also LLVM needs to now include a Findzstd.cmake file or else we get this error: CMake Error at cmake/

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

andrewrk added a comment. Compiler infrastructure should not assume the existence of a Linux distribution. The portable way is simple and can easily be supported. One should be able to install `$prefix/lib/libzstd.a` and `$prefix/include/zstd.h`, then have that prefix searched as part of the st