[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. I think there is a false positive with this @george.burgess.iv: In [this)(https://searchfox.org/mozilla-central/source/mozglue/baseprofiler/core/platform-linux-android.cpp#222-227) we have the warning triggered: mozglue/baseprofiler/core/platform-linux-android.cpp:

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. In D100581#2798079 , @raj.khem wrote: > http://sprunge.us/FJzZXL is a file from harfbuzz and it warns > > a.cc:28670:32: error: variable 'supp_size' set but not used > [-Werror,-Wunused-but-set-variable] > unsigned i

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu abandoned this revision. Abpostelnicu added a comment. This has landed and trunk is already fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 __

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. Shouldn't this also update PlatformiOSSimulator.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89156/new/ https://reviews.llvm.org/D89156 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. In D89156#2530656 , @JosephTremoulet wrote: > In D89156#2530353 , @Abpostelnicu > wrote: > >> Shouldn't this also update PlatformiOSSimulator.h? > > There is no PlatformOSSimulator.h

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. In D89156#2530701 , @JosephTremoulet wrote: > Oh, I see. I made this change in the master branch and then ported it to the > release/11.x branch. It changed the signature of a virtual method, which had > a couple more ove

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. And there are more issues like: https://github.com/llvm/llvm-project/blob/llvmorg-11.0.1/lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp#L733. `old_module_sp_ptr` is nowhere declared. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu created this revision. Abpostelnicu added a reviewer: JosephTremoulet. Abpostelnicu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix fallout caused by D89156 on 11.0.1 for MacOS Repositor

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu updated this revision to Diff 320134. Abpostelnicu added a comment. Update with format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 Files: lldb/source/Plugins/Platform/MacOSX/PlatformApple

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu updated this revision to Diff 320137. Abpostelnicu added a comment. Update for plularization of variables name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 Files: lldb/source/Plugins/Plat

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu marked an inline comment as done. Abpostelnicu added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h:58 const lldb_private::FileSpecList *module_search_paths_ptr, - lldb::ModuleSP *old_mo

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. In D89156#2530839 , @tstellar wrote: > In D89156#2530703 , @Abpostelnicu > wrote: > >> In D89156#2530701 , >> @JosephTremoulet wrote: >> >>> O

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu marked an inline comment as done. Abpostelnicu added a comment. @tstellar what do you suggest to do here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 ___

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu updated this revision to Diff 321104. Abpostelnicu added a comment. rebased on 11.1rc2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 Files: lldb/source/Plugins/Platform/MacOSX/PlatformApple

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu added a comment. The failure is wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu added a comment. Landed in 11.1 https://github.com/llvm/llvm-project/commit/1fdec59bffc11ae37eb51a1b9869f0696bfd5312#diff-2fa23ad0cf1839955ddaf4a0d78a9d9b5fd9b88933f82f6433035916a2655c6c. Patch needs to be rebased for trunk now. Repository: rG LLVM Github Monorepo CHANGES SINCE