asm created this revision.
asm added reviewers: clayborg, wallace.
Herald added subscribers: pengfei, JDevlieghere.
asm requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Rust's v0 name mangling scheme [1] is easy to disambiguate from other
na
asm added inline comments.
Comment at: lldb/unittests/Core/MangledTest.cpp:72
+
+ EXPECT_STREQ("", TheDemangled.GetCString());
+}
teemperor wrote:
> Could you do me a favour and change your test functions to LLDB's code style,
> so `mangled_name` as a variable
asm updated this revision to Diff 351481.
asm marked an inline comment as done.
asm added a comment.
code style fixes, use modern log
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104054/new/
https://reviews.llvm.org/D104054
Files:
lldb/include/
asm added a comment.
And thank you for the quick review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104054/new/
https://reviews.llvm.org/D104054
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
asm added a comment.
@teemperor @clayborg Is this good to go? :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104054/new/
https://reviews.llvm.org/D104054
___
lldb-commits mailing list
lldb-commits@list