[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#3963767 , @labath wrote: > The explanation makes sense, and I *think* the patch is ok, but it's hard to > review it with all the noise. I still believe the DIERef change would be > better off as a separate patch, so

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 479769. ayermolo added a comment. Addressed inlined comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/include/lldb/Core/dwarf.h lldb/include/

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#3966539 , @labath wrote: > I don't believe there's no way to split this patch up. I mean, just half of > it is dedicated to changing PRIx32 into PRIx64. Surely that can be a patch of > it's own, even if it meant that

<    1   2