[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the fpsr register (PR #71651)

2023-11-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Looks straightforward to me. https://github.com/llvm/llvm-project/pull/71651 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add fields for FPCR register (PR #71694)

2023-11-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. This also looks pretty straightforward after you implemented the initial support. :) https://github.com/llvm/llvm-project/pull/71694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] Improve VSCode DAP logpoint value summary (PR #71723)

2023-11-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/71723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve VSCode DAP logpoint value summary (PR #71723)

2023-11-08 Thread Alex Langford via lldb-commits
@@ -48,7 +48,9 @@ def test_logmessage_basic(self): # 1. First at the loop line with logMessage # 2. Second guard breakpoint at a line after loop logMessage_prefix = "This is log message for { -- " -logMessage = logMessage_prefix + "{i + 3}" +

[Lldb-commits] [lldb] Improve VSCode DAP logpoint value summary (PR #71723)

2023-11-08 Thread Alex Langford via lldb-commits
@@ -210,8 +210,7 @@ static std::optional TryCreateAutoSummary(lldb::SBValue value) { return TryCreateAutoSummaryForContainer(value); } -void SetValueForKey(lldb::SBValue &v, llvm::json::Object &object, -llvm::StringRef key) { +std::string ValeuToString(l

[Lldb-commits] [lldb] Improve VSCode DAP logpoint value summary (PR #71723)

2023-11-08 Thread Alex Langford via lldb-commits
@@ -295,9 +296,7 @@ bool BreakpointBase::BreakpointHitCallback( frame.GetValueForVariablePath(expr, lldb::eDynamicDontRunTarget); if (value.GetError().Fail()) value = frame.EvaluateExpression(expr); - const char *expr_val = value.GetValue(); -

[Lldb-commits] [lldb] Improve VSCode DAP logpoint value summary (PR #71723)

2023-11-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. Looks fine, but the method you added has a typo in its name. https://github.com/llvm/llvm-project/pull/71723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] Improve VSCode DAP logpoint value summary (PR #71723)

2023-11-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/71723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix assert in ScriptedProcess destructor (PR #71744)

2023-11-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. 🚢 https://github.com/llvm/llvm-project/pull/71744 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -184,6 +184,8 @@ class LLDB_API SBTarget { SBProcess LoadCore(const char *core_file); SBProcess LoadCore(const char *core_file, lldb::SBError &error); + SBProcess LoadCore(SBFile &file); bulbazord wrote: +1, please don't add a new API that gives no fe

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -244,9 +245,45 @@ SBProcess SBTarget::LoadCore(const char *core_file, lldb::SBError &error) { TargetSP target_sp(GetSP()); if (target_sp) { FileSpec filespec(core_file); -FileSystem::Instance().Resolve(filespec); +auto file = FileSystem::Instance().Open( +

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -390,12 +389,12 @@ class Process : public std::enable_shared_from_this, ConstString &GetBroadcasterClass() const override { return GetStaticBroadcasterClass(); } - -/// A notification structure that can be used by clients to listen -/// for changes in a process's

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -61,13 +62,15 @@ void ProcessMachCore::Terminate() { lldb::ProcessSP ProcessMachCore::CreateInstance(lldb::TargetSP target_sp, ListenerSP listener_sp, -const FileSpec *crash_file

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -102,10 +102,10 @@ void ProcessKDP::Terminate() { lldb::ProcessSP ProcessKDP::CreateInstance(TargetSP target_sp, ListenerSP listener_sp, - const FileSpec *crash_file_path, +

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -49,17 +50,18 @@ void ProcessElfCore::Terminate() { lldb::ProcessSP ProcessElfCore::CreateInstance(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp, - const FileSpec *crash_fi

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -67,30 +67,33 @@ class ProcessFreeBSDKernelKVM : public ProcessFreeBSDKernel { } // namespace ProcessFreeBSDKernel::ProcessFreeBSDKernel(lldb::TargetSP target_sp, - ListenerSP listener_sp) -: PostMortemProcess(target_sp, listen

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -196,9 +196,10 @@ void ProcessGDBRemote::Terminate() { lldb::ProcessSP ProcessGDBRemote::CreateInstance( lldb::TargetSP target_sp, ListenerSP listener_sp, -const FileSpec *crash_file_path, bool can_connect) { + lldb::F

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -24,7 +26,20 @@ class PostMortemProcess : public Process { using Process::Process; public: + PostMortemProcess(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp, +lldb::FileSP file_sp) + : Process(target_sp, listener_sp), m_core_file(file_sp

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -1469,6 +1468,14 @@ class Process : public std::enable_shared_from_this, virtual bool IsLiveDebugSession() const { return true; }; + + /// Provide a way to retrieve the core dump file that is loaded for debugging. + /// Only available if IsLiveDebugSession() returns

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -704,7 +705,37 @@ class Process : public std::enable_shared_from_this, /// is not supported by the plugin, error otherwise. virtual llvm::Expected SaveCore(llvm::StringRef outfile); + struct CoreFileMemoryRange { +llvm::AddressRange range; /// The address rang

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the mte_ctrl register (PR #71808)

2023-11-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: The idea of this makes sense to me, but I think you should let @felipepiovezan take a look first. https://github.com/llvm/llvm-project/pull/71828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-09 Thread Alex Langford via lldb-commits
bulbazord wrote: > I addressed most of the feedback. Alex let me know if you still really want > llvm::Error and llvm::Expected to be used as I can add that if you think it > is required. I also ran clang format. I think your answers make sense to me. I don't think you need to add them here s

[Lldb-commits] [lldb] [lldb-dap] Add an option to show function args in stack frames (PR #71843)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -87,8 +87,15 @@ class LLDB_API SBFrame { // display to a user const char *GetDisplayFunctionName(); + /// Similar to \a GetDisplayFunctionName() but with function arguments and + /// their values inserted into the function display name whenever possible. + /// + ///

[Lldb-commits] [lldb] [lldb-dap] Add an option to show function args in stack frames (PR #71843)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -87,8 +87,15 @@ class LLDB_API SBFrame { // display to a user const char *GetDisplayFunctionName(); + /// Similar to \a GetDisplayFunctionName() but with function arguments and + /// their values inserted into the function display name whenever possible. + /// + ///

[Lldb-commits] [lldb] [lldb-dap] Add an option to show function args in stack frames (PR #71843)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -187,3 +188,19 @@ def test_stackTrace(self): self.assertEquals( 0, len(stackFrames), "verify zero frames with startFrame out of bounds" ) + +@skipIfWindows bulbazord wrote: Why skip on Windows? https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [lldb-dap] Add an option to show function args in stack frames (PR #71843)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -1232,6 +1234,32 @@ const char *SBFrame::GetFunctionName() const { return name; } +void SBFrame::GetDisplayFunctionNameWithArgs(SBStream &output) { + Stream &strm = output.ref(); + + std::unique_lock lock; + ExecutionContext exe_ctx(m_opaque_sp.get(), lock); + + Stack

[Lldb-commits] [lldb] [lldb-dap] Add an option to show function args in stack frames (PR #71843)

2023-11-09 Thread Alex Langford via lldb-commits
@@ -324,8 +325,23 @@ class StackFrame : public ExecutionContextScope, ///C string with the assembly instructions for this function. const char *Disassemble(); + /// Print a description of this frame using the provided frame format. + /// If the format is invalid, the

[Lldb-commits] [lldb] [lldb] Change Breakpoint::AddName return value (PR #71236)

2023-11-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/71236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsString (PR #71613)

2023-11-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/71613 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/71961 Similar to my previous patch (#71613) where I changed `GetItemAtIndexAsString`, this patch makes the same change to `GetItemAtIndexAsDictionary`. `GetItemAtIndexAsDictionary` now returns a std::optional that i

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread Alex Langford via lldb-commits
bulbazord wrote: > A great future patch would be to have StructuredData backed by the llvm::json > stuff instead of our own custom version of this a JSON style object hiearchy I think that I agree. Unfortunately I don't have time to drive that right now and it might appear to not make sense wh

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsDictionary (PR #71961)

2023-11-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/71961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsInteger (PR #71993)

2023-11-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/71993 This is a follow-up to (#71613) and (#71961). >From c6b3f622c32634db628cb76eaca556ae3d8ad6f4 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Fri, 10 Nov 2023 14:06:48 -0800 Subject: [PATCH] [lldb] Change in

[Lldb-commits] [lldb] [lldb] Remove StructuredData::Array::GetItemAtIndexAsArray (PR #71994)

2023-11-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/71994 This method is completely unused. >From 96d7701aa01312e1decdf43c1c1287c9a4e3da91 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Fri, 10 Nov 2023 14:40:21 -0800 Subject: [PATCH] [lldb] Remove StructuredData

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-11 Thread Alex Langford via lldb-commits
@@ -94,16 +94,11 @@ SBError SBWatchpoint::GetError() { int32_t SBWatchpoint::GetHardwareIndex() { LLDB_INSTRUMENT_VA(this); - int32_t hw_index = -1; - - lldb::WatchpointSP watchpoint_sp(GetSP()); - if (watchpoint_sp) { -std::lock_guard guard( -watchpoint_sp->G

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. This makes sense to me. I don't think we should worry too much about MIPS support -- my understanding is that LLDB doesn't really support any MIPS targets right now anyway. The Linux MIPS support has been ripped out and the remaining sup

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/72012 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Oh, one more thing: Can you document the deprecation of this method into the release notes? The file is `llvm-project/llvm/docs/ReleaseNotes.rst` and there is an LLDB section. https://github.com/llvm/llvm-project/pull/72012 __

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Alex Langford via lldb-commits
@@ -1779,18 +1779,36 @@ void StackFrame::CalculateExecutionContext(ExecutionContext &exe_ctx) { exe_ctx.SetContext(shared_from_this()); } +bool StackFrame::DumpUsingFormat(Stream &strm, + const FormatEntity::Entry *format, +

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Alex Langford via lldb-commits
@@ -0,0 +1,72 @@ + +//===-- SBFormat.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[Lldb-commits] [lldb] [lldb] Remove StructuredData::Array::GetItemAtIndexAsArray (PR #71994)

2023-11-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/71994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-14 Thread Alex Langford via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-14 Thread Alex Langford via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-14 Thread Alex Langford via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-14 Thread Alex Langford via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-14 Thread Alex Langford via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-14 Thread Alex Langford via lldb-commits
@@ -476,6 +476,14 @@ class ScriptInterpreter : public PluginInterface { return false; } + virtual bool RunScriptBasedParsedCommand( + StructuredData::GenericSP impl_obj_sp, Args& args, + ScriptedCommandSynchronicity synchronicity, + lldb_private::CommandR

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-14 Thread Alex Langford via lldb-commits
@@ -2755,6 +2755,58 @@ bool ScriptInterpreterPythonImpl::RunScriptBasedCommand( return ret_val; } +bool ScriptInterpreterPythonImpl::RunScriptBasedParsedCommand( +StructuredData::GenericSP impl_obj_sp, Args &args, +ScriptedCommandSynchronicity synchronicity, +lld

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-11-14 Thread Alex Langford via lldb-commits
@@ -1255,6 +1258,676 @@ class CommandObjectScriptingObject : public CommandObjectRaw { CompletionType m_completion_type = eNoCompletion; }; + +/// This command implements a lldb parsed scripted command. The command +/// provides a definition of the options and arguments, a

[Lldb-commits] [lldb] [llvm] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-14 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Awesome, thank you! 😄 https://github.com/llvm/llvm-project/pull/72012 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-14 Thread Alex Langford via lldb-commits
bulbazord wrote: > > > The Linux MIPS support has been ripped out and the remaining support for > > > MIPS probably gets no real testing > > > > > > Don't know the status but the BSD's still have some MIPS support. > > Yeah I've been trying to keep the MIPS watchpoint code in the sources

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-11-15 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM as well. I like the name Constituents quite a bit as well! 😄 I think most feedback at this point can probably be handled in follow-ups, esp. since some of it pertains to existing interfaces. https://github.com/llvm/llvm-project/pul

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-15 Thread Alex Langford via lldb-commits
@@ -62,15 +66,25 @@ bool canUseDebuginfod() { } SmallVector getDefaultDebuginfodUrls() { - const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS"); - if (DebuginfodUrlsEnv == nullptr) -return SmallVector(); - - SmallVector DebuginfodUrls; - StringRef(DebuginfodU

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-15 Thread Alex Langford via lldb-commits
@@ -0,0 +1,142 @@ +//===-- SymbolLocatorDebuginfod.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

2023-11-15 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Beautiful, thank you for working on this. After this change, what's left to get us using the python-provided `unittest`? https://github.com/llvm/llvm-project/pull/72416 ___ lldb-commits mailing l

[Lldb-commits] [lldb] a322d50 - [lldb] Add forward declaration for SBWatchpointOptions in SBDefines.h

2023-11-16 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-11-16T12:13:44-08:00 New Revision: a322d50804c5248f9e2981f3733bcb598fa13d51 URL: https://github.com/llvm/llvm-project/commit/a322d50804c5248f9e2981f3733bcb598fa13d51 DIFF: https://github.com/llvm/llvm-project/commit/a322d50804c5248f9e2981f3733bcb598fa13d51.diff

[Lldb-commits] [lldb] Add --copyExecutable and --ignoreNegativeCache to dsymForUUID invoke (PR #72579)

2023-11-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Awesome! https://github.com/llvm/llvm-project/pull/72579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM I think, but wait a little bit for Jonas and/or Greg to give it another pass. https://github.com/llvm/llvm-project/pull/71769 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-16 Thread Alex Langford via lldb-commits
@@ -184,6 +184,7 @@ class LLDB_API SBTarget { SBProcess LoadCore(const char *core_file); SBProcess LoadCore(const char *core_file, lldb::SBError &error); + SBProcess LoadCore(SBFile &file, lldb::SBError &error); bulbazord wrote: Actually, can the `SBFile

[Lldb-commits] [lldb] [lldb] Remove unused Status::SetMachError (NFC) (PR #72668)

2023-11-17 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. 🚢 https://github.com/llvm/llvm-project/pull/72668 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0cfa501 - [LLDB] Only run lldb-server Shell tests if it gets built

2022-10-14 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2022-10-14T12:00:57-07:00 New Revision: 0cfa50154a47eb65de5bc687f6565625f556edc8 URL: https://github.com/llvm/llvm-project/commit/0cfa50154a47eb65de5bc687f6565625f556edc8 DIFF: https://github.com/llvm/llvm-project/commit/0cfa50154a47eb65de5bc687f6565625f556edc8.diff

[Lldb-commits] [lldb] 13cd390 - [lldb] Add information on type systems to statistics dump command

2022-11-02 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2022-11-02T10:45:56-07:00 New Revision: 13cd39017de07a116c8901904fd4cf7aa290a47c URL: https://github.com/llvm/llvm-project/commit/13cd39017de07a116c8901904fd4cf7aa290a47c DIFF: https://github.com/llvm/llvm-project/commit/13cd39017de07a116c8901904fd4cf7aa290a47c.diff

[Lldb-commits] [lldb] 58d38b3 - [lldb] Restore default setting of LLDB_INCLUDE_TESTS in standalone builds

2022-11-18 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2022-11-18T09:05:08-08:00 New Revision: 58d38b3ff8c3c4dd816d2047acf65fa97c0b6fb8 URL: https://github.com/llvm/llvm-project/commit/58d38b3ff8c3c4dd816d2047acf65fa97c0b6fb8 DIFF: https://github.com/llvm/llvm-project/commit/58d38b3ff8c3c4dd816d2047acf65fa97c0b6fb8.diff

[Lldb-commits] [lldb] 4c0b0de - [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

2021-05-24 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-05-24T13:13:12-07:00 New Revision: 4c0b0de904a5622c33e3ed97e86c6792fbc13feb URL: https://github.com/llvm/llvm-project/commit/4c0b0de904a5622c33e3ed97e86c6792fbc13feb DIFF: https://github.com/llvm/llvm-project/commit/4c0b0de904a5622c33e3ed97e86c6792fbc13feb.diff

[Lldb-commits] [lldb] 99155e9 - [lldb][NFC] Remove unused header from Target

2021-05-24 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-05-24T15:13:08-07:00 New Revision: 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1 URL: https://github.com/llvm/llvm-project/commit/99155e913e9bad5f7f8a247f8bb3a3ff3da74af1 DIFF: https://github.com/llvm/llvm-project/commit/99155e913e9bad5f7f8a247f8bb3a3ff3da74af1.diff

[Lldb-commits] [lldb] 64576a1 - [lldb][NFC] Refactor name to index maps in Symtab

2021-06-08 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-06-08T12:36:54-07:00 New Revision: 64576a1be887b7afcacf0534e6c168805fba5677 URL: https://github.com/llvm/llvm-project/commit/64576a1be887b7afcacf0534e6c168805fba5677 DIFF: https://github.com/llvm/llvm-project/commit/64576a1be887b7afcacf0534e6c168805fba5677.diff

[Lldb-commits] [lldb] 5bebc0b - [lldb] Decouple ObjCLanguage from Symtab

2021-06-23 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-06-23T13:49:46-07:00 New Revision: 5bebc0b177d0f02af3d8d2b02d182c04763ee468 URL: https://github.com/llvm/llvm-project/commit/5bebc0b177d0f02af3d8d2b02d182c04763ee468 DIFF: https://github.com/llvm/llvm-project/commit/5bebc0b177d0f02af3d8d2b02d182c04763ee468.diff

[Lldb-commits] [lldb] 8e6b31c - [LLDB] Move Trace-specific classes into separate library

2021-07-21 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-07-21T13:28:34-07:00 New Revision: 8e6b31c3952b366fc3fa0da8e3df7fc09fa65b05 URL: https://github.com/llvm/llvm-project/commit/8e6b31c3952b366fc3fa0da8e3df7fc09fa65b05 DIFF: https://github.com/llvm/llvm-project/commit/8e6b31c3952b366fc3fa0da8e3df7fc09fa65b05.diff

[Lldb-commits] [lldb] e42edce - [lldb][NFC] Delete unused and commented out DWARF constants

2021-07-26 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-07-26T12:26:35-07:00 New Revision: e42edce4a349efeedde2ffd07a26a6335178d24b URL: https://github.com/llvm/llvm-project/commit/e42edce4a349efeedde2ffd07a26a6335178d24b DIFF: https://github.com/llvm/llvm-project/commit/e42edce4a349efeedde2ffd07a26a6335178d24b.diff

[Lldb-commits] [lldb] 0a74fbb - [lldb][NFC] Fix incorrect log and comment

2021-07-27 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-07-27T14:43:42-07:00 New Revision: 0a74fbb7b1d3e04ac03389f1fc455ac593c2e5ee URL: https://github.com/llvm/llvm-project/commit/0a74fbb7b1d3e04ac03389f1fc455ac593c2e5ee DIFF: https://github.com/llvm/llvm-project/commit/0a74fbb7b1d3e04ac03389f1fc455ac593c2e5ee.diff

[Lldb-commits] [lldb] 993220a - [lldb] Remove CPlusPlusLanguage from Mangled

2021-07-29 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-07-29T13:58:35-07:00 New Revision: 993220a99ccef6657d6d5d04dc51c06255f285f2 URL: https://github.com/llvm/llvm-project/commit/993220a99ccef6657d6d5d04dc51c06255f285f2 DIFF: https://github.com/llvm/llvm-project/commit/993220a99ccef6657d6d5d04dc51c06255f285f2.diff

[Lldb-commits] [lldb] d2b2ab4 - [lldb] Further constrain a test that fails without python enabled

2021-08-03 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-08-03T11:50:36-07:00 New Revision: d2b2ab4e1c347161b622b9dc2553de04f9f82f04 URL: https://github.com/llvm/llvm-project/commit/d2b2ab4e1c347161b622b9dc2553de04f9f82f04 DIFF: https://github.com/llvm/llvm-project/commit/d2b2ab4e1c347161b622b9dc2553de04f9f82f04.diff

[Lldb-commits] [lldb] 4947f6d - [lldb][NFC] Remove unused header include

2021-08-19 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-08-19T11:06:56-07:00 New Revision: 4947f6d8bca1e33a663b01e3027e11d654c418fc URL: https://github.com/llvm/llvm-project/commit/4947f6d8bca1e33a663b01e3027e11d654c418fc DIFF: https://github.com/llvm/llvm-project/commit/4947f6d8bca1e33a663b01e3027e11d654c418fc.diff

[Lldb-commits] [lldb] 23c1939 - [lldb][NFC] Remove unused method RichManglingContext::IsFunction

2021-08-23 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-08-23T11:45:55-07:00 New Revision: 23c19395c085306cf229341523b6a8909b3b70a9 URL: https://github.com/llvm/llvm-project/commit/23c19395c085306cf229341523b6a8909b3b70a9 DIFF: https://github.com/llvm/llvm-project/commit/23c19395c085306cf229341523b6a8909b3b70a9.diff

[Lldb-commits] [lldb] cd2134e - [lldb] Refactor Module::LookupInfo constructor

2021-08-24 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-08-24T13:53:49-07:00 New Revision: cd2134e42aa7d1168a3ed54e41793b022f961b1f URL: https://github.com/llvm/llvm-project/commit/cd2134e42aa7d1168a3ed54e41793b022f961b1f DIFF: https://github.com/llvm/llvm-project/commit/cd2134e42aa7d1168a3ed54e41793b022f961b1f.diff

[Lldb-commits] [lldb] ce512d5 - Revert "[lldb] Refactor Module::LookupInfo constructor"

2021-08-24 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-08-24T14:52:17-07:00 New Revision: ce512d5c2af58515378f5ecd989cdc0ccea8c997 URL: https://github.com/llvm/llvm-project/commit/ce512d5c2af58515378f5ecd989cdc0ccea8c997 DIFF: https://github.com/llvm/llvm-project/commit/ce512d5c2af58515378f5ecd989cdc0ccea8c997.diff

[Lldb-commits] [lldb] 862a311 - [lldb] Tighten lock in Language::ForEach

2021-08-31 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-08-31T15:45:38-07:00 New Revision: 862a311301f51214d405eefd5bc4aa7289241f86 URL: https://github.com/llvm/llvm-project/commit/862a311301f51214d405eefd5bc4aa7289241f86 DIFF: https://github.com/llvm/llvm-project/commit/862a311301f51214d405eefd5bc4aa7289241f86.diff

[Lldb-commits] [lldb] e566dd7 - [lldb] Delete some commented out code in ClangASTSource.cpp

2020-03-03 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-03-03T13:17:21-08:00 New Revision: e566dd733d642052cf261c20e0e82f18b8e3d6fe URL: https://github.com/llvm/llvm-project/commit/e566dd733d642052cf261c20e0e82f18b8e3d6fe DIFF: https://github.com/llvm/llvm-project/commit/e566dd733d642052cf261c20e0e82f18b8e3d6fe.diff

[Lldb-commits] [lldb] r373134 - [Core] Remove unused dependency on clangAST

2019-09-27 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Sep 27 17:27:24 2019 New Revision: 373134 URL: http://llvm.org/viewvc/llvm-project?rev=373134&view=rev Log: [Core] Remove unused dependency on clangAST Modified: lldb/trunk/source/Core/CMakeLists.txt lldb/trunk/source/Core/DumpDataExtractor.cpp Modified: lldb/tr

[Lldb-commits] [lldb] r347721 - Remove dead code from IOHandler

2019-10-04 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Nov 27 15:37:47 2018 New Revision: 347721 URL: http://llvm.org/viewvc/llvm-project?rev=347721&view=rev Log: Remove dead code from IOHandler This has been dead since 2014 according to the blame Modified: lldb/trunk/source/Core/IOHandler.cpp Modified: lldb/trunk/sour

[Lldb-commits] [lldb] r373990 - [Symbol] Remove unused method ClangASTContext::GetObjCClassName

2019-10-07 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Oct 7 16:43:33 2019 New Revision: 373990 URL: http://llvm.org/viewvc/llvm-project?rev=373990&view=rev Log: [Symbol] Remove unused method ClangASTContext::GetObjCClassName Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h lldb/trunk/source/Symbol/ClangAS

[Lldb-commits] [lldb] r374100 - [CMake] Fix building without python on Windows

2019-10-08 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Oct 8 11:38:46 2019 New Revision: 374100 URL: http://llvm.org/viewvc/llvm-project?rev=374100&view=rev Log: [CMake] Fix building without python on Windows Summary: find_python_libs_windows might set LLDB_DISABLE_PYTHON to ON. Unfortunately we do not re-check this variabl

[Lldb-commits] [lldb] r374468 - [lldb-test] Remove unused header

2019-10-10 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Oct 10 15:43:03 2019 New Revision: 374468 URL: http://llvm.org/viewvc/llvm-project?rev=374468&view=rev Log: [lldb-test] Remove unused header Modified: lldb/trunk/tools/lldb-test/lldb-test.cpp Modified: lldb/trunk/tools/lldb-test/lldb-test.cpp URL: http://llvm.org/v

[Lldb-commits] [lldb] r374587 - [NativePDB] Remove unused references to ClangASTImporter

2019-10-11 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Oct 11 13:12:29 2019 New Revision: 374587 URL: http://llvm.org/viewvc/llvm-project?rev=374587&view=rev Log: [NativePDB] Remove unused references to ClangASTImporter Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp lldb/trunk/source

[Lldb-commits] [lldb] db54245 - [Symbol] Change ClangASTContext::GetCXXClassName return type

2019-10-31 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2019-10-31T11:57:37-07:00 New Revision: db542455dc0f5873851e220bf72a8394767c61fb URL: https://github.com/llvm/llvm-project/commit/db542455dc0f5873851e220bf72a8394767c61fb DIFF: https://github.com/llvm/llvm-project/commit/db542455dc0f5873851e220bf72a8394767c61fb.diff

[Lldb-commits] [lldb] 40f3d13 - [TestMTCSimple] Disable the test if you don't have libMTC

2019-11-05 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2019-11-05T14:11:26-08:00 New Revision: 40f3d1307cfd66e6dc1a921eec42559a6691b393 URL: https://github.com/llvm/llvm-project/commit/40f3d1307cfd66e6dc1a921eec42559a6691b393 DIFF: https://github.com/llvm/llvm-project/commit/40f3d1307cfd66e6dc1a921eec42559a6691b393.diff

[Lldb-commits] [lldb] a6b5daa - [test] Fix apple_simulator_test decorator when simulators are unavailable

2019-11-06 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2019-11-06T15:14:01-08:00 New Revision: a6b5daa701d3a276ace90c688f913b96d396bed1 URL: https://github.com/llvm/llvm-project/commit/a6b5daa701d3a276ace90c688f913b96d396bed1 DIFF: https://github.com/llvm/llvm-project/commit/a6b5daa701d3a276ace90c688f913b96d396bed1.diff

[Lldb-commits] [lldb] r366770 - [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up

2019-07-22 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Jul 22 17:28:26 2019 New Revision: 366770 URL: http://llvm.org/viewvc/llvm-project?rev=366770&view=rev Log: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up Summary: Delete the android target from `libstdcpp` test category, since android no longer su

[Lldb-commits] [lldb] r366771 - [lldb][test_suite] Fix skipIfTargetAndroid decorator

2019-07-22 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Jul 22 17:41:00 2019 New Revision: 366771 URL: http://llvm.org/viewvc/llvm-project?rev=366771&view=rev Log: [lldb][test_suite] Fix skipIfTargetAndroid decorator Summary: Delete the duplicate func `skipIfTargetAndroid` Fix the old one. It didn't work for missing an argume

[Lldb-commits] [lldb] r366858 - [lldb][test_suite] Update tests with unexpected pass on Android aarch64

2019-07-23 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Jul 23 15:12:16 2019 New Revision: 366858 URL: http://llvm.org/viewvc/llvm-project?rev=366858&view=rev Log: [lldb][test_suite] Update tests with unexpected pass on Android aarch64 Summary: update some test decorates that can actually pass on andriod aarch64 Patch by Wan

<    8   9   10   11   12   13   14   15   16   17   >