[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord created this revision. bulbazord added reviewers: aprantl, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While measuring some performance in LLDB I noticed that we were spendi

[Lldb-commits] [PATCH] D149218: [lldb] Fix another GCC build failure in ScriptedPythonInterface.h

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Unfortunate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149218/new/ https://reviews.llvm.org/D149218 _

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

This revision was automatically updated to reflect the committed changes. Closed by commit rGc997acb97a9b: [lldb] Add support for specifying language when setting watchpoint by expression (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

bulbazord requested changes to this revision. bulbazord added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:339 + if (stack_frame_size == 0) +stack_frame_size = arch == llvm::Triple::msp430 ?

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

bulbazord added a comment. Looks like this test does not pass on windows: https://lab.llvm.org/buildbot/#/builders/219/builds/2389 I'm aware and working on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149111/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

bulbazord added a comment. In D149111#4299871 , @bulbazord wrote: > Looks like this test does not pass on windows: > https://lab.llvm.org/buildbot/#/builders/219/builds/2389 > > I'm aware and working on this. I marked the test as unsupported on windows

[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

bulbazord created this revision. bulbazord added a reviewer: jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. FileSpec::GetFileNameExtension returns a string where the first character is g

[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

bulbazord added a comment. In D149284#4299933 , @jasonmolenda wrote: > I added this in 2016 via 243bd763ecad466fac748b565ea52c661107684d and I have > no idea what it is for. I know of no such prefix related to kernel > debugging. Let's remove it inst

[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

bulbazord updated this revision to Diff 517309. bulbazord added a comment. Remove code instead of attempting to fix things Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149284/new/ https://reviews.llvm.org/D149284 Files: lldb/source/Plugins/Plat

[Lldb-commits] [PATCH] D149284: [lldb] Remove finding .Bundle directories in PlatformDarwinKernel

This revision was automatically updated to reflect the committed changes. Closed by commit rG33d6bd1c6674: [lldb] Remove finding .Bundle directories in PlatformDarwinKernel (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149284

[Lldb-commits] [PATCH] D149300: [lldb] Change return type of FileSpec::GetFileNameExtension

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. These do

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord added a comment. In D149214#4300491 , @aprantl wrote: > Did you also measure the extra memory consumption? I would be surprised if > this mattered, but we do parse a lot of DWARF DIEs... > > Generally this seems fine. I compared the memory pro

[Lldb-commits] [PATCH] D149300: [lldb] Change return type of FileSpec::GetFileNameExtension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6fcdfc378c2f: [lldb] Change return type of FileSpec::GetFileNameExtension (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

bulbazord added inline comments. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:339 + if (stack_frame_size == 0) +stack_frame_size = arch == llvm::Triple::msp430 ? 512 : 512 * 1024; kuilpd wrote: > bulbazord wrote: > > jingham wrote: > >

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

bulbazord added inline comments. Comment at: lldb/source/Symbol/LocateSymbolFile.cpp:89-91 + dsym_file.append(".dSYM"); + llvm::sys::path::append(dsym_file, path_style, "Contents", "Resources", + "DWARF", filename); mib wrote: > Why do

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

bulbazord updated this revision to Diff 517725. bulbazord added a comment. Address @mib's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149096/new/ https://reviews.llvm.org/D149096 Files: lldb/source/Symbol/LocateSymbolFile.cpp Index:

[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

bulbazord added a comment. LGTM overall. A few nits but overall an excellent cleanup! :) Comment at: lldb/source/Host/macosx/objcxx/Host.mm:337 + + LLDB_LOG(log, "Sending {0}:{1} to external editor", file_path, line_no); + nit: Move log line below checking if

[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

bulbazord added inline comments. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:337 + + LLDB_LOG(log, "Sending {0}:{1} to external editor", file_path, line_no); + JDevlieghere wrote: > bulbazord wrote: > > nit: Move log line below checking if the file_path i

[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

bulbazord accepted this revision. bulbazord added a comment. LGTM! Thanks for cleaning this up. Comment at: lldb/source/Target/Thread.cpp:1762-1763 + frame_sc.line_entry.file, frame_sc.line_entry.line)) { +LLDB_LOG_ERROR(GetLog(LLDBLog::Host), std::

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. Mostly looks good to me, just a small thing about an implementation detail. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:38 +using namespace ll

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. llvm has a structure for maps where the key's type

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

bulbazord added inline comments. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:340-348 +Process *process_sp; +ABISP abi_sp; +if ((process_sp = exe_ctx.GetProcessPtr()) && +(abi_sp = process_sp->GetABI())) { + stack_frame_si

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

bulbazord added a comment. Sorry I should have brought this up earlier but I've noticed you don't have any tests with this change. Is it possible you could add something there? Something to make sure that these settings work as expected. Sorry for the churn btw, I really appreciate your patienc

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

bulbazord added inline comments. Comment at: lldb/source/Core/Disassembler.cpp:846 +// Note: The reason we are making the data_type a uint64_t when value is +// uint32_t is that there is no eTypeUInt32 enum value. +if (llvm::StringRef(value) == "uint32_t"

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

bulbazord added a comment. In D149262#4306884 , @kuilpd wrote: > In D149262#4306820 , @bulbazord > wrote: > >> Sorry I should have brought this up earlier but I've noticed you don't have >> any tests with this c

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

bulbazord updated this revision to Diff 518542. bulbazord added a comment. Sort output for dumping to be deterministic (based on alphabetical order like previous implementation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/ https://rev

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

bulbazord requested changes to this revision. bulbazord added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:395-396 - static std::optional g_app_fsref; - static std::string g_app_error; - static std::once_f

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for adding the test. The test itself doesn't seem portable and likely will fail on several platforms though I'm not sure which off the top of my head. After landing this, please w

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149565/new/ https://reviews.llvm.org/D149565 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

bulbazord updated this revision to Diff 518569. bulbazord added a comment. Remove unneeded StringRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/ https://reviews.llvm.org/D149482 Files: lldb/include/lldb/Interpreter/OptionValueDicti

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

This revision was automatically updated to reflect the committed changes. Closed by commit rGe53e1de57ecc: [lldb] Change ObjectValueDictionary to use a StringMap (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/ http

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There's no reason to create an entire new filespec to mutate and

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bea2d7b070d: [lldb] Refactor SBFileSpec::GetDirectory (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149625/new/ https://reviews.ll

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. As far a

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. In D149625#4312838 , @jingham wrote: > The old code had the side-effect of NOT resolving the path of the SBFileSpec > in order to get its directory. I am not sure whether that was on purpose or > not, however. To be more pre

[Lldb-commits] [PATCH] D149671: [lldb] Minor cleanups at callsites of FileSpec::GetFileNameExtension

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. FileSpec::GetFileNameExtension returns a StringRef.

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

bulbazord added a comment. In D149663#4313112 , @mib wrote: > @bulbazord What if the FileSpec is pointing to a directory instead of a file > ? What would `GetFilename` return in that case compared to > `GetLastPathComponent` ? FileSpec chops everything

[Lldb-commits] [PATCH] D149697: [lldb] Remove distribution_id from ArchSpec

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, labath, DavidSpickett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The qHostInfo packet in the gdb-remote communication pro

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

bulbazord abandoned this revision. bulbazord added a comment. I'm going to see how we could potentially improve FileSpec's performance rather than go with this approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149096/new/ https://reviews.llv

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

bulbazord added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:493 eLanguageTypeAda2012 = 0x002f, + eLanguageTypeMojo = 0x0030, These values correspond to DWARF5's official language codes and `0x0030` is technically already taken. LLDB

[Lldb-commits] [PATCH] D149671: [lldb] Minor cleanups at callsites of FileSpec::GetFileNameExtension

This revision was automatically updated to reflect the committed changes. Closed by commit rG50e79d725c10: [lldb] Minor cleanups at callsites of FileSpec::GetFileNameExtension (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4f3f5225df7: [lldb] Remove FileSpec::GetLastPathComponent (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/ https://review

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

bulbazord added a reviewer: JDevlieghere. bulbazord added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:503-504 + /// Manually start the global event handler thread. It should be used by + /// programs that use LLDB as a library. + bool StartEventHandlerThre

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

bulbazord added inline comments. Comment at: lldb/include/lldb/Expression/REPL.h:115-120 + virtual void + OnExpressionEvaluated(const ExecutionContext &exe_ctx, llvm::StringRef code, +const EvaluateExpressionOptions &expr_options, +

[Lldb-commits] [PATCH] D149697: [lldb] Remove distribution_id from ArchSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd05ffdbb2c3: [lldb] Remove distribution_id from ArchSpec (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149697/new/ https://reviews

[Lldb-commits] [PATCH] D149774: [lldb] Use templates to simplify {Get, Set}PropertyAtIndex (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I quite like the idea. Probably want to wait for others to look over it but I think it's good! Comment at: lldb/source/Core/Debugger.cpp:394 const uint32_t idx = eP

[Lldb-commits] [PATCH] D149804: [lldb][NFCI] Add unittests for ObjCLanguage::MethodName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, Michael137, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I have a patch to refactor this class and I'd like a

[Lldb-commits] [PATCH] D149803: Use the `addressing_bits` kv in the stop packet from the remote stub, if present

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149803/new/ https://reviews.llvm.org/D149803 ___

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

bulbazord added inline comments. Comment at: lldb/include/lldb/Expression/REPL.h:124 +const lldb::ValueObjectSP &result_valobj_sp, +const Status &error) { +return llvm::Error::success(); Do you still need the `S

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149717/new/ https://reviews.llvm.org/D149717 _

[Lldb-commits] [PATCH] D149900: [lldb] Expose a const iterator for SymbolContextList

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB. The

[Lldb-commits] [PATCH] D149804: [lldb][NFCI] Add unittests for ObjCLanguage::MethodName

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc39d98c3faa: [lldb][NFCI] Add unittests for ObjCLanguage::MethodName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149804/new/ htt

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, mib, jingham, kastiglione. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D149900: [lldb] Expose a const iterator for SymbolContextList

bulbazord updated this revision to Diff 519690. bulbazord added a comment. Explicitly write out type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149900/new/ https://reviews.llvm.org/D149900 Files: lldb/include/lldb/Breakpoint/BreakpointResolve

[Lldb-commits] [PATCH] D149900: [lldb] Expose a const iterator for SymbolContextList

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04aa943be8ed: [lldb] Expose a const iterator for SymbolContextList (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D149900: [lldb] Expose a const iterator for SymbolContextList

bulbazord added a comment. Looks like this may have broken the Debian buildbot: https://lab.llvm.org/buildbot/#/builders/68/builds/52162/steps/6/logs/stdio I'm taking a look and will try to fix forward. If I can't figure it out quickly, I will revert. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

bulbazord added a comment. We're definitely going to want a test for this, either a shell test or a unit test. Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104 + + return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset, +

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

bulbazord added inline comments. Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104 + + return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset, +length); +} compnerd wrote: > bulbazord wro

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149987/new/ https://reviews.llvm.org/D149987 _

[Lldb-commits] [PATCH] D149702: [LLDB] Add minimal support for the new Mojo language

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Don't forget to come back and update it when you get an official designation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149702/new/ ht

[Lldb-commits] [PATCH] D150160: [lldb] Simplify Log::PutString (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Utility/Log.cpp:135 -void Log::PutCString(const char *cstr) { Printf("%s", cstr); } -void Log::PutString(llvm::StringRef str) { PutCString(

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

bulbazord added a comment. This looks good to me. > This patch does have a regression on > API/macosx/unregistered-macho/TestUnregisteredMacho.py that I wrote last > summer; I have the patch generate JSON for a binary that it had an address > for, but could not read the mach-o headers. This te

[Lldb-commits] [PATCH] D150168: [lldb] Simplify predicates of find_if in BroadcastManager

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We had some custom classes that were used as the predicate for `s

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I have no problem with removing mod_date since you're only removing the requirement in the Darwin-specific code. Also, be sure to remove the portion of the commit message that says this

[Lldb-commits] [PATCH] D150168: [lldb] Simplify predicates of find_if in BroadcastManager

This revision was automatically updated to reflect the committed changes. Closed by commit rGec77d1f3d9fc: [lldb] Simplify predicates of find_if in BroadcastManager (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150168/new/ h

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

bulbazord accepted this revision. bulbazord added a comment. I like this. :) Comment at: lldb/source/Utility/Broadcaster.cpp:392 } -m_event_map.erase(iter); +iter = m_event_map.erase(iter); } I don't think you need to actually capture the iterat

[Lldb-commits] [PATCH] D150222: [lldb][NFCI] Remove custom dwarf LEB128 types

bulbazord created this revision. bulbazord added reviewers: aprantl, rastogishubham, fdeazeve, JDevlieghere, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The LEB128 type defined by the DW

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

bulbazord added inline comments. Comment at: lldb/include/lldb/API/SBBreakpoint.h:18-19 class ScriptInterpreter; +namespace python { +class SWIGBridge; } mib wrote: > We've talked about this offline, but I think we should stay language agnostic > in the SBAPI,

[Lldb-commits] [PATCH] D150222: [lldb][NFCI] Remove custom dwarf LEB128 types

This revision was automatically updated to reflect the committed changes. Closed by commit rGb77e41f2886a: [lldb][NFCI] Remove custom dwarf LEB128 types (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150222/new/ https://revie

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

bulbazord added inline comments. Comment at: lldb/unittests/API/SBCommandInterpreterTest.cpp:24 SBDebugger::Initialize(); m_dbg = SBDebugger::Create(/*source_init_files=*/false); } jingham wrote: > It isn't clear to me how the changes in this file fi

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord created this revision. bulbazord added reviewers: aprantl, rastogishubham, fdeazeve, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB currently defines `dw_form_t` as a `uint16_

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord added a reviewer: JDevlieghere. bulbazord added a comment. In D150228#4330798 , @jingham wrote: > Apparently a similar change was made with dw_tag_t, in the line below your > first deletion I see: > > typedef llvm::dwarf::Tag dw_tag_t; > > It s

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord updated this revision to Diff 520853. bulbazord added a comment. Do a typedef in dwarf.h (like llvm::dwarf::Tag) instead of explicitly writing the type out everywhere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/ https://revi

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord updated this revision to Diff 520854. bulbazord added a comment. Remove unused include in header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/ https://reviews.llvm.org/D150228 Files: lldb/include/lldb/Core/dwarf.h lldb/so

[Lldb-commits] [PATCH] D150235: [lldb] Change definition of DisassemblerCreateInstance

bulbazord created this revision. bulbazord added reviewers: jingham, mib, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DissassemblerCreateInstance is a function pointer whos return typ

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4331048 , @jingham wrote: > Most of this is fine. I wonder about avoiding caching the full name and name > w/o category & selector name. One of the main uses of this class is to take > incoming ObjC names from the

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

bulbazord added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:103-104 - void GetFramesUpTo(uint32_t end_idx); + /// Gets frames up to end_idx (which can be greater than the actual number of + /// frames.) Returns true if the function was interrupted

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord added a comment. In D150228#4331943 , @fdeazeve wrote: > Do you have plans to do something similar for the attribute typedef? Yes I would like to do that too! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

bulbazord updated this revision to Diff 521047. bulbazord added a comment. Fix a warning in HashedNameToDIE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/ https://reviews.llvm.org/D150228 Files: lldb/include/lldb/Core/dwarf.h lldb/s

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ec334dc7b73: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/ https

[Lldb-commits] [PATCH] D150299: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute

bulbazord created this revision. bulbazord added reviewers: aprantl, jingham, clayborg, rastogishubham, fdeazeve. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald adde

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

bulbazord added a comment. In D150303#4333215 , @rriddle wrote: > Could we switch the RTTI to use the llvm RTTI extension mechanism, instead of > enums? Other classes have started doing this, and it'd be really nice if > users can write REPLS without ne

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

bulbazord accepted this revision. bulbazord added a comment. LGTM! I know we have this pattern in many places in LLDB. It's good to see this work being done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150363/new/ https://reviews.llvm.org/D15036

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. Ok, I'm back with actual data on this patch. I have a test ObjC app with some UI, it loads a couple hundred modules. I place a breakpoint on main, I run until we hit main, and then I continue. My app will stop at `-[NSBlockOperation main]` after loading all the requir

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord updated this revision to Diff 521414. bulbazord added a comment. Update documentation for clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149914/new/ https://reviews.llvm.org/D149914 Files: lldb/source/Plugins/Language/ObjC/ObjCL

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4335858 , @aprantl wrote: > I'm not opposed to using this implementation, but have you considered using > something like the stdlib regex library to do the heavy lifting? I had not considered it actually... I don't

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:61 uint8_t m_has_children = 0; - DWARFAttribute::collection m_attributes; }; kastiglione wrote: > With this change, can the following be removed

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

bulbazord created this revision. bulbazord added reviewers: aprantl, JDevlieghere, clayborg, jingham, rastogishubham, fdeazeve. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LL

[Lldb-commits] [PATCH] D150366: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

bulbazord added a comment. Ok, this looks like it's doing the same thing to me which is good. My understanding of this change is that you're changing `lldb::DWARFDebugRanges::Extract` to use `llvm::DWARFDebugRangeList` instead of `lldb::DWARFRangeList`. Out of curiosity, do you have an idea of

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, mib, jingham, labath, kastiglione, rastogishubham, fdeazeve, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord abandoned this revision. bulbazord added a comment. Thanks for the reviews and suggestions. I took a step back and looked at DWARFAbbreviationDeclaration and DWARFAttribute in more detail and I've decided I'm going to take this in a slightly different direction. I don't want to repurp

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord added a comment. I previously uploaded a similar patch that I've since abandoned. It contains valuable context so I'm linking it here for other contributors to read: D149214 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord added a comment. In D150418#4337243 , @JDevlieghere wrote: > Given the numbers I'm surprised you decided to stick with 8 rather than 4? > Unless I'm reading them wrong, it seems that despite the number of > allocations, it's about as fast and

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

bulbazord added a comment. In D150402#4337400 , @fdeazeve wrote: > Thanks for doing this! In particular, all the early returns are very welcome > :) > > I suspect you already have this in your radar, but `ExtractFormValueAtIndex` > could probably return

[Lldb-commits] [PATCH] D150299: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG64f1fda29e2d: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1502

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGc909b491cb5f: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D150402?vs=521453&id=521757#toc Repository

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord updated this revision to Diff 521771. bulbazord added a comment. - Use emplace_back - llvm::SmallVector size 8 -> 4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150418/new/ https://reviews.llvm.org/D150418 Files: lldb/source/Plugins/S

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG050c09f0bed6: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl (authored by bulbazord). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

bulbazord added a comment. This is going to need some tests... And because you're adding templates to the SBAPI we'll need multiple tests -- Not just on the python side but I think we should add some actual C++ tests here in `test/API/api/` Comment at: lldb/include/lldb/API/S

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. > AssertionError: > 'C:\\Users\\tcwg\\llvm-worker\\lldb-aarch64-windows\\build\\lldb-test-build.noindex\\functionalities\\process_save_core\\TestProcessSaveCore.test_save_windows_mini_dump_dwarf\\a.out' > not found in > ['C:/Users/tcwg/llvm-worker/lldb-aarch64-windows

<    2   3   4   5   6   7   8   9   10   11   >