[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, amccarth, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, jfb. This patch adds support of watchpoints to the new `NativeProcessWindows` plugin. The sam

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218897. aleksandr.urakov added a comment. Determine whether 8-byte watchpoints are supported or not statically. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 Files: ll

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov marked 3 inline comments as done. aleksandr.urakov added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:82 -bool RegisterContextWindows::ClearHardwareBreakpoint(uint32_t hw_idx) { - return false; -} + if (!

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov added a comment. Thanks all! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

This revision was automatically updated to reflect the committed changes. Closed by commit rL371166: [Windows] Add support of watchpoints to `ProcessWindows` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[Lldb-commits] [PATCH] D67347: [Windows] Use EH info from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov created this revision. Herald added subscribers: llvm-commits, lldb-commits, JDevlieghere, MaskRay, arichardson, aprantl, mgorny, emaste. Herald added a reviewer: espindola. Herald added projects: LLDB, LLVM. This patch adds an implementation of reconstructing of unwind plans fro

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. It's a good point, thank you! I had the same thoughts when I done it, but I'm not completely sure. The problem is that an object file can't be completely responsible for choosing an unwind plan, because some plans are produced by symbol files (and an object fil

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov updated this revision to Diff 219853. aleksandr.urakov added a comment. Update diff due to Pavel's requests. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347 Files: lldb/include/lldb/Symbol/DWARFCallFr

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov marked 4 inline comments as done. aleksandr.urakov added a comment. Thanks all for taking a look! In D67347#1666509 , @amccarth wrote: > This patch is pretty large. It might be easier to break it up into a series > of small steps to get

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov updated this revision to Diff 220144. aleksandr.urakov edited the summary of this revision. aleksandr.urakov added a comment. Update due to the requests. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov marked 4 inline comments as done. aleksandr.urakov added a comment. Hi Jason, thanks for the review! Initially, the reason of these changes was to reuse the code that works with `eh_frame`, because on Windows we have a very similar compiler generated info designed to help with

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov updated this revision to Diff 221671. aleksandr.urakov added a comment. Update the patch due to Pavel's request. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67222/new/ https://reviews.llvm.org/D67222 Files: lldb/source/Plugins/Process/Wind

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov added a reviewer: labath. aleksandr.urakov added a comment. In D67222#1680613 , @labath wrote: > Btw, in the context of D67954 , I realized > that I don't know how to actually enable the usage of lldb-serv

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

aleksandr.urakov added a subscriber: leonid.mashinskiy. aleksandr.urakov added a comment. In D67954#1680536 , @labath wrote: > Have you considered going the "native" route directly? My understanding is > that this route is already functional on x86 (modul

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. Gentle ping! What do you think of this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

This revision was automatically updated to reflect the committed changes. Closed by commit rL359420: [Windows] Dump more information about access violation exception (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. @lanza Hello! AFAIU, these values have nothing to do with the Microsoft x64 calling convention. They are used by `ABISysV_x86_64`, which specifies ABI for working with code injectable into a process being debugged. It requires six arguments to be passed through

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. In D53753#1504361 , @labath wrote: > I'm not sure what exactly are the consequences of not using the correct ABI > definition here. I think the case where the difference may start to become > obvious is if you try to get

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. In D53753#1504589 , @labath wrote: > When we evaluate an expression, we jit a bunch of opcodes into the inferior > memory and then have it execute them. For that to work, we need to allocate > some memory in order to sto

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. Ah, yes, sure, it will just be moved on the `lldb-server` side. Thanks again for the clarification! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53753/new/ https://reviews.llvm.org/D53753 _

[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62021/new/ https://reviews.llvm.org/D62021 ___

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: aprantl, teemperor. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. Sometimes a result variable of some expression can be presented as an elaborated type. In this case the methods `IsTypedef

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov updated this revision to Diff 259509. aleksandr.urakov added reviewers: labath, leonid.mashinskiy. aleksandr.urakov added a comment. Hello, Pavel! Thanks for the review. Yes, this method looks like a better fit, I just didn't notice it before. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov updated this revision to Diff 259864. aleksandr.urakov added a comment. Thanks! Fixed. The only thing is that `GetCString()` can return `nullptr`, which leads to `None` in Python, so I made a simple wrapper for that. I'm not very deep into the testing infrastructure, so I'm not

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov added a comment. The problem here is that in the case of success `GetCString()` returns `nullptr`, and we fail on concatenation with `None` even if the expression was evaluated successfully. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov updated this revision to Diff 260235. aleksandr.urakov added a comment. Exactly! Removed unneeded wrapper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78697/new/ https://reviews.llvm.org/D78697 Files: lldb/source/Plugins/TypeS

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

This revision was automatically updated to reflect the committed changes. Closed by commit rG84c398d375d9: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a… (authored by aleksandr.urakov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

aleksandr.urakov added a comment. Hello! Thanks for the patch, generally it looks good to me, the only thing I worry about is scoped enums (please, see the comment below). Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7324-7331 + // If the variable is a

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

aleksandr.urakov added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7324-7331 + // If the variable is an enum type, take the underlying integer type as + // the type of the integer literal. + if (const EnumType *enum_type = llvm::dyn_ca

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82160/new/ https://reviews.llvm.org/D82160 __

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG895529cfd875: [lldb][PDB] Constexpr static member values as AST literals (authored by aleksandr.urakov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82160/

<    1   2   3   4