[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, zturner, rnk, labath, clayborg, lldb-commits. Herald added a subscriber: JDevlieghere. In this patch I've tried to combine the best ideas from https://reviews.llvm.org/D49368 and https://reviews.llvm.org/D49410, so

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/PDB/udt-layout.test:1-51 +REQUIRES: windows +RUN: clang-cl /Zi %S/Inputs/UdtLayoutTest.cpp /o %t.exe +RUN: %lldb -b -s %S/Inputs/UdtLayoutTest.script -- %t.exe | FileCheck %s + +CHECK:(int) int C::abc = 123 +CHECK

[Lldb-commits] [PATCH] D49368: Complete user-defined types from PDB symbol files

aleksandr.urakov abandoned this revision. aleksandr.urakov added a comment. Abandoned due to https://reviews.llvm.org/D49980 https://reviews.llvm.org/D49368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov updated this revision to Diff 158194. aleksandr.urakov added a comment. Added support of a MSInheritance attribute. https://reviews.llvm.org/D49980 Files: include/lldb/Symbol/ClangASTContext.h lit/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp lit/SymbolFile/PDB/Inputs/Pointer

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov added a comment. Ping! Can you review this, please? https://reviews.llvm.org/D49980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov added a comment. Unfortunately, there was no people yet, who can review this :) Ping! Can anyone review this, please? https://reviews.llvm.org/D49980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov added a comment. Thanks a lot! https://reviews.llvm.org/D49980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

This revision was automatically updated to reflect the committed changes. Closed by commit rL339649: [PDB] Parse UDT symbols and pointers to members (combined patch) (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov added a comment. Thanks for catching that! I didn't know about that warnings because I build LLVM with MSVC compiler, but it doesn't introduce such warnings. Now I've fixed the problem with https://reviews.llvm.org/rLLDB339994. Repository: rL LLVM https://reviews.llvm.org/

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov added a comment. Yes, I've seen today that this test is failing now, but if I'm not mistaken this have happened some later than this patch was committed. But I'm not sure, I'll look at this more precisely tomorrow, thanks! Repository: rL LLVM https://reviews.llvm.org/D49980

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov added a comment. It's also possible that the test has been failing since some commit in another repository (e.g. `clang`, `lld` or `llvm`). It seems that it was ok several days ago... Repository: rL LLVM https://reviews.llvm.org/D49980 ___

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov added a subscriber: labath. aleksandr.urakov added a comment. It seems that the cause of the failure is https://reviews.llvm.org/rL340206, but I'm not sure if the adding of `-gpubnames` switch to `clang` will be a correct fix for that? Repository: rL LLVM https://reviews.ll

[Lldb-commits] [PATCH] D51104: [PDB] Resolve a symbol context block info correctly

aleksandr.urakov added a comment. Thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D51104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51104: [PDB] Resolve a symbol context block info correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rL340901: [PDB] Resolve a symbol context block info correctly (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D511

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added a comment. Herald added a subscriber: teemperor. Ping! Can you review this, please? Repository: rLLDB LLDB https://reviews.llvm.org/D51162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov updated this revision to Diff 163528. aleksandr.urakov added a comment. Drop a scope part of a class member function name. https://reviews.llvm.org/D51162 Files: include/lldb/Symbol/ClangASTContext.h lit/SymbolFile/PDB/class-layout.test lit/SymbolFile/PDB/func-symbols.tes

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added a comment. Thanks :) Let's also wait for what Aaron will say? Because the patch is big enough. As for testing, what do you think if I'll add complex tests for the expressions evaluation, when it will be ready? I have no other idea how to test the changes in this patch...

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added a comment. Yes, I'll try to implement that, thanks for the idea! https://reviews.llvm.org/D51162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51208: [DWARF] Fix dwarf5-index-is-used.cpp

aleksandr.urakov added a comment. Ok, thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D51208 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51208: [DWARF] Fix dwarf5-index-is-used.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL341296: [DWARF] Fix dwarf5-index-is-used.cpp (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51208?vs=162336&id

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov updated this revision to Diff 163708. aleksandr.urakov added a comment. Added the dumping AST ability to `lldb-test`; adding a corresponding test for the patch. https://reviews.llvm.org/D51162 Files: include/lldb/Symbol/ClangASTContext.h lit/SymbolFile/PDB/Inputs/AstRestor

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov updated this revision to Diff 164026. aleksandr.urakov added a comment. - Fix a typo bug in `AddRecordMethods` (use `continue` instead of `break`); - Do not search function declarations by name during getting of a declaration for a symbol, it may lead to ambiguity. https://revi

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov updated this revision to Diff 164027. aleksandr.urakov added a comment. Code cleanup https://reviews.llvm.org/D51162 Files: include/lldb/Symbol/ClangASTContext.h lit/SymbolFile/PDB/Inputs/AstRestoreTest.cpp lit/SymbolFile/PDB/ast-restore.test lit/SymbolFile/PDB/class-la

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added a comment. Thanks all! https://reviews.llvm.org/D51162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL341782: [PDB] Restore AST from PDB symbols (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51162?vs=164027&id=1

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added a comment. Sorry, I've missed this. I'll fix it tomorrow. Thank you! Repository: rL LLVM https://reviews.llvm.org/D51162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added a comment. In https://reviews.llvm.org/D51162#1229616, @ted wrote: > The "auto from = 0" should be "size_t from = 0", since auto can't determine > the correct type. Yes, I've missed that because MSVC doesn't emit such a warning. Thanks for catching that! Repository:

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:268-269 + +std::unique_ptr +GetClassOrFunctionParent(const llvm::pdb::PDBSymbol &symbol) { + const IPDBSession &session = symbol.getSession(); zturner w

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:289 + return GetClassOrFunctionParent(*lexical_parent); +} + zturner wrote: > However, this is only for symbols (not types). So we can exclude everythi

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added a comment. In https://reviews.llvm.org/D51162#1229112, @stella.stamenova wrote: > This change is causing three of the symbol file PDB tests to fail: > > lldb-Unit :: > SymbolFile/PDB/release/SymbolFilePDBTests.exe/SymbolFilePDBTests.TestClassInNamespace > lldb-Unit ::

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added a comment. @stella.stamenova @ted Fixed with https://reviews.llvm.org/rL341942, thanks again! @zturner I'll rewrite `GetClassOrFunctionParent` and will create a different review for that, ok? Repository: rL LLVM https://reviews.llvm.org/D51162 _

[Lldb-commits] [PATCH] D51967: [PDB] Use the raw PDB symbol interface more accurately

aleksandr.urakov created this revision. aleksandr.urakov added a reviewer: zturner. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds some symbol tag checks before using the `IPDBRawSymbol` interface to improve safety and readability. Repository:

[Lldb-commits] [PATCH] D51967: [PDB] Use the raw PDB symbol interface more accurately

aleksandr.urakov updated this revision to Diff 165231. aleksandr.urakov added a comment. Apply recommended fixes. https://reviews.llvm.org/D51967 Files: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp Index: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp =

[Lldb-commits] [PATCH] D51967: [PDB] Use the raw PDB symbol interface more accurately

aleksandr.urakov added a comment. In https://reviews.llvm.org/D51967#1232534, @zturner wrote: > I've been experimenting with DIA locally and after some investigation I'm not > sure this is going to be reliable. Let's say we have a class, we want the > decl context containing the class. For ex

[Lldb-commits] [PATCH] D51967: [PDB] Use the raw PDB symbol interface more accurately

aleksandr.urakov added a comment. That would be great, thank you! https://reviews.llvm.org/D51967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51967: [PDB] Use the raw PDB symbol interface more accurately

This revision was automatically updated to reflect the committed changes. Closed by commit rL342208: [PDB] Use the raw PDB symbol interface more accurately (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`

aleksandr.urakov added a comment. Herald added a reviewer: serge-sans-paille. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56147/new/ https://reviews.llvm.org/D56147 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`

This revision was automatically updated to reflect the committed changes. Closed by commit rL351065: [Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov updated this revision to Diff 181541. aleksandr.urakov added a comment. @zturner Sorry for the long delay with this update. I've applied the changes we were talking about. @labath Thanks for sharing this, it's interesting to know! CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, rnk, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, abidh. This patch makes virtual bases to be added in the correct order to the bases list. It is impo

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov marked 2 inline comments as done. aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/NativePDB/tag-types.cpp:5 // Test that we can display tag types. // RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s // RUN: env LLDB_USE_NATIVE

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov updated this revision to Diff 183816. aleksandr.urakov added a comment. Herald added a reviewer: serge-sans-paille. Sorry for the long delay with reply. My colleague with a Mac (and Obj-C knowledge) have created the test for the Obj-C case. Can you take a look, please? Reposit

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Ping! Can you take a look, please? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov added a comment. Ping! Can you take a look, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56126/new/ https://reviews.llvm.org/D56126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56126/new/ https://reviews.llvm.org/D56126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

This revision was automatically updated to reflect the committed changes. Closed by commit rL352464: [NativePDB] Add basic support of methods recostruction in AST (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov updated this revision to Diff 184061. aleksandr.urakov added a comment. Thanks for the comments, I think that they make sense. I've updated the patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904 Fil

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/NativePDB/tag-types.cpp:5 // Test that we can display tag types. // RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s // RUN: env LLDB_USE_NATIVE

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

This revision was automatically updated to reflect the committed changes. Closed by commit rL352845: [PDB] Fix location retrieval for function local variables and arguments that are (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Changed prior to commit: https://rev

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Ping! What do you think about it? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov added a comment. Ping! Can you take a look, please? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

This revision was automatically updated to reflect the committed changes. Closed by commit rL353149: [Expressions] Add support of expressions evaluation in some object's context (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. C

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov added a comment. Thank you! I've updated the comments in the commit. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Thanks for the reply! It seems that after your hint I've figured it out. It's the environment variable `VCINSTALLDIR`. I've added it to the `defaultenv` list of the `_get_visual_studio_environment` function and the test passes now. What do you think about this

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: jasonmolenda, labath. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, abidh. This patch makes `x86AssemblyInspectionEngine` to process zero value of the `B` field of the `REX` prefix in a cor

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov updated this revision to Diff 185296. aleksandr.urakov added a comment. Yes, you are right, thank you! I've updated the patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57745/new/ https://reviews.llvm.org/D57745 Files: source/Plugins/Unw

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov updated this revision to Diff 185497. aleksandr.urakov added a comment. Yes, sure, sorry about this, I occasionally have forgot to update the prefixes... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57745/new/ https://reviews.llvm.org/D57745

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. Thanks all for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57745/new/ https://reviews.llvm.org/D57745 ___ lldb-comm

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353281: [x64] Process the B field of the REX prefix correctly for the PUSH and POP (authored by aleksandr.urakov, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, labath, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: lldb-commits. On my system, `clang-cl` can't compile tests containing `char16_

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov updated this revision to Diff 185526. aleksandr.urakov added a comment. I've checked your solution, and it's worked for me too! I think that your solution is better because it is more straight-forward. Here is the updated patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

aleksandr.urakov added a comment. Fixed in r353503, thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov added a comment. Zachary, can you take a look? please? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57809/new/ https://reviews.llvm.org/D57809 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL353709: [build.py] Add `-fms-compatibility-version=19` to `build.py` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Thanks for the help with the tests, it looks like they are ok now! So can we proceed with this patch? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353806: [NativePDB] Process virtual bases in the correct order (authored by aleksandr.urakov, committed by ). Herald ad

[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60068/new/ https://reviews.llvm.org/D60068 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

aleksandr.urakov added a comment. I think both approaches are acceptable, but I would prefer to include it into the Symbols library because this functionality is more symbols-related than general. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60068/new/ https

[Lldb-commits] [PATCH] D60271: PDBFPO: Use references instead of pointers, where possible

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. LGTM too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60271/new/ https://reviews.llvm.org/D60271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D60599: Move postfix expression code out of the NativePDB plugin

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. Sorry for the long delay with the response, I had days off. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60599/new/ https://reviews.llvm.org/D60599

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, asmith, labath, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, aprantl. This patch adds anonymous namespaces support to the native PDB plugin. I had to

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/NativePDB/ast-types.cpp:77 +// FIXME: Should be located in the namespace `A`, in the struct `C<1>`. +A::C<1>::D AC1D; + amccarth wrote: > Is this

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

aleksandr.urakov updated this revision to Diff 195863. aleksandr.urakov added a comment. Thank you for the comments, I agree with you. I've fixed the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60817/new/ https://reviews.llvm.org/D60817 Files: lit/SymbolFile/NativePDB/Inputs

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

aleksandr.urakov added a comment. Thanks for the review! Sorry, I've forgot to include context in the updated patch. Yes, it's exactly the case that is broken, I've left FIXME there until it will be fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60817/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

This revision was automatically updated to reflect the committed changes. Closed by commit rL358873: [NativePDB] Add anonymous namespaces support (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[Lldb-commits] [PATCH] D61003: PostfixExpression: move parser out of NativePDB internals

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61003/new/ https://reviews.llvm.org/D61003 ___ lldb-comm

[Lldb-commits] [PATCH] D77000: [lldb] [PECOFF] Check that PECallFrameInfo operates on the expected architecture before interpreting RuntimeFunction structs

aleksandr.urakov added a comment. Hello! But does the format of an exception directory for aarch64 differ completely from x86-64 one? Can we somehow adopt the existing parser to support it? If we can, I think that this check looks good (we encapsulate the difference inside `PECallFrameInfo`). O

[Lldb-commits] [PATCH] D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. Sorry for the long delay, LGTM now, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77000/new/ https://reviews.llvm.org/D77000 ___

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: labath, amccarth, asmith, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh. This patch introduces a switch, based on the environment variable `LLDB_USE_LL

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

This revision was automatically updated to reflect the committed changes. Closed by commit rL373300: [Windows] Added support of watchpoints to `NativeProcessWindows` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov added a comment. Thank you! I've added a switch in a manner similar to one that Zachary has chosen for SymbolFilePDB/NativePDB plugins here: D68258 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67222/new/ htt

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. I've made it in the way similar to Zachary have made for the `SymbolFileNativePDB` plugin. An environment variable could be more convenient e.g. to run a bunch of tests using the `lldb-test` option. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. In D68258#1690756 , @aleksandr.urakov wrote: > I've made it in the way similar to Zachary have made for the > `SymbolFileNativePDB` plugin. An environment variable could be more > convenient e.g. to run a bunch of tests

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. Hello! I am sorry for a delay with reply, I was OOO. Thanks all for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258 ___ lldb-co

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG0891366571b2: [Windows] Introduce a switch for the `lldb-server` mode on Windows (authored by aleksandr.urakov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. Thanks a lot for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

This revision was automatically updated to reflect the committed changes. Closed by commit rG30c2441a3262: [Windows] Use information from the PE32 exceptions directory to construct… (authored by aleksandr.urakov). Changed prior to commit: https://reviews.llvm.org/D67347?vs=220144&id=224554#toc

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. In D67347#1705563 , @mstorsjo wrote: > Quick question here; will unwinding using DWARF debug info still work like > before after this, for binaries that don't use SEH for exception unwinding? Hi Martin! Do I understand

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68980/new/ https://reviews.llvm.org/D68980 ___

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

aleksandr.urakov added a comment. Sorry, I didn't see Pavel's message. In this case I have no objections to the patch if other people also won't have. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68980/new/ https://reviews.llvm.org/D68980 _

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

aleksandr.urakov added a comment. In D68980#1709327 , @labath wrote: > @aleksandr.urakov, since you probably know more about windows and these tests > than I do, I'd be interested in hearing your thoughts too... Sorry, I made some changes to the testing

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. @stella.stamenova I've fixed it with r374888, thanks again for pointing to that. The fix of unwind can fix some stepping issues, because stepping logic uses call stack information actively. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thank you! Can you send me an example of binary on which unwinding fails with a crash, please? It is a very interesting case... Repository: rLLDB LLDB CHANGES SIN

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

aleksandr.urakov added a comment. Sorry, I'm OOO today, so I can't take a precise look on this now. But I'm not sure, isn't race condition possible here on the m_session_data reset? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69503/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:58 llvm::BumpPtrAllocator

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, stella.stamenova, amccarth. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh. aleksandr.urakov added a subscriber: leonid.mashinskiy. This patch adds support of watc

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218837. aleksandr.urakov added a comment. Address the requested changes. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 Files: lldb/packages/Python/lldbsuite/test/comma

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218838. aleksandr.urakov added a comment. Address the requested changes. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 Files: lldb/packages/Python/lldbsuite/test/comma

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218840. aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. Check bitness of the target when checking the watchpoint size. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ h

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov marked 5 inline comments as done. aleksandr.urakov added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp:397 +if (slot != LLDB_INVALID_INDEX32) { + int id = m_watchpoint_slots[slot]; + LLDB_LOG(log, ---

<    1   2   3   4   >