vogelsgesang wrote:
FYI @walter-erquinigo: There is a proposal under discussion to add first-class
support for `declarationLocation` (and also `valueLocation`) to the debug
adapter protocol. See
https://github.com/microsoft/debug-adapter-protocol/issues/343
https://github.com/llvm/llvm-projec
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/102928
`declarationLocation` is about to become part of the upstream debug adapter
protocol (see microsoft/debug-adapter-protocol#343). This is a draft
implementation, to be finalized and merged after the corresp
vogelsgesang wrote:
@walter-erquinigo I took a first stab at implementing the DAP proposal. Seemed
rather straightforward. I would love to hear if I missed anything.
Also, I am not sure how to implement `valueLocation`, i.e., a the source
location referecend by the value. E.g., for a function
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/103482
lldb-dap already supports a log file which can be enabled by setting the
`LLDBDAP_LOG` environment variable. With this commit, the log location can be
set directly through the VS-Code extension settings.
vogelsgesang wrote:
No worries. I will have to rework this commit anyway.
In the meantime, a proposal was merged upstream and also already implemented in
VS-Code. However, there were still larger changes which will require a complete
rewrite of this commit
https://github.com/llvm/llvm-project
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/104317
Adds support for the `readMemory` request which allows VS-Code to inspect
memory. Also, add `memoryReference` to variablesa and `evaluate` responses,
such that the binary view can be opened from the variab
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH] [lldb-dap] Support inspecting memory
Adds support fo
vogelsgesang wrote:
https://github.com/user-attachments/assets/f1ec37fe-414e-41ee-ad10-a213570d3e5f
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH 1/2] [lldb-dap] Support inspecting memory
Adds suppor
@@ -4028,6 +4049,154 @@ void request_disassemble(const llvm::json::Object
&request) {
response.try_emplace("body", std::move(body));
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" },
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4028,6 +4049,154 @@ void request_disassemble(const llvm::json::Object
&request) {
response.try_emplace("body", std::move(body));
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" },
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH 1/4] [lldb-dap] Support inspecting memory
Adds suppor
@@ -4028,6 +4049,154 @@ void request_disassemble(const llvm::json::Object
&request) {
response.try_emplace("body", std::move(body));
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" },
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH 1/5] [lldb-dap] Support inspecting memory
Adds suppor
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH 1/5] [lldb-dap] Support inspecting memory
Adds suppor
@@ -1085,6 +1085,19 @@ std::string
VariableDescription::GetResult(llvm::StringRef context) {
return description.trim().str();
}
+lldb::addr_t GetMemoryReference(lldb::SBValue v) {
+ if (!v.GetType().IsPointerType() && !v.GetType().IsArrayType()) {
+return LLDB_INVALID_
vogelsgesang wrote:
Thanks for the super-fast review, @clayborg! I addressed all the
straightforward issues and replied to the non-straightforward ones
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.l
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/103482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/102928
>From a740c6918fd4c0e47b6d266fbb2b217112405a4f Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH] [lldb-dap] Implement declaration locations
This comm
https://github.com/vogelsgesang ready_for_review
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
Ok, this is ready for review now. The upstream protocol changes were merged in
the meantime.
I did leave in the `$__lldb_extensions.declaration` although it is superseded
by the `declarationLocationReference`. Let me know in case you prefer me to
remove it
https://github.
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/102928
>From a740c6918fd4c0e47b6d266fbb2b217112405a4f Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH 1/2] [lldb-dap] Implement declaration locations
This
vogelsgesang wrote:
@JDevlieghere it seems that the automation for publishing a new VS-Code
extension to the MarketPlace did not kick off automatically. Could you dispatch
the "Publish to VSCode Marketplace" flow manually?
https://github.com/llvm/llvm-project/pull/103482
__
@@ -4028,6 +4049,154 @@ void request_disassemble(const llvm::json::Object
&request) {
response.try_emplace("body", std::move(body));
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" },
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH 1/6] [lldb-dap] Support inspecting memory
Adds suppor
@@ -4028,6 +4049,154 @@ void request_disassemble(const llvm::json::Object
&request) {
response.try_emplace("body", std::move(body));
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" },
@@ -1085,6 +1085,19 @@ std::string
VariableDescription::GetResult(llvm::StringRef context) {
return description.trim().str();
}
+lldb::addr_t GetMemoryReference(lldb::SBValue v) {
+ if (!v.GetType().IsPointerType() && !v.GetType().IsArrayType()) {
+return LLDB_INVALID_
@@ -1085,6 +1084,17 @@ std::string
VariableDescription::GetResult(llvm::StringRef context) {
return description.trim().str();
}
+std::optional GetMemoryReference(lldb::SBValue v) {
+ if (!v.GetType().IsPointerType() && !v.GetType().IsArrayType())
+return std::nullopt;
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH 1/7] [lldb-dap] Support inspecting memory
Adds suppor
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/102928
>From fcc6b56e27eb1bb564ccf04a328fecc5c02cf78e Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH] [lldb-dap] Implement declaration locations
This comm
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/102928
>From 079def868f0216f31b78469f63034db5b350e250 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH] [lldb-dap] Implement declaration locations
This comm
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/104589
Note to reviewers: This commit builds on top of the not-yet-merged PR #102928.
When reviewing, ignore the first commit, it is part of the over PR. I will
rebase and turn this into a non-draft PR after #102
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104589
>From 079def868f0216f31b78469f63034db5b350e250 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH 1/2] [lldb-dap] Implement declaration locations
This
vogelsgesang wrote:
Should hidden frames also be skipped by `StepOut`?
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
In the below screen recording, you can see:
* The function pointers are shown in the variables view as usual
* The corresponding values are linked, as indicated by the underline when
hovering the value
* When Cmd+Clicking on the value, the link is followed
* Currently, this s
vogelsgesang wrote:
Here the screen recording of a fully functional, non-remote session:
https://github.com/user-attachments/assets/64b36078-a57b-440a-85f8-0e73f88c5a56
https://github.com/llvm/llvm-project/pull/104589
___
lldb-commits mailing list
l
https://github.com/vogelsgesang commented:
Thanks for looking into this! The patch already looks very good!
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
please rebase onto `main`. This unfortunately has a merge conflict with another
change which I recently merged
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-c
@@ -17,14 +17,46 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
const path = vscode.workspace
.getConfiguration("lldb-dap", session.workspaceFolder)
.get("executable-path");
- if (path) {
-return new vscode.DebugAdapterExecutable(
@@ -17,14 +17,46 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
const path = vscode.workspace
.getConfiguration("lldb-dap", session.workspaceFolder)
.get("executable-path");
- if (path) {
-return new vscode.DebugAdapterExecutable(
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/105446
This is a first draft PR which fixes #103021
The main issue was that the `instructionOffset` was handled as a byte offset
and not as an instruction offset.
This commit also incorporates previous feedback
vogelsgesang wrote:
@clayborg I would be interested in your guidance for this PR, given that you
previously reviewed a similar change in https://reviews.llvm.org/D140358
I did use `SBFunction` / `SBSymbol` as suggested by you in [this
comment](https://reviews.llvm.org/D140358#4027551).
I did
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/105457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -311,10 +309,22 @@ void DAP::SendOutput(OutputType o, const llvm::StringRef
output) {
category = "telemetry";
break;
}
- body.try_emplace("category", category);
- EmplaceSafeString(body, "output", output.str());
- event.try_emplace("body", std::move(body));
-
vogelsgesang wrote:
> This looks like a nice improvement! Can we add a test for this?
Added. Is this the type of test case you had in mind? Also, do I need to do
anything in addition? E.g., disable the test case for libstdc++, because the
stack frame recognizer only works for libc++? How would
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105457
>From bdd78f79c8eb1a439472c1aa5a1bb25e83494a79 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 21 Aug 2024 00:12:39 +
Subject: [PATCH] [lldb-dap] Show hidden frames as "subtle"
This commi
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105457
>From 36fd54d51e8310d4d03b40019bd96e564f8d1171 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 21 Aug 2024 00:12:39 +
Subject: [PATCH] [lldb-dap] Show hidden frames as "subtle"
This commi
vogelsgesang wrote:
The included test case should be fine now, afaict
https://github.com/llvm/llvm-project/pull/105457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3193,7 +3213,11 @@ void request_stackTrace(const llvm::json::Object
&request) {
// "targetId": {
// "type": "integer",
// "description": "Optional id of the target to step into."
-// }
+// },
+// "granularity": {
+// "$ref": "#/definitions
@@ -311,10 +309,22 @@ void DAP::SendOutput(OutputType o, const llvm::StringRef
output) {
category = "telemetry";
break;
}
- body.try_emplace("category", category);
- EmplaceSafeString(body, "output", output.str());
- event.try_emplace("body", std::move(body));
-
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105464
>From c4178df5541103388e26343f62e96f8e2a65be86 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Mon, 12 Aug 2024 23:00:45 +
Subject: [PATCH 1/3] [lldb-dap] Implement `StepGranularity` for "next"
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/105464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/102928
>From 5bdcb821527bf67eead6c42825ea6e559ec749c3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH] [lldb-dap] Implement declaration locations
This comm
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104589
>From 5bdcb821527bf67eead6c42825ea6e559ec749c3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH 1/2] [lldb-dap] Implement declaration locations
This
vogelsgesang wrote:
@petrhosek this commit builds on top of #104523 and relies on the frame
recognizer introduced as part of it.
As soon as [your proposed
solutions](https://github.com/llvm/llvm-project/pull/104523#issuecomment-2303287484)
was addressed, the `subtleFrames` test case should al
@@ -0,0 +1,81 @@
+"""
+Test lldb-dap locations request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class TestDAP_locations(lldbdap_testcase
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/104589
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4046,6 +4048,181 @@ void request__testGetTargetBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// SetInstructionBreakpoints request; value of command field is
+// 'setInstructionBreakpoints'. Replaces all exist
@@ -4078,6 +4255,9 @@ void RegisterRequestCallbacks() {
g_dap.RegisterRequestCallback("threads", request_threads);
g_dap.RegisterRequestCallback("variables", request_variables);
g_dap.RegisterRequestCallback("disassemble", request_disassemble);
+ // Instruction breapoint
@@ -0,0 +1,40 @@
+"""
+Test lldb-dap locations request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class TestDAP_locations(lldbdap_testcase
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/102928
>From 5bdcb821527bf67eead6c42825ea6e559ec749c3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH 1/2] [lldb-dap] Implement declaration locations
This
https://github.com/vogelsgesang approved this pull request.
Looks good to me!
Thanks for this amazing usability improvement!
If this would have existed the first time I tried this extension, it would have
saved me a lot of time
https://github.com/llvm/llvm-project/pull/104711
__
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
vogelsgesang wrote:
> @vogelsgesang , the $__lldb_extensions.declaration is used by the Mojo
> extension. Once this change gets it, I'll update the Mojo extension to use
> the new declaration info and remove $__lldb_extensions.declaration.
Is that extension's source code available? I wonder ho
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104589
>From 5bdcb821527bf67eead6c42825ea6e559ec749c3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH 1/3] [lldb-dap] Implement declaration locations
This
vogelsgesang wrote:
> @vogelsgesang , can you show a screenshot of the variables pane after this
> change? I want to make sure that simple types, like ints, are not displayed
> as having children.
**With this commit (and also with the changes from #104589)**
https://github.com/user-attachment
vogelsgesang wrote:
> I'll explain what I do [...]
Thanks for that context! I don't currently have a LSP in mind. Let's see which
UI VS-Code will be providing for this (if any). I hope it will not conflict
with your existing UI
https://github.com/llvm/llvm-project/pull/102928
vogelsgesang wrote:
> This LGTM considering that the screenshot looks right and this passes all the
> tests.
Thanks! I assume you still want me to wait for @clayborg's review before
merging?
https://github.com/llvm/llvm-project/pull/102928
___
lldb-
@@ -0,0 +1,40 @@
+"""
+Test lldb-dap locations request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class TestDAP_locations(lldbdap_testcase
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/105695
With this commit, we also hide the implementation details of `std::invoke`. To
do so, the `LibCXXFrameRecognizer` got a couple more regular expressions.
The regular expression passed into the `AddRecognize
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4078,6 +4255,9 @@ void RegisterRequestCallbacks() {
g_dap.RegisterRequestCallback("threads", request_threads);
g_dap.RegisterRequestCallback("variables", request_variables);
g_dap.RegisterRequestCallback("disassemble", request_disassemble);
+ // Instruction breapoint
vogelsgesang wrote:
@mordante @ldionne FYI. Would be interested which other functions come to mind
that should be hidden.
See https://github.com/llvm/llvm-project/pull/105457#issuecomment-226404
for screenshots of how this looks from a user's perspective
https://github.com/llvm/llvm-proje
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From c7cc7e9eed1ef4b95cabec5f662ebe10607b178e Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH] [lldb-dap] Add frame recognizers for libc++ `std::inv
https://github.com/vogelsgesang approved this pull request.
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
Looks good to me! Thanks again for fixing this!
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -53,10 +54,32 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
public:
LibCXXFrameRecognizer()
- : m_hidden_function_regex(
-R"(^std::__1::(__function.*::operator\(\)|__invoke))"
-R"((\[.*\])?)"// ABI tag.
-R"(( c
@@ -92,11 +95,13 @@ void StackFrameRecognizerManager::ForEach(
symbol_name = entry.symbol_regexp->GetText().str();
callback(entry.recognizer_id, entry.recognizer->GetName(), module_name,
- llvm::ArrayRef(ConstString(symbol_name)), true);
+
@@ -92,11 +95,13 @@ void StackFrameRecognizerManager::ForEach(
symbol_name = entry.symbol_regexp->GetText().str();
callback(entry.recognizer_id, entry.recognizer->GetName(), module_name,
- llvm::ArrayRef(ConstString(symbol_name)), true);
+
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/105756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/105756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -145,6 +167,17 @@
StackFrameRecognizerManager::GetRecognizerForFrame(StackFrameSP frame) {
if (!entry.module_regexp->Execute(module_name.GetStringRef()))
continue;
+ConstString function_name = [&]() {
+ switch (entry.mangling_preference) {
+ cas
@@ -145,6 +167,17 @@
StackFrameRecognizerManager::GetRecognizerForFrame(StackFrameSP frame) {
if (!entry.module_regexp->Execute(module_name.GetStringRef()))
continue;
+ConstString function_name = [&]() {
+ switch (entry.mangling_preference) {
+ cas
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From 19b4370c240cfcf4a57a5c38a64c8ba933d8102c Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/3] [lldb-dap] Add frame recognizers for libc++ `std:
@@ -145,6 +167,17 @@
StackFrameRecognizerManager::GetRecognizerForFrame(StackFrameSP frame) {
if (!entry.module_regexp->Execute(module_name.GetStringRef()))
continue;
+ConstString function_name = [&]() {
+ switch (entry.mangling_preference) {
+ cas
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From 19b4370c240cfcf4a57a5c38a64c8ba933d8102c Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/4] [lldb-dap] Add frame recognizers for libc++ `std:
@@ -145,6 +167,17 @@
StackFrameRecognizerManager::GetRecognizerForFrame(StackFrameSP frame) {
if (!entry.module_regexp->Execute(module_name.GetStringRef()))
continue;
+ConstString function_name = [&]() {
+ switch (entry.mangling_preference) {
+ cas
@@ -1049,7 +1049,7 @@ let Command = "thread backtrace" in {
def thread_backtrace_extended : Option<"extended", "e">, Group<1>,
Arg<"Boolean">, Desc<"Show the extended backtrace, if available">;
def thread_backtrace_unfiltered : Option<"unfiltered", "u">, Group<1>,
- Desc
1 - 100 of 585 matches
Mail list logo
