[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

2024-03-20 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,11 @@ +import lldb +from lldbsuite.test.lldbtest import * +import lldbsuite.test.lldbutil as lldbutil + + +class TestCase(TestBase): +def test(self): +self.build() +lldbutil.run_to_source_breakpoint(self, "break here", lldb.SBFileSpec("main.c")) +

[Lldb-commits] [lldb] [lldb][progress][NFC] Clarify Doxygen comments for `details` field (PR #86002)

2024-03-20 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Thanks, that's a great improvement! https://github.com/llvm/llvm-project/pull/86002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

2024-03-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/81196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

2024-03-21 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,18 @@ +import lldb +from lldbsuite.test.lldbtest import * +import lldbsuite.test.lldbutil as lldbutil + + +class TestCase(TestBase): + +def test_raw_bytes(self): +self.build() +lldbutil.run_to_source_breakpoint(self, "break here", lldb.SBFileSpec("m

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

2024-03-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/81196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

2024-03-21 Thread Adrian Prantl via lldb-commits
@@ -659,20 +660,24 @@ static char ConvertValueObjectStyleToChar( } static bool DumpValueWithLLVMFormat(Stream &s, llvm::StringRef options, -ValueObject &target) { +ValueObject &valobj) { std::string for

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-03-22 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: While I'm sure this commit will manage to break _something_ unexpectedly, I think this is reasonable to do! Thanks for taking this on. https://github.com/llvm/llvm-project/pull/86318 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] [lldb] Avoid deadlock by unlocking before invoking callbacks (PR #86888)

2024-03-27 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/86888 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-01 Thread Adrian Prantl via lldb-commits
@@ -441,6 +441,19 @@ class ValueObject { virtual int64_t GetValueAsSigned(int64_t fail_value, bool *success = nullptr); + llvm::APSInt GetValueAsAPSInt(); adrian-prantl wrote: if these errors matter to users then `llvm::Expected` would be the right choi

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-01 Thread Adrian Prantl via lldb-commits
@@ -441,6 +441,19 @@ class ValueObject { virtual int64_t GetValueAsSigned(int64_t fail_value, bool *success = nullptr); + llvm::APSInt GetValueAsAPSInt(); + + llvm::APFloat GetValueAsFloat(); adrian-prantl wrote: same here https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-01 Thread Adrian Prantl via lldb-commits
@@ -441,6 +441,19 @@ class ValueObject { virtual int64_t GetValueAsSigned(int64_t fail_value, bool *success = nullptr); + llvm::APSInt GetValueAsAPSInt(); + + llvm::APFloat GetValueAsFloat(); + + bool GetValueAsBool(); adrian-prantl wrote: same here h

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-01 Thread Adrian Prantl via lldb-commits
@@ -668,6 +699,32 @@ class ValueObject { CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data, const ExecutionContext &exe_ctx, CompilerType type); + static lldb::ValueObjectSP + CreateValueObjectFromBytes(lldb::TargetSP ta

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

2024-04-05 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

2024-04-05 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

2024-04-05 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

2024-04-05 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,620 @@ + +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][lldb-dap] Cleanup breakpoint filters. (PR #87550)

2024-04-05 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > I would be nice if we can detect if we support Swift dynamically. Internally > in LLDB, we can ask for a TypeSystem by language using: See also how lldb/test/Shell/Process/UnsupportedLanguage.test works https://github.com/llvm/llvm-project/pull/87550 ___

[Lldb-commits] [libcxx] [lldb] [libc++][CI] Tests LLDB libc++ data formatters. (PR #88312)

2024-04-15 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @mordante This broke the green dragon bot https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/1069/ This change seems to break the `frame diagnose` test: +# Based on https://discourse.llvm.org/t/running-lldb-in-a-container/76801/4 +"se

[Lldb-commits] [lldb] 466017c - Work around test failure due to new aslr default

2024-04-15 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-04-15T15:50:17-07:00 New Revision: 466017c8dab74f66ce513c8752f0c1dcd16a8a63 URL: https://github.com/llvm/llvm-project/commit/466017c8dab74f66ce513c8752f0c1dcd16a8a63 DIFF: https://github.com/llvm/llvm-project/commit/466017c8dab74f66ce513c8752f0c1dcd16a8a63.diff

[Lldb-commits] [libcxx] [lldb] [libc++][CI] Tests LLDB libc++ data formatters. (PR #88312)

2024-04-15 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: I worked around the problem in 466017c8dab74f66ce513c8752f0c1dcd16a8a63. https://github.com/llvm/llvm-project/pull/88312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] f8e2ec1 - Revert "Add asan tests for libsanitizers. (#88349)"

2024-04-16 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-04-16T08:29:09-07:00 New Revision: f8e2ec13a8c6d33cb7b4f37869b4429ddcf43f01 URL: https://github.com/llvm/llvm-project/commit/f8e2ec13a8c6d33cb7b4f37869b4429ddcf43f01 DIFF: https://github.com/llvm/llvm-project/commit/f8e2ec13a8c6d33cb7b4f37869b4429ddcf43f01.diff

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-16 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @usama54321 I had to revert this because it broke both the arm64 and x86 bots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/1078/ https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

2024-04-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/89433 This adds a hint to the missing symbols error message to make it easier to understand what this means to users. >From d57f2adff84dc5148c417135aa4733e05476876c Mon Sep 17 00:00:00 2001 From: Adrian Prantl

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

2024-04-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89433 >From 162907c6527464f828756b7152e2364ae3be88b5 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 19 Apr 2024 11:08:16 -0700 Subject: [PATCH] [lldb] Provide a better error message for missing symbols

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

2024-04-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/89433 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c8627e4 - Revert "[lldb] Provide a better error message for missing symbols (#89433)"

2024-04-19 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-04-19T16:37:09-07:00 New Revision: c8627e4e0c8ac453844638522b887ac7b7687672 URL: https://github.com/llvm/llvm-project/commit/c8627e4e0c8ac453844638522b887ac7b7687672 DIFF: https://github.com/llvm/llvm-project/commit/c8627e4e0c8ac453844638522b887ac7b7687672.diff

[Lldb-commits] [lldb] 6a35ee8 - [lldb] Provide a better error message for missing symbols (#89433)

2024-04-19 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-04-19T16:41:07-07:00 New Revision: 6a35ee8077647b32626c3c41f9d9da4dae6670fc URL: https://github.com/llvm/llvm-project/commit/6a35ee8077647b32626c3c41f9d9da4dae6670fc DIFF: https://github.com/llvm/llvm-project/commit/6a35ee8077647b32626c3c41f9d9da4dae6670fc.diff

[Lldb-commits] [lldb] [lldb/test] Add basic ld.lld --debug-names tests (PR #88335)

2024-04-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/88335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-24 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/89981 that separates out language and version. To avoid reinventing the wheel and introducing subtle incompatibilities, this API uses the table of languages and versiond defined by the upcoming DWARF 6 standard

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-24 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From 5bd7d3da1cd1c9ec508e0fbd96c8d9f2509ee900 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-25 Thread Adrian Prantl via lldb-commits
@@ -1203,26 +1203,23 @@ bool StackFrame::IsArtificial() const { return m_stack_frame_kind == StackFrame::Kind::Artificial; } -lldb::LanguageType StackFrame::GetLanguage() { +SourceLanguage StackFrame::GetLanguage() { CompileUnit *cu = GetSymbolContext(eSymbolContextCompUn

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-26 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From aba61b23b402f350161139adfffc3799a3135c8a Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-26 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From 762029753f7c21352f653e1719cb6c75107f6a50 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-26 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From 280caa3e26227338071409213646625d05f6eba5 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-26 Thread Adrian Prantl via lldb-commits
@@ -67,6 +67,10 @@ class LLDB_API SBExpressionOptions { void SetTrapExceptions(bool trap_exceptions = true); void SetLanguage(lldb::LanguageType language); + /// Set the language using a pair of language code and version as + /// defined by the DWARF 6 specification. +

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-26 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From e561968f8290b0fbe679950e5743f1f60144d716 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-26 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,45 @@ +//===- LLDBPropertyDefEmitter.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-26 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From e9b2e98cfe0383b53d2d875f070a63c2ccffe3d3 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From 19cfcf3230d02a93a907fe93ca95dbecd48bcaf9 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-29 Thread Adrian Prantl via lldb-commits
@@ -10,6 +10,7 @@ config.llvm_build_mode = lit_config.substitute("@LLVM_BUILD_MODE@") config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@" config.lldb_obj_root = "@LLDB_BINARY_DIR@" config.lldb_src_root = "@LLDB_SOURCE_DIR@" +config.lldb_built_include_dir = lit_config.substitute("@L

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From 6d91ad848b73183268617fecf14255b0ba0b9dd8 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From ea06aa4664b9b47b3cb11ec27774b9a0d109f92f Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From 00fdda9a57660533c5a97223bd52619b36f8999c Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From c4b1ff6c92126ebf721b6044088b05112ec98477 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From 34eda7b484e3fa9eaaf97c66af3e81bf337e6edd Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/89981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 35fa46a - Improve comment

2024-04-29 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-04-29T13:37:37-07:00 New Revision: 35fa46a56ae2a220de514e5de5c5e6b4607f5ebb URL: https://github.com/llvm/llvm-project/commit/35fa46a56ae2a220de514e5de5c5e6b4607f5ebb DIFF: https://github.com/llvm/llvm-project/commit/35fa46a56ae2a220de514e5de5c5e6b4607f5ebb.diff

[Lldb-commits] [lldb] 028546c - Simplify condition (NFC)

2024-04-29 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-04-29T15:08:49-07:00 New Revision: 028546cce2316a1074aa27001450295d856e1fdc URL: https://github.com/llvm/llvm-project/commit/028546cce2316a1074aa27001450295d856e1fdc DIFF: https://github.com/llvm/llvm-project/commit/028546cce2316a1074aa27001450295d856e1fdc.diff

[Lldb-commits] [lldb] Skip various tests under ASAN on green dragon (PR #90531)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/90531 using the macOS version as a proxy. I can't reproduce any of these failures locally, but the tests all use pexpect and probably have bad timeout behavior under high load. >From 46d19cc3211fa6e27f7e4923877

[Lldb-commits] [lldb] Skip various tests under ASAN on green dragon (PR #90531)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/90531 >From 34aaec09e03d0da6b2d511708fb3fe3e71b29c55 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 29 Apr 2024 15:38:25 -0700 Subject: [PATCH] Skip various tests under ASAN on green dragon using the ma

[Lldb-commits] [lldb] Skip various tests under ASAN on green dragon (PR #90531)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/90531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Consult Language plugin in GetDisplayDemangledName (PR #90294)

2024-04-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/90294 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Display breakpoint locations using display name (PR #90297)

2024-04-29 Thread Adrian Prantl via lldb-commits
@@ -685,7 +686,7 @@ bool Address::Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, sc.DumpStopContext(s, exe_scope, *this, show_fullpaths, show_module, show_inlined_frames, show_f

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-30 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > Why does this use tablegen to parse a .def file? > > Can't you get the same behavior without tablegen, using normal xmacro > techniques, something like > > ```c++ > enum SBSourceLanguageName : uint16_t { > > #define HANDLE_DW_LNAME(ID, NAME, DESC, LOWER_BOUND) \ > eLa

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-30 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: That's also why it's a `.h` file and not a `.inc`. https://github.com/llvm/llvm-project/pull/89981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-30 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Btw. github doesn't let you see older revisions, but the code snippet you posted that includes a .def file was exactly my first version of this patch. You can still find @JDevlieghere's comment asking me to change it though :-) Another thing worth noting is that the public

[Lldb-commits] [lldb] 4cd11c9 - Thread '--lldb-obj-root' through lldb-dotest for manual testing

2024-04-30 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-04-30T09:53:13-07:00 New Revision: 4cd11c986f78e19f53b3f3c92143b7b7c1ce54b1 URL: https://github.com/llvm/llvm-project/commit/4cd11c986f78e19f53b3f3c92143b7b7c1ce54b1 DIFF: https://github.com/llvm/llvm-project/commit/4cd11c986f78e19f53b3f3c92143b7b7c1ce54b1.diff

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-04-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/90666 None >From 628576baf4dbf11efa56a079dde9759ccc7e988d Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 30 Apr 2024 13:59:39 -0700 Subject: [PATCH] Install generated API headers into LLDB.framework --

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-04-30 Thread Adrian Prantl via lldb-commits
@@ -71,6 +71,7 @@ endif() # At configuration time, collect headers for the framework bundle and copy them # into a staging directory. Later we can copy over the entire folder. file(GLOB public_headers ${LLDB_SOURCE_DIR}/include/lldb/API/*.h) +file(GLOB built_public_headers ${L

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-04-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/90666 >From 6950a36e2619f032f2dd41f258f171b876274bd5 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 30 Apr 2024 13:59:39 -0700 Subject: [PATCH] Install generated API headers into LLDB.framework --- lld

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-04-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/90666 >From 9510a08995da26d0c3c1ea8d13f6c3f8fab772c2 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 30 Apr 2024 13:59:39 -0700 Subject: [PATCH] Install generated API headers into LLDB.framework --- lld

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-04-30 Thread Adrian Prantl via lldb-commits
@@ -8,6 +8,12 @@ set(LLDB_INCLUDE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/include") set(LLDB_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) set(LLDB_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) +if (LLDB_BUILT_STANDALONE) + set(LLDB_OBJ_DIR ${CMAKE_CURRENT_BINARY_DIR}) +else() + set(LLDB_OBJ_

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-04-30 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: I had to replace the GLOB with a hardcoded file name because the GLOB gets evaluated at CMake configure time, when the file doesn't exist yet. https://github.com/llvm/llvm-project/pull/90666 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [lldb] Use Python script to generate SBLanguages.h (PR #90753)

2024-05-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/90753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Python script to generate SBLanguages.h (PR #90753)

2024-05-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/90753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Python script to generate SBLanguages.h (PR #90753)

2024-05-01 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,67 @@ +#!/usr/bin/env python3 + +import argparse +import re + +HEADER = """\ +//===-- SBLanguages.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/L

[Lldb-commits] [lldb] [lldb] Use Python script to generate SBLanguages.h (PR #90753)

2024-05-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl requested changes to this pull request. https://github.com/llvm/llvm-project/pull/90753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-05-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/90666 >From d1b444aea800ef4f5950400728e00838dfd05fba Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 30 Apr 2024 13:59:39 -0700 Subject: [PATCH] Install generated API headers into LLDB.framework --- lld

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-05-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/90666 >From 88db878450f40e450965629412d1ad5c303249e9 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 30 Apr 2024 13:59:39 -0700 Subject: [PATCH] Install generated API headers into LLDB.framework --- lld

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-05-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/90666 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c4e8e2c - Skip timing-sensitive test under ASAN

2024-05-01 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-05-01T12:55:36-07:00 New Revision: c4e8e2c67bbfff2d1b23210c375c173aa05e3848 URL: https://github.com/llvm/llvm-project/commit/c4e8e2c67bbfff2d1b23210c375c173aa05e3848 DIFF: https://github.com/llvm/llvm-project/commit/c4e8e2c67bbfff2d1b23210c375c173aa05e3848.diff

[Lldb-commits] [lldb] [lldb] Use Python script to generate SBLanguages.h (PR #90753)

2024-05-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/90753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fa9e96a - Skip pexpect test under ASAN

2024-05-01 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-05-01T13:11:51-07:00 New Revision: fa9e96a2e55226b1f9f9744f42ac5e925297f819 URL: https://github.com/llvm/llvm-project/commit/fa9e96a2e55226b1f9f9744f42ac5e925297f819 DIFF: https://github.com/llvm/llvm-project/commit/fa9e96a2e55226b1f9f9744f42ac5e925297f819.diff

[Lldb-commits] [lldb] b8c301f - Fix the regex in the sbapi python script

2024-05-01 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-05-01T13:41:32-07:00 New Revision: b8c301f6e22a6a5ebec4b8870327237eb94c5b15 URL: https://github.com/llvm/llvm-project/commit/b8c301f6e22a6a5ebec4b8870327237eb94c5b15 DIFF: https://github.com/llvm/llvm-project/commit/b8c301f6e22a6a5ebec4b8870327237eb94c5b15.diff

[Lldb-commits] [lldb] [lldb] Display breakpoint locations using display name (PR #90297)

2024-05-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/90297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Unify DW_TAG -> string conversions (PR #90657)

2024-05-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/90657 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a log level to Host::SystemLog (PR #90904)

2024-05-02 Thread Adrian Prantl via lldb-commits
@@ -87,8 +87,15 @@ class Host { StartMonitoringChildProcess(const MonitorChildProcessCallback &callback, lldb::pid_t pid); + /// System log level. + enum SystemLogLevel { +eSystemLogInfo, +eSystemLogWarning, adrian-pra

[Lldb-commits] [lldb] [lldb] Always emit diagnostic events to the system log (PR #90913)

2024-05-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/90913 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create a single Severity enum in lldb-enumerations (PR #90917)

2024-05-03 Thread Adrian Prantl via lldb-commits
@@ -1347,6 +1347,12 @@ enum DebuggerBroadcastBit { eBroadcastBitProgressCategory = (1 << 3), }; +enum Severity { + eSeverityError, + eSeverityWarning, + eSeverityInfo, adrian-prantl wrote: Can you comment that "Clang also calls these Remarks, it's concep

[Lldb-commits] [lldb] [lldb] Create a single Severity enum in lldb-enumerations (PR #90917)

2024-05-03 Thread Adrian Prantl via lldb-commits
@@ -1347,6 +1347,12 @@ enum DebuggerBroadcastBit { eBroadcastBitProgressCategory = (1 << 3), }; +enum Severity { + eSeverityError, + eSeverityWarning, + eSeverityInfo, adrian-prantl wrote: Or even `eSeverityRemark = eSeverityInfo` https://github.com/llv

[Lldb-commits] [lldb] [lldb] Create a single Severity enum in lldb-enumerations (PR #90917)

2024-05-03 Thread Adrian Prantl via lldb-commits
@@ -1347,6 +1347,12 @@ enum DebuggerBroadcastBit { eBroadcastBitProgressCategory = (1 << 3), }; +enum Severity { adrian-prantl wrote: Would `enum class` prevent people from accidentally casting this to an unrelated enum with similar purpose but potentially

[Lldb-commits] [lldb] [lldb] Create a single Severity enum in lldb-enumerations (PR #90917)

2024-05-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/90917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add TeeLogHandler to log to 2 handlers (PR #90984)

2024-05-03 Thread Adrian Prantl via lldb-commits
@@ -112,6 +112,22 @@ class RotatingLogHandler : public LogHandler { static char ID; }; +class TeeLogHandler : public LogHandler { adrian-prantl wrote: Doxygen comment? https://github.com/llvm/llvm-project/pull/90984

[Lldb-commits] [lldb] [lldb] Add TeeLogHandler to log to 2 handlers (PR #90984)

2024-05-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/90984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add TeeLogHandler to log to 2 handlers (PR #90984)

2024-05-03 Thread Adrian Prantl via lldb-commits
@@ -438,3 +439,15 @@ void RotatingLogHandler::Dump(llvm::raw_ostream &stream) const { } stream.flush(); } + +TeeLogHandler::TeeLogHandler(std::shared_ptr first_log_handler, + std::shared_ptr second_log_handler) +: m_first_log_handler(first_l

[Lldb-commits] [lldb] [lldb] Add TeeLogHandler to log to 2 handlers (PR #90984)

2024-05-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/90984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb create API folder if it does not exist, before creating SBLangua… (PR #91128)

2024-05-06 Thread Adrian Prantl via lldb-commits
@@ -37,6 +38,10 @@ def emit_enum(input, output): with open(input, "r") as f: lines = f.readlines() +# Create output folder if it does not exist +if not os.path.isdir(os.path.dirname(output)): adrian-prantl wrote: This can be simplified: ht

[Lldb-commits] [lldb] 272ea28 - Remove else-after-break (NFC)

2024-05-07 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-05-07T13:44:44-07:00 New Revision: 272ea28bdec93b33527dc54edbdef8f43c51df47 URL: https://github.com/llvm/llvm-project/commit/272ea28bdec93b33527dc54edbdef8f43c51df47 DIFF: https://github.com/llvm/llvm-project/commit/272ea28bdec93b33527dc54edbdef8f43c51df47.diff

[Lldb-commits] [lldb] 8c4d798 - Add a missing check for nullptr

2024-05-07 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-05-07T13:44:44-07:00 New Revision: 8c4d7989c2b4a7e251afc3b13002611646de90b6 URL: https://github.com/llvm/llvm-project/commit/8c4d7989c2b4a7e251afc3b13002611646de90b6 DIFF: https://github.com/llvm/llvm-project/commit/8c4d7989c2b4a7e251afc3b13002611646de90b6.diff

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-08 Thread Adrian Prantl via lldb-commits
@@ -1240,7 +1241,13 @@ TypeSP SymbolFileDWARFDebugMap::FindCompleteObjCDefinitionTypeForDIE( void SymbolFileDWARFDebugMap::FindTypes(const TypeQuery &query, TypeResults &results) { std::lock_guard guard(GetModuleMutex()); + Progress p

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-08 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/91452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-08 Thread Adrian Prantl via lldb-commits
@@ -1411,3 +1414,35 @@ clang::Decl * ClangASTImporter::ASTImporterDelegate::GetOriginalDecl(clang::Decl *To) { return m_main.GetDeclOrigin(To).decl; } + +void ClangASTImporter::ASTImporterDelegate::UpdateImportProgress( +clang::Decl const *From) { + assert(From && +

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-08 Thread Adrian Prantl via lldb-commits
@@ -1240,7 +1241,13 @@ TypeSP SymbolFileDWARFDebugMap::FindCompleteObjCDefinitionTypeForDIE( void SymbolFileDWARFDebugMap::FindTypes(const TypeQuery &query, TypeResults &results) { std::lock_guard guard(GetModuleMutex()); + Progress p

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-08 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl commented: Nice! https://github.com/llvm/llvm-project/pull/91452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-08 Thread Adrian Prantl via lldb-commits
@@ -1411,3 +1414,35 @@ clang::Decl * ClangASTImporter::ASTImporterDelegate::GetOriginalDecl(clang::Decl *To) { return m_main.GetDeclOrigin(To).decl; } + +void ClangASTImporter::ASTImporterDelegate::UpdateImportProgress( +clang::Decl const *From) { + assert(From && +

[Lldb-commits] [lldb] Add a dependency from lldb-sbapi-dwarf-enums as a dependency of libll… (PR #91511)

2024-05-08 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/91511 …db-resource-headers The Xcode build otherwise fails with ``` CMake Error in source/API/CMakeLists.txt: The custom command generating /Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-standalone

[Lldb-commits] [lldb] Add a dependency from lldb-sbapi-dwarf-enums as a dependency of libll… (PR #91511)

2024-05-08 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/91511 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb create API folder if it does not exist, before creating SBLangua… (PR #91128)

2024-05-08 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/91128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb create API folder if it does not exist, before creating SBLangua… (PR #91128)

2024-05-08 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/91128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-09 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > I am somewhat worried about this slowing down the actual operations it is > reporting progress on. I didn't really measure this, but intuitively, I'd > expect that a one of these operations (parsing/importing one type) would be > pretty fast, and that the whole process t

<    3   4   5   6   7   8   9   10   11   12   >