[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-04 Thread Adrian Prantl via lldb-commits
@@ -26,6 +27,35 @@ class raw_ostream; namespace lldb_private { +/// A compiler-independent representation of a Diagnostic. Expression +/// evaluation failures often have more than one diagnostic that a UI +/// layer might want to render differently, for example to colorize +/

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/110901 >From 97b3812fe74feef8ea4e263cbb487bde5b3fe28b Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 1 Oct 2024 17:39:10 -0700 Subject: [PATCH] Support inline diagnostics in CommandReturnObject and impl

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-04 Thread Adrian Prantl via lldb-commits
@@ -3180,15 +3180,24 @@ void CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler, if ((result.Succeeded() && io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) || io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) { -// Display a

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-04 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @jimingham I changed the API to just record the offset of the expression in the command instead of the expression itself, which should make this all look a bit more logical. https://github.com/llvm/llvm-project/pull/110901 ___ ll

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/110901 >From bfb74e76dbfa548d821e6b3891fb1e6e6c9a80a3 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 1 Oct 2024 17:39:10 -0700 Subject: [PATCH] Support inline diagnostics in CommandReturnObject and impl

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-07 Thread Adrian Prantl via lldb-commits
@@ -489,11 +489,12 @@ class CommandObjectThreadStepWithTypeAndScope : public CommandObjectParsed { AddressRange range; SymbolContext sc = frame->GetSymbolContext(eSymbolContextEverything); if (m_options.m_end_line != LLDB_INVALID_LINE_NUMBER) { -

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-07 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Thanks, this looks nice! https://github.com/llvm/llvm-project/pull/110718 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112451 >From d400a1358678162df02c7cada2a66b837d3ff005 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 16:20:33 -0700 Subject: [PATCH] [lldb] Fix a crash when two diagnostics are on the same c

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/112466 None >From d400a1358678162df02c7cada2a66b837d3ff005 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 16:20:33 -0700 Subject: [PATCH 1/2] [lldb] Fix a crash when two diagnostics are on t

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/112466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] More aggressively deduplicate global warnings based on contents. (PR #112801)

2024-10-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/112801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112451 >From 7c35b47aa81ee0d2151944eff59c159ea3fd4c5c Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 16:20:33 -0700 Subject: [PATCH] [lldb] Fix a crash when two diagnostics are on the same c

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112466 >From 7c35b47aa81ee0d2151944eff59c159ea3fd4c5c Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 16:20:33 -0700 Subject: [PATCH 1/2] [lldb] Fix a crash when two diagnostics are on the sam

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/112451 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112466 >From 433765aeb92179d3dcd422949275bf043661682b Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 20:15:12 -0700 Subject: [PATCH] [lldb] Fix offset calculation when printing diagnostics in

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/112466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-16 Thread Adrian Prantl via lldb-commits
@@ -16,12 +16,36 @@ std::string Render(std::vector details) { } // namespace TEST_F(ErrorDisplayTest, RenderStatus) { - DiagnosticDetail::SourceLocation inline_loc; - inline_loc.in_user_input = true; { +DiagnosticDetail::SourceLocation inline_loc; +inline_loc.in_u

[Lldb-commits] [lldb] More aggressively deduplicate global warnings based on contents. (PR #112801)

2024-10-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112801 >From e35350b790f34660911c23cdbe34e6a0347f924d Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 17 Oct 2024 16:44:07 -0700 Subject: [PATCH] More aggressively deduplicate global warnings based on co

[Lldb-commits] [lldb] More aggressively deduplicate global warnings based on contents. (PR #112801)

2024-10-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112801 >From 7d01c051172c89a722e386c9fb607919d4be11bc Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 17 Oct 2024 16:44:07 -0700 Subject: [PATCH] More aggressively deduplicate global warnings based on co

[Lldb-commits] [lldb] More aggressively deduplicate global warnings based on contents. (PR #112801)

2024-10-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112801 >From 3585c9ce2a79e7608ea666c9be5c398d0d5ce1cb Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 17 Oct 2024 16:44:07 -0700 Subject: [PATCH] More aggressively deduplicate global warnings based on co

[Lldb-commits] [lldb] More aggressively deduplicate global warnings based on contents. (PR #112801)

2024-10-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112801 >From 14b4120a75f35ef8ade38e6dee2c60685de10c9b Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 17 Oct 2024 16:44:07 -0700 Subject: [PATCH] More aggressively deduplicate global warnings based on co

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -305,6 +319,16 @@ class BreakpointLocation /// It also takes care of decrementing the ignore counters. /// If it returns false we should continue, otherwise stop. bool IgnoreCountShouldStop(); + + // If this location knows that the virtual stack frame it represents

[Lldb-commits] [lldb] 2b7e9d2 - [lldb] Add missing whitespace in help text

2024-10-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-10-18T16:55:21-07:00 New Revision: 2b7e9d27817da54c34a6f02dc00d2466c31f6fa0 URL: https://github.com/llvm/llvm-project/commit/2b7e9d27817da54c34a6f02dc00d2466c31f6fa0 DIFF: https://github.com/llvm/llvm-project/commit/2b7e9d27817da54c34a6f02dc00d2466c31f6fa0.diff

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext( 0, file_indexes, src_location_spec, &line_entry); } + // If we didn't manage to find a breakpoint that matched the line number + // requested, that might be because it is only an inline call site, and +

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -281,6 +283,18 @@ class BreakpointLocation /// Returns the breakpoint location ID. lldb::break_id_t GetID() const { return m_loc_id; } + + // Set the line entry that should be shown to users for this location. + // It is up to the caller to verify that this is a val

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext( 0, file_indexes, src_location_spec, &line_entry); } + // If we didn't manage to find a breakpoint that matched the line number + // requested, that might be because it is only an inline call site, and +

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Very exciting, this is something I've wished for for a long time! https://github.com/llvm/llvm-project/pull/112939 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -32,6 +32,12 @@ def test_step_in_template_with_python_api(self): self.build() self.step_in_template() +@add_test_categories(["pyapi"]) +def test_virtual_inline_stepping(self): +"""Test stepping through a virtual inlined call stack""" +

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -369,6 +393,13 @@ class BreakpointLocation lldb::break_id_t m_loc_id; ///< Breakpoint location ID. StoppointHitCounter m_hit_counter; ///< Number of times this breakpoint /// location has been hit. + std::optional m_preferred_line_en

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext( 0, file_indexes, src_location_spec, &line_entry); } + // If we didn't manage to find a breakpoint that matched the line number + // requested, that might be because it is only an inline call site, and +

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -656,6 +671,49 @@ void BreakpointLocation::SendBreakpointLocationChangedEvent( } } +std::optional BreakpointLocation::GetSuggestedStackFrameIndex() { + if (!GetPreferredLineEntry()) +return {}; + LineEntry preferred = *GetPreferredLineEntry(); + SymbolContext sc;

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -369,6 +393,13 @@ class BreakpointLocation lldb::break_id_t m_loc_id; ///< Breakpoint location ID. StoppointHitCounter m_hit_counter; ///< Number of times this breakpoint /// location has been hit. + std::optional m_preferred_line_en

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -357,3 +363,61 @@ def step_in_template(self): step_sequence = [["// In max_value specialized", "into"]] self.run_step_sequence(step_sequence) + +def run_to_call_site_and_step(self, source_regex, func_name, start_pos): +main_spec = lldb.SBFileSpec

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

2024-10-18 Thread Adrian Prantl via lldb-commits
@@ -32,6 +32,12 @@ def test_step_in_template_with_python_api(self): self.build() self.step_in_template() +@add_test_categories(["pyapi"]) +def test_virtual_inline_stepping(self): +"""Test stepping through a virtual inlined call stack""" +

[Lldb-commits] [lldb] More aggressively deduplicate global warnings based on contents. (PR #112801)

2024-10-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: The failures are timeouts. https://github.com/llvm/llvm-project/pull/112801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-21 Thread Adrian Prantl via lldb-commits
@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream, continue; } -auto &loc = *detail.source_location; remaining_details.push_back(detail); + } + + // Sort the diagnostics. + auto sort = [](auto &ds) { +llvm::sort(ds.begin(), ds.end(), [](

[Lldb-commits] [lldb] [lldb] Rename CommandReturnObject::Get.*Data -> Get.*String (PR #112062)

2024-10-21 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @JDevlieghere fixed this in 40ea92c859234d536553cf26650e89d6e52071c6 https://github.com/llvm/llvm-project/pull/112062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] [lldb] Fix the sorting function for diagnostics (PR #113220)

2024-10-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/113220 None >From 417e6f4c27d1603d118dadd8327e57b766626e6d Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 21 Oct 2024 13:57:09 -0700 Subject: [PATCH] [lldb] Fix the sorting function for diagnostics ---

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-21 Thread Adrian Prantl via lldb-commits
@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream, continue; } -auto &loc = *detail.source_location; remaining_details.push_back(detail); + } + + // Sort the diagnostics. + auto sort = [](auto &ds) { +llvm::sort(ds.begin(), ds.end(), [](

[Lldb-commits] [lldb] [lldb] Fix the sorting function for diagnostics (PR #113220)

2024-10-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/113220 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] More aggressively deduplicate global warnings based on contents. (PR #112801)

2024-10-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/112801 I've been getting complaints from users being spammed by -gmodules missing file warnings going out of control because each object file depends on an entire DAG of PCM files that usually are all missing at

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-09 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/110901 >From 0a78922cc8e21c62ed7b09a88a14ff6119697cd9 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 9 Oct 2024 09:45:53 -0700 Subject: [PATCH] Support inline diagnostics in CommandReturnObject and impl

[Lldb-commits] [lldb] [lldb] Return an llvm::Error from GetFrameBaseValue (PR #111882)

2024-10-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/111882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-09 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/110901 >From 49b51bad4dd2ca41e61da38b1e35ffcb1eb9e7d6 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 9 Oct 2024 09:45:53 -0700 Subject: [PATCH] Support inline diagnostics in CommandReturnObject and impl

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-10 Thread Adrian Prantl via lldb-commits
@@ -38,19 +38,23 @@ class Args { std::unique_ptr ptr; char quote = '\0'; +/// The position of the argument in the original argument string. +std::optional column; char *data() { return ptr.get(); } public: ArgEntry() = default; -ArgEntry(ll

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-04 Thread Adrian Prantl via lldb-commits
@@ -112,8 +113,46 @@ void CommandReturnObject::SetError(Status error) { } void CommandReturnObject::SetError(llvm::Error error) { - if (error) + // Retrieve any diagnostics. + error = llvm::handleErrors(std::move(error), [&](ExpressionErrorBase &error) { a

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-04 Thread Adrian Prantl via lldb-commits
@@ -3180,15 +3180,24 @@ void CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler, if ((result.Succeeded() && io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) || io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) { -// Display a

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/110901 >From f59f186d66c96a4aefbebd58776f99dd294f47e8 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 1 Oct 2024 17:39:10 -0700 Subject: [PATCH] Support inline diagnostics in CommandReturnObject and impl

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-04 Thread Adrian Prantl via lldb-commits
@@ -112,8 +113,46 @@ void CommandReturnObject::SetError(Status error) { } void CommandReturnObject::SetError(llvm::Error error) { - if (error) + // Retrieve any diagnostics. + error = llvm::handleErrors(std::move(error), [&](ExpressionErrorBase &error) { +SetStatus(eRe

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-22 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 3267f7a2001e769217e3192f6efb67fb77973339 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH] Add a compiler/interpreter of LLDB data formatter bytecode

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-22 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/113398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-22 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From c4360a6979a38f7e9a11edc07f02d8b3ac5bd2aa Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH] Add a compiler/interpreter of LLDB data formatter bytecode

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-22 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/113398 This PR adds a proof-of-concept for a bytecode designed to ship and run LLDB data formatters. More motivation and context can be found in the `formatter-bytecode.md` file and on discourse. >From 64252584

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-14 Thread Adrian Prantl via lldb-commits
@@ -123,30 +123,79 @@ void CommandReturnObject::SetError(llvm::Error error) { } } -llvm::StringRef -CommandReturnObject::GetInlineDiagnosticString(unsigned indent) { - RenderDiagnosticDetails(m_diag_stream, indent, true, m_diagnostics); +std::string CommandReturnObject::Get

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-11-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/114333 >From c9a4d24f222a70c7c108deebb6c25222893d7159 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 24 Jan 2024 12:42:45 -0800 Subject: [PATCH 1/2] [lldb] Load embedded type summary section (#7859) (#8040)

[Lldb-commits] [lldb] More refinement of call site handling in stepping. (PR #114628)

2024-11-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/114628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] More refinement of call site handling in stepping. (PR #114628)

2024-11-01 Thread Adrian Prantl via lldb-commits
@@ -395,7 +394,44 @@ bool ThreadPlanStepRange::SetNextBranchBreakpoint() { m_next_branch_bp_sp->GetID(), bp_site_id, run_to_address.GetLoadAddress(&m_process.GetTarget())); } - +// The "next branch breakpoint might land on

[Lldb-commits] [lldb] [lldb] Add a link to LLDB's Discord channel on the website (PR #114289)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/114289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl commented: Can you add a test (perhaps using lldb-test and a .ll or .s file)? https://github.com/llvm/llvm-project/pull/113007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] Fix a couple of tests that were incorrectly using configuration.dwarf_version (PR #114161)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl commented: Thanks! https://github.com/llvm/llvm-project/pull/114161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/114251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/114251 The order in which the libraries appear is not always stable and even if it were, this test is not the right place to check for this. >From 553d4742e6972a068105177aafd47b3da2c01d8f Mon Sep 17 00:00:00 200

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,63 @@ +; Test finding types by CompilerContext. +; REQUIRES: aarch64 +; RUN: llc %s -filetype=obj -o %t.o +; RUN: lldb-test symbols %t.o -find=type --mangled-name=UniqueDifferentName | FileCheck %s +; +; NORESULTS: Found 0 types +; CHECK: Found 1 types: +; CHECK: stru

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/113007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)

2024-11-01 Thread Adrian Prantl via lldb-commits
@@ -1608,9 +1612,48 @@ void Target::SetExecutableModule(ModuleSP &executable_sp, if (image_module_sp) { added_modules.AppendIfNeeded(image_module_sp, false); ObjectFile *objfile = image_module_sp->GetObjectFile(); - if (objfile) -

[Lldb-commits] [lldb] [lldb] Highlight "note:" in CommandReturnObject (PR #114610)

2024-11-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. I was going to say this is not the right way to do this, but I suppose there isn't really a better mechanism available, since this isn't an error. Otherwise you'd be better off joining a diagnostic error with the note so the UI layer

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Adrian Prantl via lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, // Add a hint if object description was requested, but no description // function was implemented. auto maybe_add_hint = [&](llvm::StringRef output) { +static bool note_shown = false; +

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2024-11-01 Thread Adrian Prantl via lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, // Add a hint if object description was requested, but no description // function was implemented. auto maybe_add_hint = [&](llvm::StringRef output) { +static bool note_shown = false; +

[Lldb-commits] [lldb] [lldb] Improve command status when dwim-print has no result (PR #114478)

2024-11-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl commented: @kastiglione Is there a way to turn this into a test? Apparently this works: ``` (lldb) p ; (lldb) ``` https://github.com/llvm/llvm-project/pull/114478 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/114333 Compared to the python version, this also does type checking and error handling, so it's slightly longer, however, it's still comfortably under 500 lines. See https://discourse.llvm.org/t/a-bytecode-for-ll

[Lldb-commits] [lldb] [lldb] Add a link to LLDB's Discord channel on the website (PR #114289)

2024-10-31 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Unfortunately older videos are regularly being removed. We should probably remove the links and add https://developer.apple.com/videos/play/wwdc2024/10198 instead. https://github.com/llvm/llvm-project/pull/114289 ___ lldb-commits

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] c86b1b0 - [lldb] Add handling of ECError to unit test to validate a hypothesis on the bots

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T16:39:22-07:00 New Revision: c86b1b0f44509585390c8df09b41d707e6a14011 URL: https://github.com/llvm/llvm-project/commit/c86b1b0f44509585390c8df09b41d707e6a14011 DIFF: https://github.com/llvm/llvm-project/commit/c86b1b0f44509585390c8df09b41d707e6a14011.diff

[Lldb-commits] [lldb] cf02d8b - [lldb] Store ECError as CloneableECError in Status

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T16:23:29-07:00 New Revision: cf02d8bbb6dfed17081fbdbf44e2071aea1af728 URL: https://github.com/llvm/llvm-project/commit/cf02d8bbb6dfed17081fbdbf44e2071aea1af728 DIFF: https://github.com/llvm/llvm-project/commit/cf02d8bbb6dfed17081fbdbf44e2071aea1af728.diff

[Lldb-commits] [lldb] 05a292c - Revert "[lldb] Add handling of ECError to unit test to validate a hypothesis on the bots"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:09-07:00 New Revision: 05a292caa57de13a6d0bc25dee2be25c2a0dcee3 URL: https://github.com/llvm/llvm-project/commit/05a292caa57de13a6d0bc25dee2be25c2a0dcee3 DIFF: https://github.com/llvm/llvm-project/commit/05a292caa57de13a6d0bc25dee2be25c2a0dcee3.diff

[Lldb-commits] [lldb] 79a69cb - Revert "[lldb] Store ECError as CloneableECError in Status"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:09-07:00 New Revision: 79a69cb06665859658677b9ade4a1a262490f8c1 URL: https://github.com/llvm/llvm-project/commit/79a69cb06665859658677b9ade4a1a262490f8c1 DIFF: https://github.com/llvm/llvm-project/commit/79a69cb06665859658677b9ade4a1a262490f8c1.diff

[Lldb-commits] [lldb] 2730373 - Revert "Add noexcept qualifier to placate g++"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:09-07:00 New Revision: 27303736512c32bb87b67a4ecf0b17881a8811c6 URL: https://github.com/llvm/llvm-project/commit/27303736512c32bb87b67a4ecf0b17881a8811c6 DIFF: https://github.com/llvm/llvm-project/commit/27303736512c32bb87b67a4ecf0b17881a8811c6.diff

[Lldb-commits] [lldb] 8b456b4 - Revert "[lldb] Update SocketTestUtilities.cpp to use CloneableECError"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:09-07:00 New Revision: 8b456b436f996b4c6dfee0abc704b9219d43f7d2 URL: https://github.com/llvm/llvm-project/commit/8b456b436f996b4c6dfee0abc704b9219d43f7d2 DIFF: https://github.com/llvm/llvm-project/commit/8b456b436f996b4c6dfee0abc704b9219d43f7d2.diff

[Lldb-commits] [lldb] cb6d531 - Revert "[lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:10-07:00 New Revision: cb6d53198e39838ba6f9d2974c4f4317057d1556 URL: https://github.com/llvm/llvm-project/commit/cb6d53198e39838ba6f9d2974c4f4317057d1556 DIFF: https://github.com/llvm/llvm-project/commit/cb6d53198e39838ba6f9d2974c4f4317057d1556.diff

[Lldb-commits] [lldb] 6dcde73 - Revert "[lldb] Only send "posix" error codes through the gdb-remote protocol"

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T17:28:10-07:00 New Revision: 6dcde731eb13aeaa8296504ad8178d62c8ecd3eb URL: https://github.com/llvm/llvm-project/commit/6dcde731eb13aeaa8296504ad8178d62c8ecd3eb DIFF: https://github.com/llvm/llvm-project/commit/6dcde731eb13aeaa8296504ad8178d62c8ecd3eb.diff

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: So I _thought_ I had understood this because I had simulated the missing ip6 support on the bots inside of Socked::CreateSocket, but I still had failing unit tests at the end of the day so I reverted this again for now. https://github.com/llvm/llvm-project/pull/106774

[Lldb-commits] [lldb] [lldb][FrameRecognizer] Display the first non-std frame on verbose_trap (PR #108825)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/108825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From 8a2af995f80cc518f4776c2236a86d0ca32abe03 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an llvm:

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From 40d336f5ffcbf36346eb017f65c0c150fc7190d2 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an llvm:

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From a857ea027be6dbdc06d2834b65906a356b2a4128 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an llvm:

[Lldb-commits] [lldb] 2383bc8 - [lldb] Update SocketTestUtilities.cpp to use CloneableECError

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-18T15:54:24-07:00 New Revision: 2383bc8216bd7d373bb48337199c09d40922adf2 URL: https://github.com/llvm/llvm-project/commit/2383bc8216bd7d373bb48337199c09d40922adf2 DIFF: https://github.com/llvm/llvm-project/commit/2383bc8216bd7d373bb48337199c09d40922adf2.diff

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > Actually, the CI failure appears to be relevant. The error path in the test > is `errno->std::error_code->Status->Expected` and the code in > `CheckIPSupport` expects to get a `llvm::ECError`. It looks like it gets a > different type now, and I think that's probably fine

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 6d240b3254192763f0b67b70ed36616dfcf9e565 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 4 Sep 2024 12:50:37 -0700 Subject: [PATCH] [lldb] Change the implementation of Status to store an llv

[Lldb-commits] [lldb] a7c1745 - [lldb] Only send "posix" error codes through the gdb-remote protocol

2024-09-18 Thread Adrian Prantl via lldb-commits
Author: Pavel Labath Date: 2024-09-18T14:53:42-07:00 New Revision: a7c174502aef45b2d33291129cce10c085fef944 URL: https://github.com/llvm/llvm-project/commit/a7c174502aef45b2d33291129cce10c085fef944 DIFF: https://github.com/llvm/llvm-project/commit/a7c174502aef45b2d33291129cce10c085fef944.diff

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

<    9   10   11   12   13   14   15   16   17   18   >