[Lldb-commits] [lldb] r343545 - Enable C++ tests to run in the -gmodules configuration on Darwin.

Author: adrian Date: Mon Oct 1 15:27:42 2018 New Revision: 343545 URL: http://llvm.org/viewvc/llvm-project?rev=343545&view=rev Log: Enable C++ tests to run in the -gmodules configuration on Darwin. This addresses PR36048 (http://llvm.org/bugs/show_bug.cgi?id=36048) rdar://problem/36776281 Modi

[Lldb-commits] [lldb] r343612 - DWARFExpression: Resolve file addresses in the linked module

Author: adrian Date: Tue Oct 2 10:50:42 2018 New Revision: 343612 URL: http://llvm.org/viewvc/llvm-project?rev=343612&view=rev Log: DWARFExpression: Resolve file addresses in the linked module This is a follow-up to https://reviews.llvm.org/D46362. When evaluating a complex expression in DWARFE

[Lldb-commits] [lldb] r343624 - Remove unnecessary field

Author: adrian Date: Tue Oct 2 13:14:12 2018 New Revision: 343624 URL: http://llvm.org/viewvc/llvm-project?rev=343624&view=rev Log: Remove unnecessary field Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/target_var/globals.ll Modified: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [lldb] r343695 - Skip test with older versions of clang

Author: adrian Date: Wed Oct 3 09:24:14 2018 New Revision: 343695 URL: http://llvm.org/viewvc/llvm-project?rev=343695&view=rev Log: Skip test with older versions of clang Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/target_var/TestTargetVar.py Modified: lldb/trunk/p

[Lldb-commits] [lldb] r344557 - Convert code to use early exits in prepraration for future changes. (NFC)

Author: adrian Date: Mon Oct 15 14:35:45 2018 New Revision: 344557 URL: http://llvm.org/viewvc/llvm-project?rev=344557&view=rev Log: Convert code to use early exits in prepraration for future changes. (NFC) Modified: lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILa

[Lldb-commits] [lldb] r344648 - Delete commented-out code.

Author: adrian Date: Tue Oct 16 15:01:49 2018 New Revision: 344648 URL: http://llvm.org/viewvc/llvm-project?rev=344648&view=rev Log: Delete commented-out code. Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/ValueObject.cpp URL: http://llvm.org/viewvc/llvm-

[Lldb-commits] [lldb] r345274 - Fix a bug PlatformDarwin::SDKSupportsModule.

Author: adrian Date: Thu Oct 25 08:30:43 2018 New Revision: 345274 URL: http://llvm.org/viewvc/llvm-project?rev=345274&view=rev Log: Fix a bug PlatformDarwin::SDKSupportsModule. This fixes a bug PlatformDarwin::SDKSupportsModule introduced by https://reviews.llvm.org/D47889. VersionTuple::tryPar

[Lldb-commits] [lldb] r345278 - Get rid of casts. (NFC)

Author: adrian Date: Thu Oct 25 09:15:17 2018 New Revision: 345278 URL: http://llvm.org/viewvc/llvm-project?rev=345278&view=rev Log: Get rid of casts. (NFC) Differential Revision: https://reviews.llvm.org/D53709 Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp lldb/

[Lldb-commits] [lldb] r345287 - Remove accidentally committed duplicate code

Author: adrian Date: Thu Oct 25 10:36:05 2018 New Revision: 345287 URL: http://llvm.org/viewvc/llvm-project?rev=345287&view=rev Log: Remove accidentally committed duplicate code Modified: lldb/trunk/source/Utility/ArchSpec.cpp Modified: lldb/trunk/source/Utility/ArchSpec.cpp URL: http://llv

[Lldb-commits] [lldb] r345768 - Makefile.rules: Don't use code signing on macOS; it isn't necessary.

Author: adrian Date: Wed Oct 31 12:42:02 2018 New Revision: 345768 URL: http://llvm.org/viewvc/llvm-project?rev=345768&view=rev Log: Makefile.rules: Don't use code signing on macOS; it isn't necessary. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/tru

[Lldb-commits] [lldb] r346165 - Fix (and improve) the support for C99 variable length array types

Author: adrian Date: Mon Nov 5 12:49:07 2018 New Revision: 346165 URL: http://llvm.org/viewvc/llvm-project?rev=346165&view=rev Log: Fix (and improve) the support for C99 variable length array types Clang recently improved its DWARF support for C VLA types. The DWARF now looks like this: 0x0

[Lldb-commits] [lldb] r346172 - Skip this test on older versions of clang.

Author: adrian Date: Mon Nov 5 14:19:22 2018 New Revision: 346172 URL: http://llvm.org/viewvc/llvm-project?rev=346172&view=rev Log: Skip this test on older versions of clang. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py Modified: lldb/trunk/packages/Python/lldbs

Re: [Lldb-commits] [lldb] r346186 - [TestVLA] Fix a python decorator.

Thanks!! You could also change the import line to > from lldbsuite.test.decorators import * and leave the decorator as-is. -- adrian > On Nov 5, 2018, at 4:21 PM, Davide Italiano wrote: > > @Adrian, this should be fairly straightforward, but a post-commit > review is always appreciated. >

[Lldb-commits] [lldb] r346456 - Fix CMake build when building with -fmodules-local-submodule-visibility.

Author: adrian Date: Thu Nov 8 16:49:18 2018 New Revision: 346456 URL: http://llvm.org/viewvc/llvm-project?rev=346456&view=rev Log: Fix CMake build when building with -fmodules-local-submodule-visibility. Modified: lldb/trunk/source/Host/CMakeLists.txt Modified: lldb/trunk/source/Host/CMake

[Lldb-commits] [lldb] r346519 - Annotate switch with LLVM_FALLTHROUGH

Author: adrian Date: Fri Nov 9 09:11:17 2018 New Revision: 346519 URL: http://llvm.org/viewvc/llvm-project?rev=346519&view=rev Log: Annotate switch with LLVM_FALLTHROUGH Modified: lldb/trunk/tools/debugserver/source/DNBRegisterInfo.cpp lldb/trunk/tools/debugserver/source/RNBRemote.cpp M

[Lldb-commits] [lldb] r346525 - Add missing include

Author: adrian Date: Fri Nov 9 09:44:20 2018 New Revision: 346525 URL: http://llvm.org/viewvc/llvm-project?rev=346525&view=rev Log: Add missing include Modified: lldb/trunk/tools/debugserver/source/DNBRegisterInfo.cpp Modified: lldb/trunk/tools/debugserver/source/DNBRegisterInfo.cpp URL: h

[Lldb-commits] [lldb] r346527 - Add missing include

Author: adrian Date: Fri Nov 9 09:58:05 2018 New Revision: 346527 URL: http://llvm.org/viewvc/llvm-project?rev=346527&view=rev Log: Add missing include Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp URL: http://llvm.o

[Lldb-commits] [lldb] r346572 - Add extra diagnostics to test

Author: adrian Date: Fri Nov 9 16:16:39 2018 New Revision: 346572 URL: http://llvm.org/viewvc/llvm-project?rev=346572&view=rev Log: Add extra diagnostics to test Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py Modified: lldb/trunk/packages/Python/lldbsu

[Lldb-commits] [lldb] r346812 - Fix a bug in the parsing of the LC_BUILD_VERSION Mach-O load command.

Author: adrian Date: Tue Nov 13 15:14:37 2018 New Revision: 346812 URL: http://llvm.org/viewvc/llvm-project?rev=346812&view=rev Log: Fix a bug in the parsing of the LC_BUILD_VERSION Mach-O load command. LC_BUILD_VERSION records are of variable length. The original code would use uninitialized mem

[Lldb-commits] [lldb] r346906 - Remove the expectedFlakeyDsym decorator. It's not useful anymore.

Author: adrian Date: Wed Nov 14 14:54:43 2018 New Revision: 346906 URL: http://llvm.org/viewvc/llvm-project?rev=346906&view=rev Log: Remove the expectedFlakeyDsym decorator. It's not useful anymore. Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py lldb/trunk/packages/Pyt

[Lldb-commits] [lldb] r346981 - Port the Darwin universal binary testcase to x86_64.

Author: adrian Date: Thu Nov 15 11:15:03 2018 New Revision: 346981 URL: http://llvm.org/viewvc/llvm-project?rev=346981&view=rev Log: Port the Darwin universal binary testcase to x86_64. Xcode 10 doesn't ship with an i386 SDK any more. This patch ports the testcase from an i386/x86_64 -> x86_64/x8

[Lldb-commits] [lldb] r347058 - Typo

Author: adrian Date: Fri Nov 16 08:19:08 2018 New Revision: 347058 URL: http://llvm.org/viewvc/llvm-project?rev=347058&view=rev Log: Typo Modified: lldb/trunk/test/CMakeLists.txt Modified: lldb/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/CMakeLists.txt

[Lldb-commits] [lldb] r347056 - Makefile.rules: Use a shared clang module cache directory.

Author: adrian Date: Fri Nov 16 08:19:07 2018 New Revision: 347056 URL: http://llvm.org/viewvc/llvm-project?rev=347056&view=rev Log: Makefile.rules: Use a shared clang module cache directory. Just to be safe, up until now each test used its own Clang module cache directory. Since the compiler wit

[Lldb-commits] [lldb] r347057 - Use a shared module cache directory for LLDB.

Author: adrian Date: Fri Nov 16 08:19:07 2018 New Revision: 347057 URL: http://llvm.org/viewvc/llvm-project?rev=347057&view=rev Log: Use a shared module cache directory for LLDB. This saves about 3 redundant gigabytes from the Objective-C test build directories. Tests that must do unsavory things

[Lldb-commits] [lldb] r347071 - Make path more robust so it also works with out-of-tree builds.

Author: adrian Date: Fri Nov 16 10:43:16 2018 New Revision: 347071 URL: http://llvm.org/viewvc/llvm-project?rev=347071&view=rev Log: Make path more robust so it also works with out-of-tree builds. Modified: lldb/trunk/lit/lit.cfg.py Modified: lldb/trunk/lit/lit.cfg.py URL: http://llvm.org/v

[Lldb-commits] [lldb] r347104 - Makefile.rules: Degrade gracefully on Windows machines without sed.

Author: adrian Date: Fri Nov 16 14:44:57 2018 New Revision: 347104 URL: http://llvm.org/viewvc/llvm-project?rev=347104&view=rev Log: Makefile.rules: Degrade gracefully on Windows machines without sed. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/trun

[Lldb-commits] [lldb] r347120 - Makefile.rules: Fix the windows-sed-quoting issue harder.

Author: adrian Date: Fri Nov 16 16:45:58 2018 New Revision: 347120 URL: http://llvm.org/viewvc/llvm-project?rev=347120&view=rev Log: Makefile.rules: Fix the windows-sed-quoting issue harder. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/trunk/packages

[Lldb-commits] [lldb] r347124 - Revert "Makefile.rules: Fix the windows-sed-quoting issue harder."

Author: adrian Date: Fri Nov 16 17:27:46 2018 New Revision: 347124 URL: http://llvm.org/viewvc/llvm-project?rev=347124&view=rev Log: Revert "Makefile.rules: Fix the windows-sed-quoting issue harder." Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/trunk

[Lldb-commits] [lldb] r347125 - Just don't even attempt to invoke sed on Windows.

Author: adrian Date: Fri Nov 16 17:27:47 2018 New Revision: 347125 URL: http://llvm.org/viewvc/llvm-project?rev=347125&view=rev Log: Just don't even attempt to invoke sed on Windows. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/trunk/packages/Python/

[Lldb-commits] [lldb] r348440 - Add a unit test for ArchSpec matching to document how it behaves (and test it).

Author: adrian Date: Wed Dec 5 16:43:55 2018 New Revision: 348440 URL: http://llvm.org/viewvc/llvm-project?rev=348440&view=rev Log: Add a unit test for ArchSpec matching to document how it behaves (and test it). Modified: lldb/trunk/source/Utility/ArchSpec.cpp lldb/trunk/unittests/Utilit

[Lldb-commits] [lldb] r348502 - Add another ArchSpec unit test.

Author: adrian Date: Thu Dec 6 09:11:45 2018 New Revision: 348502 URL: http://llvm.org/viewvc/llvm-project?rev=348502&view=rev Log: Add another ArchSpec unit test. Modified: lldb/trunk/unittests/Utility/ArchSpecTest.cpp Modified: lldb/trunk/unittests/Utility/ArchSpecTest.cpp URL: http://ll

[Lldb-commits] [lldb] r348808 - Rewrite pexpect-based test in LIT/FileCheck.

Author: adrian Date: Mon Dec 10 14:57:47 2018 New Revision: 348808 URL: http://llvm.org/viewvc/llvm-project?rev=348808&view=rev Log: Rewrite pexpect-based test in LIT/FileCheck. pexecpt-based tests are flakey because they involve timeouts and this test is eprfectly serializable. Added: lldb/

[Lldb-commits] [lldb] r349194 - Remove the Disassembly benchmarks.

Author: adrian Date: Fri Dec 14 13:06:00 2018 New Revision: 349194 URL: http://llvm.org/viewvc/llvm-project?rev=349194&view=rev Log: Remove the Disassembly benchmarks. While I was out hunting for remaining pexpect-based tests, I came across these tests that can't possibly work an any modern syste

[Lldb-commits] [lldb] r349366 - Make crashlog.py work when a .dSYM is present, but a binary is missing

Author: adrian Date: Mon Dec 17 09:25:57 2018 New Revision: 349366 URL: http://llvm.org/viewvc/llvm-project?rev=349366&view=rev Log: Make crashlog.py work when a .dSYM is present, but a binary is missing Often users have a crash log an d a .dSYM bundle, but not the original application binary. It

[Lldb-commits] [lldb] r349367 - Make crashlog.py work or binaries with spaces in their names

Author: adrian Date: Mon Dec 17 09:26:04 2018 New Revision: 349367 URL: http://llvm.org/viewvc/llvm-project?rev=349367&view=rev Log: Make crashlog.py work or binaries with spaces in their names This is a little dangerous since the crashlog files aren't 100% unambiguous, but the risk is mitigated

[Lldb-commits] [lldb] r349398 - Reflow readme

Author: adrian Date: Mon Dec 17 13:18:12 2018 New Revision: 349398 URL: http://llvm.org/viewvc/llvm-project?rev=349398&view=rev Log: Reflow readme Modified: lldb/trunk/packages/Python/lldbsuite/test/README-TestSuite Modified: lldb/trunk/packages/Python/lldbsuite/test/README-TestSuite URL: h

[Lldb-commits] [lldb] r349397 - Remove sleep() synchronisation from teststcase and

Author: adrian Date: Mon Dec 17 13:18:11 2018 New Revision: 349397 URL: http://llvm.org/viewvc/llvm-project?rev=349397&view=rev Log: Remove sleep() synchronisation from teststcase and make the executable name more unique. This test is failing sporadically on some bots. By removing the sleep synch

Re: [Lldb-commits] [lldb] r349397 - Remove sleep() synchronisation from teststcase and

> On Dec 18, 2018, at 12:11 AM, Pavel Labath wrote: > > Not that I want to defend the use of sleep, but my expectation is that this > will the test even more flaky. > > The only thing that test does after attaching is verifying the process > backtrace to check that it contains the "main" fu

[Lldb-commits] [lldb] r349533 - Fix REQUIRES line

Author: adrian Date: Tue Dec 18 12:28:54 2018 New Revision: 349533 URL: http://llvm.org/viewvc/llvm-project?rev=349533&view=rev Log: Fix REQUIRES line Modified: lldb/trunk/lit/Python/crashlog.test Modified: lldb/trunk/lit/Python/crashlog.test URL: http://llvm.org/viewvc/llvm-project/lldb/tr

[Lldb-commits] [lldb] r349550 - TestHelloWorld: Use a file on the target platform for synchronisation.

Author: adrian Date: Tue Dec 18 14:17:38 2018 New Revision: 349550 URL: http://llvm.org/viewvc/llvm-project?rev=349550&view=rev Log: TestHelloWorld: Use a file on the target platform for synchronisation. Thanks to Pavel Labath for the idea! Modified: lldb/trunk/packages/Python/lldbsuite/tes

[Lldb-commits] [lldb] r349700 - Simplify code for readability. (NFC)

Author: adrian Date: Wed Dec 19 15:48:40 2018 New Revision: 349700 URL: http://llvm.org/viewvc/llvm-project?rev=349700&view=rev Log: Simplify code for readability. (NFC) Modified: lldb/trunk/source/Core/ValueObjectChild.cpp Modified: lldb/trunk/source/Core/ValueObjectChild.cpp URL: http://l

[Lldb-commits] [lldb] r349851 - Disable a few tests on the green dragon sanitzier bot.

Author: adrian Date: Thu Dec 20 15:16:47 2018 New Revision: 349851 URL: http://llvm.org/viewvc/llvm-project?rev=349851&view=rev Log: Disable a few tests on the green dragon sanitzier bot. These are tests that found actual, but hard to fix, bugs that are tracked elsewhere. Leaving them red only di

[Lldb-commits] [lldb] r349861 - Fix typo

Author: adrian Date: Thu Dec 20 15:50:32 2018 New Revision: 349861 URL: http://llvm.org/viewvc/llvm-project?rev=349861&view=rev Log: Fix typo Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py URL: http://llvm.

[Lldb-commits] [lldb] r349864 - Remove ineffective (misspelled) sanitizer option

Author: adrian Date: Thu Dec 20 17:09:14 2018 New Revision: 349864 URL: http://llvm.org/viewvc/llvm-project?rev=349864&view=rev Log: Remove ineffective (misspelled) sanitizer option Modified: lldb/trunk/lit/Suite/lit.cfg Modified: lldb/trunk/lit/Suite/lit.cfg URL: http://llvm.org/viewvc/llv

[Lldb-commits] [lldb] r349865 - Add an assertion to aid in tracking down a bug

Author: adrian Date: Thu Dec 20 17:09:15 2018 New Revision: 349865 URL: http://llvm.org/viewvc/llvm-project?rev=349865&view=rev Log: Add an assertion to aid in tracking down a bug Modified: lldb/trunk/source/Target/Thread.cpp Modified: lldb/trunk/source/Target/Thread.cpp URL: http://llvm.or

[Lldb-commits] [lldb] r350247 - Add file-based synchronization to flaky test

Author: adrian Date: Wed Jan 2 11:06:22 2019 New Revision: 350247 URL: http://llvm.org/viewvc/llvm-project?rev=350247&view=rev Log: Add file-based synchronization to flaky test TestQueues is failing randomly on green dragon and I suspect it is because the enqueued threads haven't executed by the

[Lldb-commits] [lldb] r350264 - Remove Range.* from Xcode project

Author: adrian Date: Wed Jan 2 14:23:51 2019 New Revision: 350264 URL: http://llvm.org/viewvc/llvm-project?rev=350264&view=rev Log: Remove Range.* from Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org

[Lldb-commits] [lldb] r350266 - Add file-based synching to places missed in r350247.

Author: adrian Date: Wed Jan 2 14:37:28 2019 New Revision: 350266 URL: http://llvm.org/viewvc/llvm-project?rev=350266&view=rev Log: Add file-based synching to places missed in r350247. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py lldb/trunk/packages/Pyt

[Lldb-commits] [lldb] r350274 - Rearrange bitfield to allow for more space in file_idx.

Author: adrian Date: Wed Jan 2 15:37:54 2019 New Revision: 350274 URL: http://llvm.org/viewvc/llvm-project?rev=350274&view=rev Log: Rearrange bitfield to allow for more space in file_idx. This is an alternate patch for the bug reported in https://bugs.llvm.org/show_bug.cgi?id=39816 ("lldb doesn'

[Lldb-commits] [lldb] r350360 - TestQueues: Move the synchronisation code into the binary itself.

Author: adrian Date: Thu Jan 3 14:34:48 2019 New Revision: 350360 URL: http://llvm.org/viewvc/llvm-project?rev=350360&view=rev Log: TestQueues: Move the synchronisation code into the binary itself. Thanks to Pavel Labath for the suggestion! Modified: lldb/trunk/packages/Python/lldbsuite/tes

[Lldb-commits] [lldb] r350537 - Simplify testcase by using lldbutil.run_to_source_breakpoint()

Author: adrian Date: Mon Jan 7 08:27:52 2019 New Revision: 350537 URL: http://llvm.org/viewvc/llvm-project?rev=350537&view=rev Log: Simplify testcase by using lldbutil.run_to_source_breakpoint() Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-inline-functions/TestModul

[Lldb-commits] [lldb] r350543 - Fine-tune and document the barrier in TestQueues.

Author: adrian Date: Mon Jan 7 09:18:39 2019 New Revision: 350543 URL: http://llvm.org/viewvc/llvm-project?rev=350543&view=rev Log: Fine-tune and document the barrier in TestQueues. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/main.c Modified: lldb/trunk/packages/Python

[Lldb-commits] [lldb] r350557 - Refactor test, no changes expected.

Author: adrian Date: Mon Jan 7 11:19:34 2019 New Revision: 350557 URL: http://llvm.org/viewvc/llvm-project?rev=350557&view=rev Log: Refactor test, no changes expected. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/main.c Modified: lldb/trunk/packages/Python/lldbsuite/tes

[Lldb-commits] [lldb] r350559 - Split two sub-tests into separate top-level methods.

Author: adrian Date: Mon Jan 7 11:24:04 2019 New Revision: 350559 URL: http://llvm.org/viewvc/llvm-project?rev=350559&view=rev Log: Split two sub-tests into separate top-level methods. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py Modified: lldb/trunk/packa

[Lldb-commits] [lldb] r350575 - Rename DWARFDIE::GetDWOContext() -> GetDeclContext() (NFC)

Author: adrian Date: Mon Jan 7 14:47:17 2019 New Revision: 350575 URL: http://llvm.org/viewvc/llvm-project?rev=350575&view=rev Log: Rename DWARFDIE::GetDWOContext() -> GetDeclContext() (NFC) Despite the name, this function has nothing to do with the DWO format. Modified: lldb/trunk/source/P

[Lldb-commits] [lldb] r350576 - Clarify comment and variable names. (NFC)

Author: adrian Date: Mon Jan 7 15:02:28 2019 New Revision: 350576 URL: http://llvm.org/viewvc/llvm-project?rev=350576&view=rev Log: Clarify comment and variable names. (NFC) Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified: lldb/trunk/source/Plugins/Symb

[Lldb-commits] [lldb] r350577 - Simplify code.

Author: adrian Date: Mon Jan 7 15:08:16 2019 New Revision: 350577 URL: http://llvm.org/viewvc/llvm-project?rev=350577&view=rev Log: Simplify code. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParser

[Lldb-commits] [lldb] r350651 - Convert to LLDB coding style (NFC)

Author: adrian Date: Tue Jan 8 12:48:40 2019 New Revision: 350651 URL: http://llvm.org/viewvc/llvm-project?rev=350651&view=rev Log: Convert to LLDB coding style (NFC) Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/

[Lldb-commits] [lldb] r332067 - Retrieve the deployment target when retrieving an object file's triple.

Author: adrian Date: Thu May 10 17:41:20 2018 New Revision: 332067 URL: http://llvm.org/viewvc/llvm-project?rev=332067&view=rev Log: Retrieve the deployment target when retrieving an object file's triple. Getting the deployment target can be significant information when rebuilding clang modules s

[Lldb-commits] [lldb] r332111 - HostInfoMacOSX: Share the clang resource directory with Swift.

Author: adrian Date: Fri May 11 10:54:09 2018 New Revision: 332111 URL: http://llvm.org/viewvc/llvm-project?rev=332111&view=rev Log: HostInfoMacOSX: Share the clang resource directory with Swift. Inside Xcode and in Xcode toolchains LLDB is always in lockstep with the Swift compiler, so it can re

[Lldb-commits] [lldb] r332120 - Fix a regression in r332111. The LLDB.framework path component is not

Author: adrian Date: Fri May 11 12:00:58 2018 New Revision: 332120 URL: http://llvm.org/viewvc/llvm-project?rev=332120&view=rev Log: Fix a regression in r332111. The LLDB.framework path component is not usually the last component. Modified: lldb/trunk/source/Host/macosx/HostInfoMacOSX.mm

[Lldb-commits] [lldb] r332126 - Yet another follow-up to r332111. This also handles the case where an

Author: adrian Date: Fri May 11 12:29:25 2018 New Revision: 332126 URL: http://llvm.org/viewvc/llvm-project?rev=332126&view=rev Log: Yet another follow-up to r332111. This also handles the case where an LLDB.framework is built inside the LLDB build directory (but not inside an Xcode installation).

[Lldb-commits] [lldb] r332140 - Conditionally compile a Darwin-only test.

Author: adrian Date: Fri May 11 14:05:32 2018 New Revision: 332140 URL: http://llvm.org/viewvc/llvm-project?rev=332140&view=rev Log: Conditionally compile a Darwin-only test. Modified: lldb/trunk/unittests/Host/HostInfoTest.cpp Modified: lldb/trunk/unittests/Host/HostInfoTest.cpp URL: http:

Re: [Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

Thanks for jumping on this Amara — I just wanted to point out that we ususally don't revert lldb changes that only break the lldb-xcode bot if they pass on the lldb-cmake bot at the same time. When this happens it usually means that the lldb Xcode project must be updated and it's too much to ask

Re: [Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

> On May 18, 2018, at 11:25 AM, Amara Emerson via Phabricator > wrote: > > aemerson added a comment. > > In https://reviews.llvm.org/D46889#1104823, @aprantl wrote: > >> Thanks for jumping on this Amara — I just wanted to point out that we >> ususally don't revert lldb changes that only bre

Re: [Lldb-commits] [PATCH] D43984: Make the clang module cache setting available without a target

Can you help me understand why this dependency poses a problem? It's not clear to me how to resolve this otherwise. The point of the patch is to ask the clang driver for the clang module cache path. If the problem is that we otherwise don't use the driver and now pull it in, would moving the Cla

Re: [Lldb-commits] [PATCH] D47235: Move ModuleList's dependency on clangDriver into Host

> On May 22, 2018, at 6:57 PM, Zachary Turner wrote: > > Yea I don’t think this addresses the problem. We should be able to link > against parts of lldb without a dependency on clang. Since this is about > configuring something related to clang, it seems like it should be isolated > to some

Re: [Lldb-commits] [PATCH] D47235: Move ModuleList's dependency on clangDriver into Host

> On May 23, 2018, at 8:51 AM, Zachary Turner wrote: > > There's not really a diagram, because we don't have an exact vision of what > the final layering is going to look like (some things will need to be split > up, entirely new targets will need to be introduced, etc). Mostly it's just >

Re: [Lldb-commits] [PATCH] D47235: Move ModuleList's dependency on clangDriver into Host

> On May 23, 2018, at 1:33 PM, Zachary Turner wrote: > > Actually, now I’m starting to wonder why can’t ClangModulesDeclVendor.cpp > just call this function in clangDriver to get the default if the accessor > returns an empty string? That sidesteps all of this initialization funny > busi

[Lldb-commits] [lldb] r333140 - Add a --synchronous option to lldb-mi to facilitate reliable testing.

Author: adrian Date: Wed May 23 16:33:50 2018 New Revision: 333140 URL: http://llvm.org/viewvc/llvm-project?rev=333140&view=rev Log: Add a --synchronous option to lldb-mi to facilitate reliable testing. Patch by Alexander Polyakov! Differential Revision: https://reviews.llvm.org/D47110 Modified

[Lldb-commits] [lldb] r333205 - [lldb-mi] Add possibility to set breakpoints without selecting a target.

Author: adrian Date: Thu May 24 09:45:59 2018 New Revision: 333205 URL: http://llvm.org/viewvc/llvm-project?rev=333205&view=rev Log: [lldb-mi] Add possibility to set breakpoints without selecting a target. Now it's possible to set breakpoints before selecting a target, they will be set to the dum

[Lldb-commits] [lldb] r333248 - HostInfoMacOSX: Support finding the clang resource directory within CLTools.

Author: adrian Date: Thu May 24 17:29:01 2018 New Revision: 333248 URL: http://llvm.org/viewvc/llvm-project?rev=333248&view=rev Log: HostInfoMacOSX: Support finding the clang resource directory within CLTools. rdar://problem/40537961 Modified: lldb/trunk/source/Host/macosx/HostInfoMacOSX.mm

Re: [Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API using SBError parameter.

> On Jun 12, 2018, at 9:08 AM, Adrian Prantl via Phabricator > wrote: > > aprantl added a comment. > > Hmm.. @lemo 's reasoning What I was going to say here: Just from looking at the API documentation, it looks like default arguments are mapped into Python by SWIG, so there doesn't seem to

[Lldb-commits] [lldb] r334614 - Fix/unify the spelling of Objective-C.

Author: adrian Date: Wed Jun 13 09:21:24 2018 New Revision: 334614 URL: http://llvm.org/viewvc/llvm-project?rev=334614&view=rev Log: Fix/unify the spelling of Objective-C. Modified: lldb/trunk/CODE_OWNERS.txt lldb/trunk/examples/darwin/heap_find/heap/heap_find.cpp lldb/trunk/include/l

[Lldb-commits] [lldb] r335386 - Mark this test as no debuginfo

Author: adrian Date: Fri Jun 22 13:26:53 2018 New Revision: 335386 URL: http://llvm.org/viewvc/llvm-project?rev=335386&view=rev Log: Mark this test as no debuginfo Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/hello_world/TestHelloWorld.py Modified: lldb/trunk/packages/Pyt

Re: [Lldb-commits] Adding a test for split-dwarf

We just use reviews.llvm.org and CC lldb-commits. -- adrian > On Jun 25, 2018, at 9:09 PM, Puyan Lotfi via lldb-commits > wrote: > > This is a first draft. Just trying to do some basic breakpoint and line > number checks on a split dwarf compiled binary for now. >

[Lldb-commits] [lldb] r339828 - Add libc++ data formatters for std::optional.

Author: adrian Date: Wed Aug 15 15:48:48 2018 New Revision: 339828 URL: http://llvm.org/viewvc/llvm-project?rev=339828&view=rev Log: Add libc++ data formatters for std::optional. Patch by Shafik Yaghmour! This reapplies an earlier version after addressing some post-commit feedback. Differential

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

After reading through the code in TestVSCode_attach.py I see that there are lots of commands with a 1s timeout. I would not be surprised if that is too small for running on a bot, which is by definition under extreme load. Do you think increasing the timeouts would help? -- adrian _

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

> On Aug 17, 2018, at 10:35 AM, Greg Clayton wrote: > > I can expectedFail this test if needed? I'm afraid it looks like that won't be good enough. I just had to manually log into the build node and kill TestVSCode_variables.py, too, because it was hanging indefinitely. We either need to fig

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

Here's the output from attach: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/9017/testReport/lldb-Suite/tools_lldb-vscode_attach/TestVSCode_attach_py > On Aug 17, 2018, at 11:32 AM, Adrian Prantl via lldb-commits > wrote: > > > >> On Aug 17, 2018, at 10:

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

2018, at 11:33 AM, Adrian Prantl wrote: > > Here's the output from attach: > > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/9017/testReport/lldb-Suite/tools_lldb-vscode_attach/TestVSCode_attach_py > >> On Aug 17, 2018, at 11:32 AM, Adrian Prantl via lldb-com

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

ipped, 0 expected >> failures, 0 unexpected successes) >> >> Do you have access to a Mac to reproduce these failures? >> >> -- adrian >> >>> On Aug 17, 2018, at 11:33 AM, Adrian Prantl wrote: >>> >>> Here's the output from atta

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

> On Aug 17, 2018, at 1:49 PM, Adrian Prantl wrote: > > > On Aug 17, 2018, at 1:44 PM, Greg Clayton wrote: > >> I run everything on a mac and there are no failures on my machine. >> Can you find out exactly how the test suite is invoked so I can try to >> reproduce? > > You can find the e

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

We really need to do *something*. Normally our lldb-cmake bot churns out a fresh run every 10 minutes, now it is timing out after 1.5 hours: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/9021/consoleFull#console-section-10 Build timed out (after 90 minutes). Marking the build as aborte

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

Thanks! Do let me know if I can help you with figuring this out. -- adrian > On Aug 17, 2018, at 5:34 PM, Greg Clayton wrote: > > $ svn commit > Sending > packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py > Sending > packages/Python/lldbsuite/test/tool

[Lldb-commits] [lldb] r340218 - Set path to sanitizer runtime when running tests through LIT on macOS.

Author: adrian Date: Mon Aug 20 15:00:31 2018 New Revision: 340218 URL: http://llvm.org/viewvc/llvm-project?rev=340218&view=rev Log: Set path to sanitizer runtime when running tests through LIT on macOS. rdar://problem/42984739 Differential Revision: https://reviews.llvm.org/D50997 Modified:

[Lldb-commits] [lldb] r340219 - Reflow comments

Author: adrian Date: Mon Aug 20 15:00:32 2018 New Revision: 340219 URL: http://llvm.org/viewvc/llvm-project?rev=340219&view=rev Log: Reflow comments Modified: lldb/trunk/lit/Suite/lldbtest.py Modified: lldb/trunk/lit/Suite/lldbtest.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/

[Lldb-commits] [lldb] r340286 - Makefile.rules: Use an absolute path to the module cache directory.

Author: adrian Date: Tue Aug 21 08:46:15 2018 New Revision: 340286 URL: http://llvm.org/viewvc/llvm-project?rev=340286&view=rev Log: Makefile.rules: Use an absolute path to the module cache directory. This change is NFC, but it makes it more obvious in log files what happened. Modified: lldb

[Lldb-commits] [lldb] r340293 - lldbtest.py: Unconditionally set the clang module cache path.

Author: adrian Date: Tue Aug 21 09:13:37 2018 New Revision: 340293 URL: http://llvm.org/viewvc/llvm-project?rev=340293&view=rev Log: lldbtest.py: Unconditionally set the clang module cache path. This should fix the errors observable on the new lldb-cmake bot. Modified: lldb/trunk/packages/Py

[Lldb-commits] [lldb] r340543 - Add libc++ data formatter for std::function

Author: adrian Date: Thu Aug 23 10:02:39 2018 New Revision: 340543 URL: http://llvm.org/viewvc/llvm-project?rev=340543&view=rev Log: Add libc++ data formatter for std::function - Added LibcxxFunctionSummaryProvider - Removed LibcxxFunctionFrontEnd - Modified data formatter tests to test new summa

[Lldb-commits] [lldb] r340548 - lldbtest.py: Work around macOS SIP when testing ASANified builds.

Author: adrian Date: Thu Aug 23 10:19:08 2018 New Revision: 340548 URL: http://llvm.org/viewvc/llvm-project?rev=340548&view=rev Log: lldbtest.py: Work around macOS SIP when testing ASANified builds. Modified: lldb/trunk/lit/Suite/lldbtest.py Modified: lldb/trunk/lit/Suite/lldbtest.py URL: h

[Lldb-commits] [lldb] r340550 - XFAIL test for older versions of dsymutil

Author: adrian Date: Thu Aug 23 10:30:56 2018 New Revision: 340550 URL: http://llvm.org/viewvc/llvm-project?rev=340550&view=rev Log: XFAIL test for older versions of dsymutil Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/unicode/TestUnicodeSymbols.py Modified: lldb/trunk/packa

[Lldb-commits] [lldb] r340557 - Fix check for dictionary entry

Author: adrian Date: Thu Aug 23 10:51:14 2018 New Revision: 340557 URL: http://llvm.org/viewvc/llvm-project?rev=340557&view=rev Log: Fix check for dictionary entry Modified: lldb/trunk/lit/Suite/lldbtest.py Modified: lldb/trunk/lit/Suite/lldbtest.py URL: http://llvm.org/viewvc/llvm-project/

[Lldb-commits] [lldb] r340573 - XFAIL test for older versions of clang

Author: adrian Date: Thu Aug 23 14:00:37 2018 New Revision: 340573 URL: http://llvm.org/viewvc/llvm-project?rev=340573&view=rev Log: XFAIL test for older versions of clang Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/unicode/TestUnicodeSymbols.py Modified: lldb/trunk/packages

[Lldb-commits] [lldb] r340574 - Change xfail to skipIf. The exact condition is really difficult to get

Author: adrian Date: Thu Aug 23 14:08:30 2018 New Revision: 340574 URL: http://llvm.org/viewvc/llvm-project?rev=340574&view=rev Log: Change xfail to skipIf. The exact condition is really difficult to get right and doesn't add much signal. Modified: lldb/trunk/packages/Python/lldbsuite/test/l

[Lldb-commits] [lldb] r340779 - Fix typo

Author: adrian Date: Mon Aug 27 14:46:18 2018 New Revision: 340779 URL: http://llvm.org/viewvc/llvm-project?rev=340779&view=rev Log: Fix typo Modified: lldb/trunk/test/CMakeLists.txt Modified: lldb/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/CMakeLists

[Lldb-commits] [lldb] r340791 - Add a mkdir -p to builddir into lldbtest.py

Author: adrian Date: Mon Aug 27 16:06:37 2018 New Revision: 340791 URL: http://llvm.org/viewvc/llvm-project?rev=340791&view=rev Log: Add a mkdir -p to builddir into lldbtest.py Based on how it is executed, it may not have been yet created. Modified: lldb/trunk/lit/Suite/lldbtest.py Modified

[Lldb-commits] [lldb] r340792 - Make the DYLD_INSERT_LIBRARIES workaround for SIP more robut for the various configurations that bots are running

Author: adrian Date: Mon Aug 27 16:06:38 2018 New Revision: 340792 URL: http://llvm.org/viewvc/llvm-project?rev=340792&view=rev Log: Make the DYLD_INSERT_LIBRARIES workaround for SIP more robut for the various configurations that bots are running Modified: lldb/trunk/lit/Suite/lldbtest.py M

[Lldb-commits] [lldb] r340994 - Refactor BreakpointResolver::SetSCMatchesByLine() to make it easier to

Author: adrian Date: Wed Aug 29 16:16:42 2018 New Revision: 340994 URL: http://llvm.org/viewvc/llvm-project?rev=340994&view=rev Log: Refactor BreakpointResolver::SetSCMatchesByLine() to make it easier to read/understand/maintain. As a side-effect, this should also improve the performance by avoid

[Lldb-commits] [lldb] r341078 - Support setting a breakpoint by FileSpec+Line+Column in the SBAPI.

Author: adrian Date: Thu Aug 30 08:11:00 2018 New Revision: 341078 URL: http://llvm.org/viewvc/llvm-project?rev=341078&view=rev Log: Support setting a breakpoint by FileSpec+Line+Column in the SBAPI. This patch extends the SBAPI to allow for setting a breakpoint not only at a specific line, but a

  1   2   3   4   5   6   7   8   9   10   >