Ah, I missed the "not_in" in that decorator. Thanks.
On Wed, Feb 3, 2016 at 1:38 AM, Pavel Labath wrote:
> On 2 February 2016 at 23:08, Adrian McCarthy via lldb-commits
> wrote:
> > Thanks for the confirmation. I'm still not sure how
> TestConsecutiveBreakpoi
Author: amccarth
Date: Thu Feb 4 09:35:55 2016
New Revision: 259793
URL: http://llvm.org/viewvc/llvm-project?rev=259793&view=rev
Log:
Provide arguments for all the format string placeholders!
Log message was wrong because an argument was missing.
Modified:
lldb/trunk/source/Plugins/Process/
Author: amccarth
Date: Thu Feb 4 16:20:30 2016
New Revision: 259834
URL: http://llvm.org/viewvc/llvm-project?rev=259834&view=rev
Log:
Replace tabs with spaces for consistent indentation. No actual text changes.
Modified:
lldb/trunk/www/status.html
Modified: lldb/trunk/www/status.html
URL:
amccarth created this revision.
amccarth added reviewers: zturner, jingham.
amccarth added a subscriber: lldb-commits.
Just a proposal.
http://reviews.llvm.org/D16902
Files:
www/status.html
Index: www/status.html
===
--- www/stat
amccarth updated this revision to Diff 46964.
amccarth added a comment.
More tweaks after comments from Zach.
Notably removed the Script Bridging row since that's duplicating the Python
Scripting row.
http://reviews.llvm.org/D16902
Files:
www/status.html
Index: www/status.html
amccarth added a comment.
Friendly ping.
http://reviews.llvm.org/D16902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: amccarth
Date: Tue Feb 9 17:52:57 2016
New Revision: 260328
URL: http://llvm.org/viewvc/llvm-project?rev=260328&view=rev
Log:
Add status for LLDB on Windows to status.html.
Differential Revision: http://reviews.llvm.org/D16902
Modified:
lldb/trunk/www/status.html
Modified: lldb/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260328: Add status for LLDB on Windows to status.html.
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16902?vs=46964&id=47390#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: amccarth
Date: Tue Feb 9 18:06:50 2016
New Revision: 260331
URL: http://llvm.org/viewvc/llvm-project?rev=260331&view=rev
Log:
Don't dereference the first element of an empty container.
Modified:
lldb/trunk/source/Symbol/Symtab.cpp
Modified: lldb/trunk/source/Symbol/Symtab.cpp
URL:
amccarth added a subscriber: amccarth.
amccarth added a comment.
I like that you're doing this, but ...
There's a ton of duplication here. I'd really like to see the conversions
centralized with consistent error handling. Cluttering up already-too-long
functions with more #ifdefs and a half d
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
In some circumstances (notably, certain minidumps), the thread CONTEXT does not
have values for the control registers (EIP, ESP, EBP, EFLAGS). There are flags
in the CONTEXT which indi
Author: amccarth
Date: Thu Feb 11 12:24:57 2016
New Revision: 260559
URL: http://llvm.org/viewvc/llvm-project?rev=260559&view=rev
Log:
Improve ReadRegister for RegisterContextWindowsx86
In some circumstances (notably, certain minidumps), the thread CONTEXT does not
have values for the
control re
amccarth added inline comments.
Comment at: source/Host/common/HostInfoBase.cpp:88
@@ +87,3 @@
+{
+CleanupProcessSpecificLLDBTempDir();
+delete g_fields;
There's a difference in behavior in that this now happens even if we haven't
(yet) created a temp dir
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
32-bit processes on 64-bit Windows run in a layer called WoW64
(Windows-on-Windows64). If you capture a mini dump of such a process from a
32-bit debugger, you end up with a register c
amccarth marked an inline comment as done.
amccarth added a comment.
In http://reviews.llvm.org/D17465#357569, @zturner wrote:
> I'll have to look at this more carefully next week.
Take your time, I'm still working on adding some tests for this.
> I'm guessing the same logic can eventually b
amccarth updated this revision to Diff 48712.
amccarth added a comment.
Addressed first round of comments.
http://reviews.llvm.org/D17465
Files:
source/Plugins/Process/Windows/Common/NtStructures.h
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
Index: source/Plugins/Process
amccarth added a comment.
Could you post the patch with full context? It's easier to see the changes in
context.
The information looks right. It's nice to see all the build-Python-yourself
stuff simplified away.
Comment at: www/build.html:63
@@ -64,1 +62,3 @@
+
amccarth added inline comments.
Comment at: lldb/trunk/source/Host/common/FileSpec.cpp:1179
@@ +1178,3 @@
+
+char child_path[PATH_MAX];
+const int child_path_len = ::snprintf (child_path,
sizeof(child_path), "%s\\%s", dir_path, fileName.c_str());
-
amccarth added inline comments.
Comment at: lldb/trunk/source/Host/common/FileSpec.cpp:1179
@@ +1178,3 @@
+
+char child_path[PATH_MAX];
+const int child_path_len = ::snprintf (child_path,
sizeof(child_path), "%s\\%s", dir_path, fileName.c_str());
-
It looks like this patch reorders the #includes in a way that seems
contrary to general practice. In particular, if foo.cpp has a header
foo.h, then it should include foo.h before any other files. This helps
ensure that foo.h can stand alone and won't require clients to have to
figure out what el
amccarth updated this revision to Diff 48863.
amccarth added a comment.
Adds some very basic tests using a check-in minidump captured with Task Manager.
What we can do in the test is limited because the minidump doesn't seem to have
an exception record (thus the thread isn't stopped). I plan to
amccarth added inline comments.
Comment at:
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:238-240
@@ +237,5 @@
+
+// NOTE: We don't currently use the TEB for anything
else. If we need it in
+// the future, the 32-bit TEB
Author: amccarth
Date: Wed Feb 24 18:23:27 2016
New Revision: 261808
URL: http://llvm.org/viewvc/llvm-project?rev=261808&view=rev
Log:
Get register context for the 32-bit process in a WoW64 process minidump
32-bit processes on 64-bit Windows run in a layer called WoW64
(Windows-on-Windows64). If
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261808: Get register context for the 32-bit process in a
WoW64 process minidump (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D17465?vs=48863&id=48989#toc
Repository:
rL LL
Author: amccarth
Date: Wed Feb 24 18:24:07 2016
New Revision: 261810
URL: http://llvm.org/viewvc/llvm-project?rev=261810&view=rev
Log:
XFail TestInlines.py on Windows with clang.
Test expects the breakpoint to resolve to three locations, but clang on windows
yields only 2.
llvm.org/pr26710
Mod
amccarth added a comment.
I'm growing more comfortable with these changes, but I'll defer to Zach.
Comment at: lldb/trunk/source/Host/common/FileSpec.cpp:242
@@ -221,1 +241,3 @@
+path.push_back(0);
+path.pop_back();
}
I recognize that you're
amccarth created this revision.
amccarth added reviewers: zturner, spyffe.
amccarth added a subscriber: lldb-commits.
The inlining semantics for C and C++ are different, which affects the test's
expectation of the number of times the function should appear in the binary.
In the case of this tes
amccarth added a comment.
I'm going to interpret silence as consent. This review was mostly FYI.
http://reviews.llvm.org/D17650
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262255: Fix TestInlines.py on Windows (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D17650?vs=49208&id=49409#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17650
Files:
Author: amccarth
Date: Mon Feb 29 15:13:29 2016
New Revision: 262255
URL: http://llvm.org/viewvc/llvm-project?rev=262255&view=rev
Log:
Fix TestInlines.py on Windows
The inlining semantics for C and C++ are different, which affects the test's
expectation of the number of times the function should
Author: amccarth
Date: Mon Feb 29 15:15:23 2016
New Revision: 262256
URL: http://llvm.org/viewvc/llvm-project?rev=262256&view=rev
Log:
NFC: Refactor ProcessWinMiniDump to use a more traditional pimpl idiom.
This is a mechanical refactor. There should be no functional changes in this
commit.
I
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
Thanks for the fix.
Right now I'm trying to figure out why the test framework didn't detect the
crash and reported that all the tests passed.
Comment at: source/Expressi
amccarth created this revision.
amccarth added reviewers: tfiala, zturner.
amccarth added a subscriber: lldb-commits.
Nobody seems to know what purpose these files serve, yet they were accumulating
by the thousands in the test traces directory. I'm proposing we delete them.
Creating these files
Author: amccarth
Date: Thu Mar 10 09:41:11 2016
New Revision: 263122
URL: http://llvm.org/viewvc/llvm-project?rev=263122&view=rev
Log:
Eliminate the TestStarted-XXX and TestFinished-XXX files from check-lldb runs.
Nobody seems to know what purpose these files serve, yet they were accumulating
by
If we're favoring the macros over the functions, then
perhaps update the #includes?
On Fri, Mar 11, 2016 at 7:33 PM, Jim Ingham via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: jingham
> Date: Fri Mar 11 21:33:36 2016
> New Revision: 26
>
> URL: http://llvm.org/viewvc/llvm-p
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
looks good
http://reviews.llvm.org/D18287
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
amccarth added a comment.
I like where this is going. Just a couple concerns.
Comment at: tools/driver/Platform.h:15
@@ -14,4 +14,3 @@
// this will stop signal.h being included
#include "lldb/Host/HostGetOpt.h"
delete this comment
amccarth added a subscriber: amccarth.
amccarth added a comment.
This just seems to insert an extra prompt rather than solving the problem with
the prompt being printed too late.
http://reviews.llvm.org/D18335
___
lldb-commits mailing list
lldb-com
amccarth added a comment.
I patched this change in, and now I'm getting extra prompts on Windows rather
than getting the too-late prompt sooner. So is that a separate bug?
http://reviews.llvm.org/D18335
___
lldb-commits mailing list
lldb-commits@l
amccarth added a comment.
Here's a snippet of output with this fix patched in on Windows. Note the extra
(lldb) prompts on the lines beginning with "Process 10672..."
(lldb) br set -l 22
Breakpoint 1: where = a.exe`main + 20 at fizzbuzz.cpp:22, address = 0x0040e074
(lldb) run
Process 10672 laun
amccarth added a comment.
This is better. In the same scenario, I see just one extra prompt instead of
three extras. Maybe that one happens through a different code path.
> (lldb) br set -l 22
> Breakpoint 1: where = a.exe`main + 20 at fizzbuzz.cpp:22, address =
> 0x0040e074
> (lldb) run
amccarth created this revision.
amccarth added a reviewer: clayborg.
amccarth added a subscriber: lldb-commits.
I set out to add functionality to dump headers from a binary, only to discover
that the functionality already existed but wasn't (as far as I can tell) hooked
up to the command line.
amccarth added a comment.
I'm using it with PE files (Windows), so I see
A table of where the debug info exists
MSDOS Header
COFF Header
PECOFF header
a table of section headers (.rdata, .bss, etc.).
The section headers table is redundant with `target modules dump sections`, but
I don't see ano
amccarth added a comment.
Literally:
Dumping headers for 1 module(s).
Headers for 'd:\src\fizzbuzz\a.exe':
Module d:\src\fizzbuzz\a.exe
04189230: ObjectFilePECOFF, file = 'd:\src\fizzbuzz\a.exe', arch = i386
SectID Type File Address
amccarth added a subscriber: amccarth.
amccarth added a comment.
I'm not a CMake expert, so I haven't really reviewed those bits.
Comment at: cmake/modules/LLDBConfig.cmake:253
@@ -250,2 +252,3 @@
+else()
add_definitions( /D _UNICODE /D UNICODE )
endif()
---
amccarth added a comment.
Ping.
http://reviews.llvm.org/D18464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: amccarth
Date: Mon Apr 4 11:41:16 2016
New Revision: 265308
URL: http://llvm.org/viewvc/llvm-project?rev=265308&view=rev
Log:
Set the architecture type from minidump more precisely. Differentiate i686 v
i386 when possible.
Modified:
lldb/trunk/source/Plugins/Process/Windows/MiniDum
amccarth updated this revision to Diff 52588.
amccarth added a comment.
OK, this now dumps headers for the ObjectFiles of the modules rather than the
modules themselves, using `target modules dump objfile` as suggested.
My only concern here is that the SB API has a module dump, but no object fil
amccarth updated this revision to Diff 52618.
amccarth added a comment.
Removed the "headers for" string, but kept the name of the file, as not all of
the ObjectFile::Dump implementations (e.g., ELF) print the file name.
http://reviews.llvm.org/D18464
Files:
source/Commands/CommandObjectTarg
amccarth added inline comments.
Comment at: source/Commands/CommandObjectTarget.cpp:1568
@@ +1567,3 @@
+ObjectFile *objfile = module->GetObjectFile();
+strm.Printf("'%s':\n", objfile->GetFileSpec().GetCString());
+strm.IndentMore();
amccarth updated this revision to Diff 52624.
amccarth added a comment.
Removed the per-file header from the common code and make the
ObjectFileELF::Dump print its own header like the others.
http://reviews.llvm.org/D18464
Files:
source/Commands/CommandObjectTarget.cpp
source/Plugins/Objec
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265349: Implement `target modules dump objfile` (authored by
amccarth).
Changed prior to commit:
http://reviews.llvm.org/D18464?vs=52624&id=52626#toc
Repository:
rL LLVM
http://reviews.llvm.org/D184
Author: amccarth
Date: Mon Apr 4 16:21:49 2016
New Revision: 265349
URL: http://llvm.org/viewvc/llvm-project?rev=265349&view=rev
Log:
Implement `target modules dump objfile`
Differential Revision: http://reviews.llvm.org/D18464
Modified:
lldb/trunk/source/Commands/CommandObjectTarget.cpp
Author: amccarth
Date: Tue Apr 5 15:49:09 2016
New Revision: 265461
URL: http://llvm.org/viewvc/llvm-project?rev=265461&view=rev
Log:
XFail TestImport.py on Windows because Python 3 import rules don't work that
way.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/comman
gt;
> If you can get that, i can help come up with a fix. Just need to step
> through the execution of the command until you get to the python or c code
> that tries to do the import
>
> On Tue, Apr 5, 2016 at 1:54 PM Adrian McCarthy via lldb-commits <
> lldb-commits@lists.llvm.
Author: amccarth
Date: Tue Apr 5 16:49:41 2016
New Revision: 265476
URL: http://llvm.org/viewvc/llvm-project?rev=265476&view=rev
Log:
Revert "XFail TestImport.py on Windows because Python 3 import rules don't work
that way."
This reverts commit e5f0ba4fcf977ad6baaaca700d3646675cdac19b.
Modifie
> I think we need some more information before we xfail this. It would
>>>> help to drill down to either the python import statement or the
>>>> PyImport_ImportModule C api call that actually does the import.
>>>>
>>>> If you can get that, i can
#x27;ll revert the xfail if you want. But this has been broken for quite
>> a while (as has another test, which I'm looking into now).
>> >
>> > On Tue, Apr 5, 2016 at 2:29 PM, Zachary Turner
>> wrote:
>> > I think we need some more information befor
Author: amccarth
Date: Thu Apr 7 17:52:12 2016
New Revision: 265738
URL: http://llvm.org/viewvc/llvm-project?rev=265738&view=rev
Log:
Fix TestImport for Windows by ensuring backslashes in the directory paths are
properly escaped in Python.
The Python import works by ensuring the directory of th
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
This solves a flaky test on Windows.
We have similar logic elsewhere for log files. I considered trying to combine
them, but since they are methods of different objects, there wasn't r
amccarth updated this revision to Diff 53100.
amccarth added a comment.
Consolidated the os.remove and os.unlink calls with a function to do the
retries. Tested on Windows.
http://reviews.llvm.org/D18912
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbsuite/tes
amccarth added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1994
@@ +1993,3 @@
+# failure and retry.
+def remove_file(file, num_retries = 1, sleep_duration = 0.5):
+while True:
zturner wrote:
> I think the default for `num_retries` s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265948: Retry deletion of temporary files to avoid race
conditions on Windows. (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D18912?vs=53100&id=53249#toc
Repository:
rL LLV
Author: amccarth
Date: Mon Apr 11 10:21:01 2016
New Revision: 265948
URL: http://llvm.org/viewvc/llvm-project?rev=265948&view=rev
Log:
Retry deletion of temporary files to avoid race conditions on Windows.
Differential Revision: http://reviews.llvm.org/D18912
Modified:
lldb/trunk/packages/Py
amccarth added a subscriber: amccarth.
amccarth added a comment.
FYI: According to git bisect, this patch seems to have introduced a new test
failure on Windows.
http://reviews.llvm.org/D18886
___
lldb-commits mailing list
lldb-commits@lists.llvm.
amccarth added a comment.
It's weird in that, if you run the test independently, it passes. But if you
run it with the multiprocess test runner (ninja check-lldb), then it fails on
this line:
self.fail("Setting a breakpoint generated an unexpected event: %s" %
lldb.SBDebugger.StateAsCString(l
amccarth created this revision.
amccarth added reviewers: ovyalov, labath.
amccarth added a subscriber: lldb-commits.
When run with the multiprocess test runner, the getchar() trick doesn't work,
so `ninja check-lldb` would fail on this test, but running the test directly
worked fine.
This repl
amccarth marked an inline comment as done.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp:11
@@ -10,2 +10,3 @@
+#include
#include
#include
ovyalov wrote:
> You may remove iostream since getchar is no lon
This revision was automatically updated to reflect the committed changes.
amccarth marked an inline comment as done.
Closed by commit rL266145: Fix breakpoint_set_restart test for Windows
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D19035?vs=53472&id=53482#toc
Repo
Author: amccarth
Date: Tue Apr 12 17:45:03 2016
New Revision: 266145
URL: http://llvm.org/viewvc/llvm-project?rev=266145&view=rev
Log:
Fix breakpoint_set_restart test for Windows
When run with the multiprocess test runner, the getchar() trick doesn't work,
so ninja check-lldb would fail on this
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Disabling buffering exposes a bug in the MS VS 2015 CRT implementation of
fgets, where you sometimes have to hit Enter twice, depending on if the input
had an odd or even number of char
amccarth added a comment.
In http://reviews.llvm.org/D19136#401888, @zturner wrote:
> I think you can probably leave buffering turned off for stdout and only do
> this change for stdin unless we find some other bug. AFAIK the problem is
> confined to stdin. I'd probably leave a comment in `Dr
Author: amccarth
Date: Thu Apr 14 18:31:17 2016
New Revision: 266384
URL: http://llvm.org/viewvc/llvm-project?rev=266384&view=rev
Log:
Don't disable stdin buffering on Windows
Disabling buffering exposes a bug in the MS VS 2015 CRT implementation of
fgets, where you sometimes have to hit Enter t
amccarth closed this revision.
amccarth added a comment.
http://reviews.llvm.org/rL266384
http://reviews.llvm.org/D19136
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth added a subscriber: amccarth.
amccarth added a comment.
FYI: This patch seems to have broken all LLDB testing on Windows. I'll
investigate why.
Lots of the socket calls now result in stack traces like this:
Traceback (most recent call last):
File "C:\python_35\lib\multiprocessi
amccarth created this revision.
amccarth added a reviewer: spyffe.
amccarth added a subscriber: lldb-commits.
http://reviews.llvm.org/D19489
Files:
source/Expression/DiagnosticManager.cpp
Index: source/Expression/DiagnosticManager.cpp
===
amccarth added a comment.
We already limit threads on Windows to work around other problems.
Technically, we force Windows to always use the multiprocessing-pool instead of
the threading-pool, which I think has the effect of limiting the number of
threads.
I suspect that the first several inv
amccarth added a comment.
I got it. There was an exception being thrown from asyncore so early that it
didn't give a proper stack trace. The problem boils down to Python 3 drawing a
distinction between strings and bytearrays. Patch to come momentarily.
Thanks for your help.
http://reviews.
amccarth created this revision.
amccarth added a reviewer: tfiala.
amccarth added a subscriber: lldb-commits.
Python 3.5 is pickier about the distinction between chars and bytes (and
strings and bytearrays) than Python 2.7.
The call to ack_bytes.append(chr(42)) was causing a type error to be thr
Author: amccarth
Date: Tue Apr 26 10:15:29 2016
New Revision: 267562
URL: http://llvm.org/viewvc/llvm-project?rev=267562&view=rev
Log:
Fix send and receive of ACK byte in test infrastructure for Python 3.5
Python 3.5 is pickier about the distinction between chars and bytes (and
strings and bytea
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267562: Fix send and receive of ACK byte in test
infrastructure for Python 3.5 (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D19510?vs=54938&id=55005#toc
Repository:
rL LLV
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Now when you do a thread list, you'll see the exception information in the stop
info for the thread that stopped.
I'd like to move the ExceptionRecord.h file to a common place as a sepa
amccarth marked 2 inline comments as done.
Comment at: source/Plugins/Process/win-minidump/ProcessWinMiniDump.cpp:173
@@ -174,1 +172,3 @@
{
+if (m_data_up && m_data_up->m_exception_sp)
+{
zturner wrote:
> Can you invert this conditional and early-out to k
amccarth updated this revision to Diff 32475.
amccarth marked an inline comment as done.
amccarth added a comment.
Addresses some of Zach's comments.
http://reviews.llvm.org/D12126
Files:
source/Plugins/Process/Windows/ExceptionRecord.h
source/Plugins/Process/win-minidump/ProcessWinMiniDump
amccarth updated this revision to Diff 32476.
amccarth added a comment.
Forgot to flip logic for the early outs.
http://reviews.llvm.org/D12126
Files:
source/Plugins/Process/Windows/ExceptionRecord.h
source/Plugins/Process/win-minidump/ProcessWinMiniDump.cpp
source/Plugins/Process/win-min
Author: amccarth
Date: Wed Aug 19 15:43:22 2015
New Revision: 245495
URL: http://llvm.org/viewvc/llvm-project?rev=245495&view=rev
Log:
Read exception records from Windows mini dump
Differential Revision: http://reviews.llvm.org/D12126
Modified:
lldb/trunk/source/Plugins/Process/Windows/Excep
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245495: Read exception records from Windows mini dump
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D12126?vs=32476&id=32606#toc
Repository:
rL LLVM
http://reviews.llvm.or
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
http://reviews.llvm.org/D12363
Files:
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h
Index: source/Plugi
amccarth marked an inline comment as done.
amccarth added a comment.
New patch coming up.
http://reviews.llvm.org/D12363
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth updated this revision to Diff 33379.
amccarth added a comment.
Now uses llvm/Support/ConvertUTF.h instead of WinAPI WideCharToMultiByte.
http://reviews.llvm.org/D12363
Files:
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
source/Plugins/Process/Windows/MiniDump/Proc
Author: amccarth
Date: Fri Aug 28 09:42:03 2015
New Revision: 246302
URL: http://llvm.org/viewvc/llvm-project?rev=246302&view=rev
Log:
Differential Review: http://reviews.llvm.org/D12363
Modified:
lldb/trunk/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
lldb/trunk/source/
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Implements DoReadMemory for Windows mini dumps. The dumps can use two slightly
different methods for capturing ranges of memory, so I abstracted away the
search for a range from the ac
Author: amccarth
Date: Tue Sep 1 11:59:31 2015
New Revision: 246558
URL: http://llvm.org/viewvc/llvm-project?rev=246558&view=rev
Log:
Implement DoReadMemory for Windows mini dumps.
Differential Revision: http://reviews.llvm.org/D12507
Modified:
lldb/trunk/source/Plugins/Process/Windows/MiniD
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246558: Implement DoReadMemory for Windows mini dumps.
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D12507?vs=33644&id=33708#toc
Repository:
rL LLVM
http://reviews.llvm.o
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Allows about 10 passing tests to succeed rather than fail due to log file
juggling.
http://reviews.llvm.org/D12641
Files:
test/lldbtest.py
Index: test/lldbtest.py
==
amccarth updated this revision to Diff 34063.
amccarth added a comment.
I've put more detail in the comment.
http://reviews.llvm.org/D12641
Files:
test/lldbtest.py
Index: test/lldbtest.py
===
--- test/lldbtest.py
+++ test/lldbte
Author: amccarth
Date: Fri Sep 4 15:48:48 2015
New Revision: 246870
URL: http://llvm.org/viewvc/llvm-project?rev=246870&view=rev
Log:
Sleep-and-retry after a failure to delete a log file, which may be because
antimalware is holding the handle to the just-created file.
Differential Revision: htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246870: Sleep-and-retry after a failure to delete a log
file, which may be because… (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D12641?vs=34063&id=34071#toc
Repository:
r
amccarth added a subscriber: amccarth.
amccarth added a comment.
After applying the patch, I get three additional test case failures on Windows.
I'm trying to figure out now which ones.
Is there something specific I'm supposed to be trying, with regard to Ctrl+C
itself.
http://reviews.llvm.o
amccarth added a comment.
Ninja check-lldb works.
But...
Before the patch, there are 53 failing test suites and 71 failing test cases.
After the patch there are 54 failing test suites and 74 failing test cases.
Diffing the list of failed suites at the end of the output shows only one
differenc
201 - 300 of 339 matches
Mail list logo
