This revision was automatically updated to reflect the committed changes.
Closed by commit rL254780: Implement GetMemoryRegionInfo for mini dumps.
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D15218?vs=41898&id=41940#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: amccarth
Date: Tue Dec 8 18:29:38 2015
New Revision: 255083
URL: http://llvm.org/viewvc/llvm-project?rev=255083&view=rev
Log:
Fix DoReadMemory for Windows mini dumps.
Differential Revision: http://reviews.llvm.org/D15359
Modified:
lldb/trunk/source/Plugins/Process/Windows/MiniDump/P
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255083: Fix DoReadMemory for Windows mini dumps. (authored
by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D15359?vs=42243&id=42246#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
More mini dump tests to make sure we can see a stack with several levels and
inspect local variables.
http://reviews.llvm.org/D15435
Files:
packages/Python/lldbsuite/test/functionali
amccarth added a comment.
It's a fair question, but I wonder if it's a bit premature.
The tests are still pretty speedy. This way it's easy to change
(update/improve) the test and the code in parallel and get immediate results.
(There is a checked-in mini dump in this same directory, but that
amccarth added a comment.
Conceivably, you might want to create multiple dumps of the same inferior
stopped at different points. Having to update all these when you want to
change the inferior code becomes a more manual task.
http://reviews.llvm.org/D15435
_
amccarth added a comment.
I found the "test minimal amount" argument compelling, and I tried to do that
with a saved core file, but that doesn't work because stack unwinding depends
on debug information, which is the binary, and we don't want to check in
binaries for the inferiors.
http://rev
amccarth updated this revision to Diff 42575.
amccarth added a comment.
Moved loading of fizzbuzz mini dump to only the tests that needed it.
Moved @skipUnlessWindows to the individual tests. (I'm not sure how that
worked before.)
Improved some comments.
http://reviews.llvm.org/D15435
Files
Author: amccarth
Date: Fri Dec 11 16:27:57 2015
New Revision: 255379
URL: http://llvm.org/viewvc/llvm-project?rev=255379&view=rev
Log:
Add some tests for stack and local variable inspection for mini dumps.
Differential Revision: http://reviews.llvm.org/D15435
Added:
lldb/trunk/packages/Pyth
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255379: Add some tests for stack and local variable
inspection for mini dumps. (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D15435?vs=42575&id=42585#toc
Repository:
rL LLV
amccarth created this revision.
amccarth added a reviewer: tfiala.
amccarth added a subscriber: lldb-commits.
Herald added a subscriber: aemerson.
32-bit Windows calling conventions, by default, don't pass arguments in
registers, but this test expects at least one of them to be.
By adding __attr
Author: amccarth
Date: Tue Apr 26 17:25:40 2016
New Revision: 267616
URL: http://llvm.org/viewvc/llvm-project?rev=267616&view=rev
Log:
Fix TestRegisterVariables.py on Windows
Use __attribute__((regparm(x))) to ensure the compiler enregisters at least
some arguments when calling functions.
Diffe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267616: Fix TestRegisterVariables.py on Windows (authored by
amccarth).
Changed prior to commit:
http://reviews.llvm.org/D19548?vs=55050&id=55112#toc
Repository:
rL LLVM
http://reviews.llvm.org/D195
amccarth created this revision.
amccarth added a reviewer: spyffe.
amccarth added a subscriber: lldb-commits.
1. Fixed semicolon placement in the lambda in the test itself.
2. Fixed lldbinline tests in general so that we don't attempt tests on
platforms that don't use the given type of debug i
amccarth created this revision.
amccarth added a reviewer: spyffe.
amccarth added a subscriber: lldb-commits.
Test relies on a POSIX-only function `getpid()`, so the expression on Windows
gets an undefined symbol. If you substitute `_getpid()`, the interpreter
complains that it uses an opcode i
Author: amccarth
Date: Wed Apr 27 16:53:19 2016
New Revision: 267800
URL: http://llvm.org/viewvc/llvm-project?rev=267800&view=rev
Log:
XFail TestIRInterpreter on Windows
There's an open bug with calling functions in the inferior. And Windows
doesn't have the POSIX function getpid().
Differenti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267800: XFail TestIRInterpreter on Windows (authored by
amccarth).
Changed prior to commit:
http://reviews.llvm.org/D19626?vs=55326&id=55333#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19626
F
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267931: Used llvm_unreached to quite a VC++ compiler
warning. (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D19489?vs=54882&id=55475#toc
Repository:
rL LLVM
http://reviews
Author: amccarth
Date: Thu Apr 28 15:14:44 2016
New Revision: 267931
URL: http://llvm.org/viewvc/llvm-project?rev=267931&view=rev
Log:
Used llvm_unreached to quite a VC++ compiler warning.
Differential Revision: http://reviews.llvm.org/D19489
Modified:
lldb/trunk/source/Expression/Diagnostic
amccarth closed this revision.
amccarth added a comment.
This was submitted last month. r263122
http://reviews.llvm.org/D18017
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth added a comment.
Zach is hoping to enable tests on our Windows build bot this week, so I'd like
to land this in the next day or two if possible. If not, I can just xfail this
test on Windows and postpone the other fixes until there's more time for a
review.
Thanks.
http://reviews.l
amccarth added a subscriber: amccarth.
amccarth added a comment.
Chaoren: Did this completely fix the test for you? It's still failing for me
on Windows, but for a reason not addressed here.
Repository:
rL LLVM
http://reviews.llvm.org/D19751
_
amccarth added a comment.
The test expects `expr *f.op` to fail because f is a null pointer, but on
Windows it yields `(ops) $2 = 0`. I suspect this is a latent expression
evaluation bug exposed by the new test, as it also happens for other types of
pointers and not just pointers to enums.
R
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Dereferencing a null pointer in an `expr` "works" on Windows. I believe that's
a long-standing problem that's just been exposed by the reworking of this test
last week. The rest of th
Author: amccarth
Date: Wed May 4 18:32:35 2016
New Revision: 268573
URL: http://llvm.org/viewvc/llvm-project?rev=268573&view=rev
Log:
XFail TestLambdas.py on Windows after fixing some of the problems
1. Fixed semicolon placement in the lambda in the test itself.
2. Fixed lldbinline tests in gen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268573: XFail TestLambdas.py on Windows after fixing some of
the problems (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D19606?vs=55263&id=56221#toc
Repository:
rL LLVM
ht
Author: amccarth
Date: Wed May 4 18:33:19 2016
New Revision: 268574
URL: http://llvm.org/viewvc/llvm-project?rev=268574&view=rev
Log:
XFail TestEnumTypes.py on Windows
Differential Revision: http://reviews.llvm.org/D19943
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/enum_types
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268574: XFail TestEnumTypes.py on Windows (authored by
amccarth).
Changed prior to commit:
http://reviews.llvm.org/D19943?vs=56216&id=56222#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19943
Fi
amccarth abandoned this revision.
amccarth added a comment.
This was committed a while back.
http://reviews.llvm.org/D16237
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth abandoned this revision.
amccarth added a comment.
Already committed.
http://reviews.llvm.org/D16476
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: amccarth
Date: Thu Jun 30 15:55:50 2016
New Revision: 274277
URL: http://llvm.org/viewvc/llvm-project?rev=274277&view=rev
Log:
Fix for Windows builds.
Modified:
lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
Modified: lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
amccarth added a subscriber: amccarth.
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338
@@ -315,4 +337,3 @@
// truncated.
-error.SetErrorString("address is not in a known range");
return error;
}
I'm not clear why you d
amccarth added inline comments.
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338
@@ -315,4 +337,3 @@
// truncated.
-error.SetErrorString("address is not in a known range");
return error;
}
hhellyer wrote:
> Asking for a
amccarth accepted this revision.
amccarth added a reviewer: amccarth.
amccarth added a comment.
LGTM. Thanks!
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338
@@ -315,4 +337,3 @@
// truncated.
-error.SetErrorString("address is not in a kno
I patched it in this morning, but it doesn't compile on Windows. I was
able to make it work with a few tweaks at the top of SelectHelper.cpp:
// C Includes
#include
#if defined(_WIN32)
#define NOMINMAX
#include
#else
#include
#endif
The key bits: don't include on Windows and #define NOMINMA
amccarth added a comment.
Are we putting this code in the right place? I wouldn't expect minidump
parsing to fall under Plugins/Process.
I assume the eventual intent is to turn the Windows-specific code into a user
of your new code? I look forward to seeing that happen.
Com
amccarth added a comment.
In https://reviews.llvm.org/D23545#519675, @dvlahovski wrote:
> In https://reviews.llvm.org/D23545#516808, @amccarth wrote:
>
> > Are we putting this code in the right place? I wouldn't expect minidump
> > parsing to fall under Plugins/Process.
> >
> > I assume the eve
amccarth added a comment.
LGTM.
https://reviews.llvm.org/D23545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:21
@@ +20,3 @@
+llvm::StringRef
+lldb_private::minidump::consumeString(llvm::ArrayRef &Buffer) {
+ return llvm::StringRef(reinterpret_cast(Buffer.data()),
zturner wrote:
> Even if it's length prefixed, the logic here basically just consumes the
entire buffer, which doesn't seem right
Yes, agreed.
On Fri, Sep 9, 2016 at 5:45 PM, Zachary Turner wrote:
> Even if it's length prefixed, the logic here basically just consumes the
> entire buffer, which doesn't seem ri
That fix doesn't look complete:
for (size_t i = 0; i < column - 1 && i < src_line.length(); ++i)
`column` is an unsigned integral type, so doing subtraction from it can
lead to surprising results. It's probably best to write it as:
for (size_t i = 0; i + 1 < column && i < src_line.length();
Thanks for fixing it.
On Wed, Sep 21, 2016 at 4:20 PM, Ed Maste wrote:
> On 21 September 2016 at 21:38, Adrian McCarthy
> wrote:
> > That fix doesn't look complete:
>
> Thanks, I've applied your fix in r282119, and sorry for being hasty
> with the original change.
>
amccarth added inline comments.
Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:1
@@ +1,2 @@
+//===-- Registers_x86_64.cpp *- C++
-*-===//
+//
Should match file name.
Comment at:
amccarth added a subscriber: amccarth.
Comment at: source/Host/common/FileSpec.cpp:1317
@@ +1316,3 @@
+
+ char sep = GetPrefferedPathSeparator(m_syntax);
+ std::string result;
Function is misspelled. Should be `GetPreferredPathSeparator` (1 'f', 2 'r's),
throu
amccarth added a subscriber: amccarth.
Comment at: include/lldb/Interpreter/Args.h:154
@@ -167,3 +153,3 @@
//--
- const char **GetConstArgumentVector() const;
+ void GetArgumentVector(std::vector &args) const;
amccarth added inline comments.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:177
@@ +176,3 @@
+#define REG_VAL(x) *(reinterpret_cast(x))
+
+TEST_F(MinidumpParserTest, ConvertRegisterContext) {
`EXPECT_xxx` will check the condition and report if it
Author: amccarth
Date: Fri Sep 30 11:11:42 2016
New Revision: 282871
URL: http://llvm.org/viewvc/llvm-project?rev=282871&view=rev
Log:
Add namespace qualifiers for UTF functions that just moved.
Modified:
lldb/trunk/source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp
lldb/trunk/source/Pl
amccarth added a comment.
Just a drive by.
> Args.h:449
>//--
>// Classes that inherit from Args can see and modify these
>//--
This comment is no longer
amccarth added a comment.
I was hoping that, with your new mini dump parser, you'd be able to eliminate
the need for the Windows-specific minidump process plugin.
When I wrote the Windows mini dump plugin, I tried to isolate the Windows
API-specific bits using the pimpl idiom. Now that you've
amccarth accepted this revision.
amccarth added a comment.
lgtm
> UDPSocket.cpp:106
> +#if defined(_MSC_VER) && defined(UNICODE)
> +"getaddrinfo(%s, %s, &hints, &info) returned error %i (%S)",
> +#else
Yuck. Given that this is going to get reduced from UTF-16 to MBCS, it might be
cle
Author: amccarth
Date: Tue Dec 15 17:51:27 2015
New Revision: 255718
URL: http://llvm.org/viewvc/llvm-project?rev=255718&view=rev
Log:
Propagate socket_error exception from handle_read. Otherwise Ninja crashes.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest_channels.py
Modified:
amccarth created this revision.
amccarth added reviewers: emaste, jasonmolenda.
amccarth added a subscriber: lldb-commits.
When there were too many arguments given for the `frame select` command, the
error message wasn't particularly helpful and then lldb would try to select
frame -1, which resu
Author: amccarth
Date: Tue Dec 22 10:50:28 2015
New Revision: 256251
URL: http://llvm.org/viewvc/llvm-project?rev=256251&view=rev
Log:
Improve error handling for `frame select` command when there are too many
arguments.
Bug: https://llvm.org/bugs/show_bug.cgi?id=25847
It now gives a more speci
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Tweaks check_list_or_lambda to handle a partial match into a list of strings,
and updates the decorators to use check_list_or_lambda for architectures.
In addition to making things more
Author: amccarth
Date: Tue Dec 22 15:01:21 2015
New Revision: 256283
URL: http://llvm.org/viewvc/llvm-project?rev=256283&view=rev
Log:
Allow test decorators to use lists (and not_in(list)) for arches
Differential Revision:
https://mail.google.com/mail/u/0/?zx=w4areffgjbgg#inbox/151cb6afe6169bb0
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
No hurry on the review. This can go in next year. :-)
This required a little rejiggering of ProcessWindowsLive::RefreshStateAfterStop
in order to treat an unexpected breakpoint opcode
amccarth added a comment.
In http://reviews.llvm.org/D15834#318623, @labath wrote:
> Linux tests the same functionality in TestBuiltinTrap.py. Would it make sense
> to merge these two tests, given that the only difference is which compiler
> intrinsic is used to generate the int3 trap?
Yes, i
amccarth updated this revision to Diff 44179.
amccarth added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
I've rolled bits of TestBuiltinTrap.py into the new test and deleted the old
one.
This still works on Windows. I'm not set up to test it on Linux.
http://reviews.
amccarth added a comment.
PTAL: I've enhanced the test to do a couple extra checks that
TestBuiltinTrap.py was doing, and I've eliminated that old test.
I believe it should work on Linux as well as Windows, but I'm not set up with a
Linux machine right now. If someone could try this patch on
amccarth updated this revision to Diff 44264.
amccarth added a comment.
Restored TestBuiltinTrap.py because that's actually for something else.
Changed TestDebugbreak.py to use asm("int3") on non-Windows x86.
I've ordered a Linux box, but I don't currently have one, so I haven't been
able to tr
amccarth marked 3 inline comments as done.
amccarth added a comment.
Thanks for the Linux check Pavel.
I'm running one last check and then I'll submit and keep an eye on the
buildbots for the rest of the day.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoi
Author: amccarth
Date: Fri Jan 8 12:28:03 2016
New Revision: 257186
URL: http://llvm.org/viewvc/llvm-project?rev=257186&view=rev
Log:
Treat an embedded int3/__debugbreak() as a breakpoint on Windows, includes a
cross-platform test.
Added:
lldb/trunk/packages/Python/lldbsuite/test/functiona
Oops! Thanks for the fix. I'd tested only with clang, which seems to
apply C++ rules even with .c files.
I'm curious why I didn't see this break on any of the build bots.
Adrian.
On Fri, Jan 8, 2016 at 3:10 PM, Ying Chen via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: chying
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Under Python 3, lldb sees an extra frame on the stack, so I check that the
stack has at least the number frames we expect.
Python 3 doesn't have dict.iteritems(). I used a wrapper func
amccarth added a comment.
In http://reviews.llvm.org/D16017#322830, @zturner wrote:
> What's the extra frame? Why does Python have an effect on the number of
> frames seen by the minidump? Something seems wrong about that.
Sorry, I misspoke. It has nothing to do with the version of Python.
Author: amccarth
Date: Mon Jan 11 10:35:30 2016
New Revision: 257342
URL: http://llvm.org/viewvc/llvm-project?rev=257342&view=rev
Log:
Fix TestMiniDump.py for Python 2/3 (and for a change to debug info)
Differential Revision: http://reviews.llvm.org/D16017
Modified:
lldb/trunk/packages/Pyth
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257342: Fix TestMiniDump.py for Python 2/3 (and for a change
to debug info) (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16017?vs=44385&id=44518#toc
Repository:
rL LLVM
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
I don't know enough about SWIG to give that a thorough review.
Comment at: source/Host/windows/ProcessLauncherWindows.cpp:38
@@ +37,3 @@
+cur_entry += strlen(cur_e
Author: amccarth
Date: Thu Jan 14 16:52:16 2016
New Revision: 257829
URL: http://llvm.org/viewvc/llvm-project?rev=257829&view=rev
Log:
Fix detection of teardown hooks that are already bound.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/Python/
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Tested on Windows with Python 3.5.
http://reviews.llvm.org/D16237
Files:
packages/Python/lldbsuite/test/logging/TestLogging.py
Index: packages/Python/lldbsuite/test/logging/TestLoggi
amccarth updated this revision to Diff 45023.
amccarth added a comment.
Used the more explicit assertion methods.
http://reviews.llvm.org/D16237
Files:
packages/Python/lldbsuite/test/logging/TestLogging.py
Index: packages/Python/lldbsuite/test/logging/TestLogging.py
=
Author: amccarth
Date: Fri Jan 15 14:45:06 2016
New Revision: 257931
URL: http://llvm.org/viewvc/llvm-project?rev=257931&view=rev
Log:
Small fixes to ensure TestLogging.py tests work with Python 3.5 as well as 2.7.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/logging/TestLogging.py
Mo
amccarth added a subscriber: amccarth.
amccarth added a comment.
A GetMainThread method in SBAPI might be a nice addition to GetThreadAtIndex.
http://reviews.llvm.org/D16247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Apparently something changed with `thread step-over`, causing execution to move
outside the stack frame, and thus the local variables were no longer visible.
Since the step-over is unre
amccarth abandoned this revision.
amccarth added a comment.
Interestingly, the test_step_over_dwarf test is now getting an UNEXPECTED
SUCCESS on Windows.
The TestUnsignedTypes.py test (from which this one was apparently copied--see
the class name) doesn't have the step-over.
http://reviews.ll
amccarth added a comment.
By having tests doing too much, we get problems like this (where ~12 seemingly
unrelated tests started failing over the holiday weekend) instead of one test
that points to the root cause. (In this case, we're still looking for the root
cause of the regression. A simp
amccarth created this revision.
amccarth added reviewers: tberghammer, zturner.
amccarth added a subscriber: lldb-commits.
This fixes the nine tests that regressed on Windows after
http://reviews.llvm.org/D16186
http://reviews.llvm.org/D16415
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFile
Author: amccarth
Date: Thu Jan 21 14:58:12 2016
New Revision: 258429
URL: http://llvm.org/viewvc/llvm-project?rev=258429&view=rev
Log:
Add CalculateSymbolSizes in ObjectFilePECOFF::GetSymtab to ensure that (nearly)
all the symbols have sizes.
This fixes the `thread step-over` regression exposed
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258429: Add CalculateSymbolSizes in
ObjectFilePECOFF::GetSymtab to ensure that… (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16415?vs=45560&id=45586#toc
Repository:
rL LL
Author: amccarth
Date: Thu Jan 21 15:10:00 2016
New Revision: 258433
URL: http://llvm.org/viewvc/llvm-project?rev=258433&view=rev
Log:
NFC. Corrects name of test class and a comment.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
Modified:
lld
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
In Python 3.5, import looks only in the official packages directory unless you
tell it otherwise. I tested with Python 2.7 as well.
http://reviews.llvm.org/D16431
Files:
packages/P
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258448: Fix TestImport.py to work with Python 3.5. (authored
by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16431?vs=45600&id=45603#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: amccarth
Date: Thu Jan 21 17:07:48 2016
New Revision: 258448
URL: http://llvm.org/viewvc/llvm-project?rev=258448&view=rev
Log:
Fix TestImport.py to work with Python 3.5.
Differential Revision: http://reviews.llvm.org/D16431
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functio
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
https://llvm.org/bugs/show_bug.cgi?id=25819
http://reviews.llvm.org/D16476
Files:
packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespaceLookup.py
Index: packages/Python/lldb
Author: amccarth
Date: Fri Jan 22 17:05:47 2016
New Revision: 258578
URL: http://llvm.org/viewvc/llvm-project?rev=258578&view=rev
Log:
XFail a test from TestConditionalBreak.py on Windows.
Filed a bug to investigate later: llvm.org/pr26265
Modified:
lldb/trunk/packages/Python/lldbsuite/tes
Author: amccarth
Date: Fri Jan 22 17:05:29 2016
New Revision: 258577
URL: http://llvm.org/viewvc/llvm-project?rev=258577&view=rev
Log:
XFail TestNamespaceLookup tests on Windows.
There's already a pr: https://llvm.org/bugs/show_bug.cgi?id=25819
Modified:
lldb/trunk/packages/Python/lldbsuit
Author: amccarth
Date: Mon Jan 25 13:13:35 2016
New Revision: 258704
URL: http://llvm.org/viewvc/llvm-project?rev=258704&view=rev
Log:
Fix TestSourceManager.py on Windows.
Python 3.5 is picky about writing strings to binary files, so we now open the
file in text mode, and we explicitly set the ne
amccarth added a subscriber: amccarth.
amccarth added a comment.
This patch broke approximately 10 tests on Windows, mostly related to thread
step-over, thread step-out, etc. We probably need to fix something in
PECOFF::GetSymTab that's causing all the symbols to be rejected. I'll look
into
amccarth created this revision.
amccarth added reviewers: zturner, clayborg.
amccarth added a subscriber: lldb-commits.
This fixes the regression of several tests on Windows after rL258621.
The root problem is that ObjectFilePECOFF was not setting type information for
the symbols, and the new CL
amccarth marked 2 inline comments as done.
Comment at: include/lldb/Core/RangeMap.h:1230
@@ -1229,3 +1229,3 @@
typename Collection::const_iterator pos;
-for(pos = m_entries.begin(); pos != m_entries.end(); pos++)
+for (pos = m_entri
amccarth updated this revision to Diff 45933.
amccarth marked an inline comment as done.
amccarth added a comment.
Mostly clang-format.
http://reviews.llvm.org/D16563
Files:
include/lldb/Core/RangeMap.h
include/lldb/Symbol/Symtab.h
source/Core/Module.cpp
source/Plugins/ObjectFile/PECOFF
amccarth added inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:195
@@ -182,3 +194,3 @@
m_coff_header_opt (),
m_sect_headers ()
{
After discussion with a COFF expert, it seems wise to postpone trying to do
anything mor
Author: amccarth
Date: Mon Jan 25 18:58:09 2016
New Revision: 258758
URL: http://llvm.org/viewvc/llvm-project?rev=258758&view=rev
Log:
Set symbol types for function symbols loaded from PE/COFF
This fixes the regression of several tests on Windows after rL258621.
The root problem is that ObjectFi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258758: Set symbol types for function symbols loaded from
PE/COFF (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16563?vs=45933&id=45935#toc
Repository:
rL LLVM
http://rev
Author: amccarth
Date: Wed Jan 27 11:03:25 2016
New Revision: 258943
URL: http://llvm.org/viewvc/llvm-project?rev=258943&view=rev
Log:
XFail TestCPPAuto on Windows until we can find the root problem.
llvm.org/pr26339
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/auto/TestCPPAu
amccarth added a subscriber: amccarth.
amccarth added a comment.
I was chasing this same bug on Windows before I noticed you were working on it.
I patched in your latest diff, and the problem still occurs. In fact, now I
get two failures:
>
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
I don't understand how this works before, but this fixes the recent test
regressions on Windows in TestConsecutiveBreakpoints.py.
LLDB wasn't stopping when single-stepping onto a breakp
amccarth added a comment.
In http://reviews.llvm.org/D16825#342279, @jingham wrote:
> Yes, it has always been this way. Whenever we are about to start up the
> target - for whatever reason, we check to see if there is a breakpoint at the
> instruction where we are starting and if so we push a
Author: amccarth
Date: Tue Feb 2 17:38:08 2016
New Revision: 259605
URL: http://llvm.org/viewvc/llvm-project?rev=259605&view=rev
Log:
Set correct thread stop info when single-step lands on a breakpoint [Windows]
I don't understand how this worked before, but this fixes the recent test
regressio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259605: Set correct thread stop info when single-step lands
on a breakpoint [Windows] (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16825?vs=46702&id=46715#toc
Repository:
101 - 200 of 339 matches
Mail list logo
