[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/107906 >From 758745c955471b0ad65cd3a33381f753e2b63797 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Mon, 9 Sep 2024 15:32:09 -0400 Subject: [PATCH 1/2] Propagate IsText parameter to openFileForRead f

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

abhina-sree wrote: > https://github.com/llvm/llvm-project/blob/main/clang/lib/Lex/PPDirectives.cpp#L3964-L3990 Yes I think we still require specifying the Text/Binary parameter based on the context of where it is called. I will look into adding the new virtual functions as an alternative solu

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

abhina-sree wrote: > The default is set to OF_Text instead of OF_None, this change in value does > not affect any other platforms other than z/OS. Setting this parameter > correctly is required to open files on z/OS in the correct encoding. The > IsText parameter is based on the context of whe

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

abhina-sree wrote: Closing this because an alternative solution was implemented here https://github.com/llvm/llvm-project/pull/111723 https://github.com/llvm/llvm-project/pull/110661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/110661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

abhina-sree wrote: > > sorry this is same as #107906 (with a bigger impact radius, as you're also > > changing getBufferForFile) and doesn't address any of the issues mention > > about explaining the semantics of `IsText` or justification for changing > > the core VFS interfaces, for an operat

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

abhina-sree wrote: > OpenFlags |= sys::fs::OF_Text; Thanks, I've made your suggested change and I opened a new PR here https://github.com/llvm/llvm-project/pull/109664. A short explanation for why distinguishing text and binary files on z/OS is important is because the native encoding is not

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

@@ -323,10 +325,11 @@ ErrorOr RealFileSystem::status(const Twine &Path) { } ErrorOr> -RealFileSystem::openFileForRead(const Twine &Name) { +RealFileSystem::openFileForRead(const Twine &Name, bool IsText) { SmallString<256> RealName, Storage; Expected FDOrErr = sys::fs::

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

abhina-sree wrote: > 3b3accb Hi, sure I will revert the two changes so we can discuss further. The OF_Text flag only affects the z/OS platform behaviour, the OF_TextWithCRLF will affect z/OS and Windows. On other platforms, the flag doesn't show any difference in behaviour that I'm aware of

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

abhina-sree wrote: > thanks a lot for the swift response! > > I can see how none of these implementations are not using those flags > _today_, but we're changing the observable behavior for them as well, and if > some of those implementations decides to give meaning to these flags, it > might

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/110661 >From b4bf7c601d2b790ea5e65f68cb1fa9375457b558 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Mon, 9 Sep 2024 15:32:09 -0400 Subject: [PATCH] Propagate IsText parameter to openFileForRead funct

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

abhina-sree wrote: > > @perry-ca raised some concerns in #109664 about this functionality > > requiring some context awareness, I don't think any of those is addressed > > by this patch either. Pretty much all of the callers apart from ASTReader > > is just using `IsText = true`. > > It just

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/110661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/110661 >From 1a5096483d5d6d84087e913b20f6f260452988b3 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Mon, 9 Sep 2024 15:32:09 -0400 Subject: [PATCH] Propagate IsText parameter to openFileForRead funct

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/107906 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits