[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

2024-08-31 Thread AbdAlRahman Gad via lldb-commits
https://github.com/AbdAlRahmanGad updated https://github.com/llvm/llvm-project/pull/106831 >From aeb2b3380c4aea636812fd37c19b5ca920d98806 Mon Sep 17 00:00:00 2001 From: AbdAlRahman Gad Date: Sat, 31 Aug 2024 10:11:39 +0300 Subject: [PATCH] [lldb] Change ValueObject::AddressOf() to return Expect

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

2024-08-31 Thread AbdAlRahman Gad via lldb-commits
https://github.com/AbdAlRahmanGad ready_for_review https://github.com/llvm/llvm-project/pull/106831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

2024-08-31 Thread AbdAlRahman Gad via lldb-commits
https://github.com/AbdAlRahmanGad updated https://github.com/llvm/llvm-project/pull/106831 >From aeb2b3380c4aea636812fd37c19b5ca920d98806 Mon Sep 17 00:00:00 2001 From: AbdAlRahman Gad Date: Sat, 31 Aug 2024 10:11:39 +0300 Subject: [PATCH] [lldb] Change ValueObject::AddressOf() to return Expect

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

2024-08-31 Thread AbdAlRahman Gad via lldb-commits
AbdAlRahmanGad wrote: @adrian-prantl https://github.com/llvm/llvm-project/pull/106831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

2024-08-31 Thread AbdAlRahman Gad via lldb-commits
https://github.com/AbdAlRahmanGad created https://github.com/llvm/llvm-project/pull/106831 None >From aeb2b3380c4aea636812fd37c19b5ca920d98806 Mon Sep 17 00:00:00 2001 From: AbdAlRahman Gad Date: Sat, 31 Aug 2024 10:11:39 +0300 Subject: [PATCH] [lldb] Change ValueObject::AddressOf() to return

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

2024-09-05 Thread AbdAlRahman Gad via lldb-commits
AbdAlRahmanGad wrote: @jimingham This change was suggested by @adrian-prantl as good first issue for me. it's similar to this [Pull Request](https://github.com/llvm/llvm-project/pull/92979/). You can read the conversation here https://discourse.llvm.org/t/rich-disassembler-for-lldb/76952/14

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

2024-09-11 Thread AbdAlRahman Gad via lldb-commits
AbdAlRahmanGad wrote: re-ping since It's been more than a week @jimingham @adrian-prantl I hope I didn’t come across as too pushy or intrusive. https://github.com/llvm/llvm-project/pull/106831 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

2024-09-12 Thread AbdAlRahman Gad via lldb-commits
AbdAlRahmanGad wrote: As a new contributor, I don't have an opinion on this, but I'm more than happy to help out with additional tasks whenever needed. https://github.com/llvm/llvm-project/pull/106831 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

2024-09-12 Thread AbdAlRahman Gad via lldb-commits
AbdAlRahmanGad wrote: Could you please recommend something to me? If you don't have something specific in mind right now, should I look it up and then ask if it is suitable to work on before I begin? https://github.com/llvm/llvm-project/pull/106831 _

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-07 Thread AbdAlRahman Gad via lldb-commits
https://github.com/AbdAlRahmanGad updated https://github.com/llvm/llvm-project/pull/110718 >From b4afb0b69bc07b5df72e2db29af4bc09bcafa526 Mon Sep 17 00:00:00 2001 From: AbdAlRahman Gad Date: Tue, 1 Oct 2024 21:15:13 +0300 Subject: [PATCH 1/4] [lldb] Change SymbolContext::GetAddressRangeFromHer

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-07 Thread AbdAlRahman Gad via lldb-commits
https://github.com/AbdAlRahmanGad updated https://github.com/llvm/llvm-project/pull/110718 >From b4afb0b69bc07b5df72e2db29af4bc09bcafa526 Mon Sep 17 00:00:00 2001 From: AbdAlRahman Gad Date: Tue, 1 Oct 2024 21:15:13 +0300 Subject: [PATCH 1/5] [lldb] Change SymbolContext::GetAddressRangeFromHer

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-01 Thread AbdAlRahman Gad via lldb-commits
AbdAlRahmanGad wrote: @adrian-prantl https://github.com/llvm/llvm-project/pull/110718 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-01 Thread AbdAlRahman Gad via lldb-commits
https://github.com/AbdAlRahmanGad created https://github.com/llvm/llvm-project/pull/110718 None >From b4afb0b69bc07b5df72e2db29af4bc09bcafa526 Mon Sep 17 00:00:00 2001 From: AbdAlRahman Gad Date: Tue, 1 Oct 2024 21:15:13 +0300 Subject: [PATCH] [lldb] Change SymbolContext::GetAddressRangeFromHe

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-03 Thread AbdAlRahman Gad via lldb-commits
https://github.com/AbdAlRahmanGad updated https://github.com/llvm/llvm-project/pull/110718 >From b4afb0b69bc07b5df72e2db29af4bc09bcafa526 Mon Sep 17 00:00:00 2001 From: AbdAlRahman Gad Date: Tue, 1 Oct 2024 21:15:13 +0300 Subject: [PATCH 1/2] [lldb] Change SymbolContext::GetAddressRangeFromHer

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-03 Thread AbdAlRahman Gad via lldb-commits
https://github.com/AbdAlRahmanGad updated https://github.com/llvm/llvm-project/pull/110718 >From b4afb0b69bc07b5df72e2db29af4bc09bcafa526 Mon Sep 17 00:00:00 2001 From: AbdAlRahman Gad Date: Tue, 1 Oct 2024 21:15:13 +0300 Subject: [PATCH 1/3] [lldb] Change SymbolContext::GetAddressRangeFromHer

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-03 Thread AbdAlRahman Gad via lldb-commits
@@ -201,8 +201,8 @@ class SymbolContext { bool GetAddressRange(uint32_t scope, uint32_t range_idx, bool use_inline_block_range, AddressRange &range) const; - bool GetAddressRangeFromHereToEndLine(uint32_t end_line, AddressRange &range, -