[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

wallace added a comment. Hi @stella.stamenova, could you help fixing that one liner? I really have no way to install gcc7 on my linux machine (I don't have permission to install older gcc toolchains). I'm happy to chat with you on discord or anywhere else to get this resolved. Il giorno gio 16 gi

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. just some minor changes, including requiring the FileSpec as input to the SB function Comment at: lldb/include/lldb/API/SBDebugger.h:394-395 + /// Load trace

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice job! Comment at: lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py:139 +if self.USE_SB_API: +traceDescriptionFile = lldb.SBFil

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py:139 +if self.USE_SB_API: +traceDescriptionFile = lldb.SBFileSpec(traceDescriptionFilePath) +loadTraceError = lldb.SBError() --

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59 +Expected> IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request, ArrayRef current_tids) { - IntelPTPr

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59 +Expected> IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request, ArrayRef current_tids) { - IntelPTPr

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In order to provide simple scripting support on top of instruction traces, a simple solu

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

wallace updated this revision to Diff 438884. wallace added a comment. add a test for -a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128316/new/ https://reviews.llvm.org/D128316 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceInstructionDumper.h:46 /// state and granularity. class TraceInstructionDumper { public: jj10306 wrote: > nit: wdyt ab renaming this to `TraceIns

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

wallace updated this revision to Diff 439072. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128316/new/ https://reviews.llvm.org/D128316 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

wallace added inline comments. Comment at: lldb/source/Target/TraceInstructionDumper.cpp:193-194 + OutputWriterJSON(Stream &s, const TraceInstructionDumperOptions &options) + : m_s(s), m_options(options), m_j(/*IndentSize=*/m_s.AsRawOstream(), +

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

wallace added a comment. This just broke trunk. Look at this repro: #include #include void f3() { int m; m = 2; // thread 3 - line 6 } void f2() { int n; n = 1; // thread 2 - line 11 std::thread t3(f3); t3.join(); } int main() { // main std::th

[Lldb-commits] [PATCH] D139969: Add a json dumper for call graph reconstructor

wallace added a comment. I'll take a look at this later tonight or tomorrow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139969/new/ https://reviews.llvm.org/D139969 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D147252: [lldb][NFC] Move various constructor definitions from .h to .cpp

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147252/new/ https://reviews.llvm.org/D147252 _

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace created this revision. wallace added a reviewer: rriddle. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If we want to export all lldb symbols (i.e LLDB_EXPORT_ALL_SYMBOLS=ON), we need to use de

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510550. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index: lldb/cmake/modules/AddLLDB.cm

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510551. wallace added a comment. another nit... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index: lldb/cmake/modules/

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:173 + if (LLDB_EXPORT_ALL_SYMBOLS) +if (CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU") + target_compile_options(${name} PRIVATE "-fvisibility=default") rriddle wrote: > Other places

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510557. wallace added a comment. gate the target OS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index: lldb/cmake/modu

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:175 +CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU") + target_compile_options(${name} PRIVATE "-fvisibility=default") +endif() JDevlieghere wrote: > Rather than changing the c

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510588. wallace added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index: lldb/cmake/module

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe538c6fc3048: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided. (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

wallace added a comment. wow, nice improvement. I don't have anything else to add besides what @rupprecht said Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147805/new/ https://reviews.llvm.org/D147805

[Lldb-commits] [PATCH] D149180: [LLDB][REPL] Destroy the repl instances correctly

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change ensures that the REPL map inside Target is destroyed correctly when `Target::Destroy()` is invoked. Not doing s

[Lldb-commits] [PATCH] D149180: [LLDB][REPL] Destroy the repl instances correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59a39c2fc91e: [LLDB][REPL] Destroy the repl instances correctly (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some LLDB set ups need to hide certain commands for security reasons, so I'm adding a flag that allows removing non-user co

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace updated this revision to Diff 517399. wallace added a comment. remove whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1465cd49efc: [lldb] Create a way to force remove commands (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. Sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

wallace created this revision. wallace added a reviewer: jingham. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds some tests for removing lldb commands, user command and aliases. I've done in

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. -> https://reviews.llvm.org/D149379 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. @jingham, in my use case, I'm exposing a minified LLDB client remotely, so the user won't have access to script command nor the SB API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D14

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

wallace added inline comments. Comment at: lldb/source/API/SBProcess.cpp:772 - return (event.GetBroadcasterClass() == SBProcess::GetBroadcasterClass()) && - !EventIsStructuredDataEvent(event); + return Process::ProcessEventData::GetEventDataFromEvent(event.get()) != +

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm! Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1983 + g_vsc.debugger.SetAsync(true); + LaunchProcess(*g_vsc.last_launch_or_attach_request); + j

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace created this revision. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. Herald added a project: All. wallace requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Modular just announced a new lan

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:493 eLanguageTypeAda2012 = 0x002f, + eLanguageTypeMojo = 0x0030, aprantl wrote: > bulbazord wrote: > > These values correspond to DWARF5's official language codes and `0x0030`

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `StartEventHandlerThread` and `StopEventHandlerThread` are available to the SwiftREPL even though they are protected becaus

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. REPL implementations don't have an easy way to know that an expression has been evaluated, so I'm adding a simple function

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace added inline comments. Comment at: lldb/include/lldb/Expression/REPL.h:115-120 + virtual void + OnExpressionEvaluated(const ExecutionContext &exe_ctx, llvm::StringRef code, +const EvaluateExpressionOptions &expr_options, +

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:503-504 + /// Manually start the global event handler thread. It should be used by + /// programs that use LLDB as a library. + bool StartEventHandlerThread(); bulbazord wrote: > Th

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace updated this revision to Diff 519141. wallace added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149717/new/ https://reviews.llvm.org/D149717 Files: lldb/include/lldb/Core/Debugger.h Index: lldb/include/lldb

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace updated this revision to Diff 519163. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149719/new/ https://reviews.llvm.org/D149719 Files: lldb/include/lldb/Expression/REPL.h lldb/source/Expressio

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace added a comment. In D149702#4316747 , @aprantl wrote: > You can also use a constant in the Vendor extension space, which might be > more appropriate until the languages sees adoption by a wider audience. That sounds like a better idea. Thanks! I

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace updated this revision to Diff 519338. wallace added a comment. add the language as a vendor extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149702/new/ https://reviews.llvm.org/D149702 Files: lldb/docs/python_api_enums.rst lldb

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace updated this revision to Diff 519542. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149717/new/ https://reviews.llvm.org/D149717 Files: lldb/include/lldb/Core/Debugger.h Index: lldb/include/lld

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace added inline comments. Comment at: lldb/include/lldb/Expression/REPL.h:124 +const lldb::ValueObjectSP &result_valobj_sp, +const Status &error) { +return llvm::Error::success(); bulbazord wrote: > Do you

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb7c99f3aea: [LLDB] Add a hook to notify REPLs that an expression was evaluated (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149719/

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb5f745a2bfc: [lldb] Make some functions useful to REPLs public (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149717/new/ https://rev

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

wallace added a comment. The alias still works because it still holds a reference to it. I could add that as a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149379/new/ https://reviews.llvm.org/D149379 ___

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This simple diff declares some enum values needed to create a REPL for the mojo language. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150470/new/ https://reviews.llvm.org/D150470 __

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace updated this revision to Diff 524398. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 Files: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace added a comment. Sure, I can use it. I just didn't know it exists :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace updated this revision to Diff 524448. wallace added a comment. Use RTTIExtends Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 Files: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace updated this revision to Diff 524449. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 Files: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h lldb/include

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

This revision was automatically updated to reflect the committed changes. Closed by commit rGf237513cda8e: [LLDB] Add some declarations related to REPL support for mojo (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/

[Lldb-commits] [PATCH] D151501: [LLDB] Explicitly declare constructor in `PersistentExpressionState`

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Herald added subscribers: Michael137, JDevlieghere. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151501/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

wallace accepted this revision. wallace added a comment. This seems reasonable to me and I'm accepting it to unblock this feature. When Greg gets back he should be able to provide some additional comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D151962: [lldb][NFCI] Change return type of REPL::GetSourceFileBasename

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. LGTM. It also works with the mojo REPL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151962/new/ https://reviews.llvm.org/D151962 __

[Lldb-commits] [PATCH] D152326: [lldb][NFCI] DecodedThread::TraceItemStorage::error should own its own data

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152326/new/ https://reviews.llvm.org/D152326 ___

[Lldb-commits] [PATCH] D153073: [LLDB] Add DWARF definitions for the new Mojo language

wallace created this revision. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. Herald added a project: All. wallace requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. The new language Mojo recently r

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. pretty nice! Just a few nits, but other than that it's good to go Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1475 + auto cmd = g_vsc.debugger.GetCommandInterpreter

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Please write an entry about this in the documentation of lldb-vscode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/ https

[Lldb-commits] [PATCH] D153073: [LLDB] Add DWARF definitions for the new Mojo language

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG582582fb474b: [LLDB] Add DWARF definitions for the new Mojo language (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D154026: [lldb-vscode] Adjusting CreateSource to detect compiler generated frames.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. pretty nice. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154026/new/ https://reviews.llvm.org/D154026 _

[Lldb-commits] [PATCH] D154028: [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. THANKS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154028/new/ https://reviews.llvm.org/D154028 ___

[Lldb-commits] [PATCH] D154029: [lldb-vscode] Adding support for column break points.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154029/new/ https://reviews.llvm.org/D154029

[Lldb-commits] [PATCH] D109633: [lldb-vscode] Fix focus thread when previous thread exits

wallace accepted this revision. wallace added a comment. nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109633/new/ https://reviews.llvm.org/D109633 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D105998: Create synthetic symbol names on demand to improve memory consumption and startup times.

wallace closed this revision. wallace added a comment. This was commited by ec1a49170129d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105998/new/ https://reviews.llvm.org/D105

[Lldb-commits] [PATCH] D110269: Fix LLDB build on old Linux kernels

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110269/new/ https://reviews.llvm.org/D110269 _

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

wallace added inline comments. Comment at: lldb/include/lldb/Target/Process.h:241 - void BumpStopID() { -m_stop_id++; + uint32_t BumpStopID() { +const uint32_t prev_stop_id = m_stop_id++; add a comment saying that this returns the stop id with the val

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:627-628 + "incompatible with 'attachCommands'.\n", arg.str().c_str()); + } +} +// Run any pre run LLDB commands the user specified in the launch.json clay

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. looks good, does anyone else have any objections? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112279/new/ https://reviews.llvm.org/D112279

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

wallace updated this revision to Diff 381653. wallace added a comment. addressed all comments. I was able to dedup all the implementation files and the tests, and indeed passing the make flags to the build method was a good trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

wallace updated this revision to Diff 381655. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt lldb/source/Plug

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

wallace added a comment. this seems like a better solution. I like it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112279/new/ https://reviews.llvm.org/D112279 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Is it possible to add a test for that? In any case, this makes sense to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://r

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. almost there! Comment at: lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp:20 -class BitsetFrontEnd : public SyntheticChildrenFrontEnd { +// This class

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

wallace added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/bitset/TestDataFormatterGenericBitset.py:32-35 for i in range(size): child = var.GetChildAtIndex(i) self.assertEqual(child.GetVal

[Lldb-commits] [PATCH] D112501: Add new key/value pairs to the module statistics for "statistics dump".

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. looks good Comment at: lldb/include/lldb/Symbol/SymbolFile.h:309 + /// this call should add the size of all sections that contain debug + /// information. Symbols the sym

[Lldb-commits] [PATCH] D112537: Set synthetic children

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. I think you messed up when updating the diffs. I don't see the bitset diff anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. I think you messed up when updating the diffs. I don't see the bitset diff anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace added a comment. just some minor things left Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:941-942 new StringSummaryFormat(stl_summary_flags, "size=${svar%#}"))); + TypeSummaryImpl::Flags stl_set_summary_flags = stl_summary_flags;

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace added a comment. Besides, given that you are using the same python implementation for map and set, better rename the class to StdSeOrMapSynthProvider and add a comment mentioning that it works both for set and maps because they have the same underlying structure Repository: rG LLVM

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs

wallace accepted this revision. wallace added a comment. great! I'll land it for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs

wallace added a comment. Pushed upstream as 566bfbb740bb0ffef827ce983d7aa899236fcb88 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1120 +else + llvm::consumeError(expected_value.takeError()); + } err, i'm not a f

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. pretty good! Just some cosmetic changes needed and that's it Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:318 -class StdMapSynthProvider: +class StdSetO

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py:45 "[3] = 3", "[6] = 6"]) danilashtefan wrote: > wallace wrote: > > can you

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Just fix that last thing and I'll land your patch :) Thanks Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:318 -class StdMapSynthProvider: +class StdSetOrMapSynthPr

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. sounds good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112587/new/ https://reviews.llvm.org/D112587 ___

[Lldb-commits] [PATCH] D112683: Add unix signal hit counts to the target statistics.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112683/new/ https://reviews.llvm.org/D112683 ___

[Lldb-commits] [PATCH] D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. pretty good, just cosmetic changes and a comment update needed Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:915 + stl_deref_f

[Lldb-commits] [PATCH] D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. let's land https://reviews.llvm.org/D112752 first and then this one Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:915 + stl_de

[Lldb-commits] [PATCH] D112834: [lldb-vscode] Fix coredump load source mapping for first file

wallace accepted this revision. wallace added a comment. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112834/new/ https://reviews.llvm.org/D112834 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863 __

[Lldb-commits] [PATCH] D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! i'll land this now Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:321 """ -class StdSetOrMapSynthProvider: +class StdMapLikeSynthProvider:

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

wallace added a comment. @xujuntwt95329 do you have push permissions or do you need help to land this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863 ___

[Lldb-commits] [PATCH] D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. good job Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112785/new/ https://reviews.llvm.org/D112785 _

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

wallace added a comment. could you rebase this on top of the main branch? I tried to 'arc patch' it locally and there are a few merge issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863 _

<    1   2   3   4   5   6   7   8   9   10   >