[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread via lldb-commits
https://github.com/serby2000 updated https://github.com/llvm/llvm-project/pull/108948 >From 30e1a6fdc39f637095eec89584f6b163bc53037d Mon Sep 17 00:00:00 2001 From: Serby Date: Tue, 17 Sep 2024 12:19:36 +0300 Subject: [PATCH 1/2] vscode-lldb - Add Environment configuration for the lldb-dap proc

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-09-17 Thread via lldb-commits
cmtice wrote: > > > Is the plan to get the DIL data structures merged before the rest of the > > > patch series is up for review? I think it'd be great to see how the > > > infrastructure introduced here will be used > > > > > > There are 3 major pieces to the DIL implementation (soon to be 4

[Lldb-commits] [lldb] [lldb] add a check using an MD5 hash for whether a file needs to be installed on the remote target (PR #108996)

2024-09-17 Thread via lldb-commits
https://github.com/dlav-sc created https://github.com/llvm/llvm-project/pull/108996 Lldb documentation says that during remote debugging lldb client should check the existence of the desired executable file on the remote target and only if the file is missing copy it there. There is no such ch

[Lldb-commits] [lldb] [lldb] add a check using an MD5 hash for whether a file needs to be installed on the remote target (PR #108996)

2024-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (dlav-sc) Changes Lldb documentation says that during remote debugging lldb client should check the existence of the desired executable file on the remote target and only if the file is missing copy it there. There is no such check in

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-20 Thread via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk> Message-ID: In-Reply-To: taalhaataahir0102 wrote: Hi David! We're new to git that why there are some stupid things are done b

[Lldb-commits] [lldb] Fix command escape bug in lldb-dap (PR #72902)

2023-11-20 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/72902 https://github.com/llvm/llvm-project/pull/69238 caused breakage in VSCode debug console usage -- the user's input is always treated as commands instead of expressions (the same behavior as if empty command

[Lldb-commits] [lldb] Fix command escape bug in lldb-dap (PR #72902)

2023-11-20 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/72902 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix command escape bug in lldb-dap (PR #72902)

2023-11-20 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/72902 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix command escape bug in lldb-dap (PR #72902)

2023-11-20 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/72902 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix command escape bug in lldb-dap (PR #72902)

2023-11-20 Thread via lldb-commits
https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/72902 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix command escape bug in lldb-dap (PR #72902)

2023-11-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes https://github.com/llvm/llvm-project/pull/69238 caused breakage in VSCode debug console usage -- the user's input is always treated as commands instead of expressions (the same behavior as if empty command escap

[Lldb-commits] [lldb] Fix command escape bug in lldb-dap (PR #72902)

2023-11-20 Thread via lldb-commits
https://github.com/kusmour approved this pull request. https://github.com/llvm/llvm-project/pull/72902 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 69a5869 - [lldb][split-dwarf] implement GetSeparateDebugInfo for SymbolFileOnDemand (#71230)

2023-11-20 Thread via lldb-commits
Author: Tom Yang Date: 2023-11-20T12:17:15-08:00 New Revision: 69a5869da4906f61caf59ff021559ca7d974c5f9 URL: https://github.com/llvm/llvm-project/commit/69a5869da4906f61caf59ff021559ca7d974c5f9 DIFF: https://github.com/llvm/llvm-project/commit/69a5869da4906f61caf59ff021559ca7d974c5f9.diff LOG:

[Lldb-commits] [lldb] Fix command escape bug in lldb-dap (PR #72902)

2023-11-20 Thread via lldb-commits
jeffreytan81 wrote: > LGTM. It may be a good idea to move these APIs over to use std::optional > instead of taking a default value so we can use 'value_or' instead of having > to write logic to handle the default value through a parameter. My goal is fixing the regression in this diff. I will

[Lldb-commits] [lldb] 85ee3fc - Fix command escape bug in lldb-dap (#72902)

2023-11-20 Thread via lldb-commits
Author: jeffreytan81 Date: 2023-11-20T15:57:14-08:00 New Revision: 85ee3fc7ec15f432430ee0c73fe81f3d6382d9df URL: https://github.com/llvm/llvm-project/commit/85ee3fc7ec15f432430ee0c73fe81f3d6382d9df DIFF: https://github.com/llvm/llvm-project/commit/85ee3fc7ec15f432430ee0c73fe81f3d6382d9df.diff

[Lldb-commits] [lldb] Fix command escape bug in lldb-dap (PR #72902)

2023-11-20 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/72902 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Add support for parsing type unit entries in .debug_names. (PR #72952)

2023-11-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes This is a follow up patch after .debug_names can now emit local type unit entries when we compile with type units + DWARF5 + .debug_names. The pull request that added this functionality was: https://github.

[Lldb-commits] [lldb] [libcxx] [llvm] [clang] [compiler-rt] [libc] [clang-tools-extra] [flang] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-11-21 Thread via lldb-commits
https://github.com/jeanPerier edited https://github.com/llvm/llvm-project/pull/71222 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc] [flang] [clang-tools-extra] [compiler-rt] [llvm] [libcxx] [clang] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-11-21 Thread via lldb-commits
https://github.com/jeanPerier approved this pull request. Thanks, please add the POSIX macros to use ctime_r, and looks great otherwise. https://github.com/llvm/llvm-project/pull/71222 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [libc] [compiler-rt] [libcxx] [clang-tools-extra] [lldb] [llvm] [clang] [flang] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-11-21 Thread via lldb-commits
@@ -10,9 +10,26 @@ // extensions that will eventually be implemented in Fortran. #include "flang/Runtime/extensions.h" +#include "terminator.h" #include "flang/Runtime/command.h" #include "flang/Runtime/descriptor.h" #include "flang/Runtime/io-api.h" +#include "flang/Runtim

[Lldb-commits] [lldb] [libcxx] [clang] [clang-tools-extra] [flang] [compiler-rt] [libc] [llvm] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-11-21 Thread via lldb-commits
@@ -10,9 +10,26 @@ // extensions that will eventually be implemented in Fortran. #include "flang/Runtime/extensions.h" +#include "terminator.h" #include "flang/Runtime/command.h" #include "flang/Runtime/descriptor.h" #include "flang/Runtime/io-api.h" +#include "flang/Runtim

[Lldb-commits] [lldb] [llvm] Add support for parsing type unit entries in .debug_names. (PR #72952)

2023-11-21 Thread via lldb-commits
@@ -37,19 +37,29 @@ llvm::DenseSet DebugNamesDWARFIndex::GetUnits(const DebugNames &debug_names) { llvm::DenseSet result; for (const DebugNames::NameIndex &ni : debug_names) { -for (uint32_t cu = 0; cu < ni.getCUCount(); ++cu) +const uint32_t num_cus = ni.getCUCount

[Lldb-commits] [llvm] [lldb] Add support for parsing type unit entries in .debug_names. (PR #72952)

2023-11-21 Thread via lldb-commits
@@ -621,7 +621,10 @@ std::optional DWARFDebugNames::Entry::getCUIndex() const { if (std::optional Off = lookup(dwarf::DW_IDX_compile_unit)) return Off->getAsUnsignedConstant(); // In a per-CU index, the entries without a DW_IDX_compile_unit attribute - // implicitly r

[Lldb-commits] [lldb] [lldb][test] Remove `reason` from `unittest2.expectedFailure` usage (PR #73028)

2023-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/73028.diff 7 Files Affected: - (modified) lldb/test/API/functionalities/jitloader_gdb/TestJITLoaderGDB.py (+1-1) - (modified) lldb/test/API/

[Lldb-commits] [lldb] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-11-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes The @expectedFailureAll and @skipIf decorators will mark the test case as xfail/skip if _all_ conditions passed in match, including debug_info. * If debug_info is not one of the matching conditions, we

[Lldb-commits] [lldb] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-11-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 33277a3e80aedd1a6877524feadfbcb41a88..22bfc5878f1f96b3138a03eea4dc856948185c89 lldb/p

[Lldb-commits] [llvm] [lldb] [clang] [BOLT] Extend calculateEmittedSize for Block Size Calculation (PR #73076)

2023-11-22 Thread via lldb-commits
https://github.com/ShatianWang updated https://github.com/llvm/llvm-project/pull/73076 >From 322c9ed213a0aa674d822a01e8b809eb1be628a5 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 1 Jun 2021 11:37:41 -0700 Subject: [PATCH 1/3] Rebase: [Facebook] Add clang driver options to test debug i

[Lldb-commits] [llvm] [lldb] [clang] [BOLT] Extend calculateEmittedSize for Block Size Calculation (PR #73076)

2023-11-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-mc @llvm/pr-subscribers-lldb Author: ShatianWang (ShatianWang) Changes This commit modifies BinaryContext::calculateEmittedSize to update the BinaryBasicBlock::OutputAddressRange for each basic block in the input BF. Th

[Lldb-commits] [llvm] [lldb] [clang] [BOLT] Extend calculateEmittedSize for Block Size Calculation (PR #73076)

2023-11-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r e07fec10ac208c2868a24c5c0be88e45778b297e..98e1f4c3b15f677e5dbfa85dace75e4c092bb99f cross-

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-22 Thread via lldb-commits
https://github.com/taalhaataahir0102 edited https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-22 Thread via lldb-commits
https://github.com/taalhaataahir0102 ready_for_review https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-22 Thread via lldb-commits
taalhaataahir0102 wrote: Hi @DavidSpickett ! Sorry for the delay. We've done the required changes and believe that it's ready for review https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] [lldb] correct inconsistent order of messages on process launch (PR #73173)

2023-11-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: José Lira Junior (junior-jl) Changes ## Overview This pull request addresses the issue [#68035](https://github.com/llvm/llvm-project/issues/68035), where an inconsistency in the order of "Process launched" and "Process stopped" messages o

[Lldb-commits] [lldb] [llvm] Add support for parsing type unit entries in .debug_names. (PR #72952)

2023-11-22 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. Do we want to add a test with duplicate type names? Otherwise, LGTM. https://github.com/llvm/llvm-project/pull/72952 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-23 Thread via lldb-commits
https://github.com/taalhaataahir0102 edited https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-24 Thread via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk> Message-ID: In-Reply-To: https://github.com/taalhaataahir0102 updated https://github.com/llvm/llvm-project/pull/69422 >From

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-24 Thread via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: https://github.com/taalhaataahir0102 updated https://github.com/llvm/llvm-project/pull/69422 >From 2c23aaf231beef11d3e0db6506fe82323a0be6a0 M

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-24 Thread via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk> Message-ID: In-Reply-To: https://github.com/taalhaataahir0102 updated https://github.com/llvm/llvm-project/pull/69422 >From

[Lldb-commits] [lldb] [LLDB] Respect the DW_AT_alignment attribute. (PR #73307)

2023-11-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Haojian Wu (hokein) Changes Part of fixes for #72913. clang emits `DW_AT_alignment` attribute, however LLDB didn't respect it, resulting in incorrect RecordDecls built by lldb. This only fixes non-inheritance cases. The inheritance case w

[Lldb-commits] [lldb] [LLDB] Respect the DW_AT_alignment attribute. (PR #73307)

2023-11-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6b87d84ff45d03c244e7511fba9359776ce27977 5fb8fd532fe767feb2d361f9552ff31ea7770663 --

[Lldb-commits] [lldb] [lldb] Improve error message for script commands when there's no inte… (PR #73321)

2023-11-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes …rpreter It was: ``` error: there is no embedded script interpreter in this mode. ``` 1. What does "mode" mean? 2. It implies there might be an embedded script interpreter for some other "mode", what

[Lldb-commits] [lldb] bd8f106 - [lldb] correct inconsistent order of messages on process launch (#73173)

2023-11-24 Thread via lldb-commits
Author: José Lira Junior Date: 2023-11-24T15:48:16Z New Revision: bd8f1068cad06b0f0342ac7ef351bf01c2e27322 URL: https://github.com/llvm/llvm-project/commit/bd8f1068cad06b0f0342ac7ef351bf01c2e27322 DIFF: https://github.com/llvm/llvm-project/commit/bd8f1068cad06b0f0342ac7ef351bf01c2e27322.diff L

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (PR #73393)

2023-11-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Xu Jun (xujuntwt95329) Changes The `column` field is mandatory in StackTraceResponse, otherwise the debugger client may raise error (e.g. VSCode can't correctly open an editor without the column field) --- Full diff: https://github.com/l

[Lldb-commits] [libc] [llvm] [flang] [lld] [libcxx] [lldb] [libcxxabi] [clang] [flang] Pass Argv0 to getIntriniscDir and getOpenMPHeadersDir (PR #73254)

2023-11-25 Thread via lldb-commits
https://github.com/madanial0 updated https://github.com/llvm/llvm-project/pull/73254 >From 81d1e05dd084dd5bb88dab88d2f23008b8dc6cfb Mon Sep 17 00:00:00 2001 From: Mark Danial Date: Tue, 21 Nov 2023 12:18:40 -0500 Subject: [PATCH] Pass the correct path to getIntriniscDir and getOpenMPHeadersDir

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class. (PR #73467)

2023-11-26 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/73467 This adds 23 new helper functions to LLDB's CompilerType class, things like IsSmartPtrType, IsPromotableIntegerType, GetNumberofNonEmptyBaseClasses, and GetTemplateArgumentType (to name a few). These helper func

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class. (PR #73467)

2023-11-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes This adds 23 new helper functions to LLDB's CompilerType class, things like IsSmartPtrType, IsPromotableIntegerType, GetNumberofNonEmptyBaseClasses, and GetTemplateArgumentType (to name a few). These helper functions

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class. (PR #73467)

2023-11-26 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a369a5946f99254d56455f3deb0031199562c1dd 70957429780c31c8981198967af254a4232ad3bc --

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class. (PR #73467)

2023-11-26 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/73467 >From 70957429780c31c8981198967af254a4232ad3bc Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 26 Nov 2023 16:14:46 -0800 Subject: [PATCH 1/2] [LLDB] Add more helper functions to CompilerType class. This

[Lldb-commits] [lldb] 42d669f - [LLDB] Add more helper functions to CompilerType class. (#73467)

2023-11-26 Thread via lldb-commits
Author: cmtice Date: 2023-11-26T16:37:39-08:00 New Revision: 42d669f82c4db6abd6f39e1d89e4e62872c4e0a8 URL: https://github.com/llvm/llvm-project/commit/42d669f82c4db6abd6f39e1d89e4e62872c4e0a8 DIFF: https://github.com/llvm/llvm-project/commit/42d669f82c4db6abd6f39e1d89e4e62872c4e0a8.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class. (PR #73467)

2023-11-26 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/73467 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB] Add more helper functions to CompilerType class." (PR #73470)

2023-11-26 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/73470 Reverts llvm/llvm-project#73467 Merged the commit by accident! >From d4cddc1a596b60c128996c8f96f63af6fb21506a Mon Sep 17 00:00:00 2001 From: cmtice Date: Sun, 26 Nov 2023 16:37:50 -0800 Subject: [PATCH] Revert "

[Lldb-commits] [lldb] Revert "[LLDB] Add more helper functions to CompilerType class." (PR #73470)

2023-11-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes Reverts llvm/llvm-project#73467 Merged the commit by accident! --- Full diff: https://github.com/llvm/llvm-project/pull/73470.diff 2 Files Affected: - (modified) lldb/include/lldb/Symbol/CompilerType.h (+5-51) - (

[Lldb-commits] [lldb] Revert "[LLDB] Add more helper functions to CompilerType class." (PR #73470)

2023-11-26 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 42d669f82c4db6abd6f39e1d89e4e62872c4e0a8 d4cddc1a596b60c128996c8f96f63af6fb21506a --

[Lldb-commits] [lldb] Revert "[LLDB] Add more helper functions to CompilerType class." (PR #73470)

2023-11-26 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/73470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB] Add more helper functions to CompilerType class." (PR #73470)

2023-11-26 Thread via lldb-commits
cmtice wrote: Can't commit this revert because of the clang format errors. Reverted manually instead. https://github.com/llvm/llvm-project/pull/73470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class. (PR #73467)

2023-11-26 Thread via lldb-commits
cmtice wrote: I accidentally committed this PR. I could not revert using github pull requests, due to clang format errors. So I reverted it manually. (See git hash af3c5a7cf1e008a467eb3104424ed122b533d7b3). Is there any way to re-open this PR for reviews, or do I need to start all over again

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-26 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/73472 This adds 23 new helper functions to LLDB's CompilerType class, things like IsSmartPtrType, IsPromotableIntegerType, GetNumberofNonEmptyBaseClasses, and GetTemplateArgumentType (to name a few). It also has run cl

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes This adds 23 new helper functions to LLDB's CompilerType class, things like IsSmartPtrType, IsPromotableIntegerType, GetNumberofNonEmptyBaseClasses, and GetTemplateArgumentType (to name a few). It also has run clang-f

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class. (PR #73467)

2023-11-26 Thread via lldb-commits
cmtice wrote: Never mind; I'll just create a new pull request. See https://github.com/llvm/llvm-project/pull/73472. https://github.com/llvm/llvm-project/pull/73467 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-27 Thread via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk> Message-ID: In-Reply-To: taalhaataahir0102 wrote: Hi! This is how the implemented version looks like: ![image](https://gith

[Lldb-commits] [lldb] 8167934 - [lldb] Improve error message for script commands when there's no interpreter (#73321)

2023-11-27 Thread via lldb-commits
Author: David Spickett Date: 2023-11-27T09:10:39Z New Revision: 8167934480a7b6a8e122aa6233aa8ed2e2683d6a URL: https://github.com/llvm/llvm-project/commit/8167934480a7b6a8e122aa6233aa8ed2e2683d6a DIFF: https://github.com/llvm/llvm-project/commit/8167934480a7b6a8e122aa6233aa8ed2e2683d6a.diff LOG

[Lldb-commits] [libcxxabi] [llvm] [lldb] [clang] [flang] [clang-tools-extra] [libc] [lld] [libcxx] [flang] Pass Argv0 to getIntriniscDir and getOpenMPHeadersDir (PR #73254)

2023-11-27 Thread via lldb-commits
https://github.com/madanial0 updated https://github.com/llvm/llvm-project/pull/73254 >From 81d1e05dd084dd5bb88dab88d2f23008b8dc6cfb Mon Sep 17 00:00:00 2001 From: Mark Danial Date: Tue, 21 Nov 2023 12:18:40 -0500 Subject: [PATCH] Pass the correct path to getIntriniscDir and getOpenMPHeadersDir

[Lldb-commits] [libcxxabi] [llvm] [clang] [libcxx] [mlir] [openmp] [lldb] [lld] [libc] [flang] [BOLT] Use deterministic xxh3 for computing BF/BB hashes (PR #72542)

2023-11-27 Thread via lldb-commits
https://github.com/spupyrev updated https://github.com/llvm/llvm-project/pull/72542 error: too big or took too long to generate ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] DRAFT - Remove 2nd "error: " and print caret (^) below last input line from the developer. (PR #72150)

2023-11-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a0a1ff3ab40e347589b4e27d8fd350c600526735 047413349901684411fb260a49c996633b7b4dc0 --

[Lldb-commits] [libcxxabi] [clang-tools-extra] [lldb] [llvm] [libc] [clang] [flang] [lld] [libcxx] [flang] Pass Argv0 to getIntriniscDir and getOpenMPHeadersDir (PR #73254)

2023-11-27 Thread via lldb-commits
madanial0 wrote: > I see you re-based 2 times. Does this look Ok as is? It would be good to add > the AIX Driver bits once this goes in. This should be good as is pending any review comments/approvals https://github.com/llvm/llvm-project/pull/73254 _

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-11-27 Thread via lldb-commits
dyung wrote: > Seems that it caused #73580 no? I believe so. @jasonmolenda I see you attempted to make a fix in a0a1ff3ab40e347589b4e27d8fd350c600526735, however I still have two buildbots that are failing to build. Can you either fix it or revert if you need time to investigate? https://lab

[Lldb-commits] [lldb] Add option to pass thread ID to thread select command (PR #73596)

2023-11-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Christensen (mdko) Changes We'd like a way to select the current thread by its thread ID (rather than its internal LLDB thread index). This PR adds a `-t` option (`--thread_id` long option) that tells the `thread select` command t

[Lldb-commits] [lldb] Add option to pass thread ID to thread select command (PR #73596)

2023-11-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 67268da61aa2f8b24172907ee6f8d9250ee18b65 97a6e23c85457a14c91c5800fa03bb872e6f1fa6 --

[Lldb-commits] [lldb] Add option to pass thread ID to thread select command (PR #73596)

2023-11-27 Thread via lldb-commits
jimingham wrote: I would prefer you make the `-t` an option with a value, rather than a flag saying what the argument means. It makes the completer much easier to hook up since the option value can complete against the native thread ID's, and the argument complete against thread indexes. You

[Lldb-commits] [lldb] [lldb][progress] Always report progress upon Progress object destruction (PR #73605)

2023-11-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes This commit allows a final progress report upon the destruction of the `Progress` object to happen at all times as opposed to when the progress was not completed. --- Full diff: https://github.com

[Lldb-commits] [lldb] 439b16e - [LLDB] Respect the DW_AT_alignment attribute. (#73307)

2023-11-28 Thread via lldb-commits
Author: Haojian Wu Date: 2023-11-28T12:27:55+01:00 New Revision: 439b16e2b369a0e3d482597b2c6597ce187e65f9 URL: https://github.com/llvm/llvm-project/commit/439b16e2b369a0e3d482597b2c6597ce187e65f9 DIFF: https://github.com/llvm/llvm-project/commit/439b16e2b369a0e3d482597b2c6597ce187e65f9.diff LO

[Lldb-commits] [libc] [compiler-rt] [clang] [libcxx] [llvm] [lldb] [flang] [clang-tools-extra] ✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy) (PR #68620)

2023-11-28 Thread via lldb-commits
cor3ntin wrote: > So it's not so much that it's not actually true in the implementation > details, it's that it's not actually true by specification either. +1. I really do not want `-E` to start not expanding, or transforming directives. I do not see a difference between a large embed and a l

[Lldb-commits] [lld] [lldb] [clang] [mlir] [compiler-rt] [clang-tools-extra] [llvm] [libcxx] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-11-28 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 1/6] [libc++] Implement ranges::contains_subrange --- libcxx/i

[Lldb-commits] [lld] [lldb] [clang] [mlir] [compiler-rt] [clang-tools-extra] [llvm] [libcxx] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-11-28 Thread via lldb-commits
ZijunZhaoCCK wrote: > Gentle ping. There's outstanding feedback to address on this review. > @ZijunZhaoCCK if you don't think you'll have time to pursue this PR anymore, > it's all good but please let us know so we can assign it to someone else! Sorry for the late reply! I can’t make it a prio

[Lldb-commits] [lldb] Add option to pass thread ID to thread select command (PR #73596)

2023-11-28 Thread via lldb-commits
jimingham wrote: lldb doesn't have a notion of arguments actually being the value of a default option. I'm not sure I like that idea, it seems like it could quickly become confusing. lldb does have the notion of "groups of options" that work together for a given command. You can specify `

[Lldb-commits] [lldb] c846f8b - [lldb][progress] Always report progress upon Progress object destruction (#73605)

2023-11-28 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2023-11-28T10:45:02-08:00 New Revision: c846f8ba104f18053ce666de7e2da0a82deb45cd URL: https://github.com/llvm/llvm-project/commit/c846f8ba104f18053ce666de7e2da0a82deb45cd DIFF: https://github.com/llvm/llvm-project/commit/c846f8ba104f18053ce666de7e2da0a82deb45cd.d

[Lldb-commits] [lldb] 3661eb1 - Add support for parsing type unit entries in .debug_names. (#72952)

2023-11-28 Thread via lldb-commits
Author: Greg Clayton Date: 2023-11-28T13:56:45-08:00 New Revision: 3661eb150e6d4e1e06adb8a62c4b45b056f3c8be URL: https://github.com/llvm/llvm-project/commit/3661eb150e6d4e1e06adb8a62c4b45b056f3c8be DIFF: https://github.com/llvm/llvm-project/commit/3661eb150e6d4e1e06adb8a62c4b45b056f3c8be.diff

[Lldb-commits] [lldb] [lldb][test] TestConstStaticIntegralMember: relax assertion on number of global variables (PR #73707)

2023-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes In https://github.com/llvm/llvm-project/pull/73626 we started attaching `DW_AT_const_value`s on a static data-member's declaration again. In DWARFv5, those static members are represented with a `DW_TAG_var

[Lldb-commits] [lldb] Add option to pass thread ID to thread select command (PR #73596)

2023-11-28 Thread via lldb-commits
@@ -1117,6 +1117,11 @@ let Command = "thread plan list" in { Desc<"Display thread plans for unreported threads">; } +let Command = "thread select" in { + def thread_thread_id : Option<"thread_id", "t">, jimingham wrote: I don't know about the underlying

[Lldb-commits] [libcxx] [clang-tools-extra] [libc] [flang] [lld] [compiler-rt] [llvm] [libunwind] [mlir] [clang] [libcxxabi] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-11-28 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/17] [libc++] Implement ranges::contains Differential Revision

[Lldb-commits] [lldb] 4eb4211 - [lldb][test] TestConstStaticIntegralMember: relax assertion on number of global variables (#73707)

2023-11-28 Thread via lldb-commits
Author: Michael Buch Date: 2023-11-28T17:04:19-08:00 New Revision: 4eb421192479dbecae2621b868e55aaf6d945b02 URL: https://github.com/llvm/llvm-project/commit/4eb421192479dbecae2621b868e55aaf6d945b02 DIFF: https://github.com/llvm/llvm-project/commit/4eb421192479dbecae2621b868e55aaf6d945b02.diff

[Lldb-commits] [lldb] Allow lldb to load .dwp files with large .debug_info or .debug_types. (PR #73736)

2023-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes A previous patch to llvm allowed the DWARFUnitIndex class to handle .debug_info.dwo and .debug_types.dwo sections to go over 4GB by checking for this case and fixing up the DWARFUnitIndex. LLDB's DWARF parse

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-28 Thread via lldb-commits
@@ -436,8 +482,8 @@ class CompilerType { ExecutionContextScope *exe_scope); /// Dump to stdout. - void DumpTypeDescription(lldb::DescriptionLevel level = - lldb::eDescriptionLevelFull) const; cmtice wrote: Per

[Lldb-commits] [lldb] 3d7e6db - [lldb][test] Remove `reason` from `unittest2.expectedFailure` usage (#73028)

2023-11-28 Thread via lldb-commits
Author: Jordan Rupprecht Date: 2023-11-28T23:36:05-06:00 New Revision: 3d7e6db12072c26c7ad42c2c473d1dc321725db4 URL: https://github.com/llvm/llvm-project/commit/3d7e6db12072c26c7ad42c2c473d1dc321725db4 DIFF: https://github.com/llvm/llvm-project/commit/3d7e6db12072c26c7ad42c2c473d1dc321725db4.di

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-28 Thread via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: taalhaataahir0102 wrote: Hi @reviewers. Did you got the chance to look at the code and is there any feedback 🙂 https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-29 Thread via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk> Message-ID: In-Reply-To: https://github.com/taalhaataahir0102 updated https://github.com/llvm/llvm-project/pull/69422 >From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=2

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-29 Thread via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk> Message-ID: In-Reply-To: @@ -1618,12 +1621,15 @@ static uint32_t LookupSymbolInModule(CommandInterpreter &interpreter, if (symbol->ValueIsAddress()) { DumpAddress( interpret

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-29 Thread via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk> Message-ID: In-Reply-To: @@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) { return bytes_written; } +void Stream::PutCStringColorHighlighted(llvm::StringRef text, +

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

2023-11-29 Thread via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk> Message-ID: In-Reply-To: https://github.com/taalhaataahir0102 edited https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-29 Thread via lldb-commits
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const { return false; } +bool CompilerType::IsSmartPtrType() const { + // These regular expressions cover shared, unique and weak pointers both from + // stdlibc++ and libc+++. + + static llvm::Regex k_libcxx_std_u

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-29 Thread via lldb-commits
@@ -436,8 +482,8 @@ class CompilerType { ExecutionContextScope *exe_scope); /// Dump to stdout. - void DumpTypeDescription(lldb::DescriptionLevel level = - lldb::eDescriptionLevelFull) const; cmtice wrote: Dav

[Lldb-commits] [lldb] Do not land, just testing the formatting job! (PR #73811)

2023-11-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/73811.diff 1 Files Affected: - (modified) lldb/source/Utility/Scalar.cpp (+1-1) ``diff diff --git a/lldb/source/Utility/Scalar.cp

[Lldb-commits] [lldb] Do not land, just testing the formatting job! (PR #73811)

2023-11-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 953d675c42c254676ca446951bd728abefecf436 27e279c17fb7747f252b4eca58e3dd1d44845191 --

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-29 Thread via lldb-commits
@@ -436,8 +482,8 @@ class CompilerType { ExecutionContextScope *exe_scope); /// Dump to stdout. - void DumpTypeDescription(lldb::DescriptionLevel level = - lldb::eDescriptionLevelFull) const; cmtice wrote: Que

[Lldb-commits] [lldb] Add option to pass thread ID to thread select command (PR #73596)

2023-11-29 Thread via lldb-commits
https://github.com/jimingham approved this pull request. This is great. Thanks for adding the thread ID completer as well! https://github.com/llvm/llvm-project/pull/73596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Remove redundant parameter to AddMethodToObjCObjectType (PR #73832)

2023-11-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This parameter isn't used (neither in upstream LLVM nor in the Apple fork). This patch removes it. This parameter seems to have been unused since its introduction in `0f581665b768d100eece196e59b00eb16

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Make ParsedDWARFTypeAttributes parameter const (PR #73833)

2023-11-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This will make future refactorings of `ParseSubroutine` simpler. Depends on https://github.com/llvm/llvm-project/pull/73832 --- Full diff: https://github.com/llvm/llvm-project/pull/73833.diff 2 Files Aff

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-29 Thread via lldb-commits
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const { return false; } +bool CompilerType::IsSmartPtrType() const { + // These regular expressions cover shared, unique and weak pointers both from + // stdlibc++ and libc+++. + + static llvm::Regex k_libcxx_std_u

[Lldb-commits] [lldb] ce00133 - Allow lldb to load .dwp files with large .debug_info or .debug_types. (#73736)

2023-11-29 Thread via lldb-commits
Author: Greg Clayton Date: 2023-11-29T11:19:50-08:00 New Revision: ce00133e5f5b243b320d55f7e57a3f8ad2c9 URL: https://github.com/llvm/llvm-project/commit/ce00133e5f5b243b320d55f7e57a3f8ad2c9 DIFF: https://github.com/llvm/llvm-project/commit/ce00133e5f5b243b320d55f7e57a3f8ad2c9.diff

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-29 Thread via lldb-commits
@@ -194,6 +192,54 @@ class CompilerType { bool IsTypedefType() const; bool IsVoidType() const; + + bool IsSmartPtrType() const; + + bool IsInteger() const; + + bool IsFloat() const; + + bool IsEnumerationType() const; + + bool IsUnscopedEnumerationType() const; + + b

<    19   20   21   22   23   24   25   26   27   28   >