[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) { static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response, uint64_t fail_result, Status &error) { + // The packet is expected to have the following

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Recently in #107731 this change was revereted due to excess memory size in `TestSkinnyCore`. This was due to a bug where a range's end was being passed as size. Creating massive memory ranges. Additionally,

[Lldb-commits] [lldb] [lldb] Fix some tests that fail with system libstdc++ (PR #106885)

llvmbot wrote: /pull-request llvm/llvm-project#107938 https://github.com/llvm/llvm-project/pull/106885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

https://github.com/jeffreytan81 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4926835 - [LLDB][Minidump] Support minidumps where there are multiple exception streams (#97470)

Author: Jacob Lalonde Date: 2024-09-09T21:07:12-07:00 New Revision: 492683527eda7ef055660842d9a6b7e2575ae208 URL: https://github.com/llvm/llvm-project/commit/492683527eda7ef055660842d9a6b7e2575ae208 DIFF: https://github.com/llvm/llvm-project/commit/492683527eda7ef055660842d9a6b7e2575ae208.diff

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Print a warning when the debugger detects a mismatch between the MD5 checksum in the DWARF 5 line table and the file on disk. The warning is printed only once per file. --- Full diff: https://githu

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

dlav-sc wrote: I've added float, doubles and pointers support in lldb expressions. Currently, just several python API tests that check expressions with static class members (BTW, static methods work) and complex expressions like `expr struct Test { int a; int b; }; auto t = Test{3, 4}; t;` fai

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -0,0 +1,96 @@ +""" +Test RISC-V expressions evaluation. +""" dlav-sc wrote: If I'm not mistaken, I've supported all types that frontend can generate (https://github.com/llvm/llvm-project/pull/99336#issuecomment-2340245433), so these tests are no longer relev

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dhruv Srivastava (DhruvSrivastavaX) Changes This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. #101657 The complete changes for po

[Lldb-commits] [lldb] 925b220 - [lldb] Recurse through DW_AT_signature when looking for attributes (#107241)

Author: Pavel Labath Date: 2024-09-10T12:57:54+02:00 New Revision: 925b220ee424f8489bc8d7b1a247f2c5f3edde5d URL: https://github.com/llvm/llvm-project/commit/925b220ee424f8489bc8d7b1a247f2c5f3edde5d DIFF: https://github.com/llvm/llvm-project/commit/925b220ee424f8489bc8d7b1a247f2c5f3edde5d.diff

[Lldb-commits] [lldb] [lldb][test] TestDbgInfoContentVectorFromStdModule.py: skip test on Darwin (PR #108003)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This started failing on the macOS CI after https://github.com/llvm/llvm-project/pull/106885: ``` lldb-api :: commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStd

[Lldb-commits] [lldb] [lldb][test] TestDbgInfoContentVectorFromStdModule.py: skip test on Darwin (PR #108003)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 925b220ee424f8489bc8d7b1a247f2c5f3edde5d...cbc5d1316b5103a109bce905976fb9d5d937b330 lldb

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -0,0 +1,62 @@ +//===--- DirectCallReplacementPass.h - RISC-V specific pass ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -1441,6 +1443,26 @@ lldb_private::Status ClangExpressionParser::DoPrepareForExecution( custom_passes.EarlyPasses->run(*llvm_module_up); } + std::unique_ptr arch_passes(nullptr); dlav-sc wrote: addressed https://github.com/llvm/llvm-project/pull/99

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -1441,6 +1443,26 @@ lldb_private::Status ClangExpressionParser::DoPrepareForExecution( custom_passes.EarlyPasses->run(*llvm_module_up); } + std::unique_ptr arch_passes(nullptr); + if (lldb::TargetSP target_sp = exe_ctx.GetTargetSP()) { +Architecture *arch = tar

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -0,0 +1,217 @@ +//===--- DirectCallReplacementPass.cpp - RISC-V specific pass -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

dlav-sc wrote: Also Large Code Model for RISCV targets has been merged 2 days ago (https://github.com/llvm/llvm-project/pull/70308), so I'm going to remove DirectCallReplacementPass and use large model in MCJIT instead. https://github.com/llvm/llvm-project/pull/99336 __

[Lldb-commits] [lldb] 2bcab9b - [lldb][test] TestDbgInfoContentVectorFromStdModule.py: skip test on Darwin (#108003)

Author: Michael Buch Date: 2024-09-10T16:00:40+01:00 New Revision: 2bcab9ba7139cfa96c85433fa85b29c8a6d7008b URL: https://github.com/llvm/llvm-project/commit/2bcab9ba7139cfa96c85433fa85b29c8a6d7008b DIFF: https://github.com/llvm/llvm-project/commit/2bcab9ba7139cfa96c85433fa85b29c8a6d7008b.diff

[Lldb-commits] [lldb] 22144e2 - [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (#102708)

Author: Jacob Lalonde Date: 2024-09-10T09:58:43-07:00 New Revision: 22144e20cbd237a432fdc4106abe3960555aff42 URL: https://github.com/llvm/llvm-project/commit/22144e20cbd237a432fdc4106abe3960555aff42 DIFF: https://github.com/llvm/llvm-project/commit/22144e20cbd237a432fdc4106abe3960555aff42.diff

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 71986c7633f6f2d8e8e8ed5dba332c822204d211 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -274,8 +274,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr, builder.setEngineKind(llvm::EngineKind::JIT) .setErrorStr(&error_string) - .setRelocationModel(triple.isOSBinFormatMachO() ? llvm::Reloc::PIC_ -

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -0,0 +1,194 @@ +//===--- DirectToIndirectFCR.cpp - RISC-V specific pass ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

dlav-sc wrote: > Also Large Code Model for RISCV targets has been merged 2 days ago (#70308), > so I'm going to remove DirectCallReplacementPass and use large model in MCJIT > instead. I've removed DirectCallReplacementPass and added large code model instead. https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 71986c7633f6f2d8e8e8ed5dba332c822204d211 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [LLDB] Fix operators <= and >= returning a wrong result when comparing to a floating point NaN (PR #108060)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes Implement operators `<=` and `>=` to explicitly check the comparison results to be `cmpLessThan` or `cmpEqual` instead of negating the result of `operators<`. Fixes #85947 --- Full diff: https://github.com/l

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6f8d2781f604cfcf9ea6facecc0bea8e4d682e1e f172f08473d9aee702829c46fdb6cb26ec67c331 --e

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Omair Javaid (omjavaid) Changes This pull request adds support for hardware breakpoints and watchpoints in LLDB on Windows on ARM. ### Known Issues: 1. **Number of Supported Hardware Breakpoints/Watchpoints:** Windows does not provide th

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5537ae87b3a87b3abeb4e6983cecd9b103648243 1c29d30f0b9eb47da63c35f775ad69e1ef40c4de --e

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ba2aa1dcf3e18aa9bd40c7016d7fb500c77959dc d6d55a4d6f806f260e875dc29fdf7481d44fa1b1 --e

[Lldb-commits] [lldb] 5b4100c - [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (#105905)

Author: John Harrison Date: 2024-09-10T12:40:20-07:00 New Revision: 5b4100cc354148a1140546e7f5ac2bf380bc5eff URL: https://github.com/llvm/llvm-project/commit/5b4100cc354148a1140546e7f5ac2bf380bc5eff DIFF: https://github.com/llvm/llvm-project/commit/5b4100cc354148a1140546e7f5ac2bf380bc5eff.diff

[Lldb-commits] [lldb] [LLDB]Skip Summary Statistics Tests for Windows (PR #108079)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Follow up to #102708, the tests are failing for windows. There is a large variance in these tests between summary strings and built in types. I'm disabling these test for windows, and will add windows specif

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7fe1c5129e37f0eef3a67f8ccd1123e252f064b7 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] 10c04d9 - [LLDB]Skip Summary Statistics Tests for Windows (#108079)

Author: Jacob Lalonde Date: 2024-09-10T15:12:56-07:00 New Revision: 10c04d9873dbbbca26f4d996396da297b9144add URL: https://github.com/llvm/llvm-project/commit/10c04d9873dbbbca26f4d996396da297b9144add DIFF: https://github.com/llvm/llvm-project/commit/10c04d9873dbbbca26f4d996396da297b9144add.diff

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This is the root-cause for the LLDB failures that started occurring after https://github.com/llvm/llvm-project/pull/105865. The DWARFASTParserClang has logic to try derive unnamed bitfields from DWARF off

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout (PR #108169)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 19f604edfc015b35999b3b95e94f18389e4b392d fd093d23400fc48b013cafceafc009fcb5f2142c --e

[Lldb-commits] [lldb] [lldb] Only send "posix" error codes through the gdb-remote protocol (PR #108170)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The other side has no way of telling which namespace do these codes belong to, so mashing them all together is not very helpful. I'm mainly doing this to simplify some code in a pending patch

[Lldb-commits] [clang] [lldb] [llvm] Test branch1 (PR #108178)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [clang] [lldb] [llvm] Test branch1 (PR #108178)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-binary-utilities Author: None (Lakshmi-Surekha) Changes --- Patch is 388.71 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/108178.diff 129 Files Affected: - (modified) cla

[Lldb-commits] [clang] [lldb] [llvm] Test branch1 (PR #108178)

https://github.com/Lakshmi-Surekha closed https://github.com/llvm/llvm-project/pull/108178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Test branch1 (PR #108178)

https://github.com/Lakshmi-Surekha reopened https://github.com/llvm/llvm-project/pull/108178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Test branch1 (PR #108178)

https://github.com/Lakshmi-Surekha closed https://github.com/llvm/llvm-project/pull/108178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes I've been testing against qemu-aarch64 using the qemu-user platform, which doesn't support get-file: ``` AssertionError: False is not true : Command 'platform get-file "/proc/cpuinfo" <...>/TestAArch6

[Lldb-commits] [lldb] da69449 - [lldb][test] Add test for no_unique_address when mixed with bitfields (#108155)

Author: Michael Buch Date: 2024-09-11T11:36:27+01:00 New Revision: da6944912baffa430468078c38f65d55fb83dd43 URL: https://github.com/llvm/llvm-project/commit/da6944912baffa430468078c38f65d55fb83dd43 DIFF: https://github.com/llvm/llvm-project/commit/da6944912baffa430468078c38f65d55fb83dd43.diff

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes To go along with the existing TCPSocket implementation. --- Full diff: https://github.com/llvm/llvm-project/pull/108188.diff 9 Files Affected: - (modified) lldb/include/lldb/Host/Socket.h (+12-1) - (modifie

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1e3a24d2e4eb63c17b962161ae6588d1b2c178f8 eb9799b9a1631e34b9553386ce968fd5379378fc --e

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This logic will need adjusting soon for https://github.com/llvm/llvm-project/pull/108155 This patch pulls out the logic for detecting/creating unnamed bitfields out of `ParseSingleMember` to make the latt

[Lldb-commits] [lldb] 44fc987 - [lldb][test] Toolchain detection rewrite in Python (#102185)

Author: Vladislav Dzhidzhoev Date: 2024-09-11T16:04:01+03:00 New Revision: 44fc987ed174e32544a577387ab0df6886495e82 URL: https://github.com/llvm/llvm-project/commit/44fc987ed174e32544a577387ab0df6886495e82 DIFF: https://github.com/llvm/llvm-project/commit/44fc987ed174e32544a577387ab0df6886495e8

[Lldb-commits] [lldb] [lldb] Deflake TestDAP_attach (PR #108226)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The test failed in ; due to frame variable not being in stop commands, even though the DAP log shows the command being present there. I'm pretty sure t

[Lldb-commits] [lldb] [lldb] Make sure TestDAP_subtleFrames actually uses libc++ (PR #108227)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Without this, the binary would still be built with libstdc++, if that's the system/compiler default. --- Full diff: https://github.com/llvm/llvm-project/pull/108227.diff 1 Files Affected: - (modified) lldb/

[Lldb-commits] [lldb] ffa2f53 - [lldb] Print a warning on checksum mismatch (#107968)

Author: Jonas Devlieghere Date: 2024-09-11T08:53:07-07:00 New Revision: ffa2f539ae2a4e79c01b3d54f8b12c63d8781a0c URL: https://github.com/llvm/llvm-project/commit/ffa2f539ae2a4e79c01b3d54f8b12c63d8781a0c DIFF: https://github.com/llvm/llvm-project/commit/ffa2f539ae2a4e79c01b3d54f8b12c63d8781a0c.d

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

cor3ntin wrote: ping! https://github.com/llvm/llvm-project/pull/106505 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In #95312 Minidump file creation was moved from being created at the end, to the file being emitted in chunks. This causes some undesirable behavior where the file can still be present after an error has occ

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 96b7c64b8a874584a9dad44bb8901904c14701c0 771be24eecb498cecf59062182ae680f33bdbb03 --e

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

https://github.com/jeffreytan81 requested changes to this pull request. The logic makes sense. Implementation wise, instead of calling `builder.DeleteFile()` in every failure code path, I would suggest creating a RAII class which calls `builder.DeleteFile()` in destructor. Then you just need t

[Lldb-commits] [lldb] [lldb][testing] Check all stop reasons in get_threads_stopped_at_breakpoint_id (PR #108281)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes If multiple breakpoints are hit at the same time, multiple stop reasons are reported, one per breakpoint. Currently, `get_threads_stopped_at_breakpoint_id` only checks the first such rea

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Added a progress tracker to Minidump file builders memory saving --- Full diff: https://github.com/llvm/llvm-project/pull/108309.diff 2 Files Affected: - (modified) lldb/source/Plugins/ObjectFile/Minidump/

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 96b7c64b8a874584a9dad44bb8901904c14701c0 e7054832dc6e54d4b9f3ce86a8babd1f62cac81a --e

[Lldb-commits] [lldb] Make env and source map dictionaries #95137 (PR #106919)

https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/106919 >From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 1 Sep 2024 17:26:11 +0100 Subject: [PATCH 1/7] [lldb-dap] Make environment option an object --- .../tools/l

[Lldb-commits] [lldb] [lldb][testing] Check all stop reasons in get_threads_stopped_at_breakpoint_id (PR #108281)

https://github.com/jimingham approved this pull request. Yup, that's better. https://github.com/llvm/llvm-project/pull/108281 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

jimingham wrote: I don't think this is the right way to handle ValueObjects in particular. Since ValueObjects carry their errors along with them, there's really no good excuse ever to return an empty ValueObjectSP. We do that in some places, but it really makes the interface awkward: current

[Lldb-commits] [lldb] f0c6d30 - [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (#108196)

Author: Michael Buch Date: 2024-09-12T08:11:09+01:00 New Revision: f0c6d30a5d80dd42cb298f857987aa2c8f01e63e URL: https://github.com/llvm/llvm-project/commit/f0c6d30a5d80dd42cb298f857987aa2c8f01e63e DIFF: https://github.com/llvm/llvm-project/commit/f0c6d30a5d80dd42cb298f857987aa2c8f01e63e.diff

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Prevent unnamed bitfield creation in the presence of overlapping fields (PR #108343)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This bug surfaced after https://github.com/llvm/llvm-project/pull/105865 (currently reverted, but blocked on this to be relanded). Because Clang doesn't emit `DW_TAG_member`s for unnamed bitfields, LLDB ha

[Lldb-commits] [lldb] 7294396 - [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (#108183)

Author: David Spickett Date: 2024-09-12T09:48:13+01:00 New Revision: 7294396a0878a6bd179fac9aa5c3743832c799f4 URL: https://github.com/llvm/llvm-project/commit/7294396a0878a6bd179fac9aa5c3743832c799f4 DIFF: https://github.com/llvm/llvm-project/commit/7294396a0878a6bd179fac9aa5c3743832c799f4.diff

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: fix padding for current layout (PR #108362)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes IIUC, the history of `std::string`'s `__short` structure in the alternate ABI layout (as recorded by the simulator test) looks as follows: * First layout ( `SUBCLASS_PADDING` is defined): ``` struct __

[Lldb-commits] [lldb] [lldb][AArch64] Create Neon subregs when XML only includes SVE (PR #108365)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Fixes #107864 QEMU decided that when SVE is enabled it will only tell us about SVE registers in the XML, and not include Neon registers. On the grounds that the Neon V registers can be read from the

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout (PR #108375)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Depends on https://github.com/llvm/llvm-project/pull/108362 and https://github.com/llvm/llvm-project/pull/108343. Adds new layout for https://github.com/llvm/llvm-project/pull/105865. --- Full diff: https

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Prevent unnamed bitfield creation in the presence of overlapping fields (PR #108343)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 703ebca869e1e684147d316b7bdb15437c12206a 5d25eeb8cb993dc85869ace156d4a1505c9faa67 --e

[Lldb-commits] [lldb] 7e74472 - [lldb][testing] Check all stop reasons in get_threads_stopped_at_breakpoint_id (#108281)

Author: Felipe de Azevedo Piovezan Date: 2024-09-12T07:01:59-07:00 New Revision: 7e74472801486cc702fba3e831c8fcd77c120142 URL: https://github.com/llvm/llvm-project/commit/7e74472801486cc702fba3e831c8fcd77c120142 DIFF: https://github.com/llvm/llvm-project/commit/7e74472801486cc702fba3e831c8fcd77

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

jimingham wrote: You also have to be careful when treating Errors in ValueObjects, since it is not always the case that a ValueObject that returns `GetError().Success() == true` on one stop will return that when the program is allowed to run. For instance, the ValueObject for a local variable

[Lldb-commits] [lldb] Avoid expression evaluation in libStdC++ std::vector synthetic children provider (PR #108414)

https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/108414 Our customers is reporting a serious performance issue (expanding a this pointer takes 70 seconds in VSCode) in a specific execution context. Profiling shows the hot path is triggered by an expression eval

[Lldb-commits] [lldb] Avoid expression evaluation in libStdC++ std::vector synthetic children provider (PR #108414)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes Our customers is reporting a serious performance issue (expanding a this pointer takes 70 seconds in VSCode) in a specific execution context. Profiling shows the hot path is triggered by an expression evaluation

[Lldb-commits] [lldb] Avoid expression evaluation in libStdC++ std::vector synthetic children provider (PR #108414)

https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/108414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a6a547f - [lldb][DWARFASTParserClang] Prevent unnamed bitfield creation in the presence of overlapping fields (#108343)

Author: Michael Buch Date: 2024-09-12T17:26:17+01:00 New Revision: a6a547f18d99f0b0bf5ffac55443d687200f972d URL: https://github.com/llvm/llvm-project/commit/a6a547f18d99f0b0bf5ffac55443d687200f972d DIFF: https://github.com/llvm/llvm-project/commit/a6a547f18d99f0b0bf5ffac55443d687200f972d.diff

[Lldb-commits] [lldb] Avoid expression evaluation in libStdC++ std::vector synthetic children provider (PR #108414)

https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/108414 >From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Mon, 19 Aug 2024 10:57:35 -0700 Subject: [PATCH 1/3] Fix StartDebuggingRequestHandler/ReplModeRequestHandler

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications( return 0; } +struct SaveCoreRequest { jeffreytan81 wrote: Per our naming convention, let's call this RAII class `FileRemoveHolder/DumpFailRemoveHolder` or something similar, then the re

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications( return 0; } +struct SaveCoreRequest { + SaveCoreRequest(MinidumpFileBuilder &builder) : m_builder(builder) {} + + ~SaveCoreRequest() { +if (!m_success) + m_builder.DeleteFile(); ---

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/107485 >From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 5 Sep 2024 15:51:35 -0700 Subject: [PATCH 1/3] [lldb-dap] Add feature to remember last non-empty expression.

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

@@ -60,7 +60,10 @@ def run_test_evaluate_expressions( # Expressions at breakpoint 1, which is in main self.assertEvaluate("var1", "20") +# Empty expression should equate to the previous expression. cmtice wrote: Done https://github.co

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

cmtice wrote: > I wrote a fairly long comment on Friday, but I don't see it anymore so, it > looks like github has swallowed it. Here's my reconstruction of it: > > LLDB commands have the notion of a "repeat command", which can sometimes be > more complicated than just running the same string

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

@@ -1363,6 +1363,14 @@ void request_evaluate(const llvm::json::Object &request) { lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments); std::string expression = GetString(arguments, "expression").str(); llvm::StringRef context = GetString(arguments, "context"); + static

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

@@ -1364,6 +1364,13 @@ void request_evaluate(const llvm::json::Object &request) { std::string expression = GetString(arguments, "expression").str(); llvm::StringRef context = GetString(arguments, "context"); + // Remember the last non-empty expression from the user, and

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

cmtice wrote: I think I have addressed all the review comments; please take another look. https://github.com/llvm/llvm-project/pull/107485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 247d3ea843cb20d8d75ec781cd603c8ececf8934...616017152f3f0611462e9863273754036b52f7eb lldb/

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 247d3ea843cb20d8d75ec781cd603c8ececf8934 616017152f3f0611462e9863273754036b52f7eb --e

[Lldb-commits] [lldb] Avoid expression evaluation in libStdC++ std::vector synthetic children provider (PR #108414)

jimingham wrote: The goal here is excellent! Not only is this a performance problem but if you call the version of GetValueFromExpression that doesn't take an expression options - as the code you are replacing does - you get the default value for "TryAllThreads" - which is `true`. So if you

[Lldb-commits] [lldb] Avoid expression evaluation in libStdC++ std::vector synthetic children provider (PR #108414)

https://github.com/jimingham requested changes to this pull request. This is good except the implementation should be in ValueObject not SBValue. https://github.com/llvm/llvm-project/pull/108414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request) { std::string expression = GetString(arguments, "expression").str(); llvm::StringRef context = GetString(arguments, "context"); - if (context == "repl" && g_dap.DetectExpressionContext(frame,

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/107485 >From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 5 Sep 2024 15:51:35 -0700 Subject: [PATCH 1/4] [lldb-dap] Add feature to remember last non-empty expression.

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

@@ -191,6 +198,14 @@ def run_test_evaluate_expressions( self.continue_to_next_stop() self.assertEvaluate("my_bool_vec", "size=2") +# Test memory read, especially with 'empty' repeat commands. +if context == "repl": + self.continue_to_ne

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request) { std::string expression = GetString(arguments, "expression").str(); llvm::StringRef context = GetString(arguments, "context"); - if (context == "repl" && g_dap.DetectExpressionContext(frame,

[Lldb-commits] [lldb] [LLDB][Minidump] Add breakpoint stop reasons to the minidump. (PR #108448)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Recently my coworker @jeffreytan81 pointed out that Minidumps don't show breakpoints when collected. This was prior blocked because Minidumps could only contain 1 exception, now that we support N signals/sec

[Lldb-commits] [lldb] [LLDB][Minidump] Add breakpoint stop reasons to the minidump. (PR #108448)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 030c6da7af826b641db005be925b20f956c3a6bb 030b74c9e763c86d217da39487478e7cf2dff074 --e

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request) { std::string expression = GetString(arguments, "expression").str(); llvm::StringRef context = GetString(arguments, "context"); - if (context == "repl" && g_dap.DetectExpressionContext(frame,

[Lldb-commits] [lldb] [LLDB][Minidump] Add breakpoint stop reasons to the minidump. (PR #108448)

https://github.com/jeffreytan81 commented: Can you add a test to check this? https://github.com/llvm/llvm-project/pull/108448 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Add breakpoint stop reasons to the minidump. (PR #108448)

https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/108448 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    17   18   19   20   21   22   23   24   25   26   >