[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-16 Thread via lldb-commits
jeffreytan81 wrote: @labath > stepping over a breakpoint can still block Yes, I discussed this concern with @clayborg before writing it. However, this is not a new issue—the default 'step over' (next command) uses ThreadPlanStepOverBreakpoint to trace a single instruction across a breakpoint

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-16 Thread via lldb-commits
Sterling-Augustine wrote: ```lrwxrwxrwx 1 saugustine primarygroup 13 Aug 16 15:21 test/API/functionalities/breakpoint/breakpoint_with_realpath_and_source_map/symlink1/foo.h -> ../real/foo.h -rw-r--r-- 1 saugustine primarygroup 59 Aug 16 15:21 test/API/functionalities/breakpoint/breakpoint_with

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-16 Thread via lldb-commits
royitaqi wrote: I assume you meant the "w" permission on group and others (because I suppose the "x" is needed for the symlink to function). It's unintended and by accident. I cannot recall how I created them differently. Yes, a forward fix from you will be super nice. Thanks for flagging this

[Lldb-commits] [lldb] [AIX] 1. Avoid namespace collision on other platforms (PR #104679)

2024-08-17 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [AIX] 1. Avoid namespace collision on other platforms (PR #104679)

2024-08-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dhruv Srivastava (DhruvSrivastavaX) Changes This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. #101657 The complete changes for

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-18 Thread via lldb-commits
https://github.com/Da-Viper created https://github.com/llvm/llvm-project/pull/104711 Fixes #103043 >From 0b84d36d320a58a13ca98bd1b1c186c72bbe63e2 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 18 Aug 2024 15:26:11 +0100 Subject: [PATCH] [lldb-dap] vscode now shows a dialog when the dab

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (Da-Viper) Changes Fixes #103043 --- Full diff: https://github.com/llvm/llvm-project/pull/104711.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/src-ts/extension.ts (+26-3) ``diff diff --git a/lldb/tools/lldb-dap

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-18 Thread via lldb-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/104711 >From 0b84d36d320a58a13ca98bd1b1c186c72bbe63e2 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 18 Aug 2024 15:26:11 +0100 Subject: [PATCH 1/2] [lldb-dap] vscode now shows a dialog when the dab-executable

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-08-18 Thread via lldb-commits
temyurchenko wrote: > Ping @JDevlieghere for lldb test suite assistance. > > As for ORC JIT, [the compiler-rt project](https://compiler-rt.llvm.org/) does > not claim to support Windows to begin with, so it's unclear whether the bot > should not be testing on Windows or whether compiler-rt nee

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

2024-08-19 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff aad27bf534b59645f47a92f072af798687b1dd0d e72ceaada170354aa322b4c6a1787152ac72c65b --e

[Lldb-commits] [lldb] [lldb][NFC] Moved the SharedSocket class to Socket.* (PR #104787)

2024-08-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This is prerequisite for #104238. --- Full diff: https://github.com/llvm/llvm-project/pull/104787.diff 3 Files Affected: - (modified) lldb/include/lldb/Host/Socket.h (+24) - (modified) lldb/source/Host

[Lldb-commits] [lldb] [lldb] Updated TCPSocket to listen multiple ports on the same single thread (PR #104797)

2024-08-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This is prerequisite for #104238. --- Full diff: https://github.com/llvm/llvm-project/pull/104797.diff 3 Files Affected: - (modified) lldb/include/lldb/Host/common/TCPSocket.h (+3) - (modified) lldb/so

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

2024-08-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes When we use `SemaSourceWithPriorities` as the `ASTContext`s ExternalASTSource, we allocate a `ClangASTSourceProxy` (via `CreateProxy`) and two `ExternalASTSourceWrapper`. Then we push these sources into a

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

2024-08-19 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c7a54bfd1d25330199c96dd0a46cef1644b1b1ce 0c23c427f7154dabadbca65f64973ec2dbe365d9 --e

[Lldb-commits] [lldb] 7a06ebd - [lldb] PopulatePrpsInfoTest can fail due to hardcoded priority value (#104617)

2024-08-19 Thread via lldb-commits
Author: Fred Grim Date: 2024-08-19T08:41:11-07:00 New Revision: 7a06ebdeb6440d80fbcaeccd33314c6e039c6795 URL: https://github.com/llvm/llvm-project/commit/7a06ebdeb6440d80fbcaeccd33314c6e039c6795 DIFF: https://github.com/llvm/llvm-project/commit/7a06ebdeb6440d80fbcaeccd33314c6e039c6795.diff LOG

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Implement ExternalSemaSource::ReadUndefinedButUsed (PR #104817)

2024-08-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes While parsing an expression, Clang tries to diagnose usage of decls (with possibly non-external linkage) for which it hasn't been provided with a definition. This is the case, e.g., for functions with para

[Lldb-commits] [lldb] Fix StartDebuggingRequestHandler/ReplModeRequestHandler in lldb-dap (PR #104824)

2024-08-19 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/104824 `SBCommand::AddCommand()` requires `SBCommandPluginInterface` to be heap based because it will be stored inside `std::shared_ptr` later for reference counting. But lldb-dap passes `StartDebuggingRequestHa

[Lldb-commits] [lldb] Fix StartDebuggingRequestHandler/ReplModeRequestHandler in lldb-dap (PR #104824)

2024-08-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes `SBCommand::AddCommand()` requires `SBCommandPluginInterface` to be heap based because it will be stored inside `std::shared_ptr` later for reference counting. But lldb-dap passe

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-19 Thread via lldb-commits
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-19 Thread via lldb-commits
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

2024-08-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Will Hawkins (hawkinsw) Changes Only Linux systems do not have gettid. Provide our own gettid in these cases. Fixes a build failure caused by #104109. --- Full diff: https://github.com/llvm/llvm-project/pull/104831.diff 1 Files Affected:

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

2024-08-19 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6e0fc155782ff5307245a85c7b037a2998ec6c86 10bc5a512b56238328b025303345e47708927d6e --e

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-19 Thread via lldb-commits
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-19 Thread via lldb-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/104711 >From 0b84d36d320a58a13ca98bd1b1c186c72bbe63e2 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 18 Aug 2024 15:26:11 +0100 Subject: [PATCH 1/3] [lldb-dap] vscode now shows a dialog when the dab-executable

[Lldb-commits] [lldb] [llvm] [Docs] Use cacheable myst_heading_slug_func value (PR #104847)

2024-08-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Scott Linder (slinder1) Changes Avoid creating an uncacheable conf variable by using a string instead of a function reference. Also has the effect of avoiding triggering the "config.cache" sphinx warning. Requires myst_parser 0.19.0 (specif

[Lldb-commits] [lldb] [llvm-lit][test] Change unsupported cat -e to cat -v to work with lit internal shell (PR #104878)

2024-08-19 Thread via lldb-commits
https://github.com/connieyzhu created https://github.com/llvm/llvm-project/pull/104878 This patch changes the test that uses the `cat -e` option to `cat -v` so that the test can be run using lit's internal shell. This is an alternative patch to https://github.com/llvm/llvm-project/pull/102061,

[Lldb-commits] [lldb] [llvm-lit][test] Change unsupported cat -e to cat -v to work with lit internal shell (PR #104878)

2024-08-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Connie (connieyzhu) Changes This patch changes the test that uses the `cat -e` option to `cat -v` so that the test can be run using lit's internal shell. This is an alternative patch to https://github.com/llvm/llvm-project/pull/102061, opt

[Lldb-commits] [lldb] b804516 - [lldb][AIX] 1. Avoid namespace collision on other platforms (#104679)

2024-08-20 Thread via lldb-commits
Author: Dhruv Srivastava Date: 2024-08-20T10:19:32+01:00 New Revision: b804516dc5cf2bb99ff02aa49f9d4da76d721ea9 URL: https://github.com/llvm/llvm-project/commit/b804516dc5cf2bb99ff02aa49f9d4da76d721ea9 DIFF: https://github.com/llvm/llvm-project/commit/b804516dc5cf2bb99ff02aa49f9d4da76d721ea9.di

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

2024-08-20 Thread via lldb-commits
github-actions[bot] wrote: @DhruvSrivastavaX Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with

[Lldb-commits] [lldb] [lldb][Windows] Fixed the API test breakpoint_with_realpath_and_source_map (PR #104918)

2024-08-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This test is already disabled for Windows because of symlinks. Disable it for cross build on Windows host too. --- Full diff: https://github.com/llvm/llvm-project/pull/104918.diff 1 Files Affected: - (

[Lldb-commits] [lldb] fc04490 - [lldb][Windows] Fixed the API test breakpoint_with_realpath_and_source_map (#104918)

2024-08-20 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-08-20T17:25:34+04:00 New Revision: fc044901a2b8ae277b62bdde9140917913bd1644 URL: https://github.com/llvm/llvm-project/commit/fc044901a2b8ae277b62bdde9140917913bd1644 DIFF: https://github.com/llvm/llvm-project/commit/fc044901a2b8ae277b62bdde9140917913bd1644.dif

[Lldb-commits] [lldb] [lldb] Disable the API test TestCppBitfields on Windows (PR #105037)

2024-08-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This test causes the assert in clang CodeGen and python crashes with the error code 0x8003. See #105019 for more details. Note the similar test lldb/test/API/lang/c/bitfields/TestBitfields.py is alrea

[Lldb-commits] [lldb] [lldb][test] Change unsupported cat -e to cat -v to work with lit internal shell (PR #104878)

2024-08-20 Thread via lldb-commits
https://github.com/connieyzhu edited https://github.com/llvm/llvm-project/pull/104878 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Change unsupported cat -e to cat -v to work with lit internal shell (PR #104878)

2024-08-20 Thread via lldb-commits
https://github.com/connieyzhu edited https://github.com/llvm/llvm-project/pull/104878 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Change unsupported cat -e to cat -v to work with lit internal shell (PR #104878)

2024-08-20 Thread via lldb-commits
connieyzhu wrote: > Looks reasonable to me, but I think it would be worth highlighting in the > text the difference between -e and -v, so that people doing code archaelogy > don't have to look up cat options. I just added the option description in the PR description - thanks for the feedback!

[Lldb-commits] [lldb] [lldb][test] Change unsupported cat -e to cat -v to work with lit internal shell (PR #104878)

2024-08-20 Thread via lldb-commits
connieyzhu wrote: > And I edited the title slightly, since this is changing an lldb test not > llvm-lit itself. Totally missed that somehow, thank you for the fix! https://github.com/llvm/llvm-project/pull/104878 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] 770cd24 - [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (#104799)

2024-08-20 Thread via lldb-commits
Author: Michael Buch Date: 2024-08-20T18:40:54+01:00 New Revision: 770cd24140038646539602406fff54497793dae8 URL: https://github.com/llvm/llvm-project/commit/770cd24140038646539602406fff54497793dae8 DIFF: https://github.com/llvm/llvm-project/commit/770cd24140038646539602406fff54497793dae8.diff

[Lldb-commits] [lldb] 8056d92 - [lldb][ClangExpressionParser] Implement ExternalSemaSource::ReadUndefinedButUsed (#104817)

2024-08-20 Thread via lldb-commits
Author: Michael Buch Date: 2024-08-20T18:42:46+01:00 New Revision: 8056d92bc201906edbb27f4efa1cc80a18359880 URL: https://github.com/llvm/llvm-project/commit/8056d92bc201906edbb27f4efa1cc80a18359880 DIFF: https://github.com/llvm/llvm-project/commit/8056d92bc201906edbb27f4efa1cc80a18359880.diff

[Lldb-commits] [lldb] 3565332 - [lldb] Fix windows debug build after 9d07f43 (#104896)

2024-08-20 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-08-20T10:47:06-07:00 New Revision: 356533246aa33db44c75afb2d3eb6e0e08f0d7a6 URL: https://github.com/llvm/llvm-project/commit/356533246aa33db44c75afb2d3eb6e0e08f0d7a6 DIFF: https://github.com/llvm/llvm-project/commit/356533246aa33db44c75afb2d3eb6e0e08f0d7a6.

[Lldb-commits] [lldb] 31e55d4 - [lldb] Disable the API test TestCppBitfields on Windows (#105037)

2024-08-20 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-08-20T22:26:49+04:00 New Revision: 31e55d461693df035049e09cbeeb8886ca2cb6d3 URL: https://github.com/llvm/llvm-project/commit/31e55d461693df035049e09cbeeb8886ca2cb6d3 DIFF: https://github.com/llvm/llvm-project/commit/31e55d461693df035049e09cbeeb8886ca2cb6d3.dif

[Lldb-commits] [lldb] 6558e04 - [lldb][test] Change unsupported cat -e to cat -v to work with lit internal shell (#104878)

2024-08-20 Thread via lldb-commits
Author: Connie Zhu Date: 2024-08-20T11:54:17-07:00 New Revision: 6558e04f02858bff61c01c9ec0900849fc8532f5 URL: https://github.com/llvm/llvm-project/commit/6558e04f02858bff61c01c9ec0900849fc8532f5 DIFF: https://github.com/llvm/llvm-project/commit/6558e04f02858bff61c01c9ec0900849fc8532f5.diff LO

[Lldb-commits] [lldb] [lldb-dap] Enabling instruction breakpoint support to lldb-dap. (PR #105278)

2024-08-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 31e55d461693df035049e09cbeeb8886ca2cb6d3...7e221825b8537f69e19cf366c446d9a09a4768fe lldb

[Lldb-commits] [lldb] [lldb-dap] Enabling instruction breakpoint support to lldb-dap. (PR #105278)

2024-08-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 31e55d461693df035049e09cbeeb8886ca2cb6d3 7e221825b8537f69e19cf366c446d9a09a4768fe --e

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Add selectable memory regions to SBSaveCore (PR #105442)

2024-08-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes This patch adds the option to specify specific memory ranges to be included in a given core file. The current implementation lets user specified ranges either be in addition to a certain save style, or indep

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Add selectable memory regions to SBSaveCore (PR #105442)

2024-08-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r c4bf949171a72383d5ba4d2b587d4cc496aacebb...001ed7aa004480e052d5aecf29c7ce8132c60d24 lldb

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Add selectable memory regions to SBSaveCore (PR #105442)

2024-08-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c4bf949171a72383d5ba4d2b587d4cc496aacebb 001ed7aa004480e052d5aecf29c7ce8132c60d24 --e

[Lldb-commits] [lldb] f01f80c - [lldb] Extend frame recognizers to hide frames from backtraces (#104523)

2024-08-20 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-08-20T16:01:22-07:00 New Revision: f01f80ce6ca7640bb0e267b84b1ed0e89b57e2d9 URL: https://github.com/llvm/llvm-project/commit/f01f80ce6ca7640bb0e267b84b1ed0e89b57e2d9 DIFF: https://github.com/llvm/llvm-project/commit/f01f80ce6ca7640bb0e267b84b1ed0e89b57e2d9.diff

[Lldb-commits] [lldb] [lldb-dap] Fix disassembled ranges for `disassemble` request (PR #105446)

2024-08-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 82ee31f75ac1316006fa9e21dddfddec37cf7072...b809f570dd8055e5b899c337ec9ff5110ab94c6e lldb/

[Lldb-commits] [lldb] [lldb/Interpreter] Introduce `ScriptedStopHook{, Python}Interface` & make use of it (PR #105449)

2024-08-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch introduces new `ScriptedStopHook{,Python}Interface` classes that make use of the Scripted Interface infrastructure and makes use of it in `StopHookScripted`. It also relax the requireme

[Lldb-commits] [lldb] [lldb-dap] When sending a DAP Output Event break each message into separate lines. (PR #105456)

2024-08-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Previously, when output like `"hello\nworld\n"` was produced by lldb (or the process) the message would be sent as a single Output event. By being a single event this causes VS Code to treat this as a single

[Lldb-commits] [lldb] [lldb-dap] Enabling instruction breakpoint support to lldb-dap. (PR #105278)

2024-08-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Santhosh Kumar Ellendula (santhoshe447) Changes Added support for "supportsInstructionBreakpoints" capability and now it this command is triggered when we set instruction breakpoint. We need this support as part of enabling disassembly view

[Lldb-commits] [lldb] 35cec80 - [lldb][test] Workaround older systems that lack gettid (#104831)

2024-08-20 Thread via lldb-commits
Author: Will Hawkins Date: 2024-08-20T21:09:08-07:00 New Revision: 35cec805bfa91fd9b83c29c45f3a5877e484bd85 URL: https://github.com/llvm/llvm-project/commit/35cec805bfa91fd9b83c29c45f3a5877e484bd85 DIFF: https://github.com/llvm/llvm-project/commit/35cec805bfa91fd9b83c29c45f3a5877e484bd85.diff

[Lldb-commits] [lldb] [lldb][aix] 2. Updating XCOFF, PPC entry in LLDB ArchSpec (PR #105507)

2024-08-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dhruv Srivastava (DhruvSrivastavaX) Changes This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. #101657 The complete changes for

[Lldb-commits] [lldb] [lldb][aix] 2. Updating XCOFF, PPC entry in LLDB ArchSpec (PR #105523)

2024-08-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dhruv Srivastava (DhruvSrivastavaX) Changes This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. #101657 The complete changes for

[Lldb-commits] [lldb] 6cb1459 - [LLDB][Minidump] Fix ProcessMinidump::GetMemoryRegions to include 64b regions when /proc/pid maps are missing. (#101086)

2024-08-21 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-08-21T10:25:23-07:00 New Revision: 6cb14599ade843be3171fa7e4dd5f3601a3bb0de URL: https://github.com/llvm/llvm-project/commit/6cb14599ade843be3171fa7e4dd5f3601a3bb0de DIFF: https://github.com/llvm/llvm-project/commit/6cb14599ade843be3171fa7e4dd5f3601a3bb0de.diff

[Lldb-commits] [lldb] 6257a98 - [lldb-dap] Implement `StepGranularity` for "next" and "step-in" (#105464)

2024-08-21 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-08-21T20:30:10+02:00 New Revision: 6257a98b258a3f17b78af31bf43009a559c5dd1d URL: https://github.com/llvm/llvm-project/commit/6257a98b258a3f17b78af31bf43009a559c5dd1d DIFF: https://github.com/llvm/llvm-project/commit/6257a98b258a3f17b78af31bf43009a559c5dd1d

[Lldb-commits] [lldb] [lldb] Pick the correct architecutre when target and core file disagree (PR #105576)

2024-08-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes In f9f3316, Adrian fixed an issue where LLDB wouldn't update the target's architecture when the process reported a different triple that only differed in its sub-architecture. This unintentionally

[Lldb-commits] [lldb] [lldb-dap] When sending a DAP Output Event break each message into separate lines. (PR #105456)

2024-08-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a16f0dc9c2f0690e28622b0d80bd154fb0e6a30a 106a6bab4972913d989b97108c4f5f25bef2eca3 --e

[Lldb-commits] [lldb] 30ca06c - [lldb-dap] When sending a DAP Output Event break each message into separate lines. (#105456)

2024-08-21 Thread via lldb-commits
Author: John Harrison Date: 2024-08-21T13:48:29-07:00 New Revision: 30ca06c4d0d06f67f10a9e19d4333acc2074811b URL: https://github.com/llvm/llvm-project/commit/30ca06c4d0d06f67f10a9e19d4333acc2074811b DIFF: https://github.com/llvm/llvm-project/commit/30ca06c4d0d06f67f10a9e19d4333acc2074811b.diff

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-21 Thread via lldb-commits
jeffreytan81 wrote: @walter-erquinigo, the performance issue is not only showing for 1% rare gigantic target. It is actually reported by a customer's target with 4000 modules with only 3GB of debug info. Disabling this feature significantly improves the stepping experience. To get a sense of

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-21 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/104874 >From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Mon, 19 Aug 2024 10:57:35 -0700 Subject: [PATCH 1/2] Fix StartDebuggingRequestHandler/ReplModeRequestHandler

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-21 Thread via lldb-commits
@@ -3091,17 +3093,20 @@ void request_stackTrace(const llvm::json::Object &request) { // This will always return an invalid thread when // libBacktraceRecording.dylib is not loaded or if there is no extended // backtrace. -lldb::SBThread queue_backtrace_thread =

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint detection behavior [WIP] (PR #105594)

2024-08-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes This is a PR to track the changes I need to make to https://github.com/llvm/llvm-project/pull/96260 to address the CI bot failures when I merged that PR, as well as investigating the windows problem Mar

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-21 Thread via lldb-commits
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object &request) { // This will always return an invalid thread when // libBacktraceRecording.dylib is not loaded or if there is no extended // backtrace. -lldb::SBThread queue_backtrace_thread =

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-21 Thread via lldb-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/104711 >From 2cda519a06d46bd6a5ae02e8be8daacb39a49b3e Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Thu, 22 Aug 2024 01:42:17 +0100 Subject: [PATCH] Rebase and add check dap path on config change --- .../lldb-dap

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-21 Thread via lldb-commits
Da-Viper wrote: > cool > > Don't forget to run `npm run format` before landing this Done https://github.com/llvm/llvm-project/pull/104711 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-21 Thread via lldb-commits
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object &request) { // This will always return an invalid thread when // libBacktraceRecording.dylib is not loaded or if there is no extended // backtrace. -lldb::SBThread queue_backtrace_thread =

[Lldb-commits] [lldb] [lldb-dap] Skip the lldb-dap output test on windows, it seems all the lldb-dap tests are disabled on windows. (PR #105604)

2024-08-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This should fix https://lab.llvm.org/buildbot/#/builders/141/builds/1747 --- Full diff: https://github.com/llvm/llvm-project/pull/105604.diff 1 Files Affected: - (modified) lldb/test/API/tools/lldb-dap/outp

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-21 Thread via lldb-commits
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object &request) { // This will always return an invalid thread when // libBacktraceRecording.dylib is not loaded or if there is no extended // backtrace. -lldb::SBThread queue_backtrace_thread =

[Lldb-commits] [lldb] 8e0b9c8 - [lldb-dap] Skip the lldb-dap output test on windows, it seems all the lldb-dap tests are disabled on windows. (#105604)

2024-08-21 Thread via lldb-commits
Author: John Harrison Date: 2024-08-21T18:52:48-07:00 New Revision: 8e0b9c85924ca22a65d57988ea2c5c22a5181ed9 URL: https://github.com/llvm/llvm-project/commit/8e0b9c85924ca22a65d57988ea2c5c22a5181ed9 DIFF: https://github.com/llvm/llvm-project/commit/8e0b9c85924ca22a65d57988ea2c5c22a5181ed9.diff

[Lldb-commits] [lldb] 1b664fe - [lldb][AIX] Updating XCOFF, PPC entry in LLDB ArchSpec (#105523)

2024-08-22 Thread via lldb-commits
Author: Dhruv Srivastava Date: 2024-08-22T09:56:49+01:00 New Revision: 1b664fe2548d4cd5ce7a495cde4a86b5531af123 URL: https://github.com/llvm/llvm-project/commit/1b664fe2548d4cd5ce7a495cde4a86b5531af123 DIFF: https://github.com/llvm/llvm-project/commit/1b664fe2548d4cd5ce7a495cde4a86b5531af123.di

[Lldb-commits] [lldb] 9f41805 - [lldb] Pick the correct architecutre when target and core file disagree (#105576)

2024-08-22 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-08-22T08:29:48-07:00 New Revision: 9f418057dc73e4e5cb94a7cd671097275ffc29fc URL: https://github.com/llvm/llvm-project/commit/9f418057dc73e4e5cb94a7cd671097275ffc29fc DIFF: https://github.com/llvm/llvm-project/commit/9f418057dc73e4e5cb94a7cd671097275ffc29fc.d

[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes With this commit, we also hide the implementation details of `std::invoke`. To do so, the `LibCXXFrameRecognizer` got a couple more regular expressions. The regular expression passed into the `Add

[Lldb-commits] [lldb] c1e401f - [lldb] Change the two remaining SInt64 settings in Target to uint (#105460)

2024-08-22 Thread via lldb-commits
Author: Jason Molenda Date: 2024-08-22T10:10:15-07:00 New Revision: c1e401f3624780f85f4c9a26960752ee3f37fafb URL: https://github.com/llvm/llvm-project/commit/c1e401f3624780f85f4c9a26960752ee3f37fafb DIFF: https://github.com/llvm/llvm-project/commit/c1e401f3624780f85f4c9a26960752ee3f37fafb.diff

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-22 Thread via lldb-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/104711 >From 2cda519a06d46bd6a5ae02e8be8daacb39a49b3e Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Thu, 22 Aug 2024 01:42:17 +0100 Subject: [PATCH 1/2] Rebase and add check dap path on config change --- .../lldb

[Lldb-commits] [lldb] e5140ae - Fix dap stacktrace perf issue (#104874)

2024-08-22 Thread via lldb-commits
Author: jeffreytan81 Date: 2024-08-22T11:30:34-07:00 New Revision: e5140aed275fe60b83188143f39011d5c0ee5bb0 URL: https://github.com/llvm/llvm-project/commit/e5140aed275fe60b83188143f39011d5c0ee5bb0 DIFF: https://github.com/llvm/llvm-project/commit/e5140aed275fe60b83188143f39011d5c0ee5bb0.diff

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-22 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/104874 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fix: [lldb]: add missing if for smaller linux version (PR #105715)

2024-08-22 Thread via lldb-commits
https://github.com/root-kidik created https://github.com/llvm/llvm-project/pull/105715 None >From 719a9c76f8852ed4e493e7376b9959bfef8b4b5f Mon Sep 17 00:00:00 2001 From: Nikita Date: Fri, 23 Aug 2024 01:37:57 +0700 Subject: [PATCH] fix: [lldb]: add missing if for smaller linux version --- ll

[Lldb-commits] [lldb] fix: [lldb]: add missing if for smaller linux version (PR #105715)

2024-08-22 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] fix: [lldb]: add missing if for smaller linux version (PR #105715)

2024-08-22 Thread via lldb-commits
https://github.com/root-kidik edited https://github.com/llvm/llvm-project/pull/105715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fix: [lldb]: add missing if for smaller linux version (PR #105715)

2024-08-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Nikita (root-kidik) Changes Close: #105705 --- Full diff: https://github.com/llvm/llvm-project/pull/105715.diff 1 Files Affected: - (modified) lldb/source/Plugins/Process/Linux/Perf.cpp (+2) ``diff diff --git a/lldb/source/Plu

[Lldb-commits] [lldb] [lldb] Conditionalize context_switch attribute based on kernel version (PR #105715)

2024-08-22 Thread via lldb-commits
https://github.com/root-kidik edited https://github.com/llvm/llvm-project/pull/105715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support frame recognizer regexp on mangled names. (PR #105756)

2024-08-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes Instead of doing the coarse-grained initial matching of frame recognizers on fully demangled names, it can be much more efficient and reliable to filter on all functions of a particular language by dis

[Lldb-commits] [lldb] [lldb][NFC] Defer python init until ScriptInterpreter is created (PR #105757)

2024-08-22 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb][NFC] Defer python init until ScriptInterpreter is created (PR #105757)

2024-08-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Daniel Xu (danobi) Changes Previously python was initialized during static registration of the plugin. This causes the python interpreter to run even if python support is explicitly disabled thru: SBDebugger::SetScriptLanguage(ScriptL

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

2024-08-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes `memory read` will return an error if you try to read more than 1k bytes in a single command, instructing you to set `target.max-memory-read-size` or use `--force` if you intended to read more than that

[Lldb-commits] [lldb] [GDBRemote] Fix processing of comma-separated memory region entries (PR #105873)

2024-08-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes The existing algorithm was performing the following comparisons for an `aaa,bbb,ccc,ddd`: aaa\0bbb,ccc,ddd == "stack" aaa\0bbb\0ccc,ddd == "stack" aaa\0bbb\0ccc\0ddd == "stack" Which wou

[Lldb-commits] [lldb] [GDBRemote] Fix processing of comma-separated memory region entries (PR #105873)

2024-08-23 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff aec3ec04ac611f9a3d1e1ad075d50f62c1d1a1e2 8ef8ecdc8d87d474b906835d04ffdd9a19216406 --e

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-23 Thread via lldb-commits
Da-Viper wrote: ![Screenshot from 2024-08-23 20-16-35](https://github.com/user-attachments/assets/433234ab-dc1c-4907-a222-1961c97b0673) This is what is shown when I return undefined from the createDebugAdapterDescriptor function If I also throw ```vscode.FileSystemError.FileExists(`Debug pat

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

2024-08-23 Thread via lldb-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/104711 >From 2cda519a06d46bd6a5ae02e8be8daacb39a49b3e Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Thu, 22 Aug 2024 01:42:17 +0100 Subject: [PATCH 1/3] Rebase and add check dap path on config change --- .../lldb

[Lldb-commits] [lldb] 8b4147d - [GDBRemote] Fix processing of comma-separated memory region entries (#105873)

2024-08-23 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2024-08-23T13:09:31-07:00 New Revision: 8b4147d14c460f8886e882db48361d4c101917d7 URL: https://github.com/llvm/llvm-project/commit/8b4147d14c460f8886e882db48361d4c101917d7 DIFF: https://github.com/llvm/llvm-project/commit/8b4147d14c460f8886e882db48361d4c1

[Lldb-commits] [lldb] [GDBRemote] Handle 'heap' memory region info type (PR #105883)

2024-08-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This should cause the memory region info "is stack" field to be set to "no". --- Full diff: https://github.com/llvm/llvm-project/pull/105883.diff 2 Files Affected: - (modified) lldb/so

[Lldb-commits] [lldb] [lldb] Don't scan more than 10MB of assembly insns (PR #105890)

2024-08-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes For supported architectures, lldb will do a static scan of the assembly instructions of a function to detect stack/frame pointer changes, register stores and loads, so we can retrieve register values fo

[Lldb-commits] [lldb] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (PR #105905)

2024-08-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Refactoring `stackTrace` to perform frame look ups in a more on-demand fashion to improve overall performance. Additionally adding additional information to the `exceptionInfo` request to report exception st

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-23 Thread via lldb-commits
jeffreytan81 wrote: As another data point, I just encountered a telemetry data from a customer. Taking profile trace from that session shows "stackTrace" request takes more than 4 seconds. Around 94% of the time was spent in this hot path performing function evaluation: ``` ll

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-23 Thread via lldb-commits
jeffreytan81 wrote: And just for fun, here is an extreme one with 18 seconds of sampling time, 99.6% time is from this hot path. Note: they are all from linux machines because we only enable perf sampling by default for linux platform so we have no Mac data. ``` # time of first sample : 26469

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-25 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Paul Zander (negril) Changes Changed in python version 3.12: A backslash-character pair that is not a valid escape sequence now generates a SyntaxWarning, instead of DeprecationWarning. For example, re.compile("\d+\. \d+") now emits

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul Zander (negril) Changes Changed in python version 3.12: A backslash-character pair that is not a valid escape sequence now generates a SyntaxWarning, instead of DeprecationWarning. For example, re.compile("\d+\. \d+") now emits a

[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-25 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 675c748bb606d75a959481e6014299849cf3094c...32786ae0abb7c465dfab602b1d53da11dd1dc7a7 lldb/

<    14   15   16   17   18   19   20   21   22   23   >