[Lldb-commits] [lldb] [lldb] Fix SBAddressRange validation checks. (PR #95997)

2024-06-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/95997.diff 2 Files Affected: - (modified) lldb/source/API/SBAddressRange.cpp (+3-15) - (modified) lldb/test/API/python_api/address_range/TestAddressRa

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

2024-06-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes This commit adds a unit test for SBBreakpoint::SetCallback as it wasn't being tested before. --- Full diff: https://github.com/llvm/llvm-project/pull/96001.diff 2 Files Affected: - (modified) ll

[Lldb-commits] [lldb] 70f41a8 - [lldb] Add/change options in `statistics dump` to control what sections are dumped (#95075)

2024-06-18 Thread via lldb-commits
Author: royitaqi Date: 2024-06-18T17:21:20-07:00 New Revision: 70f41a8c305478cb16bcda9f9967af96ab1e3a20 URL: https://github.com/llvm/llvm-project/commit/70f41a8c305478cb16bcda9f9967af96ab1e3a20 DIFF: https://github.com/llvm/llvm-project/commit/70f41a8c305478cb16bcda9f9967af96ab1e3a20.diff LOG:

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-18 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-06-18 Thread via lldb-commits
jeffreytan81 wrote: @jimingham, hope WWDC is going well. Do you have time to review this now? Thanks. https://github.com/llvm/llvm-project/pull/90930 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb] Make LanguageRuntime::GetTypeBitSize return an optional (NFC) (PR #96013)

2024-06-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Make LanguageRuntime::GetTypeBitSize return an optional. This should be NFC, though the ObjCLanguageRuntime implementation is (possibly) more defensive against returning 0. I'm not sure if it's pos

[Lldb-commits] [lldb] dadf960 - [lldb][ObjC] Don't query objective-c runtime for decls in C++ contexts (#95963)

2024-06-18 Thread via lldb-commits
Author: Michael Buch Date: 2024-06-19T07:54:51+01:00 New Revision: dadf960607bb429baebd3f523ce5b93260a154d2 URL: https://github.com/llvm/llvm-project/commit/dadf960607bb429baebd3f523ce5b93260a154d2 DIFF: https://github.com/llvm/llvm-project/commit/dadf960607bb429baebd3f523ce5b93260a154d2.diff

[Lldb-commits] [lldb] c2f9766 - [lldb/DWARF] Fix type definition search with simple template names (#95905)

2024-06-19 Thread via lldb-commits
Author: Pavel Labath Date: 2024-06-20T08:09:02+02:00 New Revision: c2f976649a5ef405b224bfe36267966cdd394057 URL: https://github.com/llvm/llvm-project/commit/c2f976649a5ef405b224bfe36267966cdd394057 DIFF: https://github.com/llvm/llvm-project/commit/c2f976649a5ef405b224bfe36267966cdd394057.diff

[Lldb-commits] [lldb] [lldb] Merge CompilerContextKind::{Class, Struct} (PR #96145)

2024-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Our dwarf parsing code treats structures and classes as interchangable. CompilerContextKind is used when looking DIEs for types. This makes sure we always they're treated the same way. See also #95905#discuss

[Lldb-commits] [lldb] [lldb] Fix printing of unsigned enum bitfields when they contain the max value (PR #96202)

2024-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes While testing register fields I found that if you put the max value into a bitfield with an underlying type that is an unsigned enum, lldb would not print the enum name. This is because the code to m

[Lldb-commits] [lldb] 5e9f247 - [lldb] Make LanguageRuntime::GetTypeBitSize return an optional (NFC) (#96013)

2024-06-20 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-20T10:46:26-07:00 New Revision: 5e9f247c064cb2361cd641f62eb4b7049d21641a URL: https://github.com/llvm/llvm-project/commit/5e9f247c064cb2361cd641f62eb4b7049d21641a DIFF: https://github.com/llvm/llvm-project/commit/5e9f247c064cb2361cd641f62eb4b7049d21641a.d

[Lldb-commits] [lldb] [DWIMPrint] Move the setting of the result status into dump_val_object (PR #96232)

2024-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes This is another NFC change for TypeSystemClang, because an object description cannot actually fail there. It will have different behavior in the Swift plugin. --- Full diff: https://github.com/llvm/llv

[Lldb-commits] [lldb] 9473e16 - [DWIMPrint] Move the setting of the result status into dump_val_object (#96232)

2024-06-20 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-06-20T12:50:26-07:00 New Revision: 9473e162b92a7e0bb1471eaaa6cbd6b5fc104fed URL: https://github.com/llvm/llvm-project/commit/9473e162b92a7e0bb1471eaaa6cbd6b5fc104fed DIFF: https://github.com/llvm/llvm-project/commit/9473e162b92a7e0bb1471eaaa6cbd6b5fc104fed.diff

[Lldb-commits] [lldb] aafa0ef - [lldb/crashlog] Make interactive mode the new default (#94575)

2024-06-20 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-06-20T17:23:18-07:00 New Revision: aafa0ef900791857f55629bcf61c37f53cc0d2af URL: https://github.com/llvm/llvm-project/commit/aafa0ef900791857f55629bcf61c37f53cc0d2af DIFF: https://github.com/llvm/llvm-project/commit/aafa0ef900791857f55629bcf61c37f53cc0d2af.

[Lldb-commits] [lldb] [lldb] Unify Platform::ResolveExecutable (PR #96256)

2024-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The Platform class currently has two functions to resolve an executable: `ResolveExecutable` and `ResolveRemoteExecutable`. The former strictly deals with local files while the latter can handle pot

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-06-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r d8091522664248a4ba73d8d1e7fa6ac57bfcf67c...e0ed752849486f67d9fddbef3767a1756afd1ab2 lldb/

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes lldb today has two rules: When a thread stops at a BreakpointSite, we set the thread's StopReason to be "breakpoint hit" (regardless if we've actually hit the breakpoint, or if we've merely stopped *at

[Lldb-commits] [lldb] Revert "[lldb/crashlog] Make interactive mode the new default" (PR #96263)

2024-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes Reverts llvm/llvm-project#94575 since introduces test failure: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6166/ --- Full diff: https://github.com/llvm/llvm-project/pull/962

[Lldb-commits] [lldb] 1373f7c - Revert "[lldb/crashlog] Make interactive mode the new default" (#96263)

2024-06-20 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-06-20T18:23:50-07:00 New Revision: 1373f7c714824f5957aa5fabf8370286f86e6b14 URL: https://github.com/llvm/llvm-project/commit/1373f7c714824f5957aa5fabf8370286f86e6b14 DIFF: https://github.com/llvm/llvm-project/commit/1373f7c714824f5957aa5fabf8370286f86e6b14.

[Lldb-commits] [lldb] [lldb][ExpressionParser][NFCI] Add new DoPrepareForExecution interface to be implemented by language plugins (PR #96290)

2024-06-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch adds a new `DoPrepareForExecution` API, which can be implemented by the Clang and Swift language plugins. This also moves `RunStaticInitializers` into `ExpressionParser::PrepareForExecution`, so

[Lldb-commits] [lldb] [lldb/DWARF] Optimize DIEToType handling (PR #96308)

2024-06-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes - move type insertion from individual parse methods into ParseTypeFromDWARF - optimize sentinel (TYPE_IS_BEING_PARSED) insertion to avoid double map lookup - as this requires the map to not have nullptr values,

[Lldb-commits] [lldb] a083e50 - [lldb] Fix SBAddressRange validation checks. (#95997)

2024-06-21 Thread via lldb-commits
Author: Miro Bucko Date: 2024-06-21T11:24:48-04:00 New Revision: a083e50f53f0f9eb9ad0c5b65f3c627cf97043e6 URL: https://github.com/llvm/llvm-project/commit/a083e50f53f0f9eb9ad0c5b65f3c627cf97043e6 DIFF: https://github.com/llvm/llvm-project/commit/a083e50f53f0f9eb9ad0c5b65f3c627cf97043e6.diff LO

[Lldb-commits] [lldb] bf3e328 - [lldb] Unify Platform::ResolveExecutable (#96256)

2024-06-21 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-21T11:29:49-07:00 New Revision: bf3e3289d67cb0fe136b0660cac39c24c9f65069 URL: https://github.com/llvm/llvm-project/commit/bf3e3289d67cb0fe136b0660cac39c24c9f65069 DIFF: https://github.com/llvm/llvm-project/commit/bf3e3289d67cb0fe136b0660cac39c24c9f65069.d

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-06-21 Thread via lldb-commits
jeffreytan81 wrote: @ZequanWu, @labath, since this PR got reverted due to crash for `--gsimple-template-names`, do you guys have a timeline to revise a new version without crashing? I ask this because our internal customers have many forward declarations that are suffering from the slow defini

[Lldb-commits] [lldb] bfd263a - [lldb][ExpressionParser][NFCI] Add new DoPrepareForExecution interface to be implemented by language plugins (#96290)

2024-06-21 Thread via lldb-commits
Author: Michael Buch Date: 2024-06-22T07:20:13+01:00 New Revision: bfd263a34df5d3916eb8425bb070618324acabfa URL: https://github.com/llvm/llvm-project/commit/bfd263a34df5d3916eb8425bb070618324acabfa DIFF: https://github.com/llvm/llvm-project/commit/bfd263a34df5d3916eb8425bb070618324acabfa.diff

[Lldb-commits] [lldb] 599ca71 - [lldb] Merge CompilerContextKind::{Class, Struct} (#96145)

2024-06-23 Thread via lldb-commits
Author: Pavel Labath Date: 2024-06-24T08:56:21+02:00 New Revision: 599ca7165edcf7d226bd658c450801044b46ce7c URL: https://github.com/llvm/llvm-project/commit/599ca7165edcf7d226bd658c450801044b46ce7c DIFF: https://github.com/llvm/llvm-project/commit/599ca7165edcf7d226bd658c450801044b46ce7c.diff

[Lldb-commits] [lldb] 41a4db1 - [lldb/DWARF] Optimize DIEToType handling (#96308)

2024-06-24 Thread via lldb-commits
Author: Pavel Labath Date: 2024-06-24T13:35:16+02:00 New Revision: 41a4db1ba6591169069dd2352e00364d9113fbeb URL: https://github.com/llvm/llvm-project/commit/41a4db1ba6591169069dd2352e00364d9113fbeb DIFF: https://github.com/llvm/llvm-project/commit/41a4db1ba6591169069dd2352e00364d9113fbeb.diff

[Lldb-commits] [lldb] [lldb/DWARF] Remove parsing recursion when searching for definition DIEs (PR #96484)

2024-06-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes If ParseStructureLikeDIE (or ParseEnum) encountered a declaration DIE, it would call FindDefinitionTypeForDIE. This returned a fully formed type, which it achieved by recursing back into ParseStructureLikeDIE

[Lldb-commits] [lldb] 10bd5ad - [lldb][API] Add Find(Ranges)InMemory() to Process SB API (#95007)

2024-06-24 Thread via lldb-commits
Author: Miro Bucko Date: 2024-06-24T11:06:20-04:00 New Revision: 10bd5ad0a133fe73ffc1b05e63bc3fb2d56ba79c URL: https://github.com/llvm/llvm-project/commit/10bd5ad0a133fe73ffc1b05e63bc3fb2d56ba79c DIFF: https://github.com/llvm/llvm-project/commit/10bd5ad0a133fe73ffc1b05e63bc3fb2d56ba79c.diff LO

[Lldb-commits] [lldb] [lldb] Fix failing TestFind(Ranges)InMemory.py tests. (PR #96511)

2024-06-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Tests added in #95007. --- Full diff: https://github.com/llvm/llvm-project/pull/96511.diff 1 Files Affected: - (modified) lldb/test/API/python_api/find_in_memory/address_ranges_helper.py (-1) ``dif

[Lldb-commits] [lldb] 347206f - Add a unit test for SBBreakpoint::SetCallback (#96001)

2024-06-24 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-06-24T09:50:42-07:00 New Revision: 347206f9570446340da6d7dadc13d10b0aac4528 URL: https://github.com/llvm/llvm-project/commit/347206f9570446340da6d7dadc13d10b0aac4528 DIFF: https://github.com/llvm/llvm-project/commit/347206f9570446340da6d7dadc13d10b0aac4528.d

[Lldb-commits] [lldb] 3b5b814 - Add support for using foreign type units in .debug_names. (#87740)

2024-06-24 Thread via lldb-commits
Author: Greg Clayton Date: 2024-06-24T09:59:59-07:00 New Revision: 3b5b814647ef83ab763cf7871b6d74edfca67438 URL: https://github.com/llvm/llvm-project/commit/3b5b814647ef83ab763cf7871b6d74edfca67438 DIFF: https://github.com/llvm/llvm-project/commit/3b5b814647ef83ab763cf7871b6d74edfca67438.diff

[Lldb-commits] [lldb] a27164c - [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (#95312)

2024-06-24 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-06-24T10:48:01-07:00 New Revision: a27164cb33162bb42642c091703f9c6f8829785c URL: https://github.com/llvm/llvm-project/commit/a27164cb33162bb42642c091703f9c6f8829785c DIFF: https://github.com/llvm/llvm-project/commit/a27164cb33162bb42642c091703f9c6f8829785c.diff

[Lldb-commits] [lldb] 33a9c57 - [lldb] Fix failing TestFind(Ranges)InMemory.py tests. (#96511)

2024-06-24 Thread via lldb-commits
Author: Miro Bucko Date: 2024-06-24T11:38:05-07:00 New Revision: 33a9c57b89c3ea901a057c3fcc9c9160eaf5a625 URL: https://github.com/llvm/llvm-project/commit/33a9c57b89c3ea901a057c3fcc9c9160eaf5a625 DIFF: https://github.com/llvm/llvm-project/commit/33a9c57b89c3ea901a057c3fcc9c9160eaf5a625.diff LO

[Lldb-commits] [lldb] [lldb] Support new libc++ __compressed_pair layout (PR #96538)

2024-06-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 62baf21daa377c4ec1a641b26931063c1117d262...3b4d9629a68c9e75dfd139ee2745bf00db979ecd lldb/

[Lldb-commits] [lldb] Revert commits that add `TestFind(Ranges)InMemory.py` (PR #96560)

2024-06-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes Reverting to unblock macOS buildbots which are currently failing on these tests. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6377/ --- Patch is 28.12 KiB, truncated to 20.0

[Lldb-commits] [lldb] [LLDB][Minidump] Change expected directories to the correct type; size_t (PR #96564)

2024-06-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In !95312 I incorrectly set `m_expected_directories` to uint, this broke the windows build and is the incorrect type. `size_t` is more accurate because this value only ever represents the expected upper bo

[Lldb-commits] [lldb] [lldb] Fix tests for FindInMemory SB API introduced in #95007. (PR #96565)

2024-06-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/96565.diff 3 Files Affected: - (modified) lldb/test/API/python_api/find_in_memory/TestFindInMemory.py (+24-1) - (modified) lldb/test/API/python_api/f

[Lldb-commits] [lldb] a32b719 - Revert commits that add `TestFind(Ranges)InMemory.py` (#96560)

2024-06-24 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-06-24T15:12:49-07:00 New Revision: a32b7199f0c15ea1c6c9490b6166c019c9d4bd2b URL: https://github.com/llvm/llvm-project/commit/a32b7199f0c15ea1c6c9490b6166c019c9d4bd2b DIFF: https://github.com/llvm/llvm-project/commit/a32b7199f0c15ea1c6c9490b6166c019c9d4bd2b.d

[Lldb-commits] [lldb] [lldb][API] Add Find(Ranges)InMemory() to Process SB API (PR #96569)

2024-06-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes This is a second attempt to land #95007 Test Plan: llvm-lit llvm-project/lldb/test/API/python_api/find_in_memory/TestFindInMemory.py llvm-project/lldb/test/API/python_api/find_in_memory/TestFindRangesInMemory.p

[Lldb-commits] [lldb] 0d4da0d - [lldb][API] Add Find(Ranges)InMemory() to Process SB API (#96569)

2024-06-24 Thread via lldb-commits
Author: Miro Bucko Date: 2024-06-24T18:51:12-04:00 New Revision: 0d4da0df166ea7512c6e97e182b21cd706293eaa URL: https://github.com/llvm/llvm-project/commit/0d4da0df166ea7512c6e97e182b21cd706293eaa DIFF: https://github.com/llvm/llvm-project/commit/0d4da0df166ea7512c6e97e182b21cd706293eaa.diff LO

[Lldb-commits] [lldb] 361543e - [LLDB][Minidump] Change expected directories to the correct type; size_t (#96564)

2024-06-24 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-06-24T16:33:09-07:00 New Revision: 361543e4100defe14334cfb11481be44a977e627 URL: https://github.com/llvm/llvm-project/commit/361543e4100defe14334cfb11481be44a977e627 DIFF: https://github.com/llvm/llvm-project/commit/361543e4100defe14334cfb11481be44a977e627.diff

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-24 Thread via lldb-commits
cmtice wrote: > Haven't gone through this in detail yet (having an example of how these > structures will be used would be helpful), but something I was curious about > is whether this `DIL` is going to be used in the implementation of a new > command, or if we're going to extend the `frame va

[Lldb-commits] [lldb] 8395f9c - [lldb/DWARF] Remove parsing recursion when searching for definition DIEs (#96484)

2024-06-25 Thread via lldb-commits
Author: Pavel Labath Date: 2024-06-25T10:52:11+02:00 New Revision: 8395f9cecd34af8a79c96e661e46a80d0d471fb1 URL: https://github.com/llvm/llvm-project/commit/8395f9cecd34af8a79c96e661e46a80d0d471fb1 DIFF: https://github.com/llvm/llvm-project/commit/8395f9cecd34af8a79c96e661e46a80d0d471fb1.diff

[Lldb-commits] [lldb] [lldb][LibCxx] Move incorrect nullptr check (PR #96635)

2024-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Found this while skimming this code. Don't have a reproducible test case for this but the nullptr check should clearly occur before we try to dereference `location_sp`. --- Full diff: https://github.com/l

[Lldb-commits] [lldb] [lldb][test] Set target OS for API tests in case of remote testing (PR #96654)

2024-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes Makefile.rules uses HOST_OS and OS variables for determining host and target OSes for API tests compilation. When lldb's target is set to remote-linux, Makefile.rules script should be executed wit

[Lldb-commits] [lldb] e951bd0 - Reapply PR/87550 (again) (#95571)

2024-06-25 Thread via lldb-commits
Author: Vy Nguyen Date: 2024-06-25T12:01:17-04:00 New Revision: e951bd0f51f8b077296f09d9c60ddf150048042f URL: https://github.com/llvm/llvm-project/commit/e951bd0f51f8b077296f09d9c60ddf150048042f DIFF: https://github.com/llvm/llvm-project/commit/e951bd0f51f8b077296f09d9c60ddf150048042f.diff LOG

[Lldb-commits] [lldb] 21ab32e - [lldb][LibCxx] Move incorrect nullptr check (#96635)

2024-06-25 Thread via lldb-commits
Author: Michael Buch Date: 2024-06-25T19:05:16+01:00 New Revision: 21ab32e1c144b42458b7b3181e84bfb45aadcc54 URL: https://github.com/llvm/llvm-project/commit/21ab32e1c144b42458b7b3181e84bfb45aadcc54 DIFF: https://github.com/llvm/llvm-project/commit/21ab32e1c144b42458b7b3181e84bfb45aadcc54.diff

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

2024-06-25 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

2024-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kendal Harland (kendalharland) Changes This test is currently flaky on a local Windows amd64 build. If we print lldb's inputs and outputs while running, we can see that the breakpoints are always being set correctly, and always being hit:

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

2024-06-25 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

2024-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kendal Harland (kendalharland) Changes The strings this test is using seem to consistently fail to match against the expected values when built & run targeting Windows amd64. This PR updates them to the expected values. --- Full diff: htt

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

2024-06-25 Thread via lldb-commits
https://github.com/jeffreytan81 requested changes to this pull request. Have you tried to run this test on Linux? It is passing on my machine. I am pretty sure this might be Windows platform (like compiler and disassembler) specific behavior which you shouldn't change the default value for the

[Lldb-commits] [lldb] Removed header and validated on new windows machine (PR #96724)

2024-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes ![image](https://github.com/llvm/llvm-project/assets/25160653/2044cc8e-72d5-49ec-9439-256555f5fd2b) In #95312 uint and `#include ` were introduced. These broke the windows build. I addressed uint i

[Lldb-commits] [lldb] cb3469a - Removed header and validated on new windows machine (#96724)

2024-06-25 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-06-25T21:26:31-07:00 New Revision: cb3469a30f875b9cd54a263803fffc93554bec12 URL: https://github.com/llvm/llvm-project/commit/cb3469a30f875b9cd54a263803fffc93554bec12 DIFF: https://github.com/llvm/llvm-project/commit/cb3469a30f875b9cd54a263803fffc93554bec12.diff

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-09 Thread via lldb-commits
cmtice wrote: I think I have addressed all the review comments; please take another look. :-) https://github.com/llvm/llvm-project/pull/95738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-09 Thread via lldb-commits
@@ -0,0 +1,446 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Construct SmallVector with ArrayRef (NFC) (PR #102793)

2024-08-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/102793.diff 1 Files Affected: - (modified) lldb/include/lldb/Utility/UUID.h (+1-1) ``diff diff --git a/lldb/include/lldb/Utility/UU

[Lldb-commits] [lldb] 4134592 - [lldb] Construct SmallVector with ArrayRef (NFC) (#102793)

2024-08-11 Thread via lldb-commits
Author: Kazu Hirata Date: 2024-08-11T12:48:06-07:00 New Revision: 41345925f9393518be8029cfb1ea80cfeb5631b4 URL: https://github.com/llvm/llvm-project/commit/41345925f9393518be8029cfb1ea80cfeb5631b4 DIFF: https://github.com/llvm/llvm-project/commit/41345925f9393518be8029cfb1ea80cfeb5631b4.diff L

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-11 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Avoid calling DataLayout constructor accepting Module pointer (NFC) (PR #102839)

2024-08-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Sergei Barannikov (s-barannikov) Changes The constructor initializes `*this` with a copy of `M->getDataLayout()`, which can just be spelled as `DataLayout DL = M->getDataLayout()`. In all places where the constructor is used, Module outliv

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-12 Thread via lldb-commits
https://github.com/Dhruv-Srivastava-IBM converted_to_draft https://github.com/llvm/llvm-project/pull/102601 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-12 Thread via lldb-commits
https://github.com/Dhruv-Srivastava-IBM edited https://github.com/llvm/llvm-project/pull/102601 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 32a62eb - [lldb] Tolerate multiple compile units with the same DWO ID (#100577)

2024-08-12 Thread via lldb-commits
Author: Pavel Labath Date: 2024-08-12T11:29:08+02:00 New Revision: 32a62ebdeab0c10d5311cf812e021717636d4514 URL: https://github.com/llvm/llvm-project/commit/32a62ebdeab0c10d5311cf812e021717636d4514 DIFF: https://github.com/llvm/llvm-project/commit/32a62ebdeab0c10d5311cf812e021717636d4514.diff

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
https://github.com/xusheng6 created https://github.com/llvm/llvm-project/pull/102873 This fixes https://github.com/llvm/llvm-project/issues/56125 and https://github.com/vadimcn/codelldb/issues/666, as well as the downstream issue in our binary ninja debugger: https://github.com/Vector35/debugg

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: xusheng (xusheng6) Changes This fixes https://github.com/llvm/llvm-project/issues/56125 and https://github.com/vadimcn/codelldb/issues/666, as well as the downstream issue in our binary ninja debugger: https://github.com/Vector35/debugger/

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
https://github.com/xusheng6 edited https://github.com/llvm/llvm-project/pull/102873 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 55d7e59023bc48f97321970cda5e400c07de59fa 73c98df4baef99f96d9c67113ba2ed0d972e5a04 --e

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
https://github.com/xusheng6 updated https://github.com/llvm/llvm-project/pull/102873 >From 73c98df4baef99f96d9c67113ba2ed0d972e5a04 Mon Sep 17 00:00:00 2001 From: Xusheng Date: Mon, 20 Mar 2023 20:24:11 +0800 Subject: [PATCH 1/3] [lldb] Claim to support swbreak and hwbreak packets when debuggi

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
@@ -2349,6 +2349,9 @@ StateType ProcessGDBRemote::SetThreadStopInfo(StringExtractor &stop_packet) { if (!value.getAsInteger(0, addressing_bits)) { addressable_bits.SetHighmemAddressableBits(addressing_bits); } + } else if (key.compare("swbreak")

[Lldb-commits] [lldb] 21ef272 - [lldb/DWARF] Search fallback to the manual index in GetFullyQualified… (#102123)

2024-08-12 Thread via lldb-commits
Author: Pavel Labath Date: 2024-08-12T14:31:14+02:00 New Revision: 21ef272ec1974244710fc639f98674eae3f8b02c URL: https://github.com/llvm/llvm-project/commit/21ef272ec1974244710fc639f98674eae3f8b02c DIFF: https://github.com/llvm/llvm-project/commit/21ef272ec1974244710fc639f98674eae3f8b02c.diff

[Lldb-commits] [lldb] [lldb] Fix crash when adding members to an "incomplete" type (PR #102116)

2024-08-12 Thread via lldb-commits
llvmbot wrote: Failed to cherry-pick: [57cd100](https://github.com/llvm/llvm-project/commit/57cd1000c9c93fd0e64352cfbc9fbbe5b8a8fcef) https://github.com/llvm/llvm-project/actions/runs/10352006063 Please manually backport the fix and push it to your github fork. Once this is done, please cre

[Lldb-commits] [lldb] [lldb] Fix crash when adding members to an "incomplete" type (PR #102116)

2024-08-12 Thread via lldb-commits
llvmbot wrote: /pull-request llvm/llvm-project#102895 https://github.com/llvm/llvm-project/pull/102116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
https://github.com/xusheng6 updated https://github.com/llvm/llvm-project/pull/102873 >From 73c98df4baef99f96d9c67113ba2ed0d972e5a04 Mon Sep 17 00:00:00 2001 From: Xusheng Date: Mon, 20 Mar 2023 20:24:11 +0800 Subject: [PATCH 1/5] [lldb] Claim to support swbreak and hwbreak packets when debuggi

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
xusheng6 wrote: > Also there is probably a qsupported parsing function in lldb-server, please > add a comment there to say we consume lldb's swbreak/hwbreak feature but it > doesn't change the behaviour of lldb-server. Fixed in https://github.com/llvm/llvm-project/pull/102873/commits/d0851d4f

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
@@ -2353,6 +2353,10 @@ StateType ProcessGDBRemote::SetThreadStopInfo(StringExtractor &stop_packet) { uint32_t reg = UINT32_MAX; if (!key.getAsInteger(16, reg)) expedited_register_map[reg] = std::string(std::move(value)); + } else if (key.compare(

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
xusheng6 wrote: > On the testing, lldb sends this qsupported value regardless of what the > remote sends. So there's nothing to do there unless you just repeat the > feature list. There are some tests that look at lldb-server's qsupported > values, but I don't see any for the client lldb. > >

[Lldb-commits] [lldb] 82ee31f - [lldb] Updated lldb-server to spawn the child process and share socket (#101283)

2024-08-12 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-08-12T18:50:23+04:00 New Revision: 82ee31f75ac1316006fa9e21dddfddec37cf7072 URL: https://github.com/llvm/llvm-project/commit/82ee31f75ac1316006fa9e21dddfddec37cf7072 DIFF: https://github.com/llvm/llvm-project/commit/82ee31f75ac1316006fa9e21dddfddec37cf7072.dif

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitrii Galimzianov (DmT021) Changes When we search for a symbol, we first check if it is in the module_sp of the current SymbolContext, and if not, we check in the target's modules. However, the target's ModuleList also includes the alrea

[Lldb-commits] [lldb] f1e2886 - [LLDB] Impove ObjectFileELF's .dynamic parsing and usage. (#102570)

2024-08-12 Thread via lldb-commits
Author: Greg Clayton Date: 2024-08-12T10:57:04-07:00 New Revision: f1e2886261281e788e4faae406c24e787c1dbdd0 URL: https://github.com/llvm/llvm-project/commit/f1e2886261281e788e4faae406c24e787c1dbdd0 DIFF: https://github.com/llvm/llvm-project/commit/f1e2886261281e788e4faae406c24e787c1dbdd0.diff

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-08-12 Thread via lldb-commits
jeffreytan81 wrote: @labath, unfortunately the failing log does not provide much information to troubleshoot. Is it possible to gather more information of the failure? Like is it only this `lldb-x86_64-debian` bot timeout or including other bots? And is it consistently failing or occasionally

[Lldb-commits] [lldb] e26b42c - [lldb] Avoid calling DataLayout constructor accepting Module pointer (NFC) (#102839)

2024-08-12 Thread via lldb-commits
Author: Sergei Barannikov Date: 2024-08-12T21:46:47+03:00 New Revision: e26b42c70d37cbea47016984e1d2bfc347fb8818 URL: https://github.com/llvm/llvm-project/commit/e26b42c70d37cbea47016984e1d2bfc347fb8818 DIFF: https://github.com/llvm/llvm-project/commit/e26b42c70d37cbea47016984e1d2bfc347fb8818.d

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-12 Thread via lldb-commits
@@ -0,0 +1,459 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
https://github.com/xusheng6 updated https://github.com/llvm/llvm-project/pull/102873 >From 73c98df4baef99f96d9c67113ba2ed0d972e5a04 Mon Sep 17 00:00:00 2001 From: Xusheng Date: Mon, 20 Mar 2023 20:24:11 +0800 Subject: [PATCH 1/6] [lldb] Claim to support swbreak and hwbreak packets when debuggi

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-12 Thread via lldb-commits
xusheng6 wrote: > > or do we already have some infra that I can use? > > `lldb/test/API/functionalities/gdb_remote_client/TestStopPCs.py` is an > example of that infrastructure. The `threadStopInfo` is where you would > insert the swbreak hwbreak key. > > In fact, if i386 is an architecture w

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 55d7e59023bc48f97321970cda5e400c07de59fa...55f9473b8832723b96db45103bf4d5aa0b10da90 lldb/

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-13 Thread via lldb-commits
https://github.com/xusheng6 updated https://github.com/llvm/llvm-project/pull/102873 >From cdd4b8ce09fb536defb3df182e8b5ebf16ada685 Mon Sep 17 00:00:00 2001 From: Xusheng Date: Mon, 20 Mar 2023 20:24:11 +0800 Subject: [PATCH] [lldb] Claim to support swbreak and hwbreak packets when debugging a

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-13 Thread via lldb-commits
https://github.com/xusheng6 updated https://github.com/llvm/llvm-project/pull/102873 >From 51a356b384f28cce3b2cd874fbba139414b0e207 Mon Sep 17 00:00:00 2001 From: Xusheng Date: Mon, 20 Mar 2023 20:24:11 +0800 Subject: [PATCH] [lldb] Claim to support swbreak and hwbreak packets when debugging a

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-13 Thread via lldb-commits
@@ -10,13 +10,15 @@ class TestStopPCs(GDBRemoteTestBase): def test(self): class MyResponder(MockGDBServerResponder): def haltReason(self): -return "T02thread:1ff0d;threads:1ff0d,2ff0d;thread-pcs:10001bc00,10002bc00;" +ret

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-13 Thread via lldb-commits
@@ -3594,6 +3594,9 @@ rnb_err_t RNBRemote::HandlePacket_qSupported(const char *p) { reply << "SupportedWatchpointTypes=x86_64;"; #endif + // We consume lldb's swbreak/hwbreak feature, but it doesn't change the + // behaviour of lldb-server. We always adjust the program co

[Lldb-commits] [lldb] 5dbec8c - [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (#102873)

2024-08-13 Thread via lldb-commits
Author: xusheng Date: 2024-08-13T15:28:35+01:00 New Revision: 5dbec8c6ce473352cac2d89d6a5b81f65182df59 URL: https://github.com/llvm/llvm-project/commit/5dbec8c6ce473352cac2d89d6a5b81f65182df59 DIFF: https://github.com/llvm/llvm-project/commit/5dbec8c6ce473352cac2d89d6a5b81f65182df59.diff LOG:

[Lldb-commits] [lldb] [lldb][DWARFASTParser] Don't pass CompilerType by non-const reference in the DWARFASTParserClang APIs (PR #103245)

2024-08-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes The `CompilerType` is just a wrapper around two pointers, and there is no usage of the `CompilerType` where those are expected to change underneath the caller. To make the interface more straightforward to

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-13 Thread via lldb-commits
@@ -0,0 +1,459 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-13 Thread via lldb-commits
royitaqi wrote: Gentle ping. @jimingham and @labath Is there anything else you want me to improve/fix in this PR? > I think I have addressed all of your comments. > When you have the time, I will appreciate you taking another look cc @clayborg https://github.com/llvm/llvm-project/pull/102223

[Lldb-commits] [lldb] 494eec0 - [lldb][NFCI] Simplify ProcessElfCore::GetAuxvData() (#102263)

2024-08-13 Thread via lldb-commits
Author: Igor Kudrin Date: 2024-08-13T10:55:28-07:00 New Revision: 494eec0255d0e270ed877e960843177759f0ee73 URL: https://github.com/llvm/llvm-project/commit/494eec0255d0e270ed877e960843177759f0ee73 DIFF: https://github.com/llvm/llvm-project/commit/494eec0255d0e270ed877e960843177759f0ee73.diff L

[Lldb-commits] [clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

2024-08-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Kim Gräsman (kimgr) Changes When Clang is consumed as a library, the CLANG_RESOURCE_DIR definition is not exported from the CMake system, so external clients will be unable to compute the same resource dir as Clang itself would, be

[Lldb-commits] [clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

2024-08-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kim Gräsman (kimgr) Changes When Clang is consumed as a library, the CLANG_RESOURCE_DIR definition is not exported from the CMake system, so external clients will be unable to compute the same resource dir as Clang itself would, because t

[Lldb-commits] [clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

2024-08-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4377656f2419a8eb18c01e86929b689dcf22b5d6 102517cd9d53695c9ae56135492bab09df9d90ee --e

[Lldb-commits] [lldb] 28050e1 - [lldb][DWARFASTParser] Don't pass CompilerType by non-const reference in the DWARFASTParserClang APIs (#103245)

2024-08-13 Thread via lldb-commits
Author: Michael Buch Date: 2024-08-13T20:04:18+01:00 New Revision: 28050e1b0b9da6d9c24ba20e8c70cf90b8135f49 URL: https://github.com/llvm/llvm-project/commit/28050e1b0b9da6d9c24ba20e8c70cf90b8135f49 DIFF: https://github.com/llvm/llvm-project/commit/28050e1b0b9da6d9c24ba20e8c70cf90b8135f49.diff

<    12   13   14   15   16   17   18   19   20   21   >