[Lldb-commits] [lldb] [lldb][test] Add test for completing ObjCObjectType (PR #95405)

2024-06-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cece0a105b29dcbb9d88d0aa264c4745c07a8456 2e84cf46b9378307d9059aa1ce2a97046b0866b4 --

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [lld] [lldb] [llvm] [mlir] [openmp] [llvm-project] Fix typo "seperate" (PR #95373)

2024-06-13 Thread via lldb-commits
https://github.com/lntue approved this pull request. https://github.com/llvm/llvm-project/pull/95373 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-06-13 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/87197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9f70cd8 - [LLDB] Add more helper functions to ValueObject class. (#87197)

2024-06-13 Thread via lldb-commits
Author: cmtice Date: 2024-06-13T09:14:17-07:00 New Revision: 9f70cd83897b36e5628057dfef2855a0b9045766 URL: https://github.com/llvm/llvm-project/commit/9f70cd83897b36e5628057dfef2855a0b9045766 DIFF: https://github.com/llvm/llvm-project/commit/9f70cd83897b36e5628057dfef2855a0b9045766.diff LOG: [

[Lldb-commits] [lldb] 8f2a4e8 - [lldb] Support case-insensitive regex matches (#95350)

2024-06-13 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-13T09:37:02-07:00 New Revision: 8f2a4e83554abb2fb67f11d95428c3ff3147e88b URL: https://github.com/llvm/llvm-project/commit/8f2a4e83554abb2fb67f11d95428c3ff3147e88b DIFF: https://github.com/llvm/llvm-project/commit/8f2a4e83554abb2fb67f11d95428c3ff3147e88b.d

[Lldb-commits] [lldb] [LLDB][Windows] Fix watchpoints for Windows (PR #95446)

2024-06-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ffab938f50fa999f2218976f7de78cf8e4f70d4e 0053a9cfdd4637be0d52901b5d871ed1c43e06a1 --

[Lldb-commits] [lldb] [lldb][test] Force dwarf4 usage in test requiring it (PR #95449)

2024-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This test is explicitly checking for dwarf 4 behavior on Apple platforms, so we should explicitly use the dwarf4 flag. Related to https://github.com/llvm/llvm-project/pull/95164 --- Full

[Lldb-commits] [lldb] [LLDB][Windows] Fix watchpoints for Windows (PR #95446)

2024-06-13 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] d4a0154 - [llvm-project] Fix typo "seperate" (#95373)

2024-06-13 Thread via lldb-commits
Author: Jay Foad Date: 2024-06-13T20:20:27+01:00 New Revision: d4a0154902fb9b0611ed857134b26a64a1d5ad1e URL: https://github.com/llvm/llvm-project/commit/d4a0154902fb9b0611ed857134b26a64a1d5ad1e DIFF: https://github.com/llvm/llvm-project/commit/d4a0154902fb9b0611ed857134b26a64a1d5ad1e.diff LOG:

[Lldb-commits] [lldb] [LLDB][Windows] Fix watchpoints for Windows (PR #95446)

2024-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Aleksandr Korepanov (AlexK0) Changes Hello! Currently, watchpoints don't work on Windows (this can be reproduced with the existing tests). This patch fixes the related issues so that the tests and watchpoints start working. Here is the l

[Lldb-commits] [lldb] 00ed887 - [LLDB][Windows] Fix watchpoints for Windows (#95446)

2024-06-13 Thread via lldb-commits
Author: Aleksandr Korepanov Date: 2024-06-13T14:50:31-07:00 New Revision: 00ed887454f7d7522f3eac8549661e51f864a9a7 URL: https://github.com/llvm/llvm-project/commit/00ed887454f7d7522f3eac8549661e51f864a9a7 DIFF: https://github.com/llvm/llvm-project/commit/00ed887454f7d7522f3eac8549661e51f864a9a7

[Lldb-commits] [lldb] [LLDB][Windows] Fix watchpoints for Windows (PR #95446)

2024-06-13 Thread via lldb-commits
github-actions[bot] wrote: @AlexK0 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] 22ea97d - [lldb] Use packaging module instead of pkg_resources (#93712)

2024-06-13 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-13T16:00:12-07:00 New Revision: 22ea97d7bfd65abf68a68b13bf96ad69be23df54 URL: https://github.com/llvm/llvm-project/commit/22ea97d7bfd65abf68a68b13bf96ad69be23df54 DIFF: https://github.com/llvm/llvm-project/commit/22ea97d7bfd65abf68a68b13bf96ad69be23df54.d

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-13 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 1/6] Add --targets and --modules option to statistics dump --- lldb/i

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-13 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 1/7] Add --targets and --modules option to statistics dump --- lldb/i

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-13 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 1/9] Add --targets and --modules option to statistics dump --- lldb/i

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-13 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-13 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 01/10] Add --targets and --modules option to statistics dump --- lldb

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-13 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 01/11] Add --targets and --modules option to statistics dump --- lldb

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-13 Thread via lldb-commits
@@ -50,48 +60,75 @@ class MinidumpFileBuilder { ~MinidumpFileBuilder() = default; + lldb_private::Status AddHeaderAndCalculateDirectories(); // Add SystemInfo stream, used for storing the most basic information // about the system, platform etc... - lldb_private::St

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-13 Thread via lldb-commits
@@ -50,48 +60,75 @@ class MinidumpFileBuilder { ~MinidumpFileBuilder() = default; + lldb_private::Status AddHeaderAndCalculateDirectories(); // Add SystemInfo stream, used for storing the most basic information // about the system, platform etc... - lldb_private::St

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-13 Thread via lldb-commits
@@ -59,39 +68,67 @@ class MinidumpFileBuilder { // Add ThreadList stream, containing information about all threads running // at the moment of core saving. Contains information about thread // contexts. - lldb_private::Status AddThreadList(const lldb::ProcessSP &process_

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-13 Thread via lldb-commits
@@ -480,42 +557,32 @@ class ArchThreadContexts { } }; -// Function returns start and size of the memory region that contains -// memory location pointed to by the current stack pointer. -llvm::Expected> -findStackHelper(const lldb::ProcessSP &process_sp, uint64_t rsp) { - M

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-13 Thread via lldb-commits
@@ -797,20 +794,89 @@ void MinidumpFileBuilder::AddLinuxFileStreams( } } -Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { - constexpr size_t header_size = sizeof(llvm::minidump::Header); - constexpr size_t directory_size = sizeof(llvm::minidump::Directory

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-13 Thread via lldb-commits
@@ -50,48 +60,75 @@ class MinidumpFileBuilder { ~MinidumpFileBuilder() = default; + lldb_private::Status AddHeaderAndCalculateDirectories(); // Add SystemInfo stream, used for storing the most basic information // about the system, platform etc... - lldb_private::St

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-13 Thread via lldb-commits
@@ -65,56 +66,52 @@ bool ObjectFileMinidump::SaveCore(const lldb::ProcessSP &process_sp, if (!process_sp) return false; - MinidumpFileBuilder builder; - - Target &target = process_sp->GetTarget(); - - Log *log = GetLog(LLDBLog::Object); - error = builder.AddSystemIn

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-13 Thread via lldb-commits
@@ -65,56 +66,52 @@ bool ObjectFileMinidump::SaveCore(const lldb::ProcessSP &process_sp, if (!process_sp) return false; - MinidumpFileBuilder builder; - - Target &target = process_sp->GetTarget(); - - Log *log = GetLog(LLDBLog::Object); - error = builder.AddSystemIn

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-13 Thread via lldb-commits
@@ -50,48 +60,75 @@ class MinidumpFileBuilder { ~MinidumpFileBuilder() = default; + lldb_private::Status AddHeaderAndCalculateDirectories(); jeffreytan81 wrote: I would add comment to clarify that this is partially done and which fields require later fix

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-13 Thread via lldb-commits
jeffreytan81 wrote: Can this be landed safely? Do we need to update consumer side to support memory list 64? For example, if this diff is landed, and a user tries to save a minidump with memory list 64, if there is no consumer side support, will lldb crash? https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] f2d215f - [lldb][TypeSystemClang][NFCI] Factor completion logic for individual types out of GetCompleteQualType (#95402)

2024-06-13 Thread via lldb-commits
Author: Michael Buch Date: 2024-06-14T07:20:50+01:00 New Revision: f2d215f572affc9ad73da07763ce1831de7f2d4d URL: https://github.com/llvm/llvm-project/commit/f2d215f572affc9ad73da07763ce1831de7f2d4d DIFF: https://github.com/llvm/llvm-project/commit/f2d215f572affc9ad73da07763ce1831de7f2d4d.diff

[Lldb-commits] [lldb] b650764 - [lldb][test] Add test for completing ObjCObjectType (#95405)

2024-06-14 Thread via lldb-commits
Author: Michael Buch Date: 2024-06-14T11:49:12+01:00 New Revision: b650764b16b5c8790325775ac5f87f0b1c0beca7 URL: https://github.com/llvm/llvm-project/commit/b650764b16b5c8790325775ac5f87f0b1c0beca7 DIFF: https://github.com/llvm/llvm-project/commit/b650764b16b5c8790325775ac5f87f0b1c0beca7.diff

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-06-14 Thread via lldb-commits
https://github.com/ita-sc updated https://github.com/llvm/llvm-project/pull/90075 >From a6e96025f399b27395778656aa720ea97d3d1e92 Mon Sep 17 00:00:00 2001 From: Ivan Tetyushkin Date: Fri, 7 Jun 2024 11:23:24 +0300 Subject: [PATCH] [lldb][riscv] Fix setting breakpoint for undecoded instruction

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-06-14 Thread via lldb-commits
@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { LLDB_INVALID_ADDRESS); } +static int GetSoftwareBreakpointSize(const ArchSpec &arch, + lldb::addr_t ne

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-06-14 Thread via lldb-commits
@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { LLDB_INVALID_ADDRESS); } +static int GetSoftwareBreakpointSize(const ArchSpec &arch, + lldb::addr_t ne

[Lldb-commits] [lldb] Reapply PR/87550 (again) (PR #95571)

2024-06-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vy Nguyen (oontvoo) Changes New fixes: - properly init the `std::optional` to an empty vector as opposed to `{}` (which was effectively `std::nullopt`). --- Full diff: https://github.com/llvm/llvm-project/pull/95571.diff 7

[Lldb-commits] [lldb] Reapply PR/87550 (again) (PR #95571)

2024-06-14 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[Lldb-commits] [lldb] Reapply PR/87550 (again) (PR #95571)

2024-06-14 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bbe9119d9cb37662faafe7fe273e792b1b70145e ac59dccc8f0c9d75ceca2cc4019535426301211a --

[Lldb-commits] [lldb] [lldb] Tweak Python interpreter workaround on macOS (PR #95582)

2024-06-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Avoid copying the Python interpreter when running in a virtual environment as it will already have its own copy of the Python interpreter. Also leave a breadcrumb that we're running with a different

[Lldb-commits] [lldb] 4368726 - [lldb] Tweak Python interpreter workaround on macOS (#95582)

2024-06-14 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-14T11:52:27-07:00 New Revision: 436872693a8a57487bf4510437183878d1e35cfb URL: https://github.com/llvm/llvm-project/commit/436872693a8a57487bf4510437183878d1e35cfb DIFF: https://github.com/llvm/llvm-project/commit/436872693a8a57487bf4510437183878d1e35cfb.d

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-14 Thread via lldb-commits
https://github.com/thetruestblue created https://github.com/llvm/llvm-project/pull/95586 Currently, the instrumentation runtime is caching a library the first time it sees it in the module list. However, in some rare cases on Darwin, the cached pre-run unloaded modules are different from the r

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-14 Thread via lldb-commits
https://github.com/thetruestblue updated https://github.com/llvm/llvm-project/pull/95586 >From db161e5c87eecbd5607f78e7afd00af183aa415c Mon Sep 17 00:00:00 2001 From: Blue Gaston Date: Fri, 14 Jun 2024 12:53:27 -0400 Subject: [PATCH] [LLDB] Don't cache module sp when Activate() fails. Currentl

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-14 Thread via lldb-commits
https://github.com/thetruestblue closed https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-14 Thread via lldb-commits
https://github.com/thetruestblue reopened https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-14 Thread via lldb-commits
https://github.com/thetruestblue ready_for_review https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (thetruestblue) Changes Currently, the instrumentation runtime is caching a library the first time it sees it in the module list. However, in some rare cases on Darwin, the cached pre-run unloaded modules are different from the runtim

[Lldb-commits] [lldb] 445fc51 - [lldb][test] Force dwarf4 usage in test requiring it (#95449)

2024-06-14 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2024-06-14T12:40:30-07:00 New Revision: 445fc51800d391d0c912d8c6c918b016e0604319 URL: https://github.com/llvm/llvm-project/commit/445fc51800d391d0c912d8c6c918b016e0604319 DIFF: https://github.com/llvm/llvm-project/commit/445fc51800d391d0c912d8c6c918b016e

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

2024-06-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Currently, two SupportFiles with the same FileSpec are considered different if one of them has a Checksum and the other doesn't. However, this is overly strict. It's totally valid to mix LineTables

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

2024-06-14 Thread via lldb-commits
https://github.com/jimingham approved this pull request. The previous check does seem overly restrictive. LGTM https://github.com/llvm/llvm-project/pull/95606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] 19ad7a0 - [lldb] Fix the semantics of SupportFile equivalence (#95606)

2024-06-14 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-14T14:25:03-07:00 New Revision: 19ad7a046b5cf435ba95c100170fc0e36231d620 URL: https://github.com/llvm/llvm-project/commit/19ad7a046b5cf435ba95c100170fc0e36231d620 DIFF: https://github.com/llvm/llvm-project/commit/19ad7a046b5cf435ba95c100170fc0e36231d620.d

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-14 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM I also looked at this a bit, and couldn't come up with a reliable way to write a test. https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-14 Thread via lldb-commits
@@ -60,6 +60,8 @@ void InstrumentationRuntime::ModulesDidLoad( if (CheckIfRuntimeIsValid(module_sp)) { SetRuntimeModuleSP(module_sp); Activate(); +if (IsActive()) + SetRuntimeModuleSP({}); // Don't cache module if activation failed. --

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-14 Thread via lldb-commits
https://github.com/thetruestblue updated https://github.com/llvm/llvm-project/pull/95586 >From db161e5c87eecbd5607f78e7afd00af183aa415c Mon Sep 17 00:00:00 2001 From: Blue Gaston Date: Fri, 14 Jun 2024 12:53:27 -0400 Subject: [PATCH 1/2] [LLDB] Don't cache module sp when Activate() fails. Curr

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-14 Thread via lldb-commits
https://github.com/thetruestblue edited https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove SupportFile::Update and use the original Checksum (PR #95623)

2024-06-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes When Jason was looking into the issue caused by #95606 he suggested using the Checksum from the original file in LineEntry. I like the idea because it makes sense semantically, but also allows us to

[Lldb-commits] [lldb] 8f74725 - [lldb] Adds additional fields to ProcessInfo (#91544)

2024-06-14 Thread via lldb-commits
Author: Fred Grim Date: 2024-06-14T18:30:23-07:00 New Revision: 8f74725731bf431fb97929e1dd962e9a0db20865 URL: https://github.com/llvm/llvm-project/commit/8f74725731bf431fb97929e1dd962e9a0db20865 DIFF: https://github.com/llvm/llvm-project/commit/8f74725731bf431fb97929e1dd962e9a0db20865.diff LOG

[Lldb-commits] [lldb] [LLDB] Remove the redundent increment of 'properties' variable (PR #95675)

2024-06-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes This is described in (N3) https://pvs-studio.com/en/blog/posts/cpp/1126/ so caught by the PVS Studio analyzer. Warning message - V547 Expression 'properties ++ > 0' is always false. CommandObjectTarget.cpp:100

[Lldb-commits] [lldb] ef01c75 - [lldb] Remove dead code block (NFC) (#94775)

2024-06-15 Thread via lldb-commits
Author: Shivam Gupta Date: 2024-06-15T23:39:58+05:30 New Revision: ef01c75d467df92b8c659307595aa74ed2290cd8 URL: https://github.com/llvm/llvm-project/commit/ef01c75d467df92b8c659307595aa74ed2290cd8 DIFF: https://github.com/llvm/llvm-project/commit/ef01c75d467df92b8c659307595aa74ed2290cd8.diff

[Lldb-commits] [lldb] [lldb] Correct format specifier for sscanf to prevent buffer overflow (NFC) (PR #94783)

2024-06-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ef01c75d467df92b8c659307595aa74ed2290cd8 17d39d89ee723881063ecbea19caaa6806e4e095 --

[Lldb-commits] [lldb] [LLDB] Add an assert to verify sign_bit_pos is within the valid range (NFC) (PR #95678)

2024-06-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/95678.diff 1 Files Affected: - (modified) lldb/source/Utility/Scalar.cpp (+15-16) ``diff diff --git a/lldb/source/Utility/Scalar.cpp b/lld

[Lldb-commits] [lldb] [LLDB] Remove dead code (NFC) (PR #95713)

2024-06-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes The dead code is caught by PVS studio analyzer - https://pvs-studio.com/en/blog/posts/cpp/1126/, fragment N12. Warning message - V523 The 'then' statement is equivalent to the 'else' statement. Options.cpp 121

[Lldb-commits] [lldb] e4e350e - [LLDB] Remove dead code (NFC) (#95713)

2024-06-16 Thread via lldb-commits
Author: Shivam Gupta Date: 2024-06-17T09:56:01+05:30 New Revision: e4e350e85b377e424299d26937cc60ea6868900c URL: https://github.com/llvm/llvm-project/commit/e4e350e85b377e424299d26937cc60ea6868900c DIFF: https://github.com/llvm/llvm-project/commit/e4e350e85b377e424299d26937cc60ea6868900c.diff

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-16 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/95738 …uage (DIL). The Data Inspection Language (DIL), described in https://discourse.llvm.org/t/rfc-data-inspection-language/69893 includes its own parser and expression evaluator. This change defines the AST nodes,

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes …uage (DIL). The Data Inspection Language (DIL), described in https://discourse.llvm.org/t/rfc-data-inspection-language/69893 includes its own parser and expression evaluator. This change defines the AST nodes, class

[Lldb-commits] [lldb] f838f08 - [lldb] Add register field enum class (#90063)

2024-06-17 Thread via lldb-commits
Author: David Spickett Date: 2024-06-17T11:53:31+01:00 New Revision: f838f08c8def5f49001bba9dc4f682baef04cd14 URL: https://github.com/llvm/llvm-project/commit/f838f08c8def5f49001bba9dc4f682baef04cd14 DIFF: https://github.com/llvm/llvm-project/commit/f838f08c8def5f49001bba9dc4f682baef04cd14.diff

[Lldb-commits] [lldb] [lldb] Parse and display register field enums (PR #95768)

2024-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This teaches lldb to parse the enum XML elements sent by lldb-server, and make use of the information in `register read` and `register info`. The format is described in https://sourceware.org/gdb/curr

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add packaging to testing requirements.txt (PR #95806)

2024-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes To fix CI after https://github.com/llvm/llvm-project/pull/93712 landed. --- Full diff: https://github.com/llvm/llvm-project/pull/95806.diff 1 Files Affected: - (modified) lldb/test/requirements.txt

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 01/12] Add --targets and --modules option to statistics dump --- lldb

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 01/13] Add --targets and --modules option to statistics dump --- lldb

[Lldb-commits] [lldb] 13c6638 - [lldb] Add packaging to testing requirements.txt (#95806)

2024-06-17 Thread via lldb-commits
Author: David Spickett Date: 2024-06-17T17:14:06+01:00 New Revision: 13c66388db650d7766b5eb63c09ef84bb5c9e9b8 URL: https://github.com/llvm/llvm-project/commit/13c66388db650d7766b5eb63c09ef84bb5c9e9b8 DIFF: https://github.com/llvm/llvm-project/commit/13c66388db650d7766b5eb63c09ef84bb5c9e9b8.diff

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3380644 - [lldb] Remove SupportFile::Update and use the original Checksum (#95623)

2024-06-17 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-17T09:37:44-07:00 New Revision: 3380644fb070fd6648e873b1e75022bdfc432f1f URL: https://github.com/llvm/llvm-project/commit/3380644fb070fd6648e873b1e75022bdfc432f1f DIFF: https://github.com/llvm/llvm-project/commit/3380644fb070fd6648e873b1e75022bdfc432f1f.d

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

2024-06-17 Thread via lldb-commits
cmtice wrote: Just a reminder: Once we complete the work of adding type units to the merged debug_names index, foreign type unit entries will need (and have) DW_IDX_compile_unit values, even in the case without .dwp files, and will need to be handled properly. So that should be kept in mind wh

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
@@ -133,7 +133,9 @@ struct ConstStringStats { struct StatisticsOptions { bool summary_only = false; bool load_all_debug_info = false; - bool include_transcript = false; + bool include_targets = true; + bool include_modules = true; royitaqi wrote: Right

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 01/14] Add --targets and --modules option to statistics dump --- lldb

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 01/15] Add --targets and --modules option to statistics dump --- lldb

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add/change options in "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Convert ValueObject::Dump() to return llvm::Error() (NFCish) (PR #95857)

2024-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes This change by itself has no measurable effect on the LLDB testsuite. I'm making it in preparation for threading through more errors in the Swift language plugin. --- Patch is 20.56 KiB, truncated to

[Lldb-commits] [lldb] Convert ValueObject::Dump() to return llvm::Error() (NFCish) (PR #95857)

2024-06-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 6c17f1cabdee3399feceb478921a8369bde18b16...7e3d1420a941431de223098ee153d2d4c63cfbfc lldb/

[Lldb-commits] [lldb] [lldb] Suppress unsupported language warning for assembly (PR #95871)

2024-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The following warning is technically correct, but pretty much useless, since there aren't any frame variables that we'd expect the debugger to understand. > This version of LLDB has no plugin for th

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-17 Thread via lldb-commits
https://github.com/thetruestblue updated https://github.com/llvm/llvm-project/pull/95586 >From db161e5c87eecbd5607f78e7afd00af183aa415c Mon Sep 17 00:00:00 2001 From: Blue Gaston Date: Fri, 14 Jun 2024 12:53:27 -0400 Subject: [PATCH 1/2] [LLDB] Don't cache module sp when Activate() fails. Curr

[Lldb-commits] [lldb] [lldb/DWARF] Fix type definition search with simple template names (PR #95905)

2024-06-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes With simple template names the template arguments aren't embedded in the DW_AT_name attribute of the type. The code in FindDefinitionTypeForDWARFDeclContext was comparing the synthesized template arguments on

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-18 Thread via lldb-commits
https://github.com/thetruestblue updated https://github.com/llvm/llvm-project/pull/95586 >From db161e5c87eecbd5607f78e7afd00af183aa415c Mon Sep 17 00:00:00 2001 From: Blue Gaston Date: Fri, 14 Jun 2024 12:53:27 -0400 Subject: [PATCH 1/2] [LLDB] Don't cache module sp when Activate() fails. Curr

[Lldb-commits] [lldb] 41f6aee - [LLDB] Don't cache module sp when Activate() fails. (#95586)

2024-06-18 Thread via lldb-commits
Author: thetruestblue Date: 2024-06-18T07:23:28-07:00 New Revision: 41f6aee769a900558e58eba7b5f9044f8f8a05b7 URL: https://github.com/llvm/llvm-project/commit/41f6aee769a900558e58eba7b5f9044f8f8a05b7 DIFF: https://github.com/llvm/llvm-project/commit/41f6aee769a900558e58eba7b5f9044f8f8a05b7.diff

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-18 Thread via lldb-commits
https://github.com/thetruestblue closed https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fcee033 - [lldb] Suppress unsupported language warning for assembly (#95871)

2024-06-18 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-18T08:51:40-07:00 New Revision: fcee0333bab6747ca34188f3a781f4fef900b7fe URL: https://github.com/llvm/llvm-project/commit/fcee0333bab6747ca34188f3a781f4fef900b7fe DIFF: https://github.com/llvm/llvm-project/commit/fcee0333bab6747ca34188f3a781f4fef900b7fe.d

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-06-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vincent Belliard (v-bulle) Changes Adds GetSyntheticValue to the API on top of GetNonSyntheticValue. --- Full diff: https://github.com/llvm/llvm-project/pull/95959.diff 2 Files Affected: - (modified) lldb/include/lldb/API/SBValue.h (+2)

[Lldb-commits] [lldb] [lldb][ObjC] Don't query objective-c runtime for decls in C++ contexts (PR #95963)

2024-06-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes When LLDB isn't able to find a `clang::Decl` in response to a `FindExternalVisibleDeclsByName`, it will fall-back to looking into the Objective-C runtime for that decl. This ends up doing a lot of work whi

[Lldb-commits] [lldb] [lldb][ObjC] Don't query objective-c runtime for decls in C++ contexts (PR #95963)

2024-06-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r b650764b16b5c8790325775ac5f87f0b1c0beca7...25e64a8a622496cbde447d0d5185f0e7ef06586d lldb

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-18 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/95738 >From c703c473147e3e554a98014319294668a0ec790d Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 16 Jun 2024 16:32:47 -0700 Subject: [PATCH 1/2] [LLDB] Add AST node classes, functions, etc. for Data Inspect

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-18 Thread via lldb-commits
@@ -0,0 +1,165 @@ +(* LLDB Debug Expressions, a subset of C++ *) +(* Insired by https://www.nongnu.org/hcb *) + +expression = assignment_expression ; + +assignment_expression = conditional_expression +logical_or_expression assignment_operator assignment_ex

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-18 Thread via lldb-commits
@@ -0,0 +1,165 @@ +(* LLDB Debug Expressions, a subset of C++ *) +(* Insired by https://www.nongnu.org/hcb *) + +expression = assignment_expression ; + +assignment_expression = conditional_expression +logical_or_expression assignment_operator assignment_ex

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-18 Thread via lldb-commits
@@ -0,0 +1,165 @@ +(* LLDB Debug Expressions, a subset of C++ *) +(* Insired by https://www.nongnu.org/hcb *) + +expression = assignment_expression ; + +assignment_expression = conditional_expression +logical_or_expression assignment_operator assignment_ex

[Lldb-commits] [lldb] Convert ValueObject::Dump() to return llvm::Error() (NFCish) (PR #95857)

2024-06-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6c17f1cabdee3399feceb478921a8369bde18b16 ff10ee2e39740e6b8491a9f5bdcb2f4af657fa65 --e

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-06-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes 1. This commit adds LLDB_PLATFORM_URL, LLDB_TEST_SYSROOT, LLDB_PLATFORM_WORKING_DIR cmake flags to pass arguments for cross-compilation and remote running of both Shell&API tests. 2. To run Sh

<    11   12   13   14   15   16   17   18   19   20   >