[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in Platform/Android/PlatformAndroid.cpp (PR #94785)

2024-06-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:290:19: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [us

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/94786 This is useful if you have a transcript of a user session and want to rerun those commands with RunCommandInterpreter. The same functionality is also useful in testing. I'm adding it primarily for the second

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes This is useful if you have a transcript of a user session and want to rerun those commands with RunCommandInterpreter. The same functionality is also useful in testing. I'm adding it primarily for the second reas

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b653357141030620ce3e70ea939efbcb71d40657 bcd8c81c5fbc249886c53d8a2d1bc21a3f9e1ffd --

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r b653357141030620ce3e70ea939efbcb71d40657...bcd8c81c5fbc249886c53d8a2d1bc21a3f9e1ffd lldb/

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/94786 >From bcd8c81c5fbc249886c53d8a2d1bc21a3f9e1ffd Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 7 Jun 2024 11:17:26 -0700 Subject: [PATCH 1/2] Add AllowRepeats to SBCommandInterpreterRunOptions. This is us

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
@@ -93,15 +93,20 @@ class CommandInterpreterRunOptions { /// \param[in] add_to_history ///If \b true add the commands to the command history. If \b false, don't ///add them. + /// \param[in] process_repeats + ///If \b true then process empty lines as repeat

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
@@ -93,15 +93,20 @@ class CommandInterpreterRunOptions { /// \param[in] add_to_history ///If \b true add the commands to the command history. If \b false, don't ///add them. + /// \param[in] process_repeats + ///If \b true then process empty lines as repeat

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/94786 >From bcd8c81c5fbc249886c53d8a2d1bc21a3f9e1ffd Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 7 Jun 2024 11:17:26 -0700 Subject: [PATCH 1/3] Add AllowRepeats to SBCommandInterpreterRunOptions. This is us

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
@@ -93,15 +93,20 @@ class CommandInterpreterRunOptions { /// \param[in] add_to_history ///If \b true add the commands to the command history. If \b false, don't ///add them. + /// \param[in] process_repeats + ///If \b true then process empty lines as repeat

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

2024-06-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Julian Lettner (yln) Changes Use `Address` (instead of `addr_t`) to setup breakpoint in `ReportRetriever::SetupBreakpoint`. This is cleaner and the breakpoint should now survive re-running of the binary. rdar://124399066 --- Full diff: htt

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

2024-06-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b01ac5137c28fa5e1b44a5d850cb7a6ace7d8799 dd02ca52d3cdad42c549bf66b4c05aca8fa93f62 --

[Lldb-commits] [lldb] 96d01a3 - [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (#94679)

2024-06-07 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-07T13:48:17-07:00 New Revision: 96d01a350ce9875a8f893ecdc1d470caf7ed5bcd URL: https://github.com/llvm/llvm-project/commit/96d01a350ce9875a8f893ecdc1d470caf7ed5bcd DIFF: https://github.com/llvm/llvm-project/commit/96d01a350ce9875a8f893ecdc1d470caf7ed5bcd.d

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/94786 >From bcd8c81c5fbc249886c53d8a2d1bc21a3f9e1ffd Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 7 Jun 2024 11:17:26 -0700 Subject: [PATCH 1/4] Add AllowRepeats to SBCommandInterpreterRunOptions. This is us

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
@@ -182,6 +187,11 @@ class CommandInterpreterRunOptions { void SetSpawnThread(bool spawn_thread) { m_spawn_thread = spawn_thread ? eLazyBoolYes : eLazyBoolNo; } + bool GetAllowRepeats() const { return DefaultToNo(m_allow_repeats); } jimingham wrote: d

[Lldb-commits] [lldb] 435dd97 - Add AllowRepeats to SBCommandInterpreterRunOptions. (#94786)

2024-06-07 Thread via lldb-commits
Author: jimingham Date: 2024-06-07T17:05:29-07:00 New Revision: 435dd9746107e13c2ad019be3bd34815f7d2360d URL: https://github.com/llvm/llvm-project/commit/435dd9746107e13c2ad019be3bd34815f7d2360d DIFF: https://github.com/llvm/llvm-project/commit/435dd9746107e13c2ad019be3bd34815f7d2360d.diff LOG

[Lldb-commits] [lldb] Add AllowRepeats to SBCommandInterpreterRunOptions. (PR #94786)

2024-06-07 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/94786 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability for Script based commands to specify their "repeat command" (PR #94823)

2024-06-07 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/94823 Among other things, returning an empty string as the repeat command disables auto-repeat, which can be useful for state-changing commands. There's one remaining refinement to this setup, which is that for pars

[Lldb-commits] [lldb] Add the ability for Script based commands to specify their "repeat command" (PR #94823)

2024-06-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 435dd9746107e13c2ad019be3bd34815f7d2360d...c2fea75364a0017be5e59020467d661bd00122ba lldb/

[Lldb-commits] [lldb] Add the ability for Script based commands to specify their "repeat command" (PR #94823)

2024-06-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 435dd9746107e13c2ad019be3bd34815f7d2360d c2fea75364a0017be5e59020467d661bd00122ba --

[Lldb-commits] [lldb] Add the ability for Script based commands to specify their "repeat command" (PR #94823)

2024-06-07 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/94823 >From c2fea75364a0017be5e59020467d661bd00122ba Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 7 Jun 2024 17:36:34 -0700 Subject: [PATCH 1/2] Add the ability for Script based commands to specify their "re

[Lldb-commits] [lldb] [lldb] Remove redundant c_str() calls in stream output (NFC) (PR #94839)

2024-06-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes Passing the result of c_str() to a stream is slow and redundant. This change removes unnecessary c_str() calls and uses the string object directly. Caught by cppcheck - lldb/tools/debugserver/source/JSON.cpp:3

[Lldb-commits] [lldb] [lldb] Use const reference for range variables to improve performance (NFC) (PR #94840)

2024-06-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes Cppcheck recommends using a const reference for range variables in a for-each loop. This avoids unnecessary copying of elements, improving performance. Caught by cppcheck - lldb/source/API/SBBreakpoint.cpp:717

[Lldb-commits] [lldb] [lldb] Fix redundant condition in compression type check (NFC) (PR #94841)

2024-06-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes The `else if` condition for checking `m_compression_type` is redundant as it matches with a previous `if` condition, making the expression always false. Reported by cppcheck as a possible cut-and-paste error.

[Lldb-commits] [lldb] [lldb] Fix redundant condition in compression type check (NFC) (PR #94841)

2024-06-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ac404632f991fc6e7dc75ef553a99676ba8002ce 5451d769f36528e9640e665d4124103a6c34bf20 --

[Lldb-commits] [lldb] [lldb] Remove redundant condition in watch mask check (NFC) (PR #94842)

2024-06-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes This issue is reported by cppcheck as a pointless test in the watch mask check. The `else if` condition is opposite to the previous `if` condition, making the expression always true. Caught by cppcheck - lldb

[Lldb-commits] [lldb] [lldb] Adjust the for loop condition to prevent unintended increments in ExpandRLE (NFC) (PR #94844)

2024-06-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes This PR address the issue reported by static analyser cppcheck regarding missing bounds check for extra iterator increment in a loop. This could lead to accessing out-of-bounds memory. To fix this we have adj

[Lldb-commits] [lldb] d3fc5cf - [lldb] Remove redundant c_str() calls in stream output (NFC) (#94839)

2024-06-07 Thread via lldb-commits
Author: Shivam Gupta Date: 2024-06-08T12:02:01+05:30 New Revision: d3fc5cf24a93003ba963fc406aa1901a292d55f4 URL: https://github.com/llvm/llvm-project/commit/d3fc5cf24a93003ba963fc406aa1901a292d55f4 DIFF: https://github.com/llvm/llvm-project/commit/d3fc5cf24a93003ba963fc406aa1901a292d55f4.diff

[Lldb-commits] [lldb] Fix type lookup bug where wrong decl context was being used for a DIE. (PR #94846)

2024-06-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes The function that calculated the declaration context for a DIE was incorrectly transparently traversing acrosss DW_TAG_subprogram dies when climbing the parent DIE chain. This meant that types defined in fun

[Lldb-commits] [lldb] Fix type lookup bug where wrong decl context was being used for a DIE. (PR #94846)

2024-06-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5aabbf0602c48b67bb89fd37f95bf97c95ded488 2f579ecafeaeb735cbce1bcfc829eb52a93f067c --

[Lldb-commits] [lldb] Fix type lookup bug where wrong decl context was being used for a DIE. (PR #94846)

2024-06-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 5aabbf0602c48b67bb89fd37f95bf97c95ded488...2f579ecafeaeb735cbce1bcfc829eb52a93f067c lldb/

[Lldb-commits] [lldb] Fix type lookup bug where wrong decl context was being used for a DIE. (PR #94846)

2024-06-08 Thread via lldb-commits
@@ -0,0 +1,69 @@ +""" +Test the SBModule and SBTarget type lookup APIs to find multiple types. +""" + +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TypeFindFirstTestCase(TestBase): +def test_find_first_type(self): +

[Lldb-commits] [lldb] Fix type lookup bug where wrong decl context was being used for a DIE. (PR #94846)

2024-06-08 Thread via lldb-commits
https://github.com/kusmour approved this pull request. Seems there's formatter issue and a nit. Other than that LGTM :) https://github.com/llvm/llvm-project/pull/94846 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] Fix type lookup bug where wrong decl context was being used for a DIE. (PR #94846)

2024-06-08 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/94846 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix type lookup bug where wrong decl context was being used for a DIE. (PR #94846)

2024-06-08 Thread via lldb-commits
@@ -0,0 +1,69 @@ +""" +Test the SBModule and SBTarget type lookup APIs to find multiple types. +""" + +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TypeFindFirstTestCase(TestBase): +def test_find_first_type(self): +

[Lldb-commits] [lldb] [lldb] Fix TestModuleLoadedNotifys API test to work correctly on most of Linux targets (PR #94672)

2024-06-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff fb0c705dbf27e3ab84d726ad30e172806a530c21 6fb19a05a6a4fb4463035bcd35a53fc51e446a05 --

[Lldb-commits] [lldb] [lldb] Add a test for lea_rsp_pattern_p to x86 unwinder (NFC) (PR #94852)

2024-06-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes This commit adds a test for lea_rsp_pattern_p which was previously due as FIXME. --- Full diff: https://github.com/llvm/llvm-project/pull/94852.diff 1 Files Affected: - (modified) lldb/unittests/UnwindAssem

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [libc][math][C23] Implemented remquof128 function (PR #94809)

2024-06-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bfa937a48767a3dd10c5847034ce0b341da00a93 619189446484702fdf66dc43009cf6606dc4a8cd --

[Lldb-commits] [lldb] 1e92ad4 - [lldb] Use const reference for range variables to improve performance (NFC) (#94840)

2024-06-08 Thread via lldb-commits
Author: Shivam Gupta Date: 2024-06-08T22:34:40+05:30 New Revision: 1e92ad41d8ef46fa3c628b05ba8ed481fedc17bd URL: https://github.com/llvm/llvm-project/commit/1e92ad41d8ef46fa3c628b05ba8ed481fedc17bd DIFF: https://github.com/llvm/llvm-project/commit/1e92ad41d8ef46fa3c628b05ba8ed481fedc17bd.diff

[Lldb-commits] [lldb] [lldb] Gracefully down TestCoroutineHandle test in case the 'coroutine' feature is missing (PR #94903)

2024-06-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Do not let the compiler gets failed in case the target platform does not support the 'coroutine' C++ features. Just compile without it and let lldb know about missed/unsupported feature. --- Full diff: h

[Lldb-commits] [lldb] 0af2e75 - [lldb] Fix redundant condition in compression type check (NFC) (#94841)

2024-06-10 Thread via lldb-commits
Author: Shivam Gupta Date: 2024-06-10T13:53:39+05:30 New Revision: 0af2e75f8c688cc6fb7123c969c8edfa98a003fa URL: https://github.com/llvm/llvm-project/commit/0af2e75f8c688cc6fb7123c969c8edfa98a003fa DIFF: https://github.com/llvm/llvm-project/commit/0af2e75f8c688cc6fb7123c969c8edfa98a003fa.diff

[Lldb-commits] [lldb] 30bfab3 - [lldb] Remove redundant condition in watch mask check (NFC) (#94842)

2024-06-10 Thread via lldb-commits
Author: Shivam Gupta Date: 2024-06-10T13:53:55+05:30 New Revision: 30bfab3694075cfec9409821be0cfe79ae5d0770 URL: https://github.com/llvm/llvm-project/commit/30bfab3694075cfec9409821be0cfe79ae5d0770 DIFF: https://github.com/llvm/llvm-project/commit/30bfab3694075cfec9409821be0cfe79ae5d0770.diff

[Lldb-commits] [lldb] 23b8f59 - [lldb] Gracefully down TestCoroutineHandle test in case the 'coroutine' feature is missing (#94903)

2024-06-10 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-06-10T13:02:55+04:00 New Revision: 23b8f59f0916982cb0674b6175b7c812b86ffb99 URL: https://github.com/llvm/llvm-project/commit/23b8f59f0916982cb0674b6175b7c812b86ffb99 DIFF: https://github.com/llvm/llvm-project/commit/23b8f59f0916982cb0674b6175b7c812b86ffb99.dif

[Lldb-commits] [lldb] 3e39328 - [lldb] Fix TestModuleLoadedNotifys API test to work correctly on most of Linux targets (#94672)

2024-06-10 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-06-10T18:51:47+04:00 New Revision: 3e39328b62f2932c082496dd2471a9064dbff878 URL: https://github.com/llvm/llvm-project/commit/3e39328b62f2932c082496dd2471a9064dbff878 DIFF: https://github.com/llvm/llvm-project/commit/3e39328b62f2932c082496dd2471a9064dbff878.dif

[Lldb-commits] [lldb] [lldb][API] Add Find(Ranges)InMemory() to Process SB API (PR #95007)

2024-06-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Test Plan: llvm-lit llvm-project/lldb/test/API/python_api/find_in_memory/TestFindInMemory.py llvm-project/lldb/test/API/python_api/find_in_memory/TestFindRangesInMemory.py Reviewers: clayborg Tasks: lldb ---

[Lldb-commits] [lldb] [lldb][API] Add Find(Ranges)InMemory() to Process SB API (PR #95007)

2024-06-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r f26bc5f0c421c7a01a1a611249dd7483b749bab5...da8f23bf675abbb6742987e41939710ccb1c18ac lldb/

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][DWARF][NFC] Refactor RangeListsWritersByCU (PR #95008)

2024-06-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-lldb Author: Sayhaan Siddiqui (sayhaan) Changes Refactor RangeListsWritersByCU so we don't store them all in an array and instead create an instance per DWO. --- Patch is 33.08 KiB, truncated

[Lldb-commits] [lldb] [lldb] Tighten ABI assert in `StopInfoMachException::DeterminePtrauthFailure` (NFC) (PR #95015)

2024-06-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch tightens the assert check for the ABISP object in `StopInfoMachException::DeterminePtrauthFailure`. This causes some failure when debugging on a system that doesn't have pointer authent

[Lldb-commits] [lldb] Fix type lookup bug where wrong decl context was being used for a DIE. (PR #94846)

2024-06-10 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. https://github.com/llvm/llvm-project/pull/94846 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 93b91dd - [lldb] Tighten ABI assert in `StopInfoMachException::DeterminePtrauthFailure` (NFC) (#95015)

2024-06-10 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-06-10T10:49:16-07:00 New Revision: 93b91d031a703cc2f19bbe35e95bc0de6970 URL: https://github.com/llvm/llvm-project/commit/93b91d031a703cc2f19bbe35e95bc0de6970 DIFF: https://github.com/llvm/llvm-project/commit/93b91d031a703cc2f19bbe35e95bc0de6970.

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][DWARF][NFC] Remove old GDB Index functions (PR #95019)

2024-06-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sayhaan Siddiqui (sayhaan) Changes Remove old usages of GDB Index functions after replacing them with new ones. --- Patch is 38.13 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/95019.diff 22

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][DWARF][NFC] Remove old GDB Index functions (PR #95019)

2024-06-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Sayhaan Siddiqui (sayhaan) Changes Remove old usages of GDB Index functions after replacing them with new ones. --- Patch is 38.13 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/95019.dif

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

2024-06-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r f26bc5f0c421c7a01a1a611249dd7483b749bab5...ea050132f653a908eeefecd647431a0ed65e2cc0 lldb/

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][DWARF][NFC] Remove old GDB Index functions (PR #95019)

2024-06-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 77f75b45fd8a4bbc061e85a4432c23b64ca7d4f2...b9273c87b2ae189024b6bb08af5a2ee8ecf26de9 cross

[Lldb-commits] [lldb] [lldb] NFC add comments and test case for ObjectFileMachO delay-init (PR #95067)

2024-06-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes Add comments and a test for delay-init libraries on macOS. I originally added the support in 954d00e87cdd77d0e9e367be52e62340467bd779 a month ago, but without these additional clarifications. rdar://1

[Lldb-commits] [lldb] [lldb] NFC add comments and test case for ObjectFileMachO delay-init (PR #95067)

2024-06-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r c4f8ae6f32dadf9383c94ed13152d91f68631255...6b67c214ea95418e3f246c694d0a40009176fc07 lldb/

[Lldb-commits] [lldb] 1934208 - [lldb] NFC add comments and test case for ObjectFileMachO delay-init (#95067)

2024-06-10 Thread via lldb-commits
Author: Jason Molenda Date: 2024-06-10T20:33:38-07:00 New Revision: 1934208132e3a084c5952656ae29816958b8207c URL: https://github.com/llvm/llvm-project/commit/1934208132e3a084c5952656ae29816958b8207c DIFF: https://github.com/llvm/llvm-project/commit/1934208132e3a084c5952656ae29816958b8207c.diff

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-10 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/95075 # Add options The following options are added to the `statistics dump` command: * `--targets`: Dumps the `targets` section. * `--modules`: Dumps the `modules` section. When both options are given, the field `mo

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes # Add options The following options are added to the `statistics dump` command: * `--targets`: Dumps the `targets` section. * `--modules`: Dumps the `modules` section. When both options are given, the field `moduleI

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-10 Thread via lldb-commits
royitaqi wrote: cc @kusmour, @clayborg , @jeffreytan81 https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1fe4f2d1a4b9d16ae41076608783df4427a4d985 f6c7737d056526714e65c35f0204b9b4a04776c3 --

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 1fe4f2d1a4b9d16ae41076608783df4427a4d985...f6c7737d056526714e65c35f0204b9b4a04776c3 lldb/

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-10 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 1/3] Add --targets and --modules option to statistics dump --- lldb/i

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-10 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 1/4] Add --targets and --modules option to statistics dump --- lldb/i

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-10 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 1/5] Add --targets and --modules option to statistics dump --- lldb/i

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-10 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParser][NFC] Factor out CXX/ObjC method specifics out of ParseSubroutine (PR #95078)

2024-06-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch moves some of the `is_cxx_method`/`objc_method` logic out of `DWARFASTParserClang::ParseSubroutine` into their own functions. Mainly the purpose of this is to (hopefully) make this function more

[Lldb-commits] [lldb] baad1b8 - [lldb] Add a test for lea_rsp_pattern_p to x86 unwinder (NFC) (#94852)

2024-06-11 Thread via lldb-commits
Author: Shivam Gupta Date: 2024-06-11T12:52:32+05:30 New Revision: baad1b85b93c0b5ce0341668259ae21911bed8b1 URL: https://github.com/llvm/llvm-project/commit/baad1b85b93c0b5ce0341668259ae21911bed8b1 DIFF: https://github.com/llvm/llvm-project/commit/baad1b85b93c0b5ce0341668259ae21911bed8b1.diff

[Lldb-commits] [lldb] [WIP][lldb] Use forward decls with redeclared definitions instead of minimal import for records (PR #95100)

2024-06-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 97cfe549c9a9ec3880c984bd4d2ddbbd92dcb9a0...2d90c9f4bf29f7de7db3df115d505db4b674649c lldb/

[Lldb-commits] [lldb] [WIP][lldb] Use forward decls with redeclared definitions instead of minimal import for records (PR #95100)

2024-06-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 97cfe549c9a9ec3880c984bd4d2ddbbd92dcb9a0 2d90c9f4bf29f7de7db3df115d505db4b674649c --

[Lldb-commits] [lldb] c0e1ad7 - [lldb] Skip declaration DIEs in the debug_names index (#94744)

2024-06-11 Thread via lldb-commits
Author: Pavel Labath Date: 2024-06-11T16:17:25+02:00 New Revision: c0e1ad779f8b7b0073b89ecdd44c3b9c4a72e494 URL: https://github.com/llvm/llvm-project/commit/c0e1ad779f8b7b0073b89ecdd44c3b9c4a72e494 DIFF: https://github.com/llvm/llvm-project/commit/c0e1ad779f8b7b0073b89ecdd44c3b9c4a72e494.diff

[Lldb-commits] [lldb] [lldb] Do not produce field information for registers known not to exist (PR #95125)

2024-06-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Currently the logic is generate field information for all registers in LinuxArm64RegisterFlags and then as we walk the existing register info, only those that are in that existing info will get the ne

[Lldb-commits] [lldb] [lldb/DWARF] Remove some dead code (PR #95127)

2024-06-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes `GetDeclContextDIEs` and `DIEDeclContextsMatch` are unused (possibly since we added support for simplified template names, but I haven't checked). `GetDeclContextDIEs` is also very similar (but subtly differen

[Lldb-commits] [lldb] [lldb] Fix declaration of thread argument in CommandObjectThreadStepWithTypeAndScope (PR #95146)

2024-06-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/95146.diff 1 Files Affected: - (modified) lldb/source/Commands/CommandObjectThread.cpp (+1-1) ``diff diff --git a/lldb/source/Commands/Co

[Lldb-commits] [lldb] 56f668c - [lldb/DWARF] Remove some dead code (#95127)

2024-06-11 Thread via lldb-commits
Author: Pavel Labath Date: 2024-06-11T19:49:10+02:00 New Revision: 56f668c12b1a26e103aafe5ac37930b1895c938b URL: https://github.com/llvm/llvm-project/commit/56f668c12b1a26e103aafe5ac37930b1895c938b DIFF: https://github.com/llvm/llvm-project/commit/56f668c12b1a26e103aafe5ac37930b1895c938b.diff

[Lldb-commits] [lldb] [lldb] Fix declaration of thread argument in CommandObjectThreadStepWithTypeAndScope (PR #95146)

2024-06-11 Thread via lldb-commits
https://github.com/jimingham approved this pull request. We clearly parse that as a Thread Index later on, so the definition here is wrong. Thread Index is also the right choice, having to type out the ID would be annoying. https://github.com/llvm/llvm-project/pull/95146 _

[Lldb-commits] [lldb] 982b4b6 - [lldb] Fix declaration of thread argument in CommandObjectThreadStepWithTypeAndScope (#95146)

2024-06-11 Thread via lldb-commits
Author: Dave Lee Date: 2024-06-11T13:14:59-07:00 New Revision: 982b4b6f4d5ddf04ed5e85aea7074c9b26f29673 URL: https://github.com/llvm/llvm-project/commit/982b4b6f4d5ddf04ed5e85aea7074c9b26f29673 DIFF: https://github.com/llvm/llvm-project/commit/982b4b6f4d5ddf04ed5e85aea7074c9b26f29673.diff LOG:

[Lldb-commits] [lldb] a118f5f - Fix type lookup bug where wrong decl context was being used for a DIE. (#94846)

2024-06-11 Thread via lldb-commits
Author: Greg Clayton Date: 2024-06-11T13:58:26-07:00 New Revision: a118f5f398bf099ec76ebf889234ebbc58b28f0c URL: https://github.com/llvm/llvm-project/commit/a118f5f398bf099ec76ebf889234ebbc58b28f0c DIFF: https://github.com/llvm/llvm-project/commit/a118f5f398bf099ec76ebf889234ebbc58b28f0c.diff

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-11 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ConstString] Prevent GetString from constructing a std::string with a nullptr (PR #95175)

2024-06-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch prevents passing a `nullptr` to the `std::string` constructor in `GetString`. This prevents UB arising from calling `GetString` on a default-constructed `ConstString`. --- Full diff: https://gi

[Lldb-commits] [lldb] 6fb6eba - [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (#94518)

2024-06-11 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-06-11T15:20:35-07:00 New Revision: 6fb6eba9304b63e86ebf039edcb9a0b32e4b39e7 URL: https://github.com/llvm/llvm-project/commit/6fb6eba9304b63e86ebf039edcb9a0b32e4b39e7 DIFF: https://github.com/llvm/llvm-project/commit/6fb6eba9304b63e86ebf039edcb9a0b32e4b39e7.d

[Lldb-commits] [lldb] 11a4d43 - Fix flaky TestDAP_console test. (#94494)

2024-06-11 Thread via lldb-commits
Author: Miro Bucko Date: 2024-06-12T06:21:17+07:00 New Revision: 11a4d43f4a8ed02694de4d39b5591ff2b1c31803 URL: https://github.com/llvm/llvm-project/commit/11a4d43f4a8ed02694de4d39b5591ff2b1c31803 DIFF: https://github.com/llvm/llvm-project/commit/11a4d43f4a8ed02694de4d39b5591ff2b1c31803.diff LO

[Lldb-commits] [lldb] Reland "[lldb][api-test] Add API test for SBCommandInterpreter::Comm… (PR #95181)

2024-06-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes …andOverrideCallback (#94518)" This reverts commit 7cff05ada05e87408966d56b4c1675033187ff5c. The API test that was added erroneously imports a module that isn't needed and wouldn't be found which

[Lldb-commits] [lldb] 3d86eeb - Reland "[lldb][api-test] Add API test for SBCommandInterpreter::Comm… (#95181)

2024-06-11 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-06-11T16:41:31-07:00 New Revision: 3d86eebdf84f1c1a8ef57706c1182836176a1780 URL: https://github.com/llvm/llvm-project/commit/3d86eebdf84f1c1a8ef57706c1182836176a1780 DIFF: https://github.com/llvm/llvm-project/commit/3d86eebdf84f1c1a8ef57706c1182836176a1780.d

[Lldb-commits] [lldb] 1efd5c2 - [lldb][DWARFASTParser][NFC] Factor out CXX/ObjC method specifics out of ParseSubroutine (#95078)

2024-06-12 Thread via lldb-commits
Author: Michael Buch Date: 2024-06-12T09:33:35+01:00 New Revision: 1efd5c22893e4a186453f6aaf44fee747f1d63bf URL: https://github.com/llvm/llvm-project/commit/1efd5c22893e4a186453f6aaf44fee747f1d63bf DIFF: https://github.com/llvm/llvm-project/commit/1efd5c22893e4a186453f6aaf44fee747f1d63bf.diff

[Lldb-commits] [lldb] 860f0b5 - [lldb][ConstString] Prevent GetString from constructing a std::string with a nullptr (#95175)

2024-06-12 Thread via lldb-commits
Author: Michael Buch Date: 2024-06-12T09:34:12+01:00 New Revision: 860f0b542ae32c507959201146242cd716222041 URL: https://github.com/llvm/llvm-project/commit/860f0b542ae32c507959201146242cd716222041 DIFF: https://github.com/llvm/llvm-project/commit/860f0b542ae32c507959201146242cd716222041.diff

[Lldb-commits] [lldb] d32afb3 - [lldb][Progress] Report progress when parsing forward declarations from DWARF (#91452)

2024-06-12 Thread via lldb-commits
Author: Michael Buch Date: 2024-06-12T10:33:03+01:00 New Revision: d32afb39fd90a305fc116a7161a2b4c4556117d4 URL: https://github.com/llvm/llvm-project/commit/d32afb39fd90a305fc116a7161a2b4c4556117d4 DIFF: https://github.com/llvm/llvm-project/commit/d32afb39fd90a305fc116a7161a2b4c4556117d4.diff

[Lldb-commits] [lldb] [lldb] Move DWARFDeclContext functions from DWARFDebugInfoEntry to DW… (PR #95227)

2024-06-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes …ARFDIE This puts them closer to the other two functions doing something very similar. I've tried to stick to the original logic of the functions as much as possible, though I did apply some easy simplificati

[Lldb-commits] [lldb] f6a2ca4 - [lldb][test] Disable PIE for some API tests (#93808)

2024-06-12 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-06-12T17:10:20+02:00 New Revision: f6a2ca4f22e3d737a7aa488a4edde88d53dc8b26 URL: https://github.com/llvm/llvm-project/commit/f6a2ca4f22e3d737a7aa488a4edde88d53dc8b26 DIFF: https://github.com/llvm/llvm-project/commit/f6a2ca4f22e3d737a7aa488a4edde88d53dc8b2

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-06-12 Thread via lldb-commits
cmtice wrote: > There was one comment that should probably be removed. This looks okay to me > at this stage. Jim, If this looks ok to you, could you officially mark it as approved please? https://github.com/llvm/llvm-project/pull/87197 ___ lldb-comm

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-06-12 Thread via lldb-commits
cmtice wrote: Review ping? Does this look ok to everyone now? I would really like to get this PR committed (I have more waiting behind it). Thanks in advance! https://github.com/llvm/llvm-project/pull/87197 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-06-12 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM at this point. https://github.com/llvm/llvm-project/pull/87197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities Author: Jacob Lalonde (Jlalond) Changes Currently, LLDB does not support taking a minidump over the 4.2gb limit imposed by uint32. In fact, currently it writes the RVA's and the headers to the end of the file, which can become cor

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d6bbe2e20ff21cc2d31106742dfe1711ae5c641e c592936dedb0dc494b03144d741ce57ac0b27809 --

[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

2024-06-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes This commit refactors the typemaps and static functions used in the SWIG typemaps and wrappers to be in their own SWIG files that are included in the main `python.swig` file. --- Full diff: https:

[Lldb-commits] [lldb] [lldb] Support case-insensitive regex matches (PR #95350)

2024-06-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Support case-insensitive regex matches for `SBTarget::FindGlobalFunctions` and `SBTarget::FindGlobalVariables`. --- Full diff: https://github.com/llvm/llvm-project/pull/95350.diff 5 Files Affected

[Lldb-commits] [lldb] [lldb] Support case-insensitive regex matches (PR #95350)

2024-06-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 3fce14569fc3611eddca41db055143285244736a...a2a362aeaf3d091c04a2eaefc604962730aa483c lldb/

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [lld] [lldb] [llvm] [mlir] [openmp] [llvm-project] Fix typo "seperate" (PR #95373)

2024-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-lldb @llvm/pr-subscribers-lld Author: Jay Foad (jayfoad) Changes --- Patch is 57.75 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/95373.diff 64 Files Affected: - (

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFCI] Factor completion logic for individual types in GetCompleteQualType (PR #95402)

2024-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch factors out the completion logic for individual clang::Type's into their own helper functions. During the process I cleaned up a few assumptions (e.g., unnecessary if-guards that could be asser

[Lldb-commits] [lldb] [lldb][test] Add test for completing ObjCObjectType (PR #95405)

2024-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This is a minimal reproducer for a crash reported internally where we would try to call `DumpTypeDescription` on an incomplete type. This crash surfaced as part of an NFC refactor of some of the logic in `

<    10   11   12   13   14   15   16   17   18   19   >