[Lldb-commits] [lldb] [lldb] Fix 'session save' command on Windows (PR #93833)

2024-05-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 22c572eae0f3a73b9154718a3f46c08531e52e91...a11876da55230bd9c5df7cddc3726cef5f5836a1 lldb/

[Lldb-commits] [lldb] [lldb] Add AddressRange to SB API (PR #93836)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Summary: This adds new SB API calls and classes to allow a user of the SB API to obtain an address range from SBFunction and SBBlock. This is a second attempt to land the reverted PR #92014. Test Plan: llvm-lit

[Lldb-commits] [lldb] facb767 - [lldb] Fixed the TestGdbRemoteLibrariesSvr4Support test running on a remote target (#93825)

2024-05-30 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-30T19:56:04+04:00 New Revision: facb767e5b78a024d70585b24254c769473b6b54 URL: https://github.com/llvm/llvm-project/commit/facb767e5b78a024d70585b24254c769473b6b54 DIFF: https://github.com/llvm/llvm-project/commit/facb767e5b78a024d70585b24254c769473b6b54.dif

[Lldb-commits] [lldb] 59e2a6b - [lldb] Fixed the TestDebuggerAPI test running on a remote target (#93829)

2024-05-30 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-30T19:56:46+04:00 New Revision: 59e2a6b08f3e40afea87da3838ba69e1e15b6672 URL: https://github.com/llvm/llvm-project/commit/59e2a6b08f3e40afea87da3838ba69e1e15b6672 DIFF: https://github.com/llvm/llvm-project/commit/59e2a6b08f3e40afea87da3838ba69e1e15b6672.dif

[Lldb-commits] [lldb] b62ba7f - [lldb] Fixed the TestGdbRemotePlatformFile test running on a remote target (#93832)

2024-05-30 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-30T19:57:16+04:00 New Revision: b62ba7f5b1caf99a3cbbe06d0e1c788c2dc85416 URL: https://github.com/llvm/llvm-project/commit/b62ba7f5b1caf99a3cbbe06d0e1c788c2dc85416 DIFF: https://github.com/llvm/llvm-project/commit/b62ba7f5b1caf99a3cbbe06d0e1c788c2dc85416.dif

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes This fixes https://github.com/llvm/llvm-project/pull/92328#issuecomment-2139339444. This contains two fixes: 1. Do not differentiate `DW_TAG_class_type` and `DW_TAG_structure_type` in `UniqueDWARFASTTypeList`,

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 16a5fd3fdb91ffb39b97dbd3a7e9346ba406360d e7fc16ec5f31693191188b3b95728c4320465923 --

[Lldb-commits] [lldb] 3d9d485 - [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (#93839)

2024-05-30 Thread via lldb-commits
Author: Zequan Wu Date: 2024-05-30T13:05:29-04:00 New Revision: 3d9d48523977af3590f7dd0edfd258454cb9e9cf URL: https://github.com/llvm/llvm-project/commit/3d9d48523977af3590f7dd0edfd258454cb9e9cf DIFF: https://github.com/llvm/llvm-project/commit/3d9d48523977af3590f7dd0edfd258454cb9e9cf.diff LOG

[Lldb-commits] [lldb] [IRInterpreter] Return zero address for missing weak function (PR #93548)

2024-05-30 Thread via lldb-commits
jimingham wrote: It's been a long time since I've looked at this code, but the change to return a 0 value rather than an error seems consistent at least. Was there no way to test this? https://github.com/llvm/llvm-project/pull/93548 ___ lldb-commits

[Lldb-commits] [lldb] 48175a5 - [lldb] Add SBAddressRange and SBAddressRangeList to SB API (#93836)

2024-05-30 Thread via lldb-commits
Author: Miro Bucko Date: 2024-05-30T10:38:21-07:00 New Revision: 48175a5d9f62f0586c04e5a742dafa5e1943f19c URL: https://github.com/llvm/llvm-project/commit/48175a5d9f62f0586c04e5a742dafa5e1943f19c DIFF: https://github.com/llvm/llvm-project/commit/48175a5d9f62f0586c04e5a742dafa5e1943f19c.diff LO

[Lldb-commits] [lldb] [lldb][test] Fix failing test TestAddressRange.py (PR #93871)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Summary: Test llvm-project/lldb/test/API/python_api/address_range/TestAddressRange.py is failing on Windows due adding a carriage return character at the end of line. Original PR is #93836. Test Plan: llvm-lit

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-30 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/92843 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 1/9] Add resolvedCommand to transcript, add transcript to statistics d

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-30 Thread via lldb-commits
@@ -362,6 +363,36 @@ llvm::json::Value DebuggerStats::ReportStatistics( global_stats.try_emplace("modules", std::move(json_modules)); global_stats.try_emplace("memory", std::move(json_memory)); global_stats.try_emplace("commands", std::move(cmd_stats)); + +// Wh

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-30 Thread via lldb-commits
@@ -320,10 +320,13 @@ class SBCommandInterpreter { /// Returns a list of handled commands, output and error. Each element in /// the list is a dictionary with the following keys/values: - /// - "command" (string): The command that was executed. + /// - "command" (string)

[Lldb-commits] [lldb] 493eefc - [lldb][test] Fix failing test TestAddressRange.py (#93871)

2024-05-30 Thread via lldb-commits
Author: Miro Bucko Date: 2024-05-30T13:44:51-07:00 New Revision: 493eefc93f2901dd987b8ff441004352b317cab9 URL: https://github.com/llvm/llvm-project/commit/493eefc93f2901dd987b8ff441004352b317cab9 DIFF: https://github.com/llvm/llvm-project/commit/493eefc93f2901dd987b8ff441004352b317cab9.diff LO

[Lldb-commits] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-30 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/93880 But one made in a situation where that's impossible might only have an error, and no symbol context, so that's not necessarily true. Check for the target's validity before using it. Fixes issue #93313 >From

[Lldb-commits] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes But one made in a situation where that's impossible might only have an error, and no symbol context, so that's not necessarily true. Check for the target's validity before using it. Fixes issue #93313 --- Full d

[Lldb-commits] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 6abc3876c35bbe8fb5dd6435dc60f2c816b97ef6...007bab454cd9aa2c73ce167ee15900523d3b7318 lldb/

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/93881.diff 4 Files Affected: - (modified) lldb/source/Core/Mangled.cpp (+9-2) - (added) lldb/test/API/lang/c/non-mangled/Makefile (+4) - (added) l

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r f795853d1f77bff69c3805f75e54fa7a32cc23d9...21a61a1a5ae68fc1e913f73c4311258675990f95 lldb/

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-30 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/90930 >From e7823321c1b7e23b077a0b785af50d641fc9a6b7 Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 2 May 2024 18:12:04 -0700 Subject: [PATCH 1/5] Single thread timeout feature --- lldb/include/lldb/Targ

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread via lldb-commits
https://github.com/jimingham approved this pull request. This a little bit raises the question why we don't do the same checks for `_R` and `_Z`. It would be even better if the various demanglers in llvm had a quick "could this be mine" check so we didn't have to encode this in lldb. But you

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes This argument allows to specify the path to make which is used by LLDB API tests to compile test programs. It might come in handy for setting up cross-platform remote runs of API tests on Windows h

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread via lldb-commits
jimingham wrote: > Also, something to keep in mind: If Dlang ever decides to change their > mangled name scheme in the future, this change may become wrong then. I'm not > sure what commitments the D language project has for their ABI stability > though. That's why this shouldn't be in lldb i

[Lldb-commits] [lldb] 852aaf5 - Reapply "[Support] Remove terminfo dependency (#92865)" (#93889)

2024-05-30 Thread via lldb-commits
Author: Aaron Siddhartha Mondal Date: 2024-05-31T01:29:00+02:00 New Revision: 852aaf54071ad072335dcac57f544d4da34c875a URL: https://github.com/llvm/llvm-project/commit/852aaf54071ad072335dcac57f544d4da34c875a DIFF: https://github.com/llvm/llvm-project/commit/852aaf54071ad072335dcac57f544d4da34c

[Lldb-commits] [lldb] 71ccd0d - [IRInterpreter] Return zero address for missing weak function (#93548)

2024-05-30 Thread via lldb-commits
Author: Nikita Popov Date: 2024-05-31T08:18:35+02:00 New Revision: 71ccd0d8ccf876e32e21514839195f159642fe4c URL: https://github.com/llvm/llvm-project/commit/71ccd0d8ccf876e32e21514839195f159642fe4c DIFF: https://github.com/llvm/llvm-project/commit/71ccd0d8ccf876e32e21514839195f159642fe4c.diff

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes For some data formatters, even getting the number of children can be an expensive operations (e.g., needing to walk a linked list to determine the number of elements). This is then wasted work when we know we

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r a2bcb932f3130c3c18ceb06872da9002f6845c4b...957f0a85a0e0d2de9f34d00e28ba932e5affce86 lldb

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-31 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 419d363385c7fa8bd969a817f95ab025ae94277c...60032f8510b7086e36a86172fbaa090e4d7ef66f lldb/

[Lldb-commits] [lldb] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-31 Thread via lldb-commits
jimingham wrote: > LGTM assuming you can make the formatter happy. This change says "If a ValueObject has no target, don't try to find a formatter for it". If it doesn't have a target, it's either an error or stale, and isn't going to have a value to format, so any more work we did here would

[Lldb-commits] [lldb] 1e81b67 - [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (#93880)

2024-05-31 Thread via lldb-commits
Author: jimingham Date: 2024-05-31T10:43:05-07:00 New Revision: 1e81b67925fdd77a3d65ba2a7f652d1e840512f4 URL: https://github.com/llvm/llvm-project/commit/1e81b67925fdd77a3d65ba2a7f652d1e840512f4 DIFF: https://github.com/llvm/llvm-project/commit/1e81b67925fdd77a3d65ba2a7f652d1e840512f4.diff LOG

[Lldb-commits] [lldb] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-31 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/93880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread via lldb-commits
jimingham wrote: This seems reasonable. However, I note that on the page where we show how to write synthetic child providers, we say: def num_children(self): this call should return the number of children that you want your object to have That's actually not true - we pass the max_

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/92843 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 01/10] Add resolvedCommand to transcript, add transcript to statistics

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
@@ -1425,4 +1425,6 @@ let Command = "statistics dump" in { Desc<"Dump the total possible debug info statistics. " "Force loading all the debug information if not yet loaded, and collect " "statistics with those.">; + def statistics_dump_transcript: Option<"transcri

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread via lldb-commits
jimingham wrote: BTW, because the max number of children is probably getting ignored in the wild, this has to be advisory, you can't require that: val.GetNumChildren(max_children) <= max_children I don't think you do that but it might be good to note the fact. https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] 5a02a9a - [lldb] Improve identification of Dlang mangled names (#93881)

2024-05-31 Thread via lldb-commits
Author: Dave Lee Date: 2024-05-31T11:20:23-07:00 New Revision: 5a02a9a2e6794f086dfe1cd6f15ba2210bc0 URL: https://github.com/llvm/llvm-project/commit/5a02a9a2e6794f086dfe1cd6f15ba2210bc0 DIFF: https://github.com/llvm/llvm-project/commit/5a02a9a2e6794f086dfe1cd6f15ba2210bc0.diff LOG:

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/92843 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 01/11] Add resolvedCommand to transcript, add transcript to statistics

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/94007 The IsValid API is actually quite weak - it means "this value can't answer any questions meaningfully." But I've run into a couple cases where people thought it meant "was able to reconstruct the value on this

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes The IsValid API is actually quite weak - it means "this value can't answer any questions meaningfully." But I've run into a couple cases where people thought it meant "was able to reconstruct the value on this stop

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to None (PR #94017)

2024-05-31 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to None (PR #94017)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Eisuke Kawashima (e-kwsm) Changes from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, never the equality operators. --- Full diff: https

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes We received a bug report where someone was trying to print a global variable without a process. This would succeed in a debug build but fail in a on optimized build. We traced the issue back to the

[Lldb-commits] [lldb] fix(lldb/**.py): fix invalid escape sequences (PR #94034)

2024-05-31 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] fix(lldb/**.py): fix invalid escape sequences (PR #94034)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 94.92 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/94034.diff 73 Files Affected: - (modified) lldb/examples/python/crashlog.py (+4-4) - (mod

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to True/False (PR #94039)

2024-05-31 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to True/False (PR #94039)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Eisuke Kawashima (e-kwsm) Changes from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, never the equality operators. --- Full diff: https

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-31 Thread via lldb-commits
gulfemsavrun wrote: We started seeing test failures in `LLDBCoreTests`: ``` Script: -- /b/s/w/ir/x/w/llvm_build/tools/lldb/unittests/Core/./LLDBCoreTests --gtest_filter=MangledTest.EmptyForInvalidDLangName -- lldb/unittests/Core/MangledTest.cpp:89: Failure Expected equality of these values: ""

[Lldb-commits] [lldb] [lldb] Fix Dlang symbol test breakage (PR #94046)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94046.diff 2 Files Affected: - (modified) lldb/source/Core/Mangled.cpp (+3-2) - (modified) lldb/unittests/Core/MangledTest.cpp (+2-2) ``

[Lldb-commits] [lldb] 68fdc1c - [lldb] Fix Dlang symbol test breakage (#94046)

2024-05-31 Thread via lldb-commits
Author: Dave Lee Date: 2024-05-31T14:04:40-07:00 New Revision: 68fdc1cf87eb04686e079af27eaeec0f1c41f8cc URL: https://github.com/llvm/llvm-project/commit/68fdc1cf87eb04686e079af27eaeec0f1c41f8cc DIFF: https://github.com/llvm/llvm-project/commit/68fdc1cf87eb04686e079af27eaeec0f1c41f8cc.diff LOG:

[Lldb-commits] [lldb] ad884d9 - A few updates around "transcript" (#92843)

2024-05-31 Thread via lldb-commits
Author: royitaqi Date: 2024-05-31T14:42:00-07:00 New Revision: ad884d97288c752ba9088d01cf7ab80b20e4d2a6 URL: https://github.com/llvm/llvm-project/commit/ad884d97288c752ba9088d01cf7ab80b20e4d2a6 DIFF: https://github.com/llvm/llvm-project/commit/ad884d97288c752ba9088d01cf7ab80b20e4d2a6.diff LOG:

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-31 Thread via lldb-commits
gulfemsavrun wrote: > @gulfemsavrun apologies, fix is here: #94046 Thanks, this fixed the issue. https://github.com/llvm/llvm-project/pull/93881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
royitaqi wrote: This appears to be failing the `lldb-x86-64-debian` buildbot: https://lab.llvm.org/buildbot/#/builders/68/builds/75333 https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [lldb] Fix a test failure in PR #92843 (PR #94067)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/94067 Problematic PR: https://github.com/llvm/llvm-project/pull/92843 There is a failure in the added test for Linux (test passes on macOS) The problem of the said test is that its assertion is unnecessarily detailed

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
royitaqi wrote: I have proposed a fix in https://github.com/llvm/llvm-project/pull/94067 https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] Fix a test failure in PR #92843 (PR #94067)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/94067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a test failure in PR #92843 (PR #94067)

2024-05-31 Thread via lldb-commits
royitaqi wrote: cc @clayborg https://github.com/llvm/llvm-project/pull/94067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
gulfemsavrun wrote: We also see the same test error on our bots. https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8746387351248919521/overview https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/94007 >From e024ea45c052411f2e7284c0ef5a6d048681cad7 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 31 May 2024 11:29:27 -0700 Subject: [PATCH 1/2] Add doc strings for SBValue::IsValid and SBValue::GetError.

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] Fix a test failure in PR #92843 (PR #94067)

2024-05-31 Thread via lldb-commits
@@ -177,7 +177,8 @@ def test_get_transcript(self): # (lldb) r self.assertEqual(transcript[3]["command"], "r") self.assertEqual(transcript[3]["commandName"], "process launch") -self.assertEqual(transcript[3]["commandArguments"], "-X true --") +

[Lldb-commits] [lldb] Fix a test failure in PR #92843 (PR #94067)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/94067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/94007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] Fix a test failure in PR #92843 (PR #94067)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/94067 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 01/13] Add resolvedCommand to transcript, add transcript to statistics

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] Fix a test failure in PR #92843 (PR #94067)

2024-05-31 Thread via lldb-commits
royitaqi wrote: FWIW, it's easier to [see the fix this way](https://github.com/royitaqi/llvm-project/compare/enhance-transcript-2...royitaqi:llvm-project:enhance-transcript-3). <-- This is the delta of `royitaqi:enhance-transcript-3` on top of `royitaqi:enhance-transcript-2` (which has been

[Lldb-commits] [lldb] Fix a test failure in PR #92843 (PR #94067)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/94067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
gulfemsavrun wrote: Can you please revert the patch if it's going to take a while to land the fix because I don't want our builders to stay red over the weekend? https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [lldb] Revert "A few updates around "transcript"" (PR #94088)

2024-05-31 Thread via lldb-commits
https://github.com/gulfemsavrun created https://github.com/llvm/llvm-project/pull/94088 Reverts llvm/llvm-project#92843 because it broke some lldb tests: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8746385730949743489/overview >From e6c1256867d6992d5affca53

[Lldb-commits] [lldb] Revert "A few updates around "transcript"" (PR #94088)

2024-05-31 Thread via lldb-commits
https://github.com/gulfemsavrun closed https://github.com/llvm/llvm-project/pull/94088 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 85fd168 - Revert "A few updates around "transcript"" (#94088)

2024-05-31 Thread via lldb-commits
Author: gulfemsavrun Date: 2024-05-31T20:06:18-07:00 New Revision: 85fd1688b2fc73ba97d95e621cfbfe9a3fff URL: https://github.com/llvm/llvm-project/commit/85fd1688b2fc73ba97d95e621cfbfe9a3fff DIFF: https://github.com/llvm/llvm-project/commit/85fd1688b2fc73ba97d95e621cfbfe9a3fff.diff

[Lldb-commits] [lldb] Revert "A few updates around "transcript"" (PR #94088)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (gulfemsavrun) Changes Reverts llvm/llvm-project#92843 because it broke some lldb tests: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8746385730949743489/overview --- Full diff: https://github.com/l

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
royitaqi wrote: @gulfemsavrun The fix PR is ready, as linked in the above (https://github.com/llvm/llvm-project/pull/94067). I just need someone to approve it and merge it. I'm quite new to this process. Is reverting also require someone to approve a revert PR and merge it? Or is it easier,

[Lldb-commits] [lldb] Revert "A few updates around "transcript"" (PR #94088)

2024-05-31 Thread via lldb-commits
royitaqi wrote: Just curious, @gulfemsavrun , how were you able to merge without another person's approval of the PR? I'm noob to github pull request - thought revert PR are the same as other PRs and need an approval, but reading this PR it seems such step isn't required. https://github.com/l

[Lldb-commits] [lldb] [llvm] Use StringRef::starts_with (NFC) (PR #94112)

2024-06-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94112.diff 3 Files Affected: - (modified) lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp (+1-1) - (modified) lldb/source/Utility

[Lldb-commits] [lldb] 2a1ea15 - Use StringRef::starts_with (NFC) (#94112)

2024-06-01 Thread via lldb-commits
Author: Kazu Hirata Date: 2024-06-01T10:36:05-07:00 New Revision: 2a1ea151cccba3de21edb950099a75ca8d3ea604 URL: https://github.com/llvm/llvm-project/commit/2a1ea151cccba3de21edb950099a75ca8d3ea604 DIFF: https://github.com/llvm/llvm-project/commit/2a1ea151cccba3de21edb950099a75ca8d3ea604.diff L

[Lldb-commits] [lldb] [lldb] Fixed TestEchoCommands.test running on a remote target (PR #94127)

2024-06-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes EchoCommandsQuiet.out failed in case of a remote target because the platform selection and connection messages. --- Full diff: https://github.com/llvm/llvm-project/pull/94127.diff 1 Files Affected: - (

[Lldb-commits] [lldb] [lldb] Disable find-module.test in case of a remote target (PR #94165)

2024-06-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The target arch is `i386-pc-windows` after loading the dump. It updates to `i386-pc-windows-msvc` or `i386-pc-windows-gnu` in lldb\source\Plugins\Process\minidump\ProcessMinidump.cpp, line 218 ``` GetTarg

[Lldb-commits] [lldb] [lldb] Add documentation for the max_children argument (PR #94192)

2024-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94192.diff 2 Files Affected: - (modified) lldb/docs/use/variable.rst (+26-11) - (modified) lldb/include/lldb/API/SBValue.h (+14) ``diff d

[Lldb-commits] [lldb] 763b96c - [lldb] Avoid (unlimited) GetNumChildren calls when printing values (#93946)

2024-06-03 Thread via lldb-commits
Author: Pavel Labath Date: 2024-06-03T10:34:44+02:00 New Revision: 763b96c86d81d51d0db430791a61fd1e8a406bce URL: https://github.com/llvm/llvm-project/commit/763b96c86d81d51d0db430791a61fd1e8a406bce DIFF: https://github.com/llvm/llvm-project/commit/763b96c86d81d51d0db430791a61fd1e8a406bce.diff

[Lldb-commits] [lldb] [lldb][test] Fix D lang mangling test on Windows (PR #94196)

2024-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes On Windows the function does not have a symbol associated with it: Function: id = {0x01c9}, name = "_Dfunction", range = [0x000140001000-0x000140001004) LineEntry: <...> Where

[Lldb-commits] [lldb] 8918d35 - [clang][Modules] Move `ASTSourceDescriptor` into its own file (#67930)

2024-06-03 Thread via lldb-commits
Author: David Stone Date: 2024-06-03T11:09:13+02:00 New Revision: 8918d35dbde126c95350b674a2bb102692d90260 URL: https://github.com/llvm/llvm-project/commit/8918d35dbde126c95350b674a2bb102692d90260 DIFF: https://github.com/llvm/llvm-project/commit/8918d35dbde126c95350b674a2bb102692d90260.diff L

[Lldb-commits] [clang] [lldb] [clang][Modules] Move `ASTSourceDescriptor` into its own file (PR #67930)

2024-06-03 Thread via lldb-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/67930 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6abf361 - [lldb][test] Fix D lang mangling test on Windows (#94196)

2024-06-03 Thread via lldb-commits
Author: David Spickett Date: 2024-06-03T10:18:39+01:00 New Revision: 6abf361953e9c5d019a72fd83765498d269eb080 URL: https://github.com/llvm/llvm-project/commit/6abf361953e9c5d019a72fd83765498d269eb080 DIFF: https://github.com/llvm/llvm-project/commit/6abf361953e9c5d019a72fd83765498d269eb080.diff

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to None (PR #94017)

2024-06-03 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[Lldb-commits] [lldb] [lldb] fix(lldb/**.py): fix invalid escape sequences (PR #94034)

2024-06-03 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[Lldb-commits] [lldb] [lldb] fix(lldb/**.py): fix invalid escape sequences (PR #94034)

2024-06-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r fc21387b6510ee44520f2f17fb671f1265a9055f...5c7ba6c7d95cced5d8acc609a40a6b8307bc7fed lldb/

[Lldb-commits] [lldb] [lldb] fix(lldb/**.py): fix comparison to True/False (PR #94039)

2024-06-03 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[Lldb-commits] [lldb] [lldb] Add Python requirements.txt for test suite (PR #94220)

2024-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This means that CI won't have to hardcode these. We can't do conditional installs here by platform so pexpect is listed normally. If it's installed on Windows that's fine, we just won't use it. --- F

[Lldb-commits] [lldb] [lldb] Add documentation for the max_children argument (PR #94192)

2024-06-03 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/94192 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Always load Application Specific Backtrace Thread images (PR #94259)

2024-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch changes the crashlog image loading default behaviour to not only load images from the crashed thread but also for the application specific backtrace thread. This patch also move the App

[Lldb-commits] [lldb] [lldb/crashlog] Create stackframes for non-crashed threads (PR #94262)

2024-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes By default, the crashlog script only loads images for the crashed thread as well as the application specific thread. Prior to using SymbolFileJSON and ObjectFileJSON, it didn't make sense to creat

[Lldb-commits] [lldb] 0232e2b - [lldb] Add Python requirements.txt for test suite (#94220)

2024-06-03 Thread via lldb-commits
Author: David Spickett Date: 2024-06-03T18:25:05+01:00 New Revision: 0232e2b15b8d3b2653f069a5683ccd29a5d29caf URL: https://github.com/llvm/llvm-project/commit/0232e2b15b8d3b2653f069a5683ccd29a5d29caf DIFF: https://github.com/llvm/llvm-project/commit/0232e2b15b8d3b2653f069a5683ccd29a5d29caf.diff

[Lldb-commits] [lldb] Re-merge `A few updates around "transcript"` #92843 (PR #94067)

2024-06-03 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/94067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    8   9   10   11   12   13   14   15   16   17   >