[Lldb-commits] [lldb] [lldb][Windows] Fixed LibcxxChronoTimePointSecondsSummaryProvider() (PR #92701)

2024-05-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This patch fixes #92574. It is a replacement for #92575. --- Full diff: https://github.com/llvm/llvm-project/pull/92701.diff 2 Files Affected: - (modified) lldb/source/Plugins/Language/CPlusPlus/LibCxx.

[Lldb-commits] [lldb] [lldb][Windows] Fixed LibcxxChronoTimePointSecondsSummaryProvider() (PR #92701)

2024-05-19 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3c3f6d877623d0d821f59f4ec6038b27f27ee01d 2dfbb8663a4661255cd90269b9f527dfac8fb21b --

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-05-19 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/3] [LLDB] Add more helper functions to ValueObject class. Create

[Lldb-commits] [lldb] [lldb-dap] Don't send expanded descriptions for "hover" expressions (PR #92726)

2024-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes VSCode will automatically ask for the children (in structured form) so there's no point in sending the textual representation. This can make displaying hover popups for complex variables with complicated data

[Lldb-commits] [lldb] 2217d17 - [lldb][Windows] Fixed LibcxxChronoTimePointSecondsSummaryProvider() (#92701)

2024-05-20 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-20T13:44:52+04:00 New Revision: 2217d1706a76d3f298899f824354ca9d96c45813 URL: https://github.com/llvm/llvm-project/commit/2217d1706a76d3f298899f824354ca9d96c45813 DIFF: https://github.com/llvm/llvm-project/commit/2217d1706a76d3f298899f824354ca9d96c45813.dif

[Lldb-commits] [lldb] [lldb/dwarf] Fix DW_IDX_parent processing for split dwarf (PR #92745)

2024-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes DWARFDebugInfo only knows how to resolve references in its own file, but in split dwarf, the index entries will refer to DIEs in the separate (DWO) file. To resolve the DIERef correctly we'd either need to go

[Lldb-commits] [lldb] [lldb/dwarf] Fix DW_IDX_parent processing for split dwarf (PR #92745)

2024-05-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r da6a0b7af29a222b2e16a10155b49d4fafe967f3...1c36a0c63f2c7c69048de36ab524cc8df7056704 lldb/

[Lldb-commits] [lldb] [lldb/dwarf] Fix DW_IDX_parent processing for split dwarf (PR #92745)

2024-05-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff da6a0b7af29a222b2e16a10155b49d4fafe967f3 1c36a0c63f2c7c69048de36ab524cc8df7056704 --

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-20 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/90703 >From 0fd67e2de7e702ce6f7353845454ea7ff9f980d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 30 Apr 2024 21:35:49 -0700 Subject: [PATCH 01/19] Add SBCommandInterpreter::GetTranscript() --- lldb/include/lld

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-20 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/89868 >From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 23 Apr 2024 18:10:21 -0700 Subject: [PATCH 01/19] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCall

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-20 Thread via lldb-commits
@@ -731,8 +747,12 @@ class Debugger : public std::enable_shared_from_this, lldb::TargetSP m_dummy_target_sp; Diagnostics::CallbackID m_diagnostics_callback_id; - lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr; - void *m_destroy_callback_baton = nullp

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-20 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/90703 >From 323b882db7f2845563176ca057c9cd2c88f3492a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 30 Apr 2024 21:35:49 -0700 Subject: [PATCH 01/19] Add SBCommandInterpreter::GetTranscript() --- lldb/include/lld

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-20 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/89868 >From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 23 Apr 2024 18:10:21 -0700 Subject: [PATCH 01/19] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCall

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 7ecdf620330d8e044a48b6f59f8eddd2f88f01d4...25a51ed4e87042411b03ba4e57cb4a595679c37b lldb/

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 7ecdf620330d8e044a48b6f59f8eddd2f88f01d4...542615a18949f6f325c03761104b2f0530270065 lldb/

[Lldb-commits] [lldb] e8dc8d6 - Add new Python API `SBCommandInterpreter::GetTranscript()` (#90703)

2024-05-20 Thread via lldb-commits
Author: royitaqi Date: 2024-05-20T15:49:46-07:00 New Revision: e8dc8d614ada201e250fbf075241b2b6180943b5 URL: https://github.com/llvm/llvm-project/commit/e8dc8d614ada201e250fbf075241b2b6180943b5 DIFF: https://github.com/llvm/llvm-project/commit/e8dc8d614ada201e250fbf075241b2b6180943b5.diff LOG:

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-20 Thread via lldb-commits
github-actions[bot] wrote: @royitaqi Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[Lldb-commits] [lldb] 9f62775 - SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (#89868)

2024-05-20 Thread via lldb-commits
Author: royitaqi Date: 2024-05-20T15:51:42-07:00 New Revision: 9f62775038b9135709a2c3c7ea97c944278967a2 URL: https://github.com/llvm/llvm-project/commit/9f62775038b9135709a2c3c7ea97c944278967a2 DIFF: https://github.com/llvm/llvm-project/commit/9f62775038b9135709a2c3c7ea97c944278967a2.diff LOG:

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-20 Thread via lldb-commits
github-actions[bot] wrote: @royitaqi Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[Lldb-commits] [lldb] [lldb] Add support for updating string during debug process (PR #67782)

2024-05-20 Thread via lldb-commits
@@ -0,0 +1,171 @@ +#include "LibCxx.h" +#include "LibCxxStringInfoExtractor.h" + +#include "lldb/DataFormatters/FormattersHelpers.h" +#include + +using namespace lldb; +using namespace lldb_private; + +namespace { + +class StringFrontend : public SyntheticChildrenFrontEnd { + +pu

[Lldb-commits] [lldb] [lldb] Add support for updating string during debug process (PR #67782)

2024-05-20 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/67782 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for updating string during debug process (PR #67782)

2024-05-20 Thread via lldb-commits
jimingham wrote: > Hello, @jimingham , first of all - sorry for the long delay in reply. > > I carefully read through all your messages once again and found, that I > totally misunderstood some places, i.e. "Why isn't it enough to have the > ValueObjectSynthetic's SetValueFromCString do this"

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-20 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/92843 # Changes 1. Add `resolvedCommand` as a new field to (structured) transcript. This field will hold the expanded/executed command (e.g. "breakpoint set ..."). This is not to be confused with the "command" field

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes # Changes 1. Add `resolvedCommand` as a new field to (structured) transcript. This field will hold the expanded/executed command (e.g. "breakpoint set ..."). This is not to be confused with the "command" field, whi

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 85e1124049cd8aa1e58c101e082100ba74df7e42...67a1197a15682731f37890734a5c8674896e0428 lldb/

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb @llvm/pr-subscribers-clang Author: Aaron Siddhartha Mondal (aaronmondal) Changes The terminfo dependency introduces a significant nonhermeticity into the build. It doesn't respect `--no-undefined-version` meaning that it's not a dependency that ca

[Lldb-commits] [lldb] SBDebugger: define callback_token_t for win32 (PR #92870)

2024-05-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: antoine moynault (antmox) Changes fix lldb-aarch64-windows bot failure introduced by #89868 https://lab.llvm.org/buildbot/#/builders/219/builds/11583 --- Full diff: https://github.com/llvm/llvm-project/pull/92870.diff 1 Files Affected:

[Lldb-commits] [lldb] af8f155 - [lldb-dap] Don't send expanded descriptions for "hover" expressions (#92726)

2024-05-21 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-21T10:37:41+02:00 New Revision: af8f1554b8e7844304ce61b49b06e5b7946e9c47 URL: https://github.com/llvm/llvm-project/commit/af8f1554b8e7844304ce61b49b06e5b7946e9c47 DIFF: https://github.com/llvm/llvm-project/commit/af8f1554b8e7844304ce61b49b06e5b7946e9c47.diff

[Lldb-commits] [lldb] bbd54e0 - Reapply "[lldb/aarch64] Fix unwinding when signal interrupts a leaf f… (#92503)

2024-05-21 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-21T10:56:26+02:00 New Revision: bbd54e08b08f5ccd38c4665178e65c58f7b14459 URL: https://github.com/llvm/llvm-project/commit/bbd54e08b08f5ccd38c4665178e65c58f7b14459 DIFF: https://github.com/llvm/llvm-project/commit/bbd54e08b08f5ccd38c4665178e65c58f7b14459.diff

[Lldb-commits] [lldb] 9677e81 - [lldb/dwarf] Fix DW_IDX_parent processing for split dwarf (#92745)

2024-05-21 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-21T12:45:59+02:00 New Revision: 9677e8171c19f1a15c0234724f083bc9473c545a URL: https://github.com/llvm/llvm-project/commit/9677e8171c19f1a15c0234724f083bc9473c545a DIFF: https://github.com/llvm/llvm-project/commit/9677e8171c19f1a15c0234724f083bc9473c545a.diff

[Lldb-commits] [lldb] [lldb] Remove DWARFDebugInfo DIERef footguns (PR #92894)

2024-05-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes DWARFDebugInfo doesn't know how to resolve the "file_index" component of a DIERef. This patch removes GetUnit (in favor of existing GetUnitContainingDIEOffset) and changes GetDIE to take only the components it

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-21 Thread via lldb-commits
jeffreytan81 wrote: @jimingham, I have revised the PR, let me know when you can review again. Thanks. https://github.com/llvm/llvm-project/pull/90930 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-21 Thread via lldb-commits
royitaqi wrote: cc @clayborg and @jeffreytan81 https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 98f105a - [lldb] Add the word "backtrace" to bt help string (#92618)

2024-05-21 Thread via lldb-commits
Author: Dave Lee Date: 2024-05-21T10:16:51-07:00 New Revision: 98f105a1304e8d3fd0a0234d1d488ed513833df8 URL: https://github.com/llvm/llvm-project/commit/98f105a1304e8d3fd0a0234d1d488ed513833df8 DIFF: https://github.com/llvm/llvm-project/commit/98f105a1304e8d3fd0a0234d1d488ed513833df8.diff LOG:

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 3074060d6a1d7d2e74cb767876bd9e5192d12007...29b55fcba7a7f7b7ab0581f7804b9ad70863b0ff lldb

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3074060d6a1d7d2e74cb767876bd9e5192d12007 29b55fcba7a7f7b7ab0581f7804b9ad70863b0ff --

[Lldb-commits] [clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch remove 36 checks for compiler flags that are done via invoking the compiler across LLVM, Clang, and LLDB. It's was made possible by raising the bar for supported co

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-21 Thread via lldb-commits
@@ -362,6 +363,36 @@ llvm::json::Value DebuggerStats::ReportStatistics( global_stats.try_emplace("modules", std::move(json_modules)); global_stats.try_emplace("memory", std::move(json_memory)); global_stats.try_emplace("commands", std::move(cmd_stats)); + +// Wh

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-21 Thread via lldb-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/92953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Change GetChildCompilerTypeAtIndex to return Expected (NFC) (PR #92979)

2024-05-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes This change is a general improvement of the internal API. My motivation is to use this in the Swift typesystem plugin. --- Full diff: https://github.com/llvm/llvm-project/pull/92979.diff 10 Files Aff

[Lldb-commits] [lldb] Change GetChildCompilerTypeAtIndex to return Expected (NFC) (PR #92979)

2024-05-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0bc710f7c19910817ccff254c43496602635bbc9 8a6202f8ae92a62ce577271ec580379f1424f9e3 --

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-21 Thread via lldb-commits
royitaqi wrote: Hi @antmox, I'm sorry that it broke the lldb-aarch64-windows build. My bad. Your fix makes sense, though I do have the same comment as @labath had, i.e. to move that typedef outside platform-specific region. From the latest comments in that PR it seems it's already got moved.

[Lldb-commits] [lldb] SBDebugger: define callback_token_t for win32 (PR #92870)

2024-05-21 Thread via lldb-commits
royitaqi wrote: Thanks to @antmox and @labath for fixing this. My apologies for breaking the build. https://github.com/llvm/llvm-project/pull/92870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-05-21 Thread via lldb-commits
@@ -719,6 +776,10 @@ class ValueObject { ClearUserVisibleData(eClearUserVisibleDataItemsSummary); } + void SetDerefValobj(ValueObject *deref) { m_deref_valobj = deref; } cmtice wrote: I use the synthetic child providers way of getting the deref ValueOb

[Lldb-commits] [lldb] [lldb/DWARF] Make sure bad abbreviation codes do not crash lldb (PR #93006)

2024-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes We currently cannot represent abbreviation codes with more than 16 bits, and we were lldb-asserting if we ever ran into one. While I haven't seen any real DWARF with these kinds of abbreviations, it is possibl

[Lldb-commits] [lldb] [lldb-dap] Fix a race during shutdown (PR #91591)

2024-05-22 Thread via lldb-commits
kusmour wrote: > > I can't remember: does terminate come before disconnecting? Or is it the > > other way around? > > Disconnect docs say "The disconnect request asks the debug adapter to > disconnect from the debuggee (thus ending the debug session) and then to shut > down itself (the debug

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-22 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-05-22 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/4] [LLDB] Add more helper functions to ValueObject class. Create

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-05-22 Thread via lldb-commits
@@ -668,6 +699,32 @@ class ValueObject { CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data, const ExecutionContext &exe_ctx, CompilerType type); + static lldb::ValueObjectSP + CreateValueObjectFromBytes(lldb::TargetSP ta

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-05-22 Thread via lldb-commits
@@ -668,6 +699,32 @@ class ValueObject { CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data, const ExecutionContext &exe_ctx, CompilerType type); + static lldb::ValueObjectSP + CreateValueObjectFromBytes(lldb::TargetSP ta

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-05-22 Thread via lldb-commits
@@ -668,6 +699,32 @@ class ValueObject { CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data, const ExecutionContext &exe_ctx, CompilerType type); + static lldb::ValueObjectSP + CreateValueObjectFromBytes(lldb::TargetSP ta

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-05-22 Thread via lldb-commits
@@ -668,6 +699,32 @@ class ValueObject { CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data, const ExecutionContext &exe_ctx, CompilerType type); + static lldb::ValueObjectSP + CreateValueObjectFromBytes(lldb::TargetSP ta

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-05-22 Thread via lldb-commits
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::APSInt ValueObject::GetValueAsAPSInt() { + lldb::TargetSP target = GetTargetSP(); + uint64_t byte_size = 0; + if (auto temp = GetCompilerType().

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-05-22 Thread via lldb-commits
cmtice wrote: I'm sorry this has taken me so long, but I believe I have addressed/fixed everyone's comments now; if I missed any please let me know. Please review this PR again. https://github.com/llvm/llvm-project/pull/87197 ___ lldb-commits maili

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-05-22 Thread via lldb-commits
@@ -2809,6 +2919,243 @@ ValueObjectSP ValueObject::CastPointerType(const char *name, TypeSP &type_sp) { return valobj_sp; } +lldb::addr_t ValueObject::GetLoadAddress() { + lldb::addr_t addr_value = LLDB_INVALID_ADDRESS; + lldb::TargetSP target_sp = GetTargetSP(); + if (t

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-22 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/92492 >From 304528acdd3590bf4d8d1a03e31fd0970ed2eaa2 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 14 May 2024 16:18:20 -0700 Subject: [PATCH] Read and store gnu build id from loaded core file --- .../Plug

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-22 Thread via lldb-commits
@@ -271,6 +282,17 @@ Status ProcessElfCore::DoLoadCore() { return error; } +void ProcessElfCore::UpdateBuildIdForNTFileEntries() { + if (!m_nt_file_entries.empty()) { GeorgeHuyubo wrote: @labath There are two reasons, 1. We need to do this after we load P

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-22 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/92492 >From fc7ae3cd19a999375504733be6c942978d80d5d7 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 14 May 2024 16:18:20 -0700 Subject: [PATCH] Read and store gnu build id from loaded core file --- .../Plug

[Lldb-commits] [lldb] ac1dc05 - Change GetChildCompilerTypeAtIndex to return Expected (NFC) (#92979)

2024-05-22 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-05-22T08:52:33-07:00 New Revision: ac1dc05b331d35f341631f798673fe8aafdda53d URL: https://github.com/llvm/llvm-project/commit/ac1dc05b331d35f341631f798673fe8aafdda53d DIFF: https://github.com/llvm/llvm-project/commit/ac1dc05b331d35f341631f798673fe8aafdda53d.diff

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-22 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/92492 >From 4e4ca8edc4116cba0925cca8229bd5b1cb002b21 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 14 May 2024 16:18:20 -0700 Subject: [PATCH] Read and store gnu build id from loaded core file --- .../Proc

[Lldb-commits] [lldb] e558d21 - [lldb] Added Debuginfod tests and fixed a couple issues (#92572)

2024-05-22 Thread via lldb-commits
Author: Kevin Frei Date: 2024-05-22T10:31:04-07:00 New Revision: e558d21e87882d40e29d858b1269ee8f1ddf2a38 URL: https://github.com/llvm/llvm-project/commit/e558d21e87882d40e29d858b1269ee8f1ddf2a38 DIFF: https://github.com/llvm/llvm-project/commit/e558d21e87882d40e29d858b1269ee8f1ddf2a38.diff LO

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-22 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/92492 >From 11dda0b456880005695b6d1f195060788ad0edb7 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 14 May 2024 16:18:20 -0700 Subject: [PATCH] Read and store gnu build id from loaded core file --- .../Proc

[Lldb-commits] [lldb] c93a670 - Revert "[lldb] Added Debuginfod tests and fixed a couple issues" (#93094)

2024-05-22 Thread via lldb-commits
Author: Daniel Thornburgh Date: 2024-05-22T13:56:33-07:00 New Revision: c93a67038dcc1adeafa74e105fba02714732097a URL: https://github.com/llvm/llvm-project/commit/c93a67038dcc1adeafa74e105fba02714732097a DIFF: https://github.com/llvm/llvm-project/commit/c93a67038dcc1adeafa74e105fba02714732097a.d

[Lldb-commits] [lldb] Revert "[lldb] Added Debuginfod tests and fixed a couple issues" (PR #93094)

2024-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Daniel Thornburgh (mysterymath) Changes Reverts llvm/llvm-project#92572 due to Fuchsia CI breakages (using CLI tools in tests that weren't necessarily built). --- Patch is 27.56 KiB, truncated to 20.00 KiB below, full version: https://gi

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-22 Thread via lldb-commits
@@ -1312,10 +1312,16 @@ class Process : public std::enable_shared_from_this, size_t GetThreadStatus(Stream &ostrm, bool only_threads_with_stop_reason, uint32_t start_frame, uint32_t num_frames, - uint32_t num_frames_with_sour

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-22 Thread via lldb-commits
@@ -1312,10 +1312,16 @@ class Process : public std::enable_shared_from_this, size_t GetThreadStatus(Stream &ostrm, bool only_threads_with_stop_reason, uint32_t start_frame, uint32_t num_frames, - uint32_t num_frames_with_sour

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-22 Thread via lldb-commits
@@ -0,0 +1,96 @@ +//===-- ThreadPlanSingleThreadTimeout.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-22 Thread via lldb-commits
@@ -42,8 +45,13 @@ class ThreadPlanStepOverRange : public ThreadPlanStepRange, void SetupAvoidNoDebug(LazyBool step_out_avoids_code_without_debug_info); bool IsEquivalentContext(const SymbolContext &context); + // Clear and create a new ThreadPlanSingleThreadTimeout to de

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-22 Thread via lldb-commits
@@ -440,6 +440,12 @@ class ProcessGDBRemote : public Process, void HandleStopReply() override; void HandleAsyncStructuredDataPacket(llvm::StringRef data) override; + // Handle thread specific async interrupt and return the original thread + // that requested the async in

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-22 Thread via lldb-commits
@@ -3905,9 +3911,14 @@ thread_result_t Process::RunPrivateStateThread(bool is_secondary_thread) { if (interrupt_requested) { if (StateIsStoppedState(internal_state, true)) { - // We requested the interrupt, so mark this as such in the stop event -

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-22 Thread via lldb-commits
@@ -1125,6 +1125,38 @@ class StopInfoUnixSignal : public StopInfo { std::optional m_code; }; +// StopInfoInterrupt + +class StopInfoInterrupt : public StopInfo { +public: + StopInfoInterrupt(Thread &thread, int signo, const char *description) + : StopInfo(thread, signo

[Lldb-commits] [lldb] [lldb] Fixed the TestExitDuringExpression test in case of a remote target (PR #93119)

2024-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Sometimes this test failed on the assert `The thread exited` in case of a remote target. Increase the timeout to 1 second to avoid a racing condition. --- Full diff: https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] [lldb][Windows] Fixed the TestBreakpointCommand test (PR #93122)

2024-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The TestBreakpointCommand test is incorrectly disabled for Windows target. We can disable it for Windows host instead or just fix the issue. This patch fixes the path separator in BreakpointResolverFileLi

[Lldb-commits] [lldb] [lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (Reland #70392) (PR #93149)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch makes ScriptedThreadPlan conforming to the ScriptedInterface & ScriptedPythonInterface facilities by introducing 2 ScriptedThreadPlanInterface & ScriptedThreadPlanPythonInterface classes

[Lldb-commits] [lldb] 4cc6d0f - [lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (Reland #70392) (#93149)

2024-05-23 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-05-23T01:25:48-07:00 New Revision: 4cc6d0f4dfb26deb9863901c70258d6d7f0c8ba4 URL: https://github.com/llvm/llvm-project/commit/4cc6d0f4dfb26deb9863901c70258d6d7f0c8ba4 DIFF: https://github.com/llvm/llvm-project/commit/4cc6d0f4dfb26deb9863901c70258d6d7f0c8ba4.

[Lldb-commits] [lldb] ae3f680 - Revert "[lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (Reland #70392)" (#93153)

2024-05-23 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-05-23T01:46:29-07:00 New Revision: ae3f68066c8f282145435880107c1d3dc26ec3b8 URL: https://github.com/llvm/llvm-project/commit/ae3f68066c8f282145435880107c1d3dc26ec3b8 DIFF: https://github.com/llvm/llvm-project/commit/ae3f68066c8f282145435880107c1d3dc26ec3b8.

[Lldb-commits] [lldb] Revert "[lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (Reland #70392)" (PR #93153)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes Reverts llvm/llvm-project#93149 since it breaks https://lab.llvm.org/buildbot/#/builders/68/builds/74799 --- Patch is 60.44 KiB, truncated to 20.00 KiB below, full version: https://github.com/llv

[Lldb-commits] [lldb] a282463 - [lldb/DWARF] Make sure bad abbreviation codes do not crash lldb (#93006)

2024-05-23 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-23T11:23:07+02:00 New Revision: a2824632cba8e7d98a5cbf9acb3ca5d9960c95cb URL: https://github.com/llvm/llvm-project/commit/a2824632cba8e7d98a5cbf9acb3ca5d9960c95cb DIFF: https://github.com/llvm/llvm-project/commit/a2824632cba8e7d98a5cbf9acb3ca5d9960c95cb.diff

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes DumpValueObjectOptions can only be created and modified from C++. This means it's currently only testable from Python by calling some command that happens to use one, and even so, you can't pick which

[Lldb-commits] [lldb] 4d9e7b1 - [lldb][Windows] Fixed the TestBreakpointCommand test (#93122)

2024-05-23 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-23T13:59:02+04:00 New Revision: 4d9e7b14e45120557e57da2f00f6d23cf122dd95 URL: https://github.com/llvm/llvm-project/commit/4d9e7b14e45120557e57da2f00f6d23cf122dd95 DIFF: https://github.com/llvm/llvm-project/commit/4d9e7b14e45120557e57da2f00f6d23cf122dd95.dif

[Lldb-commits] [lldb] e37da2c - [lldb] Fixed the TestExitDuringExpression test in case of a remote target (#93119)

2024-05-23 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-23T14:01:10+04:00 New Revision: e37da2cef7ea44f6aa52dd37978b287a0741c39f URL: https://github.com/llvm/llvm-project/commit/e37da2cef7ea44f6aa52dd37978b287a0741c39f DIFF: https://github.com/llvm/llvm-project/commit/e37da2cef7ea44f6aa52dd37978b287a0741c39f.dif

[Lldb-commits] [lldb] [lldb] Fixed the TestDAP_repl_mode_detection test in case of a remote target (PR #93165)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This test is based on dap_server which runs locally. This test failed in case of Windows host and Linux target. --- Full diff: https://github.com/llvm/llvm-project/pull/93165.diff 1 Files Affected: - (

[Lldb-commits] [lldb] [lldb-dap] Automatically skip lldb-dap tests for remote platforms (PR #93169)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The don't currently work (and they're also not particularly useful, since all of the remote stuff happens inside lldb). This saves us from annotating tests one by one. --- Patch is 32.71 KiB, truncated to 20

[Lldb-commits] [lldb] [lldb-dap] Send terminated event only once (PR #93172)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This is a regression from #91591. Turns out std::mutex does not prevent code from running twice. :facepalm: --- Full diff: https://github.com/llvm/llvm-project/pull/93172.diff 2 Files Affected: - (modified)

[Lldb-commits] [lldb] 4feae05 - Remove some `try_compile` CMake checks for compiler flags (#92953)

2024-05-23 Thread via lldb-commits
Author: Vlad Serebrennikov Date: 2024-05-23T17:05:41+04:00 New Revision: 4feae05c6abda364a9295aecfa600d7d4e7dfeb6 URL: https://github.com/llvm/llvm-project/commit/4feae05c6abda364a9295aecfa600d7d4e7dfeb6 DIFF: https://github.com/llvm/llvm-project/commit/4feae05c6abda364a9295aecfa600d7d4e7dfeb6.

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Adrian Prantl (adrian-prantl) Changes For the significant amount of call sites that want to create an incontrovertible error, such a wrapper function creates a significant readability improvement and lowers the cost of entry to add

[Lldb-commits] [lldb] [lldb-dap] Send terminated event only once (PR #93172)

2024-05-23 Thread via lldb-commits
https://github.com/kusmour approved this pull request. Thanks for fixing it :) Just tested this patch from my side, worked well! https://github.com/llvm/llvm-project/pull/93172 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] [lldb-dap] Send terminated event only once (PR #93172)

2024-05-23 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/93172 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-23 Thread via lldb-commits
jimingham wrote: LGTM. We do offer SBValue::GetDescription, which uses a default DumpValueObjectOptions. So it would be entirely reasonable to make an SBValueObjectDescriptionOptions (or maybe a shorter name?) and add SBValue::GetDescription(SBValueObjectDescriptionOptions) API. But peopl

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -16,9 +16,12 @@ #include "lldb/DataFormatters/VectorIterator.h" #include "lldb/Target/Target.h" #include "lldb/Utility/DataBufferHeap.h" +#include "lldb/Utility/DataExtractor.h" #include "lldb/Utility/Endian.h" #include "lldb/Utility/Status.h" #include "lldb/Utility/Strea

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -2763,10 +2763,10 @@ ValueObjectSP ValueObject::Cast(const CompilerType &compiler_type) { ExecutionContextScope *exe_scope = ExecutionContext(GetExecutionContextRef()) .GetBestExecutionContextScope(); - if (compiler_type.GetByteSize(exe_scope) - <= G

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -0,0 +1,49 @@ +# coding=utf8 +""" +Helper formmater to verify Std::String by created via SBData jimingham wrote: formmater -> formatter https://github.com/llvm/llvm-project/pull/89110 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -17,6 +17,15 @@ def setUp(self): # Find the line number to break at. self.line = line_number("main.cpp", "// Set break point at this line.") +# This is the function to remove the custom formats in order to have a jimingham wrote: If you

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -17,6 +17,15 @@ def setUp(self): # Find the line number to break at. self.line = line_number("main.cpp", "// Set break point at this line.") +# This is the function to remove the custom formats in order to have a jimingham wrote: Ah, I

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/89110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-23 Thread via lldb-commits
@@ -254,13 +254,17 @@ bool lldb_private::formatters::LibStdcppStringSummaryProvider( } else addr_of_string = valobj.GetAddressOf(scalar_is_load_addr, &addr_type); - if (addr_of_string != LLDB_INVALID_ADDRESS) { + + // We have to check for host address here + /

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-23 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/92492 >From a9714b155a116e9b1d18434c0485ea2ad35680f3 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 14 May 2024 16:18:20 -0700 Subject: [PATCH] Read and store gnu build id from loaded core file --- .../Proc

<    6   7   8   9   10   11   12   13   14   15   >