[Lldb-commits] [lldb] [lldb] Don't unregister a listener that's being destroyed (PR #97300)

2024-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes It's not necessary because the broadcasters (and broadcast managers) hold a weak_ptr (*) to it, and will delete the weak_ptr next time they try to lock it. Doing this prevents recursion in RemoveListener, wher

[Lldb-commits] [lldb] ea4cf92 - [lldb][FreeBSD][AArch64] Enable register field detection (#85058)

2024-07-01 Thread via lldb-commits
Author: David Spickett Date: 2024-07-01T16:18:57+01:00 New Revision: ea4cf923edf441897c31edd59a0d7bc8c6f380ff URL: https://github.com/llvm/llvm-project/commit/ea4cf923edf441897c31edd59a0d7bc8c6f380ff DIFF: https://github.com/llvm/llvm-project/commit/ea4cf923edf441897c31edd59a0d7bc8c6f380ff.diff

[Lldb-commits] [lldb] 65c807e - [lldb][TypeSystemClang] Allow transparent lookup through anonymous namespaces (#97275)

2024-07-01 Thread via lldb-commits
Author: Michael Buch Date: 2024-07-01T17:21:58+02:00 New Revision: 65c807e69545ec23c1a258f66f744874531c7d26 URL: https://github.com/llvm/llvm-project/commit/65c807e69545ec23c1a258f66f744874531c7d26 DIFF: https://github.com/llvm/llvm-project/commit/65c807e69545ec23c1a258f66f744874531c7d26.diff

[Lldb-commits] [lldb] Disable TestUseSourceCache on Windows (PR #97324)

2024-07-01 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] Disable TestUseSourceCache on Windows (PR #97324)

2024-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kendal Harland (kendalharland) Changes This test also fails on Windows amd64, although it is only disabled for aarch64. --- Full diff: https://github.com/llvm/llvm-project/pull/97324.diff 1 Files Affected: - (modified) lldb/test/API/com

[Lldb-commits] [lldb] Fix type error when calling random.randrange with 'float' arg (PR #97328)

2024-07-01 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-01 Thread via lldb-commits
jimingham wrote: > A high-level concern that I have with this is the grammar is full of > C++-specific nodes, which is not something I would like to see in living in > `Core`. Have we previously reached any consensus on how we want to handle > different languages in DIL? I would be more comfor

[Lldb-commits] [lldb] Fix type error when calling random.randrange with 'float' arg (PR #97328)

2024-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kendal Harland (kendalharland) Changes This test only runs on Windows and fails because we're passing a literal of the wrong type to random.randrange. --- Full diff: https://github.com/llvm/llvm-project/pull/97328.diff 1 Files Affected:

[Lldb-commits] [lldb] [lldb] Don't unregister a listener that's being destroyed (PR #97300)

2024-07-01 Thread via lldb-commits
jimingham wrote: This LGTM. W.R.T. your comment about Primary Listeners... For the most part, Broadcaster classes don't actually need Listeners to function. The breakpoint system can work just fine if no one is listening to breakpoint changed events on the target. So it never sets a Primary

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-07-01 Thread via lldb-commits
Prabhuk wrote: I am part of the Fuchsia toolchain team. Our Clang toolchain CI builders crash and I suspect this change is the reason. I am verifying that. But here's the log: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8743609724828014497/+/u/clang/build/stdout and the

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting execute` (PR #97263)

2024-07-01 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r a9c12e481bfef5b2913e2241486f4dd450188cd2...1f3d0498ccedc4c8adef01d44c29be8b1a78b133 lldb/

[Lldb-commits] [lldb] dd5df27 - [lldb] Make semantics of SupportFile equivalence explicit (#97126)

2024-07-01 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-07-01T12:54:35-07:00 New Revision: dd5df27d9c6b47793b72d4c8f2a796e5d8dc343d URL: https://github.com/llvm/llvm-project/commit/dd5df27d9c6b47793b72d4c8f2a796e5d8dc343d DIFF: https://github.com/llvm/llvm-project/commit/dd5df27d9c6b47793b72d4c8f2a796e5d8dc343d.d

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-01 Thread via lldb-commits
@@ -11,6 +11,65 @@ some of these things by going through an example, explaining how to use Python scripting to find a bug in a program that searches for text in a large binary tree. +Operating System Thread Plugins +--- + +.. automodapi:: lldb.plug

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-01 Thread via lldb-commits
@@ -0,0 +1,70 @@ +from abc import abstractmethod + +import lldb + + +class ScriptedThreadPlan: +""" +Class that provides data for an instance of a LLDB 'ScriptedThreadPlan' plug-in class used to construct custom stepping logic. + +""" + +def __init__(self, thread_

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-01 Thread via lldb-commits
@@ -0,0 +1,70 @@ +from abc import abstractmethod + +import lldb + + +class ScriptedThreadPlan: +""" +Class that provides data for an instance of a LLDB 'ScriptedThreadPlan' plug-in class used to construct custom stepping logic. + +""" + +def __init__(self, thread_

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting execute` (PR #97263)

2024-07-01 Thread via lldb-commits
@@ -9,14 +9,21 @@ #ifndef LLDB_SOURCE_INTERPRETER_COMMANDOBJECTSCRIPT_H #define LLDB_SOURCE_INTERPRETER_COMMANDOBJECTSCRIPT_H -#include "lldb/Interpreter/CommandObject.h" +#include "lldb/Interpreter/CommandObjectMultiword.h" namespace lldb_private { -class CommandObjectSc

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting execute` (PR #97263)

2024-07-01 Thread via lldb-commits
@@ -80,7 +80,9 @@ def test_command_abbreviations_and_aliases(self): # Check a command that wants the raw input. command_interpreter.ResolveCommand(r"""sc print("\n\n\tHello!\n")""", result) self.assertTrue(result.Succeeded()) -self.assertEqual(r

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting execute` (PR #97263)

2024-07-01 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM with a couple little nits. https://github.com/llvm/llvm-project/pull/97263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting execute` (PR #97263)

2024-07-01 Thread via lldb-commits
@@ -518,6 +518,15 @@ void CommandInterpreter::Initialize() { AddAlias("re", cmd_obj_sp); } + cmd_obj_sp = GetCommandSPExact("scripting execute"); + if (cmd_obj_sp) { +AddAlias("sc", cmd_obj_sp); +AddAlias("scr", cmd_obj_sp); +AddAlias("scri", cmd_obj_sp); +

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting execute` (PR #97263)

2024-07-01 Thread via lldb-commits
jimingham wrote: > In addition to the comment about unique prefixes, my only other comment is, > have you considered `scripting run`? The problem with this command is that it either executes a script given to it on the command line, or it runs the embedded script interpreter... https://gith

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-01 Thread via lldb-commits
@@ -0,0 +1,70 @@ +from abc import abstractmethod + +import lldb + + +class ScriptedThreadPlan: +""" +Class that provides data for an instance of a LLDB 'ScriptedThreadPlan' plug-in class used to construct custom stepping logic. + +""" + +def __init__(self, thread_

[Lldb-commits] [lldb] fix issue with debug-types-dwo-cross-reference.cpp.tmp test (PR #97381)

2024-07-01 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] fix issue with debug-types-dwo-cross-reference.cpp.tmp test (PR #97381)

2024-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Paul Johnston (pauljohnston2009) Changes fixes issue from https://github.com/llvm/llvm-project/issues/97380 --- Full diff: https://github.com/llvm/llvm-project/pull/97381.diff 1 Files Affected: - (modified) lldb/test/Shell/SymbolFile/DW

[Lldb-commits] [lldb] 410de0c - [lldb/Commands] Alias `script` command to `scripting run` (#97263)

2024-07-01 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-07-01T21:35:21-07:00 New Revision: 410de0c8c831a4a63075dd03f80ca83205860746 URL: https://github.com/llvm/llvm-project/commit/410de0c8c831a4a63075dd03f80ca83205860746 DIFF: https://github.com/llvm/llvm-project/commit/410de0c8c831a4a63075dd03f80ca83205860746.

[Lldb-commits] [lldb] 91c0ef6 - [lldb] [ObjectFileMachO] BSS segments are loadable segments (#96983)

2024-07-01 Thread via lldb-commits
Author: Jason Molenda Date: 2024-07-01T21:56:33-07:00 New Revision: 91c0ef6f67821eb7298cb05988045e92354ac77b URL: https://github.com/llvm/llvm-project/commit/91c0ef6f67821eb7298cb05988045e92354ac77b DIFF: https://github.com/llvm/llvm-project/commit/91c0ef6f67821eb7298cb05988045e92354ac77b.diff

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

2024-07-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 7c83b7ef1796210451b839f4c58f2815f4aedfe5...e3d44a2fed3d4129e245d5695c3af0c21bb7b329 lldb/

[Lldb-commits] [lldb] 01e96c8 - [lldb] Don't unregister a listener that's being destroyed (#97300)

2024-07-02 Thread via lldb-commits
Author: Pavel Labath Date: 2024-07-02T10:08:03+02:00 New Revision: 01e96c86497ac9670e1168134870beb99cbd4d8f URL: https://github.com/llvm/llvm-project/commit/01e96c86497ac9670e1168134870beb99cbd4d8f DIFF: https://github.com/llvm/llvm-project/commit/01e96c86497ac9670e1168134870beb99cbd4d8f.diff

[Lldb-commits] [lldb] [lldb] Make Broadcaster mutexes non-recursive (PR #97400)

2024-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Non-recursive mutexes encourage better locking discipline and avoid bugs like #96750, where one can unexpectedly re-enter the critical section on the same thread, and interrupt a presumed-indivisible operation

[Lldb-commits] [lldb] 2da1095 - [lldb][test] Disable TestUseSourceCache on Windows (#97324)

2024-07-02 Thread via lldb-commits
Author: Kendal Harland Date: 2024-07-02T11:06:12+01:00 New Revision: 2da10959e00a81b983a0ea6d5c1ba9e0f2e1f192 URL: https://github.com/llvm/llvm-project/commit/2da10959e00a81b983a0ea6d5c1ba9e0f2e1f192 DIFF: https://github.com/llvm/llvm-project/commit/2da10959e00a81b983a0ea6d5c1ba9e0f2e1f192.diff

[Lldb-commits] [lldb] [lldb][test] Disable TestUseSourceCache on Windows (PR #97324)

2024-07-02 Thread via lldb-commits
github-actions[bot] wrote: @kendalharland Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-02 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/95738 >From c703c473147e3e554a98014319294668a0ec790d Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 16 Jun 2024 16:32:47 -0700 Subject: [PATCH 1/3] [LLDB] Add AST node classes, functions, etc. for Data Inspect

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-02 Thread via lldb-commits
cmtice wrote: As requested, I have updated this PR to only include the pieces needed to reproduce current (default) 'frame variable' behavior with DIL. I have also updated the BNF file accordingly. I agree with Jim re the DIL language: We should only have a single language definition, and i

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 436872693a8a57487bf4510437183878d1e35cfb c230c2844814b0edcf90c0b62dd8030cd6a5a0a8 --

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-02 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/95738 >From c703c473147e3e554a98014319294668a0ec790d Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 16 Jun 2024 16:32:47 -0700 Subject: [PATCH 1/4] [LLDB] Add AST node classes, functions, etc. for Data Inspect

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

2024-07-02 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. Sorry, was in the middle of review then got interrupted/distracted by other stuff yesterday. Looks good. https://github.com/llvm/llvm-project/pull/96687 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] [lldb] [ObjectFileELF] Detect QNX Neutrino RTOS targets (PR #97439)

2024-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ayush Sahay (ayushsahay1837) Changes This change detects _QNX Neutrino Real-Time Operating System_ targets, and is the second in a series of changes that look to facilitate remote debug of _AArch64_ targets on _QNX_. _QNX Neutrino Real-Ti

[Lldb-commits] [clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2024-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Buch (Michael137) Changes This patch is motivated by the LLDB support required for: https://github.com/llvm/llvm-project/issues/93069 In the presence of `[[no_unique_address]]`, LLDB may ask Clang to lay out types with overlappin

[Lldb-commits] [lldb] [lldb] Don't unregister a listener that's being destroyed (PR #97300)

2024-07-02 Thread via lldb-commits
jimingham wrote: > Thanks for the explanation. I believe I understand the purpose of the primary > listener. While I'm not sure that a "shared pointer" is the best way to > express the "someone must exist on the other end to pull the events" notion, > I'm not interested in revisiting that deci

[Lldb-commits] [lldb] [lldb] Make Broadcaster mutexes non-recursive (PR #97400)

2024-07-02 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM, non-recursive mutex's are much easier to reason about for sure. Thanks for the unit test! https://github.com/llvm/llvm-project/pull/97400 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] 59f4267 - [lldb/docs] Add scripting extensions documentation to the website (#97262)

2024-07-02 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-07-02T12:52:50-07:00 New Revision: 59f4267c8e0625c6583327be2db1608930f2d796 URL: https://github.com/llvm/llvm-project/commit/59f4267c8e0625c6583327be2db1608930f2d796 DIFF: https://github.com/llvm/llvm-project/commit/59f4267c8e0625c6583327be2db1608930f2d796.

[Lldb-commits] [lldb] [lldb] Add scripted thread plan python base class to lldb & website (PR #97481)

2024-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes Following a feedback request in #97262, I took out the scripted thread plan python base class from it and make a separate PR for it. This patch adds the scripted thread plan base python class to th

[Lldb-commits] [lldb] Add the ability for Script based commands to specify their "repeat command" (PR #94823)

2024-07-02 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/94823 >From c2fea75364a0017be5e59020467d661bd00122ba Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 7 Jun 2024 17:36:34 -0700 Subject: [PATCH 1/4] Add the ability for Script based commands to specify their "re

[Lldb-commits] [lldb] [lldb] [Platform] Introduce PlatformQNX (PR #97487)

2024-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ayush Sahay (ayushsahay1837) Changes This change provisions the _QNX_ platform plugin, and is the third in a series of changes that look to facilitate remote debug of _AArch64_ targets on _QNX_. _QNX Neutrino Real-Time Operating System_ is

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities Author: Jacob Lalonde (Jlalond) Changes Currently, LLDB assumes all minidumps will have unique sections. This is intuitive because almost all of the minidump sections are themselves lists. Exceptions including Signals are unique i

[Lldb-commits] [lldb] 622df0e - [lldb] Add scripted thread plan python base class to lldb & website (#97481)

2024-07-02 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-07-02T15:20:18-07:00 New Revision: 622df0ee9226b90e924538909337d55333d5d2fa URL: https://github.com/llvm/llvm-project/commit/622df0ee9226b90e924538909337d55333d5d2fa DIFF: https://github.com/llvm/llvm-project/commit/622df0ee9226b90e924538909337d55333d5d2fa.

[Lldb-commits] [clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 60d4a3517610494e5b2ef6bf347cdc71a6a979e5 6c6f17ca827feb8384441cbd6d44493954ba726f --

[Lldb-commits] [lldb] [lldb] Improve error message for unrecognized executables (PR #97490)

2024-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Currently, LLDB prints out a rather unhelpful error message when passed a file that it doesn't recognize as an executable. > error: '/path/to/file' doesn't contain any 'host' platform > architecture

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread via lldb-commits
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw { CommandOptions m_options; }; +#pragma mark CommandObjectScriptingTemplateList + +#define LLDB_OPTIONS_scripting_template_list +#include "CommandOptions.inc" + +class CommandObjectScriptingTemp

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread via lldb-commits
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw { CommandOptions m_options; }; +#pragma mark CommandObjectScriptingTemplateList + +#define LLDB_OPTIONS_scripting_template_list +#include "CommandOptions.inc" + +class CommandObjectScriptingTemp

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread via lldb-commits
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw { CommandOptions m_options; }; +#pragma mark CommandObjectScriptingTemplateList + +#define LLDB_OPTIONS_scripting_template_list +#include "CommandOptions.inc" + +class CommandObjectScriptingTemp

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread via lldb-commits
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw { CommandOptions m_options; }; +#pragma mark CommandObjectScriptingTemplateList + +#define LLDB_OPTIONS_scripting_template_list +#include "CommandOptions.inc" + +class CommandObjectScriptingTemp

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread via lldb-commits
@@ -841,6 +841,12 @@ let Command = "scripting run" in { " language. If none is specific the default scripting language is used.">; } +let Command = "scripting template list" in { + def scripting_template_list_language : Option<"language", "l">, +EnumArg<"ScriptLang">,

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread via lldb-commits
@@ -841,6 +841,12 @@ let Command = "scripting run" in { " language. If none is specific the default scripting language is used.">; } +let Command = "scripting template list" in { + def scripting_template_list_language : Option<"language", "l">, +EnumArg<"ScriptLang">,

[Lldb-commits] [lldb] SBThread::StepInstruction shouldn't discard other plans (PR #97493)

2024-07-02 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/97493 This was just a typo, none of the external execution control functions should discard other plans. In particular, it means if you stop in a hand-called function and step an instruction, the function call thre

[Lldb-commits] [lldb] SBThread::StepInstruction shouldn't discard other plans (PR #97493)

2024-07-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes This was just a typo, none of the external execution control functions should discard other plans. In particular, it means if you stop in a hand-called function and step an instruction, the function call thread pl

[Lldb-commits] [lldb] SBThread::StepInstruction shouldn't discard other plans (PR #97493)

2024-07-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 57555c6a0a96790bf1408b056405abe07899ead4...3fba16eaee25b1d63907640b79019309e9c019a7 lldb/

[Lldb-commits] [lldb] SBThread::StepInstruction shouldn't discard other plans (PR #97493)

2024-07-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 57555c6a0a96790bf1408b056405abe07899ead4 3fba16eaee25b1d63907640b79019309e9c019a7 --

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4e567242133678c88a6cb5aeb979c6148f6a7035 54e2299fead40dba247c65ea4974a550843a9b6d --

[Lldb-commits] [lldb] b77e734 - [lldb][AArch64] Add register field enum information (#96887)

2024-07-03 Thread via lldb-commits
Author: David Spickett Date: 2024-07-03T08:43:29+01:00 New Revision: b77e734e4e6c8f5e016ba3ac49526862e6039482 URL: https://github.com/llvm/llvm-project/commit/b77e734e4e6c8f5e016ba3ac49526862e6039482 DIFF: https://github.com/llvm/llvm-project/commit/b77e734e4e6c8f5e016ba3ac49526862e6039482.diff

[Lldb-commits] [lldb] [lldb] [DynamicLoaderPOSIXDYLD] Enable POSIX-DYLD for QNX (PR #97536)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ayush Sahay (ayushsahay1837) Changes This change enables the _POSIX_ dynamic loader plugin for _QNX_, and is the fourth in a series of changes that look to facilitate remote debug of _AArch64_ targets on _QNX_. _QNX Neutrino Real-Time Ope

[Lldb-commits] [lldb] 2a14c06 - [lldb] Make Broadcaster mutexes non-recursive (#97400)

2024-07-03 Thread via lldb-commits
Author: Pavel Labath Date: 2024-07-03T10:29:17+02:00 New Revision: 2a14c0643597c5932af85f22172c99800f9b4a6c URL: https://github.com/llvm/llvm-project/commit/2a14c0643597c5932af85f22172c99800f9b4a6c DIFF: https://github.com/llvm/llvm-project/commit/2a14c0643597c5932af85f22172c99800f9b4a6c.diff

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Factor out MapIterator logic into separate helper (PR #97544)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch factors all the logic for advancing the `MapIterator` out of `GetChildAtIndex`. This, in my opinion, helps readability, and will be useful for upcoming cleanups in this area. While here, some d

[Lldb-commits] [lldb] [lldb][DataFormatter] Remove support for old std::map layout (PR #97549)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes We currently supported the layout from pre-2016 (before the layout change in [14caaddd3f08e798dcd9ac0ddfc](https://github.com/llvm/llvm-project/commit/14caaddd3f08e798dcd9ac0ddfc)). We have another upcoming

[Lldb-commits] [lldb] [lldb][DataFormatter] Clean up LibcxxStdMapSyntheticFrontEnd::GetKeyValuePair (PR #97551)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch cleans up the core of the `std::map` libc++ formatter. Depends on https://github.com/llvm/llvm-project/pull/97544 and https://github.com/llvm/llvm-project/pull/97549. Changes: * Renamed `m_skip

[Lldb-commits] [lldb] [lldb] Make Listener::m_broadcasters_mutex non-recursive (PR #97552)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Follow-up to #97400. No changes apart from changing the type were necessary. The mutex was already not used recursively. --- Full diff: https://github.com/llvm/llvm-project/pull/97552.diff 2 Files Affected:

[Lldb-commits] [lldb] [lldb] Print empty enums as if they were unrecognised normal enums (PR #97553)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Fixes #97514 Given this example: ``` enum E {}; int main() { E x = E(0); E y = E(1); E z = E(2); return 0; } ``` lldb used to print nothing for `x`, but `0x1` for `y` and `0x2` for `z`

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes It's not used since https://reviews.llvm.org/D157556. --- Full diff: https://github.com/llvm/llvm-project/pull/97555.diff 4 Files Affected: - (modified) lldb/include/lldb/Utility/Listener.h (-3) - (modified

[Lldb-commits] [lldb] [lldb] Print "0x0" for bitfield like enums where the value is 0 (PR #97557)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Enums like this one are treated as bitfield like enums: enum FlagsLike {B=2, C=4}; lldb recognises them as collections of flags, so you can have "B | C". If there's any values not covered that's prin

[Lldb-commits] [lldb] [lldb] Make variant formatter work with libstdc++-14 (PR #97568)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes In this version the internal data member has grown an additional template parameter (bool), which was throwing the summary provider off. This patch uses the type of the entire variant object. This is part of t

[Lldb-commits] [lldb] [lldb] Make variant formatter work with libstdc++-14 (PR #97568)

2024-07-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 2a14c0643597c5932af85f22172c99800f9b4a6c...53b9fda6f7bf0ec4df32869c9d4ba2203aa1870a lldb/

[Lldb-commits] [lldb] dde3f17 - [lldb] Fix printing of unsigned enum bitfields when they contain the max value (#96202)

2024-07-03 Thread via lldb-commits
Author: David Spickett Date: 2024-07-03T14:30:47+01:00 New Revision: dde3f17026be48c05a5d3876f12db72fdd6422ed URL: https://github.com/llvm/llvm-project/commit/dde3f17026be48c05a5d3876f12db72fdd6422ed DIFF: https://github.com/llvm/llvm-project/commit/dde3f17026be48c05a5d3876f12db72fdd6422ed.diff

[Lldb-commits] [lldb] 41fddc4 - [lldb] Print empty enums as if they were unrecognised normal enums (#97553)

2024-07-03 Thread via lldb-commits
Author: David Spickett Date: 2024-07-03T14:47:55+01:00 New Revision: 41fddc4ec3302f125a5b84ae86c8027dedc89984 URL: https://github.com/llvm/llvm-project/commit/41fddc4ec3302f125a5b84ae86c8027dedc89984 DIFF: https://github.com/llvm/llvm-project/commit/41fddc4ec3302f125a5b84ae86c8027dedc89984.diff

[Lldb-commits] [lldb] 3101524 - [lldb] Print "0x0" for bitfield like enums where the value is 0 (#97557)

2024-07-03 Thread via lldb-commits
Author: David Spickett Date: 2024-07-03T14:48:48+01:00 New Revision: 31015240d366e4bf6f114856caa6e9ce90742b7f URL: https://github.com/llvm/llvm-project/commit/31015240d366e4bf6f114856caa6e9ce90742b7f DIFF: https://github.com/llvm/llvm-project/commit/31015240d366e4bf6f114856caa6e9ce90742b7f.diff

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::map formatter (PR #97579)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Depends on: * https://github.com/llvm/llvm-project/pull/97544 * https://github.com/llvm/llvm-project/pull/97549 * https://github.com/llvm/llvm-project/pull/97551 This patch tries to simplify the way in whic

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-07-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5da7179cb3ff80203f58ddea71562816b2ae4ff6 bcfebfbcbc4196daa9ab03874a58b53d44afeb3c --

[Lldb-commits] [lldb] 77d131e - Add the ability for Script based commands to specify their "repeat command" (#94823)

2024-07-03 Thread via lldb-commits
Author: jimingham Date: 2024-07-03T10:39:34-07:00 New Revision: 77d131eddb6ca9060c844fae9cb78779fa70c8f0 URL: https://github.com/llvm/llvm-project/commit/77d131eddb6ca9060c844fae9cb78779fa70c8f0 DIFF: https://github.com/llvm/llvm-project/commit/77d131eddb6ca9060c844fae9cb78779fa70c8f0.diff LOG

[Lldb-commits] [lldb] Add the ability for Script based commands to specify their "repeat command" (PR #94823)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/94823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] SBThread::StepInstruction shouldn't discard other plans (PR #97493)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/97493 >From 3fba16eaee25b1d63907640b79019309e9c019a7 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Tue, 2 Jul 2024 16:42:00 -0700 Subject: [PATCH 1/2] SBThread::StepInstruction shouldn't discard other plans This w

[Lldb-commits] [lldb] 845dee3 - SBThread::StepInstruction shouldn't discard other plans (#97493)

2024-07-03 Thread via lldb-commits
Author: jimingham Date: 2024-07-03T10:45:20-07:00 New Revision: 845dee36ba4161df153ba05009cea615e20eda5a URL: https://github.com/llvm/llvm-project/commit/845dee36ba4161df153ba05009cea615e20eda5a DIFF: https://github.com/llvm/llvm-project/commit/845dee36ba4161df153ba05009cea615e20eda5a.diff LOG

[Lldb-commits] [lldb] SBThread::StepInstruction shouldn't discard other plans (PR #97493)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/97493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/95959 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a017653 - [lldb][DataFormatter][NFC] Factor out MapIterator logic into separate helper (#97544)

2024-07-03 Thread via lldb-commits
Author: Michael Buch Date: 2024-07-03T19:54:20+02:00 New Revision: a0176533766201eca58b20a11e42ab30c73d1b1b URL: https://github.com/llvm/llvm-project/commit/a0176533766201eca58b20a11e42ab30c73d1b1b DIFF: https://github.com/llvm/llvm-project/commit/a0176533766201eca58b20a11e42ab30c73d1b1b.diff

[Lldb-commits] [clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Helena Kotas (hekota) Changes HLSL has a set of _intangible types_, which are described in in the [draft HLSL Specification (**[Basic.types]**)](https://microsoft.github.io/hlsl-specs/specs/hlsl.pdf): > There are special implementation-def

[Lldb-commits] [clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Helena Kotas (hekota) Changes HLSL has a set of _intangible types_, which are described in in the [draft HLSL Specification (**[Basic.types]**)](https://microsoft.github.io/hlsl-specs/specs/hlsl.pdf): > There are special implementatio

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-03 Thread via lldb-commits
cmtice wrote: BTW, I have verified that this stripped down version passes all the frame variable tests in LLDB. https://github.com/llvm/llvm-project/pull/95738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread via lldb-commits
jimingham wrote: I have a bug caused by the fact that we aren't properly marking shadow listeners as shadow listeners, causing them to steal events from the primary listener. I just got it, and haven't started looking at it. I might need SetShadow for that. https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [llvm] [lldb] [lldb-server] Introduce Host/qnx and NativeProcessQNX (PR #97630)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ayush Sahay (ayushsahay1837) Changes This change provisions the _QNX_ host and process plugins, and is the fifth and final in a series of changes that look to facilitate remote debug of _AArch64_ targets on _QNX_. _QNX Neutrino Real-Time

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread via lldb-commits
jimingham wrote: The problem was is currently you cna make a process, then do: listener = lldb.SBListener("my_listener") process.broadcaster.AddListener(listener, lldb.SBProcess.eBroadcastBitStateChanged) and nothing marks this as a Shadow listener, so when we go to deliver events, we

[Lldb-commits] [lldb] [lldb] Print empty enums as if they were unrecognised normal enums (PR #97553)

2024-07-03 Thread via lldb-commits
Prabhuk wrote: We are seeing the same failure in LLDB tests. Can we please revert this change? https://github.com/llvm/llvm-project/pull/97553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Just to be clear, I have no problem with removing this. Shadow wasn't really a useful property "listener class having a primary listener" was the only thing that really mattered. https://github.com/llvm/llvm-project/pull/97555 _

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/97555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Support exception breakpoints for plugin-provided languages (PR #97675)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes CommandObjectBreakpoint has a harcoded list of languages for which exception breakpoints can be enabled. I'm making this a bit more generic so that my Mojo plugin can get this feature. Basically,

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Move std::map iterator formatter into LibCxxMap.cpp (PR #97687)

2024-07-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes The two formatters follow very similar techniques to retrieve data out of the map. We're changing this for `std::map` in https://github.com/llvm/llvm-project/pull/97579 and plan to change it in the same w

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify libc++ std::map::iterator formatter (PR #97713)

2024-07-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Depends on https://github.com/llvm/llvm-project/pull/97687 Similar to https://github.com/llvm/llvm-project/pull/97579, this patch simplifies the way in which we retrieve the key/value pair of a `std::map`

[Lldb-commits] [lldb] 94a067a - [LLDB] Support exception breakpoints for plugin-provided languages (#97675)

2024-07-04 Thread via lldb-commits
Author: Walter Erquinigo Date: 2024-07-04T10:05:01-04:00 New Revision: 94a067a306fecceac913cc6d9bfdcd49464358ec URL: https://github.com/llvm/llvm-project/commit/94a067a306fecceac913cc6d9bfdcd49464358ec DIFF: https://github.com/llvm/llvm-project/commit/94a067a306fecceac913cc6d9bfdcd49464358ec.di

[Lldb-commits] [lldb] fbd1b65 - [lldb][DataFormatter][NFC] Move std::map iterator formatter into LibCxxMap.cpp (#97687)

2024-07-04 Thread via lldb-commits
Author: Michael Buch Date: 2024-07-04T17:06:10+01:00 New Revision: fbd1b6567ae41d64f1dbb6b32c7cf8a1b710b8d9 URL: https://github.com/llvm/llvm-project/commit/fbd1b6567ae41d64f1dbb6b32c7cf8a1b710b8d9 DIFF: https://github.com/llvm/llvm-project/commit/fbd1b6567ae41d64f1dbb6b32c7cf8a1b710b8d9.diff

[Lldb-commits] [lldb] [lldb][DataFormatter] Move std::unordered_map::iterator formatter into LibCxxUnorderedMap.cpp (PR #97752)

2024-07-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Similar to how we moved the `std::map::iterator` formatter in https://github.com/llvm/llvm-project/pull/97687, do the same for `std::unordered_map::iterator`. Again the `unordered_map` and `unordered_map:

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::unordered_map::iterator formatter (PR #97754)

2024-07-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Depends on https://github.com/llvm/llvm-project/pull/97752 This patch changes the way we retrieve the key/value pair in the `std::unordered_map::iterator` formatter (similar to how we are changing it for

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::unordered_map::iterator formatter (PR #97754)

2024-07-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff fbd1b6567ae41d64f1dbb6b32c7cf8a1b710b8d9 9e66b1c4787ad49b7f4ffab9f87746d7c59a4fd5 --

<    1   2   3   4   5   6   7   8   9   10   >