[Lldb-commits] [lldb] [LLDB][NFC]Also includes the error in log msg. (PR #134922)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/134922 >From ab50c89574613178ba2bf79455eaa8aba0f2205d Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 8 Apr 2025 15:58:10 -0400 Subject: [PATCH 1/2] [LLDB][NFC]Also includes the error in log msg. --- lldb/include

[Lldb-commits] [lldb] [LLDB][NFC]Also includes the error in log msg. (PR #134922)

https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/134922 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC]Move fields that might be referenced in scope-exit to beginning (PR #133785)

https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/133785 Details: The ScopedDiscpatcher's dtor may reference these fields so we need the fields' dtor to be be invoked *after* the dispatcher's. >From 55d20dc85389bdeacf806b18ff132030e2626d9a Mon Sep 17 00:00:00 2001 Fr

[Lldb-commits] [lldb] [LLDB][Telemetry]Init field to nullptr. (PR #131191)

https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/131191 The field is currently un-initialised and can cause a crash in some build configs (where it got random values) >From 543e208f31370310ed938425fbf89ffb3a7232fd Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu,

[Lldb-commits] [lldb] [LLDB][NFC]Refactor common test setup into SetUp method (PR #131203)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/131203 >From cff4bbc4ff68e77e3093a880f55d2e17116e6f37 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 13 Mar 2025 15:57:48 -0400 Subject: [PATCH 1/2] [LLDB][NFC]Refactor common test setup into SetUp method --- ll

[Lldb-commits] [lldb] [LLDB][NFC]Also includes the error in log msg. (PR #134922)

https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/134922 None >From ab50c89574613178ba2bf79455eaa8aba0f2205d Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 8 Apr 2025 15:58:10 -0400 Subject: [PATCH] [LLDB][NFC]Also includes the error in log msg. --- lldb/inclu

[Lldb-commits] [lldb] [lldb] Hoist UUID generation into the UUID class (PR #133662)

@@ -88,6 +88,9 @@ class UUID { DecodeUUIDBytesFromString(llvm::StringRef str, llvm::SmallVectorImpl &uuid_bytes); + /// Generate a random UUID. oontvoo wrote: s/Generate/Generates ? (to be consistent with the other comments) ht

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/23] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() { return sb_target; } +void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) { + LLDB_INSTRUMENT_VA(this); + // Disable client-telemetry for SWIG. + // This prevent arbitrary python client

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/22] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [lldb] Hoist UUID generation into the UUID class (PR #133662)

https://github.com/oontvoo approved this pull request. https://github.com/llvm/llvm-project/pull/133662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() { return sb_target; } +void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) { + LLDB_INSTRUMENT_VA(this); + // Disable client-telemetry for SWIG. + // This prevent arbitrary python client

[Lldb-commits] [lldb] [LLDB][NFC]Fix stack-use-after free bug. (PR #134296)

oontvoo wrote: I think this is a trivial enough fix - i'm going to just merge it. https://github.com/llvm/llvm-project/pull/134296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC]Fix stack-use-after free bug. (PR #134296)

https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/134296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() { return sb_target; } +void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) { + LLDB_INSTRUMENT_VA(this); + // Disable client-telemetry for SWIG. + // This prevent arbitrary python client

[Lldb-commits] [lldb] Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (PR #132043)

https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/132043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/21] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [lldb/telemetry] Report exit status only once (PR #134078)

https://github.com/oontvoo approved this pull request. https://github.com/llvm/llvm-project/pull/134078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC]Fix stack-use-after free bug. (PR #134296)

https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/134296 Details: detailed_command_telemetry (bool) and command_id (int) could already be freed when the dispatcher's dtor runs. So we should just copy them into the lambda since they are cheap. >From 96025fd1183f257c

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 1/7] [LLDB][Telemetry] Collect telemetry from client when allowed. T

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 1/8] [LLDB][Telemetry] Collect telemetry from client when allowed. T

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 1/9] [LLDB][Telemetry] Collect telemetry from client when allowed. T

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

@@ -119,6 +125,53 @@ llvm::Error TelemetryManager::preDispatch(TelemetryInfo *entry) { return llvm::Error::success(); } +void TelemetryManager::DispatchClientTelemetry( +const lldb_private::StructuredDataImpl &entry, Debugger *debugger) { + if (!m_config->enable_client

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 1/6] [LLDB][Telemetry] Collect telemetry from client when allowed. T

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/18] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [LLDB][NFC]Move fields that might be referenced in scope-exit to beginning (PR #133785)

https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/133785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() { return sb_target; } +void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) { + LLDB_INSTRUMENT_VA(this); + // Disable client-telemetry for SWIG. + // This prevent arbitrary python client

[Lldb-commits] [lldb] include telemetry session-id in diagnostic msg when enabled (PR #135924)

https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/135924 If LLDB crashes, it often helpful to know what the user was doing up to the point of the crash. Reporting the session-id helps us looking up the relevant logs. (Given Telemetry is disabled upstream, this chang

[Lldb-commits] [lldb] include telemetry session-id in diagnostic msg when enabled (PR #135924)

https://github.com/oontvoo edited https://github.com/llvm/llvm-project/pull/135924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] include telemetry session-id in diagnostic msg when enabled (PR #135924)

https://github.com/oontvoo edited https://github.com/llvm/llvm-project/pull/135924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb]Fix stack-use-after-free bugs in exit-callbacks. (PR #135763)

https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/135763 None >From dd74c3abe3a69e6c3cc4b9c22a38ca09997848f7 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 15 Apr 2025 04:42:30 -0400 Subject: [PATCH] [NFC][lldb]Fix stack-use-after-free bugs in exit-callbacks. -

[Lldb-commits] [lldb] [NFC][lldb]Fix stack-use-after-free bugs in exit-callbacks. (PR #135763)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/135763 >From dd74c3abe3a69e6c3cc4b9c22a38ca09997848f7 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 15 Apr 2025 04:42:30 -0400 Subject: [PATCH] [NFC][lldb]Fix stack-use-after-free bugs in exit-callbacks. --- ll

[Lldb-commits] [lldb] [NFC][lldb]Fix stack-use-after-free bugs in exit-callbacks. (PR #135763)

https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/135763 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/23] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/25] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

oontvoo wrote: Thanks all, for the feedback! I'll merge this EOD today, if there's no objection! :) https://github.com/llvm/llvm-project/pull/129728 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

@@ -156,6 +158,52 @@ uint32_t GetLLDBFrameID(uint64_t dap_frame_id); lldb::SBEnvironment GetEnvironmentFromArguments(const llvm::json::Object &arguments); +/// Helper for sending telemetry to lldb server, if client-telemetry is enabled. +#ifndef SWIG oontvoo

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/25] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/129728 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/24] [LLDB][Telemetry] Collect telemetry from client when allowed.

<    1   2   3   4   5