https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Dec 2024 20:50:40 -0500
Subject: [PATCH 1/4] Implement LLDB Telemetry (Part 1)
This contains only the concre
@@ -0,0 +1,92 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,92 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Dec 2024 20:50:40 -0500
Subject: [PATCH 1/6] Implement LLDB Telemetry (Part 1)
This contains only the concre
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Dec 2024 20:50:40 -0500
Subject: [PATCH 1/7] Implement LLDB Telemetry (Part 1)
This contains only the concre
@@ -0,0 +1,93 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Dec 2024 20:50:40 -0500
Subject: [PATCH 01/15] Implement LLDB Telemetry (Part 1)
This contains only the conc
@@ -0,0 +1,93 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,100 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,93 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/126588
Details:
Upstream in LLDB, we will have a default TelemetryVendor plugin will provide a
default Config and NULL TelemetryManager. Downstream vendors can extend this to
provide a vendor-specific Config along wi
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Dec 2024 20:50:40 -0500
Subject: [PATCH 01/15] Implement LLDB Telemetry (Part 1)
This contains only the conc
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/119716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/4] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,74 @@
+//===-- Telemetry.h
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/126757
None
>From 5a8b91422a017dcda595efa614a018f0a432df12 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 11:05:21 -0500
Subject: [PATCH] Addressed additional review comments from PR/119716.
---
lld
@@ -0,0 +1,69 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126746
>From 008537373cd928fea9ac04b1aed39c2ecafec65a Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 10:36:06 -0500
Subject: [PATCH 1/5] Define -DLLVM_BUILD_TELEMETRY to be used in ifdef (by
users of
oontvoo wrote:
> .. and fix the code so that it uses the new macro name ? (You'll need to
> include llvm-config.h before you can use the macro, and I'd recommend doing a
> build with telemetry disabled to check that everything works as it should)
Done. (also tested with explicitly specifying
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/3] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/3] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/2] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126746
>From 008537373cd928fea9ac04b1aed39c2ecafec65a Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 10:36:06 -0500
Subject: [PATCH 1/3] Define -DLLVM_BUILD_TELEMETRY to be used in ifdef (by
users of
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/5] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126746
>From 008537373cd928fea9ac04b1aed39c2ecafec65a Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 10:36:06 -0500
Subject: [PATCH 1/4] Define -DLLVM_BUILD_TELEMETRY to be used in ifdef (by
users of
oontvoo wrote:
> In that case, could you also delete the definition in llvm/lib/CMakeLists.txt
> and the one introduced in #126715 ?
done
https://github.com/llvm/llvm-project/pull/126746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126746
>From 008537373cd928fea9ac04b1aed39c2ecafec65a Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 10:36:06 -0500
Subject: [PATCH 1/5] Define -DLLVM_BUILD_TELEMETRY to be used in ifdef (by
users of
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/126746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/5] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/8] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/9] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/7] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/10] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
oontvoo wrote:
> This is definitely better than what you had before, but I still think it's
> more complicated than it needs to be. For one, I'd like to understand why is
> there a need for separate `TelemetryManager` and `TelemetryConfig` fields. If
> the downstream implementation is going to
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/11] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/119716
Details:
- This is a subset of PR/98528.( Pavel's suggestion was to split up the patch
to make reviewing easier)
- This contains only the concrete implementation of the framework to be used
but no usages yet.
-
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From 44fa888e6fce3788342011e445b97b293cba1c5e Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 12 Dec 2024 10:47:09 -0500
Subject: [PATCH 1/5] [lldb][telemetry] Implement LLDB Telemetry (part 1)
Details:
-
@@ -257,8 +257,8 @@ enum StopReason {
};
/// Command Return Status Types.
-enum ReturnStatus {
- eReturnStatusInvalid,
+enum ReturnStatus : int {
+ eReturnStatusInvalid = 0,
oontvoo wrote:
carry-over comment from previous patch("Why is this needed?")
This
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/119716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oontvoo wrote:
> > Pavel's suggestion was to split up the patch to make reviewing easier
>
> It was, but this wasn't the kind of separation I had in mind. For me as
> least, it's very hard to review features in these "horizontal" slices. It's
> also unclear how (if ever) will this code be test
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From 44fa888e6fce3788342011e445b97b293cba1c5e Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 12 Dec 2024 10:47:09 -0500
Subject: [PATCH 1/3] [lldb][telemetry] Implement LLDB Telemetry (part 1)
Details:
-
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From 44fa888e6fce3788342011e445b97b293cba1c5e Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 12 Dec 2024 10:47:09 -0500
Subject: [PATCH 1/4] [lldb][telemetry] Implement LLDB Telemetry (part 1)
Details:
-
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From 44fa888e6fce3788342011e445b97b293cba1c5e Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 12 Dec 2024 10:47:09 -0500
Subject: [PATCH 1/6] [lldb][telemetry] Implement LLDB Telemetry (part 1)
Details:
-
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From 44fa888e6fce3788342011e445b97b293cba1c5e Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 12 Dec 2024 10:47:09 -0500
Subject: [PATCH 1/7] [lldb][telemetry] Implement LLDB Telemetry (part 1)
Details:
-
@@ -0,0 +1,338 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,338 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,338 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,309 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,338 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/15] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/16] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/17] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/17] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -79,3 +79,7 @@ add_subdirectory(ValueObject)
if(LLDB_CAN_USE_DEBUGSERVER AND LLDB_TOOL_DEBUGSERVER_BUILD AND NOT
LLDB_USE_SYSTEM_DEBUGSERVER)
add_subdirectory(debugserver)
endif()
+
+if(LLVM_BUILD_TELEMETRY)
+ add_subdirectory(telemetry)
+endif()
oontvoo
@@ -0,0 +1,13 @@
+if (LLVM_BUILD_TELEMETRY)
+ add_lldb_library(lldbPluginTelemetryFakePlugin PLUGIN
+ FakePlugin.cpp
+
+ LINK_LIBS
+lldbCore
+lldbUtility
+lldbPluginProcessUtility
+ LINK_COMPONENTS
+Support
+Telemetry
+
@@ -59,11 +60,21 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
/// The base Telemetry manager instance in LLDB
/// This class declares additional instrumentation points
/// applicable to LLDB.
-class TelemetryManager : public llvm::telemetry::Manage
@@ -0,0 +1,34 @@
+//===-- TestFakePlugin.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126757
>From 5a8b91422a017dcda595efa614a018f0a432df12 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 11:05:21 -0500
Subject: [PATCH 1/2] Addressed additional review comments from PR/119716.
---
lldb/
oontvoo wrote:
Related follow-up :
[PR/126746](https://github.com/llvm/llvm-project/pull/126746) (for excluding
telemetry code)
https://github.com/llvm/llvm-project/pull/119716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
oontvoo wrote:
> > The (baroque) way that the other plugins work serves two purposes:
> >
> > 1. controlling the type (class) of the plugin being created based on some
> > runtime property
> > 2. creating an arbitrary number of plugin instances
> >
> > For telemetry "plugins", I don't think we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126757
>From 5a8b91422a017dcda595efa614a018f0a432df12 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 11:05:21 -0500
Subject: [PATCH 1/4] Addressed additional review comments from PR/119716.
---
lldb/
oontvoo wrote:
> Based on the title of this PR I was expecting something slightly different,
> so maybe I'm missing something. But if we want to make this an LLDB plugin
> (which I agree we should ), I would expect the `PluginManager` to manage the
> instance rather than the plugin doing itsel
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/24] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126757
>From 5a8b91422a017dcda595efa614a018f0a432df12 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 11:05:21 -0500
Subject: [PATCH 1/4] Addressed additional review comments from PR/119716.
---
lldb/
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126757
>From 5a8b91422a017dcda595efa614a018f0a432df12 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 11:05:21 -0500
Subject: [PATCH 1/4] Addressed additional review comments from PR/119716.
---
lldb/
@@ -0,0 +1,74 @@
+//===-- TelemetryTest.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/23] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/25] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/13] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/14] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/12] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 1/3] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related
metho
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes the exit status of a debugger.
+struct ExitDescription {
+ int exit_code;
+ std::string des
@@ -761,12 +767,29 @@ void Debugger::InstanceInitialize() {
DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
void *baton) {
+#ifdef LLVM_BUILD_TELEMETRY
+ lldb_private::telemetry::SteadyTimePoint start_time =
+
https://github.com/oontvoo ready_for_review
https://github.com/llvm/llvm-project/pull/127834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 1/2] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details:
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 1/3] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details:
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 1/5] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related
metho
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/128574
None
>From a6ce60e61271aa2b57b8bc51bb1b0e0cd5896f68 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 15:53:36 -0500
Subject: [PATCH] [LLDB][NFC]Renaming functions to be consistent with LLDB
nami
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127834
>From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Feb 2025 12:47:57 -0500
Subject: [PATCH 1/2] [LLDB][Telemetry]Define TargetInfo for collecting data
about a
oontvoo wrote:
(This PR assumes that we can rely on PR/128534 - that is, we always build the
telemetry library. Whether it is enabled is dictated by Config::EnableTelemetry)
https://github.com/llvm/llvm-project/pull/127834
___
lldb-commits mailing lis
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127834
>From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Feb 2025 12:47:57 -0500
Subject: [PATCH] [LLDB][Telemetry]Define TargetInfo for collecting data about
a targ
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/128574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -41,17 +41,32 @@ static uint64_t ToNanosec(const SteadyTimePoint Point) {
return std::chrono::nanoseconds(Point.time_since_epoch()).count();
}
-static std::string MakeUUID(Debugger *debugger) {
+// Generate a unique string. This should be unique across different runs.
+//
@@ -43,29 +77,79 @@ void LLDBBaseTelemetryInfo::serialize(Serializer
&serializer) const {
serializer.write("end_time", ToNanosec(end_time.value()));
}
-[[maybe_unused]] static std::string MakeUUID(Debugger *debugger) {
- uint8_t random_bytes[16];
- if (auto ec = llvm::g
@@ -56,16 +54,107 @@ void LLDBBaseTelemetryInfo::serialize(Serializer
&serializer) const {
return UUID(random_bytes).GetAsString();
}
+void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const {
+ serializer.write("entry_kind", getKind());
+ serializer.write("se
@@ -56,16 +54,107 @@ void LLDBBaseTelemetryInfo::serialize(Serializer
&serializer) const {
return UUID(random_bytes).GetAsString();
}
+void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const {
+ serializer.write("entry_kind", getKind());
+ serializer.write("se
101 - 200 of 440 matches
Mail list logo
