Yeah, I have no idea how you'd make sure that the SBError returned to Python in
a Python SBValue was checked before it went out of scope, and I'm not sure it's
our business to be enforcing that... So we're going to have to do something
special for those errors. We also use the pattern where we
BTW, not to exclude the positive because it doesn't need discussing: all the
rest of the changes you were proposing seem appropriate and good to me. Thanks
for taking the trouble to clean this up.
Jim
> On Jan 31, 2017, at 5:45 PM, Zachary Turner wrote:
>
> Yea, there may be value in both. I
I don't think any of this should be terribly controversial. The "Long term"
part of the proposals might be, but that's not what you're talking about here,
right?
These changes will presumably require adjustments to the Xcode project. If you
can do that yourself, then that's great. If you nee
Not to be snarky, but that's why we put comments in headers...
Jim
> On Feb 3, 2017, at 4:47 PM, Zachary Turner via Phabricator
> wrote:
>
> zturner added a comment.
>
> I guess the same way you would know how to use any part of a library or API.
> The first time you've ever used an API, yo
That doesn't help me if I don't know that Format takes formatters and that
various lldb objects take formatters and here are all the formatters we have.
And it would be kinder to have the list of available formatters centralized
somewhere so folks don't have to go scouring through the code to s
> On Feb 6, 2017, at 7:19 PM, Pavel Labath via Phabricator via lldb-commits
> wrote:
>
> labath added a comment.
>
> The log callback gets passed down from the SB API (in the SBDebugger
> constructor, no less). My best guess is that it is (was?) used to display the
> debugger log in some IDE
Note that the breakpoint location's site gets cleared when you disable the
breakpoint or its location, as well as when you delete it. So if you have a
workflow that does: "hit a breakpoint, disable it, hit another, reenable the
first, hit the second" you'll end up re-evaluating the condition ex
In some classes we have a Clear method that we use to release resources from an
object when we are done with it but it might not get destroyed right away. I
pretty sure Greg thought that you would be adding your change to such a method;
and in fact it would be fine to add a Clear method to Brea
This is kind of after the fact, but why didn't we reuse DataBufferMemoryMap for
the Memory Map data buffer that now happens to be backed by an LLVM
implementation? DataBufferLLVM doesn't really tell anybody what the thing does
w/o looking up the implementation.
Jim
> On Feb 27, 2017, at 2:56
I worry about stripping out the wrappers, because there are some differences in
how lldb operates from llvm that I don't think we want to push down into llvm -
in this case I'm thinking particularly about logging. DataBufferMemoryMap did
a bunch of logging, which presumably would get lost if yo
> On Feb 27, 2017, at 11:49 AM, Zachary Turner wrote:
>
> There may be some cases where we're no longer mmaping where we used to, but
> looking at LLVM's implementation, that would only happen if the file is
> fairly small, and there's a comment in LLVM explaining why they don't mmap
> small
Having library functions that don't return good errors seems like such an
obvious failing that it shouldn't be hard to motivate fixing that. Then our
logging can go in the wrapper classes, using those errors. That seems like a
pattern that solves the "don't duplicate code" problem and the "lld
No test case?
Jim
> On Feb 28, 2017, at 9:59 AM, Zachary Turner via lldb-commits
> wrote:
>
> Author: zturner
> Date: Tue Feb 28 11:59:59 2017
> New Revision: 296495
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296495&view=rev
> Log:
> Fix incorrect logic in StackFrame::Disassemble.
>
>
SBStackFrame::Disassemble calls StackFrame::Disassemble to do its job. From
the looks of it, your goof would cause lldb never to return any instructions
when asked to disassemble a stack frame, since StackFrame does the work lazily
and the error was to NOT do the work when the disassembly is em
Make that SBFrame::Disassemble...
Jim
> On Feb 28, 2017, at 10:21 AM, Jim Ingham wrote:
>
> SBStackFrame::Disassemble calls StackFrame::Disassemble to do its job. From
> the looks of it, your goof would cause lldb never to return any instructions
> when asked to disassemble a stack frame, si
Author: jingham
Date: Tue Feb 28 12:57:54 2017
New Revision: 296504
URL: http://llvm.org/viewvc/llvm-project?rev=296504&view=rev
Log:
Fix a bug in r294611 w.r.t. Darwin Kernel debugging.
Modified:
lldb/trunk/include/lldb/Target/DynamicLoader.h
lldb/trunk/include/lldb/Target/Process.h
> On Feb 28, 2017, at 3:14 PM, Zachary Turner wrote:
>
> On Tue, Feb 28, 2017 at 3:07 PM Jason Molenda wrote:
> At it's core, lldb is a real world tool that thousands of people depend on;
> breaking it or introducing bugs for little gain beyond aesthetics is a very
> poor tradeoff.
>
> Ju
the right form, you don't have adequate
context, and you are much more likely to make a mistake.
Jim
> On Feb 28, 2017, at 3:22 PM, Jim Ingham via lldb-commits
> wrote:
>
>
>> On Feb 28, 2017, at 3:14 PM, Zachary Turner wrote:
>>
>> On Tue, Feb 28, 201
> On Feb 28, 2017, at 3:36 PM, Zachary Turner wrote:
>
> That patch was not really about early returns, it was about using StringRef.
> So my comment about the aesthetics was referring to the patch in general.
> The early return was more of a drive by, since I was already touching the
> cod
> On Feb 28, 2017, at 4:15 PM, Zachary Turner wrote:
>
>
>
> On Tue, Feb 28, 2017 at 3:49 PM Jim Ingham wrote:
>
> > On Feb 28, 2017, at 3:36 PM, Zachary Turner wrote:
> >
> > That patch was not really about early returns, it was about using
> > StringRef. So my comment about the aestheti
Author: jingham
Date: Wed Mar 1 14:25:48 2017
New Revision: 296669
URL: http://llvm.org/viewvc/llvm-project?rev=296669&view=rev
Log:
Add a sample_test directory with simple starter
test cases for standard and "inline" tests.
Added:
lldb/trunk/packages/Python/lldbsuite/test/sample_test/
l
Author: jingham
Date: Wed Mar 1 16:18:37 2017
New Revision: 296692
URL: http://llvm.org/viewvc/llvm-project?rev=296692&view=rev
Log:
Add a test to ensure that SBFrame::Disassemble produces some output.
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/disassembly/TestFrameDis
Author: jingham
Date: Wed Mar 1 16:23:30 2017
New Revision: 296693
URL: http://llvm.org/viewvc/llvm-project?rev=296693&view=rev
Log:
Make it clear what you should modify when you copy any of these sample
test cases.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/sample_test/TestSampleI
Author: jingham
Date: Thu Mar 2 15:39:27 2017
New Revision: 296814
URL: http://llvm.org/viewvc/llvm-project?rev=296814&view=rev
Log:
Added a list of outstanding projects that would benefit lldb.
This was a list that I've had kicking around for a while, and would
add to whenever some hallway con
Author: jingham
Date: Thu Mar 2 15:42:00 2017
New Revision: 296816
URL: http://llvm.org/viewvc/llvm-project?rev=296816&view=rev
Log:
Goals->Projects.
Modified:
lldb/trunk/www/projects.html
Modified: lldb/trunk/www/projects.html
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/www/projec
Author: jingham
Date: Thu Mar 2 15:45:39 2017
New Revision: 296819
URL: http://llvm.org/viewvc/llvm-project?rev=296819&view=rev
Log:
Add a reference to the projects in the Get involved section.
Modified:
lldb/trunk/www/index.html
Modified: lldb/trunk/www/index.html
URL:
http://llvm.org/vie
Author: jingham
Date: Thu Mar 2 16:04:05 2017
New Revision: 296826
URL: http://llvm.org/viewvc/llvm-project?rev=296826&view=rev
Log:
Forgot about local variable lookup.
Yay for coffee lines.
Modified:
lldb/trunk/www/projects.html
Modified: lldb/trunk/www/projects.html
URL:
http://llvm.o
Author: jingham
Date: Thu Mar 2 16:13:45 2017
New Revision: 296833
URL: http://llvm.org/viewvc/llvm-project?rev=296833&view=rev
Log:
Mention fetching thread lists lazily.
Modified:
lldb/trunk/www/projects.html
Modified: lldb/trunk/www/projects.html
URL:
http://llvm.org/viewvc/llvm-project/
Author: jingham
Date: Thu Mar 2 16:24:01 2017
New Revision: 296834
URL: http://llvm.org/viewvc/llvm-project?rev=296834&view=rev
Log:
Python commands as first class citizens.
This should be a necessary precursor to adding support
for any future extension languages.
Modified:
lldb/trunk/www/
That sounds right. Please do fix the function names. We can have another
discussion about naming at some point, but we shouldn't do it piecemeal.
Jim
> On Mar 3, 2017, at 9:53 AM, Zachary Turner wrote:
>
> Yea, I can see splitting the target specific stuff into a separate "target
> aware" d
Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor. That's a
little weird because it doesn't actually take a DataExtractor, but...
Jim
> On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits
> wrote:
>
> I can fix that, I didn't see it in my tests because it doesn't co
I guess you could fudge by changing DumpDataExtractor.h to DataDumper.h to
indicate that it is more general than just data extractors.
Jim
> On Mar 3, 2017, at 3:48 PM, Zachary Turner wrote:
>
> Yea, it was a static method of DataExtractor before. I noticed the same
> thing when i saw it was
I'll get this working, but in the future when you are making changes of this
sort please chase down all the instances of functions you are changing, even in
files you aren't building locally. There might be a use that your conversion
doesn't handle, and you don't want to find that out after you'
Yeah, you could have grepped (is that how you spell that?) for "#include
"lldb/Core/DataExtractor.h" then looked at any Dump method in the files that
turned up. That would have reduced the noise.
Ah, staircase wit...
Jim
> On Mar 3, 2017, at 4:46 PM, Zachary Turner wrote:
>
> I usually do t
Might also be useful to have a list of "files only compiled on platform X"
somewhere. Then in this sort of case, you could compile, then scrutinize
carefully all the files in the "not my platform list."
Jim
> On Mar 3, 2017, at 4:51 PM, Jim Ingham via lldb-commits
&
Author: jingham
Date: Fri Mar 3 19:15:24 2017
New Revision: 296938
URL: http://llvm.org/viewvc/llvm-project?rev=296938&view=rev
Log:
Fix the macOS build all the way after r296909.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/source/Plugins/Process/MacOSX-Kernel/Communic
This change seems to have lost the code that would make sure that on platforms
with short thread names we pick up the end of the name passed in because that
is generally the more specific part. Was that just an oversight?
Jim
> On Mar 3, 2017, at 5:31 PM, Zachary Turner via lldb-commits
> wr
It was done on all platforms, but the way it worked before was there was a
HostInfo::GetMaxThreadNameLength that was the length passed into SetThreadName,
and then the string was back trimmed to that length generically in
ThisThread::SetName.
You can see the length passed in in
HostNativeThrea
> On Mar 6, 2017, at 4:10 PM, Greg Clayton via Phabricator
> wrote:
>
> clayborg requested changes to this revision.
> clayborg added a comment.
> This revision now requires changes to proceed.
>
> Very close. Can we try to get UpdateAutomaticSignalFiltering out of
> lldb_private::Process as
The UnixSignals class produces the array of signal numbers that it knows it
doesn't want to hear about. But it has no idea how any particular Process
plugin would implement ignoring those symbols. So that part belongs to the
Process plugin. I suggested in a previous comment also adding a
Uni
I like it in the base class and Greg was okay with that too. So let's leave
that where it is.
The only bit of this behavior that could be moved into UnixSignals as it seemed
to me was the handling of "needs updating". I was mostly proposing that
because then you can already pass the UnixSigna
Yes formally that seems problematic. It wouldn't be a problem in practice
because you should only call ResetNeedsUpdating in
UpdateAutomaticSignalFiltering, and the only place where
UpdateAutomaticSignalFiltering should be called is when Launching or Resuming,
and you can't call either of thes
Finding the executables that a binary will load on run before you actually run
is always best effort. We don't require the ObjectFile class to fully emulate
the platform loader. So from the standpoint of writing tests, if the test
relies on getting symbols from a loaded library it should alway
Author: jingham
Date: Mon Oct 12 14:00:28 2015
New Revision: 250081
URL: http://llvm.org/viewvc/llvm-project?rev=250081&view=rev
Log:
Fix test for change in a summary string (objects -> elements).
Modified:
lldb/trunk/test/lang/objc/hidden-ivars/TestHiddenIvars.py
Modified: lldb/trunk/test/l
Author: jingham
Date: Mon Oct 12 14:02:08 2015
New Revision: 250082
URL: http://llvm.org/viewvc/llvm-project?rev=250082&view=rev
Log:
Add a doc string for ReturnFromFrame.
Modified:
lldb/trunk/scripts/interface/SBThread.i
Modified: lldb/trunk/scripts/interface/SBThread.i
URL:
http://llvm.or
Author: jingham
Date: Mon Oct 12 14:03:32 2015
New Revision: 250083
URL: http://llvm.org/viewvc/llvm-project?rev=250083&view=rev
Log:
Return the right answer for ShouldStop for the RunToAddress plan. This isn't
strictly necessary because RunToAddress is always used as a subsidiary plan, so
it's S
Author: jingham
Date: Mon Oct 12 14:11:03 2015
New Revision: 250084
URL: http://llvm.org/viewvc/llvm-project?rev=250084&view=rev
Log:
Fix a misunderstanding of the ThreadPlan::OkayToDiscard flag in
InferiorCallPOSIX. It was
set to true, but all plans run by RunThreadPlan need to have this set t
I don't know about the std::list implementation in specific, but in the
debugger you have to be aware of the possibility that you are looking at an
entity that is in the middle of being modified. Note, it may not be obvious to
the user that that is being done since it may be happening on anothe
jingham added a subscriber: jingham.
jingham added a comment.
I don't know about the std::list implementation in specific, but in the
debugger you have to be aware of the possibility that you are looking at an
entity that is in the middle of being modified. Note, it may not be obvious to
the u
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This change alters the timing for the handling of ignore counts for
watchpoints. The original implementation (and the way ignore counts work for
breakpoints) is that the breakpoin
> On Aug 14, 2015, at 1:47 PM, Paul Herman wrote:
>
> paulherman added a comment.
>
> This patch does exactly that. It detects the language of the frame and
> upgrades it according to the rules you said (I think I might've missed ObjC
> -> ObjC++, but that can be added).
>
> Regarding the gl
> On Oct 19, 2015, at 4:18 PM, Zachary Turner via lldb-commits
> wrote:
>
> I think this is going to break the CMake build. Can you update the relevant
> CMakeLists.txt file?
>
> Also, are there any tests for this?
This doesn't actually add a REPL for any of the languages that the current L
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
So before getting into the details of the patch, there's a structural bit it
would be nice to fix.
When I was separating out bits of the Expression machinery, I assumed that even
jingham added a comment.
The generic parts of this change look fine to me, with a few inlined style
comments.
I didn't read the Go specific parts of this in detail, I assume you're going to
get those right. I mentioned a couple of style things inline, though I didn't
mark everywhere that they
Author: jingham
Date: Wed Oct 28 17:23:17 2015
New Revision: 251564
URL: http://llvm.org/viewvc/llvm-project?rev=251564&view=rev
Log:
Change Target::EvaluateExpression to take an ExecutionContextScope * rather
than a
StackFrame * (StackFrame is an ExecutionContextScope.) That allows you to call
> On Oct 29, 2015, at 3:34 AM, Mohit Bhakkad wrote:
>
> mohit.bhakkad added a comment.
>
> In http://reviews.llvm.org/D13296#265608, @jingham wrote:
>
>> This change alters the timing for the handling of ignore counts for
>> watchpoints. The original implementation (and the way ignore counts
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Yes, that looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
Author: jingham
Date: Thu Oct 29 16:54:50 2015
New Revision: 251657
URL: http://llvm.org/viewvc/llvm-project?rev=251657&view=rev
Log:
Give the test class it's own name (it was reusing the name from
TestCompletions.py).
Modified:
lldb/trunk/packages/Python/lldbsuite/test/terminal/TestSTTYBefo
The substance is fine. I fixed up the grammar a little, maybe something like:
TODO: This condition should be checked in the synchronous part of the
watchpoint code (Watchpoint::ShouldStop), so that
we avoid pulling an event even if the watchpoint fails the ignore count
condition. It is moved h
jingham added a subscriber: jingham.
jingham added a comment.
The substance is fine. I fixed up the grammar a little, maybe something like:
TODO: This condition should be checked in the synchronous part of the
watchpoint code (Watchpoint::ShouldStop), so that
we avoid pulling an event even if
Note, the other important step was that you had to have an lldb installed in
/usr/bin/lldb that FAILED this test. If you have a more recent lldb there, the
test will succeed, and you won't notice you aren't testing your newly built
sources.
Jim
> On Oct 30, 2015, at 1:25 PM, Enrico Granata vi
Author: jingham
Date: Fri Oct 30 16:32:03 2015
New Revision: 251720
URL: http://llvm.org/viewvc/llvm-project?rev=251720&view=rev
Log:
Fix an error message (the debugger was invalid, not the target.)
Modified:
lldb/trunk/source/API/SBDebugger.cpp
Modified: lldb/trunk/source/API/SBDebugger.cpp
Author: jingham
Date: Fri Oct 30 16:32:25 2015
New Revision: 251721
URL: http://llvm.org/viewvc/llvm-project?rev=251721&view=rev
Log:
Add a few missing includes.
Modified:
lldb/trunk/include/lldb/API/LLDB.h
Modified: lldb/trunk/include/lldb/API/LLDB.h
URL:
http://llvm.org/viewvc/llvm-projec
Author: jingham
Date: Fri Oct 30 16:43:15 2015
New Revision: 251722
URL: http://llvm.org/viewvc/llvm-project?rev=251722&view=rev
Log:
Make the error return more explicit when an SBValue has no value.
Modified:
lldb/trunk/source/API/SBValue.cpp
Modified: lldb/trunk/source/API/SBValue.cpp
URL:
Author: jingham
Date: Fri Oct 30 19:02:18 2015
New Revision: 251727
URL: http://llvm.org/viewvc/llvm-project?rev=251727&view=rev
Log:
Abstract the notion of the truth value of an expression result, for use
in breakpoint conditions.
Modified:
lldb/trunk/include/lldb/Core/ValueObject.h
lldb
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Yes.
Repository:
rL LLVM
http://reviews.llvm.org/D13296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: jingham
Date: Mon Nov 2 20:11:24 2015
New Revision: 251887
URL: http://llvm.org/viewvc/llvm-project?rev=251887&view=rev
Log:
Add the ability to pass an EvaluateExpressionOptions when you make a
UserExpression. This
isn't used in this commit but will be in a future commit.
Modified:
Author: jingham
Date: Tue Nov 3 19:02:06 2015
New Revision: 252023
URL: http://llvm.org/viewvc/llvm-project?rev=252023&view=rev
Log:
Try a little harder to provide a legit CWD to argdumper if
the user hasn't provided one.
Modified:
lldb/trunk/source/Host/macosx/Host.mm
Modified: lldb/trunk
Author: jingham
Date: Tue Nov 3 19:02:43 2015
New Revision: 252024
URL: http://llvm.org/viewvc/llvm-project?rev=252024&view=rev
Log:
Actually implement Section::GetSectionData.
Modified:
lldb/trunk/include/lldb/Core/Section.h
lldb/trunk/source/Core/Section.cpp
Modified: lldb/trunk/inclu
Author: jingham
Date: Tue Nov 3 19:24:04 2015
New Revision: 252029
URL: http://llvm.org/viewvc/llvm-project?rev=252029&view=rev
Log:
Fix a shadowed ivar in SearchFilterByModuleListAndCU.
Modified:
lldb/trunk/include/lldb/Core/SearchFilter.h
Modified: lldb/trunk/include/lldb/Core/SearchFilte
Author: jingham
Date: Tue Nov 3 19:39:05 2015
New Revision: 252031
URL: http://llvm.org/viewvc/llvm-project?rev=252031&view=rev
Log:
Add a few useful methods to ThreadSafeDense{Map,Set}. Not used yet.
Modified:
lldb/trunk/include/lldb/Core/ThreadSafeDenseMap.h
lldb/trunk/include/lldb/Co
t now, and don't want to get side-tracked.
Jim
> On Nov 3, 2015, at 5:43 PM, Zachary Turner wrote:
>
> Seems like this class would be a good candidate for using an RWMutex. Any
> reason you can think of why that wouldn't work?
>
> On Tue, Nov 3, 2015 at 5:41 PM Jim
Author: jingham
Date: Wed Nov 4 14:32:27 2015
New Revision: 252072
URL: http://llvm.org/viewvc/llvm-project?rev=252072&view=rev
Log:
Add "zero_memory" option to IRMemoryMap::FindSpace & IRMemoryMap::Malloc. Zero
out
the Expression ResultVariable so it's in a known initial state.
Modified:
Author: jingham
Date: Wed Nov 4 18:22:19 2015
New Revision: 252106
URL: http://llvm.org/viewvc/llvm-project?rev=252106&view=rev
Log:
One of the File constructors was missing initializers. Didn't seem
to cause any problems, but still...
Modified:
lldb/trunk/include/lldb/Host/File.h
Modified
Author: jingham
Date: Wed Nov 4 18:24:18 2015
New Revision: 252108
URL: http://llvm.org/viewvc/llvm-project?rev=252108&view=rev
Log:
AddInitialArguments -> AddArguments, and we pass in the struct_address and push
it too. All the
callers had to do this by hand and we ended up never actually addi
Author: jingham
Date: Wed Nov 4 18:38:39 2015
New Revision: 252111
URL: http://llvm.org/viewvc/llvm-project?rev=252111&view=rev
Log:
LLDB needs a mutex around getopt_long_only() function calls to avoid
multi-threading option parsing issues.
Modified:
lldb/trunk/include/lldb/Host/OptionPar
Author: jingham
Date: Wed Nov 4 19:18:07 2015
New Revision: 252122
URL: http://llvm.org/viewvc/llvm-project?rev=252122&view=rev
Log:
CommandObjectProxy needs to proxy GenerateHelpText as well as
everything else.
Modified:
lldb/trunk/include/lldb/Interpreter/CommandObjectMultiword.h
lld
Why are we trying to build this at all on Linux? Seems odd to build an empty
file rather than just not build it.
Jim
> On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits
> wrote:
>
> Author: chaoren
> Date: Wed Nov 4 19:23:19 2015
> New Revision: 252124
>
> URL: http://llvm.org/viewv
Author: jingham
Date: Wed Nov 4 19:50:42 2015
New Revision: 252129
URL: http://llvm.org/viewvc/llvm-project?rev=252129&view=rev
Log:
Add IRExecutionUnitSP to lldb-forward and use it instead of hand-rolling in
place.
Modified:
lldb/trunk/include/lldb/lldb-forward.h
lldb/trunk/source/Plug
Why?
Jim
> On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote:
>
> We do the same thing in other MacOSX platform files where they depend on
> Apple specific libraries.
>
>
>> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits
>> wrote:
>>
>>
v 4, 2015, at 6:00 PM, Jim Ingham wrote:
>>
>> Why?
>>
>> Jim
>>
>>> On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote:
>>>
>>> We do the same thing in other MacOSX platform files where they depend on
>>> Apple specific libraries
t;>
> >> Why?
> >>
> >> Jim
> >>
> >>> On Nov 4, 2015, at 5:43 PM, Jason Molenda wrote:
> >>>
> >>> We do the same thing in other MacOSX platform files where they depend on
> >>> Apple specific libraries.
&
Author: jingham
Date: Thu Nov 5 12:51:48 2015
New Revision: 252184
URL: http://llvm.org/viewvc/llvm-project?rev=252184&view=rev
Log:
Remove Copy and Paste error in a comment.
Modified:
lldb/trunk/include/lldb/Symbol/CompileUnit.h
Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h
URL:
Author: jingham
Date: Thu Nov 5 13:20:39 2015
New Revision: 252188
URL: http://llvm.org/viewvc/llvm-project?rev=252188&view=rev
Log:
Add a comment explaining TypeImpl.
Modified:
lldb/trunk/include/lldb/Symbol/Type.h
Modified: lldb/trunk/include/lldb/Symbol/Type.h
URL:
http://llvm.org/viewv
.mm means compile with the ObjectiveC++ compiler, not the ObjectiveC compiler.
Probably wouldn't effect these files but it seems a really bogus way to tell
the build system not to build files...
Jim
> On Nov 5, 2015, at 10:58 AM, Zachary Turner via lldb-commits
> wrote:
>
> Renaming it to .
Author: jingham
Date: Thu Nov 5 16:33:17 2015
New Revision: 252224
URL: http://llvm.org/viewvc/llvm-project?rev=252224&view=rev
Log:
Let the process help figure out the Host OS if nobody else
can figure it out.
Modified:
lldb/trunk/include/lldb/Target/Platform.h
lldb/trunk/include/lldb/T
Author: jingham
Date: Thu Nov 5 17:52:05 2015
New Revision: 252240
URL: http://llvm.org/viewvc/llvm-project?rev=252240&view=rev
Log:
Add a generic API to return the Concrete type for a given abstract type
name and the execution context in which it is realized.
Modified:
lldb/trunk/include/ll
Author: jingham
Date: Fri Nov 6 16:45:57 2015
New Revision: 252355
URL: http://llvm.org/viewvc/llvm-project?rev=252355&view=rev
Log:
Another optimization to keep down gdb-remote traffic. If we have suspended a
thread while
running, don't request the thread status when deciding why we stopped.
Author: jingham
Date: Fri Nov 6 16:48:59 2015
New Revision: 252356
URL: http://llvm.org/viewvc/llvm-project?rev=252356&view=rev
Log:
Make the language specifier to "break set" actually filter the names by their
language. So for
instance:
break set -l c++ -r Name
will only break on C++ symbols
Author: jingham
Date: Thu Nov 12 16:32:09 2015
New Revision: 252963
URL: http://llvm.org/viewvc/llvm-project?rev=252963&view=rev
Log:
Another little stepping optimization: if any of the source step commands are
running through a range
of addresses, and the range has no branches, instead of runni
d:\src\llvmbuild\ninja_release\bin\clang.exe
> Session info generated @ Thu Nov 12 15:44:43 2015
> To rerun this test, issue the following command from the 'test' directory:
>
> If it's not obvious what the problem is, can we revert this until we figure
> it out an
rget_line, pattern))
> > AssertionError: False is not True : Stepped to line 0 instead of expected
> > 19 with pattern 'intermediate_return_value =
> > called_from_nodebug_actual(some_value)'.
> > Config=i686-d:\src\llvmbuild\ninja_release\bin\clang.exe
> &
Author: jingham
Date: Thu Nov 12 21:37:48 2015
New Revision: 253008
URL: http://llvm.org/viewvc/llvm-project?rev=253008&view=rev
Log:
Fix commit 252963 to work around a bug on some platforms where they don't
correctly handle stepping over one breakpoint directly onto another breakpoint.
This i
so that Jim can get full logs
> if it helps.
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8391
>
> On Thu, Nov 12, 2015 at 4:37 PM Ying Chen wrote:
> I reverted this patch for now.
> Please resubmit if you have a fix.
>
> Thanks,
> Yi
y this. Makes me feel
> > a little better :)
> >
> > Posting the link to the buildbot failures here so that Jim can get full
> > logs if it helps.
> > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8391
> >
> > On Thu, Nov 12
GetCurrentPlan should never return NULL. The Thread constructor pushes the
Base thread plan onto the stack, and pop won't remove the Base plan. When we
destroy the thread (in ThreadDestroy) we clear the plan stack and then push a
ThreadPlanNull onto the plan stack. So if you are seeing a GetC
Thanks. When I first did the thread plan stuff I wasn't sure whether I would
have a use for an empty plan stack, so I didn't rigorously go through and
assert everywhere that might happen. I had some idea for using an empty plan
stack which was apparently so kooky that not only did I never impl
Author: jingham
Date: Fri Nov 13 16:19:08 2015
New Revision: 253094
URL: http://llvm.org/viewvc/llvm-project?rev=253094&view=rev
Log:
Change the test to use the instruction list to get the consecutive addresses to
break on. Rerunning
was being foiled by ASLR.
Modified:
lldb/trunk/packages/
that short-cut back.
>>
>> I wondered how this managed to cause so many Linux failures, but the OS X
>> testsuite was clean...
>>
>> Jim
>>
>>
>>
>>> On Nov 12, 2015, at 4:57 PM, Zachary Turner wrote:
>>>
>>> Ahh, see
Author: jingham
Date: Fri Nov 13 18:20:33 2015
New Revision: 253106
URL: http://llvm.org/viewvc/llvm-project?rev=253106&view=rev
Log:
Add a "not_in()" function you can apply to the list type arguments to
expectedFailureAll to reverse
the sense of the test.
Modified:
lldb/trunk/packages/Pyth
401 - 500 of 1210 matches
Mail list logo
