Re: [Lldb-commits] [PATCH] D58727: https://reviews.llvm.org/D58394 done right

The event we are stopping for is the stop to single step over a breakpoint. We should have decided not to broadcast that to the public event queue, since it's an implementation stop of the "continue". It almost looks like the stop hook is getting triggered by a not-broadcast event, though that

Re: [Lldb-commits] [lldb] r355375 - [Expression] Remove unused parameter from Evaluate

If you don't mind, I would like to revert this patch. Though the parameter is currently unused on the llvm.org side, it is used in the Swift REPL, so removing it causes unnecessary conflicts. Also, it will be necessary to support any kind of REPL - Sean gave a talk a couple of years ago at the

Re: [Lldb-commits] [lldb] r355375 - [Expression] Remove unused parameter from Evaluate

Eh, I take that back. We switched to injecting #file and #line into the body text to do the same job, so this is indeed no longer needed. Jim > On Mar 5, 2019, at 10:21 AM, Jim Ingham via lldb-commits > wrote: > > If you don't mind, I would like to revert this patch. Tho

Re: [Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

Does objdump not read core files? Jim > On Mar 5, 2019, at 8:53 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In D58976#1418596 , @clayborg wrote: > >> Do we want this in LLVM instead of lldb? > > > The

[Lldb-commits] [lldb] r355560 - Factor the clang specific parts of ExpressionSourceCode.{h, cpp} into the clang plugin.

Author: jingham Date: Wed Mar 6 14:43:25 2019 New Revision: 355560 URL: http://llvm.org/viewvc/llvm-project?rev=355560&view=rev Log: Factor the clang specific parts of ExpressionSourceCode.{h,cpp} into the clang plugin. NFC Differential Revision: https://reviews.llvm.org/D59040 Added: ll

[Lldb-commits] [lldb] r355561 - Fix Cmake files for ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp.

Author: jingham Date: Wed Mar 6 14:53:38 2019 New Revision: 355561 URL: http://llvm.org/viewvc/llvm-project?rev=355561&view=rev Log: Fix Cmake files for ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp. Modified: lldb/trunk/source/Expression/CMakeLists.txt lldb/trunk/source/Plug

Re: [Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

Just to be precise: TypeImpl stores a TypePair for the static type and a CompilerType for the dynamic type. These two have different meanings. There's no assumption about the relationship between the static and dynamic type. In ObjC, the dynamic type need not even be in the same class hierarc

Re: [Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

Mar 11, 2019, at 4:17 PM, Zachary Turner wrote: > > > > On Mon, Mar 11, 2019 at 4:15 PM Jim Ingham via lldb-commits > wrote: > Just to be precise: TypeImpl stores a TypePair for the static type and a > CompilerType for the dynamic type. These two have different meanings.

[Lldb-commits] [lldb] r355951 - Fix the project for r355939 (ASTUtils.{h, c})

Author: jingham Date: Tue Mar 12 11:48:58 2019 New Revision: 355951 URL: http://llvm.org/viewvc/llvm-project?rev=355951&view=rev Log: Fix the project for r355939 (ASTUtils.{h,c}) Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: htt

[Lldb-commits] [lldb] r355956 - Re-enable this test, the underlying bug was fixed and the test now passes.

Author: jingham Date: Tue Mar 12 12:25:29 2019 New Revision: 355956 URL: http://llvm.org/viewvc/llvm-project?rev=355956&view=rev Log: Re-enable this test, the underlying bug was fixed and the test now passes. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/

[Lldb-commits] [lldb] r355957 - Check the result of creating a node from __next_ in the std::list formatter.

Author: jingham Date: Tue Mar 12 12:27:39 2019 New Revision: 355957 URL: http://llvm.org/viewvc/llvm-project?rev=355957&view=rev Log: Check the result of creating a node from __next_ in the std::list formatter. There's a single report of a crash coming from this current_sp being NULL. I don't h

[Lldb-commits] [lldb] r355992 - This test is failing on and off on the bots.

Author: jingham Date: Tue Mar 12 16:15:48 2019 New Revision: 355992 URL: http://llvm.org/viewvc/llvm-project?rev=355992&view=rev Log: This test is failing on and off on the bots. Disable it for now till I can figure out what's going wrong. Modified: lldb/trunk/lit/ExecControl/StopHook/stop-

[Lldb-commits] [lldb] r357141 - Copy the breakpoint site owner's collection so we can drop

Author: jingham Date: Wed Mar 27 18:51:33 2019 New Revision: 357141 URL: http://llvm.org/viewvc/llvm-project?rev=357141&view=rev Log: Copy the breakpoint site owner's collection so we can drop the collection lock before we iterate over the owners calling ShouldStop. BreakpointSite::ShouldStop can

[Lldb-commits] [lldb] r357207 - Fix the swig typemap for "uint32_t *versions, uint32_t num_versions".

Author: jingham Date: Thu Mar 28 12:25:54 2019 New Revision: 357207 URL: http://llvm.org/viewvc/llvm-project?rev=357207&view=rev Log: Fix the swig typemap for "uint32_t *versions, uint32_t num_versions". It was making a list of a certain size but not always filling in that many elements, which wo

Re: [Lldb-commits] [lldb] r357141 - Copy the breakpoint site owner's collection so we can drop

Does https://reviews.llvm.org/D59957 look right? I hadn't used this before but it seems to do the right thing. Jim > On Mar 28, 2019, at 2:01 AM, Pavel Labath wrote: > > On 28/03/2019 02:54, Davide Italiano via lldb-commits wrote: >> On Wed, Mar 27, 2019 at 6:49 PM

[Lldb-commits] [lldb] r357276 - Use the multi-lockable form of std::lock for operator=

Author: jingham Date: Fri Mar 29 10:07:30 2019 New Revision: 357276 URL: http://llvm.org/viewvc/llvm-project?rev=357276&view=rev Log: Use the multi-lockable form of std::lock for operator= For = operators for lists that have mutexes, we were either just taking the locks sequentially or hand-rolli

[Lldb-commits] [lldb] r357963 - Get the run locker before you ask if your thread is valid.

Author: jingham Date: Mon Apr 8 18:33:23 2019 New Revision: 357963 URL: http://llvm.org/viewvc/llvm-project?rev=357963&view=rev Log: Get the run locker before you ask if your thread is valid. I have occasional crashes coming from SBThread::GetExtendedBacktraceThread. The symptom is that we go

Re: [Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

This won't be complete, since we also get collisions between local variables and namespaces, and that wouldn't be detected by your heuristic. I think the trick that Fred used in https://reviews.llvm.org/D46551 is actually pretty complete. An expression is never going to need to look up a variab

[Lldb-commits] [lldb] r358776 - This test doesn't need to be run for all debug formats.

Author: jingham Date: Fri Apr 19 11:46:56 2019 New Revision: 358776 URL: http://llvm.org/viewvc/llvm-project?rev=358776&view=rev Log: This test doesn't need to be run for all debug formats. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/plugins/python_os_plugin/TestPytho

[Lldb-commits] [lldb] r283468 - These test cases don't test different debug info formats.

Author: jingham Date: Thu Oct 6 12:01:00 2016 New Revision: 283468 URL: http://llvm.org/viewvc/llvm-project?rev=283468&view=rev Log: These test cases don't test different debug info formats. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/T

[Lldb-commits] [lldb] r283479 - StringRef::front asserts on empty strings, causing "break modify -c ''" to assert.

Author: jingham Date: Thu Oct 6 13:57:30 2016 New Revision: 283479 URL: http://llvm.org/viewvc/llvm-project?rev=283479&view=rev Log: StringRef::front asserts on empty strings, causing "break modify -c ''" to assert. Added a check for empty at the point where we were going to crash. Modified:

[Lldb-commits] [lldb] r283578 - The PR that caused this test ot fail was fixed in July, removing the XFAIL.

Author: jingham Date: Fri Oct 7 13:15:11 2016 New Revision: 283578 URL: http://llvm.org/viewvc/llvm-project?rev=283578&view=rev Log: The PR that caused this test ot fail was fixed in July, removing the XFAIL. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/gmodules/TestWithModu

[Lldb-commits] [lldb] r283813 - Add the radar number on our end.

Author: jingham Date: Mon Oct 10 17:21:47 2016 New Revision: 283813 URL: http://llvm.org/viewvc/llvm-project?rev=283813&view=rev Log: Add the radar number on our end. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/command/TestWatchpointComm

[Lldb-commits] [lldb] r283820 - Add the related radar on our end for llvm.org/pr15824.

Author: jingham Date: Mon Oct 10 18:29:01 2016 New Revision: 283820 URL: http://llvm.org/viewvc/llvm-project?rev=283820&view=rev Log: Add the related radar on our end for llvm.org/pr15824. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/multi_break/TestMultipleBrea

[Lldb-commits] [lldb] r283821 - Adding radar number on our end for llvm.org/pr15824.

Author: jingham Date: Mon Oct 10 18:31:36 2016 New Revision: 283821 URL: http://llvm.org/viewvc/llvm-project?rev=283821&view=rev Log: Adding radar number on our end for llvm.org/pr15824. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py Mod

[Lldb-commits] [lldb] r283835 - This test was failing because /bin/ls is no longer debuggable on OS X.

Author: jingham Date: Mon Oct 10 19:35:41 2016 New Revision: 283835 URL: http://llvm.org/viewvc/llvm-project?rev=283835&view=rev Log: This test was failing because /bin/ls is no longer debuggable on OS X. Add an executable that we can debug. Added: lldb/trunk/packages/Python/lldbsuite/test/fu

[Lldb-commits] [lldb] r283843 - Fixing the bug number for darwin on this failure.

Author: jingham Date: Mon Oct 10 20:53:43 2016 New Revision: 283843 URL: http://llvm.org/viewvc/llvm-project?rev=283843&view=rev Log: Fixing the bug number for darwin on this failure. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py Modified:

[Lldb-commits] [lldb] r283923 - Added a bugreport tracking the failure to get float return values

Author: jingham Date: Tue Oct 11 14:29:25 2016 New Revision: 283923 URL: http://llvm.org/viewvc/llvm-project?rev=283923&view=rev Log: Added a bugreport tracking the failure to get float return values on i386. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/return-value/Te

[Lldb-commits] [lldb] r283929 - This test now passes.

Author: jingham Date: Tue Oct 11 15:09:40 2016 New Revision: 283929 URL: http://llvm.org/viewvc/llvm-project?rev=283929&view=rev Log: This test now passes. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/list/TestDataFormatterLibcx

[Lldb-commits] [lldb] r283940 - Add the radar number on our end.

Author: jingham Date: Tue Oct 11 16:08:27 2016 New Revision: 283940 URL: http://llvm.org/viewvc/llvm-project?rev=283940&view=rev Log: Add the radar number on our end. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py Modified: lldb/trunk/packages/

[Lldb-commits] [lldb] r283956 - Added a radar on our end for this test's failure.

Author: jingham Date: Tue Oct 11 18:30:38 2016 New Revision: 283956 URL: http://llvm.org/viewvc/llvm-project?rev=283956&view=rev Log: Added a radar on our end for this test's failure. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py Modified

[Lldb-commits] [lldb] r283957 - This was skipped due to a clang PR that has been fixed.

Author: jingham Date: Tue Oct 11 18:55:13 2016 New Revision: 283957 URL: http://llvm.org/viewvc/llvm-project?rev=283957&view=rev Log: This was skipped due to a clang PR that has been fixed. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-incomplete/TestIncompleteModules

[Lldb-commits] [lldb] r283959 - This test now passes.

Author: jingham Date: Tue Oct 11 19:05:36 2016 New Revision: 283959 URL: http://llvm.org/viewvc/llvm-project?rev=283959&view=rev Log: This test now passes. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-auto-import/TestModulesAutoImport.py Modified: lldb/trunk/packag

[Lldb-commits] [lldb] r284182 - This test is passing on i386 now.

Author: jingham Date: Thu Oct 13 20:03:03 2016 New Revision: 284182 URL: http://llvm.org/viewvc/llvm-project?rev=284182&view=rev Log: This test is passing on i386 now. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-class-method/TestObjCClassMethod.py Modified: lldb/trun

[Lldb-commits] [lldb] r284183 - This test passes on i386 now.

Author: jingham Date: Thu Oct 13 20:11:19 2016 New Revision: 284183 URL: http://llvm.org/viewvc/llvm-project?rev=284183&view=rev Log: This test passes on i386 now. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/ivar-IMP/TestObjCiVarIMP.py Modified: lldb/trunk/packages/Python

[Lldb-commits] [lldb] r284296 - This test is no longer failing for gmodules.

Author: jingham Date: Fri Oct 14 19:04:38 2016 New Revision: 284296 URL: http://llvm.org/viewvc/llvm-project?rev=284296&view=rev Log: This test is no longer failing for gmodules. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestObjCMethods2.py Modified: lldb/tru

[Lldb-commits] [lldb] r284439 - Fix a crash in expressions with fixits in the dummy target.

Author: jingham Date: Mon Oct 17 18:59:41 2016 New Revision: 284439 URL: http://llvm.org/viewvc/llvm-project?rev=284439&view=rev Log: Fix a crash in expressions with fixits in the dummy target. In the expression command, if the target is NULL, you have to use the dummy target. Modified: l

[Lldb-commits] [lldb] r284446 - More testsuite xfail markings cleanup.

Author: jingham Date: Mon Oct 17 20:43:22 2016 New Revision: 284446 URL: http://llvm.org/viewvc/llvm-project?rev=284446&view=rev Log: More testsuite xfail markings cleanup. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestObjCMethods2.py lldb/trunk/packages/P

[Lldb-commits] [lldb] r284448 - Remove a debug print statement.

Author: jingham Date: Mon Oct 17 20:52:32 2016 New Revision: 284448 URL: http://llvm.org/viewvc/llvm-project?rev=284448&view=rev Log: Remove a debug print statement. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/register_variables/TestRegisterVariables.py Modified: lldb/trunk/

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

I am pretty sure /bin/sh is supposed to be a posix shell. We could probably use that as well if we felt that there might be an OS X without /bin/bash. But we aren't using any but the most basic properties of the shell along this code path. It isn't being done for shell expansion or anything

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

about a fallback? Try bash, if you can't find it try sh. Thoughts? > On Tue, Oct 18, 2016 at 4:39 PM Jim Ingham via lldb-commits > wrote: > I am pretty sure /bin/sh is supposed to be a posix shell. We could probably > use that as well if we felt that there might be an OS X w

Re: [Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

> On Oct 4, 2016, at 9:28 AM, Pavel Labath via lldb-commits > wrote: > > Also, apparently lldb has a bug, where it mishandles the case where you do a > (user-level) single step over an instruction triggering a watchpoint. That > would be pretty important to fix as well. Do you have a referen

Re: [Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

> On Oct 19, 2016, at 6:35 AM, Pavel Labath via lldb-commits > wrote: > > > > Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:110 > + if (name == ConstString("ptr") || name == ConstString("pointer")) return 2; > + return UINT32_MAX; > +} > --

Re: [Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

> On Oct 19, 2016, at 10:38 AM, Jim Ingham via lldb-commits > wrote: > > >> On Oct 19, 2016, at 6:35 AM, Pavel Labath via lldb-commits >> wrote: >> >> >> >> Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePo

[Lldb-commits] [PATCH] D25792: Don't set a software stepping breakpoint at 0 on arm.

jingham added a comment. Not commenting on the substance of the change (though it seems sensible to me.) The inclusion of the .gitignore was probably accidental, but in any case, try not to gang unrelated changes together like this. Thanks! https://reviews.llvm.org/D25792

Re: [Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

Ah, I see, thanks. If you can make a test case that fails on ARM in the current state of things, I would be interested in taking a look at it. We had to do an analogous little dance for stepping from one breakpoint to another. Probably not the same solution, but we can surely get this to work

[Lldb-commits] [lldb] r284791 - Remove an unnecessary and incorrect check for num locations of a breakpoint

Author: jingham Date: Thu Oct 20 17:49:06 2016 New Revision: 284791 URL: http://llvm.org/viewvc/llvm-project?rev=284791&view=rev Log: Remove an unnecessary and incorrect check for num locations of a breakpoint by grubbing the break list output. If you pass a number of locations into the run_break

[Lldb-commits] [lldb] r284792 - Add an API to remove an action from the Process PreResumeActions.

Author: jingham Date: Thu Oct 20 17:50:00 2016 New Revision: 284792 URL: http://llvm.org/viewvc/llvm-project?rev=284792&view=rev Log: Add an API to remove an action from the Process PreResumeActions. Modified: lldb/trunk/include/lldb/Target/Process.h lldb/trunk/source/Target/Process.cpp

[Lldb-commits] [lldb] r284795 - Fix a race condition between "ephemeral watchpoint disable/enable" and continue in commands.

Author: jingham Date: Thu Oct 20 19:06:38 2016 New Revision: 284795 URL: http://llvm.org/viewvc/llvm-project?rev=284795&view=rev Log: Fix a race condition between "ephemeral watchpoint disable/enable" and continue in commands. Also, watchpoint commands, like breakpoint commands, need to run in a

Re: [Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

Yeah, sorry, that was an oversight on my part, but I think it's trivial to fix. The WatchpointSentry was being set up before the little single step over the watchpoint dance, and it was accidentally being used to get the watchpoint disabled. That's not the main point of the sentry, which is to

[Lldb-commits] [lldb] r284851 - Add the new stdcpp formatters to the Xcode project.

Author: jingham Date: Fri Oct 21 13:18:25 2016 New Revision: 284851 URL: http://llvm.org/viewvc/llvm-project?rev=284851&view=rev Log: Add the new stdcpp formatters to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj UR

Re: [Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

s see the same state. But that's a question for another day. Jim > On Oct 21, 2016, at 11:05 AM, Jim Ingham via lldb-commits > wrote: > > Yeah, sorry, that was an oversight on my part, but I think it's trivial to > fix. The WatchpointSentry was being set up before

Re: [Lldb-commits] [lldb] r284817 - Revert "Fix a race condition between "ephemeral watchpoint disable/enable" and continue in commands."

Note that the WatchpointSentry logic predated the support for "!watchpoint_triggers_after", and it's real goal was to have accesses to the watchpoint in commands in the breakpoint action not re-trigger the watchpoint. The step-over-watchpoint logic was accidentally getting the benefit of this,

[Lldb-commits] [lldb] r285113 - Fixing up the project file for the removal of LibStdcppSmartPointer.cpp.

Author: jingham Date: Tue Oct 25 15:32:26 2016 New Revision: 285113 URL: http://llvm.org/viewvc/llvm-project?rev=285113&view=rev Log: Fixing up the project file for the removal of LibStdcppSmartPointer.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodepr

[Lldb-commits] [lldb] r285114 - Fix a race condition between the "ephemeral watchpoint disabling" and commands the continue the process.

Author: jingham Date: Tue Oct 25 15:34:32 2016 New Revision: 285114 URL: http://llvm.org/viewvc/llvm-project?rev=285114&view=rev Log: Fix a race condition between the "ephemeral watchpoint disabling" and commands the continue the process. This closes https://reviews.llvm.org/D25875. Modified:

Re: [Lldb-commits] [lldb] r285068 - Revert "Improve the libstdc++ smart pointer formatters"

I already fixed this in r285113. Jim > On Oct 25, 2016, at 2:49 PM, Tim Hammerquist via lldb-commits > wrote: > > Hi Pavel, > > Looks like some code left after this revert is still expecting this file > (added contemporary to r284828) that was removed in this revision. > > --- lldb/trunk/so

[Lldb-commits] [lldb] r285153 - SBWatchpoint::Disable doesn't actually work. Add a test that shows this.

Author: jingham Date: Tue Oct 25 20:09:21 2016 New Revision: 285153 URL: http://llvm.org/viewvc/llvm-project?rev=285153&view=rev Log: SBWatchpoint::Disable doesn't actually work. Add a test that shows this. Next to fix it! Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/wa

Re: [Lldb-commits] [lldb] r285068 - Revert "Improve the libstdc++ smart pointer formatters"

For people who have a Mac and can make changes to the project files, we consider it polite and kind that they also fix up the project file when they add or remove source files. But we also realize it isn't reasonable to require that somebody working on Linux, Windows, etc. have access to a Mac

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

jingham added a comment. Note that in this proposal, lldb is doing pretty much the same thing that libclang does. libclang exports its specific functionality but makes no attempt to export the llvm classes it uses. The only difference is that lldb exports a tightly controlled C++ API, whereas

[Lldb-commits] [lldb] r285742 - Switch SBWatchpoint::SetEnabled over to using Process::{Enable, Disable}Watchpoint.

Author: jingham Date: Tue Nov 1 15:37:02 2016 New Revision: 285742 URL: http://llvm.org/viewvc/llvm-project?rev=285742&view=rev Log: Switch SBWatchpoint::SetEnabled over to using Process::{Enable,Disable}Watchpoint. We don't have a good story for what happens to watchpoints when you don't have

[Lldb-commits] [lldb] r285761 - Xfail this while I figure out why the event isn't getting sent.

Author: jingham Date: Tue Nov 1 17:53:54 2016 New Revision: 285761 URL: http://llvm.org/viewvc/llvm-project?rev=285761&view=rev Log: Xfail this while I figure out why the event isn't getting sent. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_even

[Lldb-commits] [lldb] r285781 - Fix SBWatchpoint::SetEnabled to send an event.

Author: jingham Date: Tue Nov 1 20:06:42 2016 New Revision: 285781 URL: http://llvm.org/viewvc/llvm-project?rev=285781&view=rev Log: Fix SBWatchpoint::SetEnabled to send an event. We really shouldn't be sending events for SB API's, dunno when we started doing that. We don't do it for other thin

[Lldb-commits] [lldb] r285974 - Don't access the process in expressions w/o checking that

Author: jingham Date: Thu Nov 3 18:42:09 2016 New Revision: 285974 URL: http://llvm.org/viewvc/llvm-project?rev=285974&view=rev Log: Don't access the process in expressions w/o checking that the process exists. I also added some tests that crash before this fix, and work correctly after. Adde

[Lldb-commits] [lldb] r285977 - Added a couple more odd dot patterns that we got out

Author: jingham Date: Thu Nov 3 20:47:59 2016 New Revision: 285977 URL: http://llvm.org/viewvc/llvm-project?rev=285977&view=rev Log: Added a couple more odd dot patterns that we got out of clang. Modified: lldb/trunk/unittests/Host/FileSpecTest.cpp Modified: lldb/trunk/unittests/Host/FileSp

[Lldb-commits] [lldb] r286170 - UserExpression::Evaluate only returns a non-empty ValueObjectSP

Author: jingham Date: Mon Nov 7 16:47:01 2016 New Revision: 286170 URL: http://llvm.org/viewvc/llvm-project?rev=286170&view=rev Log: UserExpression::Evaluate only returns a non-empty ValueObjectSP if it returns eExpressionCompleted. Don't try to get the error from the ValueObjectSP if that's not

[Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I seem not to close the formal loop on these reviews... https://reviews.llvm.org/D22231 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D26325: Re-write OutputFormattedHelpText in terms of StringRef

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks formally equivalent to me. https://reviews.llvm.org/D26325 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [lldb] r286288 - Clean up the stop printing header lines.

Author: jingham Date: Tue Nov 8 14:36:40 2016 New Revision: 286288 URL: http://llvm.org/viewvc/llvm-project?rev=286288&view=rev Log: Clean up the stop printing header lines. I added a "thread-stop-format" to distinguish between the form that is just the thread info (since the stop printing immed

[Lldb-commits] [lldb] r286301 - Fix up the formats.html for the addition of the thread-stop-format.

Author: jingham Date: Tue Nov 8 16:05:29 2016 New Revision: 286301 URL: http://llvm.org/viewvc/llvm-project?rev=286301&view=rev Log: Fix up the formats.html for the addition of the thread-stop-format. Modified: lldb/trunk/www/formats.html Modified: lldb/trunk/www/formats.html URL: http:/

[Lldb-commits] [lldb] r286312 - "thread backtrace" should use the thread-stop-format.

Author: jingham Date: Tue Nov 8 17:43:36 2016 New Revision: 286312 URL: http://llvm.org/viewvc/llvm-project?rev=286312&view=rev Log: "thread backtrace" should use the thread-stop-format. Modified: lldb/trunk/source/Commands/CommandObjectThread.cpp Modified: lldb/trunk/source/Commands/Comm

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

jingham added a comment. This is fine with one comment on the text. Comment at: SB-api-coding-rules.html:51-54 +An example of this is the SBValue class. Please note it is necessary for the Impl class to +

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D26470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [Lldb-commits] [PATCH] D26528: Fix uninitialized members.

> On Nov 10, 2016, at 8:57 PM, Zachary Turner via lldb-commits > wrote: > > Maybe just inline the initializations so we don't have to repeat code across > multiple constructors? i.e. > > bool m_is_resolved = false; > > in the header file. I actually like the ability to do this in the heade

Re: [Lldb-commits] [PATCH] D26528: Fix uninitialized members.

Is it worthwhile having some place where we can put this sort of policy so people don't have to follow our mailing list to know this sort of rule? The coding conventions were one possible site, but that fell victim to the code reformat... Jim > On Nov 11, 2016, at 9:11 AM, Zachary Turner wro

[Lldb-commits] [PATCH] D26553: Remove weak-linked symbols for SBBreakpointListImpl

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine. https://reviews.llvm.org/D26553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D26528: Fix uninitialized members.

jingham accepted this revision. jingham added a reviewer: jingham. jingham added a comment. This revision is now accepted and ready to land. Looks fine to me. https://reviews.llvm.org/D26528 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

jingham added a comment. Besides Greg's comments, this looks reasonable to me. https://reviews.llvm.org/D26676 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r287189 - Make GetValueForVariableExpression use StringRef.

Probably just an oversight, but changing var_expr_cstr to a StringRef, but leaving it called "_cstr" will cause confusion. Jim > On Nov 16, 2016, at 5:37 PM, Zachary Turner via lldb-commits > wrote: > > Author: zturner > Date: Wed Nov 16 19:37:52 2016 > New Revision: 287189 > > URL: http://l

Re: [Lldb-commits] [lldb] r287242 - Rewrite all Property related functions in terms of StringRef.

I bet we don’t have enough test coverage in this area to ensure that these changes didn’t break things. Did you check how much test coverage there was? If it isn’t good, which is my guess for properties, then it is good hygiene to add more tests that pass in the old way before embarking on thi

Re: [Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

Yes, comp unit equal, no function and symbol equal should be treated as equivalent. However, your check would call two SymbolContexts equivalent that had different CompUnits but the same symbol. I can’t see how that would happen in practice, but if it did something odd has gone on, and we prob

[Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That way of doing it is fine too. https://reviews.llvm.org/D26804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.o

Re: [Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

Ah, good catch. That is not right. If there’s inlined function information, you want to make sure you haven’t gone from one inlined function to another. But the symbol is always going to be the same in this case. Actually, the old code is a overly restrictive by comparing the blocks directly

Re: [Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

> On Nov 17, 2016, at 1:45 PM, Sam McCall wrote: > > On Thu, Nov 17, 2016 at 10:29 PM, Jim Ingham > wrote: > Ah, good catch. That is not right. If there’s inlined function information, > you want to make sure you haven’t gone from one inlined function to another.

[Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

jingham added a comment. Excellent, thanks for catching that. https://reviews.llvm.org/D26804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

If we are going to do that, I wonder if we should start having tests share their inputs. We don’t do that for source files because the cost of duplication is so small, and then you don’t have the hassle of adding something to a source fie for test A messes up test B. But for binaries like core

Re: [Lldb-commits] [lldb] r287354 - Resubmit "Remove an output-parameter from Variable function".

I didn’t see this patch go up for review. The parameter you removed might have been vestigial or might have been one that the owner of this code was planning to do something with. Anyway, this seems to go beyond purely formal changes and so should have been discussed. My apologies if I just m

Re: [Lldb-commits] [lldb] r287354 - Resubmit "Remove an output-parameter from Variable function".

Not a big deal. Formal changes are fine, but even dead code in areas you don’t work on might represent a work in progress, so it’s good to ask first. For instance, Enrico and Greg originally had plans for “frame var” to be able to print slices of arrays - that’s presumably the dead code functi

[Lldb-commits] [lldb] r287386 - Fix "thread step until" handling of multiple line inputs.

Author: jingham Date: Fri Nov 18 16:06:10 2016 New Revision: 287386 URL: http://llvm.org/viewvc/llvm-project?rev=287386&view=rev Log: Fix "thread step until" handling of multiple line inputs. Also document that it handles same, and add some tests. Added: lldb/trunk/packages/Python/lldbsuite/

[Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

jingham added a comment. In https://reviews.llvm.org/D26883#600683, @labath wrote: > I don't know how deep do you want this refactor to be, but there is one issue > I would like us to consider, if only to decide it is out of scope of this > change. I am talking about the `quote_char` thingy. Th

Re: [Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

backtick parsing is currently incorrect, because it parses the backtick before doing arg parsing, which means it does the substitutions for “raw” commands: (lldb) expr char *$foo = "some `1 + 2` string" (lldb) expr $foo (char *) $foo = 0x00010032f100 "some 3 string" That’s unexpected, and si

Re: [Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

> On Nov 29, 2016, at 7:53 AM, Pavel Labath wrote: > > On 28 November 2016 at 18:06, Jim Ingham wrote: >> backtick parsing is currently incorrect, because it parses the backtick >> before doing arg parsing, which means it does the substitutions for “raw” >> commands: >> >> (lldb) expr char *$f

Re: [Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

> On Dec 2, 2016, at 2:47 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In https://reviews.llvm.org/D27289#611082, @jasonmolenda wrote: > >> @labath ah I see I hadn't looked at the lldb-server packets so I didn't know >> you had jThreadsInfo, good

Re: [Lldb-commits] [PATCH] D27394: Fix expression evaluation inside lambda functions for gcc

> On Dec 6, 2016, at 1:42 AM, Tamas Berghammer via Phabricator > wrote: > > tberghammer added a reviewer: aprantl. > tberghammer added a comment. > > +Adrian > > Thank you for all the comment. I agree that teaching the AST Importer to be > able to handle types inside a DeclBlock would be the

[Lldb-commits] [lldb] r289695 - Test num locations >= 1 not == 1.

Author: jingham Date: Wed Dec 14 13:35:56 2016 New Revision: 289695 URL: http://llvm.org/viewvc/llvm-project?rev=289695&view=rev Log: Test num locations >= 1 not == 1. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py

[Lldb-commits] [lldb] r289746 - Fix incorrectly named variables.

Author: jingham Date: Wed Dec 14 18:30:30 2016 New Revision: 289746 URL: http://llvm.org/viewvc/llvm-project?rev=289746&view=rev Log: Fix incorrectly named variables. Modified: lldb/trunk/source/API/SBFrame.cpp lldb/trunk/source/API/SBTarget.cpp lldb/trunk/source/Interpreter/CommandIn

[Lldb-commits] [lldb] r290216 - Ignore SIGPIPE in the mini-driver used by these tests.

Author: jingham Date: Tue Dec 20 18:12:54 2016 New Revision: 290216 URL: http://llvm.org/viewvc/llvm-project?rev=290216&view=rev Log: Ignore SIGPIPE in the mini-driver used by these tests. We're seeing some very occasional failures in these tests where the mini-driver dies with a SIGPIPE. We don

[Lldb-commits] [lldb] r293666 - Move the stop point to somewhere before the final use of the

Author: jingham Date: Tue Jan 31 12:26:20 2017 New Revision: 293666 URL: http://llvm.org/viewvc/llvm-project?rev=293666&view=rev Log: Move the stop point to somewhere before the final use of the variable we are inspecting. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/d

Re: [Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

> On Jan 31, 2017, at 3:59 PM, Zachary Turner via Phabricator via lldb-commits > wrote: > > zturner created this revision. > Herald added a subscriber: mgorny. > > The goal here is to make `lldbUtility` a library which depends on no other > libraries. It seems like this library already exist

Re: [Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

My vote is to err on the side of leaving stuff in Utility that is general (like SharingPtr) but only used by one client, rather than moving it next to its current only client. After all, you are likely to go dumpster diving in Utility when you need a tool, but you're less likely to look through

Re: [Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

I think we discussed this before, but we need an informational error object. IIRC, the llvm::Error has to be checked. But for instance if you ask a value object to evaluate itself, but you've moved to a section of code where the variable has no location, then evaluating that value will result

<    1   2   3   4   5   6   7   8   9   10   >