Author: emaste
Date: Mon Sep 21 20:36:21 2015
New Revision: 248236
URL: http://llvm.org/viewvc/llvm-project?rev=248236&view=rev
Log:
Remove expectedFailureFreeBSD from passing test_expr_null_with_dwarf
llvm.org/pr21550
Modified:
lldb/trunk/test/lang/c/anonymous/TestAnonymous.py
Modified: ll
Author: emaste
Date: Tue Sep 22 08:27:26 2015
New Revision: 248269
URL: http://llvm.org/viewvc/llvm-project?rev=248269&view=rev
Log:
Remove expectedFailureFreeBSD from passing test
HelloWorldTestCase::test_with_dwarf_and_process_launch_api passes
consistently for me and for John Wolfe.
llvm.org/
Author: emaste
Date: Tue Sep 22 08:31:16 2015
New Revision: 248271
URL: http://llvm.org/viewvc/llvm-project?rev=248271&view=rev
Log:
Remove expectedFailureFreeBSD from passing tests
These two tests are skipped on Linux with a comment that the behaviour
is as expected, but they are consistently pa
emaste created this revision.
emaste added reviewers: granata.enrico, clayborg, brucem.
emaste added a subscriber: lldb-commits.
And remove the switch default, so that the -Wcovered-switch-default warning
will catch new types in the future.
http://reviews.llvm.org/D13096
Files:
source/Symbol/
emaste added a comment.
Oh, it seems there are more new types added after I first made this change:
../tools/lldb/source/Symbol/ClangASTContext.cpp:4445:21: warning: 10
enumeration values not handled in switch: 'OCLImage2dDepth',
'OCLImage2dArrayDepth', 'OCLImage2dMSAA'... [-Wswitch]
http:/
On 23 September 2015 at 03:19, Ravitheja Addepally via lldb-commits
wrote:
> Author: ravitheja
> Date: Wed Sep 23 02:19:02 2015
> New Revision: 248366
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248366&view=rev
> Log:
> Testcase and fix for bug 24074
This change introduced a segfault in 10 o
emaste retitled this revision from "Handle OMPArraySection in
ClangASTContext::GetEncoding" to "Handle new types in
ClangASTContext::GetEncoding".
emaste updated this revision to Diff 35532.
emaste added a comment.
More new types added after my initial patch.
http://reviews.llvm.org/D13096
Fi
Author: emaste
Date: Wed Sep 23 13:20:51 2015
New Revision: 248410
URL: http://llvm.org/viewvc/llvm-project?rev=248410&view=rev
Log:
Remove expectedFailureFreeBSD from passing TestChangeValueAPI test
This test used fail intermittently, but now passes consistently on
FreeBSD in local runs. We'll i
Author: emaste
Date: Wed Sep 23 13:23:38 2015
New Revision: 248411
URL: http://llvm.org/viewvc/llvm-project?rev=248411&view=rev
Log:
Remove expectedFailureFreeBSD from passing test
ClassTypesTestCase::test_with_dwarf_and_constructor_name
llvm.org/pr14540
Modified:
lldb/trunk/test/lang/cpp/c
Author: emaste
Date: Wed Sep 23 13:32:34 2015
New Revision: 248414
URL: http://llvm.org/viewvc/llvm-project?rev=248414&view=rev
Log:
Handle new types in ClangASTContext::GetEncoding
And remove the switch default, so that the -Wcovered-switch-default
warning will catch new types next time they're
emaste added a comment.
http://reviews.llvm.org/rL248414
http://reviews.llvm.org/D13096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248414: Handle new types in ClangASTContext::GetEncoding
(authored by emaste).
Changed prior to commit:
http://reviews.llvm.org/D13096?vs=35532&id=35537#toc
Repository:
rL LLVM
http://reviews.llvm.o
I'd suggest we revert for now and bring it back after testing on all
platforms. There were a couple of nits and changes in the committed
version relative to the version in the review as well so I think it's
better to bring it back with those fixed up.
On 23 September 2015 at 14:52, Enrico Granata
On 23 September 2015 at 13:47, Siva Chandra via lldb-commits
wrote:
> Author: sivachandra
> Date: Wed Sep 23 12:47:08 2015
> New Revision: 248401
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248401&view=rev
> Log:
> DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or
>
On 24 September 2015 at 10:04, Siva Chandra wrote:
> I don't have access to a FreeBSD or a mac at the moment. Can you, or someone
> else, check how -fstandalone-debug and -fno-standalone-debug behave?
Both OS X and FreeBSD default to full debug info, but the enable /
disable options should still
On 24 September 2015 at 17:35, Siva Chandra wrote:
>
> As blaikie pointed out on the review, it could be because libc++ (which is
> the default on FreeBSD and Darwin?) does not have an explicit declaration
> for std::basic_string<...>? I have now landed a change which removes the
> dependence on s
Author: emaste
Date: Fri Sep 25 10:36:30 2015
New Revision: 248574
URL: http://llvm.org/viewvc/llvm-project?rev=248574&view=rev
Log:
Re-enable some skipped tests on FreeBSD
These tests were skipped because they hung the old FreeBSD buildbot.
They pass (and do not hang) when run locally so enable
Author: emaste
Date: Fri Sep 25 11:10:40 2015
New Revision: 248577
URL: http://llvm.org/viewvc/llvm-project?rev=248577&view=rev
Log:
Re-enable FreeBSD tests do not hang locally
These tests used to hang on the old FreeBSD buildbot, which has been
retired. They do not hang when run locally, but do
emaste added a comment.
No objection from me on the FreeBSD side. I'm leaving shortly to travel to
EuroBSDCon so probably will not be able to test before Wednesday, but I can
investigate and update decorators as appropriate afterwards.
http://reviews.llvm.org/D13028
emaste wrote:
commit message has typo `coreected`
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1245,9 +1245,10 @@ bool FormatEntity::Format(const Entry &entry, Stream &s,
llvm::Triple::OSType ostype = arch.IsValid()
? arch.GetTriple().getOS()
: llvm::Triple::Unknow
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/74198
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,165 @@
+#ifndef
LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H
+#define
LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H
+
+#include
+#include
+#include
+
+#include "lldb/Target/DynamicLoader.h"
+#include
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
emaste wrote:
Needs to be adapted for f2d32ddcec82c20582c6aa32558b82ca7c3d3c50,
`lldb/source/{Core => Host/common}/StreamFile.cpp`
(I've applied the change locally for testing, and will just fold it into the
patch series if otherwise ready to go.)
https://github.com/llvm/llvm-project/pull/67
emaste wrote:
> Excuse me. If the code works well now, I want to ask if I need to modify the
> commit message by myself so the message looks tidy, or let somebody landing
> this pull request modify the message?
This will be the first substantial change I'd land after LLVM moved to use pull
re
emaste wrote:
> I will let other FreeBSD folks do the final approval since I don't work on
> FreeBSD.
@clayborg this change LGTM for FreeBSD. I'm still not fully sorted on the
approach for landing the commits post transition to GitHub. Also see the
comment about author name above.
https://g
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
https://llvm.org/docs/GitHub.html#landing-your-change
> There are two different ways to do this:
>
> - [Interactive rebase](https://git-scm.com/docs/git-rebase#_interactive_mode)
> with fixup’s. This is the recommended method since you can control the final
> commit message and i
emaste wrote:
Oh, I think we should also mention GSoC in the commit message. Something like
`This project was part of FreeBSD's participation in Google Summer of Code
2023.` or so.
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mail
https://github.com/emaste approved this pull request.
(Assuming the comment removal gets squashed into one commit)
https://github.com/llvm/llvm-project/pull/84147
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/emaste commented:
It looks like the commit messages and content are mismatched - the commit
message references AT_HWCAP2 but it doesn't look like that's included here?
https://github.com/llvm/llvm-project/pull/85057
___
lldb-commits
emaste wrote:
> is there not a Posix way to get these
Not really. On FreeBSD these generally come from sysctl(s).
Of the ones added in this pull request SetParentProcessID is already handled on
FreeBSD, while SetProcessGroupID, SetProcessSessionID, SetUserTime,
SetSystemTime, SetCumulativeUse
emaste wrote:
MD5 is insufficient for claiming that files are identical; how do we migrate
this to a secure hash?
https://github.com/llvm/llvm-project/pull/88812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
emaste wrote:
Ok, submitted https://github.com/llvm/llvm-project/issues/89271 for the MD5
migration. I agree that issue does not block this change.
https://github.com/llvm/llvm-project/pull/88812
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
@@ -429,7 +429,43 @@ incompatible with the flags that gdb specifies.
//
// Response is F, followed by the number of bytes written (base 16)
+//--
+// vFile:MD5:
+//
+// BRIEF
+// Generate an MD5 hash of the
https://github.com/emaste approved this pull request.
This is reasonable and in line with the existing special case for NetBSD, but
it seems like this logic shouldn't really be here but in a target-specific
file. When (live or corefile) cross-debugging a FreeBSD target we should look
in $LOCAL
https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/81355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
@zxombie fyi
https://github.com/llvm/llvm-project/pull/85058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/84155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
Yes I think it's likely fixed. I'll give it a try on my FreeBSD laptop shortly.
https://github.com/llvm/llvm-project/pull/84155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
emaste wrote:
> However, for minimal dump, the build-id section won't loaded because minimal
> dump only dump the used memory by kernel.
If we fall back to no-UUID-found in that case and don't require that it matches
this is still an improvement, yeah?
https://github.com/llvm/llvm-project/pul
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/84022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/84024
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
CC @zxombie
https://github.com/llvm/llvm-project/pull/84032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -362,7 +363,15 @@ TEST(RegisterContextFreeBSDTest, arm64) {
EXPECT_GPR_ARM64(lr, lr);
EXPECT_GPR_ARM64(sp, sp);
EXPECT_GPR_ARM64(pc, elr);
+#if __FreeBSD_version >= 1400084
emaste wrote:
This will be correct when the host running the debugger is the s
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/84026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -237,6 +250,16 @@ class ProcessInstanceInfo : public ProcessInfo {
m_cumulative_system_time.tv_usec > 0;
}
+ int8_t GetNiceValue() const { return m_nice_value; }
emaste wrote:
nice and priority are not synonymous though, nice is one input int
@@ -12,6 +12,9 @@
#include "lldb/Utility/ProcessInfo.h"
#include "gtest/gtest.h"
+#include
+#include
emaste wrote:
Much of this file would work just fine on FreeBSD as well so that might make
sense, although I'm not sure what the best structure would be --
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ Status status;
+ int proc_debug, ret;
+ size_t len = sizeof(proc_debug);
+ ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", &proc_debug,
+
@@ -48,14 +48,36 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ int proc_debug, ret;
+ size_t len = sizeof(proc_debug);
+ ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", &proc_debug,
+ &
emaste wrote:
Thanks for picking this up -- I was starting to take a look but was sidetracked
with a lot of yak shaving.
https://github.com/llvm/llvm-project/pull/79662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/79662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
commit message probably needs updating for the logic change (no longer
beforehand)
Another reason to defer the check until failure occurs - if the user happens to
be running lldb as root ptrace will be able to attach independent of the state
of that sysctl
https://github.com/ll
Author: Andrew Turner
Date: 2021-09-28T10:51:06-04:00
New Revision: 993ada05f5a05615ec16da4a69bd368529a7e5d1
URL:
https://github.com/llvm/llvm-project/commit/993ada05f5a05615ec16da4a69bd368529a7e5d1
DIFF:
https://github.com/llvm/llvm-project/commit/993ada05f5a05615ec16da4a69bd368529a7e5d1.diff
emaste wrote:
Hmm, when I attempt to close it via the GitHub UI I get:
I think I can just fetch the commit locally and then push it to the tree
https://github.com/llvm/llvm-project/pull/67106
https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste wrote:
I'm not sure why @aokblast's reply didn't appear here, but indeed `%zu` is the
right format specifier.
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/68210
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ed Maste
Date: 2020-04-02T00:12:24-04:00
New Revision: af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f
URL:
https://github.com/llvm/llvm-project/commit/af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f
DIFF:
https://github.com/llvm/llvm-project/commit/af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f.diff
LOG:
Author: Ed Maste
Date: 2020-04-02T09:43:01-04:00
New Revision: 55e32e92cda79a9eb4487ea8e4ec1b968fac5145
URL:
https://github.com/llvm/llvm-project/commit/55e32e92cda79a9eb4487ea8e4ec1b968fac5145
DIFF:
https://github.com/llvm/llvm-project/commit/55e32e92cda79a9eb4487ea8e4ec1b968fac5145.diff
LOG:
Author: Ed Maste
Date: 2020-09-30T09:25:27-04:00
New Revision: f794160c6cb7da4b5ef354a91fe498341f651d36
URL:
https://github.com/llvm/llvm-project/commit/f794160c6cb7da4b5ef354a91fe498341f651d36
DIFF:
https://github.com/llvm/llvm-project/commit/f794160c6cb7da4b5ef354a91fe498341f651d36.diff
LOG:
On Wed, 14 Oct 2020 at 10:44, Pavel Labath via lldb-commits
wrote:
>
> Author: Pavel Labath
> Date: 2020-10-14T16:43:45+02:00
> New Revision: ea3a547f0be20d86b041778ae8e2779f2031f714
>
> URL:
> https://github.com/llvm/llvm-project/commit/ea3a547f0be20d86b041778ae8e2779f2031f714
> DIFF:
> https:/
On Fri, 28 Jun 2019 at 14:14, Jonas Devlieghere via lldb-commits
wrote:
>
> Author: jdevlieghere
> Date: Fri Jun 28 11:14:27 2019
> New Revision: 364669
>
> URL: http://llvm.org/viewvc/llvm-project?rev=364669&view=rev
> Log:
> [GDBRemote] Remove code that flushes GDB remote packets
>
> The arbitra
On Fri, 13 Nov 2020 at 23:02, Jonas Devlieghere via lldb-commits
wrote:
>
>
> Author: Jonas Devlieghere
> Date: 2020-11-13T20:02:05-08:00
> New Revision: 875be9f454c31c94701bdf4e28f8bea07a8c9c79
>
> URL:
> https://github.com/llvm/llvm-project/commit/875be9f454c31c94701bdf4e28f8bea07a8c9c79
> DIFF
201 - 266 of 266 matches
Mail list logo
