DavidSpickett wrote:
This is failing on AArch64 Linux and Windows, it finds some async error in the
output but the bots don't say what. I'll find what it is.
https://github.com/llvm/llvm-project/pull/65822
___
lldb-commits mailing list
lldb-commits@li
@@ -127,3 +128,65 @@ def tearDown(self):
# Call super's tearDown().
TestBase.tearDown(self)
+
+def test_run_then_attach_wait_interrupt(self):
+# Test that having run one process doesn't cause us to be unable
+# to interrupt a
Author: David Spickett
Date: 2023-09-20T10:20:45+01:00
New Revision: d7fab666955e9ef0d456b6dfb737f5a18241c97c
URL:
https://github.com/llvm/llvm-project/commit/d7fab666955e9ef0d456b6dfb737f5a18241c97c
DIFF:
https://github.com/llvm/llvm-project/commit/d7fab666955e9ef0d456b6dfb737f5a18241c97c.diff
@@ -127,3 +128,65 @@ def tearDown(self):
# Call super's tearDown().
TestBase.tearDown(self)
+
+def test_run_then_attach_wait_interrupt(self):
+# Test that having run one process doesn't cause us to be unable
+# to interrupt a
Author: David Spickett
Date: 2023-09-20T10:01:32Z
New Revision: 3d422c46828387770be07547d335a71719901979
URL:
https://github.com/llvm/llvm-project/commit/3d422c46828387770be07547d335a71719901979
DIFF:
https://github.com/llvm/llvm-project/commit/3d422c46828387770be07547d335a71719901979.diff
LOG
Author: David Spickett
Date: 2023-09-20T16:05:34+01:00
New Revision: fdc265be26483be1e081ea3f1e11d78b8cc488af
URL:
https://github.com/llvm/llvm-project/commit/fdc265be26483be1e081ea3f1e11d78b8cc488af
DIFF:
https://github.com/llvm/llvm-project/commit/fdc265be26483be1e081ea3f1e11d78b8cc488af.diff
DavidSpickett wrote:
I've just pushed a similar fix for SVE's VG
(https://github.com/llvm/llvm-project/commit/fdc265be26483be1e081ea3f1e11d78b8cc488af).
Fixes some test flakiness so I've pushed it directly.
https://github.com/llvm/llvm-project/pull/66768
___
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/66768
>From 3d4834fd5ab994dd312b28b874e73f0807b117dc Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 22 Aug 2023 14:42:35 +0100
Subject: [PATCH] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66767
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/66767
>From 705251d8ecbed546f46a5929a298ad88c70cc330 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 22 Aug 2023 11:12:23 +0100
Subject: [PATCH] [lldb][AArch64] Add release notes and documentation for SM
DavidSpickett wrote:
Thanks for looking into this. Well for now at least we know that users on Linux
will only see the bug 1 in N times :)
(the bots are still red but for unrelated reasons)
https://github.com/llvm/llvm-project/pull/65822
___
lldb-com
Author: David Spickett
Date: 2023-09-21T09:30:07Z
New Revision: a7b78cac9a77e3ef6bbbd8ab1a559891dc693401
URL:
https://github.com/llvm/llvm-project/commit/a7b78cac9a77e3ef6bbbd8ab1a559891dc693401
DIFF:
https://github.com/llvm/llvm-project/commit/a7b78cac9a77e3ef6bbbd8ab1a559891dc693401.diff
LOG
DavidSpickett wrote:
I've reverted this due to failures on Arm/AArch64 Linux, well, one test
failing, one passing unexpectedly. Likely they are expecting the watchpoint to
go off even when not modified. If I can fix them I'll do that and reland this.
https://github.com/llvm/llvm-project/pull/6
Author: David Spickett
Date: 2023-09-21T10:35:15Z
New Revision: 75e862077834c06e574d34e8958dd2ee7cc1d334
URL:
https://github.com/llvm/llvm-project/commit/75e862077834c06e574d34e8958dd2ee7cc1d334
DIFF:
https://github.com/llvm/llvm-project/commit/75e862077834c06e574d34e8958dd2ee7cc1d334.diff
LOG
DavidSpickett wrote:
I've updated the tests and relanded but there is still some stuff to check. The
tagged address test is working fine but the default watchpoint type is
different between the 2 commands, which seems wrong at first glance.
For the other one see https://github.com/llvm/llvm-pr
DavidSpickett wrote:
Where the "commands" are:
```
watchpoint set expression -s 4 -- tagged_ptr
watchpoint set variable global_var
```
They default to different types.
https://github.com/llvm/llvm-project/pull/66308
___
lldb-commits mailing list
lldb-c
Author: David Spickett
Date: 2023-09-21T13:24:34+01:00
New Revision: 43812c8c87b1c14bbcd160d613b7d8a60c21f260
URL:
https://github.com/llvm/llvm-project/commit/43812c8c87b1c14bbcd160d613b7d8a60c21f260
DIFF:
https://github.com/llvm/llvm-project/commit/43812c8c87b1c14bbcd160d613b7d8a60c21f260.diff
Author: David Spickett
Date: 2023-09-21T12:53:18Z
New Revision: 3fa503582315f23f187a019f026c5fce59b3f3d8
URL:
https://github.com/llvm/llvm-project/commit/3fa503582315f23f187a019f026c5fce59b3f3d8
DIFF:
https://github.com/llvm/llvm-project/commit/3fa503582315f23f187a019f026c5fce59b3f3d8.diff
LOG
Author: David Spickett
Date: 2023-09-21T14:54:51+01:00
New Revision: 7e744460e7ef0c3c54191b4cd0d7e9749d6fc16c
URL:
https://github.com/llvm/llvm-project/commit/7e744460e7ef0c3c54191b4cd0d7e9749d6fc16c
DIFF:
https://github.com/llvm/llvm-project/commit/7e744460e7ef0c3c54191b4cd0d7e9749d6fc16c.diff
Author: David Spickett
Date: 2023-09-21T15:04:15+01:00
New Revision: 2d69bb721386af419824c93fbeb92f79861f1add
URL:
https://github.com/llvm/llvm-project/commit/2d69bb721386af419824c93fbeb92f79861f1add
DIFF:
https://github.com/llvm/llvm-project/commit/2d69bb721386af419824c93fbeb92f79861f1add.diff
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/67124
Prior to this the command would simply crash when run on a running process.
Of the three register commands, "info" was the only one missing these
requirements. On some level it makes sense because you're n
@@ -659,3 +659,16 @@ def test_fs_gs_base(self):
pthread_self_val.GetValueAsUnsigned(0),
"fs_base does not equal to pthread_self() value.",
)
+
+def test_process_must_be_stopped(self):
+"""Check that all register commands error when th
@@ -659,3 +659,16 @@ def test_fs_gs_base(self):
pthread_self_val.GetValueAsUnsigned(0),
"fs_base does not equal to pthread_self() value.",
)
+
+def test_process_must_be_stopped(self):
+"""Check that all register commands error when th
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/67124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/67124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/67124
>From 90d4354a0305b9a88fee8e25292ecc3dcec5723d Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 22 Sep 2023 12:26:24 +
Subject: [PATCH 1/2] [lldb] Require paused process and frame for "register
@@ -659,3 +659,16 @@ def test_fs_gs_base(self):
pthread_self_val.GetValueAsUnsigned(0),
"fs_base does not equal to pthread_self() value.",
)
+
+def test_process_must_be_stopped(self):
+"""Check that all register commands error when th
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/67124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/67124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Thanks for the explanation. Now I understand what I'm seeing is the expected
behaviour, and async mode is the expected way to achieve what the test needs.
https://github.com/llvm/llvm-project/pull/67124
___
lldb-commits mailing li
DavidSpickett wrote:
This change has caused a failing test on Linux:
https://lab.llvm.org/buildbot/#/builders/68/builds/69157
That's not the first build, because the bot was red for ages beforehand and I'm
not going to check them all. I've bisected it on arm64 instead to confirm it
and get a
@@ -9,43 +9,27 @@
#include "gtest/gtest.h"
#include "Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h"
-#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h"
-#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h"
#include "Plugins/Script
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Thanks! Fixed the x86 bot and I confirmed it locally.
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Can this code be hit when using an x86 core file? Then you could write a shell
test thatis `UNSUPPORTED: x86-registered-target` (whatever the proper syntax
is) and assert that it does not crash.
It won't get run on the build bots, they enable all targets, but it's nice to
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/82670
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-02-26T10:55:31Z
New Revision: 73f11f9579a3206608ad9a07b5793ba451676087
URL:
https://github.com/llvm/llvm-project/commit/73f11f9579a3206608ad9a07b5793ba451676087
DIFF:
https://github.com/llvm/llvm-project/commit/73f11f9579a3206608ad9a07b5793ba451676087.diff
LOG
Author: David Spickett
Date: 2024-02-26T11:17:04Z
New Revision: d0b1fec9e1510d01dad2c9c429573eaa75f0963c
URL:
https://github.com/llvm/llvm-project/commit/d0b1fec9e1510d01dad2c9c429573eaa75f0963c
DIFF:
https://github.com/llvm/llvm-project/commit/d0b1fec9e1510d01dad2c9c429573eaa75f0963c.diff
LOG
Author: David Spickett
Date: 2024-02-26T13:54:05Z
New Revision: 285bff39fd283b3a9a27c06525111d8d4f474e6e
URL:
https://github.com/llvm/llvm-project/commit/285bff39fd283b3a9a27c06525111d8d4f474e6e
DIFF:
https://github.com/llvm/llvm-project/commit/285bff39fd283b3a9a27c06525111d8d4f474e6e.diff
LOG
Author: David Spickett
Date: 2024-02-26T14:01:54Z
New Revision: 8ce81e5924935436d49e0b4e835fa107531505b5
URL:
https://github.com/llvm/llvm-project/commit/8ce81e5924935436d49e0b4e835fa107531505b5
DIFF:
https://github.com/llvm/llvm-project/commit/8ce81e5924935436d49e0b4e835fa107531505b5.diff
LOG
Author: David Spickett
Date: 2024-02-27T09:34:42Z
New Revision: a1bbba06eabc5ddf533e611d15fddcfd0a8e79db
URL:
https://github.com/llvm/llvm-project/commit/a1bbba06eabc5ddf533e611d15fddcfd0a8e79db
DIFF:
https://github.com/llvm/llvm-project/commit/a1bbba06eabc5ddf533e611d15fddcfd0a8e79db.diff
LOG
@@ -407,6 +407,129 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// Get the current address mask that can be applied to addresses
+ /// before reading from memory.
+ ///
+ /// \param[in] type
+ ///
@@ -407,6 +407,129 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// Get the current address mask that can be applied to addresses
+ /// before reading from memory.
+ ///
+ /// \param[in] type
+ ///
@@ -407,6 +407,129 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// Get the current address mask that can be applied to addresses
+ /// before reading from memory.
+ ///
+ /// \param[in] type
+ ///
@@ -407,6 +407,129 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// Get the current address mask that can be applied to addresses
+ /// before reading from memory.
+ ///
+ /// \param[in] type
+ ///
DavidSpickett wrote:
Test? I remember a file dedicated to completion tests somewhere.
https://github.com/llvm/llvm-project/pull/83203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> This introduces a LLDB_TEST_USE_VENDOR_PACKAGES cmake param that can be
> enabled, and the tests will continue loading that tree.
I get the intent but doing it this way is actually going to be more of an
issue. As changes to our bot config have to go through zorg, a mas
DavidSpickett wrote:
Though maybe you intend this to break builds, that way obscure builders that we
don't know about will still hear about this?
I can understand that angle, in which case do we want to make sure all known
builders have pexpect installed before this commit goes in? I will sort
DavidSpickett wrote:
Also are there known compatible/incompatible versions of pexpect? Is `pip
install pexpect` going to install something with significant API differences to
the vendored copy?
https://github.com/llvm/llvm-project/pull/83191
___
lldb
https://github.com/DavidSpickett approved this pull request.
You need to update the PR description but otherwise LGTM.
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -54,3 +55,16 @@ def test_basic_completion(self):
self.expect_repl("$persistent + 10", substrs=["(long) $2 = 17"])
self.quit()
+
+# PExpect uses many timeouts internally and doesn't play well
+# under ASAN on a loaded machine..
+@skipIfAsan
+@
https://github.com/DavidSpickett approved this pull request.
I'd like to know if there's a good reason for the skip beyond machine load, but
this is fine as is. LGTM.
https://github.com/llvm/llvm-project/pull/83203
___
lldb-commits mailing list
lldb-c
@@ -54,3 +55,16 @@ def test_basic_completion(self):
self.expect_repl("$persistent + 10", substrs=["(long) $2 = 17"])
self.quit()
+
+# PExpect uses many timeouts internally and doesn't play well
+# under ASAN on a loaded machine..
+@skipIfAsan
+@
DavidSpickett wrote:
I admit I was too scared of SWIG to look into these myself, but it always
annoyed me that we were only 2 warnings away from a clean build. Thanks for
fixing this!
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits m
@@ -407,6 +407,118 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -1255,6 +1255,95 @@ lldb::SBFileSpec SBProcess::GetCoreFile() {
return SBFileSpec(core_file);
}
+addr_t SBProcess::GetAddressMask(AddressMaskType type,
+ AddressMaskRange addr_range) {
+ LLDB_INSTRUMENT_VA(this, type, addr_range);
+ addr_
@@ -33,18 +33,26 @@ void AddressableBits::SetHighmemAddressableBits(
m_high_memory_addr_bits = highmem_addressing_bits;
}
+addr_t AddressableBits::AddressableBitToMask(uint32_t addressable_bits) {
+ assert(addressable_bits <= sizeof(addr_t) * 8);
DavidSpick
@@ -407,6 +407,118 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
DavidSpickett wrote:
The way the cmake is written it seems that Py_pexpect_FOUND is set to false the
first time you run cmake. Then you install pexpect and lldb_find_python_module
bails early because Py_pexpect_FOUND is *still* set to false.
If you remove the CMake cache it'll then find pexpec
DavidSpickett wrote:
And a data point, AArch64 and Arm Linux are fine with pexpect-4.9.0. Still
working on getting it installed on the bot containers.
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llv
DavidSpickett wrote:
FYI @labath as the x86 bot owner.
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-02-29T14:22:23Z
New Revision: ec95379df363253ffcbbda21297417e703d5ccca
URL:
https://github.com/llvm/llvm-project/commit/ec95379df363253ffcbbda21297417e703d5ccca
DIFF:
https://github.com/llvm/llvm-project/commit/ec95379df363253ffcbbda21297417e703d5ccca.diff
LOG
DavidSpickett wrote:
> It should perhaps unset the variable first, I'll see if I can implement that.
https://github.com/llvm/llvm-project/commit/ec95379df363253ffcbbda21297417e703d5ccca
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits
Author: David Spickett
Date: 2024-02-29T14:59:51Z
New Revision: 99824cf7967922bdd9ac895c949f330bb8d6b85a
URL:
https://github.com/llvm/llvm-project/commit/99824cf7967922bdd9ac895c949f330bb8d6b85a
DIFF:
https://github.com/llvm/llvm-project/commit/99824cf7967922bdd9ac895c949f330bb8d6b85a.diff
LOG
DavidSpickett wrote:
Arm and AArch64 bots now have pexpect 4.9.0 installed.
For Linaro's bots at least, we would be ok with you flipping
`LLDB_TEST_USE_VENDOR_PACKAGES` to `OFF` as the next step. This saves us
getting a change through zorg and should "just work" now.
https://github.com/llvm/l
Author: David Spickett
Date: 2024-03-01T09:47:17Z
New Revision: ec8df555702d85511290742388d28016b69468de
URL:
https://github.com/llvm/llvm-project/commit/ec8df555702d85511290742388d28016b69468de
DIFF:
https://github.com/llvm/llvm-project/commit/ec8df555702d85511290742388d28016b69468de.diff
LOG
DavidSpickett wrote:
Done:
https://github.com/llvm/llvm-project/commit/ec8df555702d85511290742388d28016b69468de
/
https://github.com/llvm/llvm-zorg/commit/e08c692f75a922ee820ac8722f5033255913c195
https://github.com/llvm/llvm-project/pull/83191
___
l
DavidSpickett wrote:
> is about how TestAddressMasks.py assumes all Fix*Address implementations
> will handle a low and high memory address mask. The test currently assumes
> they do
I'm not sure it makes much difference unless handling low/high produces a large
amount of boilerplate in ever
@@ -0,0 +1,130 @@
+"""Test Python APIs for setting, getting, and using address masks."""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class AddressMasksTestCase(TestBase):
+N
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/84022
Fixes #48759
As stated on the issue this was fixed by a change in FreeBSD 13, and I've
confirmed that it passes on 14 as well.
>From e07cfd18f760b08fb049d556f5115480fb25322d Mon Sep 17 00:00:00 2001
From:
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/84024
vectorcall only works on x86
https://clang.llvm.org/docs/AttributeReference.html#vectorcall so elsewhere it
fails to compile. Which is expected on AArch64 for example so is treated as a
pass.
>From d86d1
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/84024
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/84026
Fixes #48758
These are now passing on AArch64 FreeBSD 14.
>From 746413849693e1e4e6d667fc136d90bc97486d82 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 5 Mar 2024 15:06:49 +
Subject: [PATCH]
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/84032
Since https://reviews.freebsd.org/D38983, spsr (aka cpsr) is stored as an 8
byte value. However in lldb's structures it is a 32 bit value still.
The version number comes from
https://cgit.freebsd.org/src/c
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/84032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
This may also imply there is work to be done to make lldb show the upper 32
bits, but I'll leave that to the FreeBSD experts to decide.
https://github.com/llvm/llvm-project/pull/84032
___
lldb-commits mailing list
lldb-commits@lis
https://github.com/DavidSpickett approved this pull request.
Still not sure this is the ideal API but we can't know that until someone (aka
you :) ) has used it for a bit, so let's get this in.
https://github.com/llvm/llvm-project/pull/83663
___
lldb
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/83663
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/84147
While adding register fields I realised that the AUXV values for Linux and
FreeBSD disagree here.
So I've added a FreeBSD specific HWCAP2 value that I can use from FreeBSD
specific code.
The alternative
DavidSpickett wrote:
Some notes:
1. This looks odd in isolation but I need to correct this to enable register
fields on FreeBSD, which will be the next PR.
2. clang-format is going to complain about the enum, I will fix push a commit
to fix that after this one, so that this commit stays readabl
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/84147
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/84147
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -39,6 +43,11 @@ class AuxVector {
AUXV_AT_EUID = 12, ///< Effective UID.
AUXV_AT_GID = 13, ///< GID.
AUXV_AT_EGID = 14, ///< Effective GID.
+
+// At this point Linux and FreeBSD diverge and many of the following values
+// are Linux specific.
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/84147
>From a251b494614a0700f424c2bedebcabd2e053a653 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 6 Mar 2024 09:08:25 +
Subject: [PATCH 1/2] [lldb][FreeBSD] Add FreeBSD specific AT_HWCAP2 value
W
DavidSpickett wrote:
We could have ABI plugins limit the mask to the known maximum address size, or
set all the upper bits to 1. Though I think `0...0` is less
confusing. But it's only fixing what you might call a visual issue, the mask
will have upper 32 bits preserved, but at runtime no addr
Author: David Spickett
Date: 2024-03-07T14:54:30Z
New Revision: 03588a27261f7ebea15af49268d2ec901fe1979e
URL:
https://github.com/llvm/llvm-project/commit/03588a27261f7ebea15af49268d2ec901fe1979e
DIFF:
https://github.com/llvm/llvm-project/commit/03588a27261f7ebea15af49268d2ec901fe1979e.diff
LOG
Author: David Spickett
Date: 2024-03-08T10:43:17Z
New Revision: 0f8cb6818d788c34d70d586f701469a5adabfce1
URL:
https://github.com/llvm/llvm-project/commit/0f8cb6818d788c34d70d586f701469a5adabfce1
DIFF:
https://github.com/llvm/llvm-project/commit/0f8cb6818d788c34d70d586f701469a5adabfce1.diff
LOG
Author: David Spickett
Date: 2024-03-08T11:33:17Z
New Revision: 235332150d52d11b340a10be1bb88432d2cf4179
URL:
https://github.com/llvm/llvm-project/commit/235332150d52d11b340a10be1bb88432d2cf4179
DIFF:
https://github.com/llvm/llvm-project/commit/235332150d52d11b340a10be1bb88432d2cf4179.diff
LOG
Author: David Spickett
Date: 2024-03-08T17:15:11Z
New Revision: 73b2d672c1c8318cd16a02812c39ae3997b9dbcd
URL:
https://github.com/llvm/llvm-project/commit/73b2d672c1c8318cd16a02812c39ae3997b9dbcd
DIFF:
https://github.com/llvm/llvm-project/commit/73b2d672c1c8318cd16a02812c39ae3997b9dbcd.diff
LOG
@@ -48,20 +48,38 @@ static Status EnsureFDFlags(int fd, int flags) {
return error;
}
+static Status CanTrace() {
+ int proc_debug, ret;
+ size_t len = sizeof(proc_debug);
+ ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", &proc_debug,
+ &
Author: David Spickett
Date: 2024-03-11T11:41:56Z
New Revision: e77f5fe889909df3508fd929f2636a0ac211877a
URL:
https://github.com/llvm/llvm-project/commit/e77f5fe889909df3508fd929f2636a0ac211877a
DIFF:
https://github.com/llvm/llvm-project/commit/e77f5fe889909df3508fd929f2636a0ac211877a.diff
LOG
DavidSpickett wrote:
The spirit of the test is fine but I think we can avoid adding another core
file.
As this plugin seems related to backtrace perhaps the test should at least run
`bt` and check for the first line of the output. Which means we can justify
putting the test in `lldb/test/Shel
@@ -0,0 +1,10 @@
+# UNSUPPORTED: x86
DavidSpickett wrote:
This should be:
```
UNSUPPORTED: target-x86_64
```
Which I'm pretty sure is lldb's equivalent of `x86-registered-target`. Which is
whether the lldb has that target built into it, vs. whether it's running
@@ -0,0 +1,10 @@
+# UNSUPPORTED: x86
DavidSpickett wrote:
Actually, I'm wrong.
We get the configured targets from llvm-config and I think that adds "X86" as a
feature, target- is about what the default triple of llvm is.
https://github.com/llvm/llvm-project/pu
DavidSpickett wrote:
This failed on our AArch64 bot but due to zombie processes hanging about from
other runs, not anything to do with this change specifically.
https://github.com/llvm/llvm-project/pull/84154
___
lldb-commits mailing list
lldb-commits
@@ -914,6 +914,25 @@ def checkForkVForkSupport():
configuration.skip_categories.append("fork")
+def checkPexpectSupport():
+from lldbsuite.test import lldbplatformutil
+
+platform = lldbplatformutil.getPlatform()
+
+# llvm.org/pr22274: need a pexpect repla
@@ -914,6 +914,25 @@ def checkForkVForkSupport():
configuration.skip_categories.append("fork")
+def checkPexpectSupport():
+from lldbsuite.test import lldbplatformutil
+
+platform = lldbplatformutil.getPlatform()
+
+# llvm.org/pr22274: need a pexpect repla
@@ -0,0 +1,49 @@
+"""Test that lldb on Darwin ignores metadata in the top byte of addresses."""
DavidSpickett wrote:
addresses in core files.
Also the filename should have core somewhere in it.
https://github.com/llvm/llvm-project/pull/84998
___
901 - 1000 of 2803 matches
Mail list logo
