https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/123918
>From c89a16ab405d4aad7bf0a59afb433dd5ecd1a402 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 20 Aug 2024 16:06:34 +0100
Subject: [PATCH 1/4] [lldb][AArch64] Fix expression evaluation with Guarde
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/123918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/123918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -575,6 +575,10 @@ Changes to LLDB
24 int main() {
Likely cause: f->b->d accessed 0x4
```
+* LLDB now supports hardware watchpoints for AArch64 Windows targets. Windows
+ does not provide API to query the number of supported hardware watchpoints.
+ Therefore curr
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance,
}
case DWORD(STATUS_BREAKPOINT):
case STATUS_WX86_BREAKPOINT:
DavidSpickett wrote:
W = something related to WOW64 here right, not W for watchpoint?
And we get this even on a
@@ -110,8 +110,8 @@
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
NativeRegisterContextWindows_x86_64::NativeRegisterContextWindows_x86_64(
const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-: NativeRegisterContextWindows(native
Author: David Spickett
Date: 2025-01-27T13:27:31Z
New Revision: e9e06bea8661ddd474557a0db2cdc8770a55b66f
URL:
https://github.com/llvm/llvm-project/commit/e9e06bea8661ddd474557a0db2cdc8770a55b66f
DIFF:
https://github.com/llvm/llvm-project/commit/e9e06bea8661ddd474557a0db2cdc8770a55b66f.diff
LOG
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/124293
>From d2c221b9b8cfeb8d9d902947db38c716e7a09804 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 27 Aug 2024 11:45:52 +0100
Subject: [PATCH] [lldb][AArch64] Add Guarded Control Stack support for Lin
DavidSpickett wrote:
Rebased, PR is just new code now.
https://github.com/llvm/llvm-project/pull/124293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Please update the PR description to reflect what the current code does, or if
you want to leave the notes there, move them into an obvious section that you
can cut out if/when this gets merged.
https://github.com/llvm/llvm-project/pull/108072
__
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance,
}
case DWORD(STATUS_BREAKPOINT):
case STATUS_WX86_BREAKPOINT:
-if (FindSoftwareBreakpoint(record.GetExceptionAddress())) {
- LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance,
}
case DWORD(STATUS_BREAKPOINT):
case STATUS_WX86_BREAKPOINT:
-if (FindSoftwareBreakpoint(record.GetExceptionAddress())) {
- LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/123918
>From c89a16ab405d4aad7bf0a59afb433dd5ecd1a402 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 20 Aug 2024 16:06:34 +0100
Subject: [PATCH 1/3] [lldb][AArch64] Fix expression evaluation with Guarde
DavidSpickett wrote:
1st commit(s) is https://github.com/llvm/llvm-project/pull/124293, last commit
is the new code.
https://github.com/llvm/llvm-project/pull/124295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/124295
>From d2c221b9b8cfeb8d9d902947db38c716e7a09804 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 27 Aug 2024 11:45:52 +0100
Subject: [PATCH 1/2] [lldb][AArch64] Add Guarded Control Stack support for
https://github.com/DavidSpickett approved this pull request.
I suppose there might be some platform out there we don't know about that this
breaks, but what better way to find out than changing it :)
LGTM.
https://github.com/llvm/llvm-project/pull/124522
___
DavidSpickett wrote:
> which doesn't send the alternate name information
I don't think we do either. Unless it's in the register info structs maybe it
is.
The way to find out is to write the tests and if they pass without any changes
to LLDB - somehow it does work.
> (in particular, there a
DavidSpickett wrote:
A test for this would be finding the tests that check basic reads of registers,
and adding reads with the new names. There should be one for core files and one
for live processes.
https://github.com/llvm/llvm-project/pull/124475
DavidSpickett wrote:
I will deal with the formatting in a follow up after this lands.
https://github.com/llvm/llvm-project/pull/124735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/124735
**Do not merge before the 20 branch is taken!**
As decided on
https://discourse.llvm.org/t/rfc-lets-document-and-enforce-a-minimum-python-version-for-lldb/82731.
LLDB 20 recommended >= 3.8 but did not re
@@ -447,6 +447,9 @@ Changes to the LLVM tools
Changes to LLDB
-
+* When building LLDB with Python support, the minimum version of Python is now
+ 3.8.
+
DavidSpickett wrote:
This looks weird now but when I rebase after the bra
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/124295
>From de84dc94ee6e5f15450f9e2729bfdbafd212b7f0 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 27 Aug 2024 14:35:28 +0100
Subject: [PATCH] [lldb][AArch64] Add register fields for Guarded Control S
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/124293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/117860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/124295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM, thanks.
My understanding of this is it generates `-m64` and `-m32` flags for
architectures that need it, and RISC-V is not one of those.
(I have heard of toolchains with both 32 and 64 bit but they use a different
triple for e
Author: David Spickett
Date: 2025-01-28T13:50:58Z
New Revision: 0cf6714279d4146ee5d6a5e34195d6fae56ed475
URL:
https://github.com/llvm/llvm-project/commit/0cf6714279d4146ee5d6a5e34195d6fae56ed475
DIFF:
https://github.com/llvm/llvm-project/commit/0cf6714279d4146ee5d6a5e34195d6fae56ed475.diff
LOG
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/123720
The Guarded Control Stack extension implements a shadow stack and the Linux
kernel provides access to 3 registers for it via ptrace.
struct user_gcs {
__u64 features_enabled;
__u64 feature
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/123945
>From ecb1b90e109df650ef1b50cc3d07b56fd302e274 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 22 Jan 2025 10:52:16 +
Subject: [PATCH 1/5] Reland "[lldb] Implement basic support for
reverse-c
DavidSpickett wrote:
@labath you can append to the PR description if you want to explain the bit I
committed from you about the x packet.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
@@ -218,7 +218,12 @@ class GDBRemoteCommunicationClient : public
GDBRemoteClientBase {
bool GetpPacketSupported(lldb::tid_t tid);
- bool GetxPacketSupported();
+ enum class xPacketState {
+Unimplemented,
+Prefixed, // Successful responses start with a 'b' charact
@@ -0,0 +1,36 @@
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase
+
+
+class TestReadMemory(GDBRemoteTestBase):
+def test_x_with
@@ -0,0 +1,36 @@
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase
+
+
+class TestReadMemory(GDBRemoteTestBase):
+def test_x_with
@@ -0,0 +1,36 @@
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase
+
+
+class TestReadMemory(GDBRemoteTestBase):
+def test_x_with
DavidSpickett wrote:
> I have created two tests.
Which is great, but we need live processes too and I found those, they are in
`lldb/test/Shell/Register/` for example
`lldb/test/Shell/Register/aarch64-gp-read.test`. For some reason we don't check
all registers there just parameter registers,
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/122694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/122694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/122694
There's a lot of fiddly bits to get right here, so I've added a more complete
example and explained why you might choose one method over another.
I thought about adding this to the qemu testing page, as t
DavidSpickett wrote:
I do this using 1 build that is a host build, with no options changed from the
usual recipe. Then a second cross compilation build done like
https://lldb.llvm.org/resources/build.html#example-1-cross-compiling-for-linux-arm64-on-ubuntu-host
in which I just build `ninja lldb
DavidSpickett wrote:
> The latter bits could be added to the qemu testing page, I'll see if any of
> it overlaps.
https://github.com/llvm/llvm-project/pull/122694
https://github.com/llvm/llvm-project/pull/117861
___
lldb-commits mailing list
lldb-com
DavidSpickett wrote:
Hi @AlexeyMerzlyakov I am looking at commits that warrant a release note for
LLDB 20, and I think this is one of them. If you want to do that yourself you
can send a PR adding a bullet point to
https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#change
DavidSpickett wrote:
Hi @dlav-sc I am looking at commits that warrant a release note for LLDB 20,
and I think this is one of them. If you want to do that yourself you can send a
PR adding a bullet point to
https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#changes-to-lld
DavidSpickett wrote:
Hi @Jlalond I am looking at commits that warrant a release note for LLDB 20,
and I think this and the rest of your Minidump changes might qualify. If you
want to do that yourself you can send a PR adding a bullet point to
https://github.com/llvm/llvm-project/blob/main/llv
DavidSpickett wrote:
Hi @slydiman, I am looking at commits that warrant a release note for LLDB 20,
and I think your work on lldb-server's port map might fit the bill. If you want
to do that yourself you can send a PR adding a bullet point to
https://github.com/llvm/llvm-project/blob/main/llvm
DavidSpickett wrote:
Also because shrinkwrap defaults to putting this all in Docker, it can cause
VPNs to do strange things. If so, there is an option to in shrinkwrap not use
the docker "runtime" as it calls it, or disable the VPN temporarily.
https://github.com/llvm/llvm-project/pull/117861
@@ -0,0 +1,66 @@
+"""
+Test lldb's ability to read and write the LoongArch LASX registers.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class LoongArch64LinuxRegisters(TestBase):
+
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/120664
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/120664
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
The tests are excellent, thanks!
This all LGTM, assuming @SixWeining agrees.
https://github.com/llvm/llvm-project/pull/120664
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
DavidSpickett wrote:
Thanks! -
https://github.com/llvm/llvm-project/commit/cfd7e024c6a97b0083f2e25a9d03d7dd516a0452#diff-9a29352a0c8c114f51b142b44cb1d5d6688787df1f78f3785ada73e1355a7379R463
https://github.com/llvm/llvm-project/pull/104238
___
lldb-com
DavidSpickett wrote:
>From the Discourse thread:
> I also went through all the commits since the llvmorg-20-init tag until
> today, and noted anything I thought might warrant a release note.
If there was unfinished work in 19 that is now finished by later PRs that's
fair to include too.
> I a
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/117861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/122917
This will be sent by Arm's Guarded Control Stack extension when an invalid
return is executed.
The signal does have an address we could show, but it's the PC at which the
fault occured. The debugger has
@@ -50,5 +63,7 @@ int main() {
}
// By now we should have one memory region where the GCS is stored.
- return 0; // Set break point at this line.
+ gcs_signal(); // Set break point at this line.
DavidSpickett wrote:
The previously added `test_gcs_region
DavidSpickett wrote:
https://github.com/llvm/llvm-project/commit/e952728f88c8b0e0208dc991dd9a04fe8c211cfb
relanded this.
https://github.com/llvm/llvm-project/pull/114973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
@@ -0,0 +1,154 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,154 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,154 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/120740
>From 65de95430fce9315a5d34aec589796818d5cd06f Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 20 Dec 2024 14:38:05 +
Subject: [PATCH 1/3] [lldb][Docs] Add equivalent of GDB's "skip" to comman
@@ -235,6 +235,23 @@ Do a source level single step in the currently selected
thread
(lldb) step
(lldb) s
+Ignore a function when doing a source level single step in
+~~
+
+.. code-block:: shell
+
+ (gdb) skip abc
+
@@ -235,6 +235,40 @@ Do a source level single step in the currently selected
thread
(lldb) step
(lldb) s
+Ignore a function when doing a source level single step in
+~~
+
+.. code-block:: shell
+
+ (gdb) skip abc
+
@@ -1226,7 +1226,7 @@ bool lldb_private::formatters::ObjCSELSummaryProvider(
time_t lldb_private::formatters::GetOSXEpoch() {
static time_t epoch = 0;
if (!epoch) {
-#ifndef _WIN32
+#if !defined(_WIN32) && !defined(_AIX)
DavidSpickett wrote:
This would jus
@@ -715,7 +715,7 @@ ConnectionFileDescriptor::ConnectFD(llvm::StringRef s,
ConnectionStatus ConnectionFileDescriptor::ConnectFile(
llvm::StringRef s, socket_id_callback_type socket_id_callback,
Status *error_ptr) {
-#if LLDB_ENABLE_POSIX
+#if LLDB_ENABLE_POSIX && !defin
@@ -16,6 +16,9 @@
#include
#include
#include
+#ifdef _AIX
+#include
DavidSpickett wrote:
First time I've heard that there is string.h and strings.h. What parts of
strings.h were needed here?
https://github.com/llvm/llvm-project/pull/120979
__
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/122933
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-01-09T10:54:52Z
New Revision: d3f1b864ae1b2c3fce343863d494a40fc231ca16
URL:
https://github.com/llvm/llvm-project/commit/d3f1b864ae1b2c3fce343863d494a40fc231ca16
DIFF:
https://github.com/llvm/llvm-project/commit/d3f1b864ae1b2c3fce343863d494a40fc231ca16.diff
LOG
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/117861
>From ecac70b8d7b00e729b3203c6d5e6aff827775467 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 19 Aug 2024 15:55:45 +0100
Subject: [PATCH 1/2] [lldb][Linux] Mark memory regions used for shadow sta
@@ -164,12 +164,17 @@ void lldb_private::ParseLinuxSMapRegions(llvm::StringRef
linux_smap,
if (!name.contains(' ')) {
if (region) {
if (name == "VmFlags") {
- if (value.contains("mt"))
-region->SetMemoryTagged(MemoryRegionInfo::eYes);
-
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/117861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -276,20 +278,35 @@ INSTANTIATE_TEST_SUITE_P(
"MMUPageSize: 4 kB\n",
MemoryRegionInfos{
MemoryRegionInfo(
-make_range(0x, 0x),
-MemoryRegionInfo::eYes, MemoryRegionInfo::eYes,
M
@@ -2796,11 +2796,17 @@
GDBRemoteCommunicationServerLLGS::Handle_qMemoryRegionInfo(
// Flags
MemoryRegionInfo::OptionalBool memory_tagged =
region_info.GetMemoryTagged();
-if (memory_tagged != MemoryRegionInfo::eDontKnow) {
+MemoryRegionInfo::OptionalBo
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/117861
>From 17f7ee60f32194aa60b9aed3fd92618cd31b020a Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 19 Aug 2024 15:55:45 +0100
Subject: [PATCH 1/2] [lldb][Linux] Mark memory regions used for shadow sta
@@ -101,12 +105,13 @@ class MemoryRegionInfo {
bool operator==(const MemoryRegionInfo &rhs) const {
return m_range == rhs.m_range && m_read == rhs.m_read &&
m_write == rhs.m_write && m_execute == rhs.m_execute &&
- m_shared == rhs.m_shared &&
-
@@ -428,7 +428,7 @@ class Function : public UserID, public SymbolContextScope {
/// The section offset based address for this function.
Function(CompileUnit *comp_unit, lldb::user_id_t func_uid,
lldb::user_id_t func_type_uid, const Mangled &mangled,
-
@@ -3,17 +3,30 @@
# int baz();
# int bar() { return 47; }
# int foo(int flag) { return flag ? bar() : baz(); }
-# The function bar has been placed "in the middle" of foo.
+# The function bar has been placed "in the middle" of foo, and the function
+# entry point is deliberately
@@ -428,7 +428,7 @@ class Function : public UserID, public SymbolContextScope {
/// The section offset based address for this function.
Function(CompileUnit *comp_unit, lldb::user_id_t func_uid,
lldb::user_id_t func_type_uid, const Mangled &mangled,
-
DavidSpickett wrote:
In future, please remember to remove anything from the commit message that was
purely for the review process, or generally no longer applies to the code being
landed. GitHub gives you a chance to do this just before the PR is merged.
In this case it just meant I got an ext
DavidSpickett wrote:
I will test on AArch64 Linux today.
https://github.com/llvm/llvm-project/pull/112079
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Tests passed on Arm and AArch64.
> This commit only adds support for the SBProcess::ReverseContinue() API. A
> user-accessible command for this will follow in a later commit.
I think this means it's not worth adding a release note just yet? Better to
wait until you can sa
DavidSpickett wrote:
> This string comes from the debug/lldb-server, and MacOS has a... complicated
> compatibility story for the debugserver.
It's not to the same level, but doesn't everyone else have this issue,
potentially? Though the consequence is just that if my lldb-server is old and
DavidSpickett wrote:
We could make MacOS adopt the Linux format, right? Not that that changes much
but just wondering if there's any reason you chose that direction.
I see you changed the MTE core file case, there is a live process test case
too, a search for `fault address:` should find it an
@@ -10,7 +10,7 @@
class TestDiagnoseDereferenceFunctionReturn(TestBase):
-@skipUnlessDarwin
+@expectedFailureAll(oslist=no_match(lldbplatformutil.getDarwinOSTriples()))
DavidSpickett wrote:
This test previously could not run anywhere but Darwin but n
https://github.com/DavidSpickett approved this pull request.
I thought maybe you could call it GetEntryPoint, but I don't think it helps
much. The answer to which address it is is one "go to definition" away, and
your point is that the obvious guess is that it's the entry point anyway.
LGTM.
DavidSpickett wrote:
> have you posted rest of the patches for GCS other than this one?
https://github.com/DavidSpickett/llvm-project/commits/gcs-work/ has all the
patches but I was avoiding doing stacked PRs. I can figure that out if it'd
help you review.
https://github.com/llvm/llvm-project
@@ -101,12 +105,13 @@ class MemoryRegionInfo {
bool operator==(const MemoryRegionInfo &rhs) const {
return m_range == rhs.m_range && m_read == rhs.m_read &&
m_write == rhs.m_write && m_execute == rhs.m_execute &&
- m_shared == rhs.m_shared &&
-
@@ -730,9 +730,21 @@ ConnectionStatus ConnectionFileDescriptor::ConnectFile(
struct termios options;
::tcgetattr(fd, &options);
-// Set port speed to maximum
+// Set port speed to the available maximum
+#ifdef B115200
::cfsetospeed(&options, B115200);
@@ -14,6 +14,7 @@
#include
#include
+#include
DavidSpickett wrote:
this can go now, right? Now that bzero is not being used.
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-co
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/122041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/122041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -14,6 +14,7 @@
#include
#include
+#include
DavidSpickett wrote:
Understood, leave it in then.
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
@@ -164,12 +164,17 @@ void lldb_private::ParseLinuxSMapRegions(llvm::StringRef
linux_smap,
if (!name.contains(' ')) {
if (region) {
if (name == "VmFlags") {
- if (value.contains("mt"))
-region->SetMemoryTagged(MemoryRegionInfo::eYes);
-
@@ -164,12 +164,17 @@ void lldb_private::ParseLinuxSMapRegions(llvm::StringRef
linux_smap,
if (!name.contains(' ')) {
if (region) {
if (name == "VmFlags") {
- if (value.contains("mt"))
-region->SetMemoryTagged(MemoryRegionInfo::eYes);
-
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/117861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/122301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2796,11 +2796,17 @@
GDBRemoteCommunicationServerLLGS::Handle_qMemoryRegionInfo(
// Flags
MemoryRegionInfo::OptionalBool memory_tagged =
region_info.GetMemoryTagged();
-if (memory_tagged != MemoryRegionInfo::eDontKnow) {
+MemoryRegionInfo::OptionalBo
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/117860
>From 4838ed0ef8a62041981e61a8d405251bb32c147d Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 27 Aug 2024 15:22:10 +0100
Subject: [PATCH 1/3] [lldb][Docs] Add Guarded Control Stack to AArch64 Lin
@@ -2796,11 +2796,17 @@
GDBRemoteCommunicationServerLLGS::Handle_qMemoryRegionInfo(
// Flags
MemoryRegionInfo::OptionalBool memory_tagged =
region_info.GetMemoryTagged();
-if (memory_tagged != MemoryRegionInfo::eDontKnow) {
+MemoryRegionInfo::OptionalBo
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/126925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
Correct according to
https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005fbuiltin.html, thanks for
the fix.
https://github.com/llvm/llvm-project/pull/127091
___
lldb-commits mailing list
ll
@@ -185,6 +185,9 @@ def setUpServerLogging(self, is_llgs):
]
def get_next_port(self):
+available_ports = self.getPlatformAvailablePorts()
+if available_ports:
DavidSpickett wrote:
We require Python >= 3.8
(https://lldb.llvm.or
2401 - 2500 of 2869 matches
Mail list logo
