DavidSpickett wrote:
> FYI, it wanted to link the X86's libxml2 with RISCV which didn't work.
This is known, from the cross building doc:
```
If you find that CMake is finding a version of an optional dependency that for
whatever reason doesn’t work, consider simply disabling it if you don’t kn
DavidSpickett wrote:
https://github.com/llvm/llvm-project/commit/9d83790d170cc0a06179514e2ab739f7ecafb78c
https://github.com/llvm/llvm-project/commit/52db30ec4154b0ef21db546ed9b5a9bfe47859cd
https://github.com/llvm/llvm-project/pull/125143
___
lldb-com
Author: David Spickett
Date: 2025-02-07T10:29:35Z
New Revision: 52db30ec4154b0ef21db546ed9b5a9bfe47859cd
URL:
https://github.com/llvm/llvm-project/commit/52db30ec4154b0ef21db546ed9b5a9bfe47859cd
DIFF:
https://github.com/llvm/llvm-project/commit/52db30ec4154b0ef21db546ed9b5a9bfe47859cd.diff
LOG
DavidSpickett wrote:
I will push something shortly for this.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-02-07T10:03:23Z
New Revision: 9d83790d170cc0a06179514e2ab739f7ecafb78c
URL:
https://github.com/llvm/llvm-project/commit/9d83790d170cc0a06179514e2ab739f7ecafb78c
DIFF:
https://github.com/llvm/llvm-project/commit/9d83790d170cc0a06179514e2ab739f7ecafb78c.diff
LOG
@@ -0,0 +1,3 @@
+# RUN: %clang_host -g -O0 %S/Inputs/main.c -o %t.out
+# RUN: %lldb -b -o 'breakpoint set -a "main +26"' %t.out | FileCheck %s
--check-prefix CHECK
DavidSpickett wrote:
You should test a few versions in case the whitespace was ever made mand
DavidSpickett wrote:
> You can check the CI logs for the exact command line it uses and replicate it
> locally.
Should be towards the start of the log, search for `cmake ` to find the command.
https://github.com/llvm/llvm-project/pull/126243
___
lldb
DavidSpickett wrote:
> As for the cases mentioned, when I tried compile all projects (compile with
> -DLLVM_ENABLE_PROJECTS=all), I did encounter such cases when compiling and
> I've fixed them all.
> Now all projects can be successfully built, so I think it should be fine?
Just to explain why
@@ -6,15 +6,22 @@
# CHECK: Found 1 function(s).
# CHECK: foo: [input.o[0x0-0xe), input.o[0x14-0x1c)]
-# CHECK-NEXT: input.o[0x0]: cmpl $0x0, %edi
-# CHECK-NEXT: input.o[0x3]: je 0x14
-# CHECK-NEXT: input.o[0x5]: jmp0x7
-# CHECK-NEXT: input.o[0x7]: callq 0xe
-# CHECK
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/126505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/124735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/124735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-01-29T09:59:34Z
New Revision: db567eaca07133a374991153635a119d9eec066b
URL:
https://github.com/llvm/llvm-project/commit/db567eaca07133a374991153635a119d9eec066b
DIFF:
https://github.com/llvm/llvm-project/commit/db567eaca07133a374991153635a119d9eec066b.diff
LOG
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/124735
>From 08c47efd81fba63f252467bf7af48549ba4b62d5 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 28 Jan 2025 10:58:34 +
Subject: [PATCH] [lldb] Make Python >= 3.8 required for LLDB 21
As decide
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/124735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
The easy one to fix is:
```
Traceback (most recent call last):
File
"C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\reverse-execution\TestReverseContinueNotSupported.py",
line 25, in test_reverse_continue_not_supported
self
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/125091
Reverts llvm/llvm-project#123945
Has failed on the Windows on Arm buildbot:
https://lab.llvm.org/buildbot/#/builders/141/builds/5865
```
Unresolved Tests (2):
lldb-api ::
functiona
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/125091
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Arm and AArch64 Linux were fine (aside from a flaky test on the latter).
Windows on Arm is complaining, I'm investigating.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -575,6 +575,10 @@ Changes to LLDB
24 int main() {
Likely cause: f->b->d accessed 0x4
```
+* LLDB now supports hardware watchpoints for AArch64 Windows targets. Windows
+ does not provide API to query the number of supported hardware watchpoints.
+ Therefore curr
DavidSpickett wrote:
Also thanks for tackling this, I know I said once (possibly twice) that I'd do
it but kept getting distracted. I know you put a bunch of research time into
this too.
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commi
https://github.com/DavidSpickett approved this pull request.
We're hitting limitations in Windows itself, and 1 watchpoint is more useful
than zero, so this LGTM.
To preempt a potential discussion: I think this should not be backported to 20.
Unless you've got a very good reason for it. We don
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
My inbox is ready :)
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> In most cases user sets breakpoint on main and then set watchpoints which
> masks this problem altogether.
Agreed, this isn't ideal but it is an improvement from the current features.
https://github.com/llvm/llvm-project/pull/108072
__
@@ -0,0 +1,36 @@
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase
+
+
+class TestReadMemory(GDBRemoteTestBase):
+def test_x_with
https://github.com/DavidSpickett approved this pull request.
LGTM, thanks for handling this.
Maybe the final say goes to @rocallahan since `rr` is the origin of the issue?
We have to wait on GDB for a bit anyway I expect.
https://github.com/llvm/llvm-project/pull/124733
___
DavidSpickett wrote:
I want to be 100% sure of the status of this issue:
> Initial Stop Behavior: Hardware breakpoints or watchpoints set on the initial
> stop do not trigger, even though they are correctly written to the Windows
> context. They only trigger if set after the main program has s
DavidSpickett wrote:
Windows on Arm passed, Arm and AArch64 Linux passed. No complaints so far.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
DavidSpickett wrote:
GCS is not implemented in QEMU yet -
https://linaro.atlassian.net/browse/QEMU-517. I used Arm's Foundation Model via
shrinkwrap:
```
$ shrinkwrap build --overlay=arch/v9.5.yaml ns-edk2.yaml
$ shrinkwrap run
--rtvar=KERNEL=/home/davspi01/work/open_source/linux.build/arm64/a
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/117860
>From 4838ed0ef8a62041981e61a8d405251bb32c147d Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 27 Aug 2024 15:22:10 +0100
Subject: [PATCH 1/2] [lldb][Docs] Add Guarded Control Stack to AArch64 Lin
@@ -229,3 +229,54 @@ bytes.
`zt0`'s value and whether it is active or not will be saved prior to
expression evaluation and restored afterwards.
+
+## Guarded Control Stack Extension (GCS)
+
+GCS support includes the following new registers:
+
+* `gcs_features_enabled`
+* `gcs_
@@ -229,3 +229,54 @@ bytes.
`zt0`'s value and whether it is active or not will be saved prior to
expression evaluation and restored afterwards.
+
+## Guarded Control Stack Extension (GCS)
+
+GCS support includes the following new registers:
+
+* `gcs_features_enabled`
+* `gcs_
@@ -229,3 +229,54 @@ bytes.
`zt0`'s value and whether it is active or not will be saved prior to
expression evaluation and restored afterwards.
+
+## Guarded Control Stack Extension (GCS)
+
+GCS support includes the following new registers:
+
+* `gcs_features_enabled`
+* `gcs_
@@ -229,3 +229,54 @@ bytes.
`zt0`'s value and whether it is active or not will be saved prior to
expression evaluation and restored afterwards.
+
+## Guarded Control Stack Extension (GCS)
+
+GCS support includes the following new registers:
+
+* `gcs_features_enabled`
+* `gcs_
@@ -229,3 +229,54 @@ bytes.
`zt0`'s value and whether it is active or not will be saved prior to
expression evaluation and restored afterwards.
+
+## Guarded Control Stack Extension (GCS)
+
+GCS support includes the following new registers:
+
+* `gcs_features_enabled`
+* `gcs_
https://github.com/DavidSpickett approved this pull request.
Since you mentioned FreeBSD I tried this on AArch64 FreeBSD and it doesn't
cause any test failures (beyond what was already failing on `main`).
This all LGTM.
https://github.com/llvm/llvm-project/pull/118043
_
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/119573
gmake is GNU make where make is not GNU compatible. This leads to a lot of
tests failing to build
with errors like:
```
make: "<...>/Makefile.rules" line 569: Invalid line type
```
See https://cmake.org/c
DavidSpickett wrote:
We could say we require a "GNU compatible" make but I didn't want to get into
the weeds of whether Mac's make is technically GNU compatible or just happens
to have all the features we need.
This change makes FreeBSD work out of the box, that's the key goal here.
https://g
@@ -0,0 +1,401 @@
+//===-- NativeRegisterContextDBReg.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/DavidSpickett commented:
This passed all tests. Some remaining cosmetic issues but otherwise looks good.
We could go more into the style issues here but
1. This code was like that before, you just moved it, so it's not actually a
regression.
2. I don't want to get into refact
@@ -0,0 +1,401 @@
+//===-- NativeRegisterContextDBReg.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,90 @@
+//===-- NativeRegisterContextDBReg.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -234,9 +234,9 @@ class NativeRegisterContextLinux_arm64
size_t GetFPMRBufferSize() { return sizeof(m_fpmr_reg); }
- llvm::Error ReadHardwareDebugInfo() override;
+ Status ReadHardwareDebugInfo() override;
DavidSpickett wrote:
@wangleiat can you explai
@@ -180,7 +180,8 @@
NativeRegisterContextLinux_arm64::NativeRegisterContextLinux_arm64(
std::unique_ptr register_info_up)
: NativeRegisterContextRegisterInfo(native_thread,
register_info_up.release()),
- NativeRegisterContex
@@ -312,16 +312,21 @@ struct DNBRegisterValue {
uint64_t uint64;
float float32;
double float64;
-int8_t v_sint8[64];
-int16_t v_sint16[32];
-int32_t v_sint32[16];
-int64_t v_sint64[8];
-uint8_t v_uint8[64];
-uint16_t v_uint16[32];
-uint32
@@ -0,0 +1,111 @@
+/// BUILT with
+///xcrun -sdk macosx.internal clang -mcpu=apple-m4 -g sme.c -o sme
+
+#include
+#include
+#include
+
+void write_sve_regs() {
+ asm volatile("ptrue p0.b\n\t");
+ asm volatile("ptrue p1.h\n\t");
+ asm volatile("ptrue p2.s\n\t");
+ asm
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/118043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -93,6 +93,55 @@ DNBArchMachARM64::SoftwareBreakpointOpcode(nub_size_t
byte_size) {
uint32_t DNBArchMachARM64::GetCPUType() { return CPU_TYPE_ARM64; }
+static std::once_flag g_cpu_has_sme_once;
+bool DNBArchMachARM64::CPUHasSME() {
+ static bool g_has_sme = false;
+ std:
DavidSpickett wrote:
> So, now the problem is that FreeBSD has both, make and gmake, and when we
> pick up make, the tests fail right? Wouldn't it be sufficient to change the
> order?
It will fix the build on FreeBSD where you have `pkg install gmake`, but on a
system without it, it will find
DavidSpickett wrote:
I thought they would have switched to a BSD make but perhaps this is left over.
Ok cool then I just need to check a few --version to see what we can look for.
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits maili
Author: David Spickett
Date: 2024-12-12T10:08:53Z
New Revision: 2fae58e9c7becc376454005da69acb3fa993350e
URL:
https://github.com/llvm/llvm-project/commit/2fae58e9c7becc376454005da69acb3fa993350e
DIFF:
https://github.com/llvm/llvm-project/commit/2fae58e9c7becc376454005da69acb3fa993350e.diff
LOG
@@ -0,0 +1,111 @@
+/// BUILT with
+///xcrun -sdk macosx.internal clang -mcpu=apple-m4 -g sme.c -o sme
+
+#include
+#include
+#include
+
+void write_sve_regs() {
+ asm volatile("ptrue p0.b\n\t");
+ asm volatile("ptrue p1.h\n\t");
+ asm volatile("ptrue p2.s\n\t");
+ asm
@@ -2842,31 +2850,32 @@ rnb_err_t
RNBRemote::SendStopReplyPacketForThread(nub_thread_t tid) {
if (g_num_reg_entries == 0)
InitializeRegisters();
-if (g_reg_entries != NULL) {
- auto interesting_regset = [](int regset) -> bool {
-#if defined(__arm64__) || de
@@ -2842,31 +2850,32 @@ rnb_err_t
RNBRemote::SendStopReplyPacketForThread(nub_thread_t tid) {
if (g_num_reg_entries == 0)
InitializeRegisters();
-if (g_reg_entries != NULL) {
- auto interesting_regset = [](int regset) -> bool {
-#if defined(__arm64__) || de
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/119573
>From aa3c542bd0f05ea46138b4335cfcbdf7aa19bf16 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 12 Dec 2024 10:42:35 +
Subject: [PATCH] [lldb] Prefer gmake on FreeBSD and NetBSD
System `make`
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I've updated it so that we prefer gmake on the BSDs, but we will use make if we
cannot find gmake. Everywhere else we prefer make instead.
If we can't find a gmake on BSD we will warn but not error.
Which means you can build on a fresh FreeBSD without installing gmake. The
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -139,8 +177,53 @@ FileSpec HostInfoPosix::GetDefaultShell() {
return FileSpec("/bin/sh");
}
+FileSpec HostInfoPosix::GetProgramFileSpec() {
+ static FileSpec g_program_filespec;
+
+ if (!g_program_filespec) {
+char exe_path[PATH_MAX];
+ssize_t len = readlink("/p
@@ -139,8 +177,53 @@ FileSpec HostInfoPosix::GetDefaultShell() {
return FileSpec("/bin/sh");
}
+FileSpec HostInfoPosix::GetProgramFileSpec() {
+ static FileSpec g_program_filespec;
+
+ if (!g_program_filespec) {
+char exe_path[PATH_MAX];
+ssize_t len = readlink("/p
@@ -12,6 +12,29 @@
using namespace lldb_private;
+TEST(RangeVector, SignedBaseType) {
+ using RangeVector = RangeVector;
+ using Entry = RangeVector::Entry;
+
+ RangeVector V;
+ V.Append(10, 5);
+ V.Append(-3, 6);
+ V.Append(-10, 3);
+ V.Sort();
+ EXPECT_THAT(V,
+
https://github.com/DavidSpickett approved this pull request.
Fine assuming no one puts part of a function > 2GB before its entry point.
Seems unlikely given that no one tried to put anything > 4GB after the entry
point either.
LGTM.
https://github.com/llvm/llvm-project/pull/120224
___
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
@labath what do you think?
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -21,8 +21,8 @@
#include
#include
-#include
#include
+#include
DavidSpickett wrote:
Please make a PR for these clang-format changes.
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing
DavidSpickett wrote:
> Yes, to handle the 64-bit debuggees in AIX, we would need the ptrace64 call.
> It will apply to all the ptrace calls in general.
It is used in the NativeProcess/Thread plugins, but since those are new plugins
only for AIX they dont need an #if AIX.
Thanks. Yes I see that
Author: David Spickett
Date: 2024-12-18T09:43:54Z
New Revision: 66bdbfbaa08fa3d8e64a7fe136a8fb717f5cdbb7
URL:
https://github.com/llvm/llvm-project/commit/66bdbfbaa08fa3d8e64a7fe136a8fb717f5cdbb7
DIFF:
https://github.com/llvm/llvm-project/commit/66bdbfbaa08fa3d8e64a7fe136a8fb717f5cdbb7.diff
LOG
DavidSpickett wrote:
Can you summarise the need for ptrace64? Mainly, will this only apply to
launching a process or does it apply to any ptrace call?
I wonder:
1. How many #ifdef we're going to end up with
2. Whether AIX should use ptrace64 everywhere if your intention is to only
support AIX
@@ -193,8 +192,13 @@ struct ForkLaunchInfo {
}
// Start tracing this child that is about to exec.
+#if !defined(_AIX)
DavidSpickett wrote:
Generally I would prefer positive conditions as the first part of an if. So
here it would be if AIX use ptrace6
DavidSpickett wrote:
> Apologies for the blunder, I myself dont speak French by the way. 😀 Corrected
I am kinda impressed how many languages they have available, but the downside
is that Google seems to love choosing a non-English one for me.
https://github.com/llvm/llvm-project/pull/120390
__
DavidSpickett wrote:
I just pushed the clang-format changes for you, rebase to include them.
https://github.com/llvm/llvm-project/pull/120378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
DavidSpickett wrote:
You can send a formatting PR then one for actual changes, where the first
commit is the formatting. You'll just need to rebase the second one once the
first one lands. This will save us some back and forth.
You can use one of those stacked PR manager tools but for <= 2 cha
DavidSpickett wrote:
Please link to the English docs -
https://www.ibm.com/docs/en/aix/7.3?topic=p-ptrace-ptracex-ptrace64-subroutine
instead.
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -2842,31 +2850,32 @@ rnb_err_t
RNBRemote::SendStopReplyPacketForThread(nub_thread_t tid) {
if (g_num_reg_entries == 0)
InitializeRegisters();
-if (g_reg_entries != NULL) {
- auto interesting_regset = [](int regset) -> bool {
-#if defined(__arm64__) || de
DavidSpickett wrote:
Formatting existing comments is fine to include here.
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/119573
>From 42fe1cb8dcb131110f18eef23625e3910f795401 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 13 Dec 2024 13:55:23 +
Subject: [PATCH] [lldb][test] Prefer gmake to make and warn for potentiall
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/119573
>From d04d592f825f3f0684a7971d79d58f90044d8e62 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 13 Dec 2024 13:55:23 +
Subject: [PATCH] [lldb][test] Prefer gmake to make and warn for potentiall
@@ -52,13 +52,23 @@ set(LLDB_DEFAULT_TEST_DSYMUTIL
"${LLVM_TOOLS_BINARY_DIR}/dsymutil${CMAKE_EXECUTA
if(LLDB_TEST_MAKE)
set(LLDB_DEFAULT_TEST_MAKE ${LLDB_TEST_MAKE})
else()
- find_program(LLDB_DEFAULT_TEST_MAKE make gmake)
+ # Prefer gmake as it will be a version of GNU ma
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
DavidSpickett wrote:
Pad with more `-` so that the line is the same length as the next `//===---`
line.
https://github.com/llvm/llvm-project/pull/118160
__
@@ -0,0 +1,119 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
@DhruvSrivastavaX I realised I can do the squash when I merge it. I was
confused by seeing so many commits here but the final changes are correct
anyway.
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mailing l
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DavidSpickett commented:
I don't know if you have worked on LLVM before but regardless, thank you for
making use of the nice error handling patterns we have. Even if sometimes
they're a bit too much.
I don't have any major problems with this, just some style points and a cou
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -130,19 +164,41 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+
+ // Need to set this as XCOFF is only
@@ -130,19 +164,41 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+
+ // Need to set this as XCOFF is only
@@ -35,6 +29,10 @@
#include "llvm/BinaryFormat/XCOFF.h"
#include "llvm/Object/XCOFFObjectFile.h"
#include "llvm/Support/MemoryBuffer.h"
+#include
+#include
+#include
+#include
DavidSpickett wrote:
Did clang-format do this? If so please put up a PR with jus
https://github.com/DavidSpickett commented:
No big objections just small things.
If you make a clang-format PR add me as a reviewer, I'll get it merged quickly
so you can rebase this.
Seems like the sticking point is create vs. createXCOFFObjectFile and I'll
leave that to you and Pavel to sor
2201 - 2300 of 2869 matches
Mail list logo
