Author: David Spickett
Date: 2022-08-15T08:54:06Z
New Revision: 193259cbcec77add8e189c4dedeefb15fef50d5e
URL:
https://github.com/llvm/llvm-project/commit/193259cbcec77add8e189c4dedeefb15fef50d5e
DIFF:
https://github.com/llvm/llvm-project/commit/193259cbcec77add8e189c4dedeefb15fef50d5e.diff
LOG
Author: David Spickett
Date: 2022-08-15T09:04:25Z
New Revision: 9f947abf94e16fa7c759ab56a4fb030d6ef25961
URL:
https://github.com/llvm/llvm-project/commit/9f947abf94e16fa7c759ab56a4fb030d6ef25961
DIFF:
https://github.com/llvm/llvm-project/commit/9f947abf94e16fa7c759ab56a4fb030d6ef25961.diff
LOG
Author: David Spickett
Date: 2022-08-16T08:28:50Z
New Revision: 662c1c28813b4dd0cf8775b9acb950ded9705cae
URL:
https://github.com/llvm/llvm-project/commit/662c1c28813b4dd0cf8775b9acb950ded9705cae
DIFF:
https://github.com/llvm/llvm-project/commit/662c1c28813b4dd0cf8775b9acb950ded9705cae.diff
LOG
Author: David Spickett
Date: 2022-08-17T08:52:58Z
New Revision: fe4a58214fe850a8fa8c58fec8e8376e7233ecba
URL:
https://github.com/llvm/llvm-project/commit/fe4a58214fe850a8fa8c58fec8e8376e7233ecba
DIFF:
https://github.com/llvm/llvm-project/commit/fe4a58214fe850a8fa8c58fec8e8376e7233ecba.diff
LOG
DavidSpickett wrote:
> A WebAssembly debugging session can be started using the new command:
> wasm [:]
What about wasm requires a new command, given that you are connecting to a GDB
server as existing targets do.
https://github.com/llvm/llvm-project/pull/77949
Author: David Spickett
Date: 2024-01-18T16:46:38Z
New Revision: b75b9d82f576fecbdec98f7cd076be7a72f70dbf
URL:
https://github.com/llvm/llvm-project/commit/b75b9d82f576fecbdec98f7cd076be7a72f70dbf
DIFF:
https://github.com/llvm/llvm-project/commit/b75b9d82f576fecbdec98f7cd076be7a72f70dbf.diff
LOG
@@ -1618,22 +1621,25 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
for (uint32_t i = 0; i < num_matches; ++i) {
Symbol *symbol = symtab->SymbolAtIndex(match_indexes[i]);
if (symbol) {
+Stream::HighlightSettings pattern_info(
+
@@ -260,10 +271,9 @@ class Stream {
/// The ANSI color code to end colorization. This is
/// environment-dependent.
- void PutCStringColorHighlighted(llvm::StringRef text,
- llvm::StringRef pattern = "",
-
@@ -262,14 +263,12 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
}
if (ConstString demangled = m_mangled.GetDemangledName()) {
s->PutCString(", name=\"");
-s->PutCStringColorHighlighted(demangled.GetStringRef(), pattern,
-
@@ -72,23 +72,20 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
-void Stream::PutCStringColorHighlighted(llvm::StringRef text,
-llvm::StringRef pattern,
-llvm::String
DavidSpickett wrote:
> Do you think the commit message is good enough?
The commit spends a lot of time talking about the previous PR not saying what
this PR does. "Follow up to #..." is enough to give context.
This PR puts all the highlighting settings into a single struct for easier
handling
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrote:
> Question: Would be good/necessary to refactor LookupSymbolInModule into some
> smaller functions? At least separating the printing part?
Maybe this is me being used to monster functions in lldb, but this one seems
fi
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -23,6 +23,16 @@
namespace lldb_private {
+struct Information {
DavidSpickett wrote:
Looks like you already did this and yes it's a good thing, it means folks can't
forget to give all 3 bits of inform
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -178,8 +170,7 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
ansi_prefix = target_sp->GetDebugger().GetRegexMatchAnsiPrefix();
ansi_suffix = target_sp->GetDebugger().G
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -524,8 +525,7 @@ bool Address::Dump(Stream *s, ExecutionContextScope
*exe_scope, DumpStyle style,
ansi_suffix =
DavidSpickett wrote:
Is this unused now?
https://github.com/llvm/llvm-
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett commented:
Do a check for unused calls to getregexmatch, I found a few I think.
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
l
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -1609,6 +1612,11 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
}
if (num_matches > 0) {
+llvm::StringRef ansi_prefix =
+interpreter.GetDebugger().GetRegexMatchAnsiPrefix();
+
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrote:
> I see. But this would need to be in another PR, right?
Yes.
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett approved this pull request.
LGTM.
Unless you've got commit access yourself, I can land this for you on Monday.
https://github.com/llvm/llvm-project/pull/76112
_
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
@@ -664,7 +674,7 @@ void request_attach(const llvm::json::Object &request) {
// Run any initialize LLDB commands the user specified in the launch.json
if (llvm::Error err = g_dap.RunInitCommands()) {
-response["success"] = false;
+ response["success"] = false;
@@ -346,6 +346,16 @@ static offset_t GetOpcodeDataSize(const DataExtractor
&data,
return (offset - data_offset) + subexpr_len;
}
+ case DW_OP_WASM_location: {
+uint8_t wasm_op = data.GetU8(&offset);
+if (wasm_op == 3) {
+ data.GetU32(&offset);
+} else
DavidSpickett wrote:
> But currently a simple gdb-remote [:] does not enable the
> "wasm' plugin. Is there a way to detect that we are debugging WebAssembly at
> connect time?
Tracing down from `platform connect `, I get to
`Process::FindPlugin`, which creates a process of all the registered
@@ -0,0 +1,293 @@
+//===-- ProcessWasm.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Author: David Spickett
Date: 2024-01-26T10:36:22Z
New Revision: 11d76fdb0b9c500aace938427bba18602d15b17d
URL:
https://github.com/llvm/llvm-project/commit/11d76fdb0b9c500aace938427bba18602d15b17d
DIFF:
https://github.com/llvm/llvm-project/commit/11d76fdb0b9c500aace938427bba18602d15b17d.diff
LOG
Author: David Spickett
Date: 2024-01-26T11:37:50Z
New Revision: 5e9f0e37494ab42ff8d850527c5517f3006e63e9
URL:
https://github.com/llvm/llvm-project/commit/5e9f0e37494ab42ff8d850527c5517f3006e63e9
DIFF:
https://github.com/llvm/llvm-project/commit/5e9f0e37494ab42ff8d850527c5517f3006e63e9.diff
LOG
Author: David Spickett
Date: 2024-01-26T12:21:42Z
New Revision: 28ee54c32e6b761e65fd2a7412776f6300ad922b
URL:
https://github.com/llvm/llvm-project/commit/28ee54c32e6b761e65fd2a7412776f6300ad922b
DIFF:
https://github.com/llvm/llvm-project/commit/28ee54c32e6b761e65fd2a7412776f6300ad922b.diff
LOG
Author: David Spickett
Date: 2024-01-26T14:06:49Z
New Revision: bb945fcd4a54c2c8f898e2bdc0d65fae841a1909
URL:
https://github.com/llvm/llvm-project/commit/bb945fcd4a54c2c8f898e2bdc0d65fae841a1909
DIFF:
https://github.com/llvm/llvm-project/commit/bb945fcd4a54c2c8f898e2bdc0d65fae841a1909.diff
LOG
DavidSpickett wrote:
If you're referring to the CI that runs here, we've been having capacity issues
lately. Another way to "resubmit" is to rebase the PR.
https://github.com/llvm/llvm-project/pull/79655
___
lldb-commits mailing list
lldb-commits@list
Author: David Spickett
Date: 2024-01-29T10:04:29Z
New Revision: 34d80f559a3ebaa354f7820022c5e050a47a9870
URL:
https://github.com/llvm/llvm-project/commit/34d80f559a3ebaa354f7820022c5e050a47a9870
DIFF:
https://github.com/llvm/llvm-project/commit/34d80f559a3ebaa354f7820022c5e050a47a9870.diff
LOG
Author: David Spickett
Date: 2024-01-29T10:11:16Z
New Revision: 89c9fee420e1ed099aaa4aab48f3b58e233a3ea9
URL:
https://github.com/llvm/llvm-project/commit/89c9fee420e1ed099aaa4aab48f3b58e233a3ea9
DIFF:
https://github.com/llvm/llvm-project/commit/89c9fee420e1ed099aaa4aab48f3b58e233a3ea9.diff
LOG
@@ -86,20 +86,45 @@ def execute(self, test, litConfig):
if timeoutInfo:
return lit.Test.TIMEOUT, output
-# Parse the dotest output from stderr.
-result_regex = r"\((\d+) passes, (\d+) failures, (\d+) errors, (\d+)
skipped, (\d+) expected fa
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/79945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I ran this on Arm and AArch64 Linux. One test
`lldb/test/API/functionalities/breakpoint/hardware_breakpoints/require_hw_breakpoints/TestRequireHWBreakpoints.py`
was xfailed on AArch64 is now not. Before:
```
PASS: LLDB (/home/david.spickett/build-llvm-aarch64/bin/clang-aarc
Author: David Spickett
Date: 2024-01-30T13:46:09Z
New Revision: 7565ae6eb99b6d3c5d83d04404a2df1b3785dbfe
URL:
https://github.com/llvm/llvm-project/commit/7565ae6eb99b6d3c5d83d04404a2df1b3785dbfe
DIFF:
https://github.com/llvm/llvm-project/commit/7565ae6eb99b6d3c5d83d04404a2df1b3785dbfe.diff
LOG
@@ -130,14 +130,14 @@ def expectedFailure_impl(func):
def expectedFailureIfFn(expected_fn, bugnumber=None):
def expectedFailure_impl(func):
-if isinstance(func, type) and issubclass(func, unittest2.TestCase):
+if isinstance(func, type) and issubclass(func,
DavidSpickett wrote:
I've simplified that strange xfail in
https://github.com/llvm/llvm-project/commit/7565ae6eb99b6d3c5d83d04404a2df1b3785dbfe.
Still seeing the tests fail instead of xfail though, see my comment.
https://github.com/llvm/llvm-project/pull/79945
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/79990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/79990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/79990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
Sounds good to me.
https://github.com/llvm/llvm-project/pull/79945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Please run the python formatter before landing though.
https://github.com/llvm/llvm-project/pull/79945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I didn't have time to review before merge, just looking at this now.
> see what the Windows CI thinks.
I assume you mean the buildbots (lldb isn't built in the pre-commit CI), but I
think given:
https://github.com/llvm/llvm-zorg/blob/590f0a62919ad313758362d18a31e7d40255e6e
https://github.com/DavidSpickett commented:
Surprised this isn't horribly broken on Linux :)
Just a bunch of nits.
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,101 @@
+"""
+Watch a large unaligned memory region that
+lldb will need multiple hardware watchpoints
+to cover.
+"""
+
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class Unalign
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,142 @@
+//===-- WatchpointAlgorithms.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,101 @@
+"""
+Watch a large unaligned memory region that
+lldb will need multiple hardware watchpoints
+to cover.
+"""
+
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class Unalign
@@ -0,0 +1,101 @@
+"""
+Watch a large unaligned memory region that
+lldb will need multiple hardware watchpoints
+to cover.
+"""
+
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class Unalign
@@ -352,6 +358,20 @@ void Watchpoint::DumpWithLevel(Stream *s,
s->Printf("\ndeclare @ '%s'", m_decl_str.c_str());
if (!m_watch_spec_str.empty())
s->Printf("\nwatchpoint spec = '%s'", m_watch_spec_str.c_str());
+if (IsEnabled()) {
+ if (ProcessSP
@@ -448,6 +448,32 @@ enum WatchpointWriteType {
eWatchpointWriteTypeOnModify
};
+/// The hardware and native stub capabilities for a given target,
+/// for translating a user's watchpoint request into hardware
+/// capable watchpoint resources.
+FLAGS_ENUM(WatchpointHardware
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -113,7 +114,8 @@ bool
WatchpointResource::ShouldStop(StoppointCallbackContext *context) {
}
void WatchpointResource::Dump(Stream *s) const {
- return; // LWP_TODO
+ s->Printf("addr = 0x%8.8" PRIx64 " size = %zu", m_addr, m_size);
+ return;
DavidSpickett
@@ -0,0 +1,101 @@
+"""
+Watch a large unaligned memory region that
+lldb will need multiple hardware watchpoints
+to cover.
+"""
+
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class Unalign
@@ -38,7 +38,44 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -38,7 +38,44 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -38,7 +38,44 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -38,7 +38,44 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -403,6 +403,22 @@ void GDBRemoteCommunicationClient::GetRemoteQSupported() {
x.split(compressions, ',');
if (!compressions.empty())
MaybeEnableCompression(compressions);
+ } else if (x.consume_front("SupportedWatchpointTypes=")) {
+llvm
@@ -403,6 +403,22 @@ void GDBRemoteCommunicationClient::GetRemoteQSupported() {
x.split(compressions, ',');
if (!compressions.empty())
MaybeEnableCompression(compressions);
+ } else if (x.consume_front("SupportedWatchpointTypes=")) {
+llvm
DavidSpickett wrote:
Just to record that I thought about it, I agree with not trying to make the
names architecture neutral.
For example one might say that because range watchpoints on mips and aarch64
have overlapping functionality (no pun intended) that we could report that we
have "range"
@@ -38,7 +38,43 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -38,7 +38,43 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -38,7 +38,43 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -403,6 +403,22 @@ void GDBRemoteCommunicationClient::GetRemoteQSupported() {
x.split(compressions, ',');
if (!compressions.empty())
MaybeEnableCompression(compressions);
+ } else if (x.consume_front("SupportedWatchpointTypes=")) {
+llvm
DavidSpickett wrote:
> What happens now is that there is a ProcessGDBRemote that registers for
> gdb-remote and it is returned by Process::FindPlugin. > Then there is the new
> ProcessWasm which might also register for the same gdb-remote maybe.
> But the problem is that at the moment when we s
DavidSpickett wrote:
> I don't know specifically why we skip those tests on our bot. Could be that
> the Windows APIs are target specific like ptrace is, > and we just didn't
> implement it for Windows on Arm yet, could be that the hardware we have
> doesn't support it.
>
> I'll found out wha
DavidSpickett wrote:
Unlikely even that given the range breakpoint stuff is all on AArch64 anyway.
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
Author: David Spickett
Date: 2024-02-05T15:25:16Z
New Revision: ae92f6e8aeb97e39b95a40fde8a176f6aff94063
URL:
https://github.com/llvm/llvm-project/commit/ae92f6e8aeb97e39b95a40fde8a176f6aff94063
DIFF:
https://github.com/llvm/llvm-project/commit/ae92f6e8aeb97e39b95a40fde8a176f6aff94063.diff
LOG
@@ -0,0 +1,313 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for your command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
@@ -0,0 +1,313 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for your command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
@@ -0,0 +1,313 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for your command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
@@ -0,0 +1,313 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for your command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
@@ -0,0 +1,313 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for your command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
@@ -200,8 +201,19 @@ lldb_private::UUID
DynamicLoaderFreeBSDKernel::CheckForKernelImageAtAddress(
if (header.e_type != llvm::ELF::ET_EXEC)
return UUID();
- ModuleSP memory_module_sp =
- process->ReadModuleFromMemory(FileSpec("temp_freebsd_kernel"), addr);
+ ArchS
@@ -218,10 +230,16 @@ lldb_private::UUID
DynamicLoaderFreeBSDKernel::CheckForKernelImageAtAddress(
return UUID();
}
- // In here, I should check is_kernel for memory_module_sp
- // However, the ReadModuleFromMemory reads wrong section so that this check
- // will fai
@@ -153,9 +153,10 @@ addr_t DynamicLoaderFreeBSDKernel::FindKernelAtLoadAddress(
}
// Read ELF header from memry and return
+template
DavidSpickett wrote:
Exactly why does this change? I don't see a need for it in this PR.
https://github.com/llvm/llvm-proje
@@ -200,8 +201,19 @@ lldb_private::UUID
DynamicLoaderFreeBSDKernel::CheckForKernelImageAtAddress(
if (header.e_type != llvm::ELF::ET_EXEC)
return UUID();
- ModuleSP memory_module_sp =
- process->ReadModuleFromMemory(FileSpec("temp_freebsd_kernel"), addr);
+ ArchS
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/80785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -218,10 +230,16 @@ lldb_private::UUID
DynamicLoaderFreeBSDKernel::CheckForKernelImageAtAddress(
return UUID();
}
- // In here, I should check is_kernel for memory_module_sp
- // However, the ReadModuleFromMemory reads wrong section so that this check
- // will fai
DavidSpickett wrote:
Thanks, the logic is clearer now.
Should this check be limited to only when a uuid is actually found? This would
allow debugging of older FreeBSDs with a newer lldb.
https://github.com/llvm/llvm-project/pull/80785
___
lldb-comm
@@ -218,10 +234,18 @@ lldb_private::UUID
DynamicLoaderFreeBSDKernel::CheckForKernelImageAtAddress(
return UUID();
}
- // In here, I should check is_kernel for memory_module_sp
- // However, the ReadModuleFromMemory reads wrong section so that this check
- // will fai
@@ -218,10 +234,18 @@ lldb_private::UUID
DynamicLoaderFreeBSDKernel::CheckForKernelImageAtAddress(
return UUID();
}
- // In here, I should check is_kernel for memory_module_sp
- // However, the ReadModuleFromMemory reads wrong section so that this check
- // will fai
DavidSpickett wrote:
Yeah now was a bad time to land this unfortunately, because I managed to screw
up Linaro's lldb bots. Waiting on a fix for that to go in and we'll get back to
you if stuff is broken.
https://github.com/llvm/llvm-project/pull/79945
__
https://github.com/DavidSpickett approved this pull request.
LGTM.
Please hold off on merging until the Arm lldb bots are working again. I've
landed the fix so it shouldn't be too long now.
https://github.com/llvm/llvm-project/pull/81703
___
lldb-com
DavidSpickett wrote:
> @DavidSpickett what's the benefit of waiting for the arm bots to come back up?
If you give me the choice of more potential chaos or less, I'm always going to
choose less :)
But yes this shouldn't be too difficult to pick out if it does fail.
https://github.com/llvm/llvm
Author: David Spickett
Date: 2022-03-18T12:31:03Z
New Revision: 9f052f3dd2d8b59dde6278aa58c6e4477c2fdef6
URL:
https://github.com/llvm/llvm-project/commit/9f052f3dd2d8b59dde6278aa58c6e4477c2fdef6
DIFF:
https://github.com/llvm/llvm-project/commit/9f052f3dd2d8b59dde6278aa58c6e4477c2fdef6.diff
LOG
Author: David Spickett
Date: 2022-04-04T11:21:01Z
New Revision: 434b545d4fc7824cf03976a8844020e33040855e
URL:
https://github.com/llvm/llvm-project/commit/434b545d4fc7824cf03976a8844020e33040855e
DIFF:
https://github.com/llvm/llvm-project/commit/434b545d4fc7824cf03976a8844020e33040855e.diff
LOG
Author: David Spickett
Date: 2022-04-12T12:31:43Z
New Revision: 0231a90bc438f728c81087520d8d5d85101ed05b
URL:
https://github.com/llvm/llvm-project/commit/0231a90bc438f728c81087520d8d5d85101ed05b
DIFF:
https://github.com/llvm/llvm-project/commit/0231a90bc438f728c81087520d8d5d85101ed05b.diff
LOG
Author: David Spickett
Date: 2022-04-19T09:19:38Z
New Revision: 68e73eaee632b29d36e8b24f62e77ef26084885d
URL:
https://github.com/llvm/llvm-project/commit/68e73eaee632b29d36e8b24f62e77ef26084885d
DIFF:
https://github.com/llvm/llvm-project/commit/68e73eaee632b29d36e8b24f62e77ef26084885d.diff
LOG
Author: David Spickett
Date: 2022-04-28T14:57:40+01:00
New Revision: b809c4cdb70a100c85524555a14332f22ede1b7a
URL:
https://github.com/llvm/llvm-project/commit/b809c4cdb70a100c85524555a14332f22ede1b7a
DIFF:
https://github.com/llvm/llvm-project/commit/b809c4cdb70a100c85524555a14332f22ede1b7a.diff
Author: David Spickett
Date: 2022-04-29T08:41:34Z
New Revision: 14869bd2dfabb7a808e57e17dd45eef7665dd737
URL:
https://github.com/llvm/llvm-project/commit/14869bd2dfabb7a808e57e17dd45eef7665dd737
DIFF:
https://github.com/llvm/llvm-project/commit/14869bd2dfabb7a808e57e17dd45eef7665dd737.diff
LOG
Author: David Spickett
Date: 2022-04-29T10:01:26Z
New Revision: 713752610edd3d8766f56e2704bb7241434cd15b
URL:
https://github.com/llvm/llvm-project/commit/713752610edd3d8766f56e2704bb7241434cd15b
DIFF:
https://github.com/llvm/llvm-project/commit/713752610edd3d8766f56e2704bb7241434cd15b.diff
LOG
Author: David Spickett
Date: 2022-04-29T11:02:59Z
New Revision: d9247cc84825539d346c74eb1379c6cb948d3a71
URL:
https://github.com/llvm/llvm-project/commit/d9247cc84825539d346c74eb1379c6cb948d3a71
DIFF:
https://github.com/llvm/llvm-project/commit/d9247cc84825539d346c74eb1379c6cb948d3a71.diff
LOG
Author: David Spickett
Date: 2022-04-29T11:25:09Z
New Revision: cacaa445c3a3a2551a6e2aef51414e47def9cc06
URL:
https://github.com/llvm/llvm-project/commit/cacaa445c3a3a2551a6e2aef51414e47def9cc06
DIFF:
https://github.com/llvm/llvm-project/commit/cacaa445c3a3a2551a6e2aef51414e47def9cc06.diff
LOG
1201 - 1300 of 2869 matches
Mail list logo
