[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-27 Thread Alex Langford via lldb-commits
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const { return false; } +bool CompilerType::IsSmartPtrType() const { + // These regular expressions cover shared, unique and weak pointers both from + // stdlibc++ and libc+++. + + static llvm::Regex k_libcxx_std_u

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-27 Thread Alex Langford via lldb-commits
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const { return false; } +bool CompilerType::IsSmartPtrType() const { + // These regular expressions cover shared, unique and weak pointers both from + // stdlibc++ and libc+++. + + static llvm::Regex k_libcxx_std_u

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Seems okay to me in general. Left some inline comments and I also agree with all of Jonas's inline comments I saw too. https://github.com/llvm/llvm-project/pull/73472 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-27 Thread Alex Langford via lldb-commits
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const { return false; } +bool CompilerType::IsSmartPtrType() const { + // These regular expressions cover shared, unique and weak pointers both from + // stdlibc++ and libc+++. + + static llvm::Regex k_libcxx_std_u

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-27 Thread Alex Langford via lldb-commits
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const { return false; } +bool CompilerType::IsSmartPtrType() const { + // These regular expressions cover shared, unique and weak pointers both from + // stdlibc++ and libc+++. + + static llvm::Regex k_libcxx_std_u

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-27 Thread Alex Langford via lldb-commits
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const { return false; } +bool CompilerType::IsSmartPtrType() const { + // These regular expressions cover shared, unique and weak pointers both from + // stdlibc++ and libc+++. bulbazord wrote: If

[Lldb-commits] [lldb] [lldb][test] Remove `reason` from `unittest2.expectedFailure` usage (PR #73028)

2023-11-28 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Awesome! https://github.com/llvm/llvm-project/pull/73028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-29 Thread Alex Langford via lldb-commits
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const { return false; } +bool CompilerType::IsSmartPtrType() const { + // These regular expressions cover shared, unique and weak pointers both from + // stdlibc++ and libc+++. + + static llvm::Regex k_libcxx_std_u

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-11-30 Thread Alex Langford via lldb-commits
@@ -1451,7 +1451,8 @@ static lldb::SectionType GetSectionType(uint32_t flags, static ConstString g_sect_name_dwarf_debug_line_str("__debug_line_str"); static ConstString g_sect_name_dwarf_debug_loc("__debug_loc"); static ConstString g_sect_name_dwarf_debug_loclists("__deb

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-11-30 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/69516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-11-30 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. There looks to be a ton of unrelated changes in ObjectFileMachO.cpp. Mostly formatting from what I can tell. Please revert to preserve blame history. https://github.com/llvm/llvm-project/pull/69516

[Lldb-commits] [lldb] [lldb] Remove pre GCC 4.8 workaround (PR #73981)

2023-11-30 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM >From the look of it, it looks like the minimum version of GCC that is >currently supported is 7.1. (See: >`llvm/cmake/modules/CheckCompilerVersion.cmake`) https://github.com/llvm/llvm-project/pull/73981 ___

[Lldb-commits] [lldb] [lldb] pipe2(2) is also supported by OpenBSD (PR #74012)

2023-11-30 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. If [this man page](https://man.openbsd.org/pipe2) is to be believed, this seems alright to do. https://github.com/llvm/llvm-project/pull/74012 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [lldb] [lldb/test] Add OpenBSD to _get_platform_os (PR #74036)

2023-12-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/74036 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Simplify pipe2(2) handling on FreeBSD (PR #74019)

2023-12-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. 🥳 https://github.com/llvm/llvm-project/pull/74019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make use of LD_LIBRARY_PATH on OpenBSD (PR #74017)

2023-12-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/74017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. 🎉 https://github.com/llvm/llvm-project/pull/74119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Additional pieces towards OpenBSD support (PR #74198)

2023-12-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/74198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Additional pieces towards OpenBSD support (PR #74198)

2023-12-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM overall, small nit https://github.com/llvm/llvm-project/pull/74198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Additional pieces towards OpenBSD support (PR #74198)

2023-12-04 Thread Alex Langford via lldb-commits
@@ -1,4 +1,7 @@ #include +#ifdef __OpenBSD__ bulbazord wrote: For consistency, can you change this to `if defined(__OpenBSD__)`? Not a big deal though https://github.com/llvm/llvm-project/pull/74198 ___ lldb-commits

[Lldb-commits] [lldb] Add option to pass thread ID to thread select command (PR #73596)

2023-12-04 Thread Alex Langford via lldb-commits
@@ -1296,10 +1296,11 @@ enum CompletionType { eRemoteDiskFileCompletion = (1u << 22), eRemoteDiskDirectoryCompletion = (1u << 23), eTypeCategoryNameCompletion = (1u << 24), + eThreadIDCompletion = (1u << 25), bulbazord wrote: Independent of the API stan

[Lldb-commits] [lldb] [lldb] Sync OpenBSD GetOSVersion() closer to NetBSD function (PR #74396)

2023-12-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/74396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF][NFC] Remove unnecessary calls to GetDWARFDeclContext (PR #74523)

2023-12-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/74523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/74687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM, small typo https://github.com/llvm/llvm-project/pull/74687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a stall in running `quit` while a live process is running (PR #74687)

2023-12-07 Thread Alex Langford via lldb-commits
@@ -558,7 +558,10 @@ class Process : public std::enable_shared_from_this, /// /// Subclasses that override this method should always call this superclass /// method. - virtual void Finalize(); + /// If you are running Finalize in your Process subclass Destructor, pass

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: The implementation looks fine to me. Can you write a test? https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [llvm] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

2023-12-07 Thread Alex Langford via lldb-commits
bulbazord wrote: > @JDevlieghere Can you delete the `llvm-project/lldb/tools/lldb-vscode` > directory from git after this commit to clean up our codebase? There are > still two copies of the `lldb-dap` code in the sources: > > ``` > lldb/tools/lldb-dap > lldb/tools/lldb-vscode > ``` > > I wor

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/74773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Simplify DWARRFDeclContext::GetQualifiedName (PR #74788)

2023-12-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. TIL about this overload of `llvm::interleave`!!! https://github.com/llvm/llvm-project/pull/74788 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Alex Langford via lldb-commits
@@ -33,14 +39,49 @@ void RunLLDBCommands(llvm::StringRef prefix, const char *error = result.GetError(); strm << error; } + }; + + lldb::SBCommandInterpreter interp = g_dap.debugger.GetCommandInterpreter(); + for (llvm::StringRef command : commands) { +lld

[Lldb-commits] [lldb] [lldb-dap] Include [opt] in the frame name only if a custom frame format is not specified. (PR #74861)

2023-12-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: I think conceptually this makes sense, but I somewhat wonder if folks would get confused when they have a custom frame format and don't see the [opt] in there? The current behavior is that [opt] is always there so folks know they don't have to put it in

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

2023-12-08 Thread Alex Langford via lldb-commits
@@ -1101,6 +1101,29 @@ std::string CreateUniqueVariableNameForDisplay(lldb::SBValue v, // can use this optional information to present the // children in a paged UI and fetch them in chunks." // } +// "declaration": { +//

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

2023-12-11 Thread Alex Langford via lldb-commits
bulbazord wrote: Is this extension to the protocol documented anywhere I can see? Or is this an ad-hoc thing? I think it would be useful to write down somewhere other than a commit message (in docs, comments, or otherwise) that this is an extension. https://github.com/llvm/llvm-project/pull/74

[Lldb-commits] [lldb] [lldb-dap] Include [opt] in the frame name only if a custom frame format is not specified. (PR #74861)

2023-12-11 Thread Alex Langford via lldb-commits
bulbazord wrote: > `{${function.is-optimized} [opt]}` is how is already is and can be done with > frame formats, so I agree with this patch that if the user customizes it, > they have complete control and we shouldn't add anything. Does everyone else > agree? I think I agree with this in prin

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

2023-12-11 Thread Alex Langford via lldb-commits
bulbazord wrote: > > Is this extension to the protocol documented anywhere I can see? Or is this > > an ad-hoc thing? I think it would be useful to write down somewhere other > > than a commit message (in docs, comments, or otherwise) that this is an > > extension. > > @bulbazord , it's an ad

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

2023-12-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/74865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-11 Thread Alex Langford via lldb-commits
bulbazord wrote: @compnerd Perhaps you can take a look at this one? Not sure who does Windows work on LLDB these days. https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-12-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Seems okay to me... Quick question: Why do you need `CompilerType::GetTemplateArgumentType`? This seems pretty specific to C++. Is there a more general concept we could capture? Like something related to "Generics"? https://github.com/llvm/llvm-project/

[Lldb-commits] [lldb] [lldb][NFCI] Remove unused parameter from BreakpointResolver*::CreateFromStructuredData (PR #75374)

2023-12-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/75374 These appear to be unused. >From e00884c8a9e6010b339932a9bff840634462beb7 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Wed, 13 Dec 2023 11:35:49 -0800 Subject: [PATCH] [lldb][NFCI] Remove unused paramete

[Lldb-commits] [lldb] Fix a crash from character type confusion interaction with libedit (PR #75388)

2023-12-13 Thread Alex Langford via lldb-commits
@@ -978,8 +978,14 @@ void Editline::DisplayCompletions( break; fprintf(editline.m_output_file, "More (Y/n/a): "); -char reply = 'n'; -int got_char = el_getc(editline.m_editline, &reply); +// The type for the output and the type for the parameter are diffe

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-12-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Seems okay to me. I don't see anything in here that wouldn't make sense in at least some other languages (other than C++). https://github.com/llvm/llvm-project/pull/73472 ___ lldb-commits mailin

[Lldb-commits] [lldb] [lldb][NFCI] Remove unused parameter from BreakpointResolver*::CreateFromStructuredData (PR #75374)

2023-12-15 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/75374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][PDB] Update max matches test for type queries (PR #75813)

2023-12-18 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Seems like a good clean up to me! https://github.com/llvm/llvm-project/pull/75813 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] Remove unused FileSPec::IsResolved() functionality. (PR #75840)

2023-12-18 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/75840 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove unused GetChildAtIndexPath(...) methods from ValueObject.cpp (PR #75870)

2023-12-18 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/75870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-18 Thread Alex Langford via lldb-commits
@@ -38,7 +65,10 @@ class FileSpecList { FileSpecList(FileSpecList &&rhs) = default; /// Initialize this object from a vector of FileSpecs - FileSpecList(std::vector &&rhs) : m_files(std::move(rhs)) {} + FileSpecList(std::vector &&rhs) { +for (auto &fs : rhs) + m

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-18 Thread Alex Langford via lldb-commits
@@ -17,13 +17,40 @@ namespace lldb_private { class Stream; +/// Represents a source file whose contents is known (for example +/// because it can be reconstructed from debug info), but that +/// hasn't been written to a local disk yet. +struct LazyFileSpec { + virtual ~LazyFi

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

2023-12-18 Thread Alex Langford via lldb-commits
@@ -1992,71 +1999,67 @@ void ValueObject::GetExpressionPath(Stream &s, } ValueObjectSP ValueObject::GetValueForExpressionPath( -llvm::StringRef expression, ExpressionPathScanEndReason *reason_to_stop, -ExpressionPathEndResultType *final_value_type, +llvm::StringRef

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

2023-12-18 Thread Alex Langford via lldb-commits
@@ -1623,62 +1623,68 @@ bool ValueObject::IsUninitializedReference() { ValueObjectSP ValueObject::GetSyntheticArrayMember(size_t index, bool can_create) { - ValueObjectSP synthetic_child_sp; - if (IsPointerType() || IsArrayT

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

2023-12-18 Thread Alex Langford via lldb-commits
@@ -1777,30 +1783,31 @@ static const char *SkipLeadingExpressionPathSeparators(const char *expression) { ValueObjectSP ValueObject::GetSyntheticExpressionPathChild(const char *expression, bool can_create) { - ValueObjectSP syntheti

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

2023-12-18 Thread Alex Langford via lldb-commits
@@ -1623,62 +1623,68 @@ bool ValueObject::IsUninitializedReference() { ValueObjectSP ValueObject::GetSyntheticArrayMember(size_t index, bool can_create) { - ValueObjectSP synthetic_child_sp; - if (IsPointerType() || IsArrayT

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

2023-12-18 Thread Alex Langford via lldb-commits
@@ -1992,71 +1999,67 @@ void ValueObject::GetExpressionPath(Stream &s, } ValueObjectSP ValueObject::GetValueForExpressionPath( -llvm::StringRef expression, ExpressionPathScanEndReason *reason_to_stop, -ExpressionPathEndResultType *final_value_type, +llvm::StringRef

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

2023-12-19 Thread Alex Langford via lldb-commits
@@ -1777,30 +1783,31 @@ static const char *SkipLeadingExpressionPathSeparators(const char *expression) { ValueObjectSP ValueObject::GetSyntheticExpressionPathChild(const char *expression, bool can_create) { - ValueObjectSP syntheti

[Lldb-commits] [lldb] [lldb][Type] Add TypeQuery::SetLanguages API (PR #75926)

2023-12-19 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/75926 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-19 Thread Alex Langford via lldb-commits
@@ -38,7 +65,10 @@ class FileSpecList { FileSpecList(FileSpecList &&rhs) = default; /// Initialize this object from a vector of FileSpecs - FileSpecList(std::vector &&rhs) : m_files(std::move(rhs)) {} + FileSpecList(std::vector &&rhs) { +for (auto &fs : rhs) + m

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/76030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/76171 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/76766 BreakpointResolverAddress optionally can include the module name related to the address that gets resolved. Currently this will never work because it sets the name to itself (which is empty). >From 519f2db688

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-02 Thread Alex Langford via lldb-commits
bulbazord wrote: > Can this be tested? I took a look at existing tests, but I'm not sure how to best test this. I think we would need to create a breakpoint in a module by address and make sure the resolver correctly serializes the name (in `statistics dump` or otherwise). Does that sound app

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/76766 >From a9b6b6fee19fd19bf1fdce6fe8e9ed35f7c1567a Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Tue, 2 Jan 2024 15:44:30 -0800 Subject: [PATCH] [lldb] Fix breakpoint resolver serialization bug BreakpointReso

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-03 Thread Alex Langford via lldb-commits
bulbazord wrote: @clayborg I was able to write a test similar to what you suggested (without needing to set two breakpoints). I also changed the actual fix since a module's object name isn't quite what I wanted in the first place. https://github.com/llvm/llvm-project/pull/76766 ___

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/76766 >From 9688e85a01c8c952a3db17510cc97ce6db570e96 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Tue, 2 Jan 2024 15:44:30 -0800 Subject: [PATCH] [lldb] Fix breakpoint resolver serialization bug BreakpointReso

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-03 Thread Alex Langford via lldb-commits
@@ -49,6 +49,37 @@ def test_scripted_extra_args(self): self.setup_targets_and_cleanup() self.do_check_extra_args() +def test_resolver_serialization(self): +"""Test that breakpoint resolvers contain the expected information""" +self.build() +

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/76766 >From 9688e85a01c8c952a3db17510cc97ce6db570e96 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Tue, 2 Jan 2024 15:44:30 -0800 Subject: [PATCH 1/2] [lldb] Fix breakpoint resolver serialization bug Breakpoint

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/76766 >From 9688e85a01c8c952a3db17510cc97ce6db570e96 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Tue, 2 Jan 2024 15:44:30 -0800 Subject: [PATCH 1/3] [lldb] Fix breakpoint resolver serialization bug Breakpoint

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/76766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-03 Thread Alex Langford via lldb-commits
bulbazord wrote: Looks like this broke on aarch64-windows. Taking a look now. https://github.com/llvm/llvm-project/pull/76766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-03 Thread Alex Langford via lldb-commits
bulbazord wrote: ``` == ERROR: test_resolver_serialization (TestBreakpointSerialization.BreakpointSerialization) Test that breakpoint resolvers contain the expected information

[Lldb-commits] [lldb] bdaedff - [lldb] Speculatively fix TestBreakpointSerialization on Windows

2024-01-03 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2024-01-03T15:50:25-08:00 New Revision: bdaedffc43a608ef5fdc8a0e0c524be0a3a8f72e URL: https://github.com/llvm/llvm-project/commit/bdaedffc43a608ef5fdc8a0e0c524be0a3a8f72e DIFF: https://github.com/llvm/llvm-project/commit/bdaedffc43a608ef5fdc8a0e0c524be0a3a8f72e.diff

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

2024-01-03 Thread Alex Langford via lldb-commits
bulbazord wrote: Speculative fix in bdaedffc43a608ef5fdc8a0e0c524be0a3a8f72e https://github.com/llvm/llvm-project/pull/76766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Mark function as const (PR #76974)

2024-01-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/76974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Remove BreakpointIDList::InsertStringArray (PR #77161)

2024-01-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/77161 This abstraction is leaky and BreakpointIDList does not need to know about CommandReturnObject. Additionally, setting the CommandReturnObject inout param to a success state does very little. The function retur

[Lldb-commits] [lldb] [lldb][NFCI] Change return type of BreakpointIDList::GetBreakpointIDAtIndex (PR #77166)

2024-01-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/77166 There are 2 motivations here: 1.) There is no need to hand out constant references to BreakpointIDs, they are only 8 bytes big. In addition, every use of this method already makes a copy anyway. 2.) Each Bre

[Lldb-commits] [lldb] [lldb][NFCI] Remove BreakpointIDList::InsertStringArray (PR #77161)

2024-01-08 Thread Alex Langford via lldb-commits
bulbazord wrote: > LGTM! > > I see that we still have `FindAndReplaceIDRanges` referencing > CommandReturnObject; out of curiosity, have you had a chance to look into > removing that one (if it makes sense)? I see that `CommandReturnObject` is > neither `#include`ed nor forward declared in th

[Lldb-commits] [lldb] [lldb][NFCI] Change return type of BreakpointIDList::GetBreakpointIDAtIndex (PR #77166)

2024-01-08 Thread Alex Langford via lldb-commits
@@ -20,17 +20,15 @@ using namespace lldb_private; // class BreakpointIDList -BreakpointIDList::BreakpointIDList() -: m_invalid_id(LLDB_INVALID_BREAK_ID, LLDB_INVALID_BREAK_ID) {} +BreakpointIDList::BreakpointIDList() : m_breakpoint_ids() {} BreakpointIDList::~Breakpoin

[Lldb-commits] [lldb] [lldb][NFCI] Remove BreakpointIDList::InsertStringArray (PR #77161)

2024-01-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/77161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Change return type of BreakpointIDList::GetBreakpointIDAtIndex (PR #77166)

2024-01-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/77166 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds some C++20 calendar data formatters. (PR #76983)

2024-01-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: I don't have a lot of knowledge about the C++20 calendar types, but the LLDB implementation looks ok to me. What do you think @Michael137? https://github.com/llvm/llvm-project/pull/76983 ___ lldb-commits mailin

[Lldb-commits] [lldb] [lldb] Deprecate SBBreakpoint::AddName in favor of AddNameWithErrorHandling (PR #71228)

2024-01-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/71228 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsInteger (PR #71993)

2024-01-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/71993 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adjust DynamicLoaderDarwin::GetThreadLocalData to support changes to TLS on macOS (PR #77854)

2024-01-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/77854 TLS implementation on Apple OSes has changed. Instead of acquiring a pthread_key and calling pthread_getspecific, we instead acquire a function pointer and perform a function call with it. This fixes accessing

[Lldb-commits] [lldb] [lldb] Adjust DynamicLoaderDarwin::GetThreadLocalData to support changes to TLS on macOS (PR #77854)

2024-01-11 Thread Alex Langford via lldb-commits
@@ -1048,70 +1048,107 @@ DynamicLoaderDarwin::GetThreadLocalData(const lldb::ModuleSP module_sp, std::lock_guard guard(m_mutex); - const uint32_t addr_size = m_process->GetAddressByteSize(); + lldb_private::Address tls_addr; + if (!module_sp->ResolveFileAddress(tls_file

[Lldb-commits] [lldb] [lldb][NFCI] Remove CommandReturnObject from BreakpointIDList (PR #77858)

2024-01-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/77858 BreakpointIDList does not need to know about CommandReturnObject. BreakpointIDList::FindAndReplaceIDRanges is the last place that uses it in BreakpointIDList. Instead of passing in a CommandReturnObject, it n

[Lldb-commits] [lldb] 564ff8f - [lldb][NFCI] Remove use of Stream * from TypeSystem

2023-07-07 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-07T10:09:43-07:00 New Revision: 564ff8ffe75d9353ac02be5a4d3aa424cb79429c URL: https://github.com/llvm/llvm-project/commit/564ff8ffe75d9353ac02be5a4d3aa424cb79429c DIFF: https://github.com/llvm/llvm-project/commit/564ff8ffe75d9353ac02be5a4d3aa424cb79429c.diff

[Lldb-commits] [lldb] 1e7101a - [lldb][NFCI] TestEmulation should take a Stream ref

2023-07-10 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-10T11:17:25-07:00 New Revision: 1e7101a3d95884c791d566b7b6192fbac55f55e0 URL: https://github.com/llvm/llvm-project/commit/1e7101a3d95884c791d566b7b6192fbac55f55e0 DIFF: https://github.com/llvm/llvm-project/commit/1e7101a3d95884c791d566b7b6192fbac55f55e0.diff

[Lldb-commits] [lldb] e7c48ff - [lldb][NFCI] Avoid construction of temporary std::strings in Variable

2023-07-11 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-11T10:22:02-07:00 New Revision: e7c48ffde1c8137822a1b0a1ba6c4be5b4624aa6 URL: https://github.com/llvm/llvm-project/commit/e7c48ffde1c8137822a1b0a1ba6c4be5b4624aa6 DIFF: https://github.com/llvm/llvm-project/commit/e7c48ffde1c8137822a1b0a1ba6c4be5b4624aa6.diff

[Lldb-commits] [lldb] 1d796b4 - [lldb][NFCI] Methods to load scripting resources should take a Stream by reference

2023-07-11 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-11T10:36:11-07:00 New Revision: 1d796b48e4d48bd0e4b29972a1b8d653493ee30c URL: https://github.com/llvm/llvm-project/commit/1d796b48e4d48bd0e4b29972a1b8d653493ee30c DIFF: https://github.com/llvm/llvm-project/commit/1d796b48e4d48bd0e4b29972a1b8d653493ee30c.diff

[Lldb-commits] [lldb] 1d7a3dc - [lldb] Forward declare SBPlatform and SBTypeMember in SBDefines

2023-07-13 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-13T10:51:48-07:00 New Revision: 1d7a3dcff77837d63a2ef4a25ab3c683ed623ec8 URL: https://github.com/llvm/llvm-project/commit/1d7a3dcff77837d63a2ef4a25ab3c683ed623ec8 DIFF: https://github.com/llvm/llvm-project/commit/1d7a3dcff77837d63a2ef4a25ab3c683ed623ec8.diff

[Lldb-commits] [lldb] c25e48c - [lldb] Move CommandOverrideCallbackWithResult to lldb_private namespace

2023-07-13 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-13T11:21:35-07:00 New Revision: c25e48c5d776c5fb8f94f13a73f44cd930968c29 URL: https://github.com/llvm/llvm-project/commit/c25e48c5d776c5fb8f94f13a73f44cd930968c29 DIFF: https://github.com/llvm/llvm-project/commit/c25e48c5d776c5fb8f94f13a73f44cd930968c29.diff

[Lldb-commits] [lldb] 7ee633a - [lldb][NFCI] Remove unneeded temporary std::string allocations in SBAPI

2023-07-14 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-14T10:46:42-07:00 New Revision: 7ee633a24b8ce87b3a9b2f0f4bd1aace634cd2a1 URL: https://github.com/llvm/llvm-project/commit/7ee633a24b8ce87b3a9b2f0f4bd1aace634cd2a1 DIFF: https://github.com/llvm/llvm-project/commit/7ee633a24b8ce87b3a9b2f0f4bd1aace634cd2a1.diff

[Lldb-commits] [lldb] 1b29a84 - [lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue

2023-07-17 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-17T12:53:34-07:00 New Revision: 1b29a848ffa2d2c108de9e64de1d271e10db25f0 URL: https://github.com/llvm/llvm-project/commit/1b29a848ffa2d2c108de9e64de1d271e10db25f0 DIFF: https://github.com/llvm/llvm-project/commit/1b29a848ffa2d2c108de9e64de1d271e10db25f0.diff

[Lldb-commits] [lldb] 5876eee - [lldb][NFCI] Add some missing SB class forward declarations

2023-07-24 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-24T10:33:30-07:00 New Revision: 5876eee1ff9278662aab219023f7466406ff4dfc URL: https://github.com/llvm/llvm-project/commit/5876eee1ff9278662aab219023f7466406ff4dfc DIFF: https://github.com/llvm/llvm-project/commit/5876eee1ff9278662aab219023f7466406ff4dfc.diff

[Lldb-commits] [lldb] a809720 - [lldb][NFCI] Change logic to find clang resource dir in standalone builds

2023-07-25 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-25T15:52:33-07:00 New Revision: a809720102fae8d1b5a7073f99f9dae9395c5f41 URL: https://github.com/llvm/llvm-project/commit/a809720102fae8d1b5a7073f99f9dae9395c5f41 DIFF: https://github.com/llvm/llvm-project/commit/a809720102fae8d1b5a7073f99f9dae9395c5f41.diff

[Lldb-commits] [lldb] db9087a - [lldb] Clean up uses of UuidCompatibility.h

2023-07-31 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-07-31T10:30:07-07:00 New Revision: db9087a696a65042701049b9028096aeda82aa98 URL: https://github.com/llvm/llvm-project/commit/db9087a696a65042701049b9028096aeda82aa98 DIFF: https://github.com/llvm/llvm-project/commit/db9087a696a65042701049b9028096aeda82aa98.diff

[Lldb-commits] [lldb] 6888de1 - [lldb] Fix building LLDB standlone without framework

2023-08-01 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-01T09:50:36-07:00 New Revision: 6888de118707e6392b46073fc35738804f9f1d80 URL: https://github.com/llvm/llvm-project/commit/6888de118707e6392b46073fc35738804f9f1d80 DIFF: https://github.com/llvm/llvm-project/commit/6888de118707e6392b46073fc35738804f9f1d80.diff

[Lldb-commits] [lldb] b8aba26 - [lldb][NFCI] More forward declarations in SBDefines.h

2023-08-01 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-01T09:57:07-07:00 New Revision: b8aba26c82f270a3bdbc85e2c886e8446f0d6820 URL: https://github.com/llvm/llvm-project/commit/b8aba26c82f270a3bdbc85e2c886e8446f0d6820 DIFF: https://github.com/llvm/llvm-project/commit/b8aba26c82f270a3bdbc85e2c886e8446f0d6820.diff

[Lldb-commits] [lldb] 6c2e324 - [lldb] Re-add compile-time checks for SPI in HosInfoMacOSX

2023-08-02 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-02T10:21:54-07:00 New Revision: 6c2e3249160f5b68f6e09fed0435ee043659f2d9 URL: https://github.com/llvm/llvm-project/commit/6c2e3249160f5b68f6e09fed0435ee043659f2d9 DIFF: https://github.com/llvm/llvm-project/commit/6c2e3249160f5b68f6e09fed0435ee043659f2d9.diff

[Lldb-commits] [lldb] 08dc847 - [lldb][NFCI] Add SBTraceCursor.h to swig headers file

2023-08-03 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-03T16:41:17-07:00 New Revision: 08dc847d55fbdfa7ff6cb8034633139df0199562 URL: https://github.com/llvm/llvm-project/commit/08dc847d55fbdfa7ff6cb8034633139df0199562 DIFF: https://github.com/llvm/llvm-project/commit/08dc847d55fbdfa7ff6cb8034633139df0199562.diff

[Lldb-commits] [lldb] 335d0e3 - [lldb][NFCI] Remove unused IOStreamMacros

2023-08-09 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-09T11:42:41-07:00 New Revision: 335d0e3a6e8de8cccd535d9dbaa3df5600884ad7 URL: https://github.com/llvm/llvm-project/commit/335d0e3a6e8de8cccd535d9dbaa3df5600884ad7 DIFF: https://github.com/llvm/llvm-project/commit/335d0e3a6e8de8cccd535d9dbaa3df5600884ad7.diff

<    1   2   3   4   5   6   7   8   9   10   >