[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-03 Thread via lldb-commits
https://github.com/award999 created https://github.com/llvm/llvm-project/pull/146884 - Add `winston` dependency (MIT license) to handle logging setup - Have an `OutputChannel` to log user facing information, errors, warnings - Write a verose log under the provided `logUri` to capture further dia

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-03 Thread via lldb-commits
award999 wrote: This PR illustrates my proposal for issue #146880 https://github.com/llvm/llvm-project/pull/146884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Consolidate libstdc++ and libc++ vector formatter tests into generic test (PR #146885)

2025-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes The libstdc++ test was a subset of the tests in libc++. This test moves the libc++ test into `generic` and removes the `libstdc++` tests. I retained the `-D_GLIBCXX_DEBUG` test cases though. Split out fro

[Lldb-commits] [lldb] [lldb][test] Consolidate libstdc++ and libc++ vector formatter tests into generic test (PR #146885)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/146885 The libstdc++ test was a subset of the tests in libc++. This test moves the libc++ test into `generic` and removes the `libstdc++` tests. I retained the `-D_GLIBCXX_DEBUG` test cases though. Split out from

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-03 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From 386436bc42c7c17d311f4eda0abf3003ecb5ac5a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146909 >From 9963727a56237f9424642bb1cc12e800640fbd0e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 3 Jul 2025 16:07:11 +0100 Subject: [PATCH 1/3] [lldb][DataFormatter] Format libstdc++ unique_ptr like we

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread Michael Buch via lldb-commits
@@ -55,6 +55,12 @@ void AddFilter(TypeCategoryImpl::SharedPointer category_sp, std::optional ExtractIndexFromString(const char *item_name); +/// Returns \c false if the smart pointer formatters shouldn't continue +/// formatting the rest of the object. Currently this is the c

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread Michael Buch via lldb-commits
@@ -55,6 +55,12 @@ void AddFilter(TypeCategoryImpl::SharedPointer category_sp, std::optional ExtractIndexFromString(const char *item_name); +/// Returns \c false if the smart pointer formatters shouldn't continue +/// formatting the rest of the object. Currently this is the c

[Lldb-commits] [lldb] [LLDB] Optimize identifier lookup in DIL (PR #146094)

2025-07-03 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: @Michael137 If I add a non-static member to that struct, would dsymutil keep the static member debug info as well? https://github.com/llvm/llvm-project/pull/146094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-07-03 Thread via lldb-commits
https://github.com/jimingham approved this pull request. I don't think we ever have a use case where the Hijack listener would only want to see "new" events after the Hijack point. And that's certainly not what we want for process events where the full sequence is important. So the behavior

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-03 Thread Bassam Khouri via lldb-commits
@@ -156,16 +157,34 @@ async function getDAPArguments( .get("arguments", []); } +/** + * Formats the given date as a string in the form "MMdd". + * + * @param date The date to format as a string. + * @returns The formatted date. + */ +function formatDate(date: Date): st

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-03 Thread Bassam Khouri via lldb-commits
@@ -0,0 +1,88 @@ +import * as vscode from "vscode"; +import * as winston from "winston"; +import * as Transport from "winston-transport"; + +class OutputChannelTransport extends Transport { +constructor(private readonly ouptutChannel: vscode.OutputChannel) { +super();

[Lldb-commits] [lldb] 31bdd5f - [lldb][test] XFAIL TestIRInterpreter.py on Windows again

2025-07-03 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-07-03T14:15:56Z New Revision: 31bdd5fd39cb26e0c85c7e2cb731d710d96057b6 URL: https://github.com/llvm/llvm-project/commit/31bdd5fd39cb26e0c85c7e2cb731d710d96057b6 DIFF: https://github.com/llvm/llvm-project/commit/31bdd5fd39cb26e0c85c7e2cb731d710d96057b6.diff LOG

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146909 >From 9963727a56237f9424642bb1cc12e800640fbd0e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 3 Jul 2025 16:07:11 +0100 Subject: [PATCH 1/4] [lldb][DataFormatter] Format libstdc++ unique_ptr like we

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146909 >From 9963727a56237f9424642bb1cc12e800640fbd0e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 3 Jul 2025 16:07:11 +0100 Subject: [PATCH 1/5] [lldb][DataFormatter] Format libstdc++ unique_ptr like we

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146578 >From a0ebe1e710c56ddc8108758ee461c1a934021337 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 10:38:22 -0700 Subject: [PATCH 1/3] [lldb] Take a sledgehammer approach to resizing the

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-07-03 Thread via lldb-commits
athierry-oct wrote: I've just pushed a new version that moves the pending events from the previous listener to the hijack listener when hijacking, and vice-versa when restoring the previous listener. In the patch: - Transferring the events between listeners is done atomically with adding/rem

[Lldb-commits] [lldb] [LLDB] Mark TestCallStdStringFunction as XPASS on Windows (PR #146835)

2025-07-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: We saw the same thing on Windows on Arm. https://github.com/llvm/llvm-project/pull/146835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Mark TestCallStdStringFunction as XPASS on Windows (PR #146835)

2025-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/146835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Mark TestCallStdStringFunction as XPASS on Windows (PR #146835)

2025-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/146835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 94d8231 - [LLDB] Mark TestCallStdStringFunction as XPASS on Windows (#146835)

2025-07-03 Thread via lldb-commits
Author: nerix Date: 2025-07-03T10:12:23+01:00 New Revision: 94d8231578272ead668bb95f8cb9c3ff5ee15aa6 URL: https://github.com/llvm/llvm-project/commit/94d8231578272ead668bb95f8cb9c3ff5ee15aa6 DIFF: https://github.com/llvm/llvm-project/commit/94d8231578272ead668bb95f8cb9c3ff5ee15aa6.diff LOG: [L

[Lldb-commits] [lldb] [LLDB] Mark TestCallStdStringFunction as XPASS on Windows (PR #146835)

2025-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/146835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr (PR #146686)

2025-07-03 Thread Hemang Gadhavi via lldb-commits
@@ -416,12 +416,8 @@ void DWARFFormValue::Dump(Stream &s) const { case DW_FORM_ref_addr: { assert(m_unit); // Unit must be valid for DW_FORM_ref_addr objects or we // will get this wrong -if (m_unit->GetVersion() <= 2) - DumpAddress(s.AsRawOst

[Lldb-commits] [lldb] 4017dc0 - [lldb][Commands][NFC] image lookup: remove unused local variable (#146554)

2025-07-03 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-03T10:28:49+01:00 New Revision: 4017dc06e3b5c4b97d8b1089070f88363e0db6f0 URL: https://github.com/llvm/llvm-project/commit/4017dc06e3b5c4b97d8b1089070f88363e0db6f0 DIFF: https://github.com/llvm/llvm-project/commit/4017dc06e3b5c4b97d8b1089070f88363e0db6f0.diff

[Lldb-commits] [lldb] 58d84a6 - [lldb][DWARF][NFC] Reduce scope of ref_addr_size variable (#146557)

2025-07-03 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-03T10:28:38+01:00 New Revision: 58d84a615e9180eeff583a9d30033ba21343550d URL: https://github.com/llvm/llvm-project/commit/58d84a615e9180eeff583a9d30033ba21343550d DIFF: https://github.com/llvm/llvm-project/commit/58d84a615e9180eeff583a9d30033ba21343550d.diff

[Lldb-commits] [lldb] [lldb][Commands][NFC] image lookup: remove unused local variable (PR #146554)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/146554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF][NFC] Reduce scope of ref_addr_size variable (PR #146557)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/146557 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-03 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Sorry, I was out yesterday. I think this is an okay, though not really satisfying solution (it could be you resized the window to see more of your history). To see if we can handle this uniformly, I guess we'd need to start by cataloguing t

[Lldb-commits] [lldb] [lldb][test] Turn std::chrono libcxx test generic (PR #146873)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146873 >From ab25e46ff0e66a84b682bbdacbb90d5472507599 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 3 Jul 2025 11:30:59 +0100 Subject: [PATCH 1/2] [lldb][test] Turn std::chrono libcxx test generic Split ou

[Lldb-commits] [lldb] [lldb][test] Run generic set formatter test-case on specified STL (PR #146882)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/146882 Previously the parameter wasn't respected. So we would only run the test with whatever stdlib the `Makefile.rules` deduced. Confirmed that ``` lldb-dotest -p TestDataFormatterGenericSet.py --category libstdc

[Lldb-commits] [lldb] [lldb][test] Run generic set formatter test-case on specified STL (PR #146882)

2025-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Previously the parameter wasn't respected. So we would only run the test with whatever stdlib the `Makefile.rules` deduced. Confirmed that ``` lldb-dotest -p TestDataFormatterGenericSet.py --category libst

[Lldb-commits] [lldb] [lldb][test] Consolidate libstdc++ and libc++ vector formatter tests into generic test (PR #146885)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146885 >From 256fa94d299e65d6e28e9bbbcf33bb2c122eec90 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 3 Jul 2025 15:04:57 +0100 Subject: [PATCH 1/2] [lldb][test] Consolidate libstdc++ and libc++ vector forma

[Lldb-commits] [lldb] a88e286 - [lldb][test] Consolidate libstdc++ and libc++ vector formatter tests into generic test (#146885)

2025-07-03 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-03T15:44:40+01:00 New Revision: a88e286aefbf25d504239badaa1a908c0a56c78e URL: https://github.com/llvm/llvm-project/commit/a88e286aefbf25d504239badaa1a908c0a56c78e DIFF: https://github.com/llvm/llvm-project/commit/a88e286aefbf25d504239badaa1a908c0a56c78e.diff

[Lldb-commits] [lldb] [lldb][test] Consolidate libstdc++ and libc++ vector formatter tests into generic test (PR #146885)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/146885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/146909 The only difference is that with libc++ the summary string contains the derefernced pointer value. With libstdc++ we currently display the pointer itself, which seems redundant. E.g., ``` (std::unique_ptr) i

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes The only difference is that with libc++ the summary string contains the derefernced pointer value. With libstdc++ we currently display the pointer itself, which seems redundant. E.g., ``` (std::unique_ptr<

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread Michael Buch via lldb-commits
@@ -55,6 +55,12 @@ void AddFilter(TypeCategoryImpl::SharedPointer category_sp, std::optional ExtractIndexFromString(const char *item_name); +/// Returns \c false if the smart pointer formatters shouldn't continue +/// formatting the rest of the object. Currently this is the c

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/146909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-03 Thread via lldb-commits
@@ -251,6 +251,44 @@ const lldb::TargetSP Breakpoint::GetTargetSP() { bool Breakpoint::IsInternal() const { return LLDB_BREAK_ID_IS_INTERNAL(m_bid); } +llvm::Error Breakpoint::SetIsHardware(bool is_hardware) { + if (is_hardware == m_hardware) +return llvm::Error::succes

[Lldb-commits] [lldb] [lldb] fix incorrect logging message (PR #146903)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/146903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2f75f65 - [lldb] Take a sledgehammer approach to resizing the statusline (#146578)

2025-07-03 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-03T10:21:49-07:00 New Revision: 2f75f658b18aed4bbcab391063bceb7ccaf8a6ec URL: https://github.com/llvm/llvm-project/commit/2f75f658b18aed4bbcab391063bceb7ccaf8a6ec DIFF: https://github.com/llvm/llvm-project/commit/2f75f658b18aed4bbcab391063bceb7ccaf8a6ec.d

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/146578 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improving 'variables' hover requests. (PR #146773)

2025-07-03 Thread via lldb-commits
jimingham wrote: I don't know how you are doing this, but if you are treating "hover over" requests as expressions and presenting the result of some real expression evaluation, you have to be quite careful about what you evaluate. For instance, you want to make sure that hovering over ` i++

[Lldb-commits] [lldb] 8d3dbdb - [lldb] fix incorrect logging message (#146903)

2025-07-03 Thread via lldb-commits
Author: Charles Zablit Date: 2025-07-03T18:22:42+01:00 New Revision: 8d3dbdb00f8f4b4953a7e2a13906dc3fce635d5d URL: https://github.com/llvm/llvm-project/commit/8d3dbdb00f8f4b4953a7e2a13906dc3fce635d5d DIFF: https://github.com/llvm/llvm-project/commit/8d3dbdb00f8f4b4953a7e2a13906dc3fce635d5d.diff

[Lldb-commits] [lldb] [lldb] fix incorrect logging message (PR #146903)

2025-07-03 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/146903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1725cc0 - [lldb] Remove unused `hardware` argument (NFC)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-03T14:37:05-07:00 New Revision: 1725cc025e8faa8dc0fd8799bc277e2c0f0f8c1c URL: https://github.com/llvm/llvm-project/commit/1725cc025e8faa8dc0fd8799bc277e2c0f0f8c1c DIFF: https://github.com/llvm/llvm-project/commit/1725cc025e8faa8dc0fd8799bc277e2c0f0f8c1c.d

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/146966 Can now limit the number of modules fetched. Show the non-standard `debugInfoSize` field in the vs-code extension. Update tests to fix silently failing test and handle when a module is removed. >From c98a51

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes Can now limit the number of modules fetched. Show the non-standard `debugInfoSize` field in the vs-code extension. Update tests to fix silently failing test and handle when a module is removed. --- Patch

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-03 Thread Ebuka Ezike via lldb-commits
da-viper wrote: Not to sure if I should split it into different PR since they are all module related. https://github.com/llvm/llvm-project/pull/146966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb] Fixing warnings / win32 builds in MainLoop. (PR #146632)

2025-07-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: We have the same one, I'll take care of it. https://github.com/llvm/llvm-project/pull/146632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)

2025-07-03 Thread Michael Buch via lldb-commits
Michael137 wrote: > I'd probably do this one data structure at a time -- merge the tests and > tweak the formatters so that they produce uniform output. Thankfully, today > we at least have presubmits to test these out easily. Doing this piecemeal sounds good to me! https://github.com/llvm/ll

[Lldb-commits] [lldb] [lldb][test] Turn std::atomic libcxx test generic (PR #146843)

2025-07-03 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/146843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-03 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/143177 >From cf6e5cb6ff2ea6ababebcc215fc51fdd6caaa134 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Wed, 18 Jun 2025 21:49:16 +0200 Subject: [PATCH] [LLDB] Add type summaries for MSVC STL strings --- lldb/packages/Pyt

[Lldb-commits] [lldb] [LLDB] Optimize identifier lookup in DIL (PR #146094)

2025-07-03 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd closed https://github.com/llvm/llvm-project/pull/146094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 03aa5c0 - [LLDB] Optimize identifier lookup in DIL (#146094)

2025-07-03 Thread via lldb-commits
Author: Ilia Kuklin Date: 2025-07-03T19:15:16+05:00 New Revision: 03aa5c0a9e7125c6547c551389a86dd70b2408f0 URL: https://github.com/llvm/llvm-project/commit/03aa5c0a9e7125c6547c551389a86dd70b2408f0 DIFF: https://github.com/llvm/llvm-project/commit/03aa5c0a9e7125c6547c551389a86dd70b2408f0.diff L

[Lldb-commits] [lldb] [lldb] fix incorrect logging message (PR #146903)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/146903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6440b10 - [lldb] Remove PRIuFT macro and use LLDB_LOG instead (#146867)

2025-07-03 Thread via lldb-commits
Author: David Spickett Date: 2025-07-03T15:30:39+01:00 New Revision: 6440b1028220955c510c7325bb6e27dc293f711a URL: https://github.com/llvm/llvm-project/commit/6440b1028220955c510c7325bb6e27dc293f711a DIFF: https://github.com/llvm/llvm-project/commit/6440b1028220955c510c7325bb6e27dc293f711a.diff

[Lldb-commits] [lldb] [lldb] Remove PRIuFT macro and use LLDB_LOG instead (PR #146867)

2025-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/146867 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Sorry, I was out yesterday. No worries and I'm sorry for rushing you. > I think this is an okay, though not really satisfying solution (it could be > you resized the window to see more of your history). To see if we can handle > this uniformly, I guess we'd need to start

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-07-03 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,15 @@ +# Disabling until the lldb-rpc-gen tool lands. +UNSUPPORTED: system-windows, system-linux, system-darwin chelcassanova wrote: I think it would actually be possible to just land this patch for now and then reenable these tests when the tool land

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/146963 LLDB has the concept of an "SDK root", which expresses where the system libraries and so which are necessary for debugging can be found. On POSIX platforms, the SDK root is just the root of the file syste

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes LLDB has the concept of an "SDK root", which expresses where the system libraries and so which are necessary for debugging can be found. On POSIX platforms, the SDK root is just the root of the file sy

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/146963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
@@ -39,6 +39,7 @@ class HostInfoPosix : public HostInfoBase { static llvm::VersionTuple GetOSVersion(); static std::optional GetOSBuildString(); + static llvm::Expected GetSDKRoot(SDKOptions options); JDevlieghere wrote: Why not a `FileSpec`? https://gi

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/include/lldb/Host/posix/HostInfoPosix.h lldb/

[Lldb-commits] [lldb] 17cb0a7 - [lldb][docs] Fix another broken markdown link

2025-07-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-03T14:19:09-07:00 New Revision: 17cb0a73a0542da3477ac94c3fddfa05c20888f8 URL: https://github.com/llvm/llvm-project/commit/17cb0a73a0542da3477ac94c3fddfa05c20888f8 DIFF: https://github.com/llvm/llvm-project/commit/17cb0a73a0542da3477ac94c3fddfa05c20888f8.d

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Adrian Prantl via lldb-commits
@@ -39,6 +39,7 @@ class HostInfoPosix : public HostInfoBase { static llvm::VersionTuple GetOSVersion(); static std::optional GetOSBuildString(); + static llvm::Expected GetSDKRoot(SDKOptions options); adrian-prantl wrote: That's existing API. https://gi

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread via lldb-commits
CodingCarpincho wrote: 👍🏼 https://github.com/llvm/llvm-project/pull/146963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/146963 >From 16b7748cf38aaade5185a1073d2755abb2c40d12 Mon Sep 17 00:00:00 2001 From: CodingCarpincho Date: Thu, 3 Jul 2025 13:54:46 -0700 Subject: [PATCH] Use the root directory as the SDK root on POSIX platforms

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread via lldb-commits
@@ -39,6 +39,7 @@ class HostInfoPosix : public HostInfoBase { static llvm::VersionTuple GetOSVersion(); static std::optional GetOSBuildString(); + static llvm::Expected GetSDKRoot(SDKOptions options); CodingCarpincho wrote: To put it simply, because the

[Lldb-commits] [lldb] 0b98b27 - Use the root directory as the SDK root on POSIX platforms

2025-07-03 Thread Adrian Prantl via lldb-commits
Author: CodingCarpincho Date: 2025-07-03T14:20:31-07:00 New Revision: 0b98b27930dad5ff59de050605c3f101330a2b5c URL: https://github.com/llvm/llvm-project/commit/0b98b27930dad5ff59de050605c3f101330a2b5c DIFF: https://github.com/llvm/llvm-project/commit/0b98b27930dad5ff59de050605c3f101330a2b5c.dif

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/146963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: I pushed this manually as 0b98b27930da. https://github.com/llvm/llvm-project/pull/146963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Support disassembling RISC-V proprietary instructions (PR #145793)

2025-07-03 Thread via lldb-commits
https://github.com/tedwoodward updated https://github.com/llvm/llvm-project/pull/145793 >From 1a7ee4297bb8e6b3fa08818e05cf245a2c768c2b Mon Sep 17 00:00:00 2001 From: Ted Woodward Date: Wed, 25 Jun 2025 14:22:28 -0700 Subject: [PATCH 1/3] Support disassembling RISC-V proprietary insns RISC-V su

[Lldb-commits] [lldb] [llvm] [lldb] Support disassembling RISC-V proprietary instructions (PR #145793)

2025-07-03 Thread via lldb-commits
tedwoodward wrote: @DavidSpickett @jasonmolenda I uploaded a new change. It has: - Use the exe_ctx version of python command, and HandleCommand - Set a variable max_byte_width, and use that instead if "max_opcode_byte_size * 3 + 1" in 3 different places - Split up RISCVPrettyPrinter comment, pu

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-03 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/138031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1995fd9 - [lldb] Extract DW_OP_deref evaluation code (NFC) (#146801)

2025-07-03 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-03T13:46:47-07:00 New Revision: 1995fd9ac6be4ff0822589f00d5fcaa12688eb87 URL: https://github.com/llvm/llvm-project/commit/1995fd9ac6be4ff0822589f00d5fcaa12688eb87 DIFF: https://github.com/llvm/llvm-project/commit/1995fd9ac6be4ff0822589f00d5fcaa12688eb87.d

[Lldb-commits] [lldb] [lldb] Extract DW_OP_deref evaluation code (NFC) (PR #146801)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/146801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][mcp] Skip MCPUnixSocketCommandTestCase if remote (PR #146807)

2025-07-03 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > I think you're looking for `@skipIf(hostoslist=["windows"])` Yes, it looks more correct. But can a Unix socket be used for a remote connection? https://github.com/llvm/llvm-project/pull/146807 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [lldb] Extract DW_OP_deref evaluation code (NFC) (PR #146801)

2025-07-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/146801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][framework] Copy framework files correctly (PR #146425)

2025-07-03 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/146425 >From 7b11f001e18d0f8d641448cac63181c9ed3c33e8 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 30 Jun 2025 14:51:43 -0700 Subject: [PATCH] [lldb][framework] Copy framework files correctly A bu

[Lldb-commits] [lldb] [lldb][framework] Copy framework files correctly (PR #146425)

2025-07-03 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Ok I was being way overkill with this patch, I updated it so that the script creates the output directories if it doesn't exist. https://github.com/llvm/llvm-project/pull/146425 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/146909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/un

[Lldb-commits] [lldb] [lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (PR #146909)

2025-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146909 >From 9963727a56237f9424642bb1cc12e800640fbd0e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 3 Jul 2025 16:07:11 +0100 Subject: [PATCH 1/2] [lldb][DataFormatter] Format libstdc++ unique_ptr like we

[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for Memory64 RVA in Minidump (+ Testing changes) (PR #146777)

2025-07-03 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Optimize identifier lookup in DIL (PR #146094)

2025-07-03 Thread Michael Buch via lldb-commits
Michael137 wrote: Looks like this is failing on macOS CI: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/28857/execution/node/106/log/?consoleFull ``` 14:41:07 FAIL: test_frame_var (TestFrameVarDILGlobalVariableLookup.TestFrameVarDILGlobalVariableLookup) 14:41:07

[Lldb-commits] [lldb] [lldb] Extract DW_OP_deref evaluation code (NFC) (PR #146801)

2025-07-03 Thread Adrian Prantl via lldb-commits
@@ -860,6 +860,64 @@ ResolveLoadAddress(ExecutionContext *exe_ctx, lldb::ModuleSP &module_sp, return load_addr; } +static llvm::Error Evaluate_DW_OP_deref(DWARFExpression::Stack &stack, +ExecutionContext *exe_ctx, +

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146602 >From 6b5d9075cf7b1e6aec0b4969695f88613e715783 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 16:02:21 -0700 Subject: [PATCH] [lldb] Add SB API to make a breakpoint a hardware breakp

[Lldb-commits] [lldb] [lldb] Extract DW_OP_deref evaluation code (NFC) (PR #146801)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146801 >From 1e71640c0bb0e3a680adf12679df6cbeda6c3aed Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 2 Jul 2025 15:31:54 -0700 Subject: [PATCH 1/2] [lldb] Extract DW_OP_deref evaluation code (NFC) Th

[Lldb-commits] [lldb] [lldb][test] Turn std::chrono libcxx test generic (PR #146873)

2025-07-03 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/146873 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Consolidate libstdc++ and libc++ vector formatter tests into generic test (PR #146885)

2025-07-03 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/146885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Consolidate libstdc++ and libc++ vector formatter tests into generic test (PR #146885)

2025-07-03 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,40 @@ +#include +#include +#include +typedef std::vector int_vect; +typedef std::vector string_vect; + +template +void by_ref_and_ptr(std::vector &ref, std::vector *ptr) { + // Stop here to check by ref + return; +} + +int main() { + int_vect numbers; + (numbers

[Lldb-commits] [lldb] [lldb][test] Run generic set formatter test-case on specified STL (PR #146882)

2025-07-03 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/146882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for Memory64 RVA in Minidump (+ Testing changes) (PR #146777)

2025-07-03 Thread via lldb-commits
jeffreytan81 wrote: Can you please split the PR into two? One for improving testing/diagnosibility, the other for the real fix? https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-03 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/146602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-03 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From 761601040deae05ab7aa5314c09af5a47d92662b Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] [lldb-dap] Improving 'variables' hover requests. (PR #146773)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I don't know how you are doing this, but if you are treating "hover over" > requests as expressions and presenting the result of some real expression > evaluation, you have to be quite careful about what you evaluate. The corresponding DAP request is called "expression" w

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-03 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: The last test failure happening was this: ``` https://github.com/llvm/llvm-project/pull/138031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   3   >