[Lldb-commits] [lldb] [lldb] Fix evaluating expressions without JIT in an object context (PR #145599)

2025-06-25 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/145599 >From fac89bb1b51496761b156f22dcff85cbe86bf9d2 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Mon, 23 Jun 2025 23:39:52 -0700 Subject: [PATCH 1/2] [lldb] Fix evaluating expressions without JIT in an object

[Lldb-commits] [lldb] [lldb] make PlatformAndroid/AdbClient::GetSyncService threadsafe (PR #145382)

2025-06-25 Thread Chad Smith via lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb][target] Add progress report for wait-attaching to proc… (PR #145111)

2025-06-25 Thread David Spickett via lldb-commits
@@ -16,6 +16,28 @@ def setUp(self): self.broadcaster, lldb.SBDebugger.eBroadcastBitProgress ) +def test_wait_attach_progress_reporting(self): +"""Test that progress reports for wait attaching work as intended.""" +target = self.dbg.Creat

[Lldb-commits] [lldb] 97b8cec - [lldb][lldb-dap] Skip runInTerminalWithObjectEnv test on Windows

2025-06-25 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-06-25T09:31:06Z New Revision: 97b8cec789fe3b8558a6d2b7fac269c5606ab4a3 URL: https://github.com/llvm/llvm-project/commit/97b8cec789fe3b8558a6d2b7fac269c5606ab4a3 DIFF: https://github.com/llvm/llvm-project/commit/97b8cec789fe3b8558a6d2b7fac269c5606ab4a3.diff LOG

[Lldb-commits] [lldb] [lldb-dap][test] Refactor runInTerminal Tests. (PR #144954)

2025-06-25 Thread Michael Buch via lldb-commits
Michael137 wrote: These tests are failing on the macOS sanitized bot bot. First failure started here: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-sanitized/1858/execution/node/89/log/ This patch is in the changelist. @da-viper mind taking a look? Or should we skip this on

[Lldb-commits] [lldb] Default transcript dumping in "statistics dump" to false (PR #145436)

2025-06-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM Any chance we could add a test for the warning? https://github.com/llvm/llvm-project/pull/145436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb-dap][test] Refactor runInTerminal Tests. (PR #144954)

2025-06-25 Thread Michael Buch via lldb-commits
Michael137 wrote: Happy to skip on ASAN (we already do that due to timeout issues in other tests) https://github.com/llvm/llvm-project/pull/144954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [lldb-dap][test] Refactor runInTerminal Tests. (PR #144954)

2025-06-25 Thread Michael Buch via lldb-commits
Michael137 wrote: I think ASAN just makes it more likely for things to time out https://github.com/llvm/llvm-project/pull/144954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: Is there a test-plan for DWARF64? Is there a buildbot running the test-suite with DWARF64 somewhere? https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread David Spickett via lldb-commits
@@ -1073,20 +1073,7 @@ const lldb_private::DWARFDataExtractor &DWARFUnit::GetData() const { : m_dwarf.GetDWARFContext().getOrLoadDebugInfoData(); } -uint32_t DWARFUnit::GetHeaderByteSize() const { - switch (m_header.getUnitType()) { - case llvm::dwarf::DW_UT_co

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread Michael Buch via lldb-commits
@@ -121,8 +124,12 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor &data, assert(m_unit); if (m_unit->GetVersion() <= 2) ref_addr_size = m_unit->GetAddressByteSize(); - else -ref_addr_size = 4; + else { +if (m_unit->Ge

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread David Spickett via lldb-commits
@@ -165,26 +172,27 @@ static FormSize g_form_sizes[] = { {1, 1}, // 0x0b DW_FORM_data1 {1, 1}, // 0x0c DW_FORM_flag {0, 0}, // 0x0d DW_FORM_sdata -{1, 4}, // 0x0e DW_FORM_strp +{0, 0}, // 0x0e DW_FORM_strp (4 bytes for DWARF32, 8 bytes for DWARF64) {0,

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][test] Refactor runInTerminal Tests. (PR #144954)

2025-06-25 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > This patch is in the changelist. @da-viper mind taking a look? Or should we > skip this on ASAN? The test most likely was not running on previous builds (because of the binary size check) now it get caught. It does not look like an ASAN problem but I am running a local build

[Lldb-commits] [lldb] [lldb-dap][test] Refactor runInTerminal Tests. (PR #144954)

2025-06-25 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > Happy to skip on ASAN (we already do that due to timeout issues in other > tests) Happy with that. https://github.com/llvm/llvm-project/pull/144954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread Hemang Gadhavi via lldb-commits
@@ -165,26 +172,27 @@ static FormSize g_form_sizes[] = { {1, 1}, // 0x0b DW_FORM_data1 {1, 1}, // 0x0c DW_FORM_flag {0, 0}, // 0x0d DW_FORM_sdata -{1, 4}, // 0x0e DW_FORM_strp +{0, 0}, // 0x0e DW_FORM_strp (4 bytes for DWARF32, 8 bytes for DWARF64) {0,

[Lldb-commits] [lldb] [lldb] Fix qEcho message handling. (PR #145675)

2025-06-25 Thread via lldb-commits
https://github.com/eleviant created https://github.com/llvm/llvm-project/pull/145675 This fixes issues found in e066f35c6981c720e3a7e5883efc40c861b3b7, which was later reverted. The problem was with "k" message which was sent with sync_on_timeout flag set to true, so lldb was waiting for respo

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-25 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/145706 .. from the guts of GDBRemoteCommunication to ~top level. This is motivated by #131519 and by the fact that's impossible to guess whether the author of a symlink intended it to be a "convenience shortcut" -- mea

[Lldb-commits] [lldb] [lldb][docs] Document qWatchpointSupportInfo (PR #145709)

2025-06-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: As far as I can tell this is only used as a binary to tell if we have any hardware breakpoints, or none. Even though the packet returns the exact number. https://github.com/llvm/llvm-project/pull/145709 ___ lldb-commits mailing li

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > Also wondering about testing this. What tools can produce DWARF64? > @DavidSpickett answer to your question, we can produce `DWARF64` by enabling -`gdwarf64` clang compilation flag. But that could be different for different compiler > Run `check-lldb` with DWARF64 ena

[Lldb-commits] [lldb] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supply registers (PR #144627)

2025-06-25 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/144627 >From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 17 Jun 2025 18:57:11 -0700 Subject: [PATCH 01/10] [lldb][Mach-O] Allow "process metadata" LC_NOTE to s

[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-25 Thread Pavel Labath via lldb-commits
labath wrote: @yuvald-sweet-security https://github.com/llvm/llvm-project/pull/145706 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread Michael Buch via lldb-commits
@@ -121,8 +124,12 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor &data, assert(m_unit); if (m_unit->GetVersion() <= 2) ref_addr_size = m_unit->GetAddressByteSize(); - else -ref_addr_size = 4; + else { +if (m_unit->Ge

[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes .. from the guts of GDBRemoteCommunication to ~top level. This is motivated by #131519 and by the fact that's impossible to guess whether the author of a symlink intended it to be a "convenience shortcut" --

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/145616 >From 5ed60a3aa5022694a593e2885ad6e563df6ffa37 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 24 Jun 2025 16:22:46 -0700 Subject: [PATCH 1/2] [lldb] Make MCP server instance global Rather than

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/145616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add DWARFExpressionEntry and GetExpressionEntryAtAddress() to … (PR #144238)

2025-06-25 Thread Adrian Prantl via lldb-commits
@@ -58,6 +59,19 @@ class DWARFExpressionList { } lldb::addr_t GetFuncFileAddress() { return m_func_file_addr; } + + /// Represents an entry in the DWARFExpressionList with all needed metadata. + struct DWARFExpressionEntry { +AddressRange file_range; /// Represents

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yeah to my surprise it's `re.search` not `re.match`. Makes sense in hindsight though. https://github.com/llvm/llvm-project/pull/127505 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: >Thats what I need suggestions and inputs what changes we can accommodate to >better support the DWARF64. Start by looking at the main differences DWARF64 has. Write DWARF64 specific tests that cover those corner cases e.g. that some symbol can now be described as a great

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread Pavel Labath via lldb-commits
labath wrote: Also note that there are remnants of our previous attempt at dwarf64 support (which was deleted many years ago) lying around the DWARFDataExtractor class. However, since this isn't how *llvm*'s DWARFDataExtractor works, I think we should not be using that (instead, we should dele

[Lldb-commits] [lldb] [lldb] include `LLVMTargetParser` in `LINK_COMPONENTS` (PR #145606)

2025-06-25 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit approved this pull request. https://github.com/llvm/llvm-project/pull/145606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread Pavel Labath via lldb-commits
@@ -121,8 +124,12 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor &data, assert(m_unit); if (m_unit->GetVersion() <= 2) ref_addr_size = m_unit->GetAddressByteSize(); - else -ref_addr_size = 4; + else { +if (m_unit->Ge

[Lldb-commits] [lldb] [lldb] Clean up GDBRemoteCommunication::StartDebugserverProcess (PR #145021)

2025-06-25 Thread Pavel Labath via lldb-commits
@@ -1084,55 +1052,30 @@ Status GDBRemoteCommunication::StartDebugserverProcess( if (socket_pipe.CanWrite()) socket_pipe.CloseWriteFileDescriptor(); - if (socket_pipe.CanRead()) { -// Read port from pipe with 10 second timeout. -std::string port_str; -while (

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread Hemang Gadhavi via lldb-commits
@@ -1073,20 +1073,7 @@ const lldb_private::DWARFDataExtractor &DWARFUnit::GetData() const { : m_dwarf.GetDWARFContext().getOrLoadDebugInfoData(); } -uint32_t DWARFUnit::GetHeaderByteSize() const { - switch (m_header.getUnitType()) { - case llvm::dwarf::DW_UT_co

[Lldb-commits] [lldb] [lldb] Remove child_process_inherit argument from Pipe (PR #145516)

2025-06-25 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/145516 >From 598b2f3f89fd3b09ab40f1ca0417e7158bae3488 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Sun, 20 Oct 2024 00:18:56 +0200 Subject: [PATCH] [lldb] Remove child_process_inherit argument from Pipe It's not n

[Lldb-commits] [lldb] [lldb-dap] Fix flaky test (PR #145231)

2025-06-25 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/145231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread John Harrison via lldb-commits
@@ -72,10 +80,46 @@ LLDBCommandTool::Call(const llvm::json::Value &args) { return text_result; } -std::optional LLDBCommandTool::GetSchema() const { +std::optional CommandTool::GetSchema() const { + llvm::json::Object id_type{{"type", "number"}}; llvm::json::Object str_t

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread John Harrison via lldb-commits
@@ -72,10 +80,46 @@ LLDBCommandTool::Call(const llvm::json::Value &args) { return text_result; } -std::optional LLDBCommandTool::GetSchema() const { +std::optional CommandTool::GetSchema() const { + llvm::json::Object id_type{{"type", "number"}}; llvm::json::Object str_t

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread John Harrison via lldb-commits
@@ -7,20 +7,23 @@ //===--===// #include "Tool.h" +#include "lldb/Core/Module.h" #include "lldb/Interpreter/CommandInterpreter.h" #include "lldb/Interpreter/CommandReturnObject.h" using namespace lldb_pri

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread John Harrison via lldb-commits
@@ -37,20 +37,26 @@ class Tool { std::string m_description; }; -class LLDBCommandTool : public mcp::Tool { +class CommandTool : public mcp::Tool { public: - LLDBCommandTool(std::string name, std::string description, - Debugger &debugger); - ~LLDBCommandTo

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread Jonas Devlieghere via lldb-commits
@@ -72,10 +80,46 @@ LLDBCommandTool::Call(const llvm::json::Value &args) { return text_result; } -std::optional LLDBCommandTool::GetSchema() const { +std::optional CommandTool::GetSchema() const { + llvm::json::Object id_type{{"type", "number"}}; llvm::json::Object str_t

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread Jonas Devlieghere via lldb-commits
@@ -72,10 +80,46 @@ LLDBCommandTool::Call(const llvm::json::Value &args) { return text_result; } -std::optional LLDBCommandTool::GetSchema() const { +std::optional CommandTool::GetSchema() const { + llvm::json::Object id_type{{"type", "number"}}; llvm::json::Object str_t

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: Clang only supports DWARF64 for ELF: ``` def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Visibility<[ClangOption, CC1Option, CC1AsOption]>, HelpText<"Enables DWARF64 format for ELF binaries, if debug information emission is enabled.">, MarshallingInfoFlag>; ``` So the e

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread Jonas Devlieghere via lldb-commits
@@ -37,20 +37,26 @@ class Tool { std::string m_description; }; -class LLDBCommandTool : public mcp::Tool { +class CommandTool : public mcp::Tool { public: - LLDBCommandTool(std::string name, std::string description, - Debugger &debugger); - ~LLDBCommandTo

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread Jonas Devlieghere via lldb-commits
@@ -72,10 +80,46 @@ LLDBCommandTool::Call(const llvm::json::Value &args) { return text_result; } -std::optional LLDBCommandTool::GetSchema() const { +std::optional CommandTool::GetSchema() const { + llvm::json::Object id_type{{"type", "number"}}; llvm::json::Object str_t

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-25 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I think the PR is close to finish, except the "how to make sure hello.cpp > builds in Windows" question. Does this test need to build on Windows? That test should only run on Darwin, so if it's properly skipped, we shouldn't even try to build the inferior. The Windows-co

[Lldb-commits] [lldb] [lldb] Fix qEcho message handling. (PR #145675)

2025-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (eleviant) Changes This fixes issues found in e066f35c6981c720e3a7e5883efc40c861b3b7, which was later reverted. The problem was with "k" message which was sent with sync_on_timeout flag set to true, so lldb was waiting for response, w

[Lldb-commits] [lldb] [lldb][docs] Document qWatchpointSupportInfo (PR #145709)

2025-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/145709.diff 1 Files Affected: - (modified) lldb/docs/resources/lldbgdbremote.md (+17) ``diff diff --git a/lldb/docs/resources/lld

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-25 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/139174 >From d98210b81f7b49f5384e968b1a18e00e432aaf2c Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 8 May 2025 16:21:53 -0700 Subject: [PATCH 1/7] Fix macOS FindProcessImpl() --- lldb/source/Host/macosx/objcxx/H

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-06-25 Thread via lldb-commits
athierry-oct wrote: Thanks for the feedback and the good discussion! > I think I understand most of what you're saying, and I think the proposed > solution may solve the problem you have in mind -- but I don't think it can > solve the problem I have in mind (and I'm not sure which of those is

[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-25 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/145706 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/145616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Document qWatchpointSupportInfo (PR #145709)

2025-06-25 Thread Alex Langford via lldb-commits
@@ -1998,6 +1998,23 @@ threads (live system debug) / cores (JTAG) in your program have stopped and allows LLDB to display and control your program correctly. +## qWatchpointSupportInfo + +Get the number of hardware watchpoints available on the remote target. + +``` +send pack

[Lldb-commits] [lldb] [lldb] Fix AppleObjCDeclVendor for classes which have no methods (PR #145452)

2025-06-25 Thread Alex Langford via lldb-commits
@@ -552,10 +552,9 @@ bool ClassDescriptorV2::Describe( } else { std::optional base_method_list = GetMethodList(process, class_ro->m_baseMethods_ptr); - if (!base_method_list) -return false; - if (!ProcessMethodList(instance_method_func, *ba

[Lldb-commits] [lldb] e8abdfc - [lldb] Make MCP server instance global (#145616)

2025-06-25 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-06-25T13:46:33-07:00 New Revision: e8abdfc88ffed632750fe0fd7deafb577e902bd6 URL: https://github.com/llvm/llvm-project/commit/e8abdfc88ffed632750fe0fd7deafb577e902bd6 DIFF: https://github.com/llvm/llvm-project/commit/e8abdfc88ffed632750fe0fd7deafb577e902bd6.d

[Lldb-commits] [lldb] [lldb] Remove child_process_inherit argument from Pipe (PR #145516)

2025-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes It's not necessary on posix platforms as of #126935 and it's ignored on windows as of #138896. For both platforms, we have a better way of inheriting FDs/HANDLEs. --- Patch is 22.46 KiB, truncated to 20.00 K

[Lldb-commits] [lldb] [lldb] Clean up GDBRemoteCommunication::StartDebugserverProcess (PR #145021)

2025-06-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/145021 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Defend against infinite recursion in GetClassDescriptor (PR #145396)

2025-06-25 Thread Adrian Prantl via lldb-commits
@@ -421,6 +422,10 @@ class AppleObjCRuntimeV2 : public AppleObjCRuntime { lldb::addr_t GetISAHashTablePointer(); + using ValueObjectSet = llvm::SmallSet; adrian-prantl wrote: `llvm::SmallPtrSet`? https://github.com/llvm/llvm-project/pull/145396 _

[Lldb-commits] [lldb] [LLDB] Update DIL to handle smart pointers; add more tests. (PR #143786)

2025-06-25 Thread via lldb-commits
cmtice wrote: I've tried to move most of the tests around as you suggested. I have kept the dil smart pointer tests separate from the existing stl tests (although I moved them over to the data-formattter-stl/libcxx tree). They do test functionality that the

[Lldb-commits] [lldb] [lldb] Fix evaluating expressions without JIT in an object context (PR #145599)

2025-06-25 Thread Igor Kudrin via lldb-commits
@@ -321,7 +321,8 @@ IRMemoryMap::Allocation::Allocation(lldb::addr_t process_alloc, lldb::addr_t IRMemoryMap::Malloc(size_t size, uint8_t alignment, uint32_t permissions, AllocationPolicy policy, - bool zero_mem

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/145616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add SI_USER and SI_KERNEL to Linux signals (PR #144800)

2025-06-25 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/144800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] make PlatformAndroid/AdbClient::GetSyncService threadsafe (PR #145382)

2025-06-25 Thread Chad Smith via lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-25 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > I'd be alright with it going in a follow-up. That being said, it would be > easy to kick this can down the road. Let's figure out a way to make this > happen without blocking this PR. I think that this should be addressed in a follow-up PR, mainly because I think change

[Lldb-commits] [lldb] [lldb] Fix evaluating expressions without JIT in an object context (PR #145599)

2025-06-25 Thread via lldb-commits
jimingham wrote: It isn't terribly important. We are switching to returning expected so if you think that looks nicer, feel free to do that. But otherwise, this is fine as it. https://github.com/llvm/llvm-project/pull/145599 ___ lldb-commits maili

[Lldb-commits] [lldb] [lldb] Fix evaluating expressions without JIT in an object context (PR #145599)

2025-06-25 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: > But we do support scalar persistent expression results in core files > currently: > > (lldb) expr int $my_int = 5 (lldb) expr $my_int * 2 (int) $0 = 10 > > and that should still work after your change. I see no reason why it > wouldn't, but it would be good to add some use

[Lldb-commits] [lldb] [lldb][NFC] remove the ResolveSDKPathFromDebugInfo method (PR #145744)

2025-06-25 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/145744 This patch is part of an effort to remove the `ResolveSDKPathFromDebugInfo` method, and more specifically the variant which takes a `Module` as argument. This PR should be merged after https://github.com

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: +1 on testing and Pavel's suggestion to use assembly/yaml for it so it can run everywhere. https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb][docs] Document qWatchpointSupportInfo (PR #145709)

2025-06-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/145709 None >From f6411a087299e570db9ef4a460c2ed2048160c39 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 25 Jun 2025 14:12:37 + Subject: [PATCH] [lldb][docs] Document qWatchpointSupportInfo ---

[Lldb-commits] [lldb] Default transcript dumping in "statistics dump" to false (PR #145436)

2025-06-25 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/commands/statistics/basic/TestStats.py `` View th

[Lldb-commits] [lldb] [lldb] Add DWARFExpressionEntry and GetExpressionEntryAtAddress() to … (PR #144238)

2025-06-25 Thread Adrian Prantl via lldb-commits
@@ -53,6 +54,29 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t func_load_addr, return GetExpressionAtAddress(func_load_addr, addr) != nullptr; } +llvm::Expected +DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr, +

[Lldb-commits] [lldb] [lldb] include `LLVMTargetParser` in `LINK_COMPONENTS` (PR #145606)

2025-06-25 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/145606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 369cbcc - [lldb] include `LLVMTargetParser` in `LINK_COMPONENTS` (#145606)

2025-06-25 Thread via lldb-commits
Author: Andrew Rogers Date: 2025-06-25T19:30:50+01:00 New Revision: 369cbcc1a21ab07ea6ca142a3b87c75d0a1b2014 URL: https://github.com/llvm/llvm-project/commit/369cbcc1a21ab07ea6ca142a3b87c75d0a1b2014 DIFF: https://github.com/llvm/llvm-project/commit/369cbcc1a21ab07ea6ca142a3b87c75d0a1b2014.diff

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-06-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: Also wondering about testing this. What tools can produce DWARF64? Have you ran `check-lldb` with DWARF64 enabled and what results did you get? I doubt anyone has spare capacity to add a whole new bot for this, but perhaps we would be ok with a few n

[Lldb-commits] [lldb] [lldb] make PlatformAndroid/AdbClient::GetSyncService threadsafe (PR #145382)

2025-06-25 Thread Chad Smith via lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Default transcript dumping in "statistics dump" to false (PR #145436)

2025-06-25 Thread via lldb-commits
https://github.com/qxy11 updated https://github.com/llvm/llvm-project/pull/145436 >From 1323a237d4cbe554e7f373316a041ca172168afe Mon Sep 17 00:00:00 2001 From: Janet Yang Date: Mon, 23 Jun 2025 14:25:12 -0700 Subject: [PATCH 1/4] Disable "transcript" in "statistics dump" by default --- lldb/i

[Lldb-commits] [lldb] [lldb][NFC] remove the ResolveSDKPathFromDebugInfo method (PR #145744)

2025-06-25 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/145744 >From e28a9e6249077c9ffca878cbf4c933b6f4f9eab8 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Thu, 19 Jun 2025 16:17:33 +0100 Subject: [PATCH 1/5] [lldb][darwin] force BuiltinHeadersInSystemModules t

[Lldb-commits] [lldb] [lldb][NFC] remove the ResolveSDKPathFromDebugInfo method (PR #145744)

2025-06-25 Thread Charles Zablit via lldb-commits
@@ -1130,14 +1130,33 @@ void PlatformDarwin::AddClangModuleCompilationOptionsForSDKType( if (target) { if (ModuleSP exe_module_sp = target->GetExecutableModule()) { - auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp); - if (path_or_err) { -

[Lldb-commits] [lldb] [lldb] include `LLVMTargetParser` in `LINK_COMPONENTS` (PR #145606)

2025-06-25 Thread Charles Zablit via lldb-commits
charles-zablit wrote: @andrurogerz do you need us to merge this for you? https://github.com/llvm/llvm-project/pull/145606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix evaluating expressions without JIT in an object context (PR #145599)

2025-06-25 Thread via lldb-commits
@@ -321,7 +321,8 @@ IRMemoryMap::Allocation::Allocation(lldb::addr_t process_alloc, lldb::addr_t IRMemoryMap::Malloc(size_t size, uint8_t alignment, uint32_t permissions, AllocationPolicy policy, - bool zero_mem

[Lldb-commits] [lldb] [lldb] Fix evaluating expressions without JIT in an object context (PR #145599)

2025-06-25 Thread via lldb-commits
jimingham wrote: That seems like a sensible strategy. I made one trivial comment about the ordering of parameters, but otherwise this LGTM. https://github.com/llvm/llvm-project/pull/145599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] 487581b - [lldb][darwin] force BuiltinHeadersInSystemModules to be always false (#144913)

2025-06-25 Thread via lldb-commits
Author: Charles Zablit Date: 2025-06-25T11:18:07-07:00 New Revision: 487581b826a5339410aaf306eafedc7b806b25e3 URL: https://github.com/llvm/llvm-project/commit/487581b826a5339410aaf306eafedc7b806b25e3 DIFF: https://github.com/llvm/llvm-project/commit/487581b826a5339410aaf306eafedc7b806b25e3.diff

[Lldb-commits] [lldb] [lldb] include `LLVMTargetParser` in `LINK_COMPONENTS` (PR #145606)

2025-06-25 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/145606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Default transcript dumping in "statistics dump" to false (PR #145436)

2025-06-25 Thread via lldb-commits
qxy11 wrote: Added a unit test around the warning message as well. I'll probably need some help with landing this. https://github.com/llvm/llvm-project/pull/145436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb] include `LLVMTargetParser` in `LINK_COMPONENTS` (PR #145606)

2025-06-25 Thread Andrew Rogers via lldb-commits
andrurogerz wrote: > do you need us to merge this for you? @charles-zablit yes, I would appreciate it! Thank you! https://github.com/llvm/llvm-project/pull/145606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] [llvm] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-25 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/145175 >From a7e33a16dd280250df2ff2d01648bd4d5bfe000b Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sat, 21 Jun 2025 17:36:58 +0200 Subject: [PATCH] [LLDB] Warn about truncated DWARF section names on Windows --- .../O

[Lldb-commits] [lldb] [lldb][AArch64] Handle core file tag segments missing tag data (PR #145338)

2025-06-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/145338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Update DIL to handle smart pointers; add more tests. (PR #143786)

2025-06-25 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/143786 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] include `LLVMTargetParser` in `LINK_COMPONENTS` (PR #145606)

2025-06-25 Thread Charles Zablit via lldb-commits
charles-zablit wrote: Confirmed that this builds fine with the changes 👍 https://github.com/llvm/llvm-project/pull/145606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Update DIL to handle smart pointers; add more tests. (PR #143786)

2025-06-25 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,24 @@ +#include + +int main(int argc, char **argv) { + + struct NodeS { +std::shared_ptr next; +int value; + }; + auto ptr_node = std::shared_ptr(new NodeS{nullptr, 2}); + ptr_node = std::shared_ptr(new NodeS{std::move(ptr_node), 1}); + + std::shared_ptr p

[Lldb-commits] [lldb] 3a3d1bf - [lldb][AArch64] Handle core file tag segments missing tag data (#145338)

2025-06-25 Thread via lldb-commits
Author: David Spickett Date: 2025-06-25T10:31:38+01:00 New Revision: 3a3d1bf4a39bbbe1cfdc56ab9eeeb13cb438348a URL: https://github.com/llvm/llvm-project/commit/3a3d1bf4a39bbbe1cfdc56ab9eeeb13cb438348a DIFF: https://github.com/llvm/llvm-project/commit/3a3d1bf4a39bbbe1cfdc56ab9eeeb13cb438348a.diff

[Lldb-commits] [lldb] [lldb] Make MCP server instance global (PR #145616)

2025-06-25 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/145616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-25 Thread via lldb-commits
royitaqi wrote: Hi @JDevlieghere and @clayborg , Could you kindly review when you have the chance? I think the PR is close to finish, except the "how to make sure hello.cpp builds in Windows" question. TL;DR updates: 1. Called `xcrun simctl spawn -s ` to launch `a.out` and verified that its

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-25 Thread via lldb-commits
royitaqi wrote: > The Windows-conditional parts will be dead code. Hi @JDevlieghere, I have moved the Windows related code. Should be good to go (re-running tests on the side). FWIW, my bad, I overlooked the `@skipUnlessDarwin` in the test. https://github.com/llvm/llvm-project/pull/139174

[Lldb-commits] [lldb] Support disassembling RISC-V proprietary instructions (PR #145793)

2025-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (tedwoodward) Changes RISC-V supports proprietary extensions, where the TD files don't know about certain instructions, and the disassembler can't disassemble them. Internal users want to be able to disassemble these instructions in L

[Lldb-commits] [lldb] Support disassembling RISC-V proprietary instructions (PR #145793)

2025-06-25 Thread via lldb-commits
https://github.com/tedwoodward created https://github.com/llvm/llvm-project/pull/145793 RISC-V supports proprietary extensions, where the TD files don't know about certain instructions, and the disassembler can't disassemble them. Internal users want to be able to disassemble these instruction

[Lldb-commits] [lldb] Support disassembling RISC-V proprietary instructions (PR #145793)

2025-06-25 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb][NFC] remove the ResolveSDKPathFromDebugInfo method (PR #145744)

2025-06-25 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/145744 >From e28a9e6249077c9ffca878cbf4c933b6f4f9eab8 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Thu, 19 Jun 2025 16:17:33 +0100 Subject: [PATCH 1/4] [lldb][darwin] force BuiltinHeadersInSystemModules t

[Lldb-commits] [lldb] Default transcript dumping in "statistics dump" to false (PR #145436)

2025-06-25 Thread via lldb-commits
https://github.com/qxy11 updated https://github.com/llvm/llvm-project/pull/145436 >From b7889c1f7b0be25f71c6c893bfabe0ebb26f9f52 Mon Sep 17 00:00:00 2001 From: Janet Yang Date: Mon, 23 Jun 2025 14:25:12 -0700 Subject: [PATCH 1/5] Disable "transcript" in "statistics dump" by default --- lldb/i

  1   2   >