[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #145212)

2025-06-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/145212.diff 1 Files Affected: - (modified) lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.cpp (-2) ``diff diff --git a/lldb/sou

[Lldb-commits] [lldb] [lldb] Remove an unused local variable (NFC) (PR #145212)

2025-06-21 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/145212 None >From a29f94fa549fefc8db9fd7d804363401ed836f39 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 21 Jun 2025 15:41:17 -0700 Subject: [PATCH] [lldb] Remove an unused local variable (NFC) --- ll

[Lldb-commits] [lldb] [lldb] Use Socket::CreatePair for launching debugserver (PR #145017)

2025-06-21 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman approved this pull request. LGTM I think we must mention in the description the main functional change that now we are always using --fd for gdbserver on Windows instead of the back connection. https://github.com/llvm/llvm-project/pull/145017 __

[Lldb-commits] [lldb] [lldb] Clean up GDBRemoteCommunication::StartDebugserverProcess (PR #145021)

2025-06-21 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman approved this pull request. LGTM Note the comment above. https://github.com/llvm/llvm-project/pull/145021 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [lldb] Clean up GDBRemoteCommunication::StartDebugserverProcess (PR #145021)

2025-06-21 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/145021 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix qEcho message handling (PR #145072)

2025-06-21 Thread via lldb-commits
https://github.com/eleviant closed https://github.com/llvm/llvm-project/pull/145072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e066f35 - [lldb] Fix qEcho message handling (#145072)

2025-06-21 Thread via lldb-commits
Author: eleviant Date: 2025-06-21T22:48:08+02:00 New Revision: e066f35c6981c720e3a7e5883efc40c861b3b7ee URL: https://github.com/llvm/llvm-project/commit/e066f35c6981c720e3a7e5883efc40c861b3b7ee DIFF: https://github.com/llvm/llvm-project/commit/e066f35c6981c720e3a7e5883efc40c861b3b7ee.diff LOG:

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-21 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/145175 >From c4ded348b004f77be9047e126e301d5887d7443d Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sat, 21 Jun 2025 17:36:58 +0200 Subject: [PATCH] [LLDB] Warn about truncated DWARF section names on Windows --- .../O

[Lldb-commits] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 2) (PR #143633)

2025-06-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/143633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-21 Thread via lldb-commits
https://github.com/zyn-li updated https://github.com/llvm/llvm-project/pull/144815 >From 3ebb051ac739ec50b4be727cc3e555a78b14d7b8 Mon Sep 17 00:00:00 2001 From: Zhiyuan Li Date: Wed, 18 Jun 2025 16:49:12 -0700 Subject: [PATCH] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique re

[Lldb-commits] [lldb] [lldb] Clean up GDBRemoteCommunication::StartDebugserverProcess (PR #145021)

2025-06-21 Thread Dmitry Vasilyev via lldb-commits
@@ -1084,55 +1052,30 @@ Status GDBRemoteCommunication::StartDebugserverProcess( if (socket_pipe.CanWrite()) socket_pipe.CloseWriteFileDescriptor(); - if (socket_pipe.CanRead()) { -// Read port from pipe with 10 second timeout. -std::string port_str; -while (

[Lldb-commits] [clang] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 4) (PR #145157)

2025-06-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes Context: See previous approaches: #142704, #143633, #144177 # This approach This approach follows this [previous suggestion](https://github.com/llvm/llvm-project/pull/144177#issuecomment-2981087019): 1. Create a ne

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-21 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/test/API/macosx/simulator/hello.cpp ``

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/139174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 4) (PR #145157)

2025-06-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/145157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix object format in the Triple of Mach-O files (approach 3) (PR #144177)

2025-06-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/144177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix qEcho message handling (PR #145072)

2025-06-21 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `lldb` at step 16 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/10758 Here is the relevant piece

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-21 Thread via lldb-commits
@@ -0,0 +1,24 @@ +#include +#include +#if !defined(_WIN32) +#include +#endif + +static void print_pid() { + #if defined(_WIN32) +fprintf(stderr, "PID: %d\n", ::GetCurrentProcessId()); royitaqi wrote: I copied this snippet from from `TestAppleSimulatorOSTy

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-21 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/139174 >From d98210b81f7b49f5384e968b1a18e00e432aaf2c Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 8 May 2025 16:21:53 -0700 Subject: [PATCH 1/6] Fix macOS FindProcessImpl() --- lldb/source/Host/macosx/objcxx/H

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/139174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-21 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/139174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-21 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/139174 >From d98210b81f7b49f5384e968b1a18e00e432aaf2c Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 8 May 2025 16:21:53 -0700 Subject: [PATCH 1/6] Fix macOS FindProcessImpl() --- lldb/source/Host/macosx/objcxx/H

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-21 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/145175 >From d2e8656a3488ee96d95c2368025820d464c04cd6 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sat, 21 Jun 2025 17:36:58 +0200 Subject: [PATCH] [LLDB] Warn about truncated DWARF section names on Windows --- .../O

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-21 Thread Jonas Devlieghere via lldb-commits
@@ -1036,12 +1036,19 @@ void ObjectFilePECOFF::CreateSections(SectionList &unified_section_list) { m_sections_up->AddSection(header_sp); unified_section_list.AddSection(header_sp); +std::vector truncated_dwarf_sections; const uint32_t nsects = m_sect_headers.

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-21 Thread Jonas Devlieghere via lldb-commits
@@ -1071,6 +1078,16 @@ void ObjectFilePECOFF::CreateSections(SectionList &unified_section_list) { m_sections_up->AddSection(section_sp); unified_section_list.AddSection(section_sp); } + +if (!truncated_dwarf_sections.empty()) { + module_sp->ReportWarni

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-21 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/145175 Linking executables with DWARF sections on Windows with the default link.exe will truncate the section names, as [sections in PE/COFF executable images can't be longer than 8 bytes](https://learn.microsoft.com

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Looks reasonable to me. CC @charles-zablit https://github.com/llvm/llvm-project/pull/145175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/145175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Support constant index encoding of DW_AT_object_pointer (PR #144998)

2025-06-21 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/144998 >From 0044bdf4731c8bb74eafb91ee19cc9c5a272d4f3 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 29 Jan 2025 12:15:35 + Subject: [PATCH 1/4] [lldb][DWARFASTParserClang] Support constant index encodi

[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

2025-06-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Linking executables with DWARF sections on Windows with the default link.exe will truncate the section names, as [sections in PE/COFF executable images can't be longer than 8 bytes](https://learn.microsoft.com/en-u

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-21 Thread via lldb-commits
https://github.com/royitaqi commented: Hi @JDevlieghere, > In TestAppleSimulatorOSType there's a snippet that launched a binary with > simctl. Could we use that to launch the binary without it being traced? Done. Kindly take a look when you have the time. TL;DR changes: 1. Found the snippet