[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Once my comments are addressed this will be good to land. Only concern was changing the default behaviour, and this PR does not go anywhere near that now. https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mailing l

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread David Spickett via lldb-commits
@@ -88,3 +88,10 @@ def test_save_core_via_process_plugin(self): os.unlink(core) except OSError: pass + +def test_help(self): +"""Test that help shows minidump as an option in plugin-names.""" DavidSpickett

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread David Spickett via lldb-commits
@@ -16,4 +16,4 @@ run DavidSpickett wrote: I think you need a test for the error when a specific plugin name is given, vs when no name is given. https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb] upgrade HandleFrameFormatVariable callees to llvm::Expected (PR #144731)

2025-06-20 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/144731 >From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 18 Jun 2025 16:41:40 +0100 Subject: [PATCH 1/8] [lldb] upgrade HandleFrameFormatVariable callees to

[Lldb-commits] [lldb] [lldb][AIX] Added base file for AIX Register Context (PR #144645)

2025-06-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/144645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][target] Add progress report for wait-attaching to process (PR #144768)

2025-06-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Though I cannot reproduce the failure, so it could be to do with the high load when run on the bots. Some process being deprioritised. https://github.com/llvm/llvm-project/pull/144768 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] [lldb] Add Socket::CreatePair (PR #145015)

2025-06-20 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/145015 It creates a pair of connected sockets using the simplest mechanism for the given platform (TCP on windows, socketpair(2) elsewhere). Main motivation is to remove the ugly platform-specific code in ProcessGDBRe

[Lldb-commits] [lldb] [lldb] Add Socket::CreatePair (PR #145015)

2025-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes It creates a pair of connected sockets using the simplest mechanism for the given platform (TCP on windows, socketpair(2) elsewhere). Main motivation is to remove the ugly platform-specific code in ProcessGDB

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/143126 >From fc849bd4e831f9dc6f53be3a8508e1eb33f4151c Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 6 Jun 2025 13:15:41 +0100 Subject: [PATCH 1/2] [lldb] add plugin names to process save-core error output. s

[Lldb-commits] [lldb] [lldb] Use Socket::CreatePair for launching debugserver (PR #145017)

2025-06-20 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/145017 This lets get rid of platform-specific code in ProcessGDBRemote and use the same code path (module differences in socket types) everywhere. It also unlocks further cleanups in the debugserver launching code. Depe

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread Ebuka Ezike via lldb-commits
da-viper wrote: The mach-o plugin works but the pecoff is an alias to minidump https://github.com/llvm/llvm-project/blob/4ec6d127c1857e77d70236b15b03d23ba1283a3d/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp#L6642-L6670 https://github.com/llvm/llvm-project/blob/4ec6d127c1857e77d7023

[Lldb-commits] [lldb] [lldb] upgrade HandleFrameFormatVariable callees to llvm::Expected (PR #144731)

2025-06-20 Thread Michael Buch via lldb-commits
@@ -2008,38 +1979,54 @@ bool CPlusPlusLanguage::HandleFrameFormatVariable( return true; } case FormatEntity::Entry::Type::FunctionReturnRight: { -std::optional return_rhs = GetDemangledReturnTypeRHS(sc); -if (!return_rhs) +auto return_rhs_or_err = GetDemangl

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Support constant index encoding of DW_AT_object_pointer (PR #144998)

2025-06-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/144998 Starting with https://github.com/llvm/llvm-project/pull/124790, Clang emits `DW_AT_object_pointer` encoded as integer constants rather than DIE references. This patch accounts for this. >From 22e8f644c3cd88

[Lldb-commits] [lldb] [lldb] upgrade HandleFrameFormatVariable callees to llvm::Expected (PR #144731)

2025-06-20 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/144731 >From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 18 Jun 2025 16:41:40 +0100 Subject: [PATCH 1/9] [lldb] upgrade HandleFrameFormatVariable callees to

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread David Spickett via lldb-commits
@@ -88,3 +88,10 @@ def test_save_core_via_process_plugin(self): os.unlink(core) except OSError: pass + +def test_help(self): +"""Test that help shows minidump as an option in plugin-names.""" +self.expect( +

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-20 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,4 @@ +CXX_SOURCES := main.cpp + +CXXFLAGS_EXTRAS := -std=c++14 -O0 labath wrote: -O0 shouldn't be necessary and -std=c++14 should be set [here](https://github.com/llvm/llvm-project/blob/e970f59e6b20dddc4369735affb79ca9be240c1c/lldb/packages/Python/lld

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-20 Thread Pavel Labath via lldb-commits
@@ -239,122 +240,39 @@ VectorIteratorSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) { bool lldb_private::formatters::LibStdcppStringSummaryProvider( ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) { - const bool scalar_is_load_addr =

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-20 Thread Pavel Labath via lldb-commits
@@ -239,122 +240,39 @@ VectorIteratorSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) { bool lldb_private::formatters::LibStdcppStringSummaryProvider( ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) { - const bool scalar_is_load_addr =

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread David Spickett via lldb-commits
@@ -16,4 +16,4 @@ run DavidSpickett wrote: This needs to be done. https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Ok so they aren't lying then. I suppose pecoff -> Windows and on Windows they use minidump among other things. https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] [lldb][darwin] force BuiltinHeadersInSystemModules to be always false (PR #144913)

2025-06-20 Thread Michael Buch via lldb-commits
Michael137 wrote: @ian-twilightcoder to chime in on the details again. Happy to give it a shot if nothing breaks (I assume you tried running the API test-suite locally?) https://github.com/llvm/llvm-project/pull/144913 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Support constant index encoding of DW_AT_object_pointer (PR #144998)

2025-06-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/144998 >From 22e8f644c3cd8856e1663bdf71aab4fa621f75bf Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 29 Jan 2025 12:15:35 + Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] Support constant index encodi

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Support constant index encoding of DW_AT_object_pointer (PR #144998)

2025-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Starting with https://github.com/llvm/llvm-project/pull/124790, Clang emits `DW_AT_object_pointer` encoded as integer constants rather than DIE references. This patch accounts for this. --- Full diff: htt

[Lldb-commits] [lldb] [lldb][AIX] Added base file for AIX Register Context (PR #144645)

2025-06-20 Thread David Spickett via lldb-commits
@@ -0,0 +1,62 @@ +//===-- NativeRegisterContextAIX.h *- C++ -*-===// DavidSpickett wrote: Make line 1 line up with line 7, they should be the same length. https://github.com/llvm/llvm-project/pull/144645 __

[Lldb-commits] [lldb] [lldb][AIX] Added base file for AIX Register Context (PR #144645)

2025-06-20 Thread David Spickett via lldb-commits
@@ -0,0 +1,54 @@ +//===-- NativeRegisterContextAIX.cpp ===// DavidSpickett wrote: Add more `-` so that line 1 ends at the same place line 7 does. https://github.com/llvm/llvm-project/pull/144645 ___

[Lldb-commits] [lldb] [lldb][AIX] Added base file for AIX Register Context (PR #144645)

2025-06-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Looks a lot like the existing ppc Linux class, which makes sense, same architecture. With the comment formatting fixed, this LGTM. https://github.com/llvm/llvm-project/pull/144645 ___ lldb-

[Lldb-commits] [lldb] [lldb][AIX] Added base file for AIX Register Context (PR #144645)

2025-06-20 Thread Hemang Gadhavi via lldb-commits
@@ -0,0 +1,54 @@ +//===-- NativeRegisterContextAIX.cpp ===// HemangGadhavi wrote: Done Thanks. https://github.com/llvm/llvm-project/pull/144645 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb][AIX] Added base file for AIX Register Context (PR #144645)

2025-06-20 Thread Hemang Gadhavi via lldb-commits
@@ -0,0 +1,62 @@ +//===-- NativeRegisterContextAIX.h *- C++ -*-===// HemangGadhavi wrote: Done Thanks. https://github.com/llvm/llvm-project/pull/144645 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Just add the new tests and this will be good to go. Figure out whether the other plugins are lying later :) https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [lldb] Use Socket::CreatePair for launching debugserver (PR #145017)

2025-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This lets get rid of platform-specific code in ProcessGDBRemote and use the same code path (module differences in socket types) everywhere. It also unlocks further cleanups in the debugserver launching code. De

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-20 Thread Pavel Labath via lldb-commits
labath wrote: > Another aside: Does anyone know why the [libstdc++ `std::__cxx11::string` > summaries](https://github.com/llvm/llvm-project/blob/802fa92aee3565768887615108aa3e924d4e0fc7/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp#L240-L358) > weren't using the string summary? They were

[Lldb-commits] [lldb] [lldb][AIX] Added base file for AIX Register Context (PR #144645)

2025-06-20 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX approved this pull request. https://github.com/llvm/llvm-project/pull/144645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread David Spickett via lldb-commits
@@ -326,11 +326,15 @@ void NativeProcessFreeBSD::MonitorSIGTRAP(lldb::pid_t pid) { if (thread_info != m_threads_stepping_with_breakpoint.end() && thread_info->second == regctx.GetPC()) { thread->SetStoppedByTrace(); - Status brkpt_error =

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -32,6 +32,31 @@ class RegisterValue; class Stream; class Target; class UnwindPlan; +class EmulateInstruction; + +using BreakpointLocations = std::vector; + +class SingleStepBreakpointLocationsPredictor { +public: + SingleStepBreakpointLocationsPredictor( + std::unique_

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -0,0 +1,90 @@ +""" +Test software step-inst +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TestSoftwareStep(TestBase): +@skipIf(archs=no_match(re.compile("rv*"))) +def t

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -14471,3 +14471,14 @@ bool EmulateInstructionARM::CreateFunctionEntryUnwind(UnwindPlan &unwind_plan) { unwind_plan.SetReturnAddressRegister(dwarf_lr); return true; } + +unsigned ARMSingleStepBreakpointLocationsPredictor::GetBreakpointSize( +lldb::addr_t bp_addr, Sta

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -0,0 +1,90 @@ +""" +Test software step-inst +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TestSoftwareStep(TestBase): +@skipIf(archs=no_match(re.compile("rv*"))) --

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -23,7 +23,7 @@ class NativeProcessSoftwareSingleStep { protected: // List of thread ids stepping with a breakpoint with the address of // the relevan breakpoint - std::map m_threads_stepping_with_breakpoint; + std::multimap m_threads_stepping_with_breakpoint; -

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -0,0 +1,90 @@ +""" +Test software step-inst dlav-sc wrote: addressed https://github.com/llvm/llvm-project/pull/127505 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -32,6 +32,31 @@ class RegisterValue; class Stream; class Target; class UnwindPlan; +class EmulateInstruction; + +using BreakpointLocations = std::vector; + +class SingleStepBreakpointLocationsPredictor { +public: + SingleStepBreakpointLocationsPredictor( + std::unique_

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -588,7 +588,100 @@ EmulateInstruction::GetInternalRegisterNumber(RegisterContext *reg_ctx, return LLDB_INVALID_REGNUM; } +std::unique_ptr +EmulateInstruction::CreateBreakpointLocationPredictor( +std::unique_ptr emulator_up) { + auto creator = + emulator_up->Get

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -32,6 +32,31 @@ class RegisterValue; class Stream; class Target; class UnwindPlan; +class EmulateInstruction; + +using BreakpointLocations = std::vector; + +class SingleStepBreakpointLocationsPredictor { +public: + SingleStepBreakpointLocationsPredictor( + std::unique_

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -16,6 +16,16 @@ namespace lldb_private { +class ARMSingleStepBreakpointLocationsPredictor +: public SingleStepBreakpointLocationsPredictor { +public: + ARMSingleStepBreakpointLocationsPredictor( + std::unique_ptr emulator_up) + : SingleStepBreakpointLocation

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -326,11 +326,15 @@ void NativeProcessFreeBSD::MonitorSIGTRAP(lldb::pid_t pid) { if (thread_info != m_threads_stepping_with_breakpoint.end() && thread_info->second == regctx.GetPC()) { thread->SetStoppedByTrace(); - Status brkpt_error =

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -87,34 +87,10 @@ static size_t WriteMemoryCallback(EmulateInstruction *instruction, void *baton, return length; } -static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { - const RegisterInfo *flags_info = regsiter_context.GetRegisterInfo( - eRegister

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -0,0 +1,90 @@ +""" +Test software step-inst +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TestSoftwareStep(TestBase): +@skipIf(archs=no_match(re.compile("rv*"))) +def t

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -0,0 +1,90 @@ +""" +Test software step-inst +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TestSoftwareStep(TestBase): +@skipIf(archs=no_match(re.compile("rv*"))) +def t

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
@@ -0,0 +1,90 @@ +""" +Test software step-inst +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TestSoftwareStep(TestBase): +@skipIf(archs=no_match(re.compile("rv*"))) +def t

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-20 Thread via lldb-commits
@@ -0,0 +1,4 @@ +CXX_SOURCES := main.cpp + +CXXFLAGS_EXTRAS := -std=c++14 -O0 Nerixyz wrote: Yes, that worked! https://github.com/llvm/llvm-project/pull/143177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread David Spickett via lldb-commits
@@ -16,6 +16,16 @@ namespace lldb_private { +class ARMSingleStepBreakpointLocationsPredictor +: public SingleStepBreakpointLocationsPredictor { +public: + ARMSingleStepBreakpointLocationsPredictor( + std::unique_ptr emulator_up) + : SingleStepBreakpointLocation

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (PR #145033)

2025-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This controls whether tag checking is performed for loads and stores, or stores only. It requires a specific architecture feature which we detect with a HWCAP3 and cpuinfo feature. Live process tests

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-20 Thread via lldb-commits
@@ -299,6 +299,8 @@ def parseOptionsAndInitTestdirs(): configuration.libcxx_library_dir = args.libcxx_library_dir configuration.cmake_build_type = args.cmake_build_type.lower() +configuration.target_triple = args.target_triple + Nerixyz wrote: The

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-20 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/143177 >From 9f957946e2538c8a0c0f6d772ae9c5d1946ec694 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Wed, 18 Jun 2025 21:49:16 +0200 Subject: [PATCH] [LLDB] Add type summaries for MSVC STL strings --- .../lldb/DataForm

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-20 Thread Pavel Labath via lldb-commits
@@ -299,6 +299,8 @@ def parseOptionsAndInitTestdirs(): configuration.libcxx_library_dir = args.libcxx_library_dir configuration.cmake_build_type = args.cmake_build_type.lower() +configuration.target_triple = args.target_triple + labath wrote: I'd

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/127505 >From 2520b8d7884d320ed7923685b1a3e8652a7e8f5f Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Fri, 23 May 2025 13:27:46 + Subject: [PATCH 1/3] [lldb][RISCV] handle lr/sc single step lldb-server had limi

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-20 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/143177 >From d80694278209cfc1c88414b1f5eb8e9980ebb3fa Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Wed, 18 Jun 2025 21:49:16 +0200 Subject: [PATCH] [LLDB] Add type summaries for MSVC STL strings --- .../lldb/DataForm

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (PR #145033)

2025-06-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/145033 This controls whether tag checking is performed for loads and stores, or stores only. It requires a specific architecture feature which we detect with a HWCAP3 and cpuinfo feature. Live process tests loo

[Lldb-commits] [lldb] [lldb] upgrade HandleFrameFormatVariable callees to llvm::Expected (PR #144731)

2025-06-20 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/144731 >From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 18 Jun 2025 16:41:40 +0100 Subject: [PATCH 01/10] [lldb] upgrade HandleFrameFormatVariable callees t

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (PR #145033)

2025-06-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: And if you want to test this, you need Arm's FVP and to add the following shrinkwrap settings: ``` +-C cluster0.memory_tagging_support_level: 4 +-C cluster1.memory_tagging_support_level: 4 +-C bp.dram_metadata.is_enabled: 1 ``` I did this on top of the v9.5-a con

[Lldb-commits] [lldb] [lldb][AArch64] Add HWCAP3 to register field detection (PR #145029)

2025-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This will be used to detect the presence of Arm's new Memory Tagging store only checking feature. This commit just adds the plumbing to get that value into the detection function. FreeBSD has not all

[Lldb-commits] [lldb] [lldb] Fix qEcho message handling (PR #145072)

2025-06-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/gdbclientutils.py lldb/test/API/functio

[Lldb-commits] [lldb] [lldb] Fix qEcho message handling (PR #145072)

2025-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (eleviant) Changes Patch fixes the sync-on-timeout logic in lldb and switches to qEcho based ping, instead of qC. This fixes vRun message case, when there is no process yet and qC returns an error. --- Full diff: https://github.com/l

[Lldb-commits] [lldb] [lldb] Fix qEcho message handling (PR #145072)

2025-06-20 Thread via lldb-commits
https://github.com/eleviant updated https://github.com/llvm/llvm-project/pull/145072 >From 8436977c0331765ab17dbb47cd7113352642e575 Mon Sep 17 00:00:00 2001 From: Evgeny Leviant Date: Fri, 20 Jun 2025 18:46:24 +0200 Subject: [PATCH 1/2] [lldb] Fix qEcho message handling Patch fixes the sync-on

[Lldb-commits] [clang] [lldb] [Clang][PowerPC] Add __dmr1024 type and DMF integer calculation builtins (PR #142480)

2025-06-20 Thread Maryam Moghadas via lldb-commits
https://github.com/maryammo closed https://github.com/llvm/llvm-project/pull/142480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/143126 >From fc849bd4e831f9dc6f53be3a8508e1eb33f4151c Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 6 Jun 2025 13:15:41 +0100 Subject: [PATCH 1/3] [lldb] add plugin names to process save-core error output. s

[Lldb-commits] [lldb] [lldb] Fix qEcho message handling (PR #145072)

2025-06-20 Thread via lldb-commits
https://github.com/eleviant created https://github.com/llvm/llvm-project/pull/145072 Patch fixes the sync-on-timeout logic in lldb and switches to qEcho based ping, instead of qC. This fixes vRun message case, when there is no process yet and qC returns an error. >From 8436977c0331765ab17dbb4

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/127505 >From 2520b8d7884d320ed7923685b1a3e8652a7e8f5f Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Fri, 23 May 2025 13:27:46 + Subject: [PATCH 1/4] [lldb][RISCV] handle lr/sc single step lldb-server had limi

[Lldb-commits] [lldb] Revert "[lldb][DWARF] Remove object_pointer from ParsedDWARFAttributes" (PR #145065)

2025-06-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Reverts llvm/llvm-project#144880 Caused `TestObjCIvarsInBlocks.py` to fail on macOS CI. --- Full diff: https://github.com/llvm/llvm-project/pull/145065.diff 2 Files Affected: - (modified) lldb/source/Pl

[Lldb-commits] [lldb] [LLDB] Update DIL to pass current 'frame var' tests. (PR #145055)

2025-06-20 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/145055 As a preliminary to making DIL the default implementation for 'frame var', ran check-lldb forcing 'frame var' to always use DIL, and discovered a few failing tests. This fixes most of them. The only two remainin

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-20 Thread Ebuka Ezike via lldb-commits
@@ -16,4 +16,4 @@ run da-viper wrote: did not run it with a file since that is tested in the `TestProcessSaveCore.py` file. https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/data-formatter/data-formatter-stl/msvcstl/stri

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo][DWARF] Create new low-level dwarf library (PR #145081)

2025-06-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- llvm/include/llvm/DebugInfo/DWARF/DWARFExpressionPr

[Lldb-commits] [lldb] [LLDB] Update DIL to pass current 'frame var' tests. (PR #145055)

2025-06-20 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/145055 >From e9079e6357b933e84603997edb8d0cd27a515989 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Fri, 20 Jun 2025 08:33:14 -0700 Subject: [PATCH 1/3] [LLDB] Update DIL to pass current 'frame var' tests. As a pr

[Lldb-commits] [lldb] [LLDB] Update DIL to pass current 'frame var' tests. (PR #145055)

2025-06-20 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/145055 >From e9079e6357b933e84603997edb8d0cd27a515989 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Fri, 20 Jun 2025 08:33:14 -0700 Subject: [PATCH 1/2] [LLDB] Update DIL to pass current 'frame var' tests. As a pr

[Lldb-commits] [lldb] [lldb] upgrade HandleFrameFormatVariable callees to llvm::Expected (PR #144731)

2025-06-20 Thread Michael Buch via lldb-commits
@@ -74,24 +74,48 @@ struct DemangledNameInfo { return BasenameRange.second > BasenameRange.first; } + /// Returns \c true if `BasenameRange` is empty. + bool isBasenameEmpty() const { +return BasenameRange.first == BasenameRange.second; Michael137

[Lldb-commits] [lldb] [lldb] Add Socket::CreatePair (PR #145015)

2025-06-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/145015 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Socket::CreatePair (PR #145015)

2025-06-20 Thread Jonas Devlieghere via lldb-commits
@@ -52,6 +52,34 @@ TCPSocket::TCPSocket(NativeSocket socket, bool should_close) TCPSocket::~TCPSocket() { CloseListenSockets(); } +llvm::Expected< +std::pair, std::unique_ptr>> +TCPSocket::CreatePair() { + auto listen_socket_up = std::make_unique(true); + if (Status err

[Lldb-commits] [lldb] [lldb] Add Socket::CreatePair (PR #145015)

2025-06-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/145015 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Socket::CreatePair (PR #145015)

2025-06-20 Thread Jonas Devlieghere via lldb-commits
@@ -106,6 +106,10 @@ class Socket : public IOObject { static std::unique_ptr Create(const SocketProtocol protocol, Status &error); + static llvm::Expected< + std::pair, std::unique_ptr>> JDevlieghere wrote: Nit:

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-20 Thread via lldb-commits
https://github.com/zyn-li updated https://github.com/llvm/llvm-project/pull/144815 >From 16792f7dffae9ef95a3a09c2dbaa6731b07e0ea7 Mon Sep 17 00:00:00 2001 From: Zhiyuan Li Date: Wed, 18 Jun 2025 16:49:12 -0700 Subject: [PATCH 1/2] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield uniqu

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-06-20 Thread James Y Knight via lldb-commits
jyknight wrote: > Thanks for the concrete example! [..] I just wanted to thank you (a bit late) for the explanation above, it was really helpful! > FWIW I'd like to get rid of the reference count of DiagnosticsEngine too, and > make the lifetimes stricter and more explicit, but that's a lower

[Lldb-commits] [lldb] Revert "[lldb][DWARF] Remove object_pointer from ParsedDWARFAttributes" (PR #145065)

2025-06-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/145065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Support constant index encoding of DW_AT_object_pointer (PR #144998)

2025-06-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/144998 >From 22e8f644c3cd8856e1663bdf71aab4fa621f75bf Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 29 Jan 2025 12:15:35 + Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] Support constant index encodi

[Lldb-commits] [lldb] [LLDB] Add SI_USER and SI_KERNEL to Linux signals (PR #144800)

2025-06-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Depending on the user's knowledge of / interpretation of how signals work, I don't think "sent by kernel" is enough for them to find their specific problem. Asking my nearest totally accurate AI model: > Yes, when an application receives a SIGILL (illegal instruction) signa

[Lldb-commits] [lldb] [lldb/cmake] Plugin layering enforcement mechanism (PR #144543)

2025-06-20 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Cool stuff! https://github.com/llvm/llvm-project/pull/144543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9524bfb - [lldb] Add Model Context Protocol (MCP) support to LLDB (#143628)

2025-06-20 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-06-20T10:48:04-05:00 New Revision: 9524bfb27020d31b9474f595b7c0e5d2e1ac65f5 URL: https://github.com/llvm/llvm-project/commit/9524bfb27020d31b9474f595b7c0e5d2e1ac65f5 DIFF: https://github.com/llvm/llvm-project/commit/9524bfb27020d31b9474f595b7c0e5d2e1ac65f5.d

[Lldb-commits] [lldb] [lldb][AArch64] Add HWCAP3 to register field detection (PR #145029)

2025-06-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/145029 >From ba8fcf4ef14e25b8a628b994988d6a67bdbea7df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 19 Jun 2025 10:43:48 + Subject: [PATCH] [lldb][AArch64] Add HWCAP3 to register field detection T

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/143628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread David Spickett via lldb-commits
@@ -32,6 +34,37 @@ class RegisterValue; class Stream; class Target; class UnwindPlan; +class EmulateInstruction; + +using BreakpointLocations = std::vector; + +class SingleStepBreakpointLocationsPredictor { +public: + SingleStepBreakpointLocationsPredictor( + std::unique_

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-06-20 Thread David Spickett via lldb-commits
@@ -1792,4 +1778,127 @@ bool EmulateInstructionRISCV::SupportsThisArch(const ArchSpec &arch) { return arch.GetTriple().isRISCV(); } +BreakpointLocations +RISCVSingleStepBreakpointLocationsPredictor::GetBreakpointLocations( +Status &status) { + EmulateInstructionRISCV *

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo][DWARF] Create new low-level dwarf library (PR #145081)

2025-06-20 Thread via lldb-commits
https://github.com/Sterling-Augustine created https://github.com/llvm/llvm-project/pull/145081 This is the culmination of a series of changes described in [1]. Although somewhat large by line count, it is almost entirely mechanical, creating a new library in DebugInfo/DWARF/LowLevel. This

[Lldb-commits] [lldb] 749e4a5 - [lldb] Fix ASCII art in CommandObjectProtocolServer (NFC)

2025-06-20 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-06-20T10:54:00-05:00 New Revision: 749e4a53d252e23e870d4a1638ff9d846af58e7f URL: https://github.com/llvm/llvm-project/commit/749e4a53d252e23e870d4a1638ff9d846af58e7f DIFF: https://github.com/llvm/llvm-project/commit/749e4a53d252e23e870d4a1638ff9d846af58e7f.d

[Lldb-commits] [lldb] [lldb][AArch64] Add HWCAP3 to register field detection (PR #145029)

2025-06-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: HWCAP3 has been present for a while - https://elixir.bootlin.com/linux/v6.16-rc2/source/include/uapi/linux/auxvec.h#L35 The MTE patches are still in review (https://lore.kernel.org/linux-arm-kernel/20250611150417.44850-5-yeoreum@arm.com/) but are unlikely to change dr

[Lldb-commits] [lldb] [lldb][AArch64] Add HWCAP3 to register field detection (PR #145029)

2025-06-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/145029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][darwin] force BuiltinHeadersInSystemModules to be always false (PR #144913)

2025-06-20 Thread Charles Zablit via lldb-commits
charles-zablit wrote: I only get one test failures when running the `check-lldb-api` target: `commands/platform/sdk/TestPlatformSDK.py` but it also happens on the main branch, so there's probably something wrong with the SDK configuration on my system. https://github.com/llvm/llvm-project/pul

[Lldb-commits] [lldb] [lldb][target] Add progress report for wait-attaching to process (PR #144768)

2025-06-20 Thread Pavel Labath via lldb-commits
labath wrote: Well.. IIUC, this test tries to attach to a process called "a.out" -- and hopes that the process doesn't appear. If you run the test suite in parallel, you'll have any number of processes like that going around all the time. Not only will this test fail, but it will mess up the s

[Lldb-commits] [lldb] 20d57e7 - [lldb][AIX] Added base file for AIX Register Context (#144645)

2025-06-20 Thread via lldb-commits
Author: Hemang Gadhavi Date: 2025-06-20T20:18:39+05:30 New Revision: 20d57e77f6709ef32791391bc064d3ed5663272a URL: https://github.com/llvm/llvm-project/commit/20d57e77f6709ef32791391bc064d3ed5663272a DIFF: https://github.com/llvm/llvm-project/commit/20d57e77f6709ef32791391bc064d3ed5663272a.diff

[Lldb-commits] [lldb] 65cb3bc - [Clang][PowerPC] Add __dmr1024 type and DMF integer calculation builtins (#142480)

2025-06-20 Thread via lldb-commits
Author: Maryam Moghadas Date: 2025-06-20T13:03:14-04:00 New Revision: 65cb3bcf327da8f9740e56897bc9954364e59eb6 URL: https://github.com/llvm/llvm-project/commit/65cb3bcf327da8f9740e56897bc9954364e59eb6 DIFF: https://github.com/llvm/llvm-project/commit/65cb3bcf327da8f9740e56897bc9954364e59eb6.dif

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-20 Thread via lldb-commits
https://github.com/zyn-li updated https://github.com/llvm/llvm-project/pull/144815 >From 2054114501b9de9ab54d22044800607fd12d Mon Sep 17 00:00:00 2001 From: Zhiyuan Li Date: Wed, 18 Jun 2025 16:49:12 -0700 Subject: [PATCH] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique re

[Lldb-commits] [lldb] [LLDB] Explicitly use python for version fixup (PR #144217)

2025-06-20 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova approved this pull request. LGTM! (For future reference, we should also do this when we run the framework fixup Python script) https://github.com/llvm/llvm-project/pull/144217 ___ lldb-commits mailing list lldb-commit

  1   2   >