[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142652 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-03 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/139170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142684 >From 0bf47c19e63c3b72a4b3861fa286e273a99bd80c Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 3 Jun 2025 23:22:30 +0100 Subject: [PATCH 1/2] [lldb] Return an error when if process save-core plugin is in

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142684 Fixes #142581 >From 7e940dcb0cfde1bc9be73c7cf2a40ba7f08d12e5 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 2 Jun 2025 17:07:50 +0100 Subject: [PATCH 1/4] [lldb-dap] Forward any error from stepping. -

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/142244 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/139170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
@@ -246,6 +246,9 @@ llvm::StringRef SymbolFileDWARFDebugMap::GetPluginDescriptionStatic() { } SymbolFile *SymbolFileDWARFDebugMap::CreateInstance(ObjectFileSP objfile_sp) { + // Don't create a debug map if the object file isn't a Mach-O. + if (!objfile_sp->GetArchitecture()

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/139170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove USE_ALLOCATE_MEMORY_CACHE (PR #142689)

2025-06-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/142689 This is always on, and has been since at least 2011 from what I can tell. The code in the `#else` clauses are effectively dead code. >From 5b0c4e004c980d37c3ec461b486256027afc3a38 Mon Sep 17 00:00:00 2001 Fro

[Lldb-commits] [lldb] [lldb][TypeSystem][NFC] CreateFunctionType to take parameters by llvm::ArrayRef (PR #142620)

2025-06-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/142620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-03 Thread via lldb-commits
royitaqi wrote: Updated the code to using `Triple` of the `ObjectFile` (thanks to @labath for the suggestion). Updated the test. @labath / @JDevlieghere: Please kindly take a look when you have the time. https://github.com/llvm/llvm-project/pull/139170 _

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,154 @@ +//===-- SymbolFileDWARFDebugMapTests.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-03 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/139170 >From c7432d04896c1eea67ed6a6d5f4b4c28941e5a90 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 8 May 2025 07:38:20 -0700 Subject: [PATCH 1/5] [lldb] Do not create SymbolFileDWARFDebugMap for non-Mach-O files

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/142244 >From 7d8d697f523d7fe80bb3f3f068efa9904c50b7cd Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 3 Jun 2025 16:03:36 -0700 Subject: [PATCH] [lldb] Revive TestSimulatorPlatform.py This test was in

[Lldb-commits] [lldb] [lldb] Remove USE_ALLOCATE_MEMORY_CACHE (PR #142689)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes This is always on, and has been since at least 2011 from what I can tell. The code in the `#else` clauses are effectively dead code. --- Full diff: https://github.com/llvm/llvm-project/pull/142689.diff 1

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-03 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. https://github.com/llvm/llvm-project/pull/142684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-03 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/142704 The fact that `ObjectFileMachO` can parse the object file means that it's an Mach-O format. So it should just be set set the default format, before going through the rest of the code, which looks at load comma

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-03 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes The fact that `ObjectFileMachO` can parse the object file means that it's an Mach-O format. So it should just be set set the default format, before going through the rest of the code, which looks at load commands li

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-03 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/142510 >From 2fd86de03cbb207420ee45334639f82d19dbbc28 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 2 Jun 2025 18:07:52 -0700 Subject: [PATCH 1/2] [lldb-dap] Migrating 'threads' request to structured types.

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-03 Thread John Harrison via lldb-commits
@@ -116,77 +116,79 @@ void SendProcessEvent(DAP &dap, LaunchMethod launch_method) { // Send a thread stopped event for all threads as long as the process // is stopped. -void SendThreadStoppedEvent(DAP &dap) { +void SendThreadStoppedEvent(DAP &dap, bool on_entry) { --

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-03 Thread John Harrison via lldb-commits
@@ -8,72 +8,43 @@ #include "DAP.h" #include "EventHelper.h" -#include "JSONUtils.h" +#include "Protocol/ProtocolRequests.h" +#include "ProtocolUtils.h" #include "RequestHandler.h" +#include "lldb/API/SBDebugger.h" +#include "lldb/API/SBDefines.h" +#include "llvm/Support/Error

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-03 Thread via lldb-commits
@@ -0,0 +1,154 @@ +//===-- SymbolFileDWARFDebugMapTests.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-03 Thread John Harrison via lldb-commits
ashgti wrote: > Can you add a `Thread` serialization/deserialization unit test? I added some unit tests but looking at this a bit more, I took some time to try a slightly different approach to validating the serialization logic. Specifically, using `roundtrip` and the individual asserts on eac

[Lldb-commits] [clang] [lldb] [llvm] [BOLT] Zero initialize pre-aggregated counters (PR #142698)

2025-06-03 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/142698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT] Zero initialize pre-aggregated counters (PR #142698)

2025-06-03 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/142698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Synchronize `__compressed_pair_padding` with libc++ (PR #142516)

2025-06-03 Thread Michael Buch via lldb-commits
@@ -72,14 +72,24 @@ inline const size_t __datasizeof_v = template struct __lldb_is_final : public integral_constant {}; -template class __compressed_pair_padding { - char __padding_[((is_empty<_ToPad>::value && -!__lldb_is_final<_ToPad>::value) || -

[Lldb-commits] [lldb] [lldb] Disable TestTargetWatchAddress.py on Windows x86_64 (PR #142573)

2025-06-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: We think all this needs is an updated expected message, but someone will have to confirm and it might be more complex. So I'm fine disabling this to not distract from getting the new bot online. https://github.com/llvm/llvm-project/pull/142573 _

<    1   2